mirror of
https://github.com/openai/codex.git
synced 2026-11-05 20:10:33 +00:00
fix(tui): annotate keymap literal arguments
Add argument comments to keymap-related TUI callsites that pass opaque literal values, keeping them compliant with the anonymous argument lint.
This commit is contained in:
@@ -1248,8 +1248,11 @@ mod tests {
|
||||
};
|
||||
|
||||
let view = make_overlay(exec_request, tx, Features::with_defaults());
|
||||
let mut buf = Buffer::empty(Rect::new(0, 0, 80, view.desired_height(80)));
|
||||
view.render(Rect::new(0, 0, 80, view.desired_height(80)), &mut buf);
|
||||
let mut buf = Buffer::empty(Rect::new(0, 0, 80, view.desired_height(/*width*/ 80)));
|
||||
view.render(
|
||||
Rect::new(0, 0, 80, view.desired_height(/*width*/ 80)),
|
||||
&mut buf,
|
||||
);
|
||||
|
||||
let rendered: Vec<String> = (0..buf.area.height)
|
||||
.map(|row| {
|
||||
@@ -1421,8 +1424,11 @@ mod tests {
|
||||
};
|
||||
|
||||
let view = make_overlay(exec_request, tx, Features::with_defaults());
|
||||
let mut buf = Buffer::empty(Rect::new(0, 0, 100, view.desired_height(100)));
|
||||
view.render(Rect::new(0, 0, 100, view.desired_height(100)), &mut buf);
|
||||
let mut buf = Buffer::empty(Rect::new(0, 0, 100, view.desired_height(/*width*/ 100)));
|
||||
view.render(
|
||||
Rect::new(0, 0, 100, view.desired_height(/*width*/ 100)),
|
||||
&mut buf,
|
||||
);
|
||||
|
||||
let rendered: Vec<String> = (0..buf.area.height)
|
||||
.map(|row| {
|
||||
|
||||
@@ -5089,11 +5089,11 @@ mod tests {
|
||||
let (tx, _rx) = unbounded_channel::<AppEvent>();
|
||||
let sender = AppEventSender::new(tx);
|
||||
let mut composer = ChatComposer::new(
|
||||
true,
|
||||
/*has_input_focus*/ true,
|
||||
sender,
|
||||
false,
|
||||
/*enhanced_keys_supported*/ false,
|
||||
"Ask Codex to do anything".to_string(),
|
||||
false,
|
||||
/*disable_paste_burst*/ false,
|
||||
);
|
||||
composer.set_steer_enabled(true);
|
||||
|
||||
|
||||
@@ -396,7 +396,7 @@ impl TextArea {
|
||||
}
|
||||
|
||||
if keymap.delete_backward.is_pressed(event) {
|
||||
self.delete_backward(1);
|
||||
self.delete_backward(/*n*/ 1);
|
||||
return;
|
||||
}
|
||||
if keymap.delete_forward_word.is_pressed(event) {
|
||||
@@ -404,7 +404,7 @@ impl TextArea {
|
||||
return;
|
||||
}
|
||||
if keymap.delete_forward.is_pressed(event) {
|
||||
self.delete_forward(1);
|
||||
self.delete_forward(/*n*/ 1);
|
||||
return;
|
||||
}
|
||||
if keymap.kill_line_start.is_pressed(event) {
|
||||
|
||||
@@ -198,23 +198,23 @@ impl KeyboardHandler for AuthModeWidget {
|
||||
}
|
||||
|
||||
if self.onboarding_keymap.move_up.is_pressed(key_event) {
|
||||
self.move_highlight(-1);
|
||||
self.move_highlight(/*delta*/ -1);
|
||||
return;
|
||||
}
|
||||
if self.onboarding_keymap.move_down.is_pressed(key_event) {
|
||||
self.move_highlight(1);
|
||||
self.move_highlight(/*delta*/ 1);
|
||||
return;
|
||||
}
|
||||
if self.onboarding_keymap.select_first.is_pressed(key_event) {
|
||||
self.select_option_by_index(0);
|
||||
self.select_option_by_index(/*index*/ 0);
|
||||
return;
|
||||
}
|
||||
if self.onboarding_keymap.select_second.is_pressed(key_event) {
|
||||
self.select_option_by_index(1);
|
||||
self.select_option_by_index(/*index*/ 1);
|
||||
return;
|
||||
}
|
||||
if self.onboarding_keymap.select_third.is_pressed(key_event) {
|
||||
self.select_option_by_index(2);
|
||||
self.select_option_by_index(/*index*/ 2);
|
||||
return;
|
||||
}
|
||||
if self.onboarding_keymap.confirm.is_pressed(key_event) {
|
||||
|
||||
@@ -206,7 +206,11 @@ mod tests {
|
||||
fn ctrl_shift_dot_changes_animation_variant() {
|
||||
let mut widget = WelcomeWidget {
|
||||
is_logged_in: false,
|
||||
animation: AsciiAnimation::with_variants(FrameRequester::test_dummy(), &VARIANTS, 0),
|
||||
animation: AsciiAnimation::with_variants(
|
||||
FrameRequester::test_dummy(),
|
||||
&VARIANTS,
|
||||
/*variant_idx*/ 0,
|
||||
),
|
||||
animations_enabled: true,
|
||||
animations_suppressed: Cell::new(false),
|
||||
toggle_animation_keys: crate::keymap::RuntimeKeymap::defaults()
|
||||
|
||||
@@ -767,7 +767,7 @@ impl StaticOverlay {
|
||||
keymap: PagerKeymap,
|
||||
) -> Self {
|
||||
Self {
|
||||
view: PagerView::new(renderables, title, 0, keymap),
|
||||
view: PagerView::new(renderables, title, /*scroll_offset*/ 0, keymap),
|
||||
is_done: false,
|
||||
}
|
||||
}
|
||||
@@ -1299,9 +1299,12 @@ mod tests {
|
||||
#[test]
|
||||
fn pager_view_content_height_counts_renderables() {
|
||||
let pv = pager_view(
|
||||
vec![paragraph_block("a", 2), paragraph_block("b", 3)],
|
||||
vec![
|
||||
paragraph_block("a", /*lines*/ 2),
|
||||
paragraph_block("b", /*lines*/ 3),
|
||||
],
|
||||
"T",
|
||||
0,
|
||||
/*scroll_offset*/ 0,
|
||||
);
|
||||
|
||||
assert_eq!(pv.content_height(/*width*/ 80), 5);
|
||||
@@ -1316,7 +1319,7 @@ mod tests {
|
||||
paragraph_block("c", /*lines*/ 3),
|
||||
],
|
||||
"T",
|
||||
0,
|
||||
/*scroll_offset*/ 0,
|
||||
);
|
||||
let area = Rect::new(0, 0, 20, 8);
|
||||
|
||||
@@ -1351,7 +1354,7 @@ mod tests {
|
||||
paragraph_block("c", /*lines*/ 3),
|
||||
],
|
||||
"T",
|
||||
0,
|
||||
/*scroll_offset*/ 0,
|
||||
);
|
||||
let area = Rect::new(0, 0, 20, 3);
|
||||
|
||||
@@ -1363,7 +1366,11 @@ mod tests {
|
||||
|
||||
#[test]
|
||||
fn pager_view_is_scrolled_to_bottom_accounts_for_wrapped_height() {
|
||||
let mut pv = pager_view(vec![paragraph_block("a", 10)], "T", 0);
|
||||
let mut pv = pager_view(
|
||||
vec![paragraph_block("a", /*lines*/ 10)],
|
||||
"T",
|
||||
/*scroll_offset*/ 0,
|
||||
);
|
||||
let area = Rect::new(0, 0, 20, 8);
|
||||
let mut buf = Buffer::empty(area);
|
||||
|
||||
|
||||
Reference in New Issue
Block a user