openai/codex
1
0
Fork 0
mirror of https://github.com/openai/codex.git synced 2026-09-08 15:50:34 +00:00
Code Issues Packages Projects Releases Wiki Activity

clarify test review wording

Browse Source
This commit is contained in:
Sayan Sisodiya
2026-05-04 11:21:25 -07:00
parent 4860c143de
commit 751c14c43f
1 changed files with 4 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
AGENTS.md
View File

@@ -110,10 +110,10 @@ See `codex-rs/tui/styles.md`.
When reviewing or adding tests:
- Ask whether the test makes sense.
- Ask whether it actually asserts something valuable that you care about.
- Ask how much the test would need to change if the surrounding system were refactored.
- Ask whether you or someone else would notice the regression if Codex auto-updated the test.
- Ask yourself whether the test makes sense.
- Ask yourself whether it actually asserts something valuable that you care about.
- Ask yourself how much the test would need to change if the surrounding system were refactored.
- Ask yourself whether you or someone else would notice the regression if Codex auto-updated the test.
If a unit test mostly covers deep implementation details, static data, removed behavior, or requires heavy monkeypatching, prefer deleting it and writing an integration test that protects meaningful end-to-end behavior instead.