mirror of
https://github.com/openai/codex.git
synced 2026-10-22 17:58:46 +00:00
windows sandbox: materialize setup helper for launch
This commit is contained in:
@@ -22,18 +22,21 @@ pub(crate) const RESOURCES_DIRNAME: &str = "codex-resources";
|
||||
#[derive(Clone, Copy, Debug, Eq, Hash, PartialEq)]
|
||||
pub(crate) enum HelperExecutable {
|
||||
CommandRunner,
|
||||
Setup,
|
||||
}
|
||||
|
||||
impl HelperExecutable {
|
||||
fn file_name(self) -> &'static str {
|
||||
match self {
|
||||
Self::CommandRunner => "codex-command-runner.exe",
|
||||
Self::Setup => "codex-windows-sandbox-setup.exe",
|
||||
}
|
||||
}
|
||||
|
||||
fn label(self) -> &'static str {
|
||||
match self {
|
||||
Self::CommandRunner => "command-runner",
|
||||
Self::Setup => "setup",
|
||||
}
|
||||
}
|
||||
}
|
||||
@@ -559,4 +562,11 @@ mod tests {
|
||||
|
||||
assert_eq!(file_name, "codex-command-runner-test-suffix.exe");
|
||||
}
|
||||
|
||||
#[test]
|
||||
fn setup_materialized_file_name_adds_suffix_before_extension() {
|
||||
let file_name = materialized_file_name(HelperExecutable::Setup, "test-suffix");
|
||||
|
||||
assert_eq!(file_name, "codex-windows-sandbox-setup-test-suffix.exe");
|
||||
}
|
||||
}
|
||||
|
||||
@@ -14,6 +14,8 @@ use crate::allow::AllowDenyPaths;
|
||||
use crate::allow::compute_allow_paths_for_permissions;
|
||||
use crate::helper_materialization::bundled_executable_path_for_exe;
|
||||
use crate::helper_materialization::helper_bin_dir;
|
||||
use crate::helper_materialization::resolve_helper_for_launch;
|
||||
use crate::helper_materialization::HelperExecutable;
|
||||
use crate::identity::sandbox_setup_is_complete;
|
||||
use crate::logging::current_log_file_path;
|
||||
use crate::logging::log_note;
|
||||
@@ -209,7 +211,7 @@ fn run_setup_refresh_inner(
|
||||
};
|
||||
let json = serde_json::to_vec(&payload)?;
|
||||
let b64 = BASE64_STANDARD.encode(json);
|
||||
let exe = find_setup_exe();
|
||||
let exe = resolve_setup_exe_for_launch(request.codex_home);
|
||||
let sbx_dir = sandbox_dir(request.codex_home);
|
||||
let log_path = current_log_file_path(&sbx_dir);
|
||||
let cleared_report = match clear_setup_error_report(request.codex_home) {
|
||||
@@ -671,6 +673,11 @@ fn find_setup_exe() -> PathBuf {
|
||||
PathBuf::from(SETUP_EXE_FILENAME)
|
||||
}
|
||||
|
||||
fn resolve_setup_exe_for_launch(codex_home: &Path) -> PathBuf {
|
||||
let sbx_dir = sandbox_dir(codex_home);
|
||||
resolve_helper_for_launch(HelperExecutable::Setup, codex_home, Some(&sbx_dir))
|
||||
}
|
||||
|
||||
fn find_setup_exe_for_current_exe(exe: &Path) -> Option<PathBuf> {
|
||||
bundled_executable_path_for_exe(exe, SETUP_EXE_FILENAME)
|
||||
}
|
||||
@@ -716,7 +723,7 @@ fn run_setup_exe(
|
||||
use windows_sys::Win32::UI::Shell::SEE_MASK_NOCLOSEPROCESS;
|
||||
use windows_sys::Win32::UI::Shell::SHELLEXECUTEINFOW;
|
||||
use windows_sys::Win32::UI::Shell::ShellExecuteExW;
|
||||
let exe = find_setup_exe();
|
||||
let exe = resolve_setup_exe_for_launch(codex_home);
|
||||
let payload_json = serde_json::to_string(payload).map_err(|err| {
|
||||
failure(
|
||||
SetupErrorCode::OrchestratorPayloadSerializeFailed,
|
||||
|
||||
Reference in New Issue
Block a user