openai/codex
1
0
Fork 0
mirror of https://github.com/openai/codex.git synced 2026-09-06 15:29:32 +00:00
Code Issues Packages Projects Releases Wiki Activity

Test stdio JSON-RPC size limits with LF and CRLF (#32134)

Browse Source 
## What changed

Update the exact-size-limit stdio connection test to exercise both `\n` and
`\r\n` line endings, sizing the duplex buffer for each delimiter.

GitOrigin-RevId: 949e28bef3f1a34d379f3623f6aa7d99c0ecea80
This commit is contained in:
jif
2026-07-10 10:47:24 +00:00
committed by copyberry
parent 0d1733b5e9
commit 707bd3cc18
1 changed files with 22 additions and 17 deletions
Download Patch File Download Diff File Expand all files Collapse all files

39
codex-rs/exec-server/src/connection.rs
View File

@@ -679,26 +679,31 @@ mod tests {
let message = test_jsonrpc_message();
let encoded = serde_json::to_string(&message)?;
let max_message_len = encoded.len();
let (reader, mut peer) = tokio::io::duplex(max_message_len.saturating_add(1));
let mut connection = JsonRpcConnection::from_stdio_with_max_message_len(
reader,
tokio::io::sink(),
"test stdio peer".to_string(),
max_message_len,
);
peer.write_all(encoded.as_bytes()).await?;
peer.write_all(b"\r\n").await?;
let event = timeout(Duration::from_secs(1), connection.incoming_rx.recv())
.await?
.expect("stdio connection should report the message");
match event {
JsonRpcConnectionEvent::Message(actual) => assert_eq!(actual, message),
event => anyhow::bail!("expected JSON-RPC message, got {event:?}"),
for line_ending in [b"\n".as_slice(), b"\r\n".as_slice()] {
let (reader, mut peer) =
tokio::io::duplex(max_message_len.saturating_add(line_ending.len()));
let mut connection = JsonRpcConnection::from_stdio_with_max_message_len(
reader,
tokio::io::sink(),
"test stdio peer".to_string(),
max_message_len,
);
peer.write_all(encoded.as_bytes()).await?;
peer.write_all(line_ending).await?;
let event = timeout(Duration::from_secs(1), connection.incoming_rx.recv())
.await?
.expect("stdio connection should report the message");
match event {
JsonRpcConnectionEvent::Message(actual) => assert_eq!(actual, message),
event => anyhow::bail!("expected JSON-RPC message, got {event:?}"),
}
drop(peer);
drop(connection);
}
drop(peer);
drop(connection);
Ok(())
}