openai/codex
1
0
Fork 0
mirror of https://github.com/openai/codex.git synced 2026-09-14 11:57:03 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix(linux-sandbox): mask missing deny_read paths

Browse Source
This commit is contained in:
viyatb-oai
2026-03-02 15:33:33 -08:00
parent 3e628641e5
commit 685883a321
1 changed files with 23 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

26
codex-rs/linux-sandbox/src/bwrap.rs
View File

@@ -334,9 +334,6 @@ fn apply_deny_read_overlays(
{
continue;
}
if !denied_path.exists() {
continue;
}
if !full_read_access {
let overlaps_visible_mounts = readable_roots
@@ -350,6 +347,8 @@ fn apply_deny_read_overlays(
}
}
// Default missing paths to a file-style mask so the deny rule still
// blocks the exact path if it appears later during the sandbox run.
let is_dir = std::fs::metadata(&denied_path)
.map(|metadata| metadata.is_dir())
.unwrap_or(false);
@@ -748,4 +747,25 @@ mod tests {
.any(|window| window == ["--ro-bind", "/dev/null", denied_file_str.as_str()])
);
}
#[test]
fn deny_read_overlays_mask_missing_paths() {
let temp_dir = TempDir::new().expect("temp dir");
let denied_file = temp_dir.path().join("secret.txt");
let policy = SandboxPolicy::ReadOnly {
access: ReadOnlyAccess::FullAccess,
deny_read_paths: vec![
AbsolutePathBuf::try_from(denied_file.as_path()).expect("absolute file"),
],
};
let args = create_filesystem_args(&policy, temp_dir.path()).expect("filesystem args");
let denied_file_str = path_to_string(&denied_file);
assert!(
args.windows(3)
.any(|window| window == ["--ro-bind", "/dev/null", denied_file_str.as_str()])
);
}
}