openai/codex
1
0
Fork 0
mirror of https://github.com/openai/codex.git synced 2026-09-08 15:50:34 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix(core): detect apps in explicit skill files

Browse Source
This commit is contained in:
Felipe Coury
2026-05-30 18:33:54 -03:00
parent 7ab2179c25
commit 5f044041af
1 changed files with 27 additions and 8 deletions
Download Patch File Download Diff File Expand all files Collapse all files

35
codex-rs/core/src/session/turn.rs
View File

@@ -507,7 +507,8 @@ async fn build_skills_and_plugins(
)
.await;
let structured_skill_may_reference_apps =
skill_injections_may_reference_apps(&skill_injections);
skill_injections_may_reference_apps(&skill_injections)
|| structured_skill_inputs_may_reference_apps(&structured_skill_input).await;
// Plain text skill mentions can collide with app slugs, so preserve their
// existing app-inventory resolution behavior.
let text_skill_input = user_input
@@ -739,13 +740,31 @@ async fn wait_for_explicit_mcp_servers(
fn skill_injections_may_reference_apps(
skill_injections: &[crate::injection::SkillInjection],
) -> bool {
skill_injections.iter().any(|skill| {
let mentions = extract_tool_mentions(&skill.contents);
mentions.plain_names().next().is_some()
|| mentions
.paths()
.any(|path| tool_kind_for_path(path) == ToolMentionKind::App)
})
skill_injections
.iter()
.any(|skill| skill_contents_may_reference_apps(&skill.contents))
}
async fn structured_skill_inputs_may_reference_apps(inputs: &[UserInput]) -> bool {
for input in inputs {
let UserInput::Skill { path, .. } = input else {
continue;
};
if let Ok(contents) = tokio::fs::read_to_string(path).await
&& skill_contents_may_reference_apps(&contents)
{
return true;
}
}
false
}
fn skill_contents_may_reference_apps(contents: &str) -> bool {
let mentions = extract_tool_mentions(contents);
mentions.plain_names().next().is_some()
|| mentions
.paths()
.any(|path| tool_kind_for_path(path) == ToolMentionKind::App)
}
async fn track_turn_resolved_config_analytics(