mirror of
https://github.com/openai/codex.git
synced 2026-11-01 19:33:35 +00:00
Simplify hooks experimental feature diff
This commit is contained in:
@@ -404,9 +404,6 @@
|
||||
"guardian_approval": {
|
||||
"type": "boolean"
|
||||
},
|
||||
"hooks": {
|
||||
"type": "boolean"
|
||||
},
|
||||
"image_detail_original": {
|
||||
"type": "boolean"
|
||||
},
|
||||
@@ -2375,9 +2372,6 @@
|
||||
"guardian_approval": {
|
||||
"type": "boolean"
|
||||
},
|
||||
"hooks": {
|
||||
"type": "boolean"
|
||||
},
|
||||
"image_detail_original": {
|
||||
"type": "boolean"
|
||||
},
|
||||
|
||||
@@ -9,10 +9,6 @@ struct Alias {
|
||||
}
|
||||
|
||||
const ALIASES: &[Alias] = &[
|
||||
Alias {
|
||||
legacy_key: "codex_hooks",
|
||||
feature: Feature::CodexHooks,
|
||||
},
|
||||
Alias {
|
||||
legacy_key: "connectors",
|
||||
feature: Feature::Apps,
|
||||
|
||||
@@ -740,7 +740,7 @@ pub const FEATURES: &[FeatureSpec] = &[
|
||||
},
|
||||
FeatureSpec {
|
||||
id: Feature::CodexHooks,
|
||||
key: "hooks",
|
||||
key: "codex_hooks",
|
||||
stage: Stage::Experimental {
|
||||
name: "Hooks",
|
||||
menu_description: "Run deterministic scripts during the Codex lifecycle",
|
||||
|
||||
@@ -120,22 +120,6 @@ fn external_migration_is_experimental_and_disabled_by_default() {
|
||||
assert_eq!(Feature::ExternalMigration.default_enabled(), false);
|
||||
}
|
||||
|
||||
#[test]
|
||||
fn hooks_is_experimental_and_user_toggleable() {
|
||||
let spec = Feature::CodexHooks.info();
|
||||
let stage = spec.stage;
|
||||
|
||||
assert_eq!(spec.key, "hooks");
|
||||
assert!(matches!(stage, Stage::Experimental { .. }));
|
||||
assert_eq!(stage.experimental_menu_name(), Some("Hooks"));
|
||||
assert_eq!(
|
||||
stage.experimental_menu_description(),
|
||||
Some("Run deterministic scripts during the Codex lifecycle")
|
||||
);
|
||||
assert_eq!(stage.experimental_announcement(), None);
|
||||
assert_eq!(Feature::CodexHooks.default_enabled(), false);
|
||||
}
|
||||
|
||||
#[test]
|
||||
fn request_permissions_is_under_development() {
|
||||
assert_eq!(
|
||||
@@ -263,12 +247,6 @@ fn collab_is_legacy_alias_for_multi_agent() {
|
||||
assert_eq!(feature_for_key("collab"), Some(Feature::Collab));
|
||||
}
|
||||
|
||||
#[test]
|
||||
fn codex_hooks_is_legacy_alias_for_hooks() {
|
||||
assert_eq!(feature_for_key("hooks"), Some(Feature::CodexHooks));
|
||||
assert_eq!(feature_for_key("codex_hooks"), Some(Feature::CodexHooks));
|
||||
}
|
||||
|
||||
#[test]
|
||||
fn multi_agent_is_stable_and_enabled_by_default() {
|
||||
assert_eq!(Feature::Collab.stage(), Stage::Stable);
|
||||
|
||||
-22
@@ -1,22 +0,0 @@
|
||||
---
|
||||
source: tui/src/chatwidget/tests/popups_and_settings.rs
|
||||
expression: popup
|
||||
---
|
||||
Experimental features
|
||||
Toggle experimental features. Changes are saved to config.toml.
|
||||
|
||||
› [ ] JavaScript REPL Enable a persistent Node-backed JavaScript REPL for interactive website debugging
|
||||
and other inline JavaScript execution capabilities. Requires Node >= v22.22.0
|
||||
installed.
|
||||
[ ] Memories Allow Codex to create new memories from conversations and bring relevant memories
|
||||
into new conversations.
|
||||
[ ] Hooks Run deterministic scripts during the Codex lifecycle
|
||||
[ ] External migration Show a startup prompt when Codex detects migratable external agent config for this
|
||||
machine or project.
|
||||
[ ] Auto-review When Codex needs approval for higher-risk actions (e.g. sandbox escapes or blocked
|
||||
network access), route eligible approval requests to a carefully-prompted security
|
||||
reviewer subagent rather than blocking the agent on your input. This can consume
|
||||
significantly more tokens because it runs a subagent on every approval request.
|
||||
[ ] Prevent sleep while running Keep your computer awake while Codex is running a thread.
|
||||
|
||||
Press space to select or enter to save for next conversation
|
||||
@@ -1682,16 +1682,6 @@ async fn experimental_features_popup_snapshot() {
|
||||
assert_chatwidget_snapshot!("experimental_features_popup", popup);
|
||||
}
|
||||
|
||||
#[tokio::test]
|
||||
async fn experimental_features_popup_from_registry_snapshot() {
|
||||
let (mut chat, _rx, _op_rx) = make_chatwidget_manual(/*model_override*/ None).await;
|
||||
|
||||
chat.open_experimental_popup();
|
||||
|
||||
let popup = render_bottom_popup(&chat, /*width*/ 120);
|
||||
assert_chatwidget_snapshot!("experimental_features_popup_from_registry", popup);
|
||||
}
|
||||
|
||||
#[tokio::test]
|
||||
async fn experimental_features_toggle_saves_on_exit() {
|
||||
let (mut chat, mut rx, _op_rx) = make_chatwidget_manual(/*model_override*/ None).await;
|
||||
|
||||
Reference in New Issue
Block a user