openai/codex
1
0
Fork 0
mirror of https://github.com/openai/codex.git synced 2026-09-07 15:40:00 +00:00
Code Issues Packages Projects Releases Wiki Activity

Isolate required-model Guardian approval coverage (#41322)

Browse Source 
## What changed

Update the Guardian v2 required-model-switch test to continue the thread with
empty input. This keeps authorization unchanged, so the test specifically
verifies that the required-model check prevents reuse of a cached approval for
the sandboxed command.

Continue asserting that a Guardian review starts and that the command skips a
second classification.

GitOrigin-RevId: 5ce914cb6e66f0527d9ec154331cc356104bfb72
This commit is contained in:
jif
2026-08-28 11:05:43 +00:00
committed by copyberry
parent a73bf25d17
commit 31d338a1ea
1 changed files with 9 additions and 10 deletions
Download Patch File Download Diff File Expand all files Collapse all files

19
codex-rs/app-server/tests/suite/v2/guardian_v2.rs
View File

@@ -1191,24 +1191,17 @@ async fn guardian_v2_routes_scoped_tool_approvals(
if matches!(lifecycle, ThreadLifecycle::RequiredModelSwitch) {
// Both MCP actions have low scores; the sandboxed exec must still receive full review.
timeout(TIMEOUT, responses_state.classification_completed.notified()).await?;
// Continue without new user input so authorization changes cannot invalidate the score.
// Only the required-model check should prevent cached approval of the sandboxed command.
let request_id = app_server
.send_turn_start_request(TurnStartParams {
thread_id: thread_id.clone(),
model: Some(REQUIRED_MODEL.to_owned()),
input: vec![UserInput::Text {
text: "Run the requested command.".to_owned(),
text_elements: Vec::new(),
}],
input: Vec::new(),
..Default::default()
})
.await?;
let _: TurnStartResponse = timeout(TIMEOUT, app_server.read_response(request_id)).await??;
let review_started: ItemGuardianApprovalReviewStartedNotification = timeout(
TIMEOUT,
app_server.read_notification("item/autoApprovalReview/started"),
)
.await??;
assert_eq!(review_started.thread_id, thread_id);
let completed: TurnCompletedNotification =
timeout(TIMEOUT, app_server.read_notification("turn/completed")).await??;
assert_eq!(completed.thread_id, thread_id);
@@ -1216,6 +1209,12 @@ async fn guardian_v2_routes_scoped_tool_approvals(
responses_state.guardian_reviews.load(Ordering::SeqCst),
expected_guardian_reviews + 1,
);
let review_started: ItemGuardianApprovalReviewStartedNotification = timeout(
TIMEOUT,
app_server.read_notification("item/autoApprovalReview/started"),
)
.await??;
assert_eq!(review_started.thread_id, thread_id);
assert_eq!(
responses_state
.luna_requests