openai/codex
1
0
Fork 0
mirror of https://github.com/openai/codex.git synced 2026-10-20 17:38:45 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix: centralize Guardian retry budget

Browse Source 
Co-authored-by: Codex noreply@openai.com
This commit is contained in:
viyatb-oai
2026-06-08 22:39:29 -07:00
co-authored by Codex noreply@openai.com
parent 3b7fc811e5
commit 255d2b881f
3 changed files with 6 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files
codex-rs/core/src/guardian/review.rs
+4 -1
View File
@@ -697,7 +697,10 @@ async fn run_guardian_review_session_with_retry(
.as_ref()
.is_some_and(CancellationToken::is_cancelled)
{
return (first_outcome, first_analytics_result);
return (
GuardianReviewOutcome::Error(GuardianReviewError::Cancelled),
first_analytics_result,
);
}
session
codex-rs/core/src/guardian/review_session.rs
+2
View File
@@ -920,6 +920,8 @@ pub(crate) fn build_guardian_review_session_config(
let mut guardian_config = parent_config.clone();
guardian_config.model = Some(active_model.to_string());
guardian_config.model_reasoning_effort = reasoning_effort;
guardian_config.model_provider.request_max_retries = Some(0);
guardian_config.model_provider.stream_max_retries = Some(0);
guardian_config.include_skill_instructions = false;
guardian_config.base_instructions = Some(
parent_config
codex-rs/core/tests/suite/guardian_review.rs
-1
View File
@@ -49,7 +49,6 @@ async fn guardian_retries_a_transient_reviewer_failure() -> Result<()> {
let sandbox_policy_for_config = sandbox_policy.clone();
let mut builder = test_codex().with_config(move |config| {
config.permissions.approval_policy = Constrained::allow_any(approval_policy);
config.model_provider.stream_max_retries = Some(0);
config
.set_legacy_sandbox_policy(sandbox_policy_for_config)
.expect("set sandbox policy");