codex: address PR review feedback (#29497)

This commit is contained in:
Adam Perry
2026-06-22 23:06:13 +00:00
parent 96d6717fc5
commit 2437634691
3 changed files with 6 additions and 4 deletions
+4 -2
View File
@@ -29,12 +29,14 @@ Safe: fixed non-publishing recipes only operate on the trusted checkout.
""",
)
# Cargo accepts `--manifest-path`, so these rules may target manifests outside
# this checkout. That flexibility is an accepted tradeoff for development.
prefix_rule(
pattern = ["cargo", ["build", "check", "clippy", "test"]],
decision = "allow",
justification = """
Needed: Cargo uses host registry, Git, and cache state.
Safe: these commands only build, check, lint, or test the trusted workspace.
Safe: these non-installing subcommands are standard development operations.
""",
)
@@ -43,7 +45,7 @@ prefix_rule(
decision = "allow",
justification = """
Needed: Nextest needs host runtime and nested sandboxes.
Safe: it only runs tests built from the trusted workspace.
Safe: it only runs tests and does not install or publish artifacts.
""",
)
@@ -7,7 +7,7 @@ import unittest
from unittest.mock import patch
FORMAT_SCRIPT_PATH = Path(__file__).with_name("format.py")
FORMAT_SCRIPT_PATH = Path(__file__).resolve().parent.parent / "format.py"
FORMAT_SCRIPT_SPEC = importlib.util.spec_from_file_location(
"codex_format_script",
FORMAT_SCRIPT_PATH,
@@ -7,7 +7,7 @@ import sys
import unittest
from unittest.mock import patch
sys.path.insert(0, str(Path(__file__).resolve().parent))
sys.path.insert(0, str(Path(__file__).resolve().parent.parent))
import setup_dev_execpolicy