openai/codex
1
0
Fork 0
mirror of https://github.com/openai/codex.git synced 2026-10-14 16:38:43 +00:00
Code Issues Packages Projects Releases Wiki Activity

Wait for thread idle in Guardian context budget tests (#47073)

Browse Source 
## Why

`TurnComplete` precedes active-turn cleanup, so injecting follow-up history immediately afterward can race with cleanup.

## What changed

Register the `ThreadIdle` lifecycle contributor in `review_preserves_user_instructions_until_request_budgeting` and wait for the thread to become idle after the initial and follow-up turns.

GitOrigin-RevId: 1ae6c80593a71d331c5c6ddf85bbe10822a68afe
This commit is contained in:
jif
2026-09-21 17:25:25 +00:00
committed by copyberry
parent f07aaf920b
commit 20cdcb0156
1 changed files with 8 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files
codex-rs/core/tests/suite/guardian_context_budget.rs
+8
View File
@@ -7,6 +7,7 @@ use codex_core::TurnInputRequest;
use codex_core::config::Constrained;
use codex_core::config::CurrentTimeReminderConfig;
use codex_core::config::RolloutBudgetConfig;
use codex_extension_api::ExtensionRegistryBuilder;
use codex_features::Feature;
use codex_protocol::config_types::ApprovalsReviewer;
use codex_protocol::models::ContentItem;
@@ -17,6 +18,7 @@ use codex_protocol::protocol::EventMsg;
use codex_protocol::protocol::Op;
use codex_protocol::protocol::ReviewDecision;
use codex_protocol::user_input::UserInput;
use core_test_support::ThreadIdle;
use core_test_support::responses;
use core_test_support::responses::ev_assistant_message;
use core_test_support::responses::ev_completed;
@@ -49,7 +51,10 @@ async fn review_preserves_user_instructions_until_request_budgeting(
"Guardian approval actions require host-native paths"
);
let server = responses::start_mock_server().await;
let mut extensions = ExtensionRegistryBuilder::new();
extensions.thread_lifecycle_contributor(Arc::new(ThreadIdle));
let test = test_codex()
.with_extensions(Arc::new(extensions.build()))
.with_model_info_override("gpt-5.6-luna", move |model| {
model.context_window = Some(window);
})
@@ -110,6 +115,8 @@ async fn review_preserves_user_instructions_until_request_budgeting(
"{padding}Run the requested echo command. You may edit scratch files only.{padding}"
);
test.submit_text_turn(&initial).await?;
// TurnComplete precedes active-turn cleanup; wait before injecting follow-up history.
ThreadIdle::wait(&test.codex).await;
// This whole message exceeds the old transcript allowance. A following
// restriction must still reach the reviewer, with the original source order.
let followup = format!("{padding}{padding}Keep all files private.{padding}{padding}");
@@ -136,6 +143,7 @@ async fn review_preserves_user_instructions_until_request_budgeting(
])
.await?;
test.submit_text_turn(restriction).await?;
ThreadIdle::wait(&test.codex).await;
}
let (compact_requests, requests): (Vec<_>, Vec<_>) = responses
.requests()