openai/codex
1
0
Fork 0
mirror of https://github.com/openai/codex.git synced 2026-08-23 13:09:46 +00:00
Code Issues Packages Projects Releases Wiki Activity

Tag Codex Apps protocol discovery metrics (#39058)

Browse Source 
## What changed

Add `server_kind=openai_codex_apps` to the
`codex.mcp.protocol_discovery` counter and its duration metric when protocol
discovery runs for the Codex Apps MCP server. Other MCP servers retain the
existing `mode` and `outcome` tags.

GitOrigin-RevId: aadbdc54642f2c103a9f1bab39308e962c115f75
This commit is contained in:
thomas
2026-08-17 19:13:09 +00:00
committed by copyberry
parent 796325f1e5
commit 14973840e0
1 changed files with 11 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

13
codex-rs/codex-mcp/src/rmcp_client.rs
View File

@@ -884,7 +884,12 @@ async fn start_server_task(
let initialize_result = client
.initialize(params, startup_timeout, send_elicitation)
.await;
record_protocol_discovery_metrics(client.protocol_mode(), started_at, &initialize_result);
record_protocol_discovery_metrics(
client.protocol_mode(),
is_codex_apps_mcp_server,
started_at,
&initialize_result,
);
let initialize_result = initialize_result.map_err(StartupOutcomeError::from)?;
let server_disables_tool_catalog_cache = initialize_result
@@ -961,6 +966,7 @@ async fn start_server_task(
fn record_protocol_discovery_metrics(
mode: McpProtocolMode,
is_codex_apps_mcp_server: bool,
started_at: Instant,
result: &Result<ServerPeerInfo>,
) {
@@ -977,7 +983,10 @@ fn record_protocol_discovery_metrics(
Ok(_) => "legacy",
Err(_) => "failure",
};
let tags = [("mode", mode), ("outcome", outcome)];
let mut tags = vec![("mode", mode), ("outcome", outcome)];
if is_codex_apps_mcp_server {
tags.push(("server_kind", "openai_codex_apps"));
}
let _ = metrics.counter("codex.mcp.protocol_discovery", /*inc*/ 1, &tags);
let _ = metrics.record_duration(
"codex.mcp.protocol_discovery.duration_ms",