app-server: use in-memory rollout path for detached review

This commit is contained in:
Michael Bolin
2026-02-12 14:53:34 -08:00
parent a4cc1a4a85
commit 0be91c3e24

View File

@@ -5152,10 +5152,13 @@ impl CodexMessageProcessor {
&mut self,
request_id: &ConnectionRequestId,
parent_thread_id: ThreadId,
parent_thread: Arc<CodexThread>,
review_request: ReviewRequest,
display_text: &str,
) -> std::result::Result<(), JSONRPCErrorError> {
let rollout_path =
let rollout_path = if let Some(path) = parent_thread.rollout_path() {
path
} else {
find_thread_path_by_id_str(&self.config.codex_home, &parent_thread_id.to_string())
.await
.map_err(|err| JSONRPCErrorError {
@@ -5167,7 +5170,8 @@ impl CodexMessageProcessor {
code: INVALID_REQUEST_ERROR_CODE,
message: format!("no rollout found for thread id {parent_thread_id}"),
data: None,
})?;
})?
};
let mut config = self.config.as_ref().clone();
if let Some(review_model) = &config.review_model {
@@ -5290,6 +5294,7 @@ impl CodexMessageProcessor {
.start_detached_review(
&request_id,
parent_thread_id,
parent_thread,
review_request,
display_text.as_str(),
)