mirror of
https://github.com/openai/codex.git
synced 2026-10-30 19:18:49 +00:00
Remove path-bearing fields from Guardian review analytics (#44352)
## What changed Replace full additional permission profiles with network-only metadata in Guardian reviewed actions, and remove the `program` field from `execve` analytics. Preserve absent and empty permission requests and the optional `network.enabled` value. ## Testing Add serialization tests for enabled and disabled network permissions, absent and empty permission requests, and an unset network permission value. GitOrigin-RevId: 9904e5f5bd6723d0c09fb423b4818cb8bf12d397
This commit is contained in:
@@ -511,7 +511,7 @@ pub(crate) fn guardian_reviewed_action(
|
||||
..
|
||||
} => GuardianReviewedAction::UnifiedExec {
|
||||
sandbox_permissions: *sandbox_permissions,
|
||||
additional_permissions: additional_permissions.clone(),
|
||||
additional_permissions: additional_permissions.as_ref().map(Into::into),
|
||||
tty: *tty,
|
||||
},
|
||||
GuardianApprovalRequest::WriteStdin { tty, .. } => {
|
||||
@@ -520,13 +520,11 @@ pub(crate) fn guardian_reviewed_action(
|
||||
#[cfg(unix)]
|
||||
GuardianApprovalRequest::Execve {
|
||||
source,
|
||||
program,
|
||||
additional_permissions,
|
||||
..
|
||||
} => GuardianReviewedAction::Execve {
|
||||
source: *source,
|
||||
program: program.clone(),
|
||||
additional_permissions: additional_permissions.clone(),
|
||||
additional_permissions: additional_permissions.as_ref().map(Into::into),
|
||||
},
|
||||
GuardianApprovalRequest::ApplyPatch { .. } => GuardianReviewedAction::ApplyPatch {},
|
||||
GuardianApprovalRequest::NetworkAccess { protocol, port, .. } => {
|
||||
|
||||
Reference in New Issue
Block a user