codex: address PR review feedback (#28463)

This commit is contained in:
Adam Perry
2026-06-16 18:01:32 +00:00
parent f3cd1ab379
commit 0143318fd6
+11 -11
View File
@@ -31,17 +31,6 @@ pub struct WineTestCommand {
env: Vec<(OsString, OsString)>,
}
/// Captured output and exit status from a Wine test command.
#[derive(Debug, PartialEq, Eq)]
pub struct WineCommandOutput {
/// Bytes captured from standard output.
pub stdout: Vec<u8>,
/// Bytes captured from standard error.
pub stderr: Vec<u8>,
/// Process exit code reported by the PTY backend.
pub exit_code: i32,
}
/// Owns a Wine process and its isolated wineserver.
///
/// Call [`Self::scope`] or [`Self::shutdown`] on every successful path. A
@@ -193,6 +182,17 @@ impl WineTestCommandContext {
}
}
/// Captured output and exit status from a Wine test command.
#[derive(Debug, PartialEq, Eq)]
pub struct WineCommandOutput {
/// Bytes captured from standard output.
pub stdout: Vec<u8>,
/// Bytes captured from standard error.
pub stderr: Vec<u8>,
/// Process exit code reported by the PTY backend.
pub exit_code: i32,
}
/// Builds a Wine command that joins the prefix exported by [`WineTestCommandContext`].
pub fn ambient_wine_command(executable: impl AsRef<OsStr>) -> Result<StdCommand> {
let runtime = WineRuntimePaths::from_runfiles()?;