add logging + friendly_name might be empty

.circleci/config.yml

@@ -0,0 +1,32 @@
+# Golang CircleCI 2.0 configuration file
+#
+# Check https://circleci.com/docs/2.0/language-go/ for more details
+version: 2
+jobs:
+  machinery:
+    docker:
+      - image: kerberos/base:91ab4d4
+    working_directory: /go/src/github.com/{{ORG_NAME}}/{{REPO_NAME}}
+    steps:
+      - checkout
+      - run: apt-get update && apt-get install -y --no-install-recommends libavcodec-dev libavformat-dev libswscale-dev libjpeg62-turbo-dev
+      - run: cd machinery && go mod download
+      - run: cd machinery && go test -v ./...
+      - run: cd machinery && go vet
+
+  ui:
+    docker:
+      - image: cimg/python:3.9.13-node
+    steps:
+      - checkout
+      - run: node --version
+      - run: cd ui && yarn
+      - run: cd ui && yarn test --passWithNoTests
+      - run: cd ui && yarn build
+
+workflows:
+  version: 2
+  build:
+    jobs:
+      - machinery
+      - ui

.devcontainer/Dockerfile

@@ -1,26 +1,2 @@
-FROM mcr.microsoft.com/devcontainers/go:1.25-trixie
-
-# Install node environment
-RUN apt-get update && \
-    apt-get install -y --no-install-recommends \
-    nodejs \
-    npm \
-    && rm -rf /var/lib/apt/lists/*
-
-# Install ffmpeg
-RUN apt-get update && \
-    apt-get install -y --no-install-recommends \
-    ffmpeg \
-    libavcodec-extra \
-    libavutil-dev \
-    libavformat-dev \
-    libavfilter-dev \
-    libavdevice-dev \
-    libswscale-dev \
-    libswresample-dev \
-    && rm -rf /var/lib/apt/lists/*
-
-USER vscode
-
-# Install go swagger
-RUN go install github.com/swaggo/swag/cmd/swag@latest
+FROM kerberos/devcontainer:b2bc659
+LABEL AUTHOR=Kerberos.io

.devcontainer/devcontainer.json

@@ -1,24 +1,33 @@
-// For format details, see https://aka.ms/devcontainer.json. For config options, see the
-// README at: https://github.com/devcontainers/templates/tree/main/src/python
+// For format details, see https://aka.ms/devcontainer.json. For config options, see the README at:
+// https://github.com/microsoft/vscode-dev-containers/tree/v0.245.2/containers/docker-existing-dockerfile
 {
-	"name": "go:1.24-trixie",
-	"runArgs": [
-		"--name=agent",
-		"--network=host"
+	"name": "A Dockerfile containing FFmpeg, OpenCV, Go and Yarn",
+	// Sets the run context to one level up instead of the .devcontainer folder.
+	"context": "..",
+	// Update the 'dockerFile' property if you aren't using the standard 'Dockerfile' filename.
+	"dockerFile": "./Dockerfile",
+	// Use 'forwardPorts' to make a list of ports inside the container available locally.
+	"forwardPorts": [
+		3000,
+		80
 	],
-	"dockerFile": "Dockerfile",
+	// Uncomment the next line to run commands after the container is created - for example installing curl.
+	"postCreateCommand": "cd ui && yarn install && yarn build && cd ../machinery && go mod download",
+	"features": {
+		"ghcr.io/devcontainers-contrib/features/ansible:1": {}
+	},
 	"customizations": {
 		"vscode": {
 			"extensions": [
-				"GitHub.copilot",
-				"ms-azuretools.vscode-docker",
-				"mongodb.mongodb-vscode"
+				"ms-kubernetes-tools.vscode-kubernetes-tools",
+				"GitHub.copilot"
 			]
 		}
 	},
-	"forwardPorts": [
-		3000,
-		8080
-	],
-	"postCreateCommand": "cd ui && yarn install && yarn build && cd ../machinery && go mod download && bash ./verify-moq-devcontainer.sh"
+	// Uncomment when using a ptrace-based debugger like C++, Go, and Rust
+	// "runArgs": [ "--cap-add=SYS_PTRACE", "--security-opt", "seccomp=unconfined" ],
+	// Uncomment to use the Docker CLI from inside the container. See https://aka.ms/vscode-remote/samples/docker-from-docker.
+	// "mounts": [ "source=/var/run/docker.sock,target=/var/run/docker.sock,type=bind" ],
+	// Uncomment to connect as a non-root user if you've added one. See https://aka.ms/vscode-remote/containers/non-root.
+	// "remoteUser": "vscode"
 }

.github/workflows/docker-dev.yml

@@ -0,0 +1,58 @@
+name: Docker development build
+
+on:
+  push:
+    branches: [ develop ]
+
+jobs:
+  build-amd64:
+    runs-on: ubuntu-latest
+    strategy:
+      matrix:
+        architecture: [amd64]
+    steps:
+    - name: Login to DockerHub
+      uses: docker/login-action@v2
+      with:
+        username: ${{ secrets.DOCKERHUB_USERNAME }}
+        password: ${{ secrets.DOCKERHUB_TOKEN }}
+    - name: Checkout
+      uses: actions/checkout@v3
+    - name: Set up QEMU
+      uses: docker/setup-qemu-action@v2
+    - name: Set up Docker Buildx
+      uses: docker/setup-buildx-action@v2
+    - name: Available platforms
+      run: echo ${{ steps.buildx.outputs.platforms }}
+    - name: Run Buildx
+      run: docker buildx build --platform linux/${{matrix.architecture}} -t kerberos/agent-dev:arch-$(echo ${{matrix.architecture}} | tr / -)-$(echo $GITHUB_SHA | cut -c1-7) --push . 
+    - name: Create new and append to manifest
+      run: docker buildx imagetools create -t kerberos/agent-dev:$(echo $GITHUB_SHA | cut -c1-7) kerberos/agent-dev:arch-$(echo ${{matrix.architecture}} | tr / -)-$(echo $GITHUB_SHA | cut -c1-7)
+    - name: Create new and append to latest manifest
+      run: docker buildx imagetools create -t kerberos/agent-dev:latest kerberos/agent-dev:arch-$(echo ${{matrix.architecture}} | tr / -)-$(echo $GITHUB_SHA | cut -c1-7)
+  build-other:
+    runs-on: ubuntu-latest
+    strategy:
+      matrix:
+        #architecture: [arm64, arm/v7, arm/v6]
+        architecture: [arm64, arm/v7]
+    steps:
+    - name: Login to DockerHub
+      uses: docker/login-action@v2
+      with:
+        username: ${{ secrets.DOCKERHUB_USERNAME }}
+        password: ${{ secrets.DOCKERHUB_TOKEN }}
+    - name: Checkout
+      uses: actions/checkout@v3
+    - name: Set up QEMU
+      uses: docker/setup-qemu-action@v2
+    - name: Set up Docker Buildx
+      uses: docker/setup-buildx-action@v2
+    - name: Available platforms
+      run: echo ${{ steps.buildx.outputs.platforms }}
+    - name: Run Buildx
+      run: docker buildx build --platform linux/${{matrix.architecture}} -t kerberos/agent-dev:arch-$(echo ${{matrix.architecture}} | tr / -)-$(echo $GITHUB_SHA | cut -c1-7) --push . 
+    - name: Create new and append to manifest
+      run: docker buildx imagetools create --append -t kerberos/agent-dev:$(echo $GITHUB_SHA | cut -c1-7) kerberos/agent-dev:arch-$(echo ${{matrix.architecture}} | tr / -)-$(echo $GITHUB_SHA | cut -c1-7)
+    - name: Create new and append to manifest latest
+      run: docker buildx imagetools create --append -t kerberos/agent-dev:latest kerberos/agent-dev:arch-$(echo ${{matrix.architecture}} | tr / -)-$(echo $GITHUB_SHA | cut -c1-7)

.github/workflows/docker-nightly.yml

@@ -0,0 +1,54 @@
+name: Docker nightly build
+
+on:
+  # Triggers the workflow every day at 9PM (CET).
+  schedule:
+    - cron: "0 22 * * *"
+
+jobs:
+  build-amd64:
+      runs-on: ubuntu-latest
+      strategy:
+        matrix:
+          architecture: [amd64]
+      steps:
+      - name: Login to DockerHub
+        uses: docker/login-action@v2
+        with:
+          username: ${{ secrets.DOCKERHUB_USERNAME }}
+          password: ${{ secrets.DOCKERHUB_TOKEN }}
+      - name: Checkout
+        uses: actions/checkout@v3
+      - name: Set up QEMU
+        uses: docker/setup-qemu-action@v2
+      - name: Set up Docker Buildx
+        uses: docker/setup-buildx-action@v2
+      - name: Available platforms
+        run: echo ${{ steps.buildx.outputs.platforms }}
+      - name: Run Buildx
+        run: docker buildx build --platform linux/${{matrix.architecture}} -t kerberos/agent-nightly:arch-$(echo ${{matrix.architecture}} | tr / -)-$(echo $GITHUB_SHA | cut -c1-7) --push . 
+      - name: Create new and append to manifest
+        run: docker buildx imagetools create -t kerberos/agent-nightly:$(echo $GITHUB_SHA | cut -c1-7) kerberos/agent-nightly:arch-$(echo ${{matrix.architecture}} | tr / -)-$(echo $GITHUB_SHA | cut -c1-7)
+  build-other:
+    runs-on: ubuntu-latest
+    strategy:
+      matrix:
+        architecture: [arm64, arm/v7, arm/v6]
+    steps:
+    - name: Login to DockerHub
+      uses: docker/login-action@v2
+      with:
+        username: ${{ secrets.DOCKERHUB_USERNAME }}
+        password: ${{ secrets.DOCKERHUB_TOKEN }}
+    - name: Checkout
+      uses: actions/checkout@v3
+    - name: Set up QEMU
+      uses: docker/setup-qemu-action@v2
+    - name: Set up Docker Buildx
+      uses: docker/setup-buildx-action@v2
+    - name: Available platforms
+      run: echo ${{ steps.buildx.outputs.platforms }}
+    - name: Run Buildx
+      run: docker buildx build --platform linux/${{matrix.architecture}} -t kerberos/agent-nightly:arch-$(echo ${{matrix.architecture}} | tr / -)-$(echo $GITHUB_SHA | cut -c1-7) --push . 
+    - name: Create new and append to manifest
+      run: docker buildx imagetools create --append -t kerberos/agent-nightly:$(echo $GITHUB_SHA | cut -c1-7) kerberos/agent-nightly:arch-$(echo ${{matrix.architecture}} | tr / -)-$(echo $GITHUB_SHA | cut -c1-7)

.github/workflows/docker.yml

@@ -0,0 +1,114 @@
+name: Docker master build
+
+on:
+  push:
+    branches: [ master ]
+
+env:
+  REPO: kerberos/agent
+  
+jobs:
+  build-amd64:
+    runs-on: ubuntu-latest
+    permissions:
+      contents: write
+    strategy:
+      matrix:
+        architecture: [amd64]
+    steps:
+      - name: Login to DockerHub
+        uses: docker/login-action@v2
+        with:
+          username: ${{ secrets.DOCKERHUB_USERNAME }}
+          password: ${{ secrets.DOCKERHUB_TOKEN }}
+      - name: Checkout
+        uses: actions/checkout@v3
+      - uses: benjlevesque/short-sha@v2.1
+        id: short-sha
+        with:
+          length: 7
+      - name: Set up QEMU
+        uses: docker/setup-qemu-action@v2
+      - name: Set up Docker Buildx
+        uses: docker/setup-buildx-action@v2
+      - name: Available platforms
+        run: echo ${{ steps.buildx.outputs.platforms }}
+      - name: Run Buildx
+        run: docker buildx build --platform linux/$(echo ${{matrix.architecture}} | tr - /) -t $REPO-arch:arch-${{matrix.architecture}}-${{steps.short-sha.outputs.sha}} --push . 
+      - name: Create new and append to manifest
+        run: docker buildx imagetools create -t $REPO:${{ steps.short-sha.outputs.sha }} $REPO-arch:arch-${{matrix.architecture}}-${{steps.short-sha.outputs.sha}}
+      - name: Create new and append to manifest latest
+        run: docker buildx imagetools create -t $REPO:latest $REPO-arch:arch-${{matrix.architecture}}-${{steps.short-sha.outputs.sha}}
+      - name: Run Buildx with output
+        run: docker buildx build --platform linux/$(echo ${{matrix.architecture}} | tr - /) -t $REPO-arch:arch-$(echo ${{matrix.architecture}} | tr / -)-${{steps.short-sha.outputs.sha}} --output type=tar,dest=output-${{matrix.architecture}}.tar . 
+      - name: Strip binary
+        run: mkdir -p output/ && tar -xf output-${{matrix.architecture}}.tar -C output && rm output-${{matrix.architecture}}.tar && cd output/ && tar -cf ../agent-${{matrix.architecture}}.tar -C home/agent . && rm -rf output
+      # We'll make a GitHub release and push the build (tar) as an artifact
+      - uses: rickstaa/action-create-tag@v1
+        with:
+          tag: ${{ steps.short-sha.outputs.sha }}
+          message: "Release ${{ steps.short-sha.outputs.sha }}"
+      - name: Create a release  
+        uses: ncipollo/release-action@v1
+        with:
+          latest: true
+          name: ${{ steps.short-sha.outputs.sha }}
+          tag: ${{ steps.short-sha.outputs.sha }}
+          artifacts: "agent-${{matrix.architecture}}.tar"
+      # Taken from GoReleaser's own release workflow.
+      # The available Snapcraft Action has some bugs described in the issue below.
+      # The mkdirs are a hack for https://github.com/goreleaser/goreleaser/issues/1715.
+      #- name: Setup Snapcraft
+      #  run: |
+      #    sudo apt-get update
+      #    sudo apt-get -yq --no-install-suggests --no-install-recommends install snapcraft
+      #    mkdir -p $HOME/.cache/snapcraft/download
+      #    mkdir -p $HOME/.cache/snapcraft/stage-packages
+      #- name: Use Snapcraft
+      #  run: tar -xf agent-${{matrix.architecture}}.tar && snapcraft 
+  build-other:
+    runs-on: ubuntu-latest
+    permissions:
+      contents: write
+    needs: build-amd64
+    strategy:
+      matrix:
+        architecture: [arm64, arm-v7, arm-v6]
+        #architecture: [arm64, arm-v7]
+    steps:
+    - name: Login to DockerHub
+      uses: docker/login-action@v2
+      with:
+        username: ${{ secrets.DOCKERHUB_USERNAME }}
+        password: ${{ secrets.DOCKERHUB_TOKEN }}
+    - name: Checkout
+      uses: actions/checkout@v3
+    - uses: benjlevesque/short-sha@v2.1
+      id: short-sha
+      with:
+        length: 7
+    - name: Set up QEMU
+      uses: docker/setup-qemu-action@v2
+    - name: Set up Docker Buildx
+      uses: docker/setup-buildx-action@v2
+    - name: Available platforms
+      run: echo ${{ steps.buildx.outputs.platforms }}
+    - name: Run Buildx
+      run: docker buildx build --platform linux/$(echo ${{matrix.architecture}} | tr - /) -t $REPO-arch:arch-${{matrix.architecture}}-${{steps.short-sha.outputs.sha}} --push . 
+    - name: Create new and append to manifest
+      run: docker buildx imagetools create --append -t $REPO:${{ steps.short-sha.outputs.sha }} $REPO-arch:arch-${{matrix.architecture}}-${{steps.short-sha.outputs.sha}}
+    - name: Create new and append to manifest latest
+      run: docker buildx imagetools create --append -t $REPO:latest $REPO-arch:arch-${{matrix.architecture}}-${{steps.short-sha.outputs.sha}}
+    - name: Run Buildx with output
+      run: docker buildx build --platform linux/$(echo ${{matrix.architecture}} | tr - /) -t $REPO-arch:arch-$(echo ${{matrix.architecture}} | tr / -)-${{steps.short-sha.outputs.sha}} --output type=tar,dest=output-${{matrix.architecture}}.tar . 
+    - name: Strip binary
+      run: mkdir -p output/ && tar -xf output-${{matrix.architecture}}.tar -C output && rm output-${{matrix.architecture}}.tar && cd output/ && tar -cf ../agent-${{matrix.architecture}}.tar -C home/agent . && rm -rf output
+    - name: Create a release  
+      uses: ncipollo/release-action@v1
+      with:
+        latest: true
+        allowUpdates: true
+        name: ${{ steps.short-sha.outputs.sha }}
+        tag: ${{ steps.short-sha.outputs.sha }}
+        artifacts: "agent-${{matrix.architecture}}.tar"
+  

.github/workflows/go.yml

@@ -2,39 +2,35 @@ name: Go
 
 on:
   push:
-    branches: [develop, master]
+    branches: [ develop, master ]
   pull_request:
-    branches: [develop, master]
+    branches: [ develop, master ]
 
 jobs:
+
   build:
     name: Build
     runs-on: ubuntu-latest
     container:
-      image: kerberos/base:eb6b088
+      image: kerberos/base:70d69dc
+
 
     strategy:
       matrix:
-        #No longer supported Go versions.
-        #go-version: ['1.17', '1.18', '1.19', '1.20', '1.21']
-        go-version: ["1.25.0"]
+        go-version: [1.17, 1.18, 1.19]
 
     steps:
-      - name: Check out code into the Go module directory
-        uses: actions/checkout@v4
-      - name: Set up Go ${{ matrix.go-version }}
-        uses: actions/setup-go@v5
-        with:
-          go-version: ${{ matrix.go-version }}
-          cache: true
-          cache-dependency-path: machinery/go.sum
-      - name: Set up git ownershi
-        run: git config --system --add safe.directory /__w/agent/agent
-      - name: Get dependencies
-        run: cd machinery && go mod download
-      - name: Build
-        run: cd machinery && go build -v ./...
-      - name: Vet
-        run: cd machinery && go vet -v ./...
-      - name: Test
-        run: cd machinery && go test -v ./...
+    - name: Set up Go ${{ matrix.go-version }}
+      uses: actions/setup-go@v2
+      with:
+        go-version: ${{ matrix.go-version }}
+    - name: Check out code into the Go module directory
+      uses: actions/checkout@v3
+    - name: Get dependencies
+      run: cd machinery && go mod download
+    - name: Build
+      run: cd machinery && go build -v ./...
+    - name: Vet
+      run: cd machinery && go vet -v ./...
+    - name: Test
+      run: cd machinery && go test -v ./...

.github/workflows/issue-userstory-create.yml

@@ -1,51 +0,0 @@
-name: Create User Story Issue
-on:
-  workflow_dispatch:
-    inputs:
-      issue_title:
-        description: 'Title for the issue'
-        required: true
-      issue_description:
-        description: 'Brief description of the feature'
-        required: true
-      complexity:
-        description: 'Complexity of the feature'
-        required: true
-        type: choice
-        options:
-          - 'Low'
-          - 'Medium'
-          - 'High'
-        default: 'Medium'
-      duration:
-        description: 'Estimated duration'
-        required: true
-        type: choice
-        options:
-          - '1 day'
-          - '3 days'
-          - '1 week'
-          - '2 weeks'
-          - '1 month'
-        default: '1 week'
-
-jobs:
-  create-issue:
-    runs-on: ubuntu-latest
-    permissions:
-      issues: write
-    steps:
-      - name: Create Issue with User Story
-        uses: cedricve/llm-create-issue-user-story@main
-        with:
-          github_token: ${{ secrets.GITHUB_TOKEN }}
-          azure_openai_api_key: ${{ secrets.AZURE_OPENAI_API_KEY }}
-          azure_openai_endpoint: ${{ secrets.AZURE_OPENAI_ENDPOINT }}
-          azure_openai_version: ${{ secrets.AZURE_OPENAI_VERSION }}
-          openai_model: ${{ secrets.OPENAI_MODEL }}
-          issue_title: ${{ github.event.inputs.issue_title }}
-          issue_description: ${{ github.event.inputs.issue_description }}
-          complexity: ${{ github.event.inputs.complexity }}
-          duration: ${{ github.event.inputs.duration }}
-          labels: 'user-story,feature'
-          assignees: ${{ github.actor }}

.github/workflows/nightly-build.yml

@@ -1,62 +0,0 @@
-name: Nightly build
-
-on:
-  # Triggers the workflow every day at 9PM (CET).
-  schedule:
-    - cron: "0 22 * * *"
-  # Allows manual triggering from the Actions tab.
-  workflow_dispatch:
-
-jobs:
-  nightly-build-amd64:
-    runs-on: ubuntu-latest
-    strategy:
-      matrix:
-        architecture: [amd64]
-    steps:
-      - name: Login to DockerHub
-        uses: docker/login-action@v3
-        with:
-          username: ${{ secrets.DOCKER_USERNAME }}
-          password: ${{ secrets.DOCKER_PASSWORD }}
-      - name: Checkout
-        uses: actions/checkout@v4
-        with:
-          ref: master
-      - name: Set up QEMU
-        uses: docker/setup-qemu-action@v3
-      - name: Set up Docker Buildx
-        id: buildx
-        uses: docker/setup-buildx-action@v3
-      - name: Available platforms
-        run: echo ${{ steps.buildx.outputs.platforms }}
-      - name: Run Buildx
-        run: docker buildx build --build-arg VERSION=$(echo $GITHUB_SHA | cut -c1-7) --platform linux/${{matrix.architecture}} -t kerberos/agent-nightly:arch-$(echo ${{matrix.architecture}} | tr / -)-$(echo $GITHUB_SHA | cut -c1-7) --push .
-      - name: Create new and append to manifest
-        run: docker buildx imagetools create -t kerberos/agent-nightly:$(echo $GITHUB_SHA | cut -c1-7) kerberos/agent-nightly:arch-$(echo ${{matrix.architecture}} | tr / -)-$(echo $GITHUB_SHA | cut -c1-7)
-  nightly-build-other:
-    runs-on: ubuntu-latest
-    strategy:
-      matrix:
-        architecture: [arm64, arm/v7, arm/v6]
-    steps:
-      - name: Login to DockerHub
-        uses: docker/login-action@v3
-        with:
-          username: ${{ secrets.DOCKER_USERNAME }}
-          password: ${{ secrets.DOCKER_PASSWORD }}
-      - name: Checkout
-        uses: actions/checkout@v4
-        with:
-          ref: master
-      - name: Set up QEMU
-        uses: docker/setup-qemu-action@v3
-      - name: Set up Docker Buildx
-        id: buildx
-        uses: docker/setup-buildx-action@v3
-      - name: Available platforms
-        run: echo ${{ steps.buildx.outputs.platforms }}
-      - name: Run Buildx
-        run: docker buildx build --build-arg VERSION=$(echo $GITHUB_SHA | cut -c1-7) --platform linux/${{matrix.architecture}} -t kerberos/agent-nightly:arch-$(echo ${{matrix.architecture}} | tr / -)-$(echo $GITHUB_SHA | cut -c1-7) --push .
-      - name: Create new and append to manifest
-        run: docker buildx imagetools create --append -t kerberos/agent-nightly:$(echo $GITHUB_SHA | cut -c1-7) kerberos/agent-nightly:arch-$(echo ${{matrix.architecture}} | tr / -)-$(echo $GITHUB_SHA | cut -c1-7)

.github/workflows/pr-build.yml

@@ -1,41 +0,0 @@
-name: Build pull request
-on:
-  pull_request:
-    types: [opened, synchronize]
-
-env:
-  REPO: kerberos/agent
-
-jobs:
-  build:
-    runs-on: ${{ matrix.runner }}
-    permissions:
-      contents: write
-    strategy:
-      matrix:
-        include:
-          - architecture: amd64
-            runner: ubuntu-24.04
-          - architecture: arm64
-            runner: ubuntu-24.04-arm
-    steps:
-      - name: Checkout
-        uses: actions/checkout@v4
-      - name: Login to DockerHub
-        uses: docker/login-action@v3
-        with:
-          username: ${{ secrets.DOCKER_USERNAME }}
-          password: ${{ secrets.DOCKER_PASSWORD }}
-      - name: Run Build
-        run: |
-          docker build --build-arg VERSION=$(echo "${{ github.event.pull_request.head.sha }}" | cut -c1-7) -t ${{ matrix.architecture }} .
-          CID=$(docker create ${{matrix.architecture}})
-          docker cp ${CID}:/home/agent ./output-${{matrix.architecture}}
-          docker rm ${CID}
-      - name: Strip binary
-        run: tar -cf agent-${{matrix.architecture}}.tar -C output-${{matrix.architecture}} . && rm -rf output-${{matrix.architecture}}
-      - name: Upload artifact
-        uses: actions/upload-artifact@v4
-        with:
-          name: agent-${{matrix.architecture}}.tar
-          path: agent-${{matrix.architecture}}.tar

.github/workflows/pr-description.yaml

@@ -1,17 +0,0 @@
-name: Autofill PR description
-
-on: pull_request
-
-jobs:
-  openai-pr-description:
-    uses: uug-ai/workflows/.github/workflows/pr-description.yml@main
-    with:
-      pr_number: ${{ github.event.number }}
-      pull_request_url: ""
-      overwrite_description: true
-    secrets:
-      TOKEN: ${{ secrets.TOKEN }}
-      AZURE_OPENAI_API_KEY: ${{ secrets.AZURE_OPENAI_API_KEY }}
-      OPENAI_MODEL: ${{ secrets.OPENAI_MODEL }}
-      AZURE_OPENAI_ENDPOINT: ${{ secrets.AZURE_OPENAI_ENDPOINT }}
-      AZURE_OPENAI_VERSION: ${{ secrets.AZURE_OPENAI_VERSION }}

.github/workflows/react.yml

@@ -11,22 +11,21 @@ on:
 
 jobs:
   build:
+
     runs-on: ubuntu-latest
 
     strategy:
       matrix:
-        node-version: [22.x]
+        node-version: [14.x, 16.x]
 
     steps:
-    - uses: actions/checkout@v4
+    - uses: actions/checkout@v2
     - name: Use Node.js ${{ matrix.node-version }}
-      uses: actions/setup-node@v4
+      uses: actions/setup-node@v2
       with:
         node-version: ${{ matrix.node-version }}
-        cache: yarn
-        cache-dependency-path: ui/yarn.lock
     - name: Yarn install
-      run: cd ui && yarn --frozen-lockfile
+      run: cd ui && yarn
     - name: Yarn test
       run: cd ui && yarn test --passWithNoTests
     - name: Yarn build

.github/workflows/release-bump.yml

@@ -1,160 +0,0 @@
-name: Bump release
-
-on:
-  workflow_dispatch:
-    inputs:
-      bump:
-        description: "Which part of the version to bump"
-        required: true
-        default: patch
-        type: choice
-        options:
-          - major
-          - minor
-          - patch
-
-permissions:
-  contents: write
-
-env:
-  REPO: kerberos/agent
-
-jobs:
-  # Determine the next version, create the GitHub release and expose the tag.
-  bump-release:
-    uses: uug-ai/workflows/.github/workflows/release-bump.yml@main
-    with:
-      bump: ${{ github.event.inputs.bump }}
-    secrets: inherit
-
-  # Publish the platform image to the uug-ai GitHub Container Registry
-  # (ghcr.io/uug-ai/agent-platform).
-  #release:
-  #  needs: bump-release
-  #  uses: uug-ai/workflows/.github/workflows/release-create.yml@main
-  #  with:
-  #    organization: uug-ai
-  #    project: ${{ github.event.repository.name }}
-  #    tag: ${{ needs.bump-release.outputs.tag }}
-  #    docker_context: "."
-  #    create_gitops_pr: false
-  #    runner_matrix: >-
-  #       [
-  #         {"architecture":"amd64","runner":"ubuntu-24.04"},
-  #         {"architecture":"arm64","runner":"ubuntu-24.04-arm"}
-  #      ]
-  #  secrets: inherit
-
-  # Everything below mirrors the agent's own release-create.yml pipeline and
-  # publishes the multi-arch image to the kerberos/agent Docker Hub repo, driven
-  # by the freshly bumped tag instead of a `release: created` event.
-  build-amd64:
-    needs: bump-release
-    runs-on: ubuntu-24.04
-    permissions:
-      contents: write
-    strategy:
-      matrix:
-        architecture: [amd64]
-    steps:
-      - name: Login to DockerHub
-        uses: docker/login-action@v3
-        with:
-          username: ${{ secrets.DOCKER_USERNAME }}
-          password: ${{ secrets.DOCKER_PASSWORD }}
-      - name: Checkout
-        uses: actions/checkout@v4
-      - name: Run Build
-        run: |
-          docker build --provenance=false --build-arg VERSION=${{ needs.bump-release.outputs.tag }} -t ${{matrix.architecture}} .
-          CID=$(docker create ${{matrix.architecture}})
-          docker cp ${CID}:/home/agent ./output-${{matrix.architecture}}
-          docker rm ${CID}
-      - name: Strip binary
-        run: tar -cf agent-${{matrix.architecture}}.tar -C output-${{matrix.architecture}} . && rm -rf output-${{matrix.architecture}}
-      - name: Build and push Docker image
-        run: |
-          docker tag ${{matrix.architecture}} $REPO-arch:arch-${{matrix.architecture}}-${{ needs.bump-release.outputs.tag }}
-          docker push $REPO-arch:arch-${{matrix.architecture}}-${{ needs.bump-release.outputs.tag }}
-      - name: Upload artifact
-        uses: actions/upload-artifact@v4
-        with:
-          name: agent-${{matrix.architecture}}.tar
-          path: agent-${{matrix.architecture}}.tar
-
-  build-arm64:
-    needs: bump-release
-    runs-on: ubuntu-24.04-arm
-    permissions:
-      contents: write
-    strategy:
-      matrix:
-        architecture: [arm64]
-    steps:
-      - name: Login to DockerHub
-        uses: docker/login-action@v3
-        with:
-          username: ${{ secrets.DOCKER_USERNAME }}
-          password: ${{ secrets.DOCKER_PASSWORD }}
-      - name: Checkout
-        uses: actions/checkout@v4
-      - name: Run Build
-        run: |
-          docker build --provenance=false --build-arg VERSION=${{ needs.bump-release.outputs.tag }} -t ${{matrix.architecture}} .
-          CID=$(docker create ${{matrix.architecture}})
-          docker cp ${CID}:/home/agent ./output-${{matrix.architecture}}
-          docker rm ${CID}
-      - name: Strip binary
-        run: tar -cf agent-${{matrix.architecture}}.tar -C output-${{matrix.architecture}} . && rm -rf output-${{matrix.architecture}}
-      - name: Build and push Docker image
-        run: |
-          docker tag ${{matrix.architecture}} $REPO-arch:arch-${{matrix.architecture}}-${{ needs.bump-release.outputs.tag }}
-          docker push $REPO-arch:arch-${{matrix.architecture}}-${{ needs.bump-release.outputs.tag }}
-      - name: Upload artifact
-        uses: actions/upload-artifact@v4
-        with:
-          name: agent-${{matrix.architecture}}.tar
-          path: agent-${{matrix.architecture}}.tar
-
-  create-manifest:
-    runs-on: ubuntu-24.04
-    needs: [bump-release, build-amd64, build-arm64]
-    steps:
-      - name: Login to DockerHub
-        uses: docker/login-action@v3
-        with:
-          username: ${{ secrets.DOCKER_USERNAME }}
-          password: ${{ secrets.DOCKER_PASSWORD }}
-      - name: Create and push multi-arch manifest
-        run: |
-          docker manifest create $REPO:${{ needs.bump-release.outputs.tag }} \
-            $REPO-arch:arch-amd64-${{ needs.bump-release.outputs.tag }} \
-            $REPO-arch:arch-arm64-${{ needs.bump-release.outputs.tag }}
-          docker manifest push $REPO:${{ needs.bump-release.outputs.tag }}
-      - name: Create and push latest manifest
-        run: |
-          docker manifest create $REPO:latest \
-            $REPO-arch:arch-amd64-${{ needs.bump-release.outputs.tag }} \
-            $REPO-arch:arch-arm64-${{ needs.bump-release.outputs.tag }}
-          docker manifest push $REPO:latest
-
-  create-release:
-    runs-on: ubuntu-24.04
-    needs: [bump-release, build-amd64, build-arm64]
-    permissions:
-      contents: write
-    steps:
-      - name: Download all artifacts
-        uses: actions/download-artifact@v4
-      - name: Create a release
-        uses: ncipollo/release-action@v1
-        with:
-          latest: true
-          allowUpdates: true
-          name: ${{ needs.bump-release.outputs.tag }}
-          tag: ${{ needs.bump-release.outputs.tag }}
-          generateReleaseNotes: false
-          omitBodyDuringUpdate: true
-          artifacts: "agent-*.tar/agent-*.tar"
-
-  

.github/workflows/release-create.yml

@@ -1,122 +0,0 @@
-name: Create a new release
-on:
-  release:
-    types: [created]
-  workflow_dispatch:
-    inputs:
-      tag:
-        description: "Tag for the Docker image"
-        required: true
-        default: "test"
-
-env:
-  REPO: kerberos/agent
-
-jobs:
-  build-amd64:
-    runs-on: ubuntu-24.04
-    permissions:
-      contents: write
-    strategy:
-      matrix:
-        architecture: [amd64]
-    steps:
-      - name: Login to DockerHub
-        uses: docker/login-action@v3
-        with:
-          username: ${{ secrets.DOCKER_USERNAME }}
-          password: ${{ secrets.DOCKER_PASSWORD }}
-      - name: Checkout
-        uses: actions/checkout@v4
-      - name: Run Build
-        run: |
-          docker build --provenance=false --build-arg VERSION=${{github.event.inputs.tag || github.ref_name}} -t ${{matrix.architecture}} .
-          CID=$(docker create ${{matrix.architecture}})
-          docker cp ${CID}:/home/agent ./output-${{matrix.architecture}}
-          docker rm ${CID}
-      - name: Strip binary
-        run: tar -cf agent-${{matrix.architecture}}.tar -C output-${{matrix.architecture}} . && rm -rf output-${{matrix.architecture}}
-      - name: Build and push Docker image
-        run: |
-          docker tag ${{matrix.architecture}} $REPO-arch:arch-${{matrix.architecture}}-${{github.event.inputs.tag || github.ref_name}}
-          docker push $REPO-arch:arch-${{matrix.architecture}}-${{github.event.inputs.tag || github.ref_name}}
-      - name: Upload artifact
-        uses: actions/upload-artifact@v4
-        with:
-          name: agent-${{matrix.architecture}}.tar
-          path: agent-${{matrix.architecture}}.tar
-          
-  build-arm64:
-    runs-on: ubuntu-24.04-arm 
-    permissions:
-      contents: write
-    strategy:
-      matrix:
-        architecture: [arm64]
-    steps:
-      - name: Login to DockerHub
-        uses: docker/login-action@v3
-        with:
-          username: ${{ secrets.DOCKER_USERNAME }}
-          password: ${{ secrets.DOCKER_PASSWORD }}
-      - name: Checkout
-        uses: actions/checkout@v4
-      - name: Run Build
-        run: |
-          docker build --provenance=false --build-arg VERSION=${{github.event.inputs.tag || github.ref_name}} -t ${{matrix.architecture}} .
-          CID=$(docker create ${{matrix.architecture}})
-          docker cp ${CID}:/home/agent ./output-${{matrix.architecture}}
-          docker rm ${CID}
-      - name: Strip binary
-        run: tar -cf agent-${{matrix.architecture}}.tar -C output-${{matrix.architecture}} . && rm -rf output-${{matrix.architecture}}
-      - name: Build and push Docker image
-        run: |
-          docker tag ${{matrix.architecture}} $REPO-arch:arch-${{matrix.architecture}}-${{github.event.inputs.tag || github.ref_name}}
-          docker push $REPO-arch:arch-${{matrix.architecture}}-${{github.event.inputs.tag || github.ref_name}}
-      - name: Upload artifact
-        uses: actions/upload-artifact@v4
-        with:
-          name: agent-${{matrix.architecture}}.tar
-          path: agent-${{matrix.architecture}}.tar
-
-  create-manifest:
-    runs-on: ubuntu-24.04
-    needs: [build-amd64, build-arm64]
-    steps:
-      - name: Login to DockerHub
-        uses: docker/login-action@v3
-        with:
-          username: ${{ secrets.DOCKER_USERNAME }}
-          password: ${{ secrets.DOCKER_PASSWORD }}
-      - name: Create and push multi-arch manifest
-        run: |
-          docker manifest create $REPO:${{ github.event.inputs.tag || github.ref_name }} \
-            $REPO-arch:arch-amd64-${{github.event.inputs.tag || github.ref_name}} \
-            $REPO-arch:arch-arm64-${{github.event.inputs.tag || github.ref_name}}
-          docker manifest push $REPO:${{ github.event.inputs.tag || github.ref_name }}
-      - name: Create and push latest manifest
-        run: |
-          docker manifest create $REPO:latest \
-            $REPO-arch:arch-amd64-${{github.event.inputs.tag || github.ref_name}} \
-            $REPO-arch:arch-arm64-${{github.event.inputs.tag || github.ref_name}}
-          docker manifest push $REPO:latest
-        if: github.event.inputs.tag == 'test'
-
-  create-release:
-    runs-on: ubuntu-24.04
-    needs: [build-amd64, build-arm64]
-    permissions:
-      contents: write
-    steps:
-      - name: Download all artifacts
-        uses: actions/download-artifact@v4
-      - name: Create a release
-        uses: ncipollo/release-action@v1
-        with:
-          latest: true
-          allowUpdates: true
-          name: ${{ github.event.inputs.tag || github.ref_name }}
-          tag: ${{ github.event.inputs.tag || github.ref_name }}
-          generateReleaseNotes: false
-          omitBodyDuringUpdate: true
-          artifacts: "agent-*.tar/agent-*.tar"

.gitignore

@@ -1,8 +1,6 @@
 ui/node_modules
 ui/build
 ui/public/assets/env.js
-.DS_Store
-__debug*
 .idea
 machinery/www
 yarn.lock
@@ -12,9 +10,5 @@ machinery/data/recordings
 machinery/data/snapshots
 machinery/test*
 machinery/init-dev.sh
-machinery/.env.local
-machinery/vendor
-machinery/go.work
-machinery/go.work.sum
-deployments/docker/private-docker-compose.yaml
-video.mp4
+machinery/.env
+deployments/docker/private-docker-compose.yaml

.travis.yml

@@ -0,0 +1,19 @@
+language: go
+
+go:
+  - 1.12.x
+  - 1.13.x
+  - 1.14.x
+  - 1.15.x
+  - tip
+
+before_install:
+  - cd machinery
+  - go mod download
+
+script:
+  - go vet
+  - go test -race -coverprofile=coverage.txt -covermode=atomic
+
+after_success:
+  - bash <(curl -s https://codecov.io/bash)

.vscode/launch.json

@@ -1,36 +0,0 @@
-{
-    // Use IntelliSense to learn about possible attributes.
-    // Hover to view descriptions of existing attributes.
-    // For more information, visit: https://go.microsoft.com/fwlink/?linkid=830387
-    "version": "0.2.0",
-    "configurations": [
-        {
-            "name": "Launch Golang",
-            "type": "go",
-            "request": "launch",
-            "mode": "auto",
-            "program": "${workspaceFolder}/machinery/main.go",
-            "args": [
-                "-action",
-                "run",
-                "-port",
-                "8080"
-            ],
-            "envFile": "${workspaceFolder}/machinery/.env.local",
-            "buildFlags": "--tags dynamic,moq",
-            "env": {
-                "GOWORK": "off"
-            },
-        },
-        {
-            "name": "Launch React",
-            "type": "node",
-            "request": "launch",
-            "cwd": "${workspaceFolder}/ui",
-            "runtimeExecutable": "yarn",
-            "runtimeArgs": [
-                "start"
-            ],
-        }
-    ]
-}

.vscode/tasks.json

@@ -1,14 +0,0 @@
-{
-  "version": "2.0.0",
-  "tasks": [
-    {
-      "label": "agent: moq verify",
-      "type": "shell",
-      "command": "bash ./verify-moq-devcontainer.sh",
-      "options": {
-        "cwd": "${workspaceFolder}/machinery"
-      },
-      "problemMatcher": []
-    }
-  ]
-}

Dockerfile

@@ -1,15 +1,6 @@
 
-ARG GO_IMAGE=golang:1.25-trixie
-ARG RUNTIME_IMAGE=debian:trixie-slim
-ARG VERSION=0.0.0
-FROM ${GO_IMAGE} AS build-machinery
-LABEL AUTHOR=uug.ai
-
-# Re-declare VERSION inside this stage so the value passed via
-# `--build-arg VERSION=...` (e.g. the release tag) is available below.
-# ARGs declared before the first FROM are not visible inside build stages.
-ARG VERSION
-ARG TARGETARCH
+FROM kerberos/base:dc12d68 AS build-machinery
+LABEL AUTHOR=Kerberos.io
 
 ENV GOROOT=/usr/local/go
 ENV GOPATH=/go
@@ -19,34 +10,29 @@ ENV GOSUMDB=off
 ##########################################
 # Installing some additional dependencies.
 
-RUN apt-get update && apt-get install -y --fix-missing --no-install-recommends \
+RUN apt-get upgrade -y && apt-get update && apt-get install -y --no-install-recommends \
 	git build-essential cmake pkg-config unzip libgtk2.0-dev \
-	curl ca-certificates libavcodec-dev libavutil-dev libcurl4-openssl-dev \
-	libssl-dev libjpeg62-turbo-dev libswscale-dev && \
+	curl ca-certificates libcurl4-openssl-dev libssl-dev libjpeg62-turbo-dev && \
 	rm -rf /var/lib/apt/lists/*
 
 ##############################################################################
-# Copy dependency metadata first so module downloads can be cached separately.
+# Copy all the relevant source code in the Docker image, so we can build this.
 
 RUN mkdir -p /go/src/github.com/kerberos-io/agent
-WORKDIR /go/src/github.com/kerberos-io/agent/machinery
-COPY machinery/go.mod machinery/go.sum ./
-RUN go mod download
+COPY machinery /go/src/github.com/kerberos-io/agent/machinery
 
-##############################################################################
-# Copy the rest of the source after dependencies are primed.
-
-COPY machinery ./
-RUN rm -rf .env
+##################################################################
+# Get the latest commit hash, so we know which version we're running
+COPY .git /go/src/github.com/kerberos-io/agent/.git
+RUN cd /go/src/github.com/kerberos-io/agent/.git && git log --format="%H" -n 1 | head -c7 > /go/src/github.com/kerberos-io/agent/machinery/version
+RUN cat /go/src/github.com/kerberos-io/agent/machinery/version
 
 ##################
 # Build Machinery
 
-RUN RESOLVED_VERSION="${VERSION:-0.0.0}" && \
-	printf '%s' "${RESOLVED_VERSION}" > version && \
-	BUILD_TAGS=timetzdata,netgo,osusergo && \
-	case "${TARGETARCH:-$(go env GOARCH)}" in amd64|arm64) BUILD_TAGS="moq,${BUILD_TAGS}" ;; esac && \
-	go build -tags "${BUILD_TAGS}" --ldflags "-s -w -X github.com/kerberos-io/agent/machinery/src/utils.VERSION=${RESOLVED_VERSION}" main.go && \
+RUN cd /go/src/github.com/kerberos-io/agent/machinery && \
+	go mod download && \
+	go build -tags timetzdata,netgo,osusergo --ldflags '-s -w -extldflags "-static -latomic"' main.go && \
 	mkdir -p /agent && \
 	mv main /agent && \
 	mv version /agent && \
@@ -56,7 +42,8 @@ RUN RESOLVED_VERSION="${VERSION:-0.0.0}" && \
 	mkdir -p /agent/data/log && \
 	mkdir -p /agent/data/recordings && \
 	mkdir -p /agent/data/capture-test && \
-	mkdir -p /agent/data/config
+	mkdir -p /agent/data/config && \
+	rm -rf /go/src/gitlab.com/
 
 ####################################
 # Let's create a /dist folder containing just the files necessary for runtime.
@@ -70,7 +57,19 @@ RUN cp -r /agent ./
 
 RUN /dist/agent/main version
 
-FROM node:22-alpine AS build-ui
+###############################################
+# Build Bento4 -> we want fragmented mp4 files
+
+ENV BENTO4_VERSION 1.6.0-639
+RUN cd /tmp && git clone https://github.com/axiomatic-systems/Bento4 && cd Bento4 && \
+	git checkout tags/v${BENTO4_VERSION} && \
+	cd Build && \
+	cmake -DCMAKE_BUILD_TYPE=Release .. && \
+	make && \
+	mv /tmp/Bento4/Build/mp4fragment /dist/agent/ && \
+	rm -rf /tmp/Bento4
+
+FROM node:18.14.0-alpine3.16 AS build-ui
 
 RUN apk update && apk upgrade --available && sync
 
@@ -78,11 +77,9 @@ RUN apk update && apk upgrade --available && sync
 # Build Web (React app)
 
 RUN mkdir -p /go/src/github.com/kerberos-io/agent/machinery/www
-WORKDIR /go/src/github.com/kerberos-io/agent/ui
-COPY ui/package.json ui/yarn.lock ./
-RUN yarn config set network-timeout 300000 && yarn --frozen-lockfile
-COPY ui ./
-RUN yarn build
+COPY ui /go/src/github.com/kerberos-io/agent/ui
+RUN cd /go/src/github.com/kerberos-io/agent/ui && rm -rf yarn.lock && yarn config set network-timeout 300000 && \
+	yarn && yarn build
 
 ####################################
 # Let's create a /dist folder containing just the files necessary for runtime.
@@ -94,17 +91,12 @@ RUN mkdir -p ./agent && cp -r /go/src/github.com/kerberos-io/agent/machinery/www
 ############################################
 # Publish main binary to GitHub release
 
-FROM ${RUNTIME_IMAGE}
+FROM alpine:latest
 
 ############################
 # Protect by non-root user.
 
-RUN apt-get update && apt-get install -y --no-install-recommends \
-	ca-certificates curl ffmpeg libatomic1 libcap2-bin libstdc++6 && \
-	rm -rf /var/lib/apt/lists/* && \
-	groupadd --system kerberosio && \
-	useradd --system --gid kerberosio --groups video --create-home agent && \
-	chmod 0755 /home/agent
+RUN addgroup -S kerberosio && adduser -S agent -G kerberosio && addgroup agent video
 
 #################################
 # Copy files from previous images
@@ -112,10 +104,13 @@ RUN apt-get update && apt-get install -y --no-install-recommends \
 COPY --chown=0:0 --from=build-machinery /dist /
 COPY --chown=0:0 --from=build-ui /dist /
 
+RUN apk update && apk add ca-certificates curl libstdc++ libc6-compat --no-cache && rm -rf /var/cache/apk/*
+
 ##################
 # Try running agent
 
 RUN mv /agent/* /home/agent/
+RUN cp /home/agent/mp4fragment /usr/local/bin/
 RUN /home/agent/main version
 
 #######################
@@ -131,7 +126,7 @@ RUN chown -R agent:kerberosio /home/agent/www
 
 ###########################
 # Grant the necessary root capabilities to the process trying to bind to the privileged port
-RUN setcap 'cap_net_bind_service=+ep' /home/agent/main
+RUN apk add libcap && setcap 'cap_net_bind_service=+ep' /home/agent/main
 
 ###################
 # Run non-root user
@@ -152,4 +147,4 @@ HEALTHCHECK CMD curl --fail http://localhost:80 || exit 1
 # Leeeeettttt'ssss goooooo!!!
 # Run the shizzle from the right working directory.
 WORKDIR /home/agent
-CMD ["./main", "-action", "run", "-port", "80"]
+CMD ["./main", "-action", "run", "-port", "80"]

README-RTSPS-TLS.md

@@ -1,645 +0,0 @@
-# RTSPS and TLS certificates
-
-This guide explains how Kerberos Agent connects to an IP camera over RTSPS,
-how to issue a camera certificate with a private CA, and how to validate the
-complete trust path. It also explains why some apparently corrupted trust
-bundles can still allow a connection.
-
-The camera-specific steps were verified with a Bosch FLEXIDOME micro 3100i.
-Other Bosch firmware versions may use different labels or ports.
-
-The commands were tested with Smallstep CLI `0.30.6` and OpenSSL `3.5.6` on
-Debian. Check `step certificate sign --help` when using an older Smallstep CLI.
-The OpenSSL isolation flags `-no-CApath` and `-no-CAstore` require a version that
-lists them in `openssl s_client -help`.
-
-## Tested configuration
-
-| Setting | Value |
-| --- | --- |
-| Camera | Bosch FLEXIDOME micro 3100i |
-| Example camera address | `10.0.30.11` |
-| RTSPS port | `9554` |
-| Main stream | `rtsps://<user>:<password>@10.0.30.11:9554/?inst=1` |
-| Sub stream | `rtsps://<user>:<password>@10.0.30.11:9554/?inst=2` |
-| Certificate SAN | `IP Address:10.0.30.11` |
-| Bosch certificate usage | `HTTPS` |
-| Agent trust input | Issuing intermediate plus root CA |
-
-Replace the example address and certificate names throughout this guide. Keep
-camera credentials out of source control and percent-encode reserved URL
-characters in usernames and passwords.
-
-## Mental model
-
-### RTSPS, SRTSP, TLS, and SRTP
-
-- The standard URL scheme is `rtsps://`. Do not use `srtsp://`.
-- Bosch interfaces and documentation may use SRTSP or Secure RTSP as product
-  terminology.
-- RTSPS carries the RTSP control connection over TLS. With gortsplib, media is
-  normally interleaved over the same TCP/TLS connection for this camera.
-- SRTP is a separate media protection mechanism and is negotiated only when the
-  camera advertises an appropriate secure RTP profile.
-
-Encryption alone does not prove which camera the Agent reached. Verified TLS
-also checks that:
-
-1. The camera certificate is signed by a trusted authority.
-2. The certificate is valid at the current time.
-3. The URL host matches a certificate Subject Alternative Name (SAN).
-
-Modern Go verification uses SANs for identity. A Common Name alone is not
-sufficient. Connecting to `10.0.30.11` requires an IP SAN with that exact value,
-not `DNS:10.0.30.11` and not only a device-name DNS SAN.
-
-### Agent behavior
-
-Kerberos Agent uses gortsplib for RTSP and RTSPS. With the normal configuration,
-gortsplib receives a nil custom TLS configuration and Go performs standard
-certificate and hostname verification with the process trust pool.
-
-`AGENT_CAPTURE_IPCAMERA_RTSPS_INSECURE=true` is an explicit escape hatch that
-sets `InsecureSkipVerify` for camera clients. It should be false in a verified
-deployment.
-
-## Communication and certificate flow
-
-The certificate is used during the TLS handshake, before the first RTSP command
-is exchanged. It is not attached to `DESCRIBE`, `SETUP`, or `PLAY`, and the CA
-trust bundle is never sent to the camera.
-
-```mermaid
-sequenceDiagram
-  participant Agent as Kerberos Agent
-  participant Trust as Go trust pool
-  participant Camera as Camera RTSPS :9554
-
-  Agent->>Trust: Load system roots and append AGENT_CAPTURE_IPCAMERA_RTSPS_CA_FILE
-  Agent->>Camera: Open TCP connection
-  Agent->>Camera: Send TLS ClientHello
-  Camera-->>Agent: Send TLS ServerHello and camera certificate
-  Agent->>Trust: Verify chain, validity, serverAuth, and URL host against SAN
-  Trust-->>Agent: Accept or reject the camera identity
-  Agent->>Camera: Complete TLS handshake
-  Note over Agent,Camera: All following traffic is encrypted by TLS
-  Agent->>Camera: DESCRIBE with RTSP authentication
-  Camera-->>Agent: Return SDP and available media tracks
-  Agent->>Camera: SETUP selected video and audio tracks over TCP
-  Agent->>Camera: PLAY
-  Camera-->>Agent: Send interleaved RTP and RTCP media over TLS
-```
-
-The files and keys have distinct roles:
-
-| Material | Location | Purpose | Sent over the connection |
-| --- | --- | --- | --- |
-| Camera leaf certificate | Camera | Identifies the camera and binds its public key to its SAN | Yes, by the camera during the TLS handshake |
-| Camera private key | Camera | Proves that the camera owns the presented certificate | No |
-| Intermediate and root CA PEM bundle | Agent | Lets Go build and trust the camera certificate chain | No |
-| RTSP username and password | Agent configuration or URL | Authenticates the Agent to the RTSP service after TLS succeeds | An authentication response is sent inside TLS; its form depends on the RTSP authentication method |
-
-For an `rtsps://` URL, the Agent parses the URL and gives gortsplib the host and
-TLS settings. gortsplib opens the TCP connection and starts TLS. Go compares the
-certificate presented by the camera with the local trust pool, checks its
-validity period and server usage, and matches the URL hostname or IP address to
-the certificate SAN. Only a successful handshake creates the encrypted channel
-needed for the RTSP exchange.
-
-The Agent then sends `DESCRIBE`, selects the advertised video and audio tracks,
-sends `SETUP`, and starts delivery with `PLAY`. For the tested camera, gortsplib
-uses interleaved TCP, so the RTSP control messages and RTP/RTCP media remain
-inside the same encrypted TLS connection. Main stream, sub stream, and enabled
-audio backchannel clients each establish and verify their own connection.
-
-If certificate verification fails, the TLS handshake does not complete and no
-usable RTSP session is established. Setting
-`AGENT_CAPTURE_IPCAMERA_RTSPS_INSECURE=true` keeps traffic encrypted but skips
-certificate-chain and hostname verification, so an attacker could impersonate
-the camera. It is not equivalent to trusting the camera certificate.
-
-## Decide the certificate identity first
-
-Choose the stable name used in every Agent URL before creating the certificate:
-
-- For an IP URL, add that address as an IP SAN.
-- For a DNS URL, add the exact hostname as a DNS SAN.
-- Add both when clients legitimately use both forms.
-
-A certificate stops matching if the camera IP changes. Use a static address,
-DHCP reservation, or stable DNS name.
-
-## Configure RTSPS in the Bosch UI
-
-1. Sign in to the camera as an administrator.
-2. Open **Configuration**.
-3. Open **Network > Network Services**.
-4. Enable **RTSPS**.
-5. Confirm port `9554`, or record the configured alternative.
-6. Click **Set**.
-
-RTSP on port `554` and RTSPS on port `9554` are separate services. Enabling
-RTSPS does not make an `rtsp://` URL secure.
-
-## Generate the private key and CSR on the camera
-
-Keeping the TLS private key on the camera avoids exporting it to an operator
-workstation or deployment system.
-
-1. Open **Service > Certificates**.
-2. Click **Add**.
-3. Select **Generate signing request**.
-4. Select `RSA 2048bit` or the stronger option supported by all clients.
-5. Enter a unique file name, such as `agent-rtsps`.
-6. Enter a descriptive Common Name and any required organization fields.
-7. Click **Generate**.
-8. Download the resulting CSR from the certificate table.
-
-On the tested firmware, this form contains no SAN field. The downloaded CSR
-therefore has no IP SAN. The CA must add the SAN while signing.
-
-Inspect the CSR before signing:
-
-```bash
-openssl req -in camera.csr.pem -noout -verify -subject
-openssl req -in camera.csr.pem -noout -text
-```
-
-The first command must report `Certificate request self-signature verify OK`.
-An absent `Subject Alternative Name` section is expected for this firmware.
-
-## Prepare Smallstep
-
-Use an existing organizational CA when one is available. Creating a new CA
-creates a new long-lived trust domain that must be distributed, protected,
-backed up, and eventually rotated.
-
-### Install the CLI on Debian amd64
-
-```bash
-curl -fsSL \
-  https://dl.smallstep.com/cli/docs-ca-install/latest/step-cli_amd64.deb \
-  -o /tmp/step-cli_amd64.deb
-sudo dpkg -i /tmp/step-cli_amd64.deb
-rm /tmp/step-cli_amd64.deb
-step version
-```
-
-Use the official package matching the host architecture on other systems.
-
-### Create a dedicated offline CA
-
-Skip this section when using an existing CA.
-
-```bash
-umask 077
-mkdir -p "$HOME/.step/secrets" "$HOME/.step/camera"
-
-openssl rand -base64 48 > "$HOME/.step/secrets/camera_ca_password"
-chmod 600 "$HOME/.step/secrets/camera_ca_password"
-
-step ca init \
-  --pki \
-  --name "UUG Camera CA" \
-  --password-file "$HOME/.step/secrets/camera_ca_password"
-```
-
-This produces:
-
-```text
-$HOME/.step/certs/root_ca.crt
-$HOME/.step/certs/intermediate_ca.crt
-$HOME/.step/secrets/root_ca_key
-$HOME/.step/secrets/intermediate_ca_key
-$HOME/.step/secrets/camera_ca_password
-```
-
-The files under `secrets/` are sensitive. Keep them mode `600`, never commit
-them, and back them up to encrypted persistent storage. A devcontainer can be
-rebuilt or deleted; it is not sufficient as the only CA backup.
-
-## Add the SAN while signing
-
-Copy the camera CSR into a protected working directory:
-
-```bash
-cp camera.csr.pem "$HOME/.step/camera/camera.csr.pem"
-```
-
-Create `$HOME/.step/camera/bosch-rtsps.tpl`:
-
-```json
-{
-  "subject": {
-    "commonName": {{ toJson .Insecure.CR.Subject.CommonName }}
-  },
-  "ipAddresses": ["10.0.30.11"],
-  "keyUsage": ["keyEncipherment", "digitalSignature"],
-  "extKeyUsage": ["serverAuth", "clientAuth"]
-}
-```
-
-The template preserves the camera CSR public key, sets the IP identity, and
-creates a TLS leaf rather than a CA certificate.
-
-Sign it with a validity period that ends before the intermediate CA expires.
-A one-year leaf is preferable to a ten-year leaf when automated renewal is
-available:
-
-```bash
-step certificate sign \
-  --template "$HOME/.step/camera/bosch-rtsps.tpl" \
-  --bundle \
-  --not-after 8760h \
-  --password-file "$HOME/.step/secrets/camera_ca_password" \
-  "$HOME/.step/camera/camera.csr.pem" \
-  "$HOME/.step/certs/intermediate_ca.crt" \
-  "$HOME/.step/secrets/intermediate_ca_key" \
-  > "$HOME/.step/camera/bosch-rtsps-chain.pem"
-```
-
-For an online `step-ca`, do not assume `step ca sign` accepts a `--san` flag. It
-does not. Authorize SANs in the one-time token or configure a provisioner
-template that produces the required SANs.
-
-## Validate before upload
-
-Inspect the leaf certificate, which is the first PEM block in the chain file:
-
-```bash
-openssl x509 \
-  -in "$HOME/.step/camera/bosch-rtsps-chain.pem" \
-  -noout -subject -issuer -dates -ext subjectAltName -ext extendedKeyUsage
-```
-
-Confirm the SAN separately because some OpenSSL versions display only the last
-requested extension:
-
-```bash
-openssl x509 \
-  -in "$HOME/.step/camera/bosch-rtsps-chain.pem" \
-  -noout -ext subjectAltName
-```
-
-Verify the path and IP identity:
-
-```bash
-openssl verify \
-  -CAfile "$HOME/.step/certs/root_ca.crt" \
-  -untrusted "$HOME/.step/certs/intermediate_ca.crt" \
-  -verify_ip 10.0.30.11 \
-  "$HOME/.step/camera/bosch-rtsps-chain.pem"
-```
-
-Confirm that the signed leaf uses the exact public key from the camera CSR:
-
-```bash
-csr_key=$(
-  openssl req -in "$HOME/.step/camera/camera.csr.pem" -pubkey -noout |
-    openssl pkey -pubin -outform DER 2>/dev/null |
-    sha256sum | cut -d' ' -f1
-)
-
-cert_key=$(
-  openssl x509 -in "$HOME/.step/camera/bosch-rtsps-chain.pem" -pubkey -noout |
-    openssl pkey -pubin -outform DER 2>/dev/null |
-    sha256sum | cut -d' ' -f1
-)
-
-test "$csr_key" = "$cert_key"
-```
-
-Do not upload a certificate when any of these checks fail.
-
-## Upload and assign the certificate
-
-1. Return to **Service > Certificates**.
-2. Click **Add > Upload certificate**.
-3. Select the leaf-plus-intermediate PEM chain.
-4. Click **Upload** and wait for `100%`.
-5. Confirm that the former CSR row is now a `Certificate`.
-6. Confirm that the key icon is present. It proves that the camera associated
-   the certificate with its retained private key.
-7. Open the new certificate's **Usage** selector.
-8. Select only **HTTPS**.
-9. Leave **CBS client** assigned to the original Bosch `DeviceCertificate`.
-10. Click **Set** and wait for the table to reload.
-
-On the tested firmware, there is no separate SRTSP usage. RTSPS presents the
-certificate assigned to HTTPS. Reassigning HTTPS therefore changes both the
-web interface and RTSPS certificate.
-
-After saving, the expected split is:
-
-| Certificate | Usage |
-| --- | --- |
-| Private-CA camera certificate | `HTTPS` |
-| Bosch `DeviceCertificate` | `CBS client` |
-
-The browser may warn about the new HTTPS certificate until the private root CA
-is trusted by the workstation.
-
-## Account for the Bosch chain behavior
-
-The tested firmware served only the leaf certificate on ports `443` and `9554`,
-even when the uploaded file contained the leaf and intermediate. Uploading the
-intermediate separately as a trusted camera certificate did not change the
-served chain.
-
-Confirm the behavior:
-
-```bash
-openssl s_client \
-  -connect 10.0.30.11:9554 \
-  -showcerts </dev/null 2>/dev/null |
-  grep -c '^-----BEGIN CERTIFICATE-----$'
-```
-
-A result of `1` means the client must already have the issuing intermediate.
-Create a portable trust bundle containing the intermediate and root:
-
-```bash
-step certificate bundle \
-  "$HOME/.step/certs/intermediate_ca.crt" \
-  "$HOME/.step/certs/root_ca.crt" \
-  "$HOME/.step/camera/uug-camera-trust-bundle.pem"
-
-chmod 644 "$HOME/.step/camera/uug-camera-trust-bundle.pem"
-```
-
-The trust bundle is public material. The CA private keys and password are not.
-
-## Configure Kerberos Agent
-
-For a process running directly in the same environment:
-
-```dotenv
-AGENT_CAPTURE_IPCAMERA_RTSP="rtsps://<user>:<password>@10.0.30.11:9554/?inst=1"
-AGENT_CAPTURE_IPCAMERA_SUB_RTSP="rtsps://<user>:<password>@10.0.30.11:9554/?inst=2"
-AGENT_CAPTURE_IPCAMERA_RTSPS_INSECURE=false
-AGENT_CAPTURE_IPCAMERA_RTSPS_CA_FILE=/home/agent/data/config/uug-camera-trust-bundle.pem
-```
-
-For a container, mount the public bundle read-only at the exact path visible
-inside the container. The Agent image creates `/home/agent/data/config` and
-includes Debian's `ca-certificates` package:
-
-```bash
-docker run \
-  -v /secure/config/uug-camera-trust-bundle.pem:/home/agent/data/config/uug-camera-trust-bundle.pem:ro \
-  -e AGENT_CAPTURE_IPCAMERA_RTSPS_CA_FILE=/home/agent/data/config/uug-camera-trust-bundle.pem \
-  -e AGENT_CAPTURE_IPCAMERA_RTSPS_INSECURE=false \
-  -e 'AGENT_CAPTURE_IPCAMERA_RTSP=rtsps://<user>:<password>@10.0.30.11:9554/?inst=1' \
-  -e 'AGENT_CAPTURE_IPCAMERA_SUB_RTSP=rtsps://<user>:<password>@10.0.30.11:9554/?inst=2' \
-  kerberos/agent:latest
-```
-
-`AGENT_CAPTURE_IPCAMERA_RTSPS_CA_FILE` starts with the operating system's roots
-and appends the camera bundle only to the gortsplib TLS configuration. Other
-clients, including MoQ, Hub, and Vault, retain the normal public CA chain.
-Restart the Agent after changing trust files.
-
-Do not set `SSL_CERT_FILE` or `SSL_CERT_DIR` in production solely for camera
-trust. They are process-wide and can prevent other clients from validating
-public services. For a deliberate process-wide isolation test, mount an empty
-directory and set `SSL_CERT_DIR` to its path:
-
-```bash
--v /secure/config/empty-ca-dir:/home/agent/data/config/empty-ca-dir:ro \
--e SSL_CERT_DIR=/home/agent/data/config/empty-ca-dir
-```
-
-Do not use `SSL_CERT_DIR=`. Go treats an empty value as unset and scans its
-default certificate directories.
-
-Only use that mode when the Agent does not need public roots for other TLS
-connections.
-
-## Validate the live endpoints
-
-### Strict TLS and identity check
-
-Use only the specified bundle, without OpenSSL's default CA locations:
-
-```bash
-openssl s_client \
-  -brief \
-  -connect 10.0.30.11:9554 \
-  -verify_ip 10.0.30.11 \
-  -verify_return_error \
-  -CAfile "$HOME/.step/camera/uug-camera-trust-bundle.pem" \
-  -no-CApath \
-  -no-CAstore \
-  </dev/null
-```
-
-Repeat with port `443`. Both must report `Verification: OK`.
-
-Confirm that identity checking is active by repeating the command with a wrong
-address, such as `-verify_ip 10.0.30.12`. It must fail with an IP address
-mismatch.
-
-### Confirm the live leaf is the generated leaf
-
-```bash
-live_fingerprint=$(
-  openssl s_client -connect 10.0.30.11:9554 -showcerts </dev/null 2>/dev/null |
-    openssl x509 -noout -fingerprint -sha256 |
-    cut -d= -f2
-)
-
-local_fingerprint=$(
-  openssl x509 \
-    -in "$HOME/.step/camera/bosch-rtsps-chain.pem" \
-    -noout -fingerprint -sha256 |
-    cut -d= -f2
-)
-
-test "$live_fingerprint" = "$local_fingerprint"
-```
-
-### Validate the media path
-
-A successful TLS handshake does not prove that RTSP authentication, DESCRIBE,
-SETUP, PLAY, and RTP delivery work. Start a fresh Agent with verified TLS and
-confirm that it connects without an x509 error and receives frames. During the
-verified setup described here, a gortsplib probe completed all RTSP operations
-and received an RTP packet over TCP.
-
-## Why a tampered bundle may still connect
-
-Editing PEM text is not always a useful negative TLS test.
-
-### A certificate can still parse after a byte change
-
-Base64 can remain syntactically valid when one character changes. OpenSSL may
-still list the certificate subject and issuer even though a signature is now
-invalid. Parsing and signature verification are different operations.
-
-### Trust anchors are not validated through a parent
-
-Every certificate loaded into Go's root pool is a trust anchor, including a
-non-self-signed intermediate CA. Verification can terminate at that certificate.
-
-If tampering changes only the intermediate's signature from its parent root,
-but does not change its public key, that intermediate can still validate the
-camera leaf when it is trusted directly. Its now-invalid parent signature is
-not consulted at the trust boundary.
-
-This is equivalent to OpenSSL's partial-chain behavior:
-
-```bash
-openssl s_client \
-  -connect 10.0.30.11:9554 \
-  -verify_ip 10.0.30.11 \
-  -verify_return_error \
-  -partial_chain \
-  -CAfile tampered-bundle.pem \
-  -no-CApath \
-  -no-CAstore \
-  </dev/null
-```
-
-### `SSL_CERT_FILE` does not isolate Go from CA directories
-
-On Unix, Go uses `SSL_CERT_FILE` instead of its default aggregate CA file, but it
-still scans default certificate directories such as `/etc/ssl/certs`. Setting
-`SSL_CERT_FILE` alone therefore does not remove CA certificates installed with
-`update-ca-certificates`. `AGENT_CAPTURE_IPCAMERA_RTSPS_CA_FILE` is appended
-after this system pool is loaded; it does not replace the system roots.
-
-Blank values do not select empty trust sources. Both `SSL_CERT_FILE=` and
-`SSL_CERT_DIR=` are treated as unset, so Go falls back to its default aggregate
-CA file and certificate directories. To test with no trusted certificates on
-Linux, use a non-empty file path that contains no certificates and a non-empty
-directory path that contains no certificates:
-
-```bash
-mkdir -p /tmp/empty-ca-dir
-SSL_CERT_FILE=/dev/null \
-SSL_CERT_DIR=/tmp/empty-ca-dir \
-AGENT_CAPTURE_IPCAMERA_RTSPS_CA_FILE= \
-AGENT_CAPTURE_IPCAMERA_RTSPS_INSECURE=false \
-GOWORK=off \
-go run -tags moq . -action run -port 8080
-```
-
-That fresh process must fail with `x509: certificate signed by unknown
-authority`.
-
-Use exactly one camera trust-distribution approach when possible:
-
-1. Mount a private trust bundle and set
-  `AGENT_CAPTURE_IPCAMERA_RTSPS_CA_FILE`; or
-2. Install the CA certificates into the operating-system trust store.
-
-Using both is valid, but makes isolation tests less obvious.
-
-### Running processes can retain old roots
-
-A long-running Go process may already have loaded and cached the trust pool.
-Always start a new process after changing trust configuration during a negative
-test.
-
-## Perform a meaningful negative test
-
-Do not corrupt only the root or intermediate signature. Instead, give a fresh
-Agent process a completely unrelated CA and hide the default CA directories.
-
-```bash
-mkdir -p /tmp/empty-ca-dir
-
-openssl req \
-  -x509 -newkey rsa:2048 -nodes -days 1 \
-  -subj '/CN=Unrelated Test Root' \
-  -keyout /tmp/unrelated-test-root.key \
-  -out /tmp/unrelated-test-root.crt
-
-SSL_CERT_FILE=/dev/null \
-SSL_CERT_DIR=/tmp/empty-ca-dir \
-AGENT_CAPTURE_IPCAMERA_RTSPS_CA_FILE=/tmp/unrelated-test-root.crt \
-AGENT_CAPTURE_IPCAMERA_RTSPS_INSECURE=false \
-GOWORK=off \
-go run -tags moq . -action run -port 8080
-```
-
-The connection must fail with an unknown-authority or chain-building error.
-Delete the temporary test key and certificate afterward.
-
-To test bundle integrity rather than client distrust, validate the intermediate
-against the root explicitly:
-
-```bash
-openssl verify \
-  -CAfile "$HOME/.step/certs/root_ca.crt" \
-  -no-CApath \
-  -no-CAstore \
-  "$HOME/.step/certs/intermediate_ca.crt"
-```
-
-Store and compare approved SHA-256 fingerprints when detecting unauthorized
-certificate-file changes is a requirement.
-
-Restore an accidentally edited bundle from the protected CA certificates, then
-restart the Agent:
-
-```bash
-step certificate bundle -f \
-  "$HOME/.step/certs/intermediate_ca.crt" \
-  "$HOME/.step/certs/root_ca.crt" \
-  "$HOME/.step/camera/uug-camera-trust-bundle.pem"
-
-openssl verify \
-  -CAfile "$HOME/.step/certs/root_ca.crt" \
-  -no-CApath \
-  -no-CAstore \
-  "$HOME/.step/certs/intermediate_ca.crt"
-```
-
-## Optional system trust installation
-
-On Debian, install both public CA certificates when every process in the system
-should trust this camera PKI:
-
-```bash
-sudo install -m 0644 \
-  "$HOME/.step/certs/root_ca.crt" \
-  /usr/local/share/ca-certificates/uug-camera-ca.crt
-
-sudo install -m 0644 \
-  "$HOME/.step/certs/intermediate_ca.crt" \
-  /usr/local/share/ca-certificates/uug-camera-intermediate-ca.crt
-
-sudo update-ca-certificates
-```
-
-This creates links below `/etc/ssl/certs`. Remove those files and rerun
-`update-ca-certificates` before attempting an isolated trust-bundle test.
-
-## Renewal and recovery
-
-- Renew before the leaf or intermediate expires.
-- Generate a new camera CSR if the firmware cannot renew the existing key.
-- Sign the new CSR with all required SANs.
-- Upload and validate the new certificate before deleting the old one.
-- Preserve an alternate administrative access path while changing HTTPS usage.
-- Back up the CA certificates, encrypted CA keys, and password separately.
-- If the CA private keys are lost, create a new CA and redistribute its trust
-  before replacing camera certificates.
-
-## Production checklist
-
-- [ ] The Agent URL uses `rtsps://`, not `rtsp://` or `srtsp://`.
-- [ ] RTSPS is enabled on the camera and the configured port is reachable.
-- [ ] The certificate SAN exactly matches the Agent URL host.
-- [ ] The leaf public key matches the camera-generated CSR.
-- [ ] The certificate has `serverAuth` extended key usage.
-- [ ] The certificate expires before its issuer.
-- [ ] HTTPS is assigned to the private-CA certificate.
-- [ ] CBS client remains assigned to the Bosch device certificate.
-- [ ] The Agent has the intermediate and root CA certificates it needs.
-- [ ] `AGENT_CAPTURE_IPCAMERA_RTSPS_INSECURE=false`.
-- [ ] The Agent was restarted after trust changes.
-- [ ] A strict TLS check reports `Verification: OK`.
-- [ ] A real Agent connection receives RTP packets.
-- [ ] CA private keys and passwords are backed up outside the devcontainer.

README.md

@@ -3,6 +3,7 @@
 <a target="_blank" href="https://kerberos.io"><img src="https://img.shields.io/badge/kerberos-website-gray.svg?longCache=true&colorB=brightgreen" alt="Kerberos Agent"></a>
 <a target="_blank" href="https://doc.kerberos.io"><img src="https://img.shields.io/badge/kerberos-documentation-gray.svg?longCache=true&colorB=brightgreen" alt="Kerberos Agent"></a>
 
+<a target="_blank" href="https://circleci.com/gh/kerberos-io/agent"><img src="https://circleci.com/gh/kerberos-io/agent.svg?style=svg"/></a>
 <img src="https://github.com/kerberos-io/agent/workflows/Go/badge.svg"/>
 <img src="https://github.com/kerberos-io/agent/workflows/React/badge.svg"/>
 <img src="https://github.com/kerberos-io/agent/workflows/CodeQL/badge.svg"/>
@@ -16,23 +17,20 @@
 <a href="LICENSE"><img src="https://img.shields.io/badge/License-MIT-yellow.svg" alt="License: MIT"></a>
 [![donate](https://brianmacdonald.github.io/Ethonate/svg/eth-donate-blue.svg)](https://brianmacdonald.github.io/Ethonate/address#0xf4a759C9436E2280Ea9cdd23d3144D95538fF4bE)
 <a target="_blank" href="https://twitter.com/kerberosio?ref_src=twsrc%5Etfw"><img src="https://img.shields.io/twitter/url.svg?label=Follow%20%40kerberosio&style=social&url=https%3A%2F%2Ftwitter.com%2Fkerberosio" alt="Twitter Widget"></a>
+[![Discord Shield](https://discordapp.com/api/guilds/1039619181731135499/widget.png?style=shield)](https://discord.gg/Bj77Vqfp2G)
 [![kerberosio](https://snapcraft.io/kerberosio/badge.svg)](https://snapcraft.io/kerberosio)
 
-[![Slack invite](https://img.shields.io/badge/join%20kerberos.io%20on%20slack-grey?style=for-the-badge&logo=slack)](https://joinslack.kerberos.io/)
-
 [**Docker Hub**](https://hub.docker.com/r/kerberos/agent) | [**Documentation**](https://doc.kerberos.io) | [**Website**](https://kerberos.io) | [**View Demo**](https://demo.kerberos.io)
 
-> Before you continue, this repository discusses one of the components of the Kerberos.io stack, the Kerberos Agent, in depth. If you are [looking for an end-to-end deployment guide have a look here](https://github.com/kerberos-io/deployment).
-
 Kerberos Agent is an isolated and scalable video (surveillance) management agent made available as Open Source under the MIT License. This means that all the source code is available for you or your company, and you can use, transform and distribute the source code; as long you keep a reference of the original license. Kerberos Agent can be used for commercial usage (which was not the case for v2). Read more [about the license here](LICENSE).
 
 ![Kerberos Agent go through UI](./assets/img/kerberos-agent-overview.gif)
 
 ## :thinking: Prerequisites
 
-- An IP camera which supports a RTSP H264 or H265 encoded stream,
-  - (or) a USB camera, Raspberry Pi camera or other camera, that [you can transform to a valid RTSP H264 or H265 stream](https://github.com/kerberos-io/camera-to-rtsp).
-- Any hardware (ARMv6, ARMv7, ARM64, AMD64) that can run a binary or container, for example: a Raspberry Pi, NVidia Jetson, Intel NUC, a VM, Bare metal machine or a full blown Kubernetes cluster.
+- An IP camera which supports a RTSP H264 encoded stream,
+  - (or) a USB camera, Raspberry Pi camera or other camera, that [you can tranform to a valid RTSP H264 stream](https://github.com/kerberos-io/camera-to-rtsp).
+- Any hardware (ARMv6, ARMv7, ARM64, AMD) that can run a binary or container, for example: a Raspberry Pi, NVidia Jetson, Intel NUC, a VM, Bare metal machine or a full blown Kubernetes cluster.
 
 ## :video_camera: Is my camera working?
 
@@ -48,47 +46,41 @@ There are a myriad of cameras out there (USB, IP and other cameras), and it migh
 
 ### Introduction
 
-1. [A world of Kerberos Agents](#a-world-of-kerberos-agents)
+3. [A world of Kerberos Agents](#a-world-of-kerberos-agents)
 
 ### Running and automation
 
-1. [How to run and deploy a Kerberos Agent](#how-to-run-and-deploy-a-kerberos-agent)
-2. [Access the Kerberos Agent](#access-the-kerberos-agent)
-3. [Configure and persist with volume mounts](#configure-and-persist-with-volume-mounts)
-4. [Configure with environment variables](#configure-with-environment-variables)
-
-### Insights
-
-1. [Encryption](#encryption)
-2. [H264 vs H265](#h264-vs-h265)
+4. [How to run and deploy a Kerberos Agent](#how-to-run-and-deploy-a-kerberos-agent)
+5. [Access the Kerberos Agent](#access-the-kerberos-agent)
+6. [Configure and persist with volume mounts](#configure-and-persist-with-volume-mounts)
+7. [Configure with environment variables](#configure-with-environment-variables)
 
 ### Contributing
 
-1. [Security vulnerability reporting](#security-vulnerability-reporting)
-1. [Contribute with Codespaces](#contribute-with-codespaces)
-2. [Develop and build](#develop-and-build)
-3. [Building from source](#building-from-source)
-4. [Building for Docker](#building-for-docker)
+8. [Contribute with Codespaces](#contribute-with-codespaces)
+9. [Develop and build](#develop-and-build)
+10. [Building from source](#building-from-source)
+11. [Building for Docker](#building-for-docker)
 
 ### Varia
 
-1. [Support our project](#support-our-project)
-1. [What is new?](#what-is-new)
-1. [Contributors](#contributors)
+12. [Support our project](#support-our-project)
+13. [What is new?](#what-is-new)
+14. [Contributors](#contributors)
 
 ## Quickstart - Docker
 
-The easiest way to get your Kerberos Agent up and running is to use our public image on [Docker hub](https://hub.docker.com/r/kerberos/agent). Once you have selected a specific tag, run `docker` command below, which will open the web interface of your Kerberos agent on port `80`, and off you go. For a more configurable and persistent deployment have a look at [Running and automating a Kerberos Agent](#running-and-automating-a-kerberos-agent).
+The easiest to get your Kerberos Agent up and running is to use our public image on [Docker hub](https://hub.docker.com/r/kerberos/agent). Once you have selected a specific tag, run below `docker` command, which will open the web interface of your Kerberos agent on port `80`, and off you go. For a more configurable and persistent deployment have a look at [Running and automating a Kerberos Agent](#running-and-automating-a-kerberos-agent).
 
     docker run -p 80:80 --name mycamera -d --restart=always kerberos/agent:latest
 
-If you want to connect to a USB or Raspberry Pi camera, [you'll need to run our side car container](https://github.com/kerberos-io/camera-to-rtsp) which proxies the camera to an RTSP stream. In that case you'll want to configure the Kerberos Agent container to run in the host network, so it can connect directly to the RTSP sidecar.
+If you want to connect to an USB or Raspberry Pi camera, [you'll need to run our side car container](https://github.com/kerberos-io/camera-to-rtsp) which proxy the camera to an RTSP stream. In that case you'll want to configure the Kerberos Agent container to run in the host network, so it can connect directly to the RTSP sidecar.
 
     docker run --network=host --name mycamera -d --restart=always kerberos/agent:latest
 
 ## Quickstart - Balena
 
-Run Kerberos Agent with [Balena Cloud](https://www.balena.io/) super powers. Monitor your Kerberos Agent with seamless remote access, over the air updates, an encrypted public `https` endpoint and much more. Checkout our application `video-surveillance` on [Balena Hub](https://hub.balena.io/apps/2064752/video-surveillance), and create your first or fleet of Kerberos Agent(s).
+Run Kerberos Agent with [Balena Cloud](https://www.balena.io/) super powers. Monitor your Kerberos Agent with seamless remote access, over the air updates, an encrypted public `https` endpoint and many more. Checkout our application `video-surveillance` on [Balena Hub](https://hub.balena.io/apps/2064752/video-surveillance), and create your first or fleet of Kerberos Agent(s).
 
 [![deploy with balena](https://balena.io/deploy.svg)](https://dashboard.balena-cloud.com/deploy?repoUrl=https://github.com/kerberos-io/balena-agent)
 
@@ -104,37 +96,31 @@ Once installed you can find your Kerberos Agent configration at `/var/snap/kerbe
 
 ## A world of Kerberos Agents
 
-The Kerberos Agent is an isolated and scalable video (surveillance) management agent with a strong focus on user experience, scalability, resilience, extension and integration. Next to the Kerberos Agent, Kerberos.io provides many other tools such as [Kerberos Factory](https://github.com/kerberos-io/factory), [Kerberos Vault](https://github.com/kerberos-io/vault), and [Kerberos Hub](https://github.com/kerberos-io/hub) to provide additional capabilities: bring your own cloud, bring your own storage, central overview, live streaming, machine learning, etc.
+The Kerberos Agent is an isolated and scalable video (surveillance) management agent with a strong focus on user experience, scalability, resilience, extension and integration. Next to the Kerberos Agent, Kerberos.io provides many other tools such as [Kerberos Factory](https://github.com/kerberos-io/factory), [Kerberos Vault](https://github.com/kerberos-io/vault) and [Kerberos Hub](https://github.com/kerberos-io/hub) to provide additional capabilities: bring your own cloud, bring your own storage, central overview, live streaming, machine learning etc.
 
-[![Deployment Agent](./assets/img/edge-deployment-agent.svg)](https://github.com/kerberos-io/deployment)
-
-As mentioned above Kerberos.io applies the concept of agents. An agent is running next to (or on) your camera, and is processing a single camera feed. It applies motion based or continuous recording and makes those recordings available through a user friendly web interface. A Kerberos Agent allows you to connect to other cloud services or integrate with custom applications. Kerberos Agent is used for personal applications and scales to enterprise production level deployments. Learn more about the [deployment strategies here](<(https://github.com/kerberos-io/deployment)>).
+As mentioned above Kerberos.io applies the concept of agents. An agent is running next to (or on) your camera, and is processing a single camera feed. It applies motion based or continuous recording and make those recordings available through a user friendly web interface. A Kerberos Agent allows you to connect to other cloud services or integrates with custom applications. Kerberos Agent is used for personal usage and scales to enterprise production level deployments.
 
 This repository contains everything you'll need to know about our core product, Kerberos Agent. Below you'll find a brief list of features and functions.
 
 - Low memory and CPU usage.
 - Simplified and modern user interface.
-- Multi architecture (ARMv6, ARMv7, ARM64, AMD64)
-- Multi stream, for example recording in H265, live streaming and motion detection in H264.
-- Multi camera support: IP Cameras (H264 and H265), USB cameras and Raspberry Pi Cameras [through a RTSP proxy](https://github.com/kerberos-io/camera-to-rtsp).
+- Multi architecture (ARMv7, ARMv8, amd64, etc).
+- Multi camera support: IP Cameras (H264), USB cameras and Raspberry Pi Cameras [through a RTSP proxy](https://github.com/kerberos-io/camera-to-rtsp).
 - Single camera per instance (e.g. one container per camera).
-- Low resolution streaming through MQTT and high resolution streaming through WebRTC (only supports H264/PCM).
-- Backchannel audio from Kerberos Hub to IP camera (requires PCM ULAW codec)
-- Audio (AAC) and video (H264/H265) recording in MP4 container.
-- End-to-end encryption through MQTT using RSA and AES (livestreaming, ONVIF, remote configuration, etc)
-- Conditional recording: offline mode, motion region, time table, continuous recording, webhook condition etc.
-- Post- and pre-recording for motion detection.
-- Encryption at rest using AES-256-CBC.
-- Ability to create fragmented recordings, and streaming through HLS fMP4.
+- Primary and secondary stream setup (record full-res, stream low-res).
+- Low resolution streaming through MQTT and full resolution streaming through WebRTC.
+- Ability to specifiy conditions: offline mode, motion region, time table, continuous recording, etc.
+- Post- and pre-recording on motion detection.
+- Ability to create fragmented recordings, and streaming though HLS fMP4.
 - [Deploy where you want](#how-to-run-and-deploy-a-kerberos-agent) with the tools you use: `docker`, `docker compose`, `ansible`, `terraform`, `kubernetes`, etc.
 - Cloud storage/persistance: Kerberos Hub, Kerberos Vault and Dropbox. [(WIP: Minio, Storj, Google Drive, FTP etc.)](https://github.com/kerberos-io/agent/issues/95)
-- Outputs: trigger an integration (Webhooks, MQTT, Script, etc) when a specific event (motion detection or start recording ) occurs
+- WIP: Integrations (Webhooks, MQTT, Script, etc).
 - REST API access and documentation through Swagger (trigger recording, update configuration, etc).
 - MIT License
 
 ## How to run and deploy a Kerberos Agent
 
-A Kerberos Agent, as previously mentioned, is a container. You can deploy it using various methods and automation tools, including `docker`, `docker compose`, `kubernetes` and more. To streamline your Kerberos.io experience, we provide concrete deployment examples to speed up your Kerberos.io journey”
+As described before a Kerberos Agent is a container, which can be deployed through various ways and automation tools such as `docker`, `docker compose`, `kubernetes` and the list goes on. To simplify your life we have come with concrete and working examples of deployments to help you speed up your Kerberos.io journey.
 
 We have documented the different deployment models [in the `deployments` directory](https://github.com/kerberos-io/agent/tree/master/deployments) of this repository. There you'll learn and find how to deploy using:
 
@@ -148,7 +134,7 @@ We have documented the different deployment models [in the `deployments` directo
 - [Balena](https://github.com/kerberos-io/agent/tree/master/deployments#8-balena)
 - [Snap](https://github.com/kerberos-io/agent/tree/master/deployments#9-snap)
 
-By default, your Kerberos Agents store all configuration and recordings within the container. To help you automate and have a more consistent data governance, you can attach volumes to configure and persist data of your Kerberos Agents and/or configure each Kerberos Agent through environment variables.
+By default your Kerberos Agents will store all its configuration and recordings inside the container. To help you automate and have a more consistent data governance, you can attach volumes to configure and persist data of your Kerberos Agents, and/or configure each Kerberos Agent through environment variables.
 
 ## Access the Kerberos Agent
 
@@ -163,23 +149,23 @@ The default username and password for the Kerberos Agent is:
 
 ## Configure and persist with volume mounts
 
-An example of how to mount a host directory is shown below using `docker`, but is applicable for [all of the deployment models and tools described above](#running-and-automating-a-kerberos-agent).
+An example of how to mount a host directory is shown below using `docker`, but is applicable for [all the deployment models and tools described above](#running-and-automating-a-kerberos-agent).
 
-You attach a volume to your container by leveraging the `-v` option. To mount your own configuration file and recordings folder, run the following commands:
+You attach a volume to your container by leveraging the `-v` option. To mount your own configuration file and recordings folder, execute as following:
 
     docker run -p 80:80 --name mycamera \
     -v $(pwd)/agent/config:/home/agent/data/config \
     -v $(pwd)/agent/recordings:/home/agent/data/recordings \
     -d --restart=always kerberos/agent:latest
 
-More examples for each deployment and automation tool [can be found in the deployment section](https://github.com/kerberos-io/agent/tree/master/deployments). Be sure to verify the permissions of the directory/volume you are attaching. More information in [this issue](https://github.com/kerberos-io/agent/issues/80).
+More example [can be found in the deployment section](https://github.com/kerberos-io/agent/tree/master/deployments) for each deployment and automation tool. Please note to verify the permissions of the directory/volume you are attaching. More information in [this issue](https://github.com/kerberos-io/agent/issues/80).
 
     chmod -R 755 kerberos-agent/
     chown 100:101 kerberos-agent/ -R
 
 ## Configure with environment variables
 
-Next to attaching the configuration file, it is also possible to override the configuration with environment variables. This makes deploying with `docker compose` or `kubernetes` much easier and more scalable. Using this approach, we simplify automation through `ansible` and `terraform`.
+Next to attaching the configuration file, it is also possible to override the configuration with environment variables. This makes deployments easier when leveraging `docker compose` or `kubernetes` deployments much easier and scalable. Using this approach we simplify automation through `ansible` and `terraform`.
 
     docker run -p 80:80 --name mycamera \
     -e AGENT_NAME=mycamera \
@@ -188,168 +174,65 @@ Next to attaching the configuration file, it is also possible to override the co
     -e AGENT_CAPTURE_CONTINUOUS=true \
     -d --restart=always kerberos/agent:latest
 
-### Secure camera streams (RTSPS)
-
-The Agent accepts `rtsps://` camera URLs. Do not use `srtsp://`; RTSPS is RTSP over TLS. For a Bosch FLEXIDOME micro 3100i, enable **Secure RTSP** under **Network > Network Services** and use port `9554`:
-
-```bash
-AGENT_CAPTURE_IPCAMERA_RTSP='rtsps://username:password@camera.example:9554/?inst=1'
-AGENT_CAPTURE_IPCAMERA_SUB_RTSP='rtsps://username:password@camera.example:9554/?inst=2'
-```
-
-Certificate verification is enabled by default. The URL hostname or IP address must match the camera certificate SAN. On this Bosch firmware, RTSPS presents the certificate assigned to **HTTPS**; there is no separate SRTSP certificate usage. Leave **CBS client** assigned to the Bosch device certificate.
-
-For a private CA, mount a PEM trust bundle containing every CA certificate needed to build the camera certificate chain and set `AGENT_CAPTURE_IPCAMERA_RTSPS_CA_FILE` to its path inside the Agent. The bundle is appended to the system roots for camera RTSPS connections only. This Bosch firmware presents only its leaf certificate, so include both the issuing intermediate and root certificates in the bundle. As a temporary fallback, `AGENT_CAPTURE_IPCAMERA_RTSPS_INSECURE=true` disables certificate verification for camera streams only.
-
-See [RTSPS and TLS certificates](README-RTSPS-TLS.md) for the complete Bosch UI, private-CA, deployment, validation, and troubleshooting procedure.
-
 | Name                                    | Description                                                                                     | Default Value                  |
 | --------------------------------------- | ----------------------------------------------------------------------------------------------- | ------------------------------ |
-| `LOG_LEVEL`                                 | Level for logging, could be "info", "warning", "debug", "error" or "fatal".                     | "info"                         |
-| `LOG_OUTPUT`                                | Logging output format "json" or "text".                                                         | "text"                         |
-| `AGENT_MODE`                                | You can choose to run this in 'release' for production, and or 'demo' for showcasing.           | "release"                      |
-| `AGENT_TLS_INSECURE`                        | Specify if you want to use `InsecureSkipVerify` for the internal HTTP client.                   | "false"                        |
-| `AGENT_USERNAME`                            | The username used to authenticate against the Kerberos Agent login page.                        | "root"                         |
-| `AGENT_PASSWORD`                            | The password used to authenticate against the Kerberos Agent login page.                        | "root"                         |
-| `AGENT_KEY`                                 | A unique identifier for your Kerberos Agent, this is auto-generated but can be overriden.       | ""                             |
-| `AGENT_NAME`                                | The agent friendly-name.                                                                        | "agent"                        |
-| `AGENT_TIMEZONE`                            | Timezone which is used for converting time.                                                     | "Africa/Ceuta"                 |
-| `AGENT_REMOVE_AFTER_UPLOAD`                 | When enabled, recordings uploaded successfully to a storage will be removed from disk.          | "true"                         |
-| `AGENT_OFFLINE`                             | Makes sure no external connection is made.                                                      | "false"                        |
-| `AGENT_AUTO_CLEAN`                          | Cleans up the recordings directory.                                                             | "true"                         |
-| `AGENT_AUTO_CLEAN_MAX_SIZE`                 | If `AUTO_CLEAN` enabled, cap the recordings directory at this size (in MB). When unset/0, recordings may use the whole disk instead (see `AGENT_AUTO_CLEAN_MIN_FREE_SPACE`). | "100"                          |
-| `AGENT_AUTO_CLEAN_MIN_FREE_SPACE`           | When `AUTO_CLEAN` is enabled and no `MAX_SIZE` is set, keep at least this much free space (in MB) on the recordings disk before deleting the oldest (already-uploaded first) recordings. Defaults to 5% of the disk. | ""                             |
-| `AGENT_TIME`                                | Enable the timetable for Kerberos Agent                                                         | "false"                        |
-| `AGENT_TIMETABLE`                           | A (weekly) time table to specify when to make recordings "start1,end1,start2,end2;start1..      | ""                             |
-| `AGENT_REGION_POLYGON`                      | A single polygon set for motion detection: "x1,y1;x2,y2;x3,y3;...                               | ""                             |
-| `AGENT_CAPTURE_IPCAMERA_RTSP`               | Full-HD RTSP or RTSPS endpoint for the target camera.                                           | ""                             |
-| `AGENT_CAPTURE_IPCAMERA_SUB_RTSP`           | RTSP or RTSPS sub-stream endpoint used for livestreaming (WebRTC).                              | ""                             |
-| `AGENT_CAPTURE_IPCAMERA_RTSPS_CA_FILE`      | PEM CA bundle appended to the system roots for RTSPS camera certificate verification.           | ""                             |
-| `AGENT_CAPTURE_IPCAMERA_RTSPS_INSECURE`     | Disable RTSPS camera certificate verification; use only when a trusted CA cannot be installed.  | "false"                        |
-| `AGENT_CAPTURE_IPCAMERA_BASE_WIDTH`         | Force a specific width resolution for live view processing.                                     | ""                             |
-| `AGENT_CAPTURE_IPCAMERA_BASE_HEIGHT`        | Force a specific height resolution for live view processing.                                    | ""                             |
-| `AGENT_CAPTURE_IPCAMERA_ONVIF`              | Mark as a compliant ONVIF device.                                                               | ""                             |
-| `AGENT_CAPTURE_IPCAMERA_ONVIF_XADDR`        | ONVIF endpoint/address running on the camera.                                                   | ""                             |
-| `AGENT_CAPTURE_IPCAMERA_ONVIF_USERNAME`     | ONVIF username to authenticate against.                                                         | ""                             |
-| `AGENT_CAPTURE_IPCAMERA_ONVIF_PASSWORD`     | ONVIF password to authenticate against.                                                         | ""                             |
-| `AGENT_CAPTURE_MOTION`                      | Toggle for enabling or disabling motion.                                                        | "true"                         |
-| `AGENT_CAPTURE_LIVEVIEW`                    | Toggle for enabling or disabling liveview.                                                      | "true"                         |
-| `AGENT_CAPTURE_SNAPSHOTS`                   | Toggle for enabling or disabling snapshot generation.                                           | "true"                         |
-| `AGENT_CAPTURE_RECORDING`                   | Toggle for enabling making recordings.                                                          | "true"                         |
-| `AGENT_CAPTURE_CONTINUOUS`                  | Toggle for enabling continuous "true" or motion "false".                                        | "false"                        |
-| `AGENT_CAPTURE_PRERECORDING`                | If `CONTINUOUS` set to `false`, specify the recording time (seconds) before/after motion event. | "10"                           |
-| `AGENT_CAPTURE_POSTRECORDING`               | If `CONTINUOUS` set to `false`, specify the recording time (seconds) after motion event.        | "20"                           |
-| `AGENT_CAPTURE_MAXLENGTH`                   | The maximum length of a single recording (seconds).                                             | "30"                           |
-| `AGENT_CAPTURE_PIXEL_CHANGE`                | If `CONTINUOUS` set to `false`, the number of pixel require to change before motion triggers.   | "150"                          |
-| `AGENT_CAPTURE_FRAGMENTED`                  | Set the format of the recorded MP4 to fragmented (suitable for HLS).                            | "false"                        |
-| `AGENT_CAPTURE_FRAGMENTED_DURATION`         | If `AGENT_CAPTURE_FRAGMENTED` set to `true`, define the duration (seconds) of a fragment.       | "8"                            |
-| `AGENT_MQTT_URI`                            | An MQTT broker endpoint that is used for bi-directional communication (live view, onvif, etc)   | "tcp://mqtt.kerberos.io:1883"  |
-| `AGENT_MQTT_USERNAME`                       | Username of the MQTT broker.                                                                    | ""                             |
-| `AGENT_MQTT_PASSWORD`                       | Password of the MQTT broker.                                                                    | ""                             |
-| `AGENT_REALTIME_PROCESSING`                 | If `AGENT_REALTIME_PROCESSING` set to `true`, the agent will send key frames to the topic       | ""                             |
-| `AGENT_REALTIME_PROCESSING_TOPIC`           | The topic to which keyframes will be sent in base64 encoded format.                             | ""                             |
-| `AGENT_STUN_URI`                            | When using WebRTC, you'll need to provide a STUN server.                                        | "stun:turn-fra1.kerberos.io:3478"|
-| `AGENT_FORCE_TURN`                          | Force using a TURN server, by generating relay candidates only.                                 | "false"                        |
-| `AGENT_TURN_URI`                            | When using WebRTC, you'll need to provide a TURN server.                                        | "turn:turn-fra1.kerberos.io:3478"|
-| `AGENT_TURN_USERNAME`                       | TURN username used for WebRTC.                                                                  | "username1"                    |
-| `AGENT_TURN_PASSWORD`                       | TURN password used for WebRTC.                                                                  | "password1"                    |
-| `AGENT_CLOUD`                               | Store recordings in Kerberos Hub (s3), Kerberos Vault (kstorage), or Dropbox (dropbox).         | "s3"                           |
-| `AGENT_HUB_ENCRYPTION`                      | Turning on/off encryption of traffic from your Kerberos Agent to Kerberos Hub.                  | "true"                         |
-| `AGENT_HUB_URI`                             | The Kerberos Hub API, defaults to our Kerberos Hub SAAS.                                        | "https://api.hub.domain.com"   |
-| `AGENT_HUB_KEY`                             | The access key linked to your account in Kerberos Hub.                                          | ""                             |
-| `AGENT_HUB_PRIVATE_KEY`                     | The secret access key linked to your account in Kerberos Hub.                                   | ""                             |
-| `AGENT_HUB_REGION`                          | The Kerberos Hub region, to which you want to upload.                                           | ""                             |
-| `AGENT_HUB_SITE`                            | The site ID of a site you've created in your Kerberos Hub account.                              | ""                             |
-| `AGENT_TUS_CHUNK_SIZE_BYTES`                | Bytes sent in each resumable-upload PATCH. Set to `0` or a negative value to send all remaining bytes in one PATCH. | "8388608" (8 MiB)              |
-| `AGENT_KERBEROSVAULT_URI`                   | The Kerberos Vault API url.                                                                     | "https://vault.domain.com/api" |
-| `AGENT_KERBEROSVAULT_ACCESS_KEY`            | The access key of a Kerberos Vault account.                                                     | ""                             |
-| `AGENT_KERBEROSVAULT_SECRET_KEY`            | The secret key of a Kerberos Vault account.                                                     | ""                             |
-| `AGENT_KERBEROSVAULT_PROVIDER`              | A Kerberos Vault provider you have created (optional).                                          | ""                             |
-| `AGENT_KERBEROSVAULT_DIRECTORY`             | The directory, in the Kerberos vault, where the recordings will be stored.                      | ""                             |
-| `AGENT_KERBEROSVAULT_SECONDARY_URI`         | The Kerberos Vault API url.                                                                     | "https://vault.domain.com/api" |
-| `AGENT_KERBEROSVAULT_SECONDARY_ACCESS_KEY`  | The access key of a secondary Kerberos Vault account.                                           | ""                             |
-| `AGENT_KERBEROSVAULT_SECONDARY_SECRET_KEY`  | The secret key of a secondary Kerberos Vault account.                                           | ""                             |
-| `AGENT_KERBEROSVAULT_SECONDARY_PROVIDER`    | A secondary Kerberos Vault provider you have created (optional).                                | ""                             |
-| `AGENT_KERBEROSVAULT_SECONDARY_DIRECTORY`   | The directory, in the secondary Kerberos vault, where the recordings will be stored.            | ""                             |
-| `AGENT_DROPBOX_ACCESS_TOKEN`                | The Access Token from your Dropbox app, that is used to leverage the Dropbox SDK.               | ""                             |
-| `AGENT_DROPBOX_DIRECTORY`                   | The directory, in Dropbox, where the recordings will be stored.                                 | ""                             |
-| `AGENT_ENCRYPTION`                          | Enable 'true' or disable 'false' end-to-end encryption for MQTT messages.                       | "false"                        |
-| `AGENT_ENCRYPTION_RECORDINGS`               | Enable 'true' or disable 'false' end-to-end encryption for recordings.                          | "false"                        |
-| `AGENT_ENCRYPTION_FINGERPRINT`              | The fingerprint of the keypair (public/private keys), so you know which one to use.             | ""                             |
-| `AGENT_ENCRYPTION_PRIVATE_KEY`              | The private key (assymetric/RSA) to decrypt and sign requests send over MQTT.                   | ""                             |
-| `AGENT_ENCRYPTION_SYMMETRIC_KEY`            | The symmetric key (AES) to encrypt and decrypt requests sent over MQTT.                         | ""                             |
-| `AGENT_SIGNING`                             | Enable 'true' or disable 'false' for signing recordings.                                        | "true"                         |
-| `AGENT_SIGNING_PRIVATE_KEY`                 | The private key (RSA) to sign the recordings fingerprint to validate origin.                    | "" - uses default one if empty |
-
-### Resumable upload chunk size
-
-Hub and Vault resumable uploads use `AGENT_TUS_CHUNK_SIZE_BYTES` as the maximum
-body size of each tus `PATCH` request. The value is a number of bytes, not a
-number of chunks. If the variable is unset or invalid, the Agent uses 8 MiB:
-
-```dotenv
-# 8 MiB (default)
-AGENT_TUS_CHUNK_SIZE_BYTES=8388608
-
-# 4 MiB: more frequent checkpoints on unstable connections
-AGENT_TUS_CHUNK_SIZE_BYTES=4194304
-
-# Disable chunking and send all remaining bytes in one PATCH
-AGENT_TUS_CHUNK_SIZE_BYTES=0
-```
-
-Smaller chunks provide more frequent resumable checkpoints but create more HTTP
-requests. Larger chunks reduce request overhead but require more data to be
-retransmitted when a request fails.
-
-
-## Encryption
-
-You can encrypt your recordings and outgoing MQTT messages with your own AES and RSA keys by enabling the encryption settings. Once enabled, all your recordings will be encrypted using AES-256-CBC and your symmetric key. You can use the default `openssl` toolchain to decrypt the recordings with your AES key, as following:
-
-    openssl aes-256-cbc -d -md md5 -in encrypted.mp4 -out decrypted.mp4 -k your-key-96ab185xxxxxxxcxxxxxxxx6a59c62e8
-
-Or you can decrypt a folder of recordings, using the Kerberos Agent binary as following:
-
-    go run main.go -action decrypt ./data/recordings your-key-96ab185xxxxxxxcxxxxxxxx6a59c62e8
-
-Or for a single file:
-
-    go run main.go -action decrypt ./data/recordings/video.mp4 your-key-96ab185xxxxxxxcxxxxxxxx6a59c62e8
-
-## H264 vs H265
-
-If we talk about video encoders and decoders (codecs) there are 2 major video codecs on the market: H264 and H265. Taking into account your use case, you might use one over the other. We will provide an (not complete) overview of the advantages and disadvantages of each codec in the field of video surveillance and video analytics. If you would like to know more, you should look for additional resources on the internet (or if you like to read physical items, books still exists nowadays).
-
-- H264 (also known as AVC or MPEG-4 Part 10)
-
-  - Is the most common one and most widely supported for IP cameras.
-  - Supported in the majority of browsers, operating system, and third-party applications.
-  - Can be embedded in commercial and 3rd party applications.
-  - Different levels of compression (high, medium, low, ..)
-  - Better quality / compression ratio, shows less artifacts at medium compression ratios.
-  - Does support technologies such as WebRTC
-
-- H265 (also known as HEVC)
-  - Is not supported on legacy cameras, though becoming rapidly available on "newer" IP cameras.
-  - Might not always be supported due to licensing. For example not supported in browers on a Linux distro.
-  - Requires licensing when embedding in a commercial product (be careful).
-  - Higher levels of compression (50% more than H264).
-  - H265 shows artifacts in motion based environments (which is less with H264).
-  - Recording the same video (resolution, duration and FPS) in H264 and H265 will result in approx 50% the file size.
-  - Not supported in technologies such as WebRTC
-
-Conclusion: depending on the use case you might choose one over the other, and you can use both at the same time. For example you can use H264 (main stream) for livestreaming, and H265 (sub stream) for recording. If you wish to play recordings in a cross-platform and cross-browser environment, you might opt for H264 for better support.
-
-## Security vulnerability reporting
-
-If you found a potential security vulnerability, please use the private channels described in [SECURITY.md](SECURITY.md). Avoid opening public GitHub issues for sensitive findings.
+| `AGENT_MODE`                            | You can choose to run this in 'release' for production, and or 'demo' for showcasing.           | "release"                      |
+| `AGENT_TLS_INSECURE`                    | Specify if you want to use `InsecureSkipVerify` for the internal HTTP client.                   | "false"                        |
+| `AGENT_USERNAME`                        | The username used to authenticate against the Kerberos Agent login page.                        | "root"                         |
+| `AGENT_PASSWORD`                        | The password used to authenticate against the Kerberos Agent login page.                        | "root"                         |
+| `AGENT_KEY`                             | A unique identifier for your Kerberos Agent, this is auto-generated but can be overriden.       | ""                             |
+| `AGENT_NAME`                            | The agent friendly-name.                                                                        | "agent"                        |
+| `AGENT_TIMEZONE`                        | Timezone which is used for converting time.                                                     | "Africa/Ceuta"                 |
+| `AGENT_REMOVE_AFTER_UPLOAD`             | When enabled, recordings uploaded successfully to a storage will be removed from disk.          | "true"                         |
+| `AGENT_OFFLINE`                         | Makes sure no external connection is made.                                                      | "false"                        |
+| `AGENT_AUTO_CLEAN`                      | Cleans up the recordings directory.                                                             | "true"                         |
+| `AGENT_AUTO_CLEAN_MAX_SIZE`             | If `AUTO_CLEAN` enabled, set the max size of the recordings directory in (MB).                  | "100"                          |
+| `AGENT_TIME`                            | Enable the timetable for Kerberos Agent                                                         | "false"                        |
+| `AGENT_TIMETABLE`                       | A (weekly) time table to specify when to make recordings "start1,end1,start2,end2;start1..      | ""                             |
+| `AGENT_REGION_POLYGON`                  | A single polygon set for motion detection: "x1,y1;x2,y2;x3,y3;...                               | ""                             |
+| `AGENT_CAPTURE_IPCAMERA_RTSP`           | Full-HD RTSP endpoint to the camera you're targetting.                                          | ""                             |
+| `AGENT_CAPTURE_IPCAMERA_SUB_RTSP`       | Sub-stream RTSP endpoint used for livestreaming (WebRTC).                                       | ""                             |
+| `AGENT_CAPTURE_IPCAMERA_ONVIF`          | Mark as a compliant ONVIF device.                                                               | ""                             |
+| `AGENT_CAPTURE_IPCAMERA_ONVIF_XADDR`    | ONVIF endpoint/address running on the camera.                                                   | ""                             |
+| `AGENT_CAPTURE_IPCAMERA_ONVIF_USERNAME` | ONVIF username to authenticate against.                                                         | ""                             |
+| `AGENT_CAPTURE_IPCAMERA_ONVIF_PASSWORD` | ONVIF password to authenticate against.                                                         | ""                             |
+| `AGENT_CAPTURE_MOTION`                  | Toggle for enabling or disabling motion.                                                        | "true"                         |
+| `AGENT_CAPTURE_LIVEVIEW`                | Toggle for enabling or disabling liveview.                                                      | "true"                         |
+| `AGENT_CAPTURE_SNAPSHOTS`               | Toggle for enabling or disabling snapshot generation.                                           | "true"                         |
+| `AGENT_CAPTURE_RECORDING`               | Toggle for enabling making recordings.                                                          | "true"                         |
+| `AGENT_CAPTURE_CONTINUOUS`              | Toggle for enabling continuous "true" or motion "false".                                        | "false"                        |
+| `AGENT_CAPTURE_PRERECORDING`            | If `CONTINUOUS` set to `false`, specify the recording time (seconds) before after motion event. | "10"                           |
+| `AGENT_CAPTURE_POSTRECORDING`           | If `CONTINUOUS` set to `false`, specify the recording time (seconds) after motion event.        | "20"                           |
+| `AGENT_CAPTURE_MAXLENGTH`               | The maximum length of a single recording (seconds).                                             | "30"                           |
+| `AGENT_CAPTURE_PIXEL_CHANGE`            | If `CONTINUOUS` set to `false`, the number of pixel require to change before motion triggers.   | "150"                          |
+| `AGENT_CAPTURE_FRAGMENTED`              | Set the format of the recorded MP4 to fragmented (suitable for HLS).                            | "false"                        |
+| `AGENT_CAPTURE_FRAGMENTED_DURATION`     | If `AGENT_CAPTURE_FRAGMENTED` set to `true`, define the duration (seconds) of a fragment.       | "8"                            |
+| `AGENT_MQTT_URI`                        | A MQTT broker endpoint that is used for bi-directional communication (live view, onvif, etc)    | "tcp://mqtt.kerberos.io:1883"  |
+| `AGENT_MQTT_USERNAME`                   | Username of the MQTT broker.                                                                    | ""                             |
+| `AGENT_MQTT_PASSWORD`                   | Password of the MQTT broker.                                                                    | ""                             |
+| `AGENT_STUN_URI`                        | When using WebRTC, you'll need to provide a STUN server.                                        | "stun:turn.kerberos.io:8443"   |
+| `AGENT_TURN_URI`                        | When using WebRTC, you'll need to provide a TURN server.                                        | "turn:turn.kerberos.io:8443"   |
+| `AGENT_TURN_USERNAME`                   | TURN username used for WebRTC.                                                                  | "username1"                    |
+| `AGENT_TURN_PASSWORD`                   | TURN password used for WebRTC.                                                                  | "password1"                    |
+| `AGENT_CLOUD`                           | Store recordings in Kerberos Hub (s3), Kerberos Vault (kstorage) or Dropbox (dropbox).          | "s3"                           |
+| `AGENT_HUB_URI`                         | The Kerberos Hub API, defaults to our Kerberos Hub SAAS.                                        | "https://api.hub.domain.com"   |
+| `AGENT_HUB_KEY`                         | The access key linked to your account in Kerberos Hub.                                          | ""                             |
+| `AGENT_HUB_PRIVATE_KEY`                 | The secret access key linked to your account in Kerberos Hub.                                   | ""                             |
+| `AGENT_HUB_REGION`                      | The Kerberos Hub region, to which you want to upload.                                           | ""                             |
+| `AGENT_HUB_SITE`                        | The site ID of a site you've created in your Kerberos Hub account.                              | ""                             |
+| `AGENT_KERBEROSVAULT_URI`               | The Kerberos Vault API url.                                                                     | "https://vault.domain.com/api" |
+| `AGENT_KERBEROSVAULT_ACCESS_KEY`        | The access key of a Kerberos Vault account.                                                     | ""                             |
+| `AGENT_KERBEROSVAULT_SECRET_KEY`        | The secret key of a Kerberos Vault account.                                                     | ""                             |
+| `AGENT_KERBEROSVAULT_PROVIDER`          | A Kerberos Vault provider you have created (optional).                                          | ""                             |
+| `AGENT_KERBEROSVAULT_DIRECTORY`         | The directory, in the provider, where the recordings will be stored in.                         | ""                             |
+| `AGENT_DROPBOX_ACCESS_TOKEN`            | The Access Token from your Dropbox app, that is used to leverage the Dropbox SDK.               | ""                             |
+| `AGENT_DROPBOX_DIRECTORY`               | The directory, in the provider, where the recordings will be stored in.                         | ""                             |
 
 ## Contribute with Codespaces
 
-One of the major blockers for letting you contribute to an Open Source project is to set up your local development machine. Why? Because you might already have some tools and libraries installed that are used for other projects, and the libraries you would need for Kerberos Agent, for example FFmpeg, might require a different version. Welcome to dependency hell...
+One of the major blockers for letting you contribute to an Open Source project is to setup your local development machine. Why? Because you might have already some tools and libraries installed that are used for other projects, and the libraries you would need for Kerberos Agent, for example FFmpeg, might require a different version. Welcome to the dependency hell..
 
-By leveraging codespaces, which the Kerberos Agent repo supports, you will be able to set up the required development environment in a few minutes. By opening the `<> Code` tab on the top of the page, you will be able to create a codespace, [using the Kerberos Devcontainer](https://github.com/kerberos-io/devcontainer) base image. This image requires all the relevant dependencies: FFmpeg, OpenCV, Golang, Node, Yarn, etc.
+By leveraging codespaces, which the Kerberos Agent repo supports, you will be able to setup the required development environment in a few minutes. By opening the `<> Code` tab on the top of the page, you will be able to create a codespace, [using the Kerberos Devcontainer](https://github.com/kerberos-io/devcontainer) base image. This image requires all the relevant dependencies: FFmpeg, OpenCV, Golang, Node, Yarn, etc.
 
 ![Kerberos Agent codespace](assets/img/codespace.png)
 
@@ -376,7 +259,7 @@ On opening of the GitHub Codespace, some dependencies will be installed. Once th
       WS_URL: `${websocketprotocol}//${externalHost}/ws`,
     };
 
-Go and open two terminals: one for the `ui` project and one for the `machinery` project.
+Go and open two terminals one for the `ui` project and one for the `machinery` project.
 
 1.  Terminal A:
 
@@ -392,11 +275,11 @@ Once executed, a popup will show up mentioning `portforwarding`. You should see
 
 ![Codespace make public](./assets/img/codespace-make-public.png)
 
-As mentioned above, copy the hostname of the `machinery` DNS name, and paste it in the `ui/src/config.json` file. Once done, reload the `ui` page in your browser, and you should be able to access the login page with the default credentials `root` and `root`.
+As mentioned above, copy the hostname of the `machinery` DNS name, and past it in the `ui/src/config.json` file. Once done reload, the `ui` page in your browser, and you should be able to access the login page with the default credentials `root` and `root`.
 
 ## Develop and build
 
-The Kerberos Agent is divided in two parts: a `machinery` and `web` part. Both parts live in this repository in their relative folders. For development or running the application on your local machine, you have to run both the `machinery` and the `web` as described below. When running in production everything is shipped as only one artifact, read more about this at [Building for production](#building-for-production).
+Kerberos Agent is divided in two parts a `machinery` and `web`. Both parts live in this repository in their relative folders. For development or running the application on your local machine, you have to run both the `machinery` and the `web` as described below. When running in production everything is shipped as only one artifact, read more about this at [Building for production](#building-for-production).
 
 ### UI
 
@@ -410,13 +293,13 @@ This will start a webserver and launches the web app on port `3000`.
 
 ![login-agent](./assets/img/agent-login.gif)
 
-Once signed in you'll see the dashboard page. After successfull configuration of your agent, you'll should see a live view and possible events recorded to disk.
+Once signed in you'll see the dashboard page showing up. After successfull configuration of your agent, you'll should see a live view and possible events recorded to disk.
 
 ![dashboard-agent](./assets/img/agent-dashboard.png)
 
 ### Machinery
 
-The `machinery` is a **Golang** project which delivers two functions: it acts as the Kerberos Agent which is doing all the heavy lifting with camera processing and other kinds of logic and on the other hand it acts as a webserver (Rest API) that allows communication from the web (React) or any other custom application. The API is documented using `swagger`.
+The `machinery` is a **Golang** project which delivers two functions: it acts as the Kerberos Agent which is doing all the heavy lifting with camera processing and other kinds of logic, on the other hand it acts as a webserver (Rest API) that allows communication from the web (React) or any other custom application. The API is documented using `swagger`.
 
 You can simply run the `machinery` using following commands.
 
@@ -424,13 +307,13 @@ You can simply run the `machinery` using following commands.
     cd machinery
     go run main.go -action run -port 80
 
-This will launch the Kerberos Agent and run a webserver on port `80`. You can change the port by your own preference. We strongly support the usage of [Goland](https://www.jetbrains.com/go/) or [Visual Studio Code](https://code.visualstudio.com/), as it comes with all the debugging and linting features built in.
+This will launch the Kerberos Agent and run a webserver on port `80`. You can change the port by your own preference. We strongly support the usage of [Goland](https://www.jetbrains.com/go/) or [Visual Studio Code](https://code.visualstudio.com/), as it comes with all the debugging and linting features builtin.
 
 ![VSCode desktop](./assets/img/vscode-desktop.png)
 
 ## Building from source
 
-Running Kerberos Agent in production only requires a single binary to run. Nevertheless, we have two parts: the `machinery` and the `web`, we merge them during build time. So this is what happens.
+Running Kerberos Agent in production only require a single binary to run. Nevertheless, we have two parts, the `machinery` and the `web`, we merge them during build time. So this is what happens.
 
 ### UI
 
@@ -441,7 +324,7 @@ To build the Kerberos Agent web app, you simply have to run the `build` command
 
 ### Machinery
 
-Building the `machinery` is also super easy 🚀, by using `go build` you can create a single binary which ships it all; thank you Golang. After building you will end up with a binary called `main`, this is what contains everything you need to run Kerberos Agent.
+Building the `machinery` is also super easy 🚀, by using `go build` you can create a single binary which ships it all; thank you Golang. After building you will endup with a binary called `main`, this is what contains everything you need to run Kerberos Agent.
 
 Remember the build step of the `web` part, during build time we move the build directory to the `machinery` directory. Inside the `machinery` web server [we reference the](https://github.com/kerberos-io/agent/blob/master/machinery/src/routers/http/Server.go#L44) `build` directory. This makes it possible to just a have single web server that runs it all.
 
@@ -450,66 +333,13 @@ Remember the build step of the `web` part, during build time we move the build d
 
 ## Building for Docker
 
-Inside the root of this `agent` repository, you will find a `Dockerfile`. This file contains the instructions for building and shipping a **Kerberos Agent**. It uses Debian Trixie to support the native dependencies used by the Agent, including Media over QUIC.
+Inside the root of this `agent` repository, you will find a `Dockerfile`. This file contains the instructions for building and shipping **Kerberos Agent**. Important to note is that start from a prebuild base image, `kerberos/base:xxx`.
+This base image contains already a couple of tools, such as Golang, FFmpeg and OpenCV. We do this for faster compilation times.
 
 By running the `docker build` command, you will create the Kerberos Agent Docker image. After building you can simply run the image as a Docker container.
 
     docker build -t kerberos/agent .
 
-### Media over QUIC
-
-The standard AMD64 and ARM64 images include the optional MoQ publisher. Its Rust
-FFI archive requires CGO and glibc 2.38 or newer, which is why the standard image
-uses Debian Trixie. The publisher is disabled unless explicitly enabled at runtime:
-
-    docker run --rm -p 80:80 \
-      -e AGENT_LIVE_MOQ_ENABLED=true \
-      -e AGENT_LIVE_MOQ_URL=https://relay.uug.ai/anon \
-      kerberos/agent
-
-`AGENT_LIVE_MOQ_BROADCAST_PREFIX` defaults to `devices`. MoQ viewers subscribe to
-a relay and never negotiate with the Agent, so every quality tier is published as
-its own broadcast and switching quality is simply a resubscribe:
-
-| Tier   | Broadcast                             | Source                                     |
-| ------ | ------------------------------------- | ------------------------------------------ |
-| `high` | `devices/<agent-key>/live.hang`       | highest-resolution camera stream           |
-| `low`  | `devices/<agent-key>/live-low.hang`   | sub stream (main stream when none is set)  |
-
-Each tier only uploads while it has at least one subscriber, so the tier nobody
-watches costs virtually no bandwidth. `AGENT_LIVE_MOQ_QUALITY` accepts `high` or
-`low` to pin the Agent to a single tier; viewers requesting the other tier then
-find no broadcast. Any other value (including the default) publishes both. The
-initial implementation publishes H.264 video only.
-
-Two bounded duration settings tune recovery for unusual network conditions:
-
-| Variable | Default | Allowed range |
-| -------- | ------- | ------------- |
-| `AGENT_LIVE_MOQ_MAX_PACKET_AGE` | `1.5s` | `250ms` to `30s` |
-| `AGENT_LIVE_MOQ_WRITE_TIMEOUT` | `5s` | `1s` to `1m` |
-
-Values use Go duration syntax and are clamped to the documented range. The
-dashboard API's `recovery` object reports per-tier reconnects, last successful
-frame/write timing, native write timeouts, watchdog restarts/cooldown, dropped
-run-channel events, and run-worker shutdown timeouts.
-
-The `/anon` relay route is intended for interoperability testing. Production
-deployments must set `AGENT_LIVE_MOQ_URL` to a short-lived, device-scoped
-publisher URL issued by Hub API.
-
-To verify the native SDK in a development container, rebuild the Agent or shared
-monorepo devcontainer so it uses the Trixie base, then run the VS Code task
-`agent: moq verify`. The same check is available from a terminal:
-
-    cd machinery
-    bash ./verify-moq-devcontainer.sh
-
-The check requires glibc 2.38 or newer, runs the tagged package and in-process
-native QUIC lifecycle tests, links the complete Agent with `-tags moq`, and
-executes the resulting binary's version
-command. Both devcontainers also run this check during their post-create setup.
-
 ## What is new?
 
 This repository contains the next generation of Kerberos.io, **Kerberos Agent (v3)**, and is the successor of the machinery and web repositories. A switch in technologies and architecture has been made. This version is still under active development and can be followed on the [develop branch](https://github.com/kerberos-io/agent/tree/develop) and [project overview](https://github.com/kerberos-io/agent/projects/1).
@@ -520,7 +350,7 @@ Read more about this [at the FAQ](#faq) below.
 
 ## Contributors
 
-This project exists thanks to all the people who contribute. Bravo!
+This project exists thanks to all the people who contribute.
 
 <a href="https://github.com/kerberos-io/agent/graphs/contributors">
   <img src="https://contrib.rocks/image?repo=kerberos-io/agent" />

SECURITY.md

@@ -1,40 +0,0 @@
-# Security Policy
-
-## Supported Versions
-
-We only provide security fixes for the latest release series on the `master` branch.
-
-## Reporting a Vulnerability
-
-Please do **not** open a public GitHub issue for potential security vulnerabilities.
-
-Use one of the private channels below:
-
-1. Preferred: GitHub private vulnerability reporting
-   - https://github.com/kerberos-io/agent/security/advisories/new
-2. Fallback: Email
-   - support@kerberos.io
-   - Optional CC: support@uug.ai
-
-Please include:
-
-- A short summary and impact.
-- Reproduction steps or proof of concept.
-- Affected version(s), commit hash, or deployment details.
-- Any proposed mitigation/workaround.
-- Your preferred attribution name.
-
-For faster triage, use this subject format in email:
-
-`[Security][Kerberos Agent] <short title>`
-
-## Response Expectations
-
-- Acknowledgement target: within 3 business days.
-- Triage/update target: within 7 business days after acknowledgement.
-
-If you do not receive a response in time, please resend your report and include your original timestamp.
-
-## Disclosure and Credits
-
-We follow coordinated disclosure. After a fix is available, we will credit reporters unless they prefer to stay anonymous.

build.sh

@@ -0,0 +1,10 @@
+export version=0.0.1
+export name=agent
+
+docker build -t $name .
+
+docker tag $name kerberos/$name:$version
+docker push kerberos/$name:$version
+
+docker tag $name kerberos/$name:latest
+docker push kerberos/$name:latest

deployments/binary/README.md

@@ -9,7 +9,7 @@ Kerberos Agents are now also shipped as static binaries. Within the Docker image
 
 You can run the binary as following on port `8080`:
 
-    main -action=run -port=80
+    main run cameraname 8080
 
 ## Systemd
 
@@ -18,7 +18,7 @@ When running on a Linux OS you might consider to auto-start the Kerberos Agent u
     [Unit]
     Wants=network.target
     [Service]
-    ExecStart=/home/pi/agent/main -action=run -port=80
+    ExecStart=/home/pi/agent/main run camera 80
     WorkingDirectory=/home/pi/agent/
     [Install]
     WantedBy=multi-user.target

deployments/docker/README.md

@@ -36,12 +36,12 @@ You attach a volume to your container by leveraging the `-v` option. To mount yo
 
         docker run -p 80:80 --name mycamera \
         -v $(pwd)/agent/config:/home/agent/data/config \
-        -v $(pwd)/agent/recordings:/home/agent/data/recordings \
-        -d --restart=always kerberos/agent:latest
+        -v $(pwd)/agent/recordings:/home/agent/data/recordings\
+        -d --restart=alwayskerberos/agent:latest
 
 ### Override with environment variables
 
-Next to attaching the configuration file, it is also possible to override the configuration with environment variables. This makes deployments when leveraging `docker compose` or `kubernetes` much easier and more scalable. Using this approach we simplify automation through `ansible` and `terraform`. You'll find [the full list of environment variables on the main README.md file](https://github.com/kerberos-io/agent#override-with-environment-variables).
+Next to attaching the configuration file, it is also possible to override the configuration with environment variables. This makes deployments easier when leveraging `docker compose` or `kubernetes` deployments much easier and scalable. Using this approach we simplify automation through `ansible` and `terraform`. You'll find [the full list of environment variables on the main README.md file](https://github.com/kerberos-io/agent#override-with-environment-variables).
 
 ### 2. Running multiple containers with Docker compose
 

deployments/docker/docker-compose.yaml

@@ -1,38 +1,35 @@
 version: "3.9"
-x-common-variables: &common-variables
-  # Add variables here to add them to all agents
-  AGENT_HUB_KEY: "xxxxx" # The access key linked to your account in Kerberos Hub.
-  AGENT_HUB_PRIVATE_KEY: "xxxxx" # The secret access key linked to your account in Kerberos Hub.
-  # find full list of environment variables here: https://github.com/kerberos-io/agent#override-with-environment-variables
 services:
   kerberos-agent1:
     image: "kerberos/agent:latest"
     ports:
       - "8081:80"
     environment:
-      <<: *common-variables
-      AGENT_NAME: agent1
-      AGENT_CAPTURE_IPCAMERA_RTSP: rtsp://username:password@x.x.x.x/Streaming/Channels/101 # Hikvision camera RTSP url example
-      AGENT_KEY: "1"
+      - AGENT_NAME=agent1
+      - AGENT_CAPTURE_IPCAMERA_RTSP=rtsp://x.x.x.x:554/Streaming/Channels/101
+      - AGENT_HUB_KEY=xxx
+      - AGENT_HUB_PRIVATE_KEY=xxx
+      - AGENT_CAPTURE_CONTINUOUS=true
+      - AGENT_CAPTURE_PRERECORDING=10
+      - AGENT_CAPTURE_POSTRECORDING=10
+      - AGENT_CAPTURE_MAXLENGTH=60
+      - AGENT_CAPTURE_PIXEL_CHANGE=150
+      # find full list of environment variables here: https://github.com/kerberos-io/agent#override-with-environment-variables
   kerberos-agent2:
     image: "kerberos/agent:latest"
     ports:
       - "8082:80"
     environment:
-      <<: *common-variables
-      AGENT_NAME: agent2
-      AGENT_CAPTURE_IPCAMERA_RTSP: rtsp://username:password@x.x.x.x/channel1 # Linksys camera RTSP url example
-      AGENT_KEY: "2"
+      - AGENT_NAME=agent2
+      - AGENT_CAPTURE_IPCAMERA_RTSP=rtsp://x.x.x.x:554/Streaming/Channels/101
+      - AGENT_HUB_KEY=yyy
+      - AGENT_HUB_PRIVATE_KEY=yyy
   kerberos-agent3:
     image: "kerberos/agent:latest"
     ports:
       - "8083:80"
     environment:
-      <<: *common-variables
-      AGENT_NAME: agent3
-      AGENT_CAPTURE_IPCAMERA_RTSP: rtsp://username:password@x.x.x.x/cam/realmonitor?channel=1&subtype=1 # Dahua camera RTSP url example
-      AGENT_KEY: "3"
-networks:
-  default:
-    name: cluster-net
-    external: true
+      - AGENT_NAME=agent3
+      - AGENT_CAPTURE_IPCAMERA_RTSP=rtsp://x.x.x.x:554/Streaming/Channels/101
+      - AGENT_HUB_KEY=zzz
+      - AGENT_HUB_PRIVATE_KEY=zzz

deployments/kubernetes/deployment-agent.yml

@@ -16,7 +16,7 @@ spec:
     spec:
       containers:
         - name: agent
-          image: kerberos/agent:3.2.3
+          image: kerberos/agent:latest
           ports:
             - containerPort: 80
               protocol: TCP
@@ -50,4 +50,4 @@ spec:
     - port: 80
       targetPort: 80
   selector:
-    app: agent
+    app: agent

machinery/.env

@@ -1,38 +0,0 @@
-AGENT_NAME=camera-name
-AGENT_KEY=uniq-camera-id
-AGENT_TIMEZONE=Europe/Brussels
-#AGENT_CAPTURE_CONTINUOUS=true
-#AGENT_CAPTURE_IPCAMERA_RTSP=rtsp://fake.kerberos.io/stream
-#AGENT_CAPTURE_IPCAMERA_SUB_RTSP=rtsp://fake.kerberos.io/stream
-AGENT_CAPTURE_IPCAMERA_ONVIF_XADDR=x.x.x.x
-AGENT_CAPTURE_IPCAMERA_ONVIF_USERNAME=xxx
-AGENT_CAPTURE_IPCAMERA_ONVIF_PASSWORD=xxx
-AGENT_HUB_URI=https://api.cloud.kerberos.io
-AGENT_HUB_KEY=AKIXxxx4JBEI
-AGENT_HUB_PRIVATE_KEY=DIOXxxxAlYpaxxxxXioL0txxx
-AGENT_HUB_SITE=681xxxxxxx9bcda5
-
-# By default will send to Hub (=S3), if you wish to send to Kerberos Vault, set to "kstorage"
-AGENT_CLOUD=s3
-AGENT_KERBEROSVAULT_URI=
-AGENT_KERBEROSVAULT_PROVIDER=
-AGENT_KERBEROSVAULT_DIRECTORY=
-AGENT_KERBEROSVAULT_ACCESS_KEY=
-AGENT_KERBEROSVAULT_SECRET_KEY=
-AGENT_KERBEROSVAULT_MAX_RETRIES=10
-AGENT_KERBEROSVAULT_TIMEOUT=120
-AGENT_KERBEROSVAULT_SECONDARY_URI=
-AGENT_KERBEROSVAULT_SECONDARY_PROVIDER=
-AGENT_KERBEROSVAULT_SECONDARY_DIRECTORY=
-AGENT_KERBEROSVAULT_SECONDARY_ACCESS_KEY=
-AGENT_KERBEROSVAULT_SECONDARY_SECRET_KEY=
-
-# Resumable (tus) uploads to Kerberos Vault are enabled by default.
-# Set to true to fall back to the legacy single-shot POST /storage upload.
-#AGENT_DISABLE_RESUMABLE_UPLOAD=true
-# Bytes sent per PATCH request (default 1 MiB = 1048576). 0 disables chunking
-# and sends the whole file in a single PATCH.
-AGENT_TUS_CHUNK_SIZE_BYTES=1048576
-
-# Open telemetry tracing endpoint
-OTEL_EXPORTER_OTLP_ENDPOINT=

machinery/.vscode/launch.json

@@ -0,0 +1,18 @@
+{
+    // Use IntelliSense to learn about possible attributes.
+    // Hover to view descriptions of existing attributes.
+    // For more information, visit: https://go.microsoft.com/fwlink/?linkid=830387
+    "version": "0.2.0",
+    "configurations": [
+        {
+            "name": "Launch Package",
+            "type": "go",
+            "request": "launch",
+            "mode": "auto",
+            "program": "main.go",
+            "args": ["-action", "run"],
+            "envFile": "${workspaceFolder}/.env",
+            "buildFlags": "--tags dynamic",
+        },
+    ]
+}

machinery/README.md

@@ -5,6 +5,7 @@
 <a target="_blank" href="https://twitter.com/kerberosio?ref_src=twsrc%5Etfw"><img src="https://img.shields.io/twitter/url.svg?label=Follow%20%40kerberosio&style=social&url=https%3A%2F%2Ftwitter.com%2Fkerberosio" alt="Twitter Widget"></a>
 <a target="_blank" href="https://join.slack.com/t/kerberosio/shared_invite/zt-1a5oj4pwm-O4qCAN9c5r2um0Ns0ge8ww"><img src="https://img.shields.io/badge/slack-@kerberosio-yellow.svg?logo=slack " alt="Kerberos.io"></a>
 
+<a target="_blank" href="https://circleci.com/gh/kerberos-io/agent"><img src="https://circleci.com/gh/kerberos-io/agent.svg?style=svg"/></a>
 <img src="https://github.com/kerberos-io/agent/workflows/Go/badge.svg"/>
 <img src="https://github.com/kerberos-io/agent/workflows/CodeQL/badge.svg"/>
 
@@ -21,8 +22,4 @@ https://brianmacdonald.github.io/Ethonate/address#0xf4a759C9436E2280Ea9cdd23d314
 
 [**Docker Hub**](https://hub.docker.com/r/kerberos/agent) | [**Documentation**](https://doc.kerberos.io) | [**Website**](https://kerberos.io)
 
-Kerberos Open source (v3) is a cutting edge video surveillance management system made available as Open Source under the MIT License. This means that all the source code is available for you or your company, and you can use, transform and distribute the source code; as long you keep a reference of the original license. Kerberos Open Source (v3) can be used for commercial usage (which was not the case for v2). Read more [about the license here](LICENSE).
-
-## Security reporting
-
-For sensitive vulnerabilities, use private disclosure channels documented in [../SECURITY.md](../SECURITY.md).
+Kerberos Open source (v3) is a cutting edge video surveillance management system made available as Open Source under the MIT License. This means that all the source code is available for you or your company, and you can use, transform and distribute the source code; as long you keep a reference of the original license. Kerberos Open Source (v3) can be used for commercial usage (which was not the case for v2). Read more [about the license here](LICENSE).

machinery/cmd/mp4analyze/main.go

@@ -1,636 +0,0 @@
-package main
-
-import (
-	"flag"
-	"fmt"
-	"os"
-	"sort"
-
-	"github.com/Eyevinn/mp4ff/avc"
-	mp4ff "github.com/Eyevinn/mp4ff/mp4"
-)
-
-func main() {
-	fromFlag := flag.Int64("from", -1, "start of the detailed inspection window (track timescale units); default auto-detects the largest keyframe gap")
-	toFlag := flag.Int64("to", -1, "end of the detailed inspection window (track timescale units); default auto-detected")
-	flag.Parse()
-	if flag.NArg() < 1 {
-		fmt.Println("usage: mp4analyze [-from N] [-to N] <file.mp4>")
-		os.Exit(1)
-	}
-	f, err := os.Open(flag.Arg(0))
-	if err != nil {
-		panic(err)
-	}
-	defer f.Close()
-	parsed, err := mp4ff.DecodeFile(f)
-	if err != nil {
-		panic(err)
-	}
-
-	// Movie-level info
-	if parsed.Init != nil && parsed.Init.Moov != nil {
-		moov := parsed.Init.Moov
-		fmt.Printf("ftyp/moov present. timescale(mvhd)=%d duration(mvhd)=%d\n",
-			moov.Mvhd.Timescale, moov.Mvhd.Duration)
-		for _, trak := range moov.Traks {
-			ts := trak.Mdia.Mdhd.Timescale
-			fmt.Printf("  trak id=%d handler=%s mdhd.timescale=%d mdhd.duration=%d\n",
-				trak.Tkhd.TrackID, trak.Mdia.Hdlr.HandlerType, ts, trak.Mdia.Mdhd.Duration)
-		}
-	} else {
-		fmt.Println("no Init/Moov (pure fragmented stream?)")
-	}
-
-	// sidx vs actual segment layout. MSE players use sidx to map presentation
-	// time -> byte ranges; if sidx references disagree with the real segment
-	// sizes/durations (e.g. after an early/short flush) the player fetches the
-	// wrong bytes and fails to decode — a failure that "heals" on seek.
-	fmt.Println("=== sidx references vs actual segments ===")
-	var sidxRefs []mp4ff.SidxRef
-	for _, c := range parsed.Children {
-		if s, ok := c.(*mp4ff.SidxBox); ok {
-			fmt.Printf("  sidx: timescale=%d earliestPresTime=%d firstOffset=%d refCount=%d anchor(after sidx)=%d\n",
-				s.Timescale, s.EarliestPresentationTime, s.FirstOffset, len(s.SidxRefs), s.AnchorPoint)
-			sidxRefs = s.SidxRefs
-		}
-	}
-	// Actual segment sizes (styp+moof+mdat) and fragment durations.
-	type segInfo struct {
-		size uint64
-		dur  uint64
-	}
-	var actual []segInfo
-	for _, seg := range parsed.Segments {
-		var sz uint64
-		if seg.Styp != nil {
-			sz += seg.Styp.Size()
-		}
-		if seg.Sidx != nil {
-			sz += seg.Sidx.Size()
-		}
-		var dur uint64
-		for _, fr := range seg.Fragments {
-			sz += fr.Moof.Size()
-			if fr.Mdat != nil {
-				sz += fr.Mdat.Size()
-			}
-			for _, traf := range fr.Moof.Trafs {
-				if traf.Tfhd.TrackID != 1 {
-					continue
-				}
-				for _, trun := range traf.Truns {
-					for _, s := range trun.Samples {
-						dur += uint64(s.Dur)
-					}
-				}
-			}
-		}
-		actual = append(actual, segInfo{size: sz, dur: dur})
-	}
-	for i := range actual {
-		refStr := "(no sidx ref)"
-		if i < len(sidxRefs) {
-			r := sidxRefs[i]
-			mark := ""
-			if uint64(r.ReferencedSize) != actual[i].size {
-				mark += fmt.Sprintf(" SIZE MISMATCH actual=%d", actual[i].size)
-			}
-			if uint64(r.SubSegmentDuration) != actual[i].dur {
-				mark += fmt.Sprintf(" DUR MISMATCH actual=%d", actual[i].dur)
-			}
-			refStr = fmt.Sprintf("sidx.size=%d sidx.dur=%d type=%d sap=%d/%d%s",
-				r.ReferencedSize, r.SubSegmentDuration, r.ReferenceType, r.StartsWithSAP, r.SAPType, mark)
-		}
-		fmt.Printf("  seg%02d actual.size=%d actual.dur=%d | %s\n", i, actual[i].size, actual[i].dur, refStr)
-	}
-
-	fmt.Println("=== fragments ===")
-	fragIdx := 0
-	var allKeyGlobal []uint64 // global keyframe decode times (track timescale units)
-	var prevTfdtEnd = map[uint32]uint64{}
-	for si, seg := range parsed.Segments {
-		for _, fr := range seg.Fragments {
-			for _, traf := range fr.Moof.Trafs {
-				tid := traf.Tfhd.TrackID
-				tfdt := traf.Tfdt.BaseMediaDecodeTime()
-				offset := uint64(0)
-				var keys []uint64 // keyframe offset-from-tfdt
-				var durs []uint64
-				zeroDur := 0
-				nSamples := 0
-				for _, trun := range traf.Truns {
-					for _, s := range trun.Samples {
-						nSamples++
-						if (s.Flags>>24)&0x03 == 0x02 { // sample_depends_on==2 => IDR/sync
-							keys = append(keys, offset)
-							if tid == 1 {
-								allKeyGlobal = append(allKeyGlobal, tfdt+offset)
-							}
-						}
-						if s.Dur == 0 {
-							zeroDur++
-						}
-						durs = append(durs, uint64(s.Dur))
-						offset += uint64(s.Dur)
-					}
-				}
-				cont := ""
-				if pe, ok := prevTfdtEnd[tid]; ok {
-					if tfdt != pe {
-						cont = fmt.Sprintf(" <-- tfdt GAP/JUMP prev_end=%d delta=%d", pe, int64(tfdt)-int64(pe))
-					}
-				}
-				prevTfdtEnd[tid] = tfdt + offset
-				if tid == 1 {
-					// in-fragment keyframe gaps
-					var gaps []int64
-					for i := 1; i < len(keys); i++ {
-						gaps = append(gaps, int64(keys[i])-int64(keys[i-1]))
-					}
-					fmt.Printf("seg%d frag%d trk%d tfdt=%d dur=%d nSamp=%d zeroDur=%d keys=%v inFragKeyGaps=%v%s\n",
-						si, fragIdx, tid, tfdt, offset, nSamples, zeroDur, keys, gaps, cont)
-				}
-			}
-			fragIdx++
-		}
-	}
-
-	fmt.Println("=== global video keyframe decode times & gaps ===")
-	for i, k := range allKeyGlobal {
-		gap := int64(0)
-		if i > 0 {
-			gap = int64(k) - int64(allKeyGlobal[i-1])
-		}
-		seam := ""
-		if i > 1 {
-			prevGap := int64(allKeyGlobal[i-1]) - int64(allKeyGlobal[i-2])
-			if gap > 0 && prevGap > 0 && gap*2 < prevGap {
-				seam = fmt.Sprintf("  <== SEAM? gap=%d < prevGap/2=%d", gap, prevGap/2)
-			}
-		}
-		fmt.Printf("  kf#%02d dt=%d gap=%d%s\n", i, k, gap, seam)
-	}
-
-	// Choose the detailed-inspection window. By default centre it on the largest
-	// keyframe gap (the most likely artifact location); -from/-to override.
-	winLo, winHi := inspectWindow(allKeyGlobal, *fromFlag, *toFlag)
-	fmt.Printf("=== detailed inspection window: dts %d..%d ===\n", winLo, winHi)
-
-	// Full sample timeline: DTS, CTS (=DTS+cto), composition offset, NAL types,
-	// to detect PTS non-monotonicity / gaps / param-set changes at the seam.
-	fmt.Println("=== per-sample timeline (full) — checking PTS monotonicity & nal types ===")
-	var trex *mp4ff.TrexBox
-	if parsed.Init != nil && parsed.Init.Moov != nil && parsed.Init.Moov.Mvex != nil {
-		for _, t := range parsed.Init.Moov.Mvex.Trexs {
-			if t.TrackID == 1 {
-				trex = t
-			}
-		}
-	}
-	var lastCTS int64 = -1
-	var lastDTS int64 = -1
-	sampIdx := 0
-	fragIdx = 0
-	for _, seg := range parsed.Segments {
-		for _, fr := range seg.Fragments {
-			fs, err := fr.GetFullSamples(trex)
-			if err != nil {
-				fmt.Printf("  frag%d GetFullSamples err: %v\n", fragIdx, err)
-				fragIdx++
-				continue
-			}
-			for _, s := range fs {
-				dts := int64(s.DecodeTime)
-				cts := dts + int64(s.CompositionTimeOffset)
-				nals := nalTypes(s.Data)
-				anomaly := ""
-				if lastCTS >= 0 && cts < lastCTS {
-					anomaly += fmt.Sprintf(" <== CTS BACKWARDS (prev=%d)", lastCTS)
-				}
-				if lastDTS >= 0 && dts < lastDTS {
-					anomaly += fmt.Sprintf(" <== DTS BACKWARDS (prev=%d)", lastDTS)
-				}
-				// sample_is_non_sync_sample is bit 16 (0x00010000); a sync sample
-				// has it clear and sample_depends_on==2 (i.e. an I-frame).
-				isSync := s.Flags&0x00010000 == 0 && (s.Flags>>24)&0x03 == 0x02
-				// Only print inside the inspection window and any anomalies, to keep output small.
-				near := dts >= winLo && dts <= winHi
-				if near || anomaly != "" {
-					fmt.Printf("  s%04d frag%d dts=%d cts=%d cto=%d dur=%d size=%d sync=%v nal=%v%s\n",
-						sampIdx, fragIdx, dts, cts, s.CompositionTimeOffset, s.Dur, len(s.Data), isSync, nals, anomaly)
-				}
-				lastCTS = cts
-				lastDTS = dts
-				sampIdx++
-			}
-			fragIdx++
-		}
-	}
-
-	// Compare parameter sets: avcC (in moov) vs inline SPS/PPS at every IDR.
-	// A looping source that restarts may re-emit SPS/PPS that differ from the
-	// ones the player configured its decoder with from avcC — a classic cause
-	// of a freeze that "heals" when you seek past the seam.
-	fmt.Println("=== parameter set comparison (avcC vs inline IDR) ===")
-	var avccSPS, avccPPS [][]byte
-	if parsed.Init != nil && parsed.Init.Moov != nil {
-		for _, trak := range parsed.Init.Moov.Traks {
-			if trak.Mdia == nil || trak.Mdia.Minf == nil || trak.Mdia.Minf.Stbl == nil {
-				continue
-			}
-			stsd := trak.Mdia.Minf.Stbl.Stsd
-			if stsd == nil || stsd.AvcX == nil || stsd.AvcX.AvcC == nil {
-				continue
-			}
-			avccSPS = stsd.AvcX.AvcC.SPSnalus
-			avccPPS = stsd.AvcX.AvcC.PPSnalus
-		}
-	}
-	for i, s := range avccSPS {
-		fmt.Printf("  avcC SPS[%d] = %x\n", i, s)
-	}
-	for i, p := range avccPPS {
-		fmt.Printf("  avcC PPS[%d] = %x\n", i, p)
-	}
-	fragIdx = 0
-	sampIdx = 0
-	var baseSPS, basePPS []byte
-	if len(avccSPS) > 0 {
-		baseSPS = avccSPS[0]
-	}
-	if len(avccPPS) > 0 {
-		basePPS = avccPPS[0]
-	}
-	for _, seg := range parsed.Segments {
-		for _, fr := range seg.Fragments {
-			fs, err := fr.GetFullSamples(trex)
-			if err != nil {
-				fragIdx++
-				continue
-			}
-			for _, s := range fs {
-				spsList := nalsByType(s.Data, 7)
-				ppsList := nalsByType(s.Data, 8)
-				if len(spsList) > 0 || len(ppsList) > 0 {
-					dts := int64(s.DecodeTime)
-					note := ""
-					if len(spsList) > 0 {
-						if baseSPS == nil {
-							baseSPS = spsList[0]
-						} else if !bytesEqual(baseSPS, spsList[0]) {
-							note += " <== SPS CHANGED vs base/avcC"
-						}
-					}
-					if len(ppsList) > 0 {
-						if basePPS == nil {
-							basePPS = ppsList[0]
-						} else if !bytesEqual(basePPS, ppsList[0]) {
-							note += " <== PPS CHANGED vs base/avcC"
-						}
-					}
-					var spsHex, ppsHex string
-					if len(spsList) > 0 {
-						spsHex = fmt.Sprintf("%x", spsList[0])
-					}
-					if len(ppsList) > 0 {
-						ppsHex = fmt.Sprintf("%x", ppsList[0])
-					}
-					fmt.Printf("  IDR s%04d frag%d dts=%d SPS=%s PPS=%s%s\n",
-						sampIdx, fragIdx, dts, spsHex, ppsHex, note)
-				}
-				sampIdx++
-			}
-			fragIdx++
-		}
-	}
-
-	sliceHeaders(parsed, trex, winLo, winHi)
-
-	summary(parsed, trex)
-}
-
-func sliceHeaders(parsed *mp4ff.File, trex *mp4ff.TrexBox, winLo, winHi int64) {
-	// Build SPS/PPS maps from avcC.
-	spsMap := map[uint32]*avc.SPS{}
-	ppsMap := map[uint32]*avc.PPS{}
-	if parsed.Init != nil && parsed.Init.Moov != nil {
-		for _, trak := range parsed.Init.Moov.Traks {
-			if trak.Mdia == nil || trak.Mdia.Minf == nil || trak.Mdia.Minf.Stbl == nil {
-				continue
-			}
-			stsd := trak.Mdia.Minf.Stbl.Stsd
-			if stsd == nil || stsd.AvcX == nil || stsd.AvcX.AvcC == nil {
-				continue
-			}
-			for _, s := range stsd.AvcX.AvcC.SPSnalus {
-				if sps, err := avc.ParseSPSNALUnit(s, true); err == nil {
-					spsMap[uint32(sps.ParameterID)] = sps
-				}
-			}
-			for _, p := range stsd.AvcX.AvcC.PPSnalus {
-				if pps, err := avc.ParsePPSNALUnit(p, spsMap); err == nil {
-					ppsMap[pps.PicParameterSetID] = pps
-				}
-			}
-		}
-	}
-
-	fmt.Println("=== slice headers in inspection window (frame_num / poc / idr_pic_id) ===")
-	fragIdx := 0
-	sampIdx := 0
-	for _, seg := range parsed.Segments {
-		for _, fr := range seg.Fragments {
-			fs, err := fr.GetFullSamples(trex)
-			if err != nil {
-				fragIdx++
-				continue
-			}
-			for _, s := range fs {
-				dts := int64(s.DecodeTime)
-				if dts < winLo || dts > winHi {
-					sampIdx++
-					continue
-				}
-				for _, nal := range splitAVCC(s.Data) {
-					t := nal[0] & 0x1f
-					if t == 1 || t == 5 { // non-IDR or IDR slice
-						sh, err := avc.ParseSliceHeader(nal, spsMap, ppsMap)
-						if err != nil {
-							fmt.Printf("  s%04d frag%d dts=%d nalType=%d sliceHeader ERR: %v\n", sampIdx, fragIdx, dts, t, err)
-							break
-						}
-						fmt.Printf("  s%04d frag%d dts=%d nalType=%d sliceType=%v frameNum=%d idrPicId=%d pocLsb=%d\n",
-							sampIdx, fragIdx, dts, t, sh.SliceType, sh.FrameNum, sh.IDRPicID, sh.PicOrderCntLsb)
-						break
-					}
-				}
-				sampIdx++
-			}
-			fragIdx++
-		}
-	}
-}
-
-// splitAVCC splits a length-prefixed (4-byte) AVCC buffer into NAL units.
-func splitAVCC(b []byte) [][]byte {
-	var out [][]byte
-	i := 0
-	for i+4 <= len(b) {
-		n := int(uint32(b[i])<<24 | uint32(b[i+1])<<16 | uint32(b[i+2])<<8 | uint32(b[i+3]))
-		i += 4
-		if n <= 0 || i+n > len(b) {
-			break
-		}
-		out = append(out, b[i:i+n])
-		i += n
-	}
-	return out
-}
-
-func bytesEqual(a, b []byte) bool {
-	if len(a) != len(b) {
-		return false
-	}
-	for i := range a {
-		if a[i] != b[i] {
-			return false
-		}
-	}
-	return true
-}
-
-// nalTypes returns the list of H.264 NAL unit types present in an AVCC
-// (length-prefixed) sample buffer.
-func nalTypes(b []byte) []int {
-	var out []int
-	i := 0
-	for i+4 <= len(b) {
-		n := int(uint32(b[i])<<24 | uint32(b[i+1])<<16 | uint32(b[i+2])<<8 | uint32(b[i+3]))
-		i += 4
-		if n <= 0 || i+n > len(b) {
-			break
-		}
-		out = append(out, int(b[i]&0x1f))
-		i += n
-	}
-	return out
-}
-
-// nalsByType returns the raw NAL payloads (without length prefix) of the given
-// type from an AVCC (length-prefixed) sample buffer.
-func nalsByType(b []byte, want int) [][]byte {
-	var out [][]byte
-	i := 0
-	for i+4 <= len(b) {
-		n := int(uint32(b[i])<<24 | uint32(b[i+1])<<16 | uint32(b[i+2])<<8 | uint32(b[i+3]))
-		i += 4
-		if n <= 0 || i+n > len(b) {
-			break
-		}
-		if int(b[i]&0x1f) == want {
-			nal := make([]byte, n)
-			copy(nal, b[i:i+n])
-			out = append(out, nal)
-		}
-		i += n
-	}
-	return out
-}
-
-// inspectWindow returns the [lo,hi] decode-time range (track timescale units)
-// for which sample-level detail is printed. Explicit -from/-to win; otherwise
-// the window auto-centres on the largest gap between consecutive video
-// keyframes — the most likely location of a visible artifact — with a margin on
-// each side so the frames leading into and out of the gap are shown too.
-func inspectWindow(keyDecodeTimes []uint64, from, to int64) (int64, int64) {
-	if from >= 0 || to >= 0 {
-		if from < 0 {
-			from = 0
-		}
-		if to < 0 {
-			to = from + 2000
-		}
-		return from, to
-	}
-	if len(keyDecodeTimes) < 2 {
-		return 0, 1 << 62
-	}
-	worstIdx, worstGap := 1, uint64(0)
-	for i := 1; i < len(keyDecodeTimes); i++ {
-		if g := keyDecodeTimes[i] - keyDecodeTimes[i-1]; g > worstGap {
-			worstGap = g
-			worstIdx = i
-		}
-	}
-	const margin = 500
-	lo := int64(keyDecodeTimes[worstIdx-1]) - margin
-	if lo < 0 {
-		lo = 0
-	}
-	return lo, int64(keyDecodeTimes[worstIdx]) + margin
-}
-
-// summary prints a compact, generic health report so a recording can be
-// validated at a glance without reading the full per-sample dump above.
-func summary(parsed *mp4ff.File, trex *mp4ff.TrexBox) {
-	fmt.Println("=== SUMMARY (health checks) ===")
-
-	videoTracks, audioTracks := 0, 0
-	var videoTimescale uint64 = 1
-	if parsed.Init != nil && parsed.Init.Moov != nil {
-		for _, trak := range parsed.Init.Moov.Traks {
-			switch trak.Mdia.Hdlr.HandlerType {
-			case "vide":
-				videoTracks++
-				if trak.Mdia.Mdhd.Timescale != 0 {
-					videoTimescale = uint64(trak.Mdia.Mdhd.Timescale)
-				}
-			case "soun":
-				audioTracks++
-			}
-		}
-	}
-	fmt.Printf("  tracks: %d video, %d audio\n", videoTracks, audioTracks)
-	if audioTracks == 0 {
-		fmt.Println("    note: no audio track is embedded in this file")
-	}
-
-	type fragStat struct {
-		idx     int
-		tfdt    uint64
-		dur     uint64
-		nSamp   int
-		nKeys   int
-		zeroDur int
-		fps     float64
-	}
-	var stats []fragStat
-	var keyTimes []uint64
-	var fpsArr []float64
-	tfdtGaps := 0
-	var prevEnd uint64
-	havePrev := false
-	fi := 0
-	for _, seg := range parsed.Segments {
-		for _, fr := range seg.Fragments {
-			for _, traf := range fr.Moof.Trafs {
-				if traf.Tfhd.TrackID != 1 {
-					continue
-				}
-				st := fragStat{idx: fi, tfdt: traf.Tfdt.BaseMediaDecodeTime()}
-				off := uint64(0)
-				for _, trun := range traf.Truns {
-					for _, s := range trun.Samples {
-						st.nSamp++
-						if (s.Flags>>24)&0x03 == 0x02 {
-							st.nKeys++
-							keyTimes = append(keyTimes, st.tfdt+off)
-						}
-						if s.Dur == 0 {
-							st.zeroDur++
-						}
-						off += uint64(s.Dur)
-					}
-				}
-				st.dur = off
-				d := st.dur
-				if d == 0 {
-					d = 1
-				}
-				st.fps = float64(st.nSamp) * float64(videoTimescale) / float64(d)
-				fpsArr = append(fpsArr, st.fps)
-				if havePrev && st.tfdt != prevEnd {
-					tfdtGaps++
-				}
-				prevEnd = st.tfdt + st.dur
-				havePrev = true
-				stats = append(stats, st)
-			}
-			fi++
-		}
-	}
-
-	medFps := medianFloat(fpsArr)
-	fmt.Printf("  fragments: %d (video timescale=%d, median %.1f fps)\n", len(stats), videoTimescale, medFps)
-	lowFps := 0
-	totalZero := 0
-	for _, st := range stats {
-		totalZero += st.zeroDur
-		flagStr := ""
-		if medFps > 0 && st.fps < medFps*0.9 {
-			lowFps++
-			flagStr = "  <== LOW FRAME RATE — likely dropped frames"
-		}
-		fmt.Printf("    frag%02d tfdt=%-6d dur=%-5d samples=%-3d keyframes=%d zeroDur=%d fps=%.1f%s\n",
-			st.idx, st.tfdt, st.dur, st.nSamp, st.nKeys, st.zeroDur, st.fps, flagStr)
-	}
-
-	var gaps []uint64
-	for i := 1; i < len(keyTimes); i++ {
-		gaps = append(gaps, keyTimes[i]-keyTimes[i-1])
-	}
-	irregular := 0
-	if len(gaps) > 0 {
-		med := medianUint(gaps)
-		mn, mx := gaps[0], gaps[0]
-		for _, g := range gaps {
-			if g < mn {
-				mn = g
-			}
-			if g > mx {
-				mx = g
-			}
-			// Flag intervals that deviate by more than ~50% from the median GOP.
-			if med > 0 && (g*2 > med*3 || g*2 < med) {
-				irregular++
-			}
-		}
-		fmt.Printf("  keyframe gaps: min=%d median=%d max=%d  irregular=%d/%d\n", mn, med, mx, irregular, len(gaps))
-	}
-	fmt.Printf("  tfdt discontinuities: %d\n", tfdtGaps)
-	fmt.Printf("  zero-duration samples: %d\n", totalZero)
-
-	fmt.Println("  verdict:")
-	clean := true
-	if audioTracks == 0 {
-		fmt.Println("    - no audio track (expected if this recording is video-only)")
-	}
-	if lowFps > 0 {
-		clean = false
-		fmt.Printf("    - %d fragment(s) have a reduced frame rate (dropped frames) — likely source of the artifacts\n", lowFps)
-	}
-	if irregular > 0 {
-		clean = false
-		fmt.Printf("    - %d irregular keyframe interval(s)\n", irregular)
-	}
-	if tfdtGaps > 0 {
-		clean = false
-		fmt.Printf("    - %d timeline (tfdt) discontinuity(ies)\n", tfdtGaps)
-	}
-	if totalZero > 0 {
-		clean = false
-		fmt.Printf("    - %d zero-duration sample(s)\n", totalZero)
-	}
-	if clean {
-		fmt.Println("    - container structure looks healthy")
-	}
-}
-
-func medianUint(v []uint64) uint64 {
-	if len(v) == 0 {
-		return 0
-	}
-	c := append([]uint64(nil), v...)
-	sort.Slice(c, func(i, j int) bool { return c[i] < c[j] })
-	return c[len(c)/2]
-}
-
-func medianFloat(v []float64) float64 {
-	if len(v) == 0 {
-		return 0
-	}
-	c := append([]float64(nil), v...)
-	sort.Float64s(c)
-	return c[len(c)/2]
-}

machinery/data/config/config.json

@@ -1,22 +1,25 @@
-
 {
 	"type": "",
-	"key": "",
-	"name": "agent",
+	"key": "okkey",
+	"name": "rtsp2",
 	"time": "false",
 	"offline": "false",
-	"auto_clean": "true",
+	"auto_clean": "100",
 	"remove_after_upload": "true",
-	"max_directory_size": 0,
-	"timezone": "Africa/Ceuta",
+	"max_directory_size": 20,
+	"timezone": "Europe/Brussels",
 	"capture": {
 		"name": "",
 		"ipcamera": {
-			"rtsp": "",
-			"sub_rtsp": "",
+			"width": 640,
+			"height": 480,
 			"fps": "",
-			"base_width": 640,
-			"base_height": 0
+			"rtsp": "rtsp://fake.kerberos.io/stream",
+			"sub_rtsp": "rtsp://kellyvd:cedricve123@192.168.1.68:554/Streaming/Channels/102?transportmode=multicast\u0026profile=Profile_1",
+			"onvif": "true",
+			"onvif_xaddr": "192.168.1.68",
+			"onvif_username": "kellyvd",
+			"onvif_password": "cedricve123"
 		},
 		"usbcamera": {
 			"device": ""
@@ -24,28 +27,27 @@
 		"raspicamera": {
 			"device": ""
 		},
-		"continuous": "false",
 		"recording": "true",
 		"snapshots": "true",
-		"liveview": "true",
-		"liveview_chunking": "false",
 		"motion": "true",
-		"postrecording": 20,
-		"prerecording": 10,
-		"maxlengthrecording": 30,
+		"liveview": "true",
+		"continuous": "false",
+		"postrecording": 5,
+		"prerecording": 5,
+		"maxlengthrecording": 10,
 		"transcodingwebrtc": "",
 		"transcodingresolution": 0,
 		"forwardwebrtc": "",
 		"fragmented": "false",
-		"fragmentedduration": 8,
+		"fragmentedduration": 10,
 		"pixelChangeThreshold": 150
 	},
 	"timetable": [
 		{
 			"start1": 0,
-			"end1": 43199,
-			"start2": 43200,
-			"end2": 86400
+			"end1": 0,
+			"start2": 0,
+			"end2": 0
 		},
 		{
 			"start1": 0,
@@ -92,34 +94,118 @@
 			"x2": 800,
 			"y2": 640
 		},
-		"polygon": []
+		"polygon": [
+			{
+				"id": "1694456798869",
+				"coordinates": [
+					{
+						"x": 458.8176559163439,
+						"y": 420.6597577161105
+					},
+					{
+						"x": 541.8959724597637,
+						"y": 422.62130444776193
+					},
+					{
+						"x": 540.2578560606811,
+						"y": 446.03551153214977
+					},
+					{
+						"x": 459.51092569845395,
+						"y": 445.07041692205803
+					}
+				]
+			},
+			{
+				"id": "1694455955284",
+				"coordinates": [
+					{
+						"x": 82.63849814838939,
+						"y": 122.83665165528404
+					},
+					{
+						"x": 259.18591194149286,
+						"y": 122.83665165528404
+					},
+					{
+						"x": 259.18591194149286,
+						"y": 232.42716889666335
+					},
+					{
+						"x": 82.63849814838939,
+						"y": 232.42716889666335
+					}
+				]
+			},
+			{
+				"id": "1694455953115",
+				"coordinates": [
+					{
+						"x": 200.7130606007035,
+						"y": 171.25495957161723
+					},
+					{
+						"x": 445.73676749725524,
+						"y": 171.25495957161723
+					},
+					{
+						"x": 445.73676749725524,
+						"y": 297.5911664681689
+					},
+					{
+						"x": 200.7130606007035,
+						"y": 297.5911664681689
+					}
+				]
+			},
+			{
+				"id": "0",
+				"coordinates": [
+					{
+						"x": 351.8431271737717,
+						"y": 65.62379883848743
+					},
+					{
+						"x": 609.6534108617149,
+						"y": 65.62379883848743
+					},
+					{
+						"x": 609.6534108617149,
+						"y": 246.50145841295546
+					},
+					{
+						"x": 351.8431271737717,
+						"y": 246.50145841295546
+					}
+				]
+			}
+		]
 	},
 	"cloud": "s3",
 	"s3": {
 		"proxyuri": "http://proxy.kerberos.io",
 		"bucket": "kerberosaccept",
-		"region": "eu-west-1"
+		"region": "eu-west1",
+		"username": "cedricve"
+	},
+	"kstorage": {
+		"uri": "https://api.vault.kerberos.io",
+		"access_key": "pDCQve0XL1DXwy2x",
+		"secret_access_key": "GTpus90EKrKYuplqL3g!2oiQ@s",
+		"directory": "cedricve"
 	},
-	"kstorage": {},
-	"kstorage_secondary": {},
 	"dropbox": {},
 	"mqtturi": "tcp://mqtt.kerberos.io:1883",
 	"mqtt_username": "",
 	"mqtt_password": "",
-	"turn_force": "false",
-	"stunuri": "stun:turn-fra1.kerberos.io:3478",
-	"turnuri": "turn:turn-fra1.kerberos.io:3478",
+	"stunuri": "stun:turn.kerberos.io:8443",
+	"turnuri": "turn:turn.kerberos.io:8443",
 	"turn_username": "username1",
 	"turn_password": "password1",
 	"heartbeaturi": "",
-	"hub_encryption": "true",
-	"hub_uri": "https://api.cloud.kerberos.io",
-	"hub_key": "",
-	"hub_private_key": "",
+	"hub_uri": "http://localhost:8081",
+	"hub_key": "AKIA5V6EGLUWXDU4JBEI",
+	"hub_private_key": "DIOXToTpAlYpa4atf7aWtxHd9xEw/Fk4XioL0tek",
 	"hub_site": "",
-	"condition_uri": "",
-	"encryption": {},
-	"signing": {},
-	"realtimeprocessing": "false",
-	"realtimeprocessing_topic": ""
+	"condition_uri": ""
 }

machinery/data/tus/1786715908_3-737_encrypted_0-0-0-0_-1_25498.mp4.primary.json

@@ -1 +0,0 @@
-{"upload_url":"https://vault.kerberos.io/api/storage/tus/19e42fbc666a38064904caf8c46d182a","vault_uri":"https://vault.kerberos.io/api/storage/tus/","size":1591581}

machinery/docs/docs.go

@@ -1,4 +1,5 @@
-// Package docs Code generated by swaggo/swag. DO NOT EDIT
+// Package docs GENERATED BY SWAG; DO NOT EDIT
+// This file was generated by swaggo/swag
 package docs
 
 import "github.com/swaggo/swag"
@@ -28,7 +29,7 @@ const docTemplate = `{
             "post": {
                 "description": "Will return the ONVIF capabilities for the specific camera.",
                 "tags": [
-                    "onvif"
+                    "camera"
                 ],
                 "summary": "Will return the ONVIF capabilities for the specific camera.",
                 "operationId": "camera-onvif-capabilities",
@@ -57,7 +58,7 @@ const docTemplate = `{
             "post": {
                 "description": "Will activate the desired ONVIF preset.",
                 "tags": [
-                    "onvif"
+                    "camera"
                 ],
                 "summary": "Will activate the desired ONVIF preset.",
                 "operationId": "camera-onvif-gotopreset",
@@ -82,45 +83,11 @@ const docTemplate = `{
                 }
             }
         },
-        "/api/camera/onvif/inputs": {
-            "post": {
-                "security": [
-                    {
-                        "Bearer": []
-                    }
-                ],
-                "description": "Will get the digital inputs from the ONVIF device.",
-                "tags": [
-                    "onvif"
-                ],
-                "summary": "Will get the digital inputs from the ONVIF device.",
-                "operationId": "get-digital-inputs",
-                "parameters": [
-                    {
-                        "description": "OnvifCredentials",
-                        "name": "config",
-                        "in": "body",
-                        "required": true,
-                        "schema": {
-                            "$ref": "#/definitions/models.OnvifCredentials"
-                        }
-                    }
-                ],
-                "responses": {
-                    "200": {
-                        "description": "OK",
-                        "schema": {
-                            "$ref": "#/definitions/models.APIResponse"
-                        }
-                    }
-                }
-            }
-        },
         "/api/camera/onvif/login": {
             "post": {
                 "description": "Try to login into ONVIF supported camera.",
                 "tags": [
-                    "onvif"
+                    "camera"
                 ],
                 "summary": "Try to login into ONVIF supported camera.",
                 "operationId": "camera-onvif-login",
@@ -145,86 +112,11 @@ const docTemplate = `{
                 }
             }
         },
-        "/api/camera/onvif/outputs": {
-            "post": {
-                "security": [
-                    {
-                        "Bearer": []
-                    }
-                ],
-                "description": "Will get the relay outputs from the ONVIF device.",
-                "tags": [
-                    "onvif"
-                ],
-                "summary": "Will get the relay outputs from the ONVIF device.",
-                "operationId": "get-relay-outputs",
-                "parameters": [
-                    {
-                        "description": "OnvifCredentials",
-                        "name": "config",
-                        "in": "body",
-                        "required": true,
-                        "schema": {
-                            "$ref": "#/definitions/models.OnvifCredentials"
-                        }
-                    }
-                ],
-                "responses": {
-                    "200": {
-                        "description": "OK",
-                        "schema": {
-                            "$ref": "#/definitions/models.APIResponse"
-                        }
-                    }
-                }
-            }
-        },
-        "/api/camera/onvif/outputs/{output}": {
-            "post": {
-                "security": [
-                    {
-                        "Bearer": []
-                    }
-                ],
-                "description": "Will trigger the relay output from the ONVIF device.",
-                "tags": [
-                    "onvif"
-                ],
-                "summary": "Will trigger the relay output from the ONVIF device.",
-                "operationId": "trigger-relay-output",
-                "parameters": [
-                    {
-                        "description": "OnvifCredentials",
-                        "name": "config",
-                        "in": "body",
-                        "required": true,
-                        "schema": {
-                            "$ref": "#/definitions/models.OnvifCredentials"
-                        }
-                    },
-                    {
-                        "type": "string",
-                        "description": "Output",
-                        "name": "output",
-                        "in": "path",
-                        "required": true
-                    }
-                ],
-                "responses": {
-                    "200": {
-                        "description": "OK",
-                        "schema": {
-                            "$ref": "#/definitions/models.APIResponse"
-                        }
-                    }
-                }
-            }
-        },
         "/api/camera/onvif/pantilt": {
             "post": {
                 "description": "Panning or/and tilting the camera using a direction (x,y).",
                 "tags": [
-                    "onvif"
+                    "camera"
                 ],
                 "summary": "Panning or/and tilting the camera.",
                 "operationId": "camera-onvif-pantilt",
@@ -253,7 +145,7 @@ const docTemplate = `{
             "post": {
                 "description": "Will return the ONVIF presets for the specific camera.",
                 "tags": [
-                    "onvif"
+                    "camera"
                 ],
                 "summary": "Will return the ONVIF presets for the specific camera.",
                 "operationId": "camera-onvif-presets",
@@ -278,45 +170,11 @@ const docTemplate = `{
                 }
             }
         },
-        "/api/camera/onvif/verify": {
-            "post": {
-                "security": [
-                    {
-                        "Bearer": []
-                    }
-                ],
-                "description": "Will verify the ONVIF connectivity.",
-                "tags": [
-                    "onvif"
-                ],
-                "summary": "Will verify the ONVIF connectivity.",
-                "operationId": "verify-onvif",
-                "parameters": [
-                    {
-                        "description": "OnvifCredentials",
-                        "name": "config",
-                        "in": "body",
-                        "required": true,
-                        "schema": {
-                            "$ref": "#/definitions/models.OnvifCredentials"
-                        }
-                    }
-                ],
-                "responses": {
-                    "200": {
-                        "description": "OK",
-                        "schema": {
-                            "$ref": "#/definitions/models.APIResponse"
-                        }
-                    }
-                }
-            }
-        },
         "/api/camera/onvif/zoom": {
             "post": {
                 "description": "Zooming in or out the camera.",
                 "tags": [
-                    "onvif"
+                    "camera"
                 ],
                 "summary": "Zooming in or out the camera.",
                 "operationId": "camera-onvif-zoom",
@@ -341,90 +199,6 @@ const docTemplate = `{
                 }
             }
         },
-        "/api/camera/record": {
-            "post": {
-                "description": "Make a recording.",
-                "tags": [
-                    "camera"
-                ],
-                "summary": "Make a recording.",
-                "operationId": "camera-record",
-                "responses": {
-                    "200": {
-                        "description": "OK",
-                        "schema": {
-                            "$ref": "#/definitions/models.APIResponse"
-                        }
-                    }
-                }
-            }
-        },
-        "/api/camera/restart": {
-            "post": {
-                "description": "Restart the agent.",
-                "tags": [
-                    "camera"
-                ],
-                "summary": "Restart the agent.",
-                "operationId": "camera-restart",
-                "responses": {
-                    "200": {
-                        "description": "OK",
-                        "schema": {
-                            "$ref": "#/definitions/models.APIResponse"
-                        }
-                    }
-                }
-            }
-        },
-        "/api/camera/snapshot/base64": {
-            "get": {
-                "description": "Get a snapshot from the camera in base64.",
-                "tags": [
-                    "camera"
-                ],
-                "summary": "Get a snapshot from the camera in base64.",
-                "operationId": "snapshot-base64",
-                "responses": {
-                    "200": {
-                        "description": "OK"
-                    }
-                }
-            }
-        },
-        "/api/camera/snapshot/jpeg": {
-            "get": {
-                "description": "Get a snapshot from the camera in jpeg format.",
-                "tags": [
-                    "camera"
-                ],
-                "summary": "Get a snapshot from the camera in jpeg format.",
-                "operationId": "snapshot-jpeg",
-                "responses": {
-                    "200": {
-                        "description": "OK"
-                    }
-                }
-            }
-        },
-        "/api/camera/stop": {
-            "post": {
-                "description": "Stop the agent.",
-                "tags": [
-                    "camera"
-                ],
-                "summary": "Stop the agent.",
-                "operationId": "camera-stop",
-                "responses": {
-                    "200": {
-                        "description": "OK",
-                        "schema": {
-                            "$ref": "#/definitions/models.APIResponse"
-                        }
-                    }
-                }
-            }
-        },
         "/api/camera/verify/{streamType}": {
             "post": {
                 "description": "This method will validate a specific profile connection from an RTSP camera, and try to get the codec.",
@@ -465,75 +239,6 @@ const docTemplate = `{
                 }
             }
         },
-        "/api/config": {
-            "get": {
-                "description": "Get the current configuration.",
-                "tags": [
-                    "config"
-                ],
-                "summary": "Get the current configuration.",
-                "operationId": "config",
-                "responses": {
-                    "200": {
-                        "description": "OK"
-                    }
-                }
-            },
-            "post": {
-                "description": "Update the current configuration.",
-                "tags": [
-                    "config"
-                ],
-                "summary": "Update the current configuration.",
-                "operationId": "config",
-                "parameters": [
-                    {
-                        "description": "Configuration",
-                        "name": "config",
-                        "in": "body",
-                        "required": true,
-                        "schema": {
-                            "$ref": "#/definitions/models.Config"
-                        }
-                    }
-                ],
-                "responses": {
-                    "200": {
-                        "description": "OK"
-                    }
-                }
-            }
-        },
-        "/api/dashboard": {
-            "get": {
-                "description": "Get all information showed on the dashboard.",
-                "tags": [
-                    "general"
-                ],
-                "summary": "Get all information showed on the dashboard.",
-                "operationId": "dashboard",
-                "responses": {
-                    "200": {
-                        "description": "OK"
-                    }
-                }
-            }
-        },
-        "/api/days": {
-            "get": {
-                "description": "Get all days stored in the recordings directory.",
-                "tags": [
-                    "general"
-                ],
-                "summary": "Get all days stored in the recordings directory.",
-                "operationId": "days",
-                "responses": {
-                    "200": {
-                        "description": "OK"
-                    }
-                }
-            }
-        },
         "/api/hub/verify": {
             "post": {
                 "security": [
@@ -543,7 +248,7 @@ const docTemplate = `{
                 ],
                 "description": "Will verify the hub connectivity.",
                 "tags": [
-                    "persistence"
+                    "config"
                 ],
                 "summary": "Will verify the hub connectivity.",
                 "operationId": "verify-hub",
@@ -568,32 +273,6 @@ const docTemplate = `{
                 }
             }
         },
-        "/api/latest-events": {
-            "post": {
-                "description": "Get the latest recordings (events) from the recordings directory.",
-                "tags": [
-                    "general"
-                ],
-                "summary": "Get the latest recordings (events) from the recordings directory.",
-                "operationId": "latest-events",
-                "parameters": [
-                    {
-                        "description": "Event filter",
-                        "name": "eventFilter",
-                        "in": "body",
-                        "required": true,
-                        "schema": {
-                            "$ref": "#/definitions/models.EventFilter"
-                        }
-                    }
-                ],
-                "responses": {
-                    "200": {
-                        "description": "OK"
-                    }
-                }
-            }
-        },
         "/api/login": {
             "post": {
                 "description": "Get Authorization token.",
@@ -623,6 +302,40 @@ const docTemplate = `{
                 }
             }
         },
+        "/api/onvif/verify": {
+            "post": {
+                "security": [
+                    {
+                        "Bearer": []
+                    }
+                ],
+                "description": "Will verify the ONVIF connectivity.",
+                "tags": [
+                    "config"
+                ],
+                "summary": "Will verify the ONVIF connectivity.",
+                "operationId": "verify-onvif",
+                "parameters": [
+                    {
+                        "description": "Camera Config",
+                        "name": "cameraConfig",
+                        "in": "body",
+                        "required": true,
+                        "schema": {
+                            "$ref": "#/definitions/models.IPCamera"
+                        }
+                    }
+                ],
+                "responses": {
+                    "200": {
+                        "description": "OK",
+                        "schema": {
+                            "$ref": "#/definitions/models.APIResponse"
+                        }
+                    }
+                }
+            }
+        },
         "/api/persistence/verify": {
             "post": {
                 "security": [
@@ -632,7 +345,7 @@ const docTemplate = `{
                 ],
                 "description": "Will verify the persistence.",
                 "tags": [
-                    "persistence"
+                    "config"
                 ],
                 "summary": "Will verify the persistence.",
                 "operationId": "verify-persistence",
@@ -792,9 +505,6 @@ const docTemplate = `{
                 "dropbox": {
                     "$ref": "#/definitions/models.Dropbox"
                 },
-                "encryption": {
-                    "$ref": "#/definitions/models.Encryption"
-                },
                 "friendly_name": {
                     "type": "string"
                 },
@@ -802,9 +512,6 @@ const docTemplate = `{
                     "description": "obsolete",
                     "type": "string"
                 },
-                "hub_encryption": {
-                    "type": "string"
-                },
                 "hub_key": {
                     "type": "string"
                 },
@@ -841,12 +548,6 @@ const docTemplate = `{
                 "offline": {
                     "type": "string"
                 },
-                "realtimeprocessing": {
-                    "type": "string"
-                },
-                "realtimeprocessing_topic": {
-                    "type": "string"
-                },
                 "region": {
                     "$ref": "#/definitions/models.Region"
                 },
@@ -871,9 +572,6 @@ const docTemplate = `{
                 "timezone": {
                     "type": "string"
                 },
-                "turn_force": {
-                    "type": "string"
-                },
                 "turn_password": {
                     "type": "string"
                 },
@@ -910,49 +608,12 @@ const docTemplate = `{
                 }
             }
         },
-        "models.Encryption": {
-            "type": "object",
-            "properties": {
-                "enabled": {
-                    "type": "string"
-                },
-                "fingerprint": {
-                    "type": "string"
-                },
-                "private_key": {
-                    "type": "string"
-                },
-                "recordings": {
-                    "type": "string"
-                },
-                "symmetric_key": {
-                    "type": "string"
-                }
-            }
-        },
-        "models.EventFilter": {
-            "type": "object",
-            "properties": {
-                "number_of_elements": {
-                    "type": "integer"
-                },
-                "timestamp_offset_end": {
-                    "type": "integer"
-                },
-                "timestamp_offset_start": {
-                    "type": "integer"
-                }
-            }
-        },
         "models.IPCamera": {
             "type": "object",
             "properties": {
                 "fps": {
                     "type": "string"
                 },
-                "height": {
-                    "type": "integer"
-                },
                 "onvif": {
                     "type": "string"
                 },
@@ -968,20 +629,8 @@ const docTemplate = `{
                 "rtsp": {
                     "type": "string"
                 },
-                "sub_fps": {
-                    "type": "string"
-                },
-                "sub_height": {
-                    "type": "integer"
-                },
                 "sub_rtsp": {
                     "type": "string"
-                },
-                "sub_width": {
-                    "type": "integer"
-                },
-                "width": {
-                    "type": "integer"
                 }
             }
         },
@@ -1186,8 +835,6 @@ var SwaggerInfo = &swag.Spec{
 	Description:      "This is the API for using and configure Kerberos Agent.",
 	InfoInstanceName: "swagger",
 	SwaggerTemplate:  docTemplate,
-	LeftDelim:        "{{",
-	RightDelim:       "}}",
 }
 
 func init() {

machinery/docs/swagger.json

@@ -21,7 +21,7 @@
             "post": {
                 "description": "Will return the ONVIF capabilities for the specific camera.",
                 "tags": [
-                    "onvif"
+                    "camera"
                 ],
                 "summary": "Will return the ONVIF capabilities for the specific camera.",
                 "operationId": "camera-onvif-capabilities",
@@ -50,7 +50,7 @@
             "post": {
                 "description": "Will activate the desired ONVIF preset.",
                 "tags": [
-                    "onvif"
+                    "camera"
                 ],
                 "summary": "Will activate the desired ONVIF preset.",
                 "operationId": "camera-onvif-gotopreset",
@@ -75,45 +75,11 @@
                 }
             }
         },
-        "/api/camera/onvif/inputs": {
-            "post": {
-                "security": [
-                    {
-                        "Bearer": []
-                    }
-                ],
-                "description": "Will get the digital inputs from the ONVIF device.",
-                "tags": [
-                    "onvif"
-                ],
-                "summary": "Will get the digital inputs from the ONVIF device.",
-                "operationId": "get-digital-inputs",
-                "parameters": [
-                    {
-                        "description": "OnvifCredentials",
-                        "name": "config",
-                        "in": "body",
-                        "required": true,
-                        "schema": {
-                            "$ref": "#/definitions/models.OnvifCredentials"
-                        }
-                    }
-                ],
-                "responses": {
-                    "200": {
-                        "description": "OK",
-                        "schema": {
-                            "$ref": "#/definitions/models.APIResponse"
-                        }
-                    }
-                }
-            }
-        },
         "/api/camera/onvif/login": {
             "post": {
                 "description": "Try to login into ONVIF supported camera.",
                 "tags": [
-                    "onvif"
+                    "camera"
                 ],
                 "summary": "Try to login into ONVIF supported camera.",
                 "operationId": "camera-onvif-login",
@@ -138,86 +104,11 @@
                 }
             }
         },
-        "/api/camera/onvif/outputs": {
-            "post": {
-                "security": [
-                    {
-                        "Bearer": []
-                    }
-                ],
-                "description": "Will get the relay outputs from the ONVIF device.",
-                "tags": [
-                    "onvif"
-                ],
-                "summary": "Will get the relay outputs from the ONVIF device.",
-                "operationId": "get-relay-outputs",
-                "parameters": [
-                    {
-                        "description": "OnvifCredentials",
-                        "name": "config",
-                        "in": "body",
-                        "required": true,
-                        "schema": {
-                            "$ref": "#/definitions/models.OnvifCredentials"
-                        }
-                    }
-                ],
-                "responses": {
-                    "200": {
-                        "description": "OK",
-                        "schema": {
-                            "$ref": "#/definitions/models.APIResponse"
-                        }
-                    }
-                }
-            }
-        },
-        "/api/camera/onvif/outputs/{output}": {
-            "post": {
-                "security": [
-                    {
-                        "Bearer": []
-                    }
-                ],
-                "description": "Will trigger the relay output from the ONVIF device.",
-                "tags": [
-                    "onvif"
-                ],
-                "summary": "Will trigger the relay output from the ONVIF device.",
-                "operationId": "trigger-relay-output",
-                "parameters": [
-                    {
-                        "description": "OnvifCredentials",
-                        "name": "config",
-                        "in": "body",
-                        "required": true,
-                        "schema": {
-                            "$ref": "#/definitions/models.OnvifCredentials"
-                        }
-                    },
-                    {
-                        "type": "string",
-                        "description": "Output",
-                        "name": "output",
-                        "in": "path",
-                        "required": true
-                    }
-                ],
-                "responses": {
-                    "200": {
-                        "description": "OK",
-                        "schema": {
-                            "$ref": "#/definitions/models.APIResponse"
-                        }
-                    }
-                }
-            }
-        },
         "/api/camera/onvif/pantilt": {
             "post": {
                 "description": "Panning or/and tilting the camera using a direction (x,y).",
                 "tags": [
-                    "onvif"
+                    "camera"
                 ],
                 "summary": "Panning or/and tilting the camera.",
                 "operationId": "camera-onvif-pantilt",
@@ -246,7 +137,7 @@
             "post": {
                 "description": "Will return the ONVIF presets for the specific camera.",
                 "tags": [
-                    "onvif"
+                    "camera"
                 ],
                 "summary": "Will return the ONVIF presets for the specific camera.",
                 "operationId": "camera-onvif-presets",
@@ -271,45 +162,11 @@
                 }
             }
         },
-        "/api/camera/onvif/verify": {
-            "post": {
-                "security": [
-                    {
-                        "Bearer": []
-                    }
-                ],
-                "description": "Will verify the ONVIF connectivity.",
-                "tags": [
-                    "onvif"
-                ],
-                "summary": "Will verify the ONVIF connectivity.",
-                "operationId": "verify-onvif",
-                "parameters": [
-                    {
-                        "description": "OnvifCredentials",
-                        "name": "config",
-                        "in": "body",
-                        "required": true,
-                        "schema": {
-                            "$ref": "#/definitions/models.OnvifCredentials"
-                        }
-                    }
-                ],
-                "responses": {
-                    "200": {
-                        "description": "OK",
-                        "schema": {
-                            "$ref": "#/definitions/models.APIResponse"
-                        }
-                    }
-                }
-            }
-        },
         "/api/camera/onvif/zoom": {
             "post": {
                 "description": "Zooming in or out the camera.",
                 "tags": [
-                    "onvif"
+                    "camera"
                 ],
                 "summary": "Zooming in or out the camera.",
                 "operationId": "camera-onvif-zoom",
@@ -334,90 +191,6 @@
                 }
             }
         },
-        "/api/camera/record": {
-            "post": {
-                "description": "Make a recording.",
-                "tags": [
-                    "camera"
-                ],
-                "summary": "Make a recording.",
-                "operationId": "camera-record",
-                "responses": {
-                    "200": {
-                        "description": "OK",
-                        "schema": {
-                            "$ref": "#/definitions/models.APIResponse"
-                        }
-                    }
-                }
-            }
-        },
-        "/api/camera/restart": {
-            "post": {
-                "description": "Restart the agent.",
-                "tags": [
-                    "camera"
-                ],
-                "summary": "Restart the agent.",
-                "operationId": "camera-restart",
-                "responses": {
-                    "200": {
-                        "description": "OK",
-                        "schema": {
-                            "$ref": "#/definitions/models.APIResponse"
-                        }
-                    }
-                }
-            }
-        },
-        "/api/camera/snapshot/base64": {
-            "get": {
-                "description": "Get a snapshot from the camera in base64.",
-                "tags": [
-                    "camera"
-                ],
-                "summary": "Get a snapshot from the camera in base64.",
-                "operationId": "snapshot-base64",
-                "responses": {
-                    "200": {
-                        "description": "OK"
-                    }
-                }
-            }
-        },
-        "/api/camera/snapshot/jpeg": {
-            "get": {
-                "description": "Get a snapshot from the camera in jpeg format.",
-                "tags": [
-                    "camera"
-                ],
-                "summary": "Get a snapshot from the camera in jpeg format.",
-                "operationId": "snapshot-jpeg",
-                "responses": {
-                    "200": {
-                        "description": "OK"
-                    }
-                }
-            }
-        },
-        "/api/camera/stop": {
-            "post": {
-                "description": "Stop the agent.",
-                "tags": [
-                    "camera"
-                ],
-                "summary": "Stop the agent.",
-                "operationId": "camera-stop",
-                "responses": {
-                    "200": {
-                        "description": "OK",
-                        "schema": {
-                            "$ref": "#/definitions/models.APIResponse"
-                        }
-                    }
-                }
-            }
-        },
         "/api/camera/verify/{streamType}": {
             "post": {
                 "description": "This method will validate a specific profile connection from an RTSP camera, and try to get the codec.",
@@ -458,75 +231,6 @@
                 }
             }
         },
-        "/api/config": {
-            "get": {
-                "description": "Get the current configuration.",
-                "tags": [
-                    "config"
-                ],
-                "summary": "Get the current configuration.",
-                "operationId": "config",
-                "responses": {
-                    "200": {
-                        "description": "OK"
-                    }
-                }
-            },
-            "post": {
-                "description": "Update the current configuration.",
-                "tags": [
-                    "config"
-                ],
-                "summary": "Update the current configuration.",
-                "operationId": "config",
-                "parameters": [
-                    {
-                        "description": "Configuration",
-                        "name": "config",
-                        "in": "body",
-                        "required": true,
-                        "schema": {
-                            "$ref": "#/definitions/models.Config"
-                        }
-                    }
-                ],
-                "responses": {
-                    "200": {
-                        "description": "OK"
-                    }
-                }
-            }
-        },
-        "/api/dashboard": {
-            "get": {
-                "description": "Get all information showed on the dashboard.",
-                "tags": [
-                    "general"
-                ],
-                "summary": "Get all information showed on the dashboard.",
-                "operationId": "dashboard",
-                "responses": {
-                    "200": {
-                        "description": "OK"
-                    }
-                }
-            }
-        },
-        "/api/days": {
-            "get": {
-                "description": "Get all days stored in the recordings directory.",
-                "tags": [
-                    "general"
-                ],
-                "summary": "Get all days stored in the recordings directory.",
-                "operationId": "days",
-                "responses": {
-                    "200": {
-                        "description": "OK"
-                    }
-                }
-            }
-        },
         "/api/hub/verify": {
             "post": {
                 "security": [
@@ -536,7 +240,7 @@
                 ],
                 "description": "Will verify the hub connectivity.",
                 "tags": [
-                    "persistence"
+                    "config"
                 ],
                 "summary": "Will verify the hub connectivity.",
                 "operationId": "verify-hub",
@@ -561,32 +265,6 @@
                 }
             }
         },
-        "/api/latest-events": {
-            "post": {
-                "description": "Get the latest recordings (events) from the recordings directory.",
-                "tags": [
-                    "general"
-                ],
-                "summary": "Get the latest recordings (events) from the recordings directory.",
-                "operationId": "latest-events",
-                "parameters": [
-                    {
-                        "description": "Event filter",
-                        "name": "eventFilter",
-                        "in": "body",
-                        "required": true,
-                        "schema": {
-                            "$ref": "#/definitions/models.EventFilter"
-                        }
-                    }
-                ],
-                "responses": {
-                    "200": {
-                        "description": "OK"
-                    }
-                }
-            }
-        },
         "/api/login": {
             "post": {
                 "description": "Get Authorization token.",
@@ -616,6 +294,40 @@
                 }
             }
         },
+        "/api/onvif/verify": {
+            "post": {
+                "security": [
+                    {
+                        "Bearer": []
+                    }
+                ],
+                "description": "Will verify the ONVIF connectivity.",
+                "tags": [
+                    "config"
+                ],
+                "summary": "Will verify the ONVIF connectivity.",
+                "operationId": "verify-onvif",
+                "parameters": [
+                    {
+                        "description": "Camera Config",
+                        "name": "cameraConfig",
+                        "in": "body",
+                        "required": true,
+                        "schema": {
+                            "$ref": "#/definitions/models.IPCamera"
+                        }
+                    }
+                ],
+                "responses": {
+                    "200": {
+                        "description": "OK",
+                        "schema": {
+                            "$ref": "#/definitions/models.APIResponse"
+                        }
+                    }
+                }
+            }
+        },
         "/api/persistence/verify": {
             "post": {
                 "security": [
@@ -625,7 +337,7 @@
                 ],
                 "description": "Will verify the persistence.",
                 "tags": [
-                    "persistence"
+                    "config"
                 ],
                 "summary": "Will verify the persistence.",
                 "operationId": "verify-persistence",
@@ -785,9 +497,6 @@
                 "dropbox": {
                     "$ref": "#/definitions/models.Dropbox"
                 },
-                "encryption": {
-                    "$ref": "#/definitions/models.Encryption"
-                },
                 "friendly_name": {
                     "type": "string"
                 },
@@ -795,9 +504,6 @@
                     "description": "obsolete",
                     "type": "string"
                 },
-                "hub_encryption": {
-                    "type": "string"
-                },
                 "hub_key": {
                     "type": "string"
                 },
@@ -834,12 +540,6 @@
                 "offline": {
                     "type": "string"
                 },
-                "realtimeprocessing": {
-                    "type": "string"
-                },
-                "realtimeprocessing_topic": {
-                    "type": "string"
-                },
                 "region": {
                     "$ref": "#/definitions/models.Region"
                 },
@@ -864,9 +564,6 @@
                 "timezone": {
                     "type": "string"
                 },
-                "turn_force": {
-                    "type": "string"
-                },
                 "turn_password": {
                     "type": "string"
                 },
@@ -903,49 +600,12 @@
                 }
             }
         },
-        "models.Encryption": {
-            "type": "object",
-            "properties": {
-                "enabled": {
-                    "type": "string"
-                },
-                "fingerprint": {
-                    "type": "string"
-                },
-                "private_key": {
-                    "type": "string"
-                },
-                "recordings": {
-                    "type": "string"
-                },
-                "symmetric_key": {
-                    "type": "string"
-                }
-            }
-        },
-        "models.EventFilter": {
-            "type": "object",
-            "properties": {
-                "number_of_elements": {
-                    "type": "integer"
-                },
-                "timestamp_offset_end": {
-                    "type": "integer"
-                },
-                "timestamp_offset_start": {
-                    "type": "integer"
-                }
-            }
-        },
         "models.IPCamera": {
             "type": "object",
             "properties": {
                 "fps": {
                     "type": "string"
                 },
-                "height": {
-                    "type": "integer"
-                },
                 "onvif": {
                     "type": "string"
                 },
@@ -961,20 +621,8 @@
                 "rtsp": {
                     "type": "string"
                 },
-                "sub_fps": {
-                    "type": "string"
-                },
-                "sub_height": {
-                    "type": "integer"
-                },
                 "sub_rtsp": {
                     "type": "string"
-                },
-                "sub_width": {
-                    "type": "integer"
-                },
-                "width": {
-                    "type": "integer"
                 }
             }
         },

machinery/docs/swagger.yaml

@@ -88,15 +88,11 @@ definitions:
         type: string
       dropbox:
         $ref: '#/definitions/models.Dropbox'
-      encryption:
-        $ref: '#/definitions/models.Encryption'
       friendly_name:
         type: string
       heartbeaturi:
         description: obsolete
         type: string
-      hub_encryption:
-        type: string
       hub_key:
         type: string
       hub_private_key:
@@ -121,10 +117,6 @@ definitions:
         type: string
       offline:
         type: string
-      realtimeprocessing:
-        type: string
-      realtimeprocessing_topic:
-        type: string
       region:
         $ref: '#/definitions/models.Region'
       remove_after_upload:
@@ -141,8 +133,6 @@ definitions:
         type: array
       timezone:
         type: string
-      turn_force:
-        type: string
       turn_password:
         type: string
       turn_username:
@@ -166,34 +156,10 @@ definitions:
       directory:
         type: string
     type: object
-  models.Encryption:
-    properties:
-      enabled:
-        type: string
-      fingerprint:
-        type: string
-      private_key:
-        type: string
-      recordings:
-        type: string
-      symmetric_key:
-        type: string
-    type: object
-  models.EventFilter:
-    properties:
-      number_of_elements:
-        type: integer
-      timestamp_offset_end:
-        type: integer
-      timestamp_offset_start:
-        type: integer
-    type: object
   models.IPCamera:
     properties:
       fps:
         type: string
-      height:
-        type: integer
       onvif:
         type: string
       onvif_password:
@@ -204,16 +170,8 @@ definitions:
         type: string
       rtsp:
         type: string
-      sub_fps:
-        type: string
-      sub_height:
-        type: integer
       sub_rtsp:
         type: string
-      sub_width:
-        type: integer
-      width:
-        type: integer
     type: object
   models.KStorage:
     properties:
@@ -363,7 +321,7 @@ paths:
             $ref: '#/definitions/models.APIResponse'
       summary: Will return the ONVIF capabilities for the specific camera.
       tags:
-      - onvif
+      - camera
   /api/camera/onvif/gotopreset:
     post:
       description: Will activate the desired ONVIF preset.
@@ -382,28 +340,7 @@ paths:
             $ref: '#/definitions/models.APIResponse'
       summary: Will activate the desired ONVIF preset.
       tags:
-      - onvif
-  /api/camera/onvif/inputs:
-    post:
-      description: Will get the digital inputs from the ONVIF device.
-      operationId: get-digital-inputs
-      parameters:
-      - description: OnvifCredentials
-        in: body
-        name: config
-        required: true
-        schema:
-          $ref: '#/definitions/models.OnvifCredentials'
-      responses:
-        "200":
-          description: OK
-          schema:
-            $ref: '#/definitions/models.APIResponse'
-      security:
-      - Bearer: []
-      summary: Will get the digital inputs from the ONVIF device.
-      tags:
-      - onvif
+      - camera
   /api/camera/onvif/login:
     post:
       description: Try to login into ONVIF supported camera.
@@ -422,54 +359,7 @@ paths:
             $ref: '#/definitions/models.APIResponse'
       summary: Try to login into ONVIF supported camera.
       tags:
-      - onvif
-  /api/camera/onvif/outputs:
-    post:
-      description: Will get the relay outputs from the ONVIF device.
-      operationId: get-relay-outputs
-      parameters:
-      - description: OnvifCredentials
-        in: body
-        name: config
-        required: true
-        schema:
-          $ref: '#/definitions/models.OnvifCredentials'
-      responses:
-        "200":
-          description: OK
-          schema:
-            $ref: '#/definitions/models.APIResponse'
-      security:
-      - Bearer: []
-      summary: Will get the relay outputs from the ONVIF device.
-      tags:
-      - onvif
-  /api/camera/onvif/outputs/{output}:
-    post:
-      description: Will trigger the relay output from the ONVIF device.
-      operationId: trigger-relay-output
-      parameters:
-      - description: OnvifCredentials
-        in: body
-        name: config
-        required: true
-        schema:
-          $ref: '#/definitions/models.OnvifCredentials'
-      - description: Output
-        in: path
-        name: output
-        required: true
-        type: string
-      responses:
-        "200":
-          description: OK
-          schema:
-            $ref: '#/definitions/models.APIResponse'
-      security:
-      - Bearer: []
-      summary: Will trigger the relay output from the ONVIF device.
-      tags:
-      - onvif
+      - camera
   /api/camera/onvif/pantilt:
     post:
       description: Panning or/and tilting the camera using a direction (x,y).
@@ -488,7 +378,7 @@ paths:
             $ref: '#/definitions/models.APIResponse'
       summary: Panning or/and tilting the camera.
       tags:
-      - onvif
+      - camera
   /api/camera/onvif/presets:
     post:
       description: Will return the ONVIF presets for the specific camera.
@@ -507,28 +397,7 @@ paths:
             $ref: '#/definitions/models.APIResponse'
       summary: Will return the ONVIF presets for the specific camera.
       tags:
-      - onvif
-  /api/camera/onvif/verify:
-    post:
-      description: Will verify the ONVIF connectivity.
-      operationId: verify-onvif
-      parameters:
-      - description: OnvifCredentials
-        in: body
-        name: config
-        required: true
-        schema:
-          $ref: '#/definitions/models.OnvifCredentials'
-      responses:
-        "200":
-          description: OK
-          schema:
-            $ref: '#/definitions/models.APIResponse'
-      security:
-      - Bearer: []
-      summary: Will verify the ONVIF connectivity.
-      tags:
-      - onvif
+      - camera
   /api/camera/onvif/zoom:
     post:
       description: Zooming in or out the camera.
@@ -547,62 +416,6 @@ paths:
             $ref: '#/definitions/models.APIResponse'
       summary: Zooming in or out the camera.
       tags:
-      - onvif
-  /api/camera/record:
-    post:
-      description: Make a recording.
-      operationId: camera-record
-      responses:
-        "200":
-          description: OK
-          schema:
-            $ref: '#/definitions/models.APIResponse'
-      summary: Make a recording.
-      tags:
-      - camera
-  /api/camera/restart:
-    post:
-      description: Restart the agent.
-      operationId: camera-restart
-      responses:
-        "200":
-          description: OK
-          schema:
-            $ref: '#/definitions/models.APIResponse'
-      summary: Restart the agent.
-      tags:
-      - camera
-  /api/camera/snapshot/base64:
-    get:
-      description: Get a snapshot from the camera in base64.
-      operationId: snapshot-base64
-      responses:
-        "200":
-          description: OK
-      summary: Get a snapshot from the camera in base64.
-      tags:
-      - camera
-  /api/camera/snapshot/jpeg:
-    get:
-      description: Get a snapshot from the camera in jpeg format.
-      operationId: snapshot-jpeg
-      responses:
-        "200":
-          description: OK
-      summary: Get a snapshot from the camera in jpeg format.
-      tags:
-      - camera
-  /api/camera/stop:
-    post:
-      description: Stop the agent.
-      operationId: camera-stop
-      responses:
-        "200":
-          description: OK
-          schema:
-            $ref: '#/definitions/models.APIResponse'
-      summary: Stop the agent.
-      tags:
       - camera
   /api/camera/verify/{streamType}:
     post:
@@ -632,52 +445,6 @@ paths:
       summary: Validate a specific RTSP profile camera connection.
       tags:
       - camera
-  /api/config:
-    get:
-      description: Get the current configuration.
-      operationId: config
-      responses:
-        "200":
-          description: OK
-      summary: Get the current configuration.
-      tags:
-      - config
-    post:
-      description: Update the current configuration.
-      operationId: config
-      parameters:
-      - description: Configuration
-        in: body
-        name: config
-        required: true
-        schema:
-          $ref: '#/definitions/models.Config'
-      responses:
-        "200":
-          description: OK
-      summary: Update the current configuration.
-      tags:
-      - config
-  /api/dashboard:
-    get:
-      description: Get all information showed on the dashboard.
-      operationId: dashboard
-      responses:
-        "200":
-          description: OK
-      summary: Get all information showed on the dashboard.
-      tags:
-      - general
-  /api/days:
-    get:
-      description: Get all days stored in the recordings directory.
-      operationId: days
-      responses:
-        "200":
-          description: OK
-      summary: Get all days stored in the recordings directory.
-      tags:
-      - general
   /api/hub/verify:
     post:
       description: Will verify the hub connectivity.
@@ -698,24 +465,7 @@ paths:
       - Bearer: []
       summary: Will verify the hub connectivity.
       tags:
-      - persistence
-  /api/latest-events:
-    post:
-      description: Get the latest recordings (events) from the recordings directory.
-      operationId: latest-events
-      parameters:
-      - description: Event filter
-        in: body
-        name: eventFilter
-        required: true
-        schema:
-          $ref: '#/definitions/models.EventFilter'
-      responses:
-        "200":
-          description: OK
-      summary: Get the latest recordings (events) from the recordings directory.
-      tags:
-      - general
+      - config
   /api/login:
     post:
       description: Get Authorization token.
@@ -735,6 +485,27 @@ paths:
       summary: Get Authorization token.
       tags:
       - authentication
+  /api/onvif/verify:
+    post:
+      description: Will verify the ONVIF connectivity.
+      operationId: verify-onvif
+      parameters:
+      - description: Camera Config
+        in: body
+        name: cameraConfig
+        required: true
+        schema:
+          $ref: '#/definitions/models.IPCamera'
+      responses:
+        "200":
+          description: OK
+          schema:
+            $ref: '#/definitions/models.APIResponse'
+      security:
+      - Bearer: []
+      summary: Will verify the ONVIF connectivity.
+      tags:
+      - config
   /api/persistence/verify:
     post:
       description: Will verify the persistence.
@@ -755,7 +526,7 @@ paths:
       - Bearer: []
       summary: Will verify the persistence.
       tags:
-      - persistence
+      - config
 securityDefinitions:
   Bearer:
     in: header

machinery/go.mod

@@ -1,143 +1,145 @@
 module github.com/kerberos-io/agent/machinery
 
-go 1.25.0
+go 1.19
 
-replace google.golang.org/genproto => google.golang.org/genproto v0.0.0-20250519155744-55703ea1f237
+// replace github.com/kerberos-io/joy4 v1.0.57 => ../../../../github.com/kerberos-io/joy4
+// replace github.com/kerberos-io/onvif v0.0.6 => ../../../../github.com/kerberos-io/onvif
 
 require (
-	github.com/Eyevinn/mp4ff v0.48.0
 	github.com/InVisionApp/conjungo v1.1.0
-	github.com/appleboy/gin-jwt/v2 v2.10.3
-	github.com/bluenviron/gortsplib/v5 v5.6.3
-	github.com/bluenviron/mediacommon v1.14.0
+	github.com/appleboy/gin-jwt/v2 v2.9.1
+	github.com/asticode/go-astits v1.11.0
+	github.com/bluenviron/gortsplib/v3 v3.6.1
+	github.com/bluenviron/mediacommon v0.5.0
 	github.com/cedricve/go-onvif v0.0.0-20200222191200-567e8ce298f6
-	github.com/dromara/carbon/v2 v2.6.8
+	github.com/deepch/vdk v0.0.19
 	github.com/dropbox/dropbox-sdk-go-unofficial/v6 v6.0.5
-	github.com/eclipse/paho.mqtt.golang v1.5.0
-	github.com/elastic/go-sysinfo v1.15.3
-	github.com/gin-contrib/cors v1.7.5
-	github.com/gin-contrib/pprof v1.5.3
-	github.com/gin-gonic/contrib v0.0.0-20250521004450-2b1292699c15
-	github.com/gin-gonic/gin v1.10.1
-	github.com/gofrs/uuid v4.4.0+incompatible
-	github.com/golang-jwt/jwt/v4 v4.5.2
-	github.com/gorilla/websocket v1.5.3
+	github.com/eclipse/paho.mqtt.golang v1.4.2
+	github.com/elastic/go-sysinfo v1.9.0
+	github.com/gin-contrib/cors v1.4.0
+	github.com/gin-contrib/pprof v1.4.0
+	github.com/gin-gonic/contrib v0.0.0-20221130124618-7e01895a63f2
+	github.com/gin-gonic/gin v1.8.2
+	github.com/golang-jwt/jwt/v4 v4.4.3
+	github.com/golang-module/carbon/v2 v2.2.3
+	github.com/gorilla/websocket v1.5.0
 	github.com/kellydunn/golang-geo v0.7.0
-	github.com/kerberos-io/joy4 v1.0.64
-	github.com/kerberos-io/onvif v1.2.2
+	github.com/kerberos-io/joy4 v1.0.58
+	github.com/kerberos-io/onvif v0.0.7
 	github.com/minio/minio-go/v6 v6.0.57
-	github.com/moq-dev/moq-go v0.5.7
-	github.com/nfnt/resize v0.0.0-20180221191011-83c6a9932646
-	github.com/pion/interceptor v0.1.47
-	github.com/pion/rtp v1.10.5
-	github.com/pion/webrtc/v4 v4.2.18
-	github.com/sirupsen/logrus v1.9.3
-	github.com/stretchr/testify v1.11.1
-	github.com/swaggo/files v1.0.1
-	github.com/swaggo/gin-swagger v1.6.0
-	github.com/swaggo/swag v1.16.4
+	github.com/nsmith5/mjpeg v0.0.0-20200913181537-54b8ada0e53e
+	github.com/op/go-logging v0.0.0-20160315200505-970db520ece7
+	github.com/pion/rtp v1.7.13
+	github.com/pion/webrtc/v3 v3.1.50
+	github.com/sirupsen/logrus v1.9.0
+	github.com/swaggo/files v1.0.0
+	github.com/swaggo/gin-swagger v1.5.3
+	github.com/swaggo/swag v1.8.9
 	github.com/tevino/abool v1.2.0
-	github.com/zaf/g711 v1.4.0
-	go.mongodb.org/mongo-driver v1.17.3
-	go.opentelemetry.io/otel v1.36.0
-	go.opentelemetry.io/otel/exporters/otlp/otlptrace v1.36.0
-	go.opentelemetry.io/otel/exporters/otlp/otlptrace/otlptracehttp v1.36.0
-	go.opentelemetry.io/otel/sdk v1.36.0
-	go.opentelemetry.io/otel/trace v1.36.0
+	go.mongodb.org/mongo-driver v1.7.5
+	gopkg.in/DataDog/dd-trace-go.v1 v1.46.0
+	gopkg.in/natefinch/lumberjack.v2 v2.0.0
 )
 
 require (
+	github.com/DataDog/datadog-agent/pkg/obfuscate v0.0.0-20211129110424-6491aa3bf583 // indirect
+	github.com/DataDog/datadog-agent/pkg/remoteconfig/state v0.42.0-rc.1 // indirect
+	github.com/DataDog/datadog-go v4.8.2+incompatible // indirect
+	github.com/DataDog/datadog-go/v5 v5.0.2 // indirect
+	github.com/DataDog/go-tuf v0.3.0--fix-localmeta-fork // indirect
+	github.com/DataDog/gostackparse v0.5.0 // indirect
+	github.com/DataDog/sketches-go v1.2.1 // indirect
 	github.com/KyleBanks/depth v1.2.1 // indirect
+	github.com/Microsoft/go-winio v0.5.1 // indirect
 	github.com/PuerkitoBio/purell v1.1.1 // indirect
 	github.com/PuerkitoBio/urlesc v0.0.0-20170810143723-de5bf2ad4578 // indirect
-	github.com/beevik/etree v1.2.0 // indirect
-	github.com/bluenviron/mediacommon/v2 v2.9.2 // indirect
-	github.com/bytedance/sonic v1.13.2 // indirect
-	github.com/bytedance/sonic/loader v0.2.4 // indirect
-	github.com/cenkalti/backoff/v5 v5.0.2 // indirect
+	github.com/asticode/go-astikit v0.30.0 // indirect
+	github.com/beevik/etree v1.1.0 // indirect
+	github.com/cespare/xxhash/v2 v2.1.2 // indirect
 	github.com/clbanning/mxj v1.8.4 // indirect
-	github.com/clbanning/mxj/v2 v2.7.0 // indirect
-	github.com/cloudwego/base64x v0.1.5 // indirect
-	github.com/davecgh/go-spew v1.1.1 // indirect
-	github.com/elastic/go-windows v1.0.2 // indirect
+	github.com/dgraph-io/ristretto v0.1.0 // indirect
+	github.com/dustin/go-humanize v1.0.0 // indirect
+	github.com/elastic/go-windows v1.0.0 // indirect
 	github.com/elgs/gostrgen v0.0.0-20161222160715-9d61ae07eeae // indirect
 	github.com/erikstmartin/go-testdb v0.0.0-20160219214506-8d10e4a1bae5 // indirect
-	github.com/gabriel-vasile/mimetype v1.4.8 // indirect
-	github.com/gin-contrib/sse v1.0.0 // indirect
-	github.com/go-logr/logr v1.4.2 // indirect
-	github.com/go-logr/stdr v1.2.2 // indirect
+	github.com/gin-contrib/sse v0.1.0 // indirect
 	github.com/go-openapi/jsonpointer v0.19.5 // indirect
 	github.com/go-openapi/jsonreference v0.19.6 // indirect
 	github.com/go-openapi/spec v0.20.4 // indirect
 	github.com/go-openapi/swag v0.19.15 // indirect
-	github.com/go-playground/locales v0.14.1 // indirect
-	github.com/go-playground/universal-translator v0.18.1 // indirect
-	github.com/go-playground/validator/v10 v10.26.0 // indirect
-	github.com/goccy/go-json v0.10.5 // indirect
+	github.com/go-playground/locales v0.14.0 // indirect
+	github.com/go-playground/universal-translator v0.18.0 // indirect
+	github.com/go-playground/validator/v10 v10.11.1 // indirect
+	github.com/go-stack/stack v1.8.0 // indirect
+	github.com/goccy/go-json v0.10.0 // indirect
+	github.com/gofrs/uuid v3.2.0+incompatible // indirect
+	github.com/golang/glog v0.0.0-20160126235308-23def4e6c14b // indirect
+	github.com/golang/protobuf v1.5.3 // indirect
 	github.com/golang/snappy v0.0.4 // indirect
-	github.com/google/uuid v1.6.0 // indirect
-	github.com/grpc-ecosystem/grpc-gateway/v2 v2.26.3 // indirect
+	github.com/google/go-cmp v0.5.9 // indirect
+	github.com/google/pprof v0.0.0-20210423192551-a2663126120b // indirect
+	github.com/google/uuid v1.3.0 // indirect
+	github.com/joeshaw/multierror v0.0.0-20140124173710-69b34d4ec901 // indirect
 	github.com/josharian/intern v1.0.0 // indirect
 	github.com/json-iterator/go v1.1.12 // indirect
-	github.com/juju/errors v1.0.0 // indirect
-	github.com/klauspost/compress v1.16.7 // indirect
+	github.com/klauspost/compress v1.15.0 // indirect
 	github.com/klauspost/cpuid v1.2.3 // indirect
-	github.com/klauspost/cpuid/v2 v2.2.10 // indirect
 	github.com/kylelemons/go-gypsy v1.0.0 // indirect
-	github.com/leodido/go-urn v1.4.0 // indirect
-	github.com/lib/pq v1.10.9 // indirect
-	github.com/mailru/easyjson v0.7.6 // indirect
-	github.com/mattn/go-isatty v0.0.20 // indirect
+	github.com/leodido/go-urn v1.2.1 // indirect
+	github.com/lib/pq v1.10.7 // indirect
+	github.com/mailru/easyjson v0.7.7 // indirect
+	github.com/mattn/go-isatty v0.0.16 // indirect
 	github.com/minio/md5-simd v1.1.0 // indirect
 	github.com/minio/sha256-simd v0.1.1 // indirect
 	github.com/mitchellh/go-homedir v1.1.0 // indirect
 	github.com/modern-go/concurrent v0.0.0-20180306012644-bacd9c7ef1dd // indirect
 	github.com/modern-go/reflect2 v1.0.2 // indirect
-	github.com/montanaflynn/stats v0.7.1 // indirect
-	github.com/moq-dev/moq-go-ffi v0.3.7 // indirect
-	github.com/nxadm/tail v1.4.11 // indirect
-	github.com/pelletier/go-toml/v2 v2.2.3 // indirect
-	github.com/pion/datachannel v1.6.2 // indirect
-	github.com/pion/dtls/v3 v3.1.5 // indirect
-	github.com/pion/ice/v4 v4.4.0 // indirect
-	github.com/pion/logging v0.2.4 // indirect
-	github.com/pion/mdns/v2 v2.1.0 // indirect
+	github.com/onsi/gomega v1.27.4 // indirect
+	github.com/pelletier/go-toml/v2 v2.0.6 // indirect
+	github.com/philhofer/fwd v1.1.1 // indirect
+	github.com/pion/datachannel v1.5.5 // indirect
+	github.com/pion/dtls/v2 v2.1.5 // indirect
+	github.com/pion/ice/v2 v2.2.12 // indirect
+	github.com/pion/interceptor v0.1.11 // indirect
+	github.com/pion/logging v0.2.2 // indirect
+	github.com/pion/mdns v0.0.5 // indirect
 	github.com/pion/randutil v0.1.0 // indirect
-	github.com/pion/rtcp v1.2.17 // indirect
-	github.com/pion/sctp v1.11.1 // indirect
-	github.com/pion/sdp/v3 v3.0.19 // indirect
-	github.com/pion/srtp/v3 v3.0.12 // indirect
-	github.com/pion/stun/v3 v3.1.6 // indirect
-	github.com/pion/transport/v4 v4.0.2 // indirect
-	github.com/pion/turn/v5 v5.0.12 // indirect
-	github.com/pmezard/go-difflib v1.0.0 // indirect
-	github.com/prometheus/procfs v0.15.1 // indirect
-	github.com/twitchyliquid64/golang-asm v0.15.1 // indirect
-	github.com/ugorji/go/codec v1.2.12 // indirect
-	github.com/wlynxg/anet v0.0.5 // indirect
+	github.com/pion/rtcp v1.2.10 // indirect
+	github.com/pion/sctp v1.8.5 // indirect
+	github.com/pion/sdp/v3 v3.0.6 // indirect
+	github.com/pion/srtp/v2 v2.0.10 // indirect
+	github.com/pion/stun v0.3.5 // indirect
+	github.com/pion/transport v0.14.1 // indirect
+	github.com/pion/turn/v2 v2.0.8 // indirect
+	github.com/pion/udp v0.1.1 // indirect
+	github.com/pkg/errors v0.9.1 // indirect
+	github.com/prometheus/procfs v0.8.0 // indirect
+	github.com/richardartoul/molecule v1.0.1-0.20221107223329-32cfee06a052 // indirect
+	github.com/secure-systems-lab/go-securesystemslib v0.4.0 // indirect
+	github.com/spaolacci/murmur3 v1.1.0 // indirect
+	github.com/tinylib/msgp v1.1.6 // indirect
+	github.com/ugorji/go/codec v1.2.7 // indirect
 	github.com/xdg-go/pbkdf2 v1.0.0 // indirect
-	github.com/xdg-go/scram v1.1.2 // indirect
-	github.com/xdg-go/stringprep v1.0.4 // indirect
-	github.com/youmark/pkcs8 v0.0.0-20240726163527-a2c0da244d78 // indirect
+	github.com/xdg-go/scram v1.0.2 // indirect
+	github.com/xdg-go/stringprep v1.0.2 // indirect
+	github.com/youmark/pkcs8 v0.0.0-20181117223130-1be2e3e5546d // indirect
 	github.com/ziutek/mymysql v1.5.4 // indirect
-	go.opentelemetry.io/auto/sdk v1.1.0 // indirect
-	go.opentelemetry.io/otel/metric v1.36.0 // indirect
-	go.opentelemetry.io/proto/otlp v1.6.0 // indirect
-	golang.org/x/arch v0.16.0 // indirect
-	golang.org/x/crypto v0.54.0 // indirect
-	golang.org/x/net v0.57.0 // indirect
-	golang.org/x/oauth2 v0.30.0 // indirect
-	golang.org/x/sync v0.22.0 // indirect
-	golang.org/x/sys v0.47.0 // indirect
-	golang.org/x/text v0.40.0 // indirect
-	golang.org/x/time v0.14.0 // indirect
-	golang.org/x/tools v0.47.0 // indirect
-	google.golang.org/genproto/googleapis/api v0.0.0-20250519155744-55703ea1f237 // indirect
-	google.golang.org/genproto/googleapis/rpc v0.0.0-20250519155744-55703ea1f237 // indirect
-	google.golang.org/grpc v1.72.1 // indirect
-	google.golang.org/protobuf v1.36.6 // indirect
+	go4.org/intern v0.0.0-20211027215823-ae77deb06f29 // indirect
+	go4.org/unsafe/assume-no-moving-gc v0.0.0-20220617031537-928513b29760 // indirect
+	golang.org/x/crypto v0.4.0 // indirect
+	golang.org/x/net v0.9.0 // indirect
+	golang.org/x/oauth2 v0.0.0-20201208152858-08078c50e5b5 // indirect
+	golang.org/x/sync v0.1.0 // indirect
+	golang.org/x/sys v0.7.0 // indirect
+	golang.org/x/text v0.9.0 // indirect
+	golang.org/x/time v0.0.0-20211116232009-f0f3c7e86c11 // indirect
+	golang.org/x/tools v0.7.0 // indirect
+	golang.org/x/xerrors v0.0.0-20200804184101-5ec99f83aff1 // indirect
+	google.golang.org/appengine v1.6.6 // indirect
+	google.golang.org/grpc v1.32.0 // indirect
+	google.golang.org/protobuf v1.28.1 // indirect
 	gopkg.in/ini.v1 v1.42.0 // indirect
 	gopkg.in/yaml.v2 v2.4.0 // indirect
-	gopkg.in/yaml.v3 v3.0.1 // indirect
 	howett.net/plist v0.0.0-20181124034731-591f970eefbb // indirect
+	inet.af/netaddr v0.0.0-20220617031823-097006376321 // indirect
 )

machinery/logging.go

@@ -1,160 +0,0 @@
-package main
-
-import (
-	"fmt"
-	"os"
-	"path/filepath"
-	"runtime"
-	"strings"
-	"time"
-
-	log "github.com/sirupsen/logrus"
-)
-
-const (
-	defaultLogLevel  = log.InfoLevel
-	defaultLogOutput = "text"
-)
-
-type localTimeFormatter struct {
-	timezone  *time.Location
-	formatter log.Formatter
-}
-
-func (f localTimeFormatter) Format(entry *log.Entry) ([]byte, error) {
-	entry.Time = entry.Time.In(f.timezone)
-	return f.formatter.Format(entry)
-}
-
-type componentHook struct{}
-
-func (componentHook) Levels() []log.Level {
-	return log.AllLevels
-}
-
-func (componentHook) Fire(entry *log.Entry) error {
-	if _, exists := entry.Data["component"]; exists {
-		return nil
-	}
-	entry.Data["component"] = componentFromCaller(entry.Caller)
-	return nil
-}
-
-func configureLogging(levelValue string, outputValue string, timezone *time.Location) {
-	configureLogger(log.StandardLogger(), levelValue, outputValue, timezone)
-}
-
-func configureLogger(logger *log.Logger, levelValue string, outputValue string, timezone *time.Location) {
-	if timezone == nil {
-		timezone = time.Local
-	}
-
-	level, levelErr := parseLogLevel(levelValue)
-	output, outputErr := parseLogOutput(outputValue)
-
-	logger.SetOutput(os.Stdout)
-	logger.SetLevel(level)
-	logger.SetReportCaller(true)
-	logger.SetFormatter(localTimeFormatter{
-		timezone:  timezone,
-		formatter: newLogFormatter(output),
-	})
-	installComponentHook(logger)
-
-	if levelErr != nil {
-		logger.WithFields(log.Fields{
-			"configured_level": levelValue,
-			"effective_level":  level.String(),
-		}).WithError(levelErr).Warn("invalid log level; using default")
-	}
-	if outputErr != nil {
-		logger.WithFields(log.Fields{
-			"configured_output": outputValue,
-			"effective_output":  output,
-		}).WithError(outputErr).Warn("invalid log output; using default")
-	}
-
-	logger.WithFields(log.Fields{
-		"event":         "logger_configured",
-		"log_level":     level.String(),
-		"output":        output,
-		"report_caller": logger.ReportCaller,
-		"timezone":      timezone.String(),
-	}).Debug("logging configured")
-}
-
-func installComponentHook(logger *log.Logger) {
-	for _, hooks := range logger.Hooks {
-		for _, hook := range hooks {
-			if _, ok := hook.(componentHook); ok {
-				return
-			}
-		}
-	}
-	logger.AddHook(componentHook{})
-}
-
-func componentFromCaller(frame *runtime.Frame) string {
-	if frame == nil {
-		return "unknown"
-	}
-
-	const sourceMarker = "/machinery/src/"
-	normalizedFile := filepath.ToSlash(frame.File)
-	if markerIndex := strings.Index(normalizedFile, sourceMarker); markerIndex >= 0 {
-		relativeFile := normalizedFile[markerIndex+len(sourceMarker):]
-		if directory := filepath.ToSlash(filepath.Dir(relativeFile)); directory != "." {
-			return directory
-		}
-	}
-	if strings.Contains(normalizedFile, "/machinery/") {
-		return "agent"
-	}
-	return "unknown"
-}
-
-func parseLogLevel(value string) (log.Level, error) {
-	normalized := strings.ToLower(strings.TrimSpace(value))
-	if normalized == "" {
-		return defaultLogLevel, nil
-	}
-	if normalized == "warning" {
-		normalized = "warn"
-	}
-
-	level, err := log.ParseLevel(normalized)
-	if err != nil {
-		return defaultLogLevel, fmt.Errorf("parse LOG_LEVEL: %w", err)
-	}
-	return level, nil
-}
-
-func parseLogOutput(value string) (string, error) {
-	normalized := strings.ToLower(strings.TrimSpace(value))
-	if normalized == "" {
-		return defaultLogOutput, nil
-	}
-	switch normalized {
-	case "json", "text":
-		return normalized, nil
-	default:
-		return defaultLogOutput, fmt.Errorf("unsupported LOG_OUTPUT %q", value)
-	}
-}
-
-func newLogFormatter(output string) log.Formatter {
-	callerPrettyfier := func(frame *runtime.Frame) (string, string) {
-		return filepath.Base(frame.Function), fmt.Sprintf("%s:%d", filepath.Base(frame.File), frame.Line)
-	}
-	if output == "json" {
-		return &log.JSONFormatter{
-			CallerPrettyfier: callerPrettyfier,
-			TimestampFormat:  time.RFC3339Nano,
-		}
-	}
-	return &log.TextFormatter{
-		CallerPrettyfier: callerPrettyfier,
-		FullTimestamp:    true,
-		TimestampFormat:  time.RFC3339Nano,
-	}
-}

machinery/logging_test.go

@@ -1,165 +0,0 @@
-package main
-
-import (
-	"bytes"
-	"encoding/json"
-	"runtime"
-	"strings"
-	"testing"
-	"time"
-
-	log "github.com/sirupsen/logrus"
-)
-
-func TestConfigureLoggingDebugIncludesStructuredContext(t *testing.T) {
-	logger := log.New()
-	var output bytes.Buffer
-	configureLogger(logger, "debug", "json", time.UTC)
-	logger.SetOutput(&output)
-	logger.WithField("event", "test_event").Debug("structured debug test")
-
-	lines := strings.Split(strings.TrimSpace(output.String()), "\n")
-	var entry map[string]interface{}
-	if err := json.Unmarshal([]byte(lines[len(lines)-1]), &entry); err != nil {
-		t.Fatalf("decode debug log: %v; output=%q", err, output.String())
-	}
-	for key, want := range map[string]interface{}{
-		"component": "agent",
-		"event":     "test_event",
-		"level":     "debug",
-		"msg":       "structured debug test",
-	} {
-		if got := entry[key]; got != want {
-			t.Fatalf("%s = %v, want %v", key, got, want)
-		}
-	}
-	if entry["file"] == nil || entry["func"] == nil {
-		t.Fatalf("debug log is missing caller metadata: %v", entry)
-	}
-}
-
-func TestConfigureLoggerInstallsComponentHookOnce(t *testing.T) {
-	logger := log.New()
-	configureLogger(logger, "info", "text", time.UTC)
-	configureLogger(logger, "debug", "json", time.UTC)
-
-	var componentHooks int
-	for _, hooks := range logger.Hooks {
-		for _, hook := range hooks {
-			if _, ok := hook.(componentHook); ok {
-				componentHooks++
-			}
-		}
-	}
-	if componentHooks != len(log.AllLevels) {
-		t.Fatalf("component hook registrations = %d, want %d", componentHooks, len(log.AllLevels))
-	}
-}
-
-func TestComponentFromCaller(t *testing.T) {
-	tests := []struct {
-		name  string
-		frame *runtime.Frame
-		want  string
-	}{
-		{
-			name:  "nested runtime package",
-			frame: &runtime.Frame{File: "/workspace/agent/machinery/src/routers/mqtt/main.go"},
-			want:  "routers/mqtt",
-		},
-		{
-			name:  "top-level runtime package",
-			frame: &runtime.Frame{File: "/workspace/agent/machinery/src/capture/main.go"},
-			want:  "capture",
-		},
-		{
-			name:  "executable",
-			frame: &runtime.Frame{File: "/workspace/agent/machinery/main.go"},
-			want:  "agent",
-		},
-		{name: "missing caller", want: "unknown"},
-	}
-
-	for _, test := range tests {
-		t.Run(test.name, func(t *testing.T) {
-			if got := componentFromCaller(test.frame); got != test.want {
-				t.Fatalf("componentFromCaller() = %q, want %q", got, test.want)
-			}
-		})
-	}
-}
-
-func TestComponentHookAddsAndPreservesComponent(t *testing.T) {
-	hook := componentHook{}
-
-	entry := log.NewEntry(log.New())
-	entry.Caller = &runtime.Frame{File: "/workspace/agent/machinery/src/cloud/livehls/session.go"}
-	if err := hook.Fire(entry); err != nil {
-		t.Fatalf("componentHook.Fire() error = %v", err)
-	}
-	if got := entry.Data["component"]; got != "cloud/livehls" {
-		t.Fatalf("component = %v, want cloud/livehls", got)
-	}
-
-	entry.Data["component"] = "explicit"
-	if err := hook.Fire(entry); err != nil {
-		t.Fatalf("componentHook.Fire() preserving field error = %v", err)
-	}
-	if got := entry.Data["component"]; got != "explicit" {
-		t.Fatalf("component = %v, want explicit", got)
-	}
-}
-
-func TestParseLogLevel(t *testing.T) {
-	tests := []struct {
-		name    string
-		value   string
-		want    log.Level
-		wantErr bool
-	}{
-		{name: "default", want: log.InfoLevel},
-		{name: "info", value: "INFO", want: log.InfoLevel},
-		{name: "warning alias", value: "warning", want: log.WarnLevel},
-		{name: "debug", value: "debug", want: log.DebugLevel},
-		{name: "trace", value: "trace", want: log.TraceLevel},
-		{name: "invalid", value: "verbose", want: log.InfoLevel, wantErr: true},
-	}
-
-	for _, test := range tests {
-		t.Run(test.name, func(t *testing.T) {
-			got, err := parseLogLevel(test.value)
-			if (err != nil) != test.wantErr {
-				t.Fatalf("parseLogLevel(%q) error = %v, wantErr %t", test.value, err, test.wantErr)
-			}
-			if got != test.want {
-				t.Fatalf("parseLogLevel(%q) = %s, want %s", test.value, got, test.want)
-			}
-		})
-	}
-}
-
-func TestParseLogOutput(t *testing.T) {
-	tests := []struct {
-		name    string
-		value   string
-		want    string
-		wantErr bool
-	}{
-		{name: "default", want: "text"},
-		{name: "text", value: "TEXT", want: "text"},
-		{name: "json", value: "json", want: "json"},
-		{name: "invalid", value: "console", want: "text", wantErr: true},
-	}
-
-	for _, test := range tests {
-		t.Run(test.name, func(t *testing.T) {
-			got, err := parseLogOutput(test.value)
-			if (err != nil) != test.wantErr {
-				t.Fatalf("parseLogOutput(%q) error = %v, wantErr %t", test.value, err, test.wantErr)
-			}
-			if got != test.want {
-				t.Fatalf("parseLogOutput(%q) = %q, want %q", test.value, got, test.want)
-			}
-		})
-	}
-}

machinery/main.go

@@ -3,71 +3,53 @@ package main
 import (
 	"context"
 	"flag"
-	"fmt"
 	"os"
-	"strings"
 	"time"
 
-	"github.com/kerberos-io/agent/machinery/src/capture"
 	"github.com/kerberos-io/agent/machinery/src/components"
+	"github.com/kerberos-io/agent/machinery/src/log"
 	"github.com/kerberos-io/agent/machinery/src/models"
-	"github.com/kerberos-io/agent/machinery/src/onvif"
-	log "github.com/sirupsen/logrus"
-	"go.opentelemetry.io/otel"
-	"go.opentelemetry.io/otel/attribute"
-	"go.opentelemetry.io/otel/exporters/otlp/otlptrace"
-	"go.opentelemetry.io/otel/exporters/otlp/otlptrace/otlptracehttp"
-	"go.opentelemetry.io/otel/sdk/resource"
-	"go.opentelemetry.io/otel/sdk/trace"
-	semconv "go.opentelemetry.io/otel/semconv/v1.4.0"
 
 	configService "github.com/kerberos-io/agent/machinery/src/config"
 	"github.com/kerberos-io/agent/machinery/src/routers"
 	"github.com/kerberos-io/agent/machinery/src/utils"
+	"gopkg.in/DataDog/dd-trace-go.v1/ddtrace/tracer"
+	"gopkg.in/DataDog/dd-trace-go.v1/profiler"
 )
 
-var VERSION = utils.VERSION
-
-func startTracing(agentKey string, otelEndpoint string) (*trace.TracerProvider, error) {
-	serviceName := "agent-" + agentKey
-	headers := map[string]string{
-		"content-type": "application/json",
-	}
-
-	exporter, err := otlptrace.New(
-		context.Background(),
-		otlptracehttp.NewClient(
-			otlptracehttp.WithEndpoint(otelEndpoint),
-			otlptracehttp.WithHeaders(headers),
-			otlptracehttp.WithInsecure(),
-		),
-	)
-	if err != nil {
-		return nil, fmt.Errorf("creating new exporter: %w", err)
-	}
-
-	tracerprovider := trace.NewTracerProvider(
-		trace.WithBatcher(
-			exporter,
-			trace.WithMaxExportBatchSize(trace.DefaultMaxExportBatchSize),
-			trace.WithBatchTimeout(trace.DefaultScheduleDelay*time.Millisecond),
-			trace.WithMaxExportBatchSize(trace.DefaultMaxExportBatchSize),
-		),
-		trace.WithResource(
-			resource.NewWithAttributes(
-				semconv.SchemaURL,
-				semconv.ServiceNameKey.String(serviceName),
-				attribute.String("environment", "develop"),
-			),
-		),
-	)
-
-	otel.SetTracerProvider(tracerprovider)
-
-	return tracerprovider, nil
-}
+var VERSION = "3.0.0"
 
 func main() {
+	// You might be interested in debugging the agent.
+	if os.Getenv("DATADOG_AGENT_ENABLED") == "true" {
+		if os.Getenv("DATADOG_AGENT_K8S_ENABLED") == "true" {
+			tracer.Start()
+			defer tracer.Stop()
+		} else {
+			service := os.Getenv("DATADOG_AGENT_SERVICE")
+			environment := os.Getenv("DATADOG_AGENT_ENVIRONMENT")
+			log.Log.Info("Starting Datadog Agent with service: " + service + " and environment: " + environment)
+			rules := []tracer.SamplingRule{tracer.RateRule(1)}
+			tracer.Start(
+				tracer.WithSamplingRules(rules),
+				tracer.WithService(service),
+				tracer.WithEnv(environment),
+			)
+			defer tracer.Stop()
+			err := profiler.Start(
+				profiler.WithService(service),
+				profiler.WithEnv(environment),
+				profiler.WithProfileTypes(
+					profiler.CPUProfile,
+					profiler.HeapProfile,
+				),
+			)
+			if err != nil {
+				log.Log.Fatal(err.Error())
+			}
+			defer profiler.Stop()
+		}
+	}
 
 	// Start the show ;)
 	// We'll parse the flags (named variables), and start the agent.
@@ -77,89 +59,28 @@ func main() {
 	var name string
 	var port string
 	var timeout string
-	var subnet string
 
 	flag.StringVar(&action, "action", "version", "Tell us what you want do 'run' or 'version'")
 	flag.StringVar(&configDirectory, "config", ".", "Where is the configuration stored")
 	flag.StringVar(&name, "name", "agent", "Provide a name for the agent")
 	flag.StringVar(&port, "port", "80", "On which port should the agent run")
 	flag.StringVar(&timeout, "timeout", "2000", "Number of milliseconds to wait for the ONVIF discovery to complete")
-	flag.StringVar(&subnet, "subnet", "", "Optional subnet(s) to scan for discovery, e.g. '192.168.1.0/24' (comma-separated). Defaults to the local interfaces.")
 	flag.Parse()
 
-	// Specify the level of loggin: "info", "warning", "debug", "error" or "fatal."
-	logLevel := os.Getenv("LOG_LEVEL")
-	if logLevel == "" {
-		logLevel = "info"
-	}
-	// Specify the output formatter of the log: "text" or "json".
-	logOutput := os.Getenv("LOG_OUTPUT")
-	if logOutput == "" {
-		logOutput = "text"
-	}
-	// Specify the timezone of the log: "UTC" or "Local".
 	timezone, _ := time.LoadLocation("CET")
-	configureLogging(logLevel, logOutput, timezone)
-	log.WithFields(log.Fields{
-		"action":           action,
-		"component":        "agent",
-		"config_directory": configDirectory,
-		"event":            "command_parsed",
-		"port":             port,
-		"version":          VERSION,
-	}).Debug("Agent command parsed")
+	log.Log.Init(configDirectory, timezone)
 
 	switch action {
 
 	case "version":
-		{
-			log.WithFields(log.Fields{
-				"component": "agent",
-				"event":     "version",
-				"version":   VERSION,
-			}).Info("Kerberos Agent version")
-		}
+		log.Log.Info("You are currrently running Kerberos Agent " + VERSION)
+
 	case "discover":
-		{
-			// Convert duration to int
-			timeout, err := time.ParseDuration(timeout + "ms")
-			if err != nil {
-				log.WithError(err).WithField("component", "onvif").
-					Fatal("invalid ONVIF discovery timeout")
-				return
-			}
-			var subnets []string
-			for _, part := range strings.Split(subnet, ",") {
-				if trimmed := strings.TrimSpace(part); trimmed != "" {
-					subnets = append(subnets, trimmed)
-				}
-			}
-			onvif.Discover(timeout, subnets...)
-		}
-	case "decrypt":
-		{
-			log.WithFields(log.Fields{
-				"component": "encryption",
-				"event":     "decrypt_started",
-				"path":      flag.Arg(0),
-			}).Info("Decrypting recording")
-			symmetricKey := []byte(flag.Arg(1))
-
-			if len(symmetricKey) == 0 {
-				log.Fatal("main.Main(): symmetric key should not be empty")
-				return
-			}
-			if len(symmetricKey) != 32 {
-				log.Fatal("main.Main(): symmetric key should be 32 bytes")
-				return
-			}
-
-			utils.Decrypt(flag.Arg(0), symmetricKey)
-		}
+		log.Log.Info(timeout)
 
 	case "run":
 		{
-			// Print Agent ASCII art
+			// Print Kerberos.io ASCII art
 			utils.PrintASCIIArt()
 
 			// Print the environment variables which include "AGENT_" as prefix.
@@ -172,38 +93,12 @@ func main() {
 			configuration.Name = name
 			configuration.Port = port
 
-			// Open this configuration either from Agent or Factory.
+			// Open this configuration either from Kerberos Agent or Kerberos Factory.
 			configService.OpenConfig(configDirectory, &configuration)
 
 			// We will override the configuration with the environment variables
 			configService.OverrideWithEnvironmentVariables(&configuration)
 
-			// Start OpenTelemetry tracing
-			if otelEndpoint := os.Getenv("OTEL_EXPORTER_OTLP_ENDPOINT"); otelEndpoint == "" {
-				log.WithFields(log.Fields{
-					"component": "tracing",
-					"event":     "tracing_disabled",
-				}).Debug("OpenTelemetry tracing disabled")
-			} else {
-				log.WithFields(log.Fields{
-					"component": "tracing",
-					"event":     "tracing_starting",
-				}).Info("Starting OpenTelemetry tracing")
-				agentKey := configuration.Config.Key
-				traceProvider, err := startTracing(agentKey, otelEndpoint)
-				if err != nil {
-					log.WithError(err).WithField("component", "tracing").
-						Error("Failed to start OpenTelemetry tracing")
-				} else {
-					defer func() {
-						if err := traceProvider.Shutdown(context.Background()); err != nil {
-							log.WithError(err).WithField("component", "tracing").
-								Error("Failed to shut down OpenTelemetry tracing")
-						}
-					}()
-				}
-			}
-
 			// Printing final configuration
 			utils.PrintConfiguration(&configuration)
 
@@ -212,13 +107,8 @@ func main() {
 			utils.CheckDataDirectoryPermissions(configDirectory)
 
 			// Set timezone
-			timezone, err := time.LoadLocation(configuration.Config.Timezone)
-			if err != nil {
-				log.WithError(err).WithField("timezone", configuration.Config.Timezone).
-					Warn("invalid Agent timezone; using the host timezone for logs")
-				timezone = time.Local
-			}
-			configureLogging(logLevel, logOutput, timezone)
+			timezone, _ := time.LoadLocation(configuration.Config.Timezone)
+			log.Log.Init(configDirectory, timezone)
 
 			// Check if we have a device Key or not, if not
 			// we will generate one.
@@ -227,45 +117,28 @@ func main() {
 				configuration.Config.Key = key
 				err := configService.StoreConfig(configDirectory, configuration.Config)
 				if err == nil {
-					log.WithFields(log.Fields{
-						"component": "configuration",
-						"event":     "agent_key_generated",
-					}).Info("Generated and stored a unique Agent key")
+					log.Log.Info("Main: updated unique key for agent to: " + key)
 				} else {
-					log.WithError(err).WithFields(log.Fields{
-						"component": "configuration",
-						"event":     "agent_key_store_failed",
-					}).Error("Failed to store the generated Agent key")
+					log.Log.Info("Main: something went wrong while trying to store key: " + key)
 				}
 			}
 
 			// Create a cancelable context, which will be used to cancel and restart.
 			// This is used to restart the agent when the configuration is updated.
 			ctx, cancel := context.WithCancel(context.Background())
-			defer cancel()
-
-			// We create a capture object, this will contain all the streaming clients.
-			// And allow us to extract media from within difference places in the agent.
-			capture := capture.Capture{}
 
 			// Bootstrapping the agent
 			communication := models.Communication{
+				Context:         &ctx,
+				CancelContext:   &cancel,
 				HandleBootstrap: make(chan string, 1),
 			}
-
-			log.WithFields(log.Fields{
-				"component": "agent",
-				"event":     "runtime_starting",
-				"port":      configuration.Port,
-			}).Info("Starting Agent runtime")
-			go components.Bootstrap(ctx, configDirectory, &configuration, &communication, &capture)
+			go components.Bootstrap(configDirectory, &configuration, &communication)
 
 			// Start the REST API.
-			routers.StartWebserver(configDirectory, &configuration, &communication, &capture)
+			routers.StartWebserver(configDirectory, &configuration, &communication)
 		}
 	default:
-		{
-			log.Error("main.Main(): Sorry I don't understand :(")
-		}
+		log.Log.Error("Main: Sorry I don't understand :(")
 	}
 }

machinery/src/api/onvif.go

@@ -0,0 +1 @@
+package api

machinery/src/capture/IPCamera.go

@@ -0,0 +1,150 @@
+package capture
+
+import (
+	"context"
+	"strconv"
+	"sync"
+	"time"
+
+	"github.com/kerberos-io/agent/machinery/src/log"
+	"github.com/kerberos-io/agent/machinery/src/models"
+	"github.com/kerberos-io/joy4/av/pubsub"
+
+	"github.com/kerberos-io/joy4/av"
+	"github.com/kerberos-io/joy4/av/avutil"
+	"github.com/kerberos-io/joy4/cgo/ffmpeg"
+	"github.com/kerberos-io/joy4/format"
+)
+
+func OpenRTSP(ctx context.Context, url string) (av.DemuxCloser, []av.CodecData, error) {
+	format.RegisterAll()
+	infile, err := avutil.Open(ctx, url)
+	if err == nil {
+		streams, errstreams := infile.Streams()
+		return infile, streams, errstreams
+	}
+	return nil, []av.CodecData{}, err
+}
+
+func GetVideoStream(streams []av.CodecData) (av.CodecData, error) {
+	var videoStream av.CodecData
+	for _, stream := range streams {
+		if stream.Type().IsAudio() {
+			//astream := stream.(av.AudioCodecData)
+		} else if stream.Type().IsVideo() {
+			videoStream = stream
+		}
+	}
+	return videoStream, nil
+}
+
+func GetVideoDecoder(decoder *ffmpeg.VideoDecoder, streams []av.CodecData) {
+	// Load video codec
+	var vstream av.VideoCodecData
+	for _, stream := range streams {
+		if stream.Type().IsAudio() {
+			//astream := stream.(av.AudioCodecData)
+		} else if stream.Type().IsVideo() {
+			vstream = stream.(av.VideoCodecData)
+		}
+	}
+	err := ffmpeg.NewVideoDecoder(decoder, vstream)
+	if err != nil {
+		log.Log.Error("GetVideoDecoder: " + err.Error())
+	}
+}
+
+func DecodeImage(frame *ffmpeg.VideoFrame, pkt av.Packet, decoder *ffmpeg.VideoDecoder, decoderMutex *sync.Mutex) (*ffmpeg.VideoFrame, error) {
+	decoderMutex.Lock()
+	img, err := decoder.Decode(frame, pkt.Data)
+	decoderMutex.Unlock()
+	return img, err
+}
+
+func HandleStream(infile av.DemuxCloser, queue *pubsub.Queue, communication *models.Communication) { //, wg *sync.WaitGroup) {
+
+	log.Log.Debug("HandleStream: started")
+	var err error
+loop:
+	for {
+		// This will check if we need to stop the thread,
+		// because of a reconfiguration.
+		select {
+		case <-communication.HandleStream:
+			break loop
+		default:
+		}
+
+		var pkt av.Packet
+		if pkt, err = infile.ReadPacket(); err != nil { // sometimes this throws an end of file..
+			log.Log.Error("HandleStream: " + err.Error())
+			time.Sleep(1 * time.Second)
+		}
+
+		// Could be that a decode is throwing errors.
+		if len(pkt.Data) > 0 {
+
+			queue.WritePacket(pkt)
+
+			// This will check if we need to stop the thread,
+			// because of a reconfiguration.
+			select {
+			case <-communication.HandleStream:
+				break loop
+			default:
+			}
+
+			if pkt.IsKeyFrame {
+
+				// Increment packets, so we know the device
+				// is not blocking.
+				r := communication.PackageCounter.Load().(int64)
+				log.Log.Info("HandleStream: packet size " + strconv.Itoa(len(pkt.Data)))
+				communication.PackageCounter.Store((r + 1) % 1000)
+				communication.LastPacketTimer.Store(time.Now().Unix())
+			}
+		}
+	}
+
+	queue.Close()
+	log.Log.Debug("HandleStream: finished")
+}
+
+func HandleSubStream(infile av.DemuxCloser, queue *pubsub.Queue, communication *models.Communication) { //, wg *sync.WaitGroup) {
+
+	log.Log.Debug("HandleSubStream: started")
+	var err error
+loop:
+	for {
+		// This will check if we need to stop the thread,
+		// because of a reconfiguration.
+		select {
+		case <-communication.HandleSubStream:
+			break loop
+		default:
+		}
+
+		var pkt av.Packet
+		if pkt, err = infile.ReadPacket(); err != nil { // sometimes this throws an end of file..
+			log.Log.Error("HandleSubStream: " + err.Error())
+			time.Sleep(1 * time.Second)
+		}
+
+		// Could be that a decode is throwing errors.
+		if len(pkt.Data) > 0 {
+
+			queue.WritePacket(pkt)
+
+			// This will check if we need to stop the thread,
+			// because of a reconfiguration.
+			select {
+			case <-communication.HandleSubStream:
+				break loop
+			default:
+			}
+		}
+	}
+
+	queue.Close()
+	log.Log.Debug("HandleSubStream: finished")
+}

machinery/src/capture/cleanup_test.go

@@ -1,238 +0,0 @@
-package capture
-
-import (
-	"os"
-	"path/filepath"
-	"runtime"
-	"testing"
-	"time"
-
-	"github.com/kerberos-io/agent/machinery/src/models"
-)
-
-// writeRecording creates a file under recordingsDir and sets its modtime so the
-// tests can control the "oldest" ordering deterministically.
-func writeRecording(t *testing.T, recordingsDir, name string, ageMinutes int) {
-	t.Helper()
-	full := filepath.Join(recordingsDir, name)
-	if err := os.WriteFile(full, []byte("data"), 0o644); err != nil {
-		t.Fatalf("write recording %s: %v", name, err)
-	}
-	mod := time.Now().Add(-time.Duration(ageMinutes) * time.Minute)
-	if err := os.Chtimes(full, mod, mod); err != nil {
-		t.Fatalf("chtimes %s: %v", name, err)
-	}
-}
-
-// markPending creates the upload marker in cloudDir for the given recording,
-// marking it as still queued for upload.
-func markPending(t *testing.T, cloudDir, name string) {
-	t.Helper()
-	markerName := models.RecordingUploadMetadataFileName(name)
-	if err := os.WriteFile(filepath.Join(cloudDir, markerName), nil, 0o644); err != nil {
-		t.Fatalf("write marker %s: %v", name, err)
-	}
-}
-
-func newCleanupDirs(t *testing.T) (string, string) {
-	t.Helper()
-	base := t.TempDir()
-	recordingsDir := filepath.Join(base, "data", "recordings")
-	cloudDir := filepath.Join(base, "data", "cloud")
-	if err := os.MkdirAll(recordingsDir, 0o755); err != nil {
-		t.Fatalf("mkdir recordings: %v", err)
-	}
-	if err := os.MkdirAll(cloudDir, 0o755); err != nil {
-		t.Fatalf("mkdir cloud: %v", err)
-	}
-	return recordingsDir, cloudDir
-}
-
-// The core regression: when the oldest recording is still pending upload but a
-// newer one has already been uploaded, cleanup must delete the uploaded (safe)
-// one and leave the pending recording on disk so it can still be uploaded.
-func TestPickRecordingToCleanup_PrefersUploaded(t *testing.T) {
-	recordingsDir, cloudDir := newCleanupDirs(t)
-
-	// oldest is still pending upload (marker present).
-	writeRecording(t, recordingsDir, "oldest_pending.mp4", 30)
-	markPending(t, cloudDir, "oldest_pending.mp4")
-	// newer one has already been uploaded (no marker).
-	writeRecording(t, recordingsDir, "newer_uploaded.mp4", 10)
-
-	name, pending, err := pickRecordingToCleanup(recordingsDir, cloudDir)
-	if err != nil {
-		t.Fatalf("unexpected error: %v", err)
-	}
-	if pending {
-		t.Fatalf("expected a safe (already-uploaded) deletion, got pending=true")
-	}
-	if name != "newer_uploaded.mp4" {
-		t.Fatalf("cleanup picked %q, want the uploaded recording newer_uploaded.mp4", name)
-	}
-}
-
-func TestPickRecordingToCleanup_RecognizesLegacyMarkerName(t *testing.T) {
-	recordingsDir, cloudDir := newCleanupDirs(t)
-
-	writeRecording(t, recordingsDir, "legacy_pending.mp4", 30)
-	if err := os.WriteFile(filepath.Join(cloudDir, "legacy_pending.mp4"), nil, 0o644); err != nil {
-		t.Fatalf("write legacy marker: %v", err)
-	}
-	writeRecording(t, recordingsDir, "uploaded.mp4", 10)
-
-	name, pending, err := pickRecordingToCleanup(recordingsDir, cloudDir)
-	if err != nil {
-		t.Fatalf("unexpected error: %v", err)
-	}
-	if pending || name != "uploaded.mp4" {
-		t.Fatalf("cleanup picked name=%q pending=%v, want uploaded.mp4 pending=false", name, pending)
-	}
-}
-
-// Among several already-uploaded recordings, the oldest uploaded one is chosen.
-func TestPickRecordingToCleanup_OldestUploadedFirst(t *testing.T) {
-	recordingsDir, cloudDir := newCleanupDirs(t)
-
-	writeRecording(t, recordingsDir, "old_uploaded.mp4", 40)
-	writeRecording(t, recordingsDir, "mid_uploaded.mp4", 20)
-	// pending one must be ignored even though it is not the oldest.
-	writeRecording(t, recordingsDir, "pending.mp4", 30)
-	markPending(t, cloudDir, "pending.mp4")
-
-	name, pending, err := pickRecordingToCleanup(recordingsDir, cloudDir)
-	if err != nil {
-		t.Fatalf("unexpected error: %v", err)
-	}
-	if pending {
-		t.Fatalf("expected pending=false, got true")
-	}
-	if name != "old_uploaded.mp4" {
-		t.Fatalf("cleanup picked %q, want old_uploaded.mp4", name)
-	}
-}
-
-// Last resort: when every recording is still pending upload, cleanup returns the
-// oldest one with pending=true so the caller can drop it (and its marker) to keep
-// the disk bounded.
-func TestPickRecordingToCleanup_AllPendingFallsBackToOldest(t *testing.T) {
-	recordingsDir, cloudDir := newCleanupDirs(t)
-
-	writeRecording(t, recordingsDir, "a_old.mp4", 50)
-	markPending(t, cloudDir, "a_old.mp4")
-	writeRecording(t, recordingsDir, "b_new.mp4", 5)
-	markPending(t, cloudDir, "b_new.mp4")
-
-	name, pending, err := pickRecordingToCleanup(recordingsDir, cloudDir)
-	if err != nil {
-		t.Fatalf("unexpected error: %v", err)
-	}
-	if !pending {
-		t.Fatalf("expected pending=true when every recording is queued for upload")
-	}
-	if name != "a_old.mp4" {
-		t.Fatalf("cleanup picked %q, want the oldest pending a_old.mp4", name)
-	}
-}
-
-// An empty recordings directory yields os.ErrNotExist so the caller does nothing.
-func TestPickRecordingToCleanup_Empty(t *testing.T) {
-	recordingsDir, cloudDir := newCleanupDirs(t)
-
-	if _, _, err := pickRecordingToCleanup(recordingsDir, cloudDir); err != os.ErrNotExist {
-		t.Fatalf("expected os.ErrNotExist for an empty directory, got %v", err)
-	}
-}
-
-// writeSizedRecording writes a recording of an exact byte size so tests can
-// exercise the megabyte-based directory-cap threshold.
-func writeSizedRecording(t *testing.T, dir, name string, size int) {
-	t.Helper()
-	if err := os.WriteFile(filepath.Join(dir, name), make([]byte, size), 0o644); err != nil {
-		t.Fatalf("write sized recording %s: %v", name, err)
-	}
-}
-
-// When AGENT_AUTO_CLEAN_MAX_SIZE (MaxDirectorySize) is set, cleanup triggers once
-// the recordings directory grows past that many megabytes.
-func TestRecordingsNeedCleanup_FixedCap(t *testing.T) {
-	recordingsDir, _ := newCleanupDirs(t)
-	// ~2 MB of recordings on disk.
-	writeSizedRecording(t, recordingsDir, "big.mp4", 2*1000*1000)
-
-	over := &models.Configuration{Config: models.Config{MaxDirectorySize: 1}}
-	need, err := recordingsNeedCleanup(recordingsDir, over)
-	if err != nil {
-		t.Fatalf("unexpected error: %v", err)
-	}
-	if !need {
-		t.Fatalf("expected cleanup when 2MB of recordings exceed the 1MB cap")
-	}
-
-	under := &models.Configuration{Config: models.Config{MaxDirectorySize: 100}}
-	need, err = recordingsNeedCleanup(recordingsDir, under)
-	if err != nil {
-		t.Fatalf("unexpected error: %v", err)
-	}
-	if need {
-		t.Fatalf("expected no cleanup when 2MB of recordings stay under the 100MB cap")
-	}
-}
-
-// With no fixed cap (the default), cleanup is driven by the free space left on
-// the recordings filesystem versus the reserve.
-func TestRecordingsNeedCleanup_DefaultDiskReserve(t *testing.T) {
-	if runtime.GOOS != "linux" {
-		t.Skip("disk usage stats are only implemented on linux")
-	}
-	recordingsDir, _ := newCleanupDirs(t)
-
-	totalMB, availableMB, err := diskUsageMB(recordingsDir)
-	if err != nil {
-		t.Fatalf("diskUsageMB: %v", err)
-	}
-	if totalMB <= 0 || availableMB <= 0 {
-		t.Skipf("unexpected disk stats total=%dMB available=%dMB", totalMB, availableMB)
-	}
-
-	// A reserve larger than the whole disk means free space is always below it.
-	over := &models.Configuration{Config: models.Config{MinFreeSpace: totalMB + availableMB}}
-	need, err := recordingsNeedCleanup(recordingsDir, over)
-	if err != nil {
-		t.Fatalf("unexpected error: %v", err)
-	}
-	if !need {
-		t.Fatalf("expected cleanup when free space (%dMB) is below the reserve", availableMB)
-	}
-
-	// A 1 MB reserve leaves plenty of free space, so nothing should be cleaned.
-	under := &models.Configuration{Config: models.Config{MinFreeSpace: 1}}
-	need, err = recordingsNeedCleanup(recordingsDir, under)
-	if err != nil {
-		t.Fatalf("unexpected error: %v", err)
-	}
-	if need {
-		t.Fatalf("expected no cleanup when free space (%dMB) exceeds the 1MB reserve", availableMB)
-	}
-}
-
-// The default 5% reserve must never truncate to 0MB on small disks, otherwise
-// cleanup would only trigger once the disk is completely full.
-func TestDefaultReserveMB(t *testing.T) {
-	cases := []struct {
-		totalMB int64
-		want    int64
-	}{
-		{totalMB: 0, want: 1},   // no/unknown disk size still reserves 1MB
-		{totalMB: 10, want: 1},  // 5% = 0MB -> floored to 1MB
-		{totalMB: 19, want: 1},  // 5% = 0MB -> floored to 1MB
-		{totalMB: 20, want: 1},  // 5% = exactly 1MB
-		{totalMB: 100, want: 5}, // 5% = 5MB
-		{totalMB: 1000, want: 50},
-	}
-	for _, c := range cases {
-		if got := defaultReserveMB(c.totalMB); got != c.want {
-			t.Errorf("defaultReserveMB(%d) = %d, want %d", c.totalMB, got, c.want)
-		}
-	}
-}

machinery/src/capture/disk_linux.go

@@ -1,23 +0,0 @@
-//go:build linux
-
-package capture
-
-import "syscall"
-
-// diskUsageMB returns the total capacity and the currently available space (both
-// in megabytes, decimal) of the filesystem that contains path. Auto-clean uses
-// it to default its cleanup threshold to the real disk capacity instead of a
-// fixed size, so recordings can grow to fill the disk while keeping a reserve
-// free. Linux is the agent's deployment target (amd64/arm64 containers).
-func diskUsageMB(path string) (totalMB int64, availableMB int64, err error) {
-	var stat syscall.Statfs_t
-	if err = syscall.Statfs(path, &stat); err != nil {
-		return 0, 0, err
-	}
-	blockSize := int64(stat.Bsize)
-	totalMB = int64(stat.Blocks) * blockSize / 1000 / 1000
-	// Bavail is the free space available to unprivileged users, which is the
-	// space we can actually keep writing recordings into.
-	availableMB = int64(stat.Bavail) * blockSize / 1000 / 1000
-	return totalMB, availableMB, nil
-}

machinery/src/capture/disk_other.go

@@ -1,13 +0,0 @@
-//go:build !linux
-
-package capture
-
-import "errors"
-
-// diskUsageMB is only implemented on Linux (the agent's deployment target). On
-// other platforms (e.g. local macOS/Windows dev builds) auto-clean falls back to
-// its historical fixed-size directory cap, so this reports the capability as
-// unavailable.
-func diskUsageMB(path string) (totalMB int64, availableMB int64, err error) {
-	return 0, 0, errors.New("disk usage stats are not supported on this platform")
-}

machinery/src/capture/gortsplib_test.go

@@ -1,104 +0,0 @@
-package capture
-
-import (
-	"bytes"
-	"context"
-	"encoding/pem"
-	"errors"
-	"net/http/httptest"
-	"os"
-	"path/filepath"
-	"strings"
-	"testing"
-)
-
-func TestGolibrtspCloseBeforeClientStart(t *testing.T) {
-	client := &Golibrtsp{}
-
-	if err := client.Close(context.Background()); err != nil {
-		t.Fatalf("Close() error = %v", err)
-	}
-}
-
-func TestSanitizeRTSPErrorRemovesCredentialsAndQuery(t *testing.T) {
-	rawURL := "rtsp://camera-user:camera-password@10.0.20.15/live?access_token=secret"
-	got := sanitizeRTSPError(errors.New("describe "+rawURL+": bad status code"), rawURL)
-
-	for _, secret := range []string{"camera-user", "camera-password", "access_token", "secret"} {
-		if strings.Contains(got.Error(), secret) {
-			t.Fatalf("sanitizeRTSPError() exposed %q in %q", secret, got)
-		}
-	}
-	if !strings.Contains(got.Error(), "rtsp://10.0.20.15/live") {
-		t.Fatalf("sanitizeRTSPError() removed useful host/path context: %q", got)
-	}
-}
-
-func TestRTSPSTLSConfig(t *testing.T) {
-	t.Run("verifies certificates by default", func(t *testing.T) {
-		t.Setenv(rtspsCAFileEnv, "")
-		t.Setenv(rtspsInsecureEnv, "")
-
-		got, err := rtspsTLSConfig()
-		if err != nil {
-			t.Fatalf("rtspsTLSConfig() error = %v", err)
-		}
-		if got != nil {
-			t.Fatalf("rtspsTLSConfig() = %#v, want nil", got)
-		}
-	})
-
-	t.Run("allows explicit insecure mode", func(t *testing.T) {
-		t.Setenv(rtspsCAFileEnv, "/missing/ignored-in-insecure-mode.pem")
-		t.Setenv(rtspsInsecureEnv, "true")
-
-		got, err := rtspsTLSConfig()
-		if err != nil {
-			t.Fatalf("rtspsTLSConfig() error = %v", err)
-		}
-		if got == nil || !got.InsecureSkipVerify {
-			t.Fatalf("rtspsTLSConfig() = %#v, want InsecureSkipVerify enabled", got)
-		}
-	})
-
-	t.Run("adds a camera CA to system roots", func(t *testing.T) {
-		t.Setenv(rtspsInsecureEnv, "")
-		server := httptest.NewTLSServer(nil)
-		defer server.Close()
-
-		certificate := server.Certificate()
-		caFile := filepath.Join(t.TempDir(), "camera-ca.pem")
-		caPEM := pem.EncodeToMemory(&pem.Block{Type: "CERTIFICATE", Bytes: certificate.Raw})
-		if err := os.WriteFile(caFile, caPEM, 0o600); err != nil {
-			t.Fatal(err)
-		}
-		t.Setenv(rtspsCAFileEnv, caFile)
-
-		got, err := rtspsTLSConfig()
-		if err != nil {
-			t.Fatalf("rtspsTLSConfig() error = %v", err)
-		}
-		if got == nil || got.RootCAs == nil {
-			t.Fatalf("rtspsTLSConfig() = %#v, want custom RootCAs", got)
-		}
-		for _, subject := range got.RootCAs.Subjects() {
-			if bytes.Equal(subject, certificate.RawSubject) {
-				return
-			}
-		}
-		t.Fatal("camera CA was not added to RootCAs")
-	})
-
-	t.Run("rejects an invalid camera CA file", func(t *testing.T) {
-		t.Setenv(rtspsInsecureEnv, "")
-		caFile := filepath.Join(t.TempDir(), "camera-ca.pem")
-		if err := os.WriteFile(caFile, []byte("not a certificate"), 0o600); err != nil {
-			t.Fatal(err)
-		}
-		t.Setenv(rtspsCAFileEnv, caFile)
-
-		if _, err := rtspsTLSConfig(); err == nil {
-			t.Fatal("rtspsTLSConfig() error = nil, want invalid CA error")
-		}
-	})
-}

machinery/src/capture/main_test.go

@@ -1,88 +0,0 @@
-package capture
-
-import (
-	"encoding/json"
-	"math"
-	"os"
-	"path/filepath"
-	"testing"
-	"time"
-
-	"github.com/kerberos-io/agent/machinery/src/models"
-	"github.com/kerberos-io/agent/machinery/src/video"
-)
-
-func TestPTSToDuration(t *testing.T) {
-	tests := []struct {
-		name      string
-		pts       int64
-		clockRate int
-		want      time.Duration
-	}{
-		{name: "one video second", pts: 90_000, clockRate: 90_000, want: time.Second},
-		{name: "one audio frame", pts: 1_024, clockRate: 8_000, want: 128 * time.Millisecond},
-		{name: "fractional millisecond", pts: 45_045, clockRate: 90_000, want: 500*time.Millisecond + 500*time.Microsecond},
-		{name: "negative timestamp", pts: -45_045, clockRate: 90_000, want: -500*time.Millisecond - 500*time.Microsecond},
-		{name: "large timestamp", pts: 90_000 * 60 * 60 * 24, clockRate: 90_000, want: 24 * time.Hour},
-	}
-
-	for _, test := range tests {
-		t.Run(test.name, func(t *testing.T) {
-			if got := ptsToDuration(test.pts, test.clockRate); got != test.want {
-				t.Fatalf("ptsToDuration(%d, %d) = %s, want %s", test.pts, test.clockRate, got, test.want)
-			}
-		})
-	}
-}
-
-func TestQueueRecordingForUploadStoresFinalizedMetadata(t *testing.T) {
-	configDirectory := t.TempDir()
-	if err := os.MkdirAll(filepath.Join(configDirectory, "data", "cloud"), 0o755); err != nil {
-		t.Fatalf("mkdir cloud queue: %v", err)
-	}
-
-	mp4Video := &video.MP4{VideoTotalDuration: 20452, SampleCount: 613}
-	metadata := recordingUploadMetadata("recording.mp4", "device-key", 1785934709414, mp4Video)
-	queueRecordingForUpload(configDirectory, metadata)
-
-	got, err := os.ReadFile(filepath.Join(configDirectory, "data", "cloud", "recording.metadata"))
-	if err != nil {
-		t.Fatalf("read upload marker: %v", err)
-	}
-	var stored models.RecordingUploadMetadata
-	if err := json.Unmarshal(got, &stored); err != nil {
-		t.Fatalf("decode upload marker: %v", err)
-	}
-	expectedFPS := mp4Video.AverageFPS()
-	if stored.FileName != "recording.mp4" || stored.DeviceKey != "device-key" || stored.Timestamp != 1785934709414 || stored.Duration != 20452 || math.Abs(stored.FPS-expectedFPS) > 1e-9 {
-		t.Fatalf("upload marker = %+v", stored)
-	}
-	if stored.FPS == math.Floor(stored.FPS) {
-		t.Fatalf("upload marker FPS = %v, want fractional precision", stored.FPS)
-	}
-}
-
-func TestQueueRecordingForUploadKeepsUnknownFPSCompatible(t *testing.T) {
-	for _, fps := range []float64{0, 0.99, -1, math.NaN(), math.Inf(1), 241} {
-		t.Run("invalid FPS", func(t *testing.T) {
-			configDirectory := t.TempDir()
-			if err := os.MkdirAll(filepath.Join(configDirectory, "data", "cloud"), 0o755); err != nil {
-				t.Fatalf("mkdir cloud queue: %v", err)
-			}
-
-			metadata := models.RecordingUploadMetadata{FileName: "recording.mp4"}
-			if fps >= 1 && fps <= 240 && !math.IsNaN(fps) && !math.IsInf(fps, 0) {
-				metadata.FPS = fps
-			}
-			queueRecordingForUpload(configDirectory, metadata)
-
-			got, err := os.ReadFile(filepath.Join(configDirectory, "data", "cloud", "recording.metadata"))
-			if err != nil {
-				t.Fatalf("read upload marker: %v", err)
-			}
-			if string(got) != `{"filename":"recording.mp4","device_key":"","timestamp":0,"duration":0}` {
-				t.Fatalf("upload marker = %q, want metadata without FPS", got)
-			}
-		})
-	}
-}

machinery/src/capture/rtsp_client.go

@@ -1,109 +0,0 @@
-package capture
-
-import (
-	"context"
-	"image"
-	"sync"
-
-	"github.com/kerberos-io/agent/machinery/src/models"
-	"github.com/kerberos-io/agent/machinery/src/packets"
-)
-
-type Capture struct {
-	clientsMu             sync.RWMutex
-	rtspClient            *Golibrtsp
-	rtspSubClient         *Golibrtsp
-	rtspBackChannelClient *Golibrtsp
-}
-
-func (c *Capture) SetMainClient(rtspUrl string) *Golibrtsp {
-	client := &Golibrtsp{
-		Url: rtspUrl,
-	}
-	c.clientsMu.Lock()
-	c.rtspClient = client
-	c.clientsMu.Unlock()
-	return client
-}
-
-func (c *Capture) SetSubClient(rtspUrl string) *Golibrtsp {
-	client := &Golibrtsp{
-		Url: rtspUrl,
-	}
-	c.clientsMu.Lock()
-	c.rtspSubClient = client
-	c.clientsMu.Unlock()
-	return client
-}
-
-func (c *Capture) SetBackChannelClient(rtspUrl string) *Golibrtsp {
-	client := &Golibrtsp{
-		Url: rtspUrl,
-	}
-	c.clientsMu.Lock()
-	c.rtspBackChannelClient = client
-	c.clientsMu.Unlock()
-	return client
-}
-
-func (c *Capture) MainClient() *Golibrtsp {
-	c.clientsMu.RLock()
-	defer c.clientsMu.RUnlock()
-	return c.rtspClient
-}
-
-func (c *Capture) SubClient() *Golibrtsp {
-	c.clientsMu.RLock()
-	defer c.clientsMu.RUnlock()
-	return c.rtspSubClient
-}
-
-func (c *Capture) ClearClients(main, sub, backchannel *Golibrtsp) {
-	c.clientsMu.Lock()
-	defer c.clientsMu.Unlock()
-	if c.rtspClient == main {
-		c.rtspClient = nil
-	}
-	if c.rtspSubClient == sub {
-		c.rtspSubClient = nil
-	}
-	if c.rtspBackChannelClient == backchannel {
-		c.rtspBackChannelClient = nil
-	}
-}
-
-// RTSPClient is a interface that abstracts the RTSP client implementation.
-type RTSPClient interface {
-	// Connect to the RTSP server.
-	Connect(ctx context.Context, otelContext context.Context) error
-
-	// Connect to a backchannel RTSP server.
-	ConnectBackChannel(ctx context.Context, otelContext context.Context) error
-
-	// Start the RTSP client, and start reading packets.
-	Start(ctx context.Context, streamType string, queue *packets.Queue, configuration *models.Configuration, communication *models.Communication) error
-
-	// Start the RTSP client, and start reading packets.
-	StartBackChannel(ctx context.Context, otelContext context.Context) error
-
-	// Decode a packet into a image.
-	DecodePacket(pkt packets.Packet) (image.YCbCr, error)
-
-	// Decode a packet into a image.
-	DecodePacketRaw(pkt packets.Packet) (image.Gray, error)
-
-	// Write a packet to the RTSP server.
-	WritePacket(pkt packets.Packet) error
-
-	// Close the connection to the RTSP server.
-	Close(ctx context.Context) error
-
-	// Get a list of streams from the RTSP server.
-	GetStreams() ([]packets.Stream, error)
-
-	// Get a list of video streams from the RTSP server.
-	GetVideoStreams() ([]packets.Stream, error)
-
-	// Get a list of audio streams from the RTSP server.
-	GetAudioStreams() ([]packets.Stream, error)
-}

machinery/src/capture/rtsp_client_test.go

@@ -1,62 +0,0 @@
-package capture
-
-import (
-	"strconv"
-	"sync"
-	"testing"
-)
-
-func TestCaptureClientAccessCanRaceReplacement(t *testing.T) {
-	captureDevice := &Capture{}
-	captureDevice.SetMainClient("rtsp://main/0")
-	captureDevice.SetSubClient("rtsp://sub/0")
-
-	var workers sync.WaitGroup
-	workers.Add(2)
-	go func() {
-		defer workers.Done()
-		for replacement := 1; replacement <= 1000; replacement++ {
-			suffix := strconv.Itoa(replacement)
-			captureDevice.SetMainClient("rtsp://main/" + suffix)
-			captureDevice.SetSubClient("rtsp://sub/" + suffix)
-		}
-	}()
-	go func() {
-		defer workers.Done()
-		for snapshot := 0; snapshot < 1000; snapshot++ {
-			if captureDevice.MainClient() == nil {
-				t.Error("MainClient() returned nil")
-				return
-			}
-			if captureDevice.SubClient() == nil {
-				t.Error("SubClient() returned nil")
-				return
-			}
-		}
-	}()
-	workers.Wait()
-}
-
-func TestCaptureClearClientsOnlyClearsMatchingRun(t *testing.T) {
-	captureDevice := &Capture{}
-	oldMain := captureDevice.SetMainClient("rtsp://main/old")
-	oldSub := captureDevice.SetSubClient("rtsp://sub/old")
-	oldBackchannel := captureDevice.SetBackChannelClient("rtsp://back/old")
-
-	newMain := captureDevice.SetMainClient("rtsp://main/new")
-	newSub := captureDevice.SetSubClient("rtsp://sub/new")
-	newBackchannel := captureDevice.SetBackChannelClient("rtsp://back/new")
-
-	captureDevice.ClearClients(oldMain, oldSub, oldBackchannel)
-	if captureDevice.MainClient() != newMain {
-		t.Fatal("stale cleanup cleared the new main client")
-	}
-	if captureDevice.SubClient() != newSub {
-		t.Fatal("stale cleanup cleared the new sub client")
-	}
-
-	captureDevice.ClearClients(newMain, newSub, newBackchannel)
-	if captureDevice.MainClient() != nil || captureDevice.SubClient() != nil {
-		t.Fatal("matching cleanup did not clear current clients")
-	}
-}

machinery/src/cloud/Cloud.go

@@ -0,0 +1,859 @@
+package cloud
+
+import (
+	"bytes"
+	"crypto/tls"
+	"encoding/base64"
+	"encoding/json"
+	"fmt"
+	"io/ioutil"
+	"os"
+	"strings"
+	"sync"
+
+	"github.com/elastic/go-sysinfo"
+	"github.com/gin-gonic/gin"
+	"github.com/golang-module/carbon/v2"
+	"github.com/kerberos-io/joy4/av/pubsub"
+
+	mqtt "github.com/eclipse/paho.mqtt.golang"
+	av "github.com/kerberos-io/joy4/av"
+	"github.com/kerberos-io/joy4/cgo/ffmpeg"
+
+	"net/http"
+	"strconv"
+	"time"
+
+	"github.com/kerberos-io/agent/machinery/src/computervision"
+	"github.com/kerberos-io/agent/machinery/src/log"
+	"github.com/kerberos-io/agent/machinery/src/models"
+	"github.com/kerberos-io/agent/machinery/src/onvif"
+	"github.com/kerberos-io/agent/machinery/src/utils"
+	"github.com/kerberos-io/agent/machinery/src/webrtc"
+)
+
+func PendingUpload(configDirectory string) {
+	ff, err := utils.ReadDirectory(configDirectory + "/data/cloud/")
+	if err == nil {
+		for _, f := range ff {
+			log.Log.Info(f.Name())
+		}
+	}
+}
+
+func HandleUpload(configDirectory string, configuration *models.Configuration, communication *models.Communication) {
+
+	log.Log.Debug("HandleUpload: started")
+
+	config := configuration.Config
+	watchDirectory := configDirectory + "/data/cloud/"
+
+	if config.Offline == "true" {
+		log.Log.Debug("HandleUpload: stopping as Offline is enabled.")
+	} else {
+
+		// Half a second delay between two uploads
+		delay := 500 * time.Millisecond
+
+	loop:
+		for {
+			// This will check if we need to stop the thread,
+			// because of a reconfiguration.
+			select {
+			case <-communication.HandleUpload:
+				break loop
+			case <-time.After(2 * time.Second):
+			}
+
+			ff, err := utils.ReadDirectory(watchDirectory)
+			if err != nil {
+				log.Log.Error("HandleUpload: " + err.Error())
+			} else {
+				for _, f := range ff {
+
+					// This will check if we need to stop the thread,
+					// because of a reconfiguration.
+					select {
+					case <-communication.HandleUpload:
+						break loop
+					default:
+					}
+
+					fileName := f.Name()
+					uploaded := false
+					configured := false
+					err = nil
+					if config.Cloud == "s3" || config.Cloud == "kerberoshub" {
+						uploaded, configured, err = UploadKerberosHub(configuration, fileName)
+					} else if config.Cloud == "kstorage" || config.Cloud == "kerberosvault" {
+						uploaded, configured, err = UploadKerberosVault(configuration, fileName)
+					} else if config.Cloud == "dropbox" {
+						uploaded, configured, err = UploadDropbox(configuration, fileName)
+					} else if config.Cloud == "gdrive" {
+						// Todo: implement gdrive upload
+					} else if config.Cloud == "onedrive" {
+						// Todo: implement onedrive upload
+					} else if config.Cloud == "minio" {
+						// Todo: implement minio upload
+					} else if config.Cloud == "webdav" {
+						// Todo: implement webdav upload
+					} else if config.Cloud == "ftp" {
+						// Todo: implement ftp upload
+					} else if config.Cloud == "sftp" {
+						// Todo: implement sftp upload
+					} else if config.Cloud == "aws" {
+						// Todo: need to be updated, was previously used for hub.
+						uploaded, configured, err = UploadS3(configuration, fileName)
+					} else if config.Cloud == "azure" {
+						// Todo: implement azure upload
+					} else if config.Cloud == "google" {
+						// Todo: implement google upload
+					}
+					// And so on... (have a look here -> https://github.com/kerberos-io/agent/issues/95)
+
+					// Check if the file is uploaded, if so, remove it.
+					if uploaded {
+						delay = 500 * time.Millisecond // reset
+						err := os.Remove(watchDirectory + fileName)
+						if err != nil {
+							log.Log.Error("HandleUpload: " + err.Error())
+						}
+
+						// Check if we need to remove the original recording
+						// removeAfterUpload is set to false by default
+						if config.RemoveAfterUpload != "false" {
+							err := os.Remove(configDirectory + "/data/recordings/" + fileName)
+							if err != nil {
+								log.Log.Error("HandleUpload: " + err.Error())
+							}
+						}
+					} else if !configured {
+						err := os.Remove(watchDirectory + fileName)
+						if err != nil {
+							log.Log.Error("HandleUpload: " + err.Error())
+						}
+					} else {
+						delay = 20 * time.Second // slow down
+						if err != nil {
+							log.Log.Error("HandleUpload: " + err.Error())
+						}
+					}
+
+					time.Sleep(delay)
+				}
+			}
+		}
+	}
+
+	log.Log.Debug("HandleUpload: finished")
+}
+
+func GetSystemInfo() (models.System, error) {
+	var usedMem uint64 = 0
+	var totalMem uint64 = 0
+	var freeMem uint64 = 0
+
+	var processUsedMem uint64 = 0
+
+	architecture := ""
+	cpuId := ""
+	KernelVersion := ""
+	agentVersion := ""
+	var MACs []string
+	var IPs []string
+	hostname := ""
+	bootTime := time.Time{}
+
+	// Read agent version
+	version, err := os.Open("./version")
+	defer version.Close()
+	agentVersion = "unknown"
+	if err == nil {
+		agentVersionBytes, err := ioutil.ReadAll(version)
+		agentVersion = string(agentVersionBytes)
+		if err != nil {
+			log.Log.Error(err.Error())
+		}
+	}
+
+	host, err := sysinfo.Host()
+	if err == nil {
+		cpuId = host.Info().UniqueID
+		architecture = host.Info().Architecture
+		KernelVersion = host.Info().KernelVersion
+		MACs = host.Info().MACs
+		IPs = host.Info().IPs
+		hostname = host.Info().Hostname
+		bootTime = host.Info().BootTime
+		memory, err := host.Memory()
+		if err == nil {
+			usedMem = memory.Used
+			totalMem = memory.Total
+			freeMem = memory.Free
+		}
+	}
+
+	process, err := sysinfo.Self()
+	if err == nil {
+		memInfo, err := process.Memory()
+		if err == nil {
+			processUsedMem = memInfo.Resident
+		}
+	}
+
+	system := models.System{
+		Hostname:          hostname,
+		CPUId:             cpuId,
+		KernelVersion:     KernelVersion,
+		Version:           agentVersion,
+		MACs:              MACs,
+		IPs:               IPs,
+		BootTime:          uint64(bootTime.Unix()),
+		Architecture:      architecture,
+		UsedMemory:        usedMem,
+		TotalMemory:       totalMem,
+		FreeMemory:        freeMem,
+		ProcessUsedMemory: processUsedMem,
+	}
+
+	return system, nil
+}
+
+func HandleHeartBeat(configuration *models.Configuration, communication *models.Communication, uptimeStart time.Time) {
+	log.Log.Debug("HandleHeartBeat: started")
+
+loop:
+	for {
+
+		config := configuration.Config
+
+		if config.Offline == "true" {
+			log.Log.Debug("HandleHeartBeat: stopping as Offline is enabled.")
+		} else {
+
+			url := config.HeartbeatURI
+			key := ""
+			username := ""
+			vaultURI := ""
+
+			username = config.S3.Username
+			if config.Cloud == "s3" && config.S3 != nil && config.S3.Publickey != "" {
+				username = config.S3.Username
+				key = config.S3.Publickey
+			} else if config.Cloud == "kstorage" && config.KStorage != nil && config.KStorage.CloudKey != "" {
+				key = config.KStorage.CloudKey
+				username = config.KStorage.Directory
+			}
+
+			// This is the new way ;)
+			if config.HubURI != "" {
+				url = config.HubURI + "/devices/heartbeat"
+			}
+			if config.HubKey != "" {
+				key = config.HubKey
+			}
+
+			if key != "" {
+				// Check if we have a friendly name or not.
+				name := config.Name
+				if config.FriendlyName != "" {
+					name = config.FriendlyName
+				}
+
+				// Get some system information
+				// like the uptime, hostname, memory usage, etc.
+				system, _ := GetSystemInfo()
+
+				// We will formated the uptime to a human readable format
+				// this will be used on Kerberos Hub: Uptime -> 1 day and 2 hours.
+				uptimeFormatted := uptimeStart.Format("2006-01-02 15:04:05")
+				uptimeString := carbon.Parse(uptimeFormatted).DiffForHumans()
+				uptimeString = strings.ReplaceAll(uptimeString, "ago", "")
+
+				// Do the same for boottime
+				bootTimeFormatted := time.Unix(int64(system.BootTime), 0).Format("2006-01-02 15:04:05")
+				boottimeString := carbon.Parse(bootTimeFormatted).DiffForHumans()
+				boottimeString = strings.ReplaceAll(boottimeString, "ago", "")
+
+				// We'll check which mode is enabled for the camera.
+				onvifEnabled := "false"
+				onvifZoom := "false"
+				onvifPanTilt := "false"
+				onvifPresets := "false"
+				var onvifPresetsList []byte
+				if config.Capture.IPCamera.ONVIFXAddr != "" {
+					cameraConfiguration := configuration.Config.Capture.IPCamera
+					device, err := onvif.ConnectToOnvifDevice(&cameraConfiguration)
+					if err == nil {
+						configurations, err := onvif.GetPTZConfigurationsFromDevice(device)
+						if err == nil {
+							onvifEnabled = "true"
+							_, canZoom, canPanTilt := onvif.GetPTZFunctionsFromDevice(configurations)
+							if canZoom {
+								onvifZoom = "true"
+							}
+							if canPanTilt {
+								onvifPanTilt = "true"
+							}
+							// Try to read out presets
+							presets, err := onvif.GetPresetsFromDevice(device)
+							if err == nil && len(presets) > 0 {
+								onvifPresets = "true"
+								onvifPresetsList, err = json.Marshal(presets)
+								if err != nil {
+									log.Log.Error("HandleHeartBeat: error while marshalling presets: " + err.Error())
+									onvifPresetsList = []byte("[]")
+								}
+							} else {
+								if err != nil {
+									log.Log.Error("HandleHeartBeat: error while getting presets: " + err.Error())
+								} else {
+									log.Log.Debug("HandleHeartBeat: no presets found.")
+								}
+								onvifPresetsList = []byte("[]")
+							}
+						} else {
+							log.Log.Error("HandleHeartBeat: error while getting PTZ configurations: " + err.Error())
+							onvifPresetsList = []byte("[]")
+						}
+					} else {
+						log.Log.Error("HandleHeartBeat: error while connecting to ONVIF device: " + err.Error())
+						onvifPresetsList = []byte("[]")
+					}
+				} else {
+					log.Log.Debug("HandleHeartBeat: ONVIF is not enabled.")
+					onvifPresetsList = []byte("[]")
+				}
+
+				// Check if the agent is running inside a cluster (Kerberos Factory) or as
+				// an open source agent
+				isEnterprise := false
+				if os.Getenv("DEPLOYMENT") == "factory" || os.Getenv("MACHINERY_ENVIRONMENT") == "kubernetes" {
+					isEnterprise = true
+				}
+
+				// Congert to string
+				macs, _ := json.Marshal(system.MACs)
+				ips, _ := json.Marshal(system.IPs)
+				cameraConnected := "true"
+				if communication.CameraConnected == false {
+					cameraConnected = "false"
+				}
+
+				var object = fmt.Sprintf(`{
+						"key" : "%s",
+						"version" : "3.0.0",
+						"release" : "%s",
+						"cpuid" : "%s",
+						"clouduser" : "%s",
+						"cloudpublickey" : "%s",
+						"cameraname" : "%s",
+						"enterprise" : %t,
+						"hostname" : "%s",
+						"architecture" : "%s",
+						"totalMemory" : "%d",
+						"usedMemory" : "%d",
+						"freeMemory" : "%d",
+						"processMemory" : "%d",
+						"mac_list" : %s,
+						"ip_list" : %s,
+						"board" : "",
+						"disk1size" : "%s",
+						"disk3size" : "%s",
+						"diskvdasize" :  "%s",
+						"uptime" : "%s",
+						"boot_time" : "%s",
+						"siteID" : "%s",
+						"onvif" : "%s",
+						"onvif_zoom" : "%s",
+						"onvif_pantilt" : "%s",
+						"onvif_presets": "%s",
+						"onvif_presets_list": %s,
+						"cameraConnected": "%s",
+						"numberoffiles" : "33",
+						"timestamp" : 1564747908,
+						"cameratype" : "IPCamera",
+						"docker" : true,
+						"kios" : false,
+						"raspberrypi" : false
+					}`, config.Key, system.Version, system.CPUId, username, key, name, isEnterprise, system.Hostname, system.Architecture, system.TotalMemory, system.UsedMemory, system.FreeMemory, system.ProcessUsedMemory, macs, ips, "0", "0", "0", uptimeString, boottimeString, config.HubSite, onvifEnabled, onvifZoom, onvifPanTilt, onvifPresets, onvifPresetsList, cameraConnected)
+
+				var jsonStr = []byte(object)
+				buffy := bytes.NewBuffer(jsonStr)
+				req, _ := http.NewRequest("POST", url, buffy)
+				req.Header.Set("Content-Type", "application/json")
+
+				var client *http.Client
+				if os.Getenv("AGENT_TLS_INSECURE") == "true" {
+					tr := &http.Transport{
+						TLSClientConfig: &tls.Config{InsecureSkipVerify: true},
+					}
+					client = &http.Client{Transport: tr}
+				} else {
+					client = &http.Client{}
+				}
+
+				resp, err := client.Do(req)
+				if resp != nil {
+					resp.Body.Close()
+				}
+				if err == nil && resp.StatusCode == 200 {
+					communication.CloudTimestamp.Store(time.Now().Unix())
+					log.Log.Info("HandleHeartBeat: (200) Heartbeat received by Kerberos Hub.")
+				} else {
+					if communication.CloudTimestamp != nil && communication.CloudTimestamp.Load() != nil {
+						communication.CloudTimestamp.Store(int64(0))
+					}
+					log.Log.Error("HandleHeartBeat: (400) Something went wrong while sending to Kerberos Hub.")
+				}
+
+				// If we have a Kerberos Vault connected, we will also send some analytics
+				// to that service.
+				vaultURI = config.KStorage.URI
+				if vaultURI != "" {
+					buffy = bytes.NewBuffer(jsonStr)
+					req, _ = http.NewRequest("POST", vaultURI+"/devices/heartbeat", buffy)
+					req.Header.Set("Content-Type", "application/json")
+					resp, err = client.Do(req)
+					if resp != nil {
+						resp.Body.Close()
+					}
+					if err == nil && resp.StatusCode == 200 {
+						log.Log.Info("HandleHeartBeat: (200) Heartbeat received by Kerberos Vault.")
+					} else {
+						log.Log.Error("HandleHeartBeat: (400) Something went wrong while sending to Kerberos Vault.")
+					}
+				}
+			} else {
+				log.Log.Error("HandleHeartBeat: Disabled as we do not have a public key defined.")
+			}
+		}
+
+		// This will check if we need to stop the thread,
+		// because of a reconfiguration.
+		select {
+		case <-communication.HandleHeartBeat:
+			break loop
+		case <-time.After(15 * time.Second):
+		}
+	}
+
+	log.Log.Debug("HandleHeartBeat: finished")
+}
+
+func HandleLiveStreamSD(livestreamCursor *pubsub.QueueCursor, configuration *models.Configuration, communication *models.Communication, mqttClient mqtt.Client, decoder *ffmpeg.VideoDecoder, decoderMutex *sync.Mutex) {
+
+	log.Log.Debug("HandleLiveStreamSD: started")
+
+	config := configuration.Config
+
+	// If offline made is enabled, we will stop the thread.
+	if config.Offline == "true" {
+		log.Log.Debug("HandleLiveStreamSD: stopping as Offline is enabled.")
+	} else {
+
+		// Check if we need to enable the live stream
+		if config.Capture.Liveview != "false" {
+
+			// Allocate frame
+			frame := ffmpeg.AllocVideoFrame()
+
+			key := ""
+			if config.Cloud == "s3" && config.S3 != nil && config.S3.Publickey != "" {
+				key = config.S3.Publickey
+			} else if config.Cloud == "kstorage" && config.KStorage != nil && config.KStorage.CloudKey != "" {
+				key = config.KStorage.CloudKey
+			}
+			// This is the new way ;)
+			if config.HubKey != "" {
+				key = config.HubKey
+			}
+
+			topic := "kerberos/" + key + "/device/" + config.Key + "/live"
+
+			lastLivestreamRequest := int64(0)
+
+			var cursorError error
+			var pkt av.Packet
+
+			for cursorError == nil {
+				pkt, cursorError = livestreamCursor.ReadPacket()
+				if len(pkt.Data) == 0 || !pkt.IsKeyFrame {
+					continue
+				}
+				now := time.Now().Unix()
+				select {
+				case <-communication.HandleLiveSD:
+					lastLivestreamRequest = now
+				default:
+				}
+				if now-lastLivestreamRequest > 3 {
+					continue
+				}
+				log.Log.Info("HandleLiveStreamSD: Sending base64 encoded images to MQTT.")
+				sendImage(frame, topic, mqttClient, pkt, decoder, decoderMutex)
+			}
+
+			// Cleanup the frame.
+			frame.Free()
+
+		} else {
+			log.Log.Debug("HandleLiveStreamSD: stopping as Liveview is disabled.")
+		}
+	}
+
+	log.Log.Debug("HandleLiveStreamSD: finished")
+}
+
+func sendImage(frame *ffmpeg.VideoFrame, topic string, mqttClient mqtt.Client, pkt av.Packet, decoder *ffmpeg.VideoDecoder, decoderMutex *sync.Mutex) {
+	_, err := computervision.GetRawImage(frame, pkt, decoder, decoderMutex)
+	if err == nil {
+		bytes, _ := computervision.ImageToBytes(&frame.Image)
+		encoded := base64.StdEncoding.EncodeToString(bytes)
+		mqttClient.Publish(topic, 0, false, encoded)
+	}
+}
+
+func HandleLiveStreamHD(livestreamCursor *pubsub.QueueCursor, configuration *models.Configuration, communication *models.Communication, mqttClient mqtt.Client, codecs []av.CodecData, decoder *ffmpeg.VideoDecoder, decoderMutex *sync.Mutex) {
+
+	config := configuration.Config
+
+	if config.Offline == "true" {
+		log.Log.Debug("HandleLiveStreamHD: stopping as Offline is enabled.")
+	} else {
+
+		// Check if we need to enable the live stream
+		if config.Capture.Liveview != "false" {
+
+			// Should create a track here.
+			videoTrack := webrtc.NewVideoTrack(codecs)
+			audioTrack := webrtc.NewAudioTrack(codecs)
+			go webrtc.WriteToTrack(livestreamCursor, configuration, communication, mqttClient, videoTrack, audioTrack, codecs, decoder, decoderMutex)
+
+			if config.Capture.ForwardWebRTC == "true" {
+				// We get a request with an offer, but we'll forward it.
+				for m := range communication.HandleLiveHDHandshake {
+					// Forward SDP
+					m.CloudKey = config.Key
+					request, err := json.Marshal(m)
+					if err == nil {
+						mqttClient.Publish("kerberos/webrtc/request", 2, false, request)
+					}
+				}
+			} else {
+				log.Log.Info("HandleLiveStreamHD: Waiting for peer connections.")
+				for handshake := range communication.HandleLiveHDHandshake {
+					log.Log.Info("HandleLiveStreamHD: setting up a peer connection.")
+					key := config.Key + "/" + handshake.Cuuid
+					webrtc.CandidatesMutex.Lock()
+					_, ok := webrtc.CandidateArrays[key]
+					if !ok {
+						webrtc.CandidateArrays[key] = make(chan string, 30)
+					}
+					webrtc.CandidatesMutex.Unlock()
+					webrtc.InitializeWebRTCConnection(configuration, communication, mqttClient, videoTrack, audioTrack, handshake, webrtc.CandidateArrays[key])
+
+				}
+			}
+
+		} else {
+			log.Log.Debug("HandleLiveStreamHD: stopping as Liveview is disabled.")
+		}
+	}
+}
+
+// VerifyHub godoc
+// @Router /api/hub/verify [post]
+// @ID verify-hub
+// @Security Bearer
+// @securityDefinitions.apikey Bearer
+// @in header
+// @name Authorization
+// @Tags config
+// @Param config body models.Config true "Config"
+// @Summary Will verify the hub connectivity.
+// @Description Will verify the hub connectivity.
+// @Success 200 {object} models.APIResponse
+func VerifyHub(c *gin.Context) {
+
+	var config models.Config
+	err := c.BindJSON(&config)
+
+	if err == nil {
+		hubURI := config.HubURI
+		publicKey := config.HubKey
+		privateKey := config.HubPrivateKey
+
+		req, err := http.NewRequest("POST", hubURI+"/subscription/verify", nil)
+		if err == nil {
+			req.Header.Set("X-Kerberos-Hub-PublicKey", publicKey)
+			req.Header.Set("X-Kerberos-Hub-PrivateKey", privateKey)
+			var client *http.Client
+			if os.Getenv("AGENT_TLS_INSECURE") == "true" {
+				tr := &http.Transport{
+					TLSClientConfig: &tls.Config{InsecureSkipVerify: true},
+				}
+				client = &http.Client{Transport: tr}
+			} else {
+				client = &http.Client{}
+			}
+
+			resp, err := client.Do(req)
+			if err == nil {
+				body, err := ioutil.ReadAll(resp.Body)
+				defer resp.Body.Close()
+				if err == nil {
+					if resp.StatusCode == 200 {
+						c.JSON(200, body)
+					} else {
+						c.JSON(400, models.APIResponse{
+							Data: "Something went wrong while reaching the Kerberos Hub API: " + string(body),
+						})
+					}
+				} else {
+					c.JSON(400, models.APIResponse{
+						Data: "Something went wrong while ready the response body: " + err.Error(),
+					})
+				}
+			} else {
+				c.JSON(400, models.APIResponse{
+					Data: "Something went wrong while reaching to the Kerberos Hub API: " + hubURI,
+				})
+			}
+		} else {
+			c.JSON(400, models.APIResponse{
+				Data: "Something went wrong while creating the HTTP request: " + err.Error(),
+			})
+		}
+	} else {
+		c.JSON(400, models.APIResponse{
+			Data: "Something went wrong while receiving the config " + err.Error(),
+		})
+	}
+}
+
+// VerifyPersistence godoc
+// @Router /api/persistence/verify [post]
+// @ID verify-persistence
+// @Security Bearer
+// @securityDefinitions.apikey Bearer
+// @in header
+// @name Authorization
+// @Tags config
+// @Param config body models.Config true "Config"
+// @Summary Will verify the persistence.
+// @Description Will verify the persistence.
+// @Success 200 {object} models.APIResponse
+func VerifyPersistence(c *gin.Context, configDirectory string) {
+
+	var config models.Config
+	err := c.BindJSON(&config)
+	if err != nil || config.Cloud != "" {
+
+		if config.Cloud == "dropbox" {
+			VerifyDropbox(config, c)
+		} else if config.Cloud == "s3" || config.Cloud == "kerberoshub" {
+
+			if config.HubURI == "" ||
+				config.HubKey == "" ||
+				config.HubPrivateKey == "" ||
+				config.S3.Region == "" {
+				msg := "VerifyPersistence: Kerberos Hub not properly configured."
+				log.Log.Info(msg)
+				c.JSON(400, models.APIResponse{
+					Data: msg,
+				})
+			} else {
+
+				// Open test-480p.mp4
+				file, err := os.Open(configDirectory + "/data/test-480p.mp4")
+				if err != nil {
+					msg := "VerifyPersistence: error reading test-480p.mp4: " + err.Error()
+					log.Log.Error(msg)
+					c.JSON(400, models.APIResponse{
+						Data: msg,
+					})
+				}
+				defer file.Close()
+
+				req, err := http.NewRequest("POST", config.HubURI+"/storage/upload", file)
+				if err != nil {
+					msg := "VerifyPersistence: error reading Kerberos Hub HEAD request, " + config.HubURI + "/storage: " + err.Error()
+					log.Log.Error(msg)
+					c.JSON(400, models.APIResponse{
+						Data: msg,
+					})
+				}
+
+				timestamp := time.Now().Unix()
+				fileName := strconv.FormatInt(timestamp, 10) +
+					"_6-967003_" + config.Name + "_200-200-400-400_24_769.mp4"
+				req.Header.Set("X-Kerberos-Storage-FileName", fileName)
+				req.Header.Set("X-Kerberos-Storage-Capture", "IPCamera")
+				req.Header.Set("X-Kerberos-Storage-Device", config.Key)
+				req.Header.Set("X-Kerberos-Hub-PublicKey", config.HubKey)
+				req.Header.Set("X-Kerberos-Hub-PrivateKey", config.HubPrivateKey)
+				req.Header.Set("X-Kerberos-Hub-Region", config.S3.Region)
+
+				var client *http.Client
+				if os.Getenv("AGENT_TLS_INSECURE") == "true" {
+					tr := &http.Transport{
+						TLSClientConfig: &tls.Config{InsecureSkipVerify: true},
+					}
+					client = &http.Client{Transport: tr}
+				} else {
+					client = &http.Client{}
+				}
+
+				resp, err := client.Do(req)
+				if resp != nil {
+					defer resp.Body.Close()
+				}
+
+				if err == nil && resp != nil {
+					if resp.StatusCode == 200 {
+						msg := "VerifyPersistence: Upload allowed using the credentials provided (" + config.HubKey + ", " + config.HubPrivateKey + ")"
+						log.Log.Info(msg)
+						c.JSON(200, models.APIResponse{
+							Data: msg,
+						})
+					} else {
+						msg := "VerifyPersistence: Upload NOT allowed using the credentials provided (" + config.HubKey + ", " + config.HubPrivateKey + ")"
+						log.Log.Info(msg)
+						c.JSON(400, models.APIResponse{
+							Data: msg,
+						})
+					}
+				} else {
+					msg := "VerifyPersistence: Error creating Kerberos Hub request"
+					log.Log.Info(msg)
+					c.JSON(400, models.APIResponse{
+						Data: msg,
+					})
+				}
+			}
+
+		} else if config.Cloud == "kstorage" || config.Cloud == "kerberosvault" {
+
+			uri := config.KStorage.URI
+			accessKey := config.KStorage.AccessKey
+			secretAccessKey := config.KStorage.SecretAccessKey
+			directory := config.KStorage.Directory
+			provider := config.KStorage.Provider
+
+			if err == nil && uri != "" && accessKey != "" && secretAccessKey != "" {
+
+				var client *http.Client
+				if os.Getenv("AGENT_TLS_INSECURE") == "true" {
+					tr := &http.Transport{
+						TLSClientConfig: &tls.Config{InsecureSkipVerify: true},
+					}
+					client = &http.Client{Transport: tr}
+				} else {
+					client = &http.Client{}
+				}
+
+				req, err := http.NewRequest("POST", uri+"/ping", nil)
+				req.Header.Add("X-Kerberos-Storage-AccessKey", accessKey)
+				req.Header.Add("X-Kerberos-Storage-SecretAccessKey", secretAccessKey)
+				resp, err := client.Do(req)
+
+				if err == nil {
+					body, err := ioutil.ReadAll(resp.Body)
+					defer resp.Body.Close()
+					if err == nil && resp.StatusCode == http.StatusOK {
+
+						if provider != "" || directory != "" {
+
+							// Generate a random name.
+							timestamp := time.Now().Unix()
+							fileName := strconv.FormatInt(timestamp, 10) +
+								"_6-967003_" + config.Name + "_200-200-400-400_24_769.mp4"
+
+							// Open test-480p.mp4
+							file, err := os.Open(configDirectory + "/test-480p.mp4")
+							if err != nil {
+								msg := "VerifyPersistence: error reading test-480p.mp4: " + err.Error()
+								log.Log.Error(msg)
+								c.JSON(400, models.APIResponse{
+									Data: msg,
+								})
+							}
+							defer file.Close()
+
+							req, err := http.NewRequest("POST", uri+"/storage", file)
+							if err == nil {
+
+								req.Header.Set("Content-Type", "video/mp4")
+								req.Header.Set("X-Kerberos-Storage-CloudKey", config.HubKey)
+								req.Header.Set("X-Kerberos-Storage-AccessKey", accessKey)
+								req.Header.Set("X-Kerberos-Storage-SecretAccessKey", secretAccessKey)
+								req.Header.Set("X-Kerberos-Storage-Provider", provider)
+								req.Header.Set("X-Kerberos-Storage-FileName", fileName)
+								req.Header.Set("X-Kerberos-Storage-Device", config.Key)
+								req.Header.Set("X-Kerberos-Storage-Capture", "IPCamera")
+								req.Header.Set("X-Kerberos-Storage-Directory", directory)
+
+								var client *http.Client
+								if os.Getenv("AGENT_TLS_INSECURE") == "true" {
+									tr := &http.Transport{
+										TLSClientConfig: &tls.Config{InsecureSkipVerify: true},
+									}
+									client = &http.Client{Transport: tr}
+								} else {
+									client = &http.Client{}
+								}
+
+								resp, err := client.Do(req)
+
+								if err == nil {
+									if resp != nil {
+										body, err := ioutil.ReadAll(resp.Body)
+										defer resp.Body.Close()
+										if err == nil {
+											if resp.StatusCode == 200 {
+												c.JSON(200, body)
+											} else {
+												c.JSON(400, models.APIResponse{
+													Data: "VerifyPersistence: Something went wrong while verifying your persistence settings. Make sure your provider is the same as the storage provider in your Kerberos Vault, and the relevant storage provider is configured properly.",
+												})
+											}
+										}
+									}
+								} else {
+									c.JSON(400, models.APIResponse{
+										Data: "VerifyPersistence: Upload of fake recording failed: " + err.Error(),
+									})
+								}
+							} else {
+								c.JSON(400, models.APIResponse{
+									Data: "VerifyPersistence: Something went wrong while creating /storage POST request." + err.Error(),
+								})
+							}
+						} else {
+							c.JSON(400, models.APIResponse{
+								Data: "VerifyPersistence: Provider and/or directory is missing from the request.",
+							})
+						}
+					} else {
+						c.JSON(400, models.APIResponse{
+							Data: "VerifyPersistence: Something went wrong while verifying storage credentials: " + string(body),
+						})
+					}
+				} else {
+					c.JSON(400, models.APIResponse{
+						Data: "VerifyPersistence: Something went wrong while verifying storage credentials:" + err.Error(),
+					})
+				}
+			} else {
+				c.JSON(400, models.APIResponse{
+					Data: "VerifyPersistence: please fill-in the required Kerberos Vault credentials.",
+				})
+			}
+		}
+	} else {
+		c.JSON(400, models.APIResponse{
+			Data: "VerifyPersistence: No persistence was specified, so do not know what to verify:" + err.Error(),
+		})
+	}
+}

machinery/src/cloud/Dropbox.go

@@ -11,8 +11,8 @@ import (
 	"github.com/dropbox/dropbox-sdk-go-unofficial/v6/dropbox/files"
 	"github.com/dropbox/dropbox-sdk-go-unofficial/v6/dropbox/users"
 	"github.com/gin-gonic/gin"
+	"github.com/kerberos-io/agent/machinery/src/log"
 	"github.com/kerberos-io/agent/machinery/src/models"
-	log "github.com/sirupsen/logrus"
 )
 
 // UploadDropbox uploads the file to your Dropbox account using the access token and directory.
@@ -30,13 +30,13 @@ func UploadDropbox(configuration *models.Configuration, fileName string) (bool,
 
 	if token == "" {
 		err := "UploadDropbox: Dropbox not properly configured"
-		log.Info(err)
+		log.Log.Info(err)
 		return false, true, errors.New(err)
 	}
 
 	// Upload to Dropbox
-	log.Info("UploadDropbox: Uploading to Dropbox")
-	log.Info("UploadDropbox: Upload started for " + fileName)
+	log.Log.Info("UploadDropbox: Uploading to Dropbox")
+	log.Log.Info("UploadDropbox: Upload started for " + fileName)
 	fullname := "data/recordings/" + fileName
 
 	dConfig := dropbox.Config{
@@ -46,11 +46,7 @@ func UploadDropbox(configuration *models.Configuration, fileName string) (bool,
 
 	file, err := os.OpenFile(fullname, os.O_RDWR, 0755)
 	if file != nil {
-		defer func() {
-			if cerr := file.Close(); cerr != nil {
-				log.Error("UploadDropbox: Error closing file: " + cerr.Error())
-			}
-		}()
+		defer file.Close()
 	}
 
 	if err == nil {
@@ -68,15 +64,15 @@ func UploadDropbox(configuration *models.Configuration, fileName string) (bool,
 		}, file)
 
 		if err != nil {
-			log.Error("UploadDropbox: Error uploading file: " + err.Error())
+			log.Log.Error("UploadDropbox: Error uploading file: " + err.Error())
 			return false, false, err
 		}
 
-		log.Info("UploadDropbox: File uploaded successfully, " + res.Name)
+		log.Log.Info("UploadDropbox: File uploaded successfully, " + res.Name)
 		return true, true, nil
 	}
 
-	log.Error("UploadDropbox: Error opening file: " + err.Error())
+	log.Log.Error("UploadDropbox: Error opening file: " + err.Error())
 	return false, true, err
 }
 

machinery/src/cloud/KerberosHub.go

@@ -0,0 +1,131 @@
+package cloud
+
+import (
+	"crypto/tls"
+	"errors"
+	"io/ioutil"
+	"net/http"
+	"os"
+
+	"github.com/kerberos-io/agent/machinery/src/log"
+	"github.com/kerberos-io/agent/machinery/src/models"
+)
+
+func UploadKerberosHub(configuration *models.Configuration, fileName string) (bool, bool, error) {
+	config := configuration.Config
+
+	if config.HubURI == "" ||
+		config.HubKey == "" ||
+		config.HubPrivateKey == "" ||
+		config.S3.Region == "" {
+		err := "UploadKerberosHub: Kerberos Hub not properly configured."
+		log.Log.Info(err)
+		return false, false, errors.New(err)
+	}
+
+	// timestamp_microseconds_instanceName_regionCoordinates_numberOfChanges_token
+	// 1564859471_6-474162_oprit_577-283-727-375_1153_27.mp4
+	// - Timestamp
+	// - Size + - + microseconds
+	// - device
+	// - Region
+	// - Number of changes
+	// - Token
+
+	log.Log.Info("UploadKerberosHub: Uploading to Kerberos Hub (" + config.HubURI + ")")
+	log.Log.Info("UploadKerberosHub: Upload started for " + fileName)
+	fullname := "data/recordings/" + fileName
+
+	// Check if we still have the file otherwise we abort the request.
+	file, err := os.OpenFile(fullname, os.O_RDWR, 0755)
+	if file != nil {
+		defer file.Close()
+	}
+	if err != nil {
+		err := "UploadKerberosHub: Upload Failed, file doesn't exists anymore."
+		log.Log.Info(err)
+		return false, false, errors.New(err)
+	}
+
+	// Check if we are allowed to upload to the hub with these credentials.
+	// There might be different reasons like (muted, read-only..)
+	req, err := http.NewRequest("HEAD", config.HubURI+"/storage/upload", nil)
+	if err != nil {
+		errorMessage := "UploadKerberosHub: error reading HEAD request, " + config.HubURI + "/storage: " + err.Error()
+		log.Log.Error(errorMessage)
+		return false, true, errors.New(errorMessage)
+	}
+
+	req.Header.Set("X-Kerberos-Storage-FileName", fileName)
+	req.Header.Set("X-Kerberos-Storage-Capture", "IPCamera")
+	req.Header.Set("X-Kerberos-Storage-Device", config.Key)
+	req.Header.Set("X-Kerberos-Hub-PublicKey", config.HubKey)
+	req.Header.Set("X-Kerberos-Hub-PrivateKey", config.HubPrivateKey)
+	req.Header.Set("X-Kerberos-Hub-Region", config.S3.Region)
+
+	var client *http.Client
+	if os.Getenv("AGENT_TLS_INSECURE") == "true" {
+		tr := &http.Transport{
+			TLSClientConfig: &tls.Config{InsecureSkipVerify: true},
+		}
+		client = &http.Client{Transport: tr}
+	} else {
+		client = &http.Client{}
+	}
+
+	resp, err := client.Do(req)
+	if resp != nil {
+		defer resp.Body.Close()
+	}
+
+	if err == nil {
+		if resp != nil {
+			if err == nil {
+				if resp.StatusCode == 200 {
+					log.Log.Info("UploadKerberosHub: Upload allowed using the credentials provided (" + config.HubKey + ", " + config.HubPrivateKey + ")")
+				} else {
+					log.Log.Info("UploadKerberosHub: Upload NOT allowed using the credentials provided (" + config.HubKey + ", " + config.HubPrivateKey + ")")
+					return false, true, nil
+				}
+			}
+		}
+	}
+
+	// Now we know we are allowed to upload to the hub, we can start uploading.
+	req, err = http.NewRequest("POST", config.HubURI+"/storage/upload", file)
+	if err != nil {
+		errorMessage := "UploadKerberosHub: error reading POST request, " + config.KStorage.URI + "/storage/upload: " + err.Error()
+		log.Log.Error(errorMessage)
+		return false, true, errors.New(errorMessage)
+	}
+	req.Header.Set("Content-Type", "video/mp4")
+	req.Header.Set("X-Kerberos-Storage-FileName", fileName)
+	req.Header.Set("X-Kerberos-Storage-Capture", "IPCamera")
+	req.Header.Set("X-Kerberos-Storage-Device", config.Key)
+	req.Header.Set("X-Kerberos-Hub-PublicKey", config.HubKey)
+	req.Header.Set("X-Kerberos-Hub-PrivateKey", config.HubPrivateKey)
+	req.Header.Set("X-Kerberos-Hub-Region", config.S3.Region)
+	resp, err = client.Do(req)
+	if resp != nil {
+		defer resp.Body.Close()
+	}
+
+	if err == nil {
+		if resp != nil {
+			body, err := ioutil.ReadAll(resp.Body)
+			if err == nil {
+				if resp.StatusCode == 200 {
+					log.Log.Info("UploadKerberosHub: Upload Finished, " + resp.Status + ".")
+					return true, true, nil
+				} else {
+					log.Log.Info("UploadKerberosHub: Upload Failed, " + resp.Status + ", " + string(body))
+					return false, true, nil
+				}
+			}
+		}
+	}
+
+	errorMessage := "UploadKerberosHub: Upload Failed, " + err.Error()
+	log.Log.Info(errorMessage)
+	return false, true, errors.New(errorMessage)
+}

machinery/src/cloud/KerberosVault.go

@@ -0,0 +1,105 @@
+package cloud
+
+import (
+	"crypto/tls"
+	"errors"
+	"io/ioutil"
+	"net/http"
+	"os"
+
+	"github.com/kerberos-io/agent/machinery/src/log"
+	"github.com/kerberos-io/agent/machinery/src/models"
+)
+
+func UploadKerberosVault(configuration *models.Configuration, fileName string) (bool, bool, error) {
+
+	config := configuration.Config
+
+	if config.KStorage.AccessKey == "" ||
+		config.KStorage.SecretAccessKey == "" ||
+		config.KStorage.Directory == "" ||
+		config.KStorage.URI == "" {
+		err := "UploadKerberosVault: Kerberos Vault not properly configured."
+		log.Log.Info(err)
+		return false, false, errors.New(err)
+	}
+
+	// timestamp_microseconds_instanceName_regionCoordinates_numberOfChanges_token
+	// 1564859471_6-474162_oprit_577-283-727-375_1153_27.mp4
+	// - Timestamp
+	// - Size + - + microseconds
+	// - device
+	// - Region
+	// - Number of changes
+	// - Token
+	// KerberosCloud, this means storage is disabled and proxy enabled.
+	log.Log.Info("UploadKerberosVault: Uploading to Kerberos Vault (" + config.KStorage.URI + ")")
+	log.Log.Info("UploadKerberosVault: Upload started for " + fileName)
+	fullname := "data/recordings/" + fileName
+
+	file, err := os.OpenFile(fullname, os.O_RDWR, 0755)
+	if file != nil {
+		defer file.Close()
+	}
+	if err != nil {
+		err := "UploadKerberosVault: Upload Failed, file doesn't exists anymore."
+		log.Log.Info(err)
+		return false, false, errors.New(err)
+	}
+
+	publicKey := config.KStorage.CloudKey
+	// This is the new way ;)
+	if config.HubKey != "" {
+		publicKey = config.HubKey
+	}
+
+	req, err := http.NewRequest("POST", config.KStorage.URI+"/storage", file)
+	if err != nil {
+		errorMessage := "UploadKerberosVault: error reading request, " + config.KStorage.URI + "/storage: " + err.Error()
+		log.Log.Error(errorMessage)
+		return false, true, errors.New(errorMessage)
+	}
+	req.Header.Set("Content-Type", "video/mp4")
+	req.Header.Set("X-Kerberos-Storage-CloudKey", publicKey)
+	req.Header.Set("X-Kerberos-Storage-AccessKey", config.KStorage.AccessKey)
+	req.Header.Set("X-Kerberos-Storage-SecretAccessKey", config.KStorage.SecretAccessKey)
+	req.Header.Set("X-Kerberos-Storage-Provider", config.KStorage.Provider)
+	req.Header.Set("X-Kerberos-Storage-FileName", fileName)
+	req.Header.Set("X-Kerberos-Storage-Device", config.Key)
+	req.Header.Set("X-Kerberos-Storage-Capture", "IPCamera")
+	req.Header.Set("X-Kerberos-Storage-Directory", config.KStorage.Directory)
+
+	var client *http.Client
+	if os.Getenv("AGENT_TLS_INSECURE") == "true" {
+		tr := &http.Transport{
+			TLSClientConfig: &tls.Config{InsecureSkipVerify: true},
+		}
+		client = &http.Client{Transport: tr}
+	} else {
+		client = &http.Client{}
+	}
+
+	resp, err := client.Do(req)
+	if resp != nil {
+		defer resp.Body.Close()
+	}
+
+	if err == nil {
+		if resp != nil {
+			body, err := ioutil.ReadAll(resp.Body)
+			if err == nil {
+				if resp.StatusCode == 200 {
+					log.Log.Info("UploadKerberosVault: Upload Finished, " + resp.Status + ", " + string(body))
+					return true, true, nil
+				} else {
+					log.Log.Info("UploadKerberosVault: Upload Failed, " + resp.Status + ", " + string(body))
+					return false, true, nil
+				}
+			}
+		}
+	}
+
+	errorMessage := "UploadKerberosVault: Upload Failed, " + err.Error()
+	log.Log.Info(errorMessage)
+	return false, true, errors.New(errorMessage)
+}

machinery/src/cloud/S3.go

@@ -9,9 +9,9 @@ import (
 	"strconv"
 	"strings"
 
+	"github.com/kerberos-io/agent/machinery/src/log"
 	"github.com/kerberos-io/agent/machinery/src/models"
 	"github.com/minio/minio-go/v6"
-	log "github.com/sirupsen/logrus"
 )
 
 func UploadS3(configuration *models.Configuration, fileName string) (bool, bool, error) {
@@ -29,7 +29,7 @@ func UploadS3(configuration *models.Configuration, fileName string) (bool, bool,
 
 	if config.S3 == nil {
 		errorMessage := "UploadS3: Uploading Failed, as no settings found"
-		log.Error(errorMessage)
+		log.Log.Error(errorMessage)
 		return false, false, errors.New(errorMessage)
 	}
 
@@ -49,14 +49,14 @@ func UploadS3(configuration *models.Configuration, fileName string) (bool, bool,
 	// Check if we have some credentials otherwise we abort the request.
 	if aws_access_key_id == "" || aws_secret_access_key == "" {
 		errorMessage := "UploadS3: Uploading Failed, as no credentials found"
-		log.Error(errorMessage)
+		log.Log.Error(errorMessage)
 		return false, false, errors.New(errorMessage)
 	}
 
 	s3Client, err := minio.NewWithRegion("s3.amazonaws.com", aws_access_key_id, aws_secret_access_key, true, aws_region)
 	if err != nil {
 		errorMessage := "UploadS3: " + err.Error()
-		log.Error(errorMessage)
+		log.Log.Error(errorMessage)
 		return false, true, errors.New(errorMessage)
 	}
 
@@ -74,7 +74,7 @@ func UploadS3(configuration *models.Configuration, fileName string) (bool, bool,
 	fileParts := strings.Split(fileName, "_")
 	if len(fileParts) == 1 {
 		errorMessage := "UploadS3: " + fileName + " is not a valid name."
-		log.Error(errorMessage)
+		log.Log.Error(errorMessage)
 		return false, true, errors.New(errorMessage)
 	}
 
@@ -85,7 +85,7 @@ func UploadS3(configuration *models.Configuration, fileName string) (bool, bool,
 	//numberOfChanges := fileParts[4]
 	token, _ := strconv.Atoi(fileParts[5])
 
-	log.Info("UploadS3: Upload started for " + fileName)
+	log.Log.Info("UploadS3: Upload started for " + fileName)
 	fullname := "data/recordings/" + fileName
 
 	file, err := os.OpenFile(fullname, os.O_RDWR, 0755)
@@ -95,14 +95,14 @@ func UploadS3(configuration *models.Configuration, fileName string) (bool, bool,
 
 	if err != nil {
 		errorMessage := "UploadS3: " + err.Error()
-		log.Error(errorMessage)
+		log.Log.Error(errorMessage)
 		return false, true, errors.New(errorMessage)
 	}
 
 	fileInfo, err := file.Stat()
 	if err != nil {
 		errorMessage := "UploadS3: " + err.Error()
-		log.Error(errorMessage)
+		log.Log.Error(errorMessage)
 		return false, true, errors.New(errorMessage)
 	}
 
@@ -128,10 +128,10 @@ func UploadS3(configuration *models.Configuration, fileName string) (bool, bool,
 
 	if err != nil {
 		errorMessage := "UploadS3: Uploading Failed, " + err.Error()
-		log.Error(errorMessage)
+		log.Log.Error(errorMessage)
 		return false, true, errors.New(errorMessage)
 	} else {
-		log.Info("UploadS3: Upload Finished, file has been uploaded to bucket: " + strconv.FormatInt(n, 10))
+		log.Log.Info("UploadS3: Upload Finished, file has been uploaded to bucket: " + strconv.FormatInt(n, 10))
 		return true, true, nil
 	}
 }

machinery/src/cloud/cloud_test.go

@@ -1,592 +0,0 @@
-package cloud
-
-import (
-	"encoding/json"
-	"errors"
-	"fmt"
-	"io"
-	"net/http"
-	"strings"
-	"testing"
-	"time"
-
-	"github.com/kerberos-io/agent/machinery/src/models"
-	agentonvif "github.com/kerberos-io/agent/machinery/src/onvif"
-	goonvif "github.com/kerberos-io/onvif"
-	goonvifdevice "github.com/kerberos-io/onvif/device"
-	goonvifptz "github.com/kerberos-io/onvif/ptz"
-)
-
-func TestHeartbeatFailureLogOmitsHubResponseBody(t *testing.T) {
-	response := &http.Response{
-		StatusCode: http.StatusBadRequest,
-		Status:     "400 Bad Request",
-		Body:       io.NopCloser(strings.NewReader(`{"error":"invalid heartbeat"}`)),
-	}
-
-	responseBody, truncated, err := readHeartbeatResponseBody(response)
-	if err != nil {
-		t.Fatalf("readHeartbeatResponseBody() error = %v", err)
-	}
-	fields := heartbeatFailureLogFields(response, responseBody, truncated, 125*time.Millisecond)
-
-	for key, want := range map[string]interface{}{
-		"duration_ms":             int64(125),
-		"response_body_bytes":     len(responseBody),
-		"response_body_truncated": false,
-		"status_code":             http.StatusBadRequest,
-	} {
-		if got := fields[key]; got != want {
-			t.Errorf("%s = %v, want %v", key, got, want)
-		}
-	}
-	for key, value := range fields {
-		if strings.Contains(key, "response_body") && key != "response_body_bytes" && key != "response_body_truncated" {
-			t.Fatalf("unexpected response body field %q=%v", key, value)
-		}
-		if strings.Contains(fmt.Sprint(value), "invalid heartbeat") {
-			t.Fatalf("heartbeat log fields exposed response body in %q=%v", key, value)
-		}
-	}
-}
-
-func TestReadHeartbeatResponseBodyTruncatesLargeBody(t *testing.T) {
-	response := &http.Response{
-		Body: io.NopCloser(strings.NewReader(strings.Repeat("x", heartbeatResponseBodyLogLimit+1))),
-	}
-
-	body, truncated, err := readHeartbeatResponseBody(response)
-	if err != nil {
-		t.Fatalf("readHeartbeatResponseBody() error = %v", err)
-	}
-	if !truncated {
-		t.Fatal("readHeartbeatResponseBody() truncated = false, want true")
-	}
-	if len(body) != heartbeatResponseBodyLogLimit {
-		t.Fatalf("len(body) = %d, want %d", len(body), heartbeatResponseBodyLogLimit)
-	}
-}
-
-func TestHeartbeatONVIFPayloadCachesStaticAndReusesLoopSubscription(t *testing.T) {
-	restoreHeartbeatONVIFStubs(t)
-
-	device := newTestONVIFDevice()
-	camera := models.IPCamera{
-		ONVIFXAddr:    "http://camera/onvif",
-		ONVIFUsername: "operator",
-		ONVIFPassword: "secret",
-	}
-	initialEvents := []agentonvif.ONVIFEvents{{Key: "input-1", Type: "input", Value: "true", Timestamp: 1}}
-	loopEvents := []agentonvif.ONVIFEvents{{Key: "output-1", Type: "output", Value: "false", Timestamp: 2}}
-	wantPresets := mustJSONMarshal(t, []models.OnvifActionPreset{{Name: "Lobby", Token: "1"}})
-	wantInitialEvents := mustJSONMarshal(t, initialEvents)
-	wantLoopEvents := mustJSONMarshal(t, loopEvents)
-
-	var connectCalls, ptzConfigCalls, ptzFunctionCalls, presetCalls, createCalls, eventCalls, unsubscribeCalls int
-
-	heartbeatConnectToONVIFDevice = func(*models.IPCamera) (*goonvif.Device, goonvifdevice.GetCapabilitiesResponse, error) {
-		connectCalls++
-		return device, goonvifdevice.GetCapabilitiesResponse{}, nil
-	}
-	heartbeatGetPTZConfigurationsFromDevice = func(*goonvif.Device) (goonvifptz.GetConfigurationsResponse, error) {
-		ptzConfigCalls++
-		return goonvifptz.GetConfigurationsResponse{}, nil
-	}
-	heartbeatGetPTZFunctionsFromDevice = func(goonvifptz.GetConfigurationsResponse) ([]string, bool, bool) {
-		ptzFunctionCalls++
-		return nil, true, true
-	}
-	heartbeatGetPresetsFromDevice = func(*goonvif.Device) ([]models.OnvifActionPreset, error) {
-		presetCalls++
-		return []models.OnvifActionPreset{{Name: "Lobby", Token: "1"}}, nil
-	}
-	heartbeatCreatePullPointSubscription = func(*goonvif.Device) (string, error) {
-		createCalls++
-		switch createCalls {
-		case 1:
-			return "initial-1", nil
-		case 2:
-			return "loop", nil
-		case 3:
-			return "initial-2", nil
-		default:
-			t.Fatalf("unexpected create pull point call %d", createCalls)
-			return "", nil
-		}
-	}
-	heartbeatGetEventMessages = func(_ *goonvif.Device, pullPointAddress string) ([]agentonvif.ONVIFEvents, error) {
-		eventCalls++
-		switch pullPointAddress {
-		case "initial-1", "initial-2":
-			return initialEvents, nil
-		case "loop":
-			return loopEvents, nil
-		default:
-			t.Fatalf("unexpected pull point address %q", pullPointAddress)
-			return nil, nil
-		}
-	}
-	heartbeatUnsubscribePullPoint = func(_ *goonvif.Device, pullPointAddress string) error {
-		unsubscribeCalls++
-		if pullPointAddress != "initial-1" && pullPointAddress != "initial-2" {
-			t.Fatalf("unexpected unsubscribe pull point %q", pullPointAddress)
-		}
-		return nil
-	}
-
-	state := newHeartbeatONVIFState()
-
-	payload := getHeartbeatONVIFPayload(camera, state)
-	if payload.enabled != "true" || payload.zoom != "true" || payload.panTilt != "true" || payload.presets != "true" {
-		t.Fatalf("unexpected static payload: %+v", payload)
-	}
-	if string(payload.presetsList) != string(wantPresets) {
-		t.Fatalf("payload.presetsList = %s, want %s", payload.presetsList, wantPresets)
-	}
-	if string(payload.eventsList) != string(wantInitialEvents) {
-		t.Fatalf("payload.eventsList = %s, want %s", payload.eventsList, wantInitialEvents)
-	}
-	if connectCalls != 1 || ptzConfigCalls != 1 || ptzFunctionCalls != 1 || presetCalls != 1 {
-		t.Fatalf("unexpected static call counts after first cycle: connect=%d ptzConfig=%d ptzFunctions=%d presets=%d", connectCalls, ptzConfigCalls, ptzFunctionCalls, presetCalls)
-	}
-	if createCalls != 2 || eventCalls != 1 || unsubscribeCalls != 1 {
-		t.Fatalf("unexpected event call counts after first cycle: create=%d events=%d unsubscribe=%d", createCalls, eventCalls, unsubscribeCalls)
-	}
-
-	payload = getHeartbeatONVIFPayload(camera, state)
-	if string(payload.eventsList) != string(wantLoopEvents) {
-		t.Fatalf("second payload.eventsList = %s, want %s", payload.eventsList, wantLoopEvents)
-	}
-	if connectCalls != 1 {
-		t.Fatalf("connectCalls = %d, want 1", connectCalls)
-	}
-	if ptzConfigCalls != 1 || ptzFunctionCalls != 1 || presetCalls != 1 {
-		t.Fatalf("static calls were not cached: ptzConfig=%d ptzFunctions=%d presets=%d", ptzConfigCalls, ptzFunctionCalls, presetCalls)
-	}
-	if createCalls != 3 || eventCalls != 3 || unsubscribeCalls != 2 {
-		t.Fatalf("temporary state subscription was not refreshed or loop subscription was not reused: create=%d events=%d unsubscribe=%d", createCalls, eventCalls, unsubscribeCalls)
-	}
-}
-
-func TestHeartbeatONVIFPayloadRefreshesAfterCameraConfigChange(t *testing.T) {
-	restoreHeartbeatONVIFStubs(t)
-
-	deviceA := newTestONVIFDevice()
-	deviceB := newTestONVIFDevice()
-	cameraA := models.IPCamera{ONVIFXAddr: "http://camera-a/onvif", ONVIFUsername: "user", ONVIFPassword: "secret-a"}
-	cameraB := models.IPCamera{ONVIFXAddr: "http://camera-b/onvif", ONVIFUsername: "user", ONVIFPassword: "secret-b"}
-	var connectCalls, ptzConfigCalls, presetCalls, createCalls int
-	var unsubscribed []string
-
-	heartbeatConnectToONVIFDevice = func(camera *models.IPCamera) (*goonvif.Device, goonvifdevice.GetCapabilitiesResponse, error) {
-		connectCalls++
-		switch camera.ONVIFXAddr {
-		case cameraA.ONVIFXAddr:
-			return deviceA, goonvifdevice.GetCapabilitiesResponse{}, nil
-		case cameraB.ONVIFXAddr:
-			return deviceB, goonvifdevice.GetCapabilitiesResponse{}, nil
-		default:
-			t.Fatalf("unexpected camera address %q", camera.ONVIFXAddr)
-			return nil, goonvifdevice.GetCapabilitiesResponse{}, nil
-		}
-	}
-	heartbeatGetPTZConfigurationsFromDevice = func(*goonvif.Device) (goonvifptz.GetConfigurationsResponse, error) {
-		ptzConfigCalls++
-		return goonvifptz.GetConfigurationsResponse{}, nil
-	}
-	heartbeatGetPTZFunctionsFromDevice = func(goonvifptz.GetConfigurationsResponse) ([]string, bool, bool) {
-		return nil, false, true
-	}
-	heartbeatGetPresetsFromDevice = func(*goonvif.Device) ([]models.OnvifActionPreset, error) {
-		presetCalls++
-		return nil, nil
-	}
-	heartbeatCreatePullPointSubscription = func(*goonvif.Device) (string, error) {
-		createCalls++
-		switch createCalls {
-		case 1:
-			return "initial-a", nil
-		case 2:
-			return "loop-a", nil
-		case 3:
-			return "initial-b", nil
-		case 4:
-			return "loop-b", nil
-		default:
-			t.Fatalf("unexpected create pull point call %d", createCalls)
-			return "", nil
-		}
-	}
-	heartbeatGetEventMessages = func(_ *goonvif.Device, pullPointAddress string) ([]agentonvif.ONVIFEvents, error) {
-		switch pullPointAddress {
-		case "initial-a":
-			return []agentonvif.ONVIFEvents{{Key: "a", Type: "input", Value: "true", Timestamp: 1}}, nil
-		case "initial-b":
-			return []agentonvif.ONVIFEvents{{Key: "b", Type: "input", Value: "false", Timestamp: 2}}, nil
-		default:
-			t.Fatalf("unexpected pull point address %q", pullPointAddress)
-			return nil, nil
-		}
-	}
-	heartbeatUnsubscribePullPoint = func(_ *goonvif.Device, pullPointAddress string) error {
-		unsubscribed = append(unsubscribed, pullPointAddress)
-		return nil
-	}
-
-	state := newHeartbeatONVIFState()
-	_ = getHeartbeatONVIFPayload(cameraA, state)
-	payload := getHeartbeatONVIFPayload(cameraB, state)
-
-	if connectCalls != 2 {
-		t.Fatalf("connectCalls = %d, want 2", connectCalls)
-	}
-	if ptzConfigCalls != 2 || presetCalls != 2 {
-		t.Fatalf("camera config change did not refresh static state: ptzConfig=%d presets=%d", ptzConfigCalls, presetCalls)
-	}
-	if createCalls != 4 {
-		t.Fatalf("camera config change did not recreate subscriptions: create=%d", createCalls)
-	}
-	if countString(unsubscribed, "loop-a") != 1 {
-		t.Fatalf("unsubscribed loop-a %d times, want 1; unsubscribed=%v", countString(unsubscribed, "loop-a"), unsubscribed)
-	}
-	wantEvents := mustJSONMarshal(t, []agentonvif.ONVIFEvents{{Key: "b", Type: "input", Value: "false", Timestamp: 2}})
-	if string(payload.eventsList) != string(wantEvents) {
-		t.Fatalf("payload.eventsList = %s, want %s", payload.eventsList, wantEvents)
-	}
-}
-
-func TestHeartbeatONVIFPayloadRetriesStaticFetchFailuresWithoutReconnect(t *testing.T) {
-	restoreHeartbeatONVIFStubs(t)
-
-	device := newTestONVIFDevice()
-	camera := models.IPCamera{
-		ONVIFXAddr:    "http://camera/onvif",
-		ONVIFUsername: "operator",
-		ONVIFPassword: "secret",
-	}
-	var connectCalls, ptzConfigCalls, presetCalls, createCalls, eventCalls int
-
-	heartbeatConnectToONVIFDevice = func(*models.IPCamera) (*goonvif.Device, goonvifdevice.GetCapabilitiesResponse, error) {
-		connectCalls++
-		return device, goonvifdevice.GetCapabilitiesResponse{}, nil
-	}
-	heartbeatGetPTZConfigurationsFromDevice = func(*goonvif.Device) (goonvifptz.GetConfigurationsResponse, error) {
-		ptzConfigCalls++
-		return goonvifptz.GetConfigurationsResponse{}, nil
-	}
-	heartbeatGetPTZFunctionsFromDevice = func(goonvifptz.GetConfigurationsResponse) ([]string, bool, bool) {
-		return nil, true, true
-	}
-	heartbeatGetPresetsFromDevice = func(*goonvif.Device) ([]models.OnvifActionPreset, error) {
-		presetCalls++
-		if presetCalls == 1 {
-			return nil, errors.New("temporary preset failure")
-		}
-		return []models.OnvifActionPreset{{Name: "Lobby", Token: "1"}}, nil
-	}
-	heartbeatCreatePullPointSubscription = func(*goonvif.Device) (string, error) {
-		createCalls++
-		switch createCalls {
-		case 1:
-			return "initial-1", nil
-		case 2:
-			return "loop", nil
-		case 3:
-			return "initial-2", nil
-		default:
-			t.Fatalf("unexpected create pull point call %d", createCalls)
-			return "", nil
-		}
-	}
-	heartbeatGetEventMessages = func(_ *goonvif.Device, pullPointAddress string) ([]agentonvif.ONVIFEvents, error) {
-		eventCalls++
-		switch pullPointAddress {
-		case "initial-1", "initial-2":
-			return []agentonvif.ONVIFEvents{{Key: "one", Type: "input", Value: "true", Timestamp: 1}}, nil
-		case "loop":
-			return []agentonvif.ONVIFEvents{{Key: "two", Type: "output", Value: "false", Timestamp: 2}}, nil
-		default:
-			t.Fatalf("unexpected pull point address %q", pullPointAddress)
-			return nil, nil
-		}
-	}
-	heartbeatUnsubscribePullPoint = func(*goonvif.Device, string) error { return nil }
-
-	state := newHeartbeatONVIFState()
-	payload := getHeartbeatONVIFPayload(camera, state)
-	if payload.presets != "false" {
-		t.Fatalf("payload.presets = %q, want false on transient preset failure", payload.presets)
-	}
-	payload = getHeartbeatONVIFPayload(camera, state)
-	if payload.presets != "true" {
-		t.Fatalf("payload.presets = %q, want true after retry", payload.presets)
-	}
-	if connectCalls != 1 {
-		t.Fatalf("connectCalls = %d, want 1", connectCalls)
-	}
-	if ptzConfigCalls != 2 || presetCalls != 2 {
-		t.Fatalf("static failures were not retried on heartbeat cadence: ptzConfig=%d presets=%d", ptzConfigCalls, presetCalls)
-	}
-	if createCalls != 3 || eventCalls != 3 {
-		t.Fatalf("unexpected event behavior during retry: create=%d events=%d", createCalls, eventCalls)
-	}
-}
-
-func TestHeartbeatONVIFStateReleasesSubscriptionWhenDisabled(t *testing.T) {
-	restoreHeartbeatONVIFStubs(t)
-
-	device := newTestONVIFDevice()
-	state := newHeartbeatONVIFState()
-	state.cameraConfiguration = models.IPCamera{ONVIFXAddr: "http://camera/onvif"}
-	state.cameraKey = heartbeatONVIFCameraKey(state.cameraConfiguration)
-	state.device = device
-	state.loopPullPoint = "loop"
-
-	var unsubscribed []string
-	heartbeatUnsubscribePullPoint = func(gotDevice *goonvif.Device, pullPointAddress string) error {
-		if gotDevice != device {
-			t.Fatal("unsubscribe used a different ONVIF device")
-		}
-		unsubscribed = append(unsubscribed, pullPointAddress)
-		return nil
-	}
-
-	state.prepare(models.IPCamera{})
-
-	if len(unsubscribed) != 1 || unsubscribed[0] != "loop" {
-		t.Fatalf("unsubscribed = %v, want [loop]", unsubscribed)
-	}
-	if state.device != nil || state.loopPullPoint != "" {
-		t.Fatalf("disabled state retained device or pull point: %+v", state)
-	}
-}
-
-func TestHeartbeatONVIFPayloadDoesNotCreateSubscriptionsWhenConnectFails(t *testing.T) {
-	restoreHeartbeatONVIFStubs(t)
-
-	var createCalls int
-
-	heartbeatConnectToONVIFDevice = func(*models.IPCamera) (*goonvif.Device, goonvifdevice.GetCapabilitiesResponse, error) {
-		return nil, goonvifdevice.GetCapabilitiesResponse{}, errors.New("connect failed")
-	}
-	heartbeatCreatePullPointSubscription = func(*goonvif.Device) (string, error) {
-		createCalls++
-		return "unexpected", nil
-	}
-
-	payload := getHeartbeatONVIFPayload(models.IPCamera{
-		ONVIFXAddr:    "http://camera/onvif",
-		ONVIFUsername: "operator",
-		ONVIFPassword: "secret",
-	}, newHeartbeatONVIFState())
-
-	if createCalls != 0 {
-		t.Fatalf("createCalls = %d, want 0", createCalls)
-	}
-	assertDefaultHeartbeatONVIFPayload(t, payload)
-}
-
-func TestHeartbeatONVIFPayloadReconnectFailureInvalidatesCache(t *testing.T) {
-	restoreHeartbeatONVIFStubs(t)
-
-	device1 := newTestONVIFDevice()
-	device2 := newTestONVIFDevice()
-	camera := models.IPCamera{
-		ONVIFXAddr:    "http://camera/onvif",
-		ONVIFUsername: "operator",
-		ONVIFPassword: "secret",
-	}
-	var connectCalls, ptzConfigCalls, presetCalls, createCalls int
-	var unsubscribed []string
-
-	heartbeatConnectToONVIFDevice = func(*models.IPCamera) (*goonvif.Device, goonvifdevice.GetCapabilitiesResponse, error) {
-		connectCalls++
-		switch connectCalls {
-		case 1:
-			return device1, goonvifdevice.GetCapabilitiesResponse{}, nil
-		case 2:
-			return device2, goonvifdevice.GetCapabilitiesResponse{}, nil
-		default:
-			t.Fatalf("unexpected connect call %d", connectCalls)
-			return nil, goonvifdevice.GetCapabilitiesResponse{}, nil
-		}
-	}
-	heartbeatGetPTZConfigurationsFromDevice = func(*goonvif.Device) (goonvifptz.GetConfigurationsResponse, error) {
-		ptzConfigCalls++
-		return goonvifptz.GetConfigurationsResponse{}, nil
-	}
-	heartbeatGetPTZFunctionsFromDevice = func(goonvifptz.GetConfigurationsResponse) ([]string, bool, bool) {
-		return nil, true, false
-	}
-	heartbeatGetPresetsFromDevice = func(*goonvif.Device) ([]models.OnvifActionPreset, error) {
-		presetCalls++
-		return []models.OnvifActionPreset{{Name: "Preset", Token: "1"}}, nil
-	}
-	heartbeatCreatePullPointSubscription = func(*goonvif.Device) (string, error) {
-		createCalls++
-		switch createCalls {
-		case 1:
-			return "initial-1", nil
-		case 2:
-			return "loop-1", nil
-		case 3:
-			return "initial-2", nil
-		case 4:
-			return "initial-3", nil
-		case 5:
-			return "loop-3", nil
-		default:
-			t.Fatalf("unexpected create pull point call %d", createCalls)
-			return "", nil
-		}
-	}
-	heartbeatGetEventMessages = func(_ *goonvif.Device, pullPointAddress string) ([]agentonvif.ONVIFEvents, error) {
-		switch pullPointAddress {
-		case "initial-1":
-			return []agentonvif.ONVIFEvents{{Key: "before", Type: "input", Value: "true", Timestamp: 1}}, nil
-		case "initial-2":
-			return []agentonvif.ONVIFEvents{{Key: "during", Type: "input", Value: "true", Timestamp: 2}}, nil
-		case "loop-1":
-			return nil, errors.New("pull failed")
-		case "initial-3":
-			return []agentonvif.ONVIFEvents{{Key: "after", Type: "input", Value: "false", Timestamp: 2}}, nil
-		default:
-			t.Fatalf("unexpected pull point address %q", pullPointAddress)
-			return nil, nil
-		}
-	}
-	heartbeatUnsubscribePullPoint = func(_ *goonvif.Device, pullPointAddress string) error {
-		unsubscribed = append(unsubscribed, pullPointAddress)
-		return nil
-	}
-
-	state := newHeartbeatONVIFState()
-	_ = getHeartbeatONVIFPayload(camera, state)
-	payload := getHeartbeatONVIFPayload(camera, state)
-	wantEventsDuringFailure := mustJSONMarshal(t, []agentonvif.ONVIFEvents{{Key: "during", Type: "input", Value: "true", Timestamp: 2}})
-	if string(payload.eventsList) != string(wantEventsDuringFailure) {
-		t.Fatalf("payload.eventsList after operation failure = %s, want %s", payload.eventsList, wantEventsDuringFailure)
-	}
-	payload = getHeartbeatONVIFPayload(camera, state)
-
-	if ptzConfigCalls != 2 || presetCalls != 2 {
-		t.Fatalf("reconnect did not refresh static state: ptzConfig=%d presets=%d", ptzConfigCalls, presetCalls)
-	}
-	if connectCalls != 2 {
-		t.Fatalf("connectCalls = %d, want 2 after reconnect", connectCalls)
-	}
-	if createCalls != 5 {
-		t.Fatalf("reconnect did not recreate subscriptions: create=%d", createCalls)
-	}
-	if countString(unsubscribed, "loop-1") != 1 {
-		t.Fatalf("operation failure cleanup mismatch, unsubscribed=%v", unsubscribed)
-	}
-	wantEvents := mustJSONMarshal(t, []agentonvif.ONVIFEvents{{Key: "after", Type: "input", Value: "false", Timestamp: 2}})
-	if string(payload.eventsList) != string(wantEvents) {
-		t.Fatalf("payload.eventsList = %s, want %s", payload.eventsList, wantEvents)
-	}
-}
-
-func TestHeartbeatONVIFPayloadKeepsCachedConnectionWhenInitialStateFetchFails(t *testing.T) {
-	restoreHeartbeatONVIFStubs(t)
-
-	device := newTestONVIFDevice()
-	camera := models.IPCamera{
-		ONVIFXAddr:    "http://camera/onvif",
-		ONVIFUsername: "operator",
-		ONVIFPassword: "secret",
-	}
-	loopEvents := []agentonvif.ONVIFEvents{{Key: "input-1", Type: "input", Value: "true", Timestamp: 1}}
-
-	state := newHeartbeatONVIFState()
-	state.cameraConfiguration = camera
-	state.cameraKey = heartbeatONVIFCameraKey(camera)
-	state.device = device
-	state.loopPullPoint = "loop"
-	state.staticLoaded = true
-	state.staticPayload.enabled = "true"
-
-	heartbeatCreatePullPointSubscription = func(*goonvif.Device) (string, error) {
-		return "", errors.New("temporary initial-state failure")
-	}
-	heartbeatGetEventMessages = func(_ *goonvif.Device, pullPointAddress string) ([]agentonvif.ONVIFEvents, error) {
-		if pullPointAddress != "loop" {
-			t.Fatalf("unexpected pull point address %q", pullPointAddress)
-		}
-		return loopEvents, nil
-	}
-
-	payload := getHeartbeatONVIFPayload(camera, state)
-
-	wantEvents := mustJSONMarshal(t, loopEvents)
-	if string(payload.eventsList) != string(wantEvents) {
-		t.Fatalf("payload.eventsList = %s, want %s", payload.eventsList, wantEvents)
-	}
-	if state.device != device || state.loopPullPoint != "loop" || !state.staticLoaded {
-		t.Fatalf("temporary failure invalidated healthy cached state: %+v", state)
-	}
-}
-
-func restoreHeartbeatONVIFStubs(t *testing.T) {
-	t.Helper()
-
-	originalConnect := heartbeatConnectToONVIFDevice
-	originalCreate := heartbeatCreatePullPointSubscription
-	originalDigitalInputs := heartbeatGetDigitalInputs
-	originalEvents := heartbeatGetEventMessages
-	originalPresets := heartbeatGetPresetsFromDevice
-	originalPTZConfigurations := heartbeatGetPTZConfigurationsFromDevice
-	originalPTZFunctions := heartbeatGetPTZFunctionsFromDevice
-	originalRelayOutputs := heartbeatGetRelayOutputs
-	originalUnsubscribe := heartbeatUnsubscribePullPoint
-
-	t.Cleanup(func() {
-		heartbeatConnectToONVIFDevice = originalConnect
-		heartbeatCreatePullPointSubscription = originalCreate
-		heartbeatGetDigitalInputs = originalDigitalInputs
-		heartbeatGetEventMessages = originalEvents
-		heartbeatGetPresetsFromDevice = originalPresets
-		heartbeatGetPTZConfigurationsFromDevice = originalPTZConfigurations
-		heartbeatGetPTZFunctionsFromDevice = originalPTZFunctions
-		heartbeatGetRelayOutputs = originalRelayOutputs
-		heartbeatUnsubscribePullPoint = originalUnsubscribe
-	})
-}
-
-func mustJSONMarshal(t *testing.T, v interface{}) []byte {
-	t.Helper()
-
-	b, err := json.Marshal(v)
-	if err != nil {
-		t.Fatalf("json.Marshal() error = %v", err)
-	}
-	return b
-}
-
-func assertDefaultHeartbeatONVIFPayload(t *testing.T, payload heartbeatONVIFPayload) {
-	t.Helper()
-
-	defaultPayload := defaultHeartbeatONVIFPayload()
-	if payload.enabled != defaultPayload.enabled ||
-		payload.zoom != defaultPayload.zoom ||
-		payload.panTilt != defaultPayload.panTilt ||
-		payload.presets != defaultPayload.presets ||
-		string(payload.presetsList) != string(defaultPayload.presetsList) ||
-		string(payload.eventsList) != string(defaultPayload.eventsList) {
-		t.Fatalf("payload = %+v, want default payload", payload)
-	}
-}
-
-func newTestONVIFDevice() *goonvif.Device {
-	return &goonvif.Device{}
-}
-
-func countString(values []string, want string) int {
-	count := 0
-	for _, value := range values {
-		if value == want {
-			count++
-		}
-	}
-	return count
-}

machinery/src/cloud/kerberos_hub.go

@@ -1,219 +0,0 @@
-package cloud
-
-import (
-	"crypto/tls"
-	"errors"
-	"fmt"
-	"io/ioutil"
-	"net/http"
-	"os"
-
-	"github.com/kerberos-io/agent/machinery/src/models"
-	log "github.com/sirupsen/logrus"
-)
-
-func UploadKerberosHub(configuration *models.Configuration, fileName string) (bool, bool, error) {
-	config := configuration.Config
-
-	if config.HubURI == "" ||
-		config.HubKey == "" ||
-		config.HubPrivateKey == "" ||
-		config.S3.Region == "" {
-		err := "UploadKerberosHub: Kerberos Hub not properly configured."
-		log.Info(err)
-		return false, false, errors.New(err)
-	}
-
-	// timestamp_microseconds_instanceName_regionCoordinates_numberOfChanges_token
-	// 1564859471_6-474162_oprit_577-283-727-375_1153_27.mp4
-	// - Timestamp
-	// - Size + - + microseconds
-	// - device
-	// - Region
-	// - Number of changes
-	// - Token
-
-	log.WithFields(log.Fields{
-		"component": "kerberos_hub",
-		"event":     "upload_started",
-	}).Info("Uploading recording to Kerberos Hub")
-
-	// Prefer the resumable (tus) upload when enabled (the default). Kerberos Hub
-	// authenticates the agent with its Hub public/private key and proxies the
-	// resumable upload to the Kerberos Vault. When Hub does not expose a tus
-	// endpoint (older deployments) we transparently fall back to the legacy
-	// single-POST upload below.
-	if resumableUploadsEnabled() {
-		uploaded, _, supported, body, rerr := uploadHubResumable(&config, fileName, "UploadKerberosHub", "hub")
-		if supported {
-			if uploaded {
-				log.WithFields(log.Fields{
-					"component":      "kerberos_hub",
-					"event":          "upload_completed",
-					"response_bytes": len(body),
-					"transport":      "tus",
-				}).Info("Hub upload completed")
-				return true, true, nil
-			}
-			if rerr != nil {
-				log.WithError(rerr).WithFields(log.Fields{
-					"component": "kerberos_hub",
-					"event":     "upload_failed",
-					"transport": "tus",
-				}).Error("Hub upload failed")
-			} else {
-				log.WithFields(log.Fields{
-					"component":      "kerberos_hub",
-					"event":          "upload_incomplete",
-					"response_bytes": len(body),
-					"transport":      "tus",
-				}).Warn("Hub upload incomplete")
-			}
-			return false, true, rerr
-		}
-		log.WithFields(log.Fields{
-			"component": "kerberos_hub",
-			"event":     "upload_transport_fallback",
-			"transport": "http",
-		}).Info("Resumable Hub upload unavailable; using legacy upload")
-	}
-
-	fullname := "data/recordings/" + fileName
-
-	// Check if we still have the file otherwise we abort the request.
-	file, err := os.OpenFile(fullname, os.O_RDWR, 0755)
-	if file != nil {
-		defer file.Close()
-	}
-	if err != nil {
-		err := "UploadKerberosHub: Upload Failed, file doesn't exists anymore."
-		log.Info(err)
-		return false, false, errors.New(err)
-	}
-
-	// Check if we are allowed to upload to the hub with these credentials.
-	// There might be different reasons like (muted, read-only..)
-	req, err := http.NewRequest("HEAD", config.HubURI+"/storage/upload", nil)
-	if err != nil {
-		log.WithError(err).WithFields(log.Fields{
-			"component": "kerberos_hub",
-			"event":     "authorization_request_creation_failed",
-		}).Error("Failed to create Hub upload authorization request")
-		return false, true, fmt.Errorf("create Hub upload authorization request: %w", err)
-	}
-
-	req.Header.Set("X-Kerberos-Storage-FileName", fileName)
-	req.Header.Set("X-Kerberos-Storage-Capture", "IPCamera")
-	req.Header.Set("X-Kerberos-Storage-Device", config.Key)
-	req.Header.Set("X-Kerberos-Hub-PublicKey", config.HubKey)
-	req.Header.Set("X-Kerberos-Hub-PrivateKey", config.HubPrivateKey)
-	req.Header.Set("X-Kerberos-Hub-Region", config.S3.Region)
-	setQueuedRecordingMetadataHeaders(req.Header, fileName)
-
-	var client *http.Client
-	if os.Getenv("AGENT_TLS_INSECURE") == "true" {
-		tr := &http.Transport{
-			TLSClientConfig: &tls.Config{InsecureSkipVerify: true},
-		}
-		client = &http.Client{Transport: tr, CheckRedirect: stripHubCredentialsOnCrossHostRedirect}
-	} else {
-		client = &http.Client{CheckRedirect: stripHubCredentialsOnCrossHostRedirect}
-	}
-
-	resp, err := client.Do(req)
-	if resp != nil {
-		defer resp.Body.Close()
-	}
-
-	if err == nil && resp != nil {
-		if resp.StatusCode == 200 {
-			log.WithFields(log.Fields{
-				"component":   "kerberos_hub",
-				"event":       "upload_authorized",
-				"status_code": resp.StatusCode,
-			}).Debug("Hub upload authorized")
-		} else {
-			log.WithFields(log.Fields{
-				"component":   "kerberos_hub",
-				"event":       "upload_rejected",
-				"status_code": resp.StatusCode,
-			}).Warn("Hub upload rejected")
-			return false, true, nil
-		}
-	}
-
-	// Now we know we are allowed to upload to the hub, we can start uploading.
-	req, err = http.NewRequest("POST", config.HubURI+"/storage/upload", file)
-	if err != nil {
-		log.WithError(err).WithFields(log.Fields{
-			"component": "kerberos_hub",
-			"event":     "upload_request_creation_failed",
-		}).Error("Failed to create Hub upload request")
-		return false, true, fmt.Errorf("create Hub upload request: %w", err)
-	}
-	req.Header.Set("Content-Type", "video/mp4")
-	req.Header.Set("X-Kerberos-Storage-FileName", fileName)
-	req.Header.Set("X-Kerberos-Storage-Capture", "IPCamera")
-	req.Header.Set("X-Kerberos-Storage-Device", config.Key)
-	req.Header.Set("X-Kerberos-Hub-PublicKey", config.HubKey)
-	req.Header.Set("X-Kerberos-Hub-PrivateKey", config.HubPrivateKey)
-	req.Header.Set("X-Kerberos-Hub-Region", config.S3.Region)
-	setQueuedRecordingMetadataHeaders(req.Header, fileName)
-	resp, err = client.Do(req)
-	if resp != nil {
-		defer resp.Body.Close()
-	}
-
-	if err == nil {
-		if resp != nil {
-			body, err := ioutil.ReadAll(resp.Body)
-			if err == nil {
-				if resp.StatusCode == 200 {
-					log.WithFields(log.Fields{
-						"component":   "kerberos_hub",
-						"event":       "upload_completed",
-						"status_code": resp.StatusCode,
-						"transport":   "http",
-					}).Info("Hub upload completed")
-					return true, true, nil
-				} else {
-					log.WithFields(log.Fields{
-						"component":      "kerberos_hub",
-						"event":          "upload_rejected",
-						"response_bytes": len(body),
-						"status_code":    resp.StatusCode,
-						"transport":      "http",
-					}).Warn("Hub upload rejected")
-					return false, true, nil
-				}
-			}
-		}
-	}
-
-	if err == nil {
-		err = errors.New("Hub upload failed without a response")
-	}
-	log.WithError(err).WithFields(log.Fields{
-		"component": "kerberos_hub",
-		"event":     "upload_failed",
-		"transport": "http",
-	}).Error("Hub upload failed")
-	return false, true, fmt.Errorf("Hub upload failed: %w", err)
-}
-
-// stripHubCredentialsOnCrossHostRedirect removes the custom Kerberos Hub
-// credential headers on a redirect that crosses to a different host. net/http
-// already strips the standard sensitive headers (Authorization, Cookie,
-// WWW-Authenticate) on a cross-host redirect, but it does NOT strip
-// custom-named headers, so without this the Hub private/public keys would be
-// forwarded to any host the configured HubURI redirects to.
-func stripHubCredentialsOnCrossHostRedirect(req *http.Request, via []*http.Request) error {
-	if len(via) == 0 {
-		return nil
-	}
-	if req.URL.Host != via[0].URL.Host {
-		req.Header.Del("X-Kerberos-Hub-PrivateKey")
-		req.Header.Del("X-Kerberos-Hub-PublicKey")
-	}
-	return nil
-}

machinery/src/cloud/kerberos_vault.go

@@ -1,297 +0,0 @@
-package cloud
-
-import (
-	"crypto/tls"
-	"errors"
-	"io"
-	"net/http"
-	"os"
-	"strconv"
-	"time"
-
-	"github.com/kerberos-io/agent/machinery/src/models"
-	log "github.com/sirupsen/logrus"
-)
-
-// We will count the number of retries we have done.
-// If we have done more than "kstorageRetryPolicy" retries, we will stop, and start sending to the secondary storage.
-var kstorageRetryCount = 0
-var kstorageRetryTimeout = time.Now().Unix()
-
-func UploadKerberosVault(configuration *models.Configuration, fileName string) (bool, bool, error) {
-
-	config := configuration.Config
-
-	if config.KStorage.AccessKey == "" ||
-		config.KStorage.SecretAccessKey == "" ||
-		config.KStorage.Directory == "" ||
-		config.KStorage.URI == "" {
-		err := "UploadKerberosVault: Kerberos Vault not properly configured"
-		log.Info(err)
-		return false, false, errors.New(err)
-	}
-
-	// If the recording no longer exists on disk there is nothing to upload.
-	// This can happen when the file was already removed (e.g. cleanup, or an
-	// earlier successful upload). Skip it so the watcher drops the marker
-	// instead of retrying indefinitely.
-	info, err := os.Stat("data/recordings/" + fileName)
-	if err != nil {
-		log.Info("UploadKerberosVault: skipping " + fileName + ", file doesn't exist anymore")
-		return false, false, nil
-	}
-	if info.Size() == 0 {
-		log.Warn("UploadKerberosVault: skipping " + fileName + ", recording is empty")
-		return false, false, nil
-	}
-
-	// timestamp_microseconds_instanceName_regionCoordinates_numberOfChanges_token
-	// 1564859471_6-474162_oprit_577-283-727-375_1153_27.mp4
-	// - Timestamp
-	// - Size + - + microseconds
-	// - device
-	// - Region
-	// - Number of changes
-	// - Token
-	// KerberosCloud, this means storage is disabled and proxy enabled.
-	log.WithFields(log.Fields{
-		"component": "kerberos_vault",
-		"event":     "upload_started",
-		"storage":   "primary",
-	}).Info("Vault upload started")
-
-	publicKey := config.KStorage.CloudKey
-	if config.HubKey != "" {
-		publicKey = config.HubKey
-	}
-
-	// We need to check if we are in a retry timeout.
-	if kstorageRetryTimeout <= time.Now().Unix() {
-		uploaded, responded, body, err := sendToVault(*config.KStorage, publicKey, config.Key, fileName, "UploadKerberosVault", "primary")
-		if uploaded {
-			kstorageRetryCount = 0
-			log.WithFields(log.Fields{
-				"component": "kerberos_vault",
-				"event":     "upload_completed",
-				"storage":   "primary",
-			}).Info("Vault upload completed")
-			return true, true, nil
-		}
-
-		if err != nil {
-			log.WithError(err).WithFields(log.Fields{
-				"component": "kerberos_vault",
-				"event":     "upload_failed",
-				"storage":   "primary",
-			}).Error("Vault upload failed")
-		} else {
-			log.WithFields(log.Fields{
-				"component":      "kerberos_vault",
-				"event":          "upload_rejected",
-				"response_bytes": len(body),
-				"storage":        "primary",
-			}).Warn("Vault upload rejected")
-		}
-
-		// We only advance the retry policy when the vault gave a definitive
-		// response (mirroring the original behaviour where transient network
-		// errors did not consume retries). When the retry count reaches the
-		// configured maximum we back off for the configured timeout.
-		if responded {
-			if kstorageRetryCount < config.KStorage.MaxRetries {
-				kstorageRetryCount = (kstorageRetryCount + 1)
-			}
-			if kstorageRetryCount == config.KStorage.MaxRetries {
-				kstorageRetryTimeout = time.Now().Add(time.Duration(config.KStorage.Timeout) * time.Second).Unix()
-			}
-		}
-	}
-
-	// We might need to check if we can upload to our secondary storage.
-	if config.KStorageSecondary.AccessKey == "" ||
-		config.KStorageSecondary.SecretAccessKey == "" ||
-		config.KStorageSecondary.Directory == "" ||
-		config.KStorageSecondary.URI == "" {
-		log.Info("UploadKerberosVault (Secondary): Secondary Kerberos Vault not properly configured.")
-	} else {
-
-		if kstorageRetryCount < config.KStorage.MaxRetries {
-			log.Info("UploadKerberosVault (Secondary): Do not upload to secondary storage, we are still in retry policy.")
-			return false, true, nil
-		}
-
-		log.WithFields(log.Fields{
-			"component": "kerberos_vault",
-			"event":     "upload_started",
-			"storage":   "secondary",
-		}).Info("Vault upload started")
-
-		uploaded, _, body, err := sendToVault(*config.KStorageSecondary, publicKey, config.Key, fileName, "UploadKerberosVault (Secondary)", "secondary")
-		if uploaded {
-			log.WithFields(log.Fields{
-				"component": "kerberos_vault",
-				"event":     "upload_completed",
-				"storage":   "secondary",
-			}).Info("Vault upload completed")
-			return true, true, nil
-		}
-
-		if err != nil {
-			log.WithError(err).WithFields(log.Fields{
-				"component": "kerberos_vault",
-				"event":     "upload_failed",
-				"storage":   "secondary",
-			}).Error("Vault upload failed")
-		} else {
-			log.WithFields(log.Fields{
-				"component":      "kerberos_vault",
-				"event":          "upload_rejected",
-				"response_bytes": len(body),
-				"storage":        "secondary",
-			}).Warn("Vault upload rejected")
-		}
-	}
-
-	return false, true, nil
-}
-
-// sendToVault uploads a single recording to one Kerberos Vault. When resumable
-// uploads are enabled (the default) it attempts the tus protocol first and, if
-// the vault does not expose a tus endpoint (older deployments), transparently
-// falls back to the legacy single-shot POST.
-//
-// It returns whether the upload succeeded, whether the vault gave a definitive
-// HTTP response (so the caller can advance its retry policy), a short message
-// for logging, and a transport error if any.
-func sendToVault(vault models.KStorage, publicKey, deviceKey, fileName, label, slot string) (bool, bool, string, error) {
-	if resumableUploadsEnabled() {
-		uploaded, responded, supported, body, err := uploadVaultResumable(vault, publicKey, deviceKey, fileName, label, slot)
-		if supported {
-			return uploaded, responded, body, err
-		}
-		log.Info(label + ": resumable (tus) endpoint not available, falling back to legacy upload")
-	}
-	return uploadVaultLegacy(vault, publicKey, deviceKey, fileName, label)
-}
-
-// uploadVaultLegacy performs the original single-request upload: the whole file
-// is sent as the body of a POST to {URI}/storage. Kept for backwards
-// compatibility with vault deployments that do not support resumable uploads.
-func uploadVaultLegacy(vault models.KStorage, publicKey, deviceKey, fileName, label string) (bool, bool, string, error) {
-	fullname := "data/recordings/" + fileName
-
-	file, err := os.Open(fullname)
-	if file != nil {
-		defer file.Close()
-	}
-	if err != nil {
-		msg := label + ": Upload Failed, file doesn't exists anymore"
-		log.Info(msg)
-		return false, false, "", errors.New(msg)
-	}
-
-	uri := vault.URI
-	for len(uri) > 0 && uri[len(uri)-1] == '/' {
-		uri = uri[:len(uri)-1]
-	}
-
-	req, err := http.NewRequest("POST", uri+"/storage", file)
-	if err != nil {
-		errorMessage := label + ": error reading request, " + uri + "/storage: " + err.Error()
-		log.Error(errorMessage)
-		return false, false, "", errors.New(errorMessage)
-	}
-	req.Header.Set("Content-Type", "video/mp4")
-	setVaultHeaders(req.Header, vault, publicKey, deviceKey, fileName)
-	setQueuedRecordingMetadataHeaders(req.Header, fileName)
-
-	client := newVaultHTTPClient(0)
-	resp, err := client.Do(req)
-	if resp != nil {
-		defer resp.Body.Close()
-	}
-	if err != nil {
-		return false, false, "", err
-	}
-
-	body, rerr := io.ReadAll(resp.Body)
-	if rerr != nil {
-		return false, false, "", rerr
-	}
-
-	if resp.StatusCode == 200 {
-		return true, true, resp.Status + ", " + string(body), nil
-	}
-	return false, true, resp.Status + ", " + string(body), nil
-}
-
-// setVaultHeaders sets the standard Kerberos Vault headers used by the legacy
-// single-POST upload.
-func setVaultHeaders(h http.Header, vault models.KStorage, publicKey, deviceKey, fileName string) {
-	h.Set("X-Kerberos-Storage-CloudKey", publicKey)
-	h.Set("X-Kerberos-Storage-AccessKey", vault.AccessKey)
-	h.Set("X-Kerberos-Storage-SecretAccessKey", vault.SecretAccessKey)
-	h.Set("X-Kerberos-Storage-Provider", vault.Provider)
-	h.Set("X-Kerberos-Storage-FileName", fileName)
-	h.Set("X-Kerberos-Storage-Device", deviceKey)
-	h.Set("X-Kerberos-Storage-Capture", "IPCamera")
-	h.Set("X-Kerberos-Storage-Directory", vault.Directory)
-}
-
-// newVaultHTTPClient builds an HTTP client honouring the AGENT_TLS_INSECURE
-// escape hatch. A timeout of 0 disables the *overall* client timeout, which is
-// required for streaming large upload bodies without capping the total transfer
-// time. Transport-level timeouts are still applied so that a lost network
-// connection (for example the internet being disconnected) fails reasonably
-// fast and the upload is retried, instead of the request hanging until the OS
-// TCP timeout (which can be many minutes) and blocking the whole upload loop.
-func newVaultHTTPClient(timeout time.Duration) *http.Client {
-	// Start from a clone of the default transport so we keep its sane dial and
-	// TLS-handshake timeouts, connection pooling and HTTP/2 support even when the
-	// AGENT_TLS_INSECURE escape hatch is enabled (a bare http.Transport would have
-	// no dial/handshake timeouts at all).
-	transport := http.DefaultTransport.(*http.Transport).Clone()
-
-	// ResponseHeaderTimeout bounds how long we wait for the vault's response
-	// headers *after* the request body has been fully written. It does not limit
-	// the time spent streaming the (potentially large) upload body, so big
-	// recordings still upload fine, but a vault/network that disappears while we
-	// wait for the acknowledgement is detected and the upload is retried instead
-	// of hanging indefinitely.
-	transport.ResponseHeaderTimeout = vaultResponseHeaderTimeout()
-
-	if os.Getenv("AGENT_TLS_INSECURE") == "true" {
-		if transport.TLSClientConfig == nil {
-			transport.TLSClientConfig = &tls.Config{}
-		}
-		transport.TLSClientConfig.InsecureSkipVerify = true
-	}
-
-	client := &http.Client{Transport: transport}
-	if timeout > 0 {
-		client.Timeout = timeout
-	}
-	return client
-}
-
-// vaultResponseHeaderTimeout returns the maximum time to wait for a vault's
-// response headers after the request body has been written. It defaults to 5
-// minutes — generous enough for the vault to persist/finalize a chunk or a full
-// recording to its storage provider — and can be tuned with the
-// AGENT_VAULT_RESPONSE_HEADER_TIMEOUT_SECONDS environment variable. A value of 0
-// (or a negative/invalid value) disables the timeout.
-func vaultResponseHeaderTimeout() time.Duration {
-	const def = 5 * time.Minute
-	v := os.Getenv("AGENT_VAULT_RESPONSE_HEADER_TIMEOUT_SECONDS")
-	if v == "" {
-		return def
-	}
-	n, err := strconv.Atoi(v)
-	if err != nil {
-		return def
-	}
-	if n <= 0 {
-		return 0
-	}
-	return time.Duration(n) * time.Second
-}

machinery/src/cloud/livehls.go

@@ -1,403 +0,0 @@
-package cloud
-
-import (
-	"os"
-	"time"
-
-	mqtt "github.com/eclipse/paho.mqtt.golang"
-
-	"github.com/kerberos-io/agent/machinery/src/cloud/livehls"
-	"github.com/kerberos-io/agent/machinery/src/models"
-	"github.com/kerberos-io/agent/machinery/src/packets"
-	log "github.com/sirupsen/logrus"
-)
-
-// hlsViewerTimeoutSeconds is how long the agent keeps shipping live HLS segments
-// after the last viewer keepalive. It is a few seconds longer than the segment
-// duration so a viewer whose keepalive is briefly delayed does not cause the
-// session to flap. When it lapses the session is torn down to stop wasting
-// upload bandwidth when nobody is watching.
-const hlsViewerTimeoutSeconds = 8
-
-// hlsReadyReannounceSeconds throttles how often the agent re-announces an
-// already-ready session over MQTT in response to viewer keepalives. The initial
-// "receive-hls-ready" is a one-shot fired when the first segment lands; a viewer
-// that connects or hard-refreshes after that (while the session is still alive)
-// missed it, so we re-announce on subsequent keepalives. Viewers dedupe by
-// session id, so a re-announce for a session they already play is a no-op. ~2s
-// gets a refreshed viewer playing well within its connection timeout without
-// spamming the control plane.
-const hlsReadyReannounceSeconds = 2
-
-// HandleLiveStreamHLS drives the live HLS producer. It mirrors HandleLiveStreamSD:
-// it reads the camera's packet stream from a Latest() cursor, and while a viewer
-// is active (kept alive via communication.HandleLiveHLS) it muxes the packets
-// into CMAF segments and ships them to hub-api, which stores each segment in an
-// ephemeral, short-TTL live window and serves the rolling playlist to viewers.
-//
-// A session is created lazily on the first keyframe seen while a viewer is active
-// and torn down once viewers go away, so an idle camera produces no live traffic.
-//
-// By default (AGENT_LIVE_HLS_PREWARM unset or != "false") the agent instead keeps
-// one long-lived session muxing continuously into a small in-memory ring buffer
-// while idle (uploading nothing) and, the moment a viewer arrives, flushes the
-// already-encoded init + most-recent segment(s) and starts uploading live. This
-// trades a little idle CPU for a near-instant "requesting stream", so viewers no
-// longer wait a full GOP for the first segment to be cut. Set
-// AGENT_LIVE_HLS_PREWARM=false to fall back to the lazy on-demand path above.
-func HandleLiveStreamHLS(
-	configuration *models.Configuration,
-	communication *models.Communication,
-	mqttClient mqtt.Client,
-	subStreamEnabled bool,
-	mainQueue *packets.Queue,
-	subQueue *packets.Queue,
-) {
-
-	log.Debug("cloud.HandleLiveStreamHLS(): started")
-
-	config := configuration.Config
-
-	if config.Offline == "true" {
-		log.Debug("cloud.HandleLiveStreamHLS(): stopping as Offline is enabled.")
-		return
-	}
-	if config.Capture.Liveview == "false" {
-		log.Debug("cloud.HandleLiveStreamHLS(): stopping as Liveview is disabled.")
-		return
-	}
-	if config.HubURI == "" || config.HubKey == "" {
-		log.Debug("cloud.HandleLiveStreamHLS(): stopping as the Hub is not configured (HubURI/HubKey).")
-		return
-	}
-
-	hubKey := config.HubKey
-	deviceId := config.Key
-
-	region := ""
-	if config.S3 != nil {
-		region = config.S3.Region
-	}
-
-	publisher := livehls.NewPublisher(livehls.PublisherConfig{
-		HubURI:        config.HubURI,
-		HubKey:        config.HubKey,
-		HubPrivateKey: config.HubPrivateKey,
-		Region:        region,
-		DeviceKey:     deviceId,
-	})
-
-	// The live session can be served from the main (high-resolution) or sub
-	// (low-resolution) stream and switched on demand. requestedQuality tracks the
-	// latest tier asked for over the keepalive; source holds the cursor plus the
-	// encoded parameter sets/dimensions for the stream currently being muxed.
-	// Encoded dimensions are only needed for the avcC fallback path (an SPS that
-	// mp4ff's strict parser rejects).
-	requestedQuality := models.StreamQualityAuto
-	useSub := models.SelectSubStreamForQuality(config, requestedQuality, subStreamEnabled)
-	source := buildHLSSource(config, mainQueue, subQueue, useSub)
-	log.Info("cloud.HandleLiveStreamHLS(): serving live HLS from the " + source.label + " stream")
-
-	// prewarm keeps a single long-lived session muxing into an in-memory ring
-	// buffer while idle and flushes it the instant a viewer arrives, eliminating
-	// the per-request GOP wait. Enabled by default; set AGENT_LIVE_HLS_PREWARM=false
-	// to fall back to the lazy on-demand path.
-	prewarm := os.Getenv("AGENT_LIVE_HLS_PREWARM") != "false"
-	if prewarm {
-		log.Info("cloud.HandleLiveStreamHLS(): live HLS prewarm ENABLED (set AGENT_LIVE_HLS_PREWARM=false to disable)")
-	} else {
-		log.Info("cloud.HandleLiveStreamHLS(): live HLS prewarm DISABLED (AGENT_LIVE_HLS_PREWARM=false)")
-	}
-
-	// lowLatency enables LL-HLS: each segment is sliced into CMAF parts shipped the
-	// instant they close and advertised via #EXT-X-PART, taking glass-to-glass HLS
-	// latency from ~4-6s down to ~1-2s. Enabled by default; set
-	// AGENT_LIVE_HLS_LOW_LATENCY=false to fall back to whole-segment HLS.
-	partTargetMs := uint64(0)
-	if os.Getenv("AGENT_LIVE_HLS_LOW_LATENCY") != "false" {
-		partTargetMs = livehls.DefaultPartTargetMs
-		log.Info("cloud.HandleLiveStreamHLS(): live HLS low-latency (LL-HLS) ENABLED (set AGENT_LIVE_HLS_LOW_LATENCY=false to disable)")
-	} else {
-		log.Info("cloud.HandleLiveStreamHLS(): live HLS low-latency (LL-HLS) DISABLED (AGENT_LIVE_HLS_LOW_LATENCY=false)")
-	}
-
-	var session *livehls.Session
-	lastViewerRequest := int64(0)
-	lastReadyAnnounce := int64(0)
-
-	var cursorError error
-	var pkt packets.Packet
-
-	for cursorError == nil {
-		pkt, cursorError = source.cursor.ReadPacket()
-		if cursorError != nil {
-			break
-		}
-
-		now := time.Now().Unix()
-		select {
-		case q := <-communication.HandleLiveHLS:
-			lastViewerRequest = now
-			if q != "" {
-				requestedQuality = q
-			}
-			// A keepalive may come from a viewer that just connected or hard-
-			// refreshed and therefore missed the one-shot readiness announcement
-			// fired when this session's first segment landed. Re-announce (throttled)
-			// so late/refreshed viewers learn the active session id; the frontend
-			// dedupes by session id, so this is a no-op for viewers already playing.
-			// UploadsActive() is always true for the on-demand path; for prewarm it
-			// suppresses a stale re-announce while idle (the flush-on-arrival path
-			// below announces once the buffer has actually been shipped).
-			if session != nil && session.IsReady() && session.UploadsActive() && now-lastReadyAnnounce >= hlsReadyReannounceSeconds {
-				publishHLSReady(configuration, mqttClient, hubKey, deviceId, session.SessionID())
-				lastReadyAnnounce = now
-			}
-		default:
-		}
-
-		// Switch the source stream when the requested quality now maps to the other
-		// stream. Tearing the current session down makes the producer rebuild the
-		// init segment and announce a fresh session id from the new stream, which the
-		// viewer re-attaches to.
-		if wantSub := models.SelectSubStreamForQuality(config, requestedQuality, subStreamEnabled); wantSub != useSub {
-			useSub = wantSub
-			if session != nil {
-				_ = session.Close()
-				session = nil
-			}
-			source = buildHLSSource(config, mainQueue, subQueue, useSub)
-			lastReadyAnnounce = 0
-			log.Info("cloud.HandleLiveStreamHLS(): switched live HLS to the " + source.label + " stream (quality=" + requestedQuality + ")")
-			continue
-		}
-
-		viewerActive := now-lastViewerRequest <= hlsViewerTimeoutSeconds
-
-		if prewarm {
-			// Keep one long-lived session muxing into the ring buffer. Create it on
-			// the first keyframe (so the buffer opens on a random-access point) and
-			// never tear it down for idleness; uploads, not muxing, are what we gate
-			// on viewer presence.
-			if session == nil {
-				if len(pkt.Data) == 0 || !pkt.IsVideo || !pkt.IsKeyFrame {
-					continue
-				}
-				session = livehls.NewSession(publisher, livehls.SessionOptions{
-					Codec:          pkt.Codec,
-					SPSNALUs:       source.sps,
-					PPSNALUs:       source.pps,
-					VPSNALUs:       source.vps,
-					Width:          source.width,
-					Height:         source.height,
-					PartTargetMs:   partTargetMs,
-					StartBuffering: true,
-				})
-				session.SetOnReady(func(sessionID string) {
-					log.WithFields(log.Fields{
-						"component":  "cloud/livehls",
-						"event":      "session_ready",
-						"session_id": sessionID,
-					}).Info("Live HLS session ready")
-					publishHLSReady(configuration, mqttClient, hubKey, deviceId, sessionID)
-					lastReadyAnnounce = time.Now().Unix()
-				})
-				session.SetOnFailure(func(sessionID, reason string) {
-					publishHLSFailure(configuration, mqttClient, hubKey, deviceId, sessionID, reason)
-				})
-				log.WithFields(log.Fields{
-					"component":  "cloud/livehls",
-					"event":      "session_prewarming",
-					"session_id": session.SessionID(),
-				}).Info("Prewarming live HLS session")
-			}
-
-			if viewerActive {
-				// Activating flushes the cached init + buffered segment(s). onReady
-				// announces the first-ever readiness; on a later re-activation it has
-				// already fired, so announce here (throttled, so the first activation
-				// does not double up) once the buffer has actually been shipped.
-				if session.SetUploadsActive(true) && session.IsReady() && now-lastReadyAnnounce >= hlsReadyReannounceSeconds {
-					publishHLSReady(configuration, mqttClient, hubKey, deviceId, session.SessionID())
-					lastReadyAnnounce = now
-				}
-			} else {
-				// No viewer: keep muxing into the buffer but stop uploading.
-				session.SetUploadsActive(false)
-			}
-
-			if len(pkt.Data) > 0 && pkt.IsVideo {
-				if err := session.WritePacket(pkt); err != nil {
-					log.Error("cloud.HandleLiveStreamHLS(): " + err.Error())
-				}
-			}
-			continue
-		}
-
-		if !viewerActive {
-			// No viewer: stop and discard the session so we stop shipping segments.
-			if session != nil {
-				_ = session.Close()
-				log.WithFields(log.Fields{
-					"component":  "cloud/livehls",
-					"event":      "session_stopped",
-					"reason":     "no_active_viewers",
-					"session_id": session.SessionID(),
-				}).Info("Live HLS session stopped")
-				session = nil
-			}
-			continue
-		}
-
-		if len(pkt.Data) == 0 || !pkt.IsVideo {
-			continue
-		}
-
-		// Start a session lazily, but only on a keyframe so the first segment opens
-		// on a random-access point.
-		if session == nil {
-			if !pkt.IsKeyFrame {
-				continue
-			}
-			session = livehls.NewSession(publisher, livehls.SessionOptions{
-				Codec:        pkt.Codec,
-				SPSNALUs:     source.sps,
-				PPSNALUs:     source.pps,
-				VPSNALUs:     source.vps,
-				Width:        source.width,
-				Height:       source.height,
-				PartTargetMs: partTargetMs,
-			})
-			session.SetOnReady(func(sessionID string) {
-				log.WithFields(log.Fields{
-					"component":  "cloud/livehls",
-					"event":      "session_ready",
-					"session_id": sessionID,
-				}).Info("Live HLS session ready")
-				publishHLSReady(configuration, mqttClient, hubKey, deviceId, sessionID)
-				lastReadyAnnounce = time.Now().Unix()
-			})
-			session.SetOnFailure(func(sessionID, reason string) {
-				publishHLSFailure(configuration, mqttClient, hubKey, deviceId, sessionID, reason)
-			})
-			log.WithFields(log.Fields{
-				"component":  "cloud/livehls",
-				"event":      "session_started",
-				"session_id": session.SessionID(),
-			}).Info("Live HLS session started")
-		}
-
-		if err := session.WritePacket(pkt); err != nil {
-			log.Error("cloud.HandleLiveStreamHLS(): " + err.Error())
-		}
-	}
-
-	if session != nil {
-		_ = session.Close()
-	}
-	log.Debug("cloud.HandleLiveStreamHLS(): finished")
-}
-
-// publishHLSReady announces, over MQTT, that a live HLS session is available so
-// viewers can load the rolling playlist hub-api serves for {device}/{session}.
-func publishHLSReady(configuration *models.Configuration, mqttClient mqtt.Client, hubKey, deviceId, sessionID string) {
-	valueMap := map[string]interface{}{
-		"session": sessionID,
-		"device":  deviceId,
-	}
-	message := models.Message{
-		Payload: models.Payload{
-			Action:   "receive-hls-ready",
-			DeviceId: deviceId,
-			Value:    valueMap,
-		},
-	}
-	payload, err := models.PackageMQTTMessage(configuration, message)
-	if err == nil {
-		mqttClient.Publish("kerberos/hub/"+hubKey, 0, false, payload)
-		log.WithFields(log.Fields{
-			"component":  "cloud/livehls",
-			"event":      "session_announced",
-			"session_id": sessionID,
-		}).Info("Live HLS session announced")
-	} else {
-		log.WithError(err).WithFields(log.Fields{
-			"component":  "cloud/livehls",
-			"event":      "session_announcement_failed",
-			"session_id": sessionID,
-		}).Error("Failed to package live HLS session announcement")
-	}
-}
-
-func publishHLSFailure(configuration *models.Configuration, mqttClient mqtt.Client, hubKey, deviceId, sessionID, reason string) {
-	valueMap := map[string]interface{}{
-		"session": sessionID,
-		"device":  deviceId,
-		"reason":  reason,
-	}
-	message := models.Message{
-		Payload: models.Payload{
-			Action:   "receive-hls-error",
-			DeviceId: deviceId,
-			Value:    valueMap,
-		},
-	}
-	payload, err := models.PackageMQTTMessage(configuration, message)
-	if err == nil {
-		mqttClient.Publish("kerberos/hub/"+hubKey, 0, false, payload)
-		log.WithFields(log.Fields{
-			"component":  "cloud/livehls",
-			"event":      "session_failure_announced",
-			"reason":     reason,
-			"session_id": sessionID,
-		}).Warn("Live HLS session failure announced")
-	} else {
-		log.WithError(err).WithFields(log.Fields{
-			"component":  "cloud/livehls",
-			"event":      "session_failure_announcement_failed",
-			"session_id": sessionID,
-		}).Error("Failed to package live HLS session failure")
-	}
-}
-
-// hlsStreamSource bundles everything the live HLS producer needs to mux one of
-// the camera's streams: the packet cursor it reads from plus the encoded
-// parameter sets and dimensions used to build that stream's init segment.
-type hlsStreamSource struct {
-	cursor *packets.QueueCursor
-	sps    [][]byte
-	pps    [][]byte
-	vps    [][]byte
-	width  uint16
-	height uint16
-	label  string
-}
-
-// buildHLSSource resolves the packet cursor and encoded parameter sets/dimensions
-// for the selected stream. useSub picks the sub (low-resolution) stream when one
-// is available; otherwise the main (high-resolution) stream is used. A fresh
-// Latest() cursor is created so muxing resumes from the live edge of the chosen
-// stream after a switch.
-func buildHLSSource(config models.Config, mainQueue, subQueue *packets.Queue, useSub bool) hlsStreamSource {
-	cam := config.Capture.IPCamera
-	if useSub && subQueue != nil {
-		return hlsStreamSource{
-			cursor: subQueue.Latest(),
-			sps:    cam.SubSPSNALUs,
-			pps:    cam.SubPPSNALUs,
-			vps:    cam.SubVPSNALUs,
-			width:  uint16(cam.SubWidth),
-			height: uint16(cam.SubHeight),
-			label:  "sub",
-		}
-	}
-	return hlsStreamSource{
-		cursor: mainQueue.Latest(),
-		sps:    cam.SPSNALUs,
-		pps:    cam.PPSNALUs,
-		vps:    cam.VPSNALUs,
-		width:  uint16(cam.Width),
-		height: uint16(cam.Height),
-		label:  "main",
-	}
-}

machinery/src/cloud/livehls/publisher.go

@@ -1,244 +0,0 @@
-// Package livehls implements the agent-side producer for live HLS streaming.
-//
-// It complements the recording pipeline: where recordings are muxed into one
-// fragmented MP4 and uploaded resumably (TUS) when complete, live HLS ships a
-// continuous series of small, independently-decodable CMAF segments to hub-api
-// the instant each is produced, so a browser can play a near-live HLS stream
-// without WebRTC/TURN (outbound HTTPS only).
-//
-// The wire contract (agent -> hub-api) intentionally mirrors the existing
-// header-based storage convention (X-Kerberos-Storage-Device / -FileName, plus
-// the Hub public/private key auth headers). hub-api authenticates the agent and
-// stores each segment in an ephemeral, short-TTL live window keyed by
-// {device}/{session}, which it serves straight back to the browser. The live
-// window is deliberately kept out of the vault and the recordings collection;
-// durable archival/DVR is a separate, later concern.
-//
-// Unlike recordings, live segments are NOT uploaded resumably: a 1-2s segment
-// that fails to upload is stale by the time a retry would land, so the publisher
-// is fire-and-forget and drops on failure (logged) rather than blocking the live
-// pipeline behind a retry/handshake.
-package livehls
-
-import (
-	"bytes"
-	"context"
-	"fmt"
-	"io"
-	"net/http"
-	"strconv"
-	"strings"
-	"time"
-
-	"github.com/kerberos-io/agent/machinery/src/video"
-	log "github.com/sirupsen/logrus"
-)
-
-const (
-	// liveIngestPath is the hub-api endpoint that accepts a single live segment
-	// (or the init segment) and stores it in the ephemeral live window. hub-api
-	// distinguishes init vs media segment and the object name via the
-	// X-Kerberos-Live-* headers below, keeping a single route (mirrors the
-	// existing /storage/upload convention).
-	liveIngestPath = "/storage/live"
-
-	// Object names within a session. The init segment (ftyp+moov) is uploaded
-	// once per session; media segments are seg-<sequence>.m4s.
-	initObjectName = "init.mp4"
-
-	contentTypeInit    = "video/mp4"
-	contentTypeSegment = "video/iso.segment"
-
-	// Header names for the live ingest contract.
-	headerHubPublicKey  = "X-Kerberos-Hub-PublicKey"
-	headerHubPrivateKey = "X-Kerberos-Hub-PrivateKey"
-	headerHubRegion     = "X-Kerberos-Hub-Region"
-	headerStorageDevice = "X-Kerberos-Storage-Device"
-	headerLiveSession   = "X-Kerberos-Live-Session"
-	headerLiveName      = "X-Kerberos-Live-Name"
-	headerLiveSequence  = "X-Kerberos-Live-Sequence"
-	headerLiveDuration  = "X-Kerberos-Live-Duration"
-	// Low-latency (LL-HLS) part headers. A part belongs to media segment
-	// X-Kerberos-Live-Sequence and is the X-Kerberos-Live-Part-th chunk within it;
-	// X-Kerberos-Live-Part-Independent flags a part that starts on a keyframe.
-	headerLivePart            = "X-Kerberos-Live-Part"
-	headerLivePartIndependent = "X-Kerberos-Live-Part-Independent"
-
-	// defaultPublishTimeout bounds a single segment upload. A live segment that
-	// cannot be delivered within roughly its own duration is stale, so the upload
-	// is abandoned (dropped) rather than allowed to back up the pipeline.
-	defaultPublishTimeout = 4 * time.Second
-	maxErrorResponseBytes = 4 << 10
-)
-
-// PublisherConfig carries the hub endpoint and credentials needed to ship live
-// segments. It is populated from the agent's models.Config (HubURI/HubKey/...).
-type PublisherConfig struct {
-	HubURI        string // base hub-api URL, e.g. https://api.hub.example.com
-	HubKey        string // Hub public key (X-Kerberos-Hub-PublicKey)
-	HubPrivateKey string // Hub private key (X-Kerberos-Hub-PrivateKey)
-	Region        string // storage region (X-Kerberos-Hub-Region), may be empty
-	DeviceKey     string // device/camera key (X-Kerberos-Storage-Device)
-
-	// Timeout optionally overrides defaultPublishTimeout (used by tests).
-	Timeout time.Duration
-	// HTTPClient optionally injects a client (used by tests). When nil a
-	// redirect-credential-stripping client is created.
-	HTTPClient *http.Client
-}
-
-// Publisher ships init and media segments to hub-api over plain HTTP POST.
-//
-// It is safe for sequential use from a single live-stream goroutine. Methods are
-// fire-and-forget: they return an error for the caller to log, but the caller is
-// expected to continue (drop-on-fail) rather than retry.
-type Publisher struct {
-	cfg    PublisherConfig
-	client *http.Client
-}
-
-// NewPublisher builds a Publisher. The HTTP client strips the Hub credential
-// headers on a cross-host redirect (net/http does this for standard auth headers
-// but not custom-named ones), matching the recording upload client.
-func NewPublisher(cfg PublisherConfig) *Publisher {
-	client := cfg.HTTPClient
-	if client == nil {
-		timeout := cfg.Timeout
-		if timeout <= 0 {
-			timeout = defaultPublishTimeout
-		}
-		client = &http.Client{
-			Timeout:       timeout,
-			CheckRedirect: stripHubCredentialsOnCrossHostRedirect,
-		}
-	}
-	return &Publisher{cfg: cfg, client: client}
-}
-
-// PublishInit uploads the session's init segment (ftyp+moov). It must be called
-// (and succeed) before the player can use any media segment, so the caller
-// should treat a failure here as "session not yet established" and retry on the
-// next init opportunity rather than shipping media segments blindly.
-func (p *Publisher) PublishInit(ctx context.Context, sessionID string, data []byte) error {
-	return p.post(ctx, postParams{
-		sessionID:   sessionID,
-		name:        initObjectName,
-		contentType: contentTypeInit,
-		body:        data,
-	})
-}
-
-// PublishSegment uploads one media segment (styp+moof+mdat). The segment's
-// sequence number and duration travel in headers so hub-api can update the
-// rolling playlist window without parsing the box structure.
-func (p *Publisher) PublishSegment(ctx context.Context, sessionID string, seg video.LiveSegment) error {
-	return p.post(ctx, postParams{
-		sessionID:   sessionID,
-		name:        fmt.Sprintf("seg-%d.m4s", seg.SequenceNumber),
-		sequence:    seg.SequenceNumber,
-		durationMs:  seg.DurationMs,
-		hasSegment:  true,
-		contentType: contentTypeSegment,
-		body:        seg.Data,
-	})
-}
-
-// PublishPart uploads one CMAF partial segment (LL-HLS). The part is named
-// seg-<segment>.<part>.m4s and carries its segment sequence, part index,
-// independence flag and duration in headers so hub-api can advertise it via
-// #EXT-X-PART and reconstruct the full segment by concatenating its parts.
-func (p *Publisher) PublishPart(ctx context.Context, sessionID string, part video.LivePart) error {
-	return p.post(ctx, postParams{
-		sessionID:   sessionID,
-		name:        fmt.Sprintf("seg-%d.%d.m4s", part.SegmentSeq, part.PartIndex),
-		sequence:    part.SegmentSeq,
-		durationMs:  part.DurationMs,
-		partIndex:   part.PartIndex,
-		independent: part.Independent,
-		hasPart:     true,
-		contentType: contentTypeSegment,
-		body:        part.Data,
-	})
-}
-
-type postParams struct {
-	sessionID   string
-	name        string
-	sequence    uint32
-	durationMs  uint64
-	hasSegment  bool
-	partIndex   uint32
-	independent bool
-	hasPart     bool
-	contentType string
-	body        []byte
-}
-
-// post performs a single fire-and-forget upload to the live ingest endpoint.
-func (p *Publisher) post(ctx context.Context, params postParams) error {
-	if p.cfg.HubURI == "" {
-		return fmt.Errorf("livehls: HubURI not configured")
-	}
-	if params.sessionID == "" {
-		return fmt.Errorf("livehls: empty session id")
-	}
-
-	url := strings.TrimRight(p.cfg.HubURI, "/") + liveIngestPath
-	req, err := http.NewRequestWithContext(ctx, http.MethodPost, url, bytes.NewReader(params.body))
-	if err != nil {
-		return fmt.Errorf("livehls: build request: %w", err)
-	}
-
-	req.Header.Set("Content-Type", params.contentType)
-	req.Header.Set(headerStorageDevice, p.cfg.DeviceKey)
-	req.Header.Set(headerLiveSession, params.sessionID)
-	req.Header.Set(headerLiveName, params.name)
-	if params.hasSegment || params.hasPart {
-		req.Header.Set(headerLiveSequence, strconv.FormatUint(uint64(params.sequence), 10))
-		req.Header.Set(headerLiveDuration, strconv.FormatUint(params.durationMs, 10))
-	}
-	if params.hasPart {
-		req.Header.Set(headerLivePart, strconv.FormatUint(uint64(params.partIndex), 10))
-		independent := "0"
-		if params.independent {
-			independent = "1"
-		}
-		req.Header.Set(headerLivePartIndependent, independent)
-	}
-	req.Header.Set(headerHubPublicKey, p.cfg.HubKey)
-	req.Header.Set(headerHubPrivateKey, p.cfg.HubPrivateKey)
-	req.Header.Set(headerHubRegion, p.cfg.Region)
-
-	resp, err := p.client.Do(req)
-	if err != nil {
-		return fmt.Errorf("livehls: upload %s: %w", params.name, err)
-	}
-	defer resp.Body.Close()
-
-	if resp.StatusCode < 200 || resp.StatusCode >= 300 {
-		body, _ := io.ReadAll(io.LimitReader(resp.Body, maxErrorResponseBytes))
-		return fmt.Errorf("livehls: upload %s rejected with status %d (%d response bytes)", params.name, resp.StatusCode, len(body))
-	}
-	log.WithFields(log.Fields{
-		"component":  "cloud/livehls",
-		"event":      "object_uploaded",
-		"object":     params.name,
-		"session_id": params.sessionID,
-	}).Trace("Live HLS object uploaded")
-	return nil
-}
-
-// stripHubCredentialsOnCrossHostRedirect removes the Hub credential headers when
-// a redirect crosses to a different host. net/http strips standard sensitive
-// headers on a cross-host redirect but not custom-named ones, so without this the
-// Hub keys could leak to a redirect target.
-func stripHubCredentialsOnCrossHostRedirect(req *http.Request, via []*http.Request) error {
-	if len(via) == 0 {
-		return nil
-	}
-	if req.URL.Host != via[0].URL.Host {
-		req.Header.Del(headerHubPrivateKey)
-		req.Header.Del(headerHubPublicKey)
-	}
-	return nil
-}

machinery/src/cloud/livehls/publisher_test.go

@@ -1,332 +0,0 @@
-package livehls
-
-import (
-	"context"
-	"io"
-	"net/http"
-	"net/http/httptest"
-	"strings"
-	"sync"
-	"testing"
-	"time"
-
-	"github.com/kerberos-io/agent/machinery/src/packets"
-	"github.com/kerberos-io/agent/machinery/src/video"
-)
-
-// captured records one received upload for assertions.
-type captured struct {
-	path        string
-	method      string
-	contentType string
-	device      string
-	session     string
-	name        string
-	sequence    string
-	duration    string
-	hubPublic   string
-	hubPrivate  string
-	region      string
-	body        []byte
-}
-
-// newCapturingServer returns an httptest server that records every upload and
-// replies with the given status code.
-func newCapturingServer(t *testing.T, status int) (*httptest.Server, *[]captured, *sync.Mutex) {
-	t.Helper()
-	var mu sync.Mutex
-	var got []captured
-	srv := httptest.NewServer(http.HandlerFunc(func(w http.ResponseWriter, r *http.Request) {
-		body, _ := io.ReadAll(r.Body)
-		mu.Lock()
-		got = append(got, captured{
-			path:        r.URL.Path,
-			method:      r.Method,
-			contentType: r.Header.Get("Content-Type"),
-			device:      r.Header.Get(headerStorageDevice),
-			session:     r.Header.Get(headerLiveSession),
-			name:        r.Header.Get(headerLiveName),
-			sequence:    r.Header.Get(headerLiveSequence),
-			duration:    r.Header.Get(headerLiveDuration),
-			hubPublic:   r.Header.Get(headerHubPublicKey),
-			hubPrivate:  r.Header.Get(headerHubPrivateKey),
-			region:      r.Header.Get(headerHubRegion),
-			body:        body,
-		})
-		mu.Unlock()
-		w.WriteHeader(status)
-	}))
-	t.Cleanup(srv.Close)
-	return srv, &got, &mu
-}
-
-func testPublisher(hubURI string) *Publisher {
-	return NewPublisher(PublisherConfig{
-		HubURI:        hubURI,
-		HubKey:        "pub-key",
-		HubPrivateKey: "priv-key",
-		Region:        "eu-west",
-		DeviceKey:     "cam-1",
-		Timeout:       2 * time.Second,
-	})
-}
-
-func TestPublisherPublishInitSendsContractHeaders(t *testing.T) {
-	srv, got, mu := newCapturingServer(t, http.StatusOK)
-	p := testPublisher(srv.URL)
-
-	if err := p.PublishInit(context.Background(), "sess-1", []byte("INITBYTES")); err != nil {
-		t.Fatalf("PublishInit: %v", err)
-	}
-
-	mu.Lock()
-	defer mu.Unlock()
-	if len(*got) != 1 {
-		t.Fatalf("server received %d requests, want 1", len(*got))
-	}
-	c := (*got)[0]
-	if c.method != http.MethodPost {
-		t.Errorf("method=%s, want POST", c.method)
-	}
-	if c.path != liveIngestPath {
-		t.Errorf("path=%s, want %s", c.path, liveIngestPath)
-	}
-	if c.contentType != contentTypeInit {
-		t.Errorf("content-type=%s, want %s", c.contentType, contentTypeInit)
-	}
-	if c.device != "cam-1" {
-		t.Errorf("device=%s, want cam-1", c.device)
-	}
-	if c.session != "sess-1" {
-		t.Errorf("session=%s, want sess-1", c.session)
-	}
-	if c.name != initObjectName {
-		t.Errorf("name=%s, want %s", c.name, initObjectName)
-	}
-	if c.hubPublic != "pub-key" || c.hubPrivate != "priv-key" || c.region != "eu-west" {
-		t.Errorf("auth headers wrong: pub=%q priv=%q region=%q", c.hubPublic, c.hubPrivate, c.region)
-	}
-	if string(c.body) != "INITBYTES" {
-		t.Errorf("body=%q, want INITBYTES", string(c.body))
-	}
-	// init must NOT carry segment-only headers.
-	if c.sequence != "" || c.duration != "" {
-		t.Errorf("init should not send sequence/duration, got seq=%q dur=%q", c.sequence, c.duration)
-	}
-}
-
-func TestPublisherPublishSegmentSendsSequenceAndDuration(t *testing.T) {
-	srv, got, mu := newCapturingServer(t, http.StatusOK)
-	p := testPublisher(srv.URL)
-
-	seg := video.LiveSegment{SequenceNumber: 7, DurationMs: 1960, Data: []byte("SEGMENT")}
-	if err := p.PublishSegment(context.Background(), "sess-9", seg); err != nil {
-		t.Fatalf("PublishSegment: %v", err)
-	}
-
-	mu.Lock()
-	defer mu.Unlock()
-	c := (*got)[0]
-	if c.contentType != contentTypeSegment {
-		t.Errorf("content-type=%s, want %s", c.contentType, contentTypeSegment)
-	}
-	if c.name != "seg-7.m4s" {
-		t.Errorf("name=%s, want seg-7.m4s", c.name)
-	}
-	if c.sequence != "7" {
-		t.Errorf("sequence=%s, want 7", c.sequence)
-	}
-	if c.duration != "1960" {
-		t.Errorf("duration=%s, want 1960", c.duration)
-	}
-	if string(c.body) != "SEGMENT" {
-		t.Errorf("body=%q, want SEGMENT", string(c.body))
-	}
-}
-
-func TestPublisherReturnsErrorOnNon2xx(t *testing.T) {
-	srv := httptest.NewServer(http.HandlerFunc(func(w http.ResponseWriter, _ *http.Request) {
-		w.WriteHeader(http.StatusBadRequest)
-		_, _ = w.Write([]byte(`{"error":true,"data":"No user found with this public and private key."}`))
-	}))
-	t.Cleanup(srv.Close)
-	p := testPublisher(srv.URL)
-
-	err := p.PublishSegment(context.Background(), "s", video.LiveSegment{SequenceNumber: 1, Data: []byte("x")})
-	if err == nil {
-		t.Fatal("expected an error on 400 response")
-	}
-	if !strings.Contains(err.Error(), "status 400") || !strings.Contains(err.Error(), "71 response bytes") {
-		t.Fatalf("error = %q, want status code and response size", err)
-	}
-	if strings.Contains(err.Error(), "No user found with this public and private key") {
-		t.Fatalf("error exposed Hub response body: %q", err)
-	}
-}
-
-func TestPublisherErrorsWithoutHubURI(t *testing.T) {
-	p := NewPublisher(PublisherConfig{DeviceKey: "cam"})
-	if err := p.PublishInit(context.Background(), "s", []byte("x")); err == nil {
-		t.Fatal("expected error when HubURI is empty")
-	}
-}
-
-// makeAnnexBVideoPacket builds a synthetic capture packet carrying one Annex B
-// H.264 access unit at the given decode time (ms).
-func makeAnnexBVideoPacket(isKey bool, timeMs int64) packets.Packet {
-	nalType := byte(0x01)
-	if isKey {
-		nalType = 0x65
-	}
-	data := []byte{0x00, 0x00, 0x00, 0x01, nalType}
-	for i := 0; i < 80; i++ {
-		data = append(data, byte(i))
-	}
-	return packets.Packet{
-		IsVideo:    true,
-		IsKeyFrame: isKey,
-		Codec:      "H264",
-		Data:       data,
-		TimeLegacy: time.Duration(timeMs) * time.Millisecond,
-	}
-}
-
-func TestSessionShipsInitThenSegmentsAndFiresReady(t *testing.T) {
-	srv, got, mu := newCapturingServer(t, http.StatusOK)
-	p := testPublisher(srv.URL)
-
-	sess := NewSession(p, SessionOptions{
-		Codec:           "H264",
-		SPSNALUs:        [][]byte{liveTestSPSForSession()},
-		PPSNALUs:        [][]byte{{0x68, 0xce, 0x38, 0x80}},
-		Width:           640,
-		Height:          480,
-		TargetSegmentMs: 2000,
-	})
-
-	var readyCalls int
-	var readySession string
-	sess.SetOnReady(func(id string) {
-		readyCalls++
-		readySession = id
-	})
-
-	// 4 GOPs of 25 frames @ 40ms = 1s GOPs => with 2s target, 2 segments emitted
-	// during streaming and a final one on Close.
-	const gopFrames, gops = 25, 4
-	for i := 0; i < gopFrames*gops; i++ {
-		isKey := i%gopFrames == 0
-		pkt := makeAnnexBVideoPacket(isKey, int64(i*40))
-		if err := sess.WritePacket(pkt); err != nil {
-			t.Fatalf("WritePacket(%d): %v", i, err)
-		}
-	}
-	// A non-video packet must be ignored.
-	if err := sess.WritePacket(packets.Packet{IsAudio: true, Data: []byte{1, 2, 3}}); err != nil {
-		t.Fatalf("WritePacket(audio): %v", err)
-	}
-	if err := sess.Close(); err != nil {
-		t.Fatalf("Close: %v", err)
-	}
-
-	mu.Lock()
-	defer mu.Unlock()
-
-	var initCount, segCount int
-	for _, c := range *got {
-		if c.name == initObjectName {
-			initCount++
-			if string(c.body[4:8]) != "ftyp" {
-				t.Errorf("init body is not an ftyp box: % x", c.body[:12])
-			}
-		} else {
-			segCount++
-			if c.session != sess.SessionID() {
-				t.Errorf("segment session=%s, want %s", c.session, sess.SessionID())
-			}
-		}
-	}
-	if initCount != 1 {
-		t.Errorf("init uploaded %d times, want exactly 1", initCount)
-	}
-	if segCount < 2 {
-		t.Errorf("got %d segment uploads, want >= 2", segCount)
-	}
-	if readyCalls != 1 {
-		t.Errorf("OnReady fired %d times, want exactly 1", readyCalls)
-	}
-	if readySession != sess.SessionID() {
-		t.Errorf("OnReady session=%s, want %s", readySession, sess.SessionID())
-	}
-}
-
-func TestSessionRetriesInitWhenFirstAttemptFails(t *testing.T) {
-	// Server fails the first N requests, then succeeds. This proves init is
-	// re-attempted (not dropped) so the session can still establish.
-	var mu sync.Mutex
-	var inits, segs int
-	failFirst := 1
-	srv := httptest.NewServer(http.HandlerFunc(func(w http.ResponseWriter, r *http.Request) {
-		mu.Lock()
-		defer mu.Unlock()
-		name := r.Header.Get(headerLiveName)
-		if name == initObjectName {
-			inits++
-			if inits <= failFirst {
-				w.WriteHeader(http.StatusBadGateway)
-				return
-			}
-		} else {
-			segs++
-		}
-		w.WriteHeader(http.StatusOK)
-	}))
-	t.Cleanup(srv.Close)
-
-	sess := NewSession(testPublisher(srv.URL), SessionOptions{
-		Codec:    "H264",
-		SPSNALUs: [][]byte{liveTestSPSForSession()},
-		PPSNALUs: [][]byte{{0x68, 0xce, 0x38, 0x80}},
-		Width:    640,
-		Height:   480,
-	})
-
-	var ready int
-	var failures int
-	var failureReason string
-	sess.SetOnReady(func(string) { ready++ })
-	sess.SetOnFailure(func(_ string, reason string) {
-		failures++
-		failureReason = reason
-	})
-
-	for i := 0; i < 60; i++ {
-		isKey := i%25 == 0
-		if err := sess.WritePacket(makeAnnexBVideoPacket(isKey, int64(i*40))); err != nil {
-			t.Fatalf("WritePacket(%d): %v", i, err)
-		}
-	}
-	if err := sess.Close(); err != nil {
-		t.Fatalf("Close: %v", err)
-	}
-
-	mu.Lock()
-	defer mu.Unlock()
-	if inits < 2 {
-		t.Errorf("init attempted %d times, want >= 2 (first failed then retried)", inits)
-	}
-	if segs < 1 {
-		t.Errorf("no segments delivered after init recovered (segs=%d)", segs)
-	}
-	if ready != 1 {
-		t.Errorf("OnReady fired %d times, want 1", ready)
-	}
-	if failures != 1 || failureReason != "init-upload-failed" {
-		t.Errorf("OnFailure = %d/%q, want 1/init-upload-failed", failures, failureReason)
-	}
-}
-
-// liveTestSPSForSession is the known-good baseline SPS reused across tests.
-func liveTestSPSForSession() []byte {
-	return []byte{0x67, 0x42, 0xc0, 0x1e, 0xd9, 0x00, 0xa0, 0x47, 0xfe, 0xc8}
-}

machinery/src/cloud/livehls/session.go

@@ -1,533 +0,0 @@
-package livehls
-
-import (
-	"context"
-	"crypto/rand"
-	"encoding/hex"
-	"fmt"
-	"sync"
-	"time"
-
-	"github.com/kerberos-io/agent/machinery/src/packets"
-	"github.com/kerberos-io/agent/machinery/src/video"
-	log "github.com/sirupsen/logrus"
-)
-
-// DefaultTargetSegmentMs is the nominal live segment length. ~2s keeps standard
-// HLS latency reasonable (a player typically buffers ~3 segments) while staying
-// large enough that per-segment HTTP overhead is negligible.
-const DefaultTargetSegmentMs = 2000
-
-// DefaultPartTargetMs is the nominal LL-HLS part length used when low latency is
-// enabled. ~300ms parts yield ~6-7 parts per 2s segment; with the playlist's
-// PART-HOLD-BACK at ~3x the part target this lands glass-to-glass latency around
-// 1-2s (versus ~4-6s for whole-segment HLS).
-const DefaultPartTargetMs = 300
-
-// Session ties a video.LiveSegmenter to a Publisher: it converts capture packets
-// into CMAF segments and ships each one to hub-api. Exactly one init segment is
-// delivered per session (re-attempted until it lands), after which media
-// segments are published and the OnReady signal fires once so the control plane
-// (MQTT) can tell viewers the live playlist exists.
-//
-// A Session is driven from a single goroutine (the live-stream loop); its methods
-// are not safe for concurrent use except SessionID, which is immutable.
-type Session struct {
-	id        string
-	publisher *Publisher
-	segmenter *video.LiveSegmenter
-
-	// newContext produces the per-upload context (timeout). Overridable in tests.
-	newContext func() (context.Context, context.CancelFunc)
-
-	mu            sync.Mutex
-	initBytes     []byte
-	initPublished bool
-	// lastInitAt is when the init segment was last (re)uploaded. The init is
-	// re-sent periodically so its short TTL in the hub live window never lapses
-	// mid-session; see refreshInitIfStale.
-	lastInitAt   time.Time
-	readyFired   bool
-	onReady      func(sessionID string)
-	failureFired bool
-	onFailure    func(sessionID, reason string)
-
-	// uploadsActive gates whether the init and completed segments are shipped to
-	// hub-api. It is true for the default on-demand path. The prewarm path starts
-	// it false so the session keeps muxing into bufferedSegments without producing
-	// any live traffic until a viewer actually arrives; see SetUploadsActive.
-	uploadsActive bool
-	// bufferedSegments is the in-memory ring buffer (the most recent
-	// prewarmMaxBufferedSegments segments) kept while uploadsActive is false, so a
-	// viewer that arrives can be served an already-encoded segment immediately
-	// instead of waiting a full GOP for the next one to be cut.
-	bufferedSegments []video.LiveSegment
-	// bufferedParts is the LL-HLS counterpart of bufferedSegments: while idle it
-	// retains the parts of the most recent (prewarmMaxBufferedSegments+1) segments,
-	// pruned a WHOLE segment at a time so a flushed segment is never partial.
-	bufferedParts []video.LivePart
-}
-
-// SessionOptions configures a live HLS session.
-type SessionOptions struct {
-	Codec           string   // "H264" or "H265"
-	SPSNALUs        [][]byte // parameter sets (raw or Annex B)
-	PPSNALUs        [][]byte //
-	VPSNALUs        [][]byte // H.265 only
-	Width           uint16   // encoded width (for the avcC fallback path)
-	Height          uint16   // encoded height
-	TargetSegmentMs uint64   // 0 => DefaultTargetSegmentMs
-	// PartTargetMs, when > 0, enables LL-HLS: each segment is additionally sliced
-	// into ~PartTargetMs CMAF parts that are published (and advertised via
-	// #EXT-X-PART) the instant they close, for ~1-2s glass-to-glass latency. 0
-	// keeps the classic whole-segment path.
-	PartTargetMs uint64
-	// StartBuffering starts the session in prewarm (buffer-only) mode: it muxes
-	// segments into an in-memory ring buffer but uploads nothing until
-	// SetUploadsActive(true) is called. Default false => uploads are live
-	// immediately (the on-demand path's behaviour).
-	StartBuffering bool
-}
-
-// NewSession builds a session with a fresh random id and wires the segmenter's
-// init/segment callbacks to the publisher.
-func NewSession(publisher *Publisher, opts SessionOptions) *Session {
-	target := opts.TargetSegmentMs
-	if target == 0 {
-		target = DefaultTargetSegmentMs
-	}
-	seg := video.NewLiveSegmenter(opts.Codec, opts.SPSNALUs, opts.PPSNALUs, opts.VPSNALUs, target)
-	seg.SetDimensions(opts.Width, opts.Height)
-	if opts.PartTargetMs > 0 {
-		seg.EnableLowLatency(opts.PartTargetMs)
-	}
-
-	s := &Session{
-		id:        newSessionID(),
-		publisher: publisher,
-		segmenter: seg,
-		// Uploads are live by default; the prewarm path opts into buffer-only mode.
-		uploadsActive: !opts.StartBuffering,
-		newContext: func() (context.Context, context.CancelFunc) {
-			return context.WithTimeout(context.Background(), defaultPublishTimeout)
-		},
-	}
-
-	// The segmenter emits the init segment exactly once; capture it and try to
-	// ship it. Failures here are non-fatal - publishInitIfNeeded re-attempts
-	// before the next media segment so a transient hub hiccup at startup does not
-	// permanently break the session.
-	seg.OnInit = func(initBytes []byte) error {
-		s.mu.Lock()
-		s.initBytes = append([]byte(nil), initBytes...)
-		active := s.uploadsActive
-		s.mu.Unlock()
-		// While prewarming we cache the init in memory but ship nothing; it is
-		// uploaded on the first SetUploadsActive(true) flush.
-		if active {
-			s.publishInitIfNeeded()
-		}
-		return nil
-	}
-
-	// Each completed media segment is shipped. We only publish a segment once the
-	// init segment has landed (a media segment is useless without it), and we fire
-	// OnReady after the first successfully shipped segment.
-	seg.OnSegment = func(segment video.LiveSegment) error {
-		s.mu.Lock()
-		active := s.uploadsActive
-		s.mu.Unlock()
-		if !active {
-			// Prewarm: retain the most recent segments in memory but upload nothing
-			// until a viewer arrives (SetUploadsActive flushes them).
-			s.bufferSegment(segment)
-			return nil
-		}
-		if !s.publishInitIfNeeded() {
-			log.WithFields(log.Fields{
-				"component":        "cloud/livehls",
-				"event":            "segment_dropped",
-				"reason":           "init_unavailable",
-				"segment_sequence": segment.SequenceNumber,
-				"session_id":       s.id,
-			}).Warn("Dropping live HLS segment")
-			return nil
-		}
-		ctx, cancel := s.newContext()
-		defer cancel()
-		if err := s.publisher.PublishSegment(ctx, s.id, segment); err != nil {
-			log.WithError(err).WithFields(log.Fields{
-				"component":        "cloud/livehls",
-				"event":            "segment_upload_failed",
-				"segment_sequence": segment.SequenceNumber,
-				"session_id":       s.id,
-			}).Warn("Failed to upload live HLS segment")
-			s.fireFailureOnce("segment-upload-failed")
-			return nil
-		}
-		s.fireReadyOnce()
-		// Keep the (write-once) init segment from ageing out of the live window
-		// while the session is still producing media.
-		s.refreshInitIfStale()
-		return nil
-	}
-
-	// In LL-HLS mode the segmenter emits parts (not whole segments); ship each one
-	// the instant it closes. Mirrors OnSegment: buffer while prewarming, otherwise
-	// publish after the init has landed and fire OnReady on the first part.
-	if opts.PartTargetMs > 0 {
-		seg.OnPart = func(part video.LivePart) error {
-			s.mu.Lock()
-			active := s.uploadsActive
-			s.mu.Unlock()
-			if !active {
-				s.bufferPart(part)
-				return nil
-			}
-			if !s.publishInitIfNeeded() {
-				log.WithFields(log.Fields{
-					"component":        "cloud/livehls",
-					"event":            "part_dropped",
-					"part_index":       part.PartIndex,
-					"reason":           "init_unavailable",
-					"segment_sequence": part.SegmentSeq,
-					"session_id":       s.id,
-				}).Warn("Dropping live HLS part")
-				return nil
-			}
-			ctx, cancel := s.newContext()
-			defer cancel()
-			if err := s.publisher.PublishPart(ctx, s.id, part); err != nil {
-				log.WithError(err).WithFields(log.Fields{
-					"component":        "cloud/livehls",
-					"event":            "part_upload_failed",
-					"part_index":       part.PartIndex,
-					"segment_sequence": part.SegmentSeq,
-					"session_id":       s.id,
-				}).Warn("Failed to upload live HLS part")
-				s.fireFailureOnce("part-upload-failed")
-				return nil
-			}
-			s.fireReadyOnce()
-			s.refreshInitIfStale()
-			return nil
-		}
-	}
-
-	return s
-}
-
-// SessionID returns the immutable session identifier used in object keys and the
-// MQTT ready signal.
-func (s *Session) SessionID() string { return s.id }
-
-// IsReady reports whether the session has delivered its init segment and at
-// least one media segment, i.e. the playlist hub-api serves is now playable. It
-// lets the live-stream loop re-announce "receive-hls-ready" to viewers that join
-// or hard-refresh after the initial one-shot signal (which they would otherwise
-// never receive, leaving the stream blank until the session is recreated).
-func (s *Session) IsReady() bool {
-	s.mu.Lock()
-	defer s.mu.Unlock()
-	return s.readyFired
-}
-
-// SetOnReady registers a callback fired exactly once, after the first media
-// segment has been successfully delivered. Used to publish the MQTT
-// "receive-hls-ready" signal so viewers can load the playlist.
-func (s *Session) SetOnReady(fn func(sessionID string)) {
-	s.mu.Lock()
-	s.onReady = fn
-	s.mu.Unlock()
-}
-
-// SetOnFailure registers a one-shot callback for startup upload failures. The
-// reason is a fixed code rather than an HTTP response body, so credentials or
-// server details cannot leak through MQTT diagnostics.
-func (s *Session) SetOnFailure(fn func(sessionID, reason string)) {
-	s.mu.Lock()
-	s.onFailure = fn
-	s.mu.Unlock()
-}
-
-// prewarmMaxBufferedSegments is how many of the most recent completed segments
-// the prewarm path keeps in memory while idle and flushes to a viewer on arrival.
-// One segment keeps startup instant (the viewer immediately gets a playable
-// segment) while starting as close to the live edge as possible, so the HLS view
-// tracks the WebRTC/live edge instead of opening several seconds behind; hls.js
-// then converges to the edge via maxLiveSyncPlaybackRate. Raising it trades
-// latency-from-live for a little more startup cushion.
-const prewarmMaxBufferedSegments = 1
-
-// SetUploadsActive toggles whether the session ships its init and segments to
-// hub-api, and reports whether this call flipped it from inactive to active.
-//
-// While uploads are inactive the session keeps muxing capture packets into an
-// in-memory ring buffer (the cached init plus the most recent
-// prewarmMaxBufferedSegments segments) but uploads nothing, so an idle camera
-// produces no live traffic. Switching from inactive to active immediately
-// flushes the cached init and buffered segments so a viewer can start almost
-// instantly instead of waiting a full GOP for the next segment to be cut.
-// Switching from active to inactive resets the init-published flag so the next
-// activation re-uploads the init (it may have aged out of the hub's short-TTL
-// live window while idle). All other transitions are no-ops. Driven from the
-// live-stream goroutine; not safe for concurrent use.
-func (s *Session) SetUploadsActive(active bool) bool {
-	s.mu.Lock()
-	if s.uploadsActive == active {
-		s.mu.Unlock()
-		return false
-	}
-	s.uploadsActive = active
-	if !active {
-		// Going idle: force the next activation to re-deliver the init segment,
-		// which may have expired from the hub live window while nobody was watching.
-		s.initPublished = false
-		s.mu.Unlock()
-		return false
-	}
-	// Inactive -> active: take the cached buffered segments/parts and flush them
-	// outside the lock (the publish calls take their own time and re-acquire the
-	// mutex).
-	buffered := s.bufferedSegments
-	bufferedParts := s.bufferedParts
-	s.bufferedSegments = nil
-	s.bufferedParts = nil
-	s.mu.Unlock()
-
-	// Deliver the init first; media segments are useless without it.
-	for i := range buffered {
-		if !s.publishInitIfNeeded() {
-			break
-		}
-		ctx, cancel := s.newContext()
-		if err := s.publisher.PublishSegment(ctx, s.id, buffered[i]); err != nil {
-			log.WithError(err).WithFields(log.Fields{
-				"component":        "cloud/livehls",
-				"event":            "prewarm_segment_upload_failed",
-				"segment_sequence": buffered[i].SequenceNumber,
-				"session_id":       s.id,
-			}).Warn("Failed to upload buffered live HLS segment")
-			s.fireFailureOnce("segment-upload-failed")
-			cancel()
-			continue
-		}
-		cancel()
-		s.fireReadyOnce()
-		s.refreshInitIfStale()
-	}
-	// LL-HLS: flush the buffered parts in order (oldest first) so the viewer gets a
-	// playable, near-live window immediately.
-	for i := range bufferedParts {
-		if !s.publishInitIfNeeded() {
-			break
-		}
-		ctx, cancel := s.newContext()
-		if err := s.publisher.PublishPart(ctx, s.id, bufferedParts[i]); err != nil {
-			log.WithError(err).WithFields(log.Fields{
-				"component":        "cloud/livehls",
-				"event":            "prewarm_part_upload_failed",
-				"part_index":       bufferedParts[i].PartIndex,
-				"segment_sequence": bufferedParts[i].SegmentSeq,
-				"session_id":       s.id,
-			}).Warn("Failed to upload buffered live HLS part")
-			s.fireFailureOnce("part-upload-failed")
-			cancel()
-			continue
-		}
-		cancel()
-		s.fireReadyOnce()
-		s.refreshInitIfStale()
-	}
-	return true
-}
-
-// UploadsActive reports whether the session is currently shipping segments (as
-// opposed to buffering them while prewarming). Always true for the on-demand
-// path.
-func (s *Session) UploadsActive() bool {
-	s.mu.Lock()
-	defer s.mu.Unlock()
-	return s.uploadsActive
-}
-
-// bufferSegment appends a completed segment to the in-memory prewarm ring buffer,
-// discarding the oldest so at most prewarmMaxBufferedSegments are retained.
-func (s *Session) bufferSegment(seg video.LiveSegment) {
-	s.mu.Lock()
-	s.bufferedSegments = append(s.bufferedSegments, seg)
-	if overflow := len(s.bufferedSegments) - prewarmMaxBufferedSegments; overflow > 0 {
-		// Drop the oldest segment(s) and shrink the backing array so retained bytes
-		// stay bounded.
-		s.bufferedSegments = append([]video.LiveSegment(nil), s.bufferedSegments[overflow:]...)
-	}
-	s.mu.Unlock()
-}
-
-// bufferPart appends a part to the LL-HLS prewarm ring buffer, pruning whole
-// older segments (never individual parts) so the retained window always consists
-// of complete segments plus the in-progress one. Pruning on a part-0 boundary
-// keeps at most prewarmMaxBufferedSegments fully-buffered segments behind the
-// current one, which guarantees a flushed segment can be reconstructed in full.
-func (s *Session) bufferPart(part video.LivePart) {
-	s.mu.Lock()
-	s.bufferedParts = append(s.bufferedParts, part)
-	if part.PartIndex == 0 && part.SegmentSeq > uint32(prewarmMaxBufferedSegments) {
-		minSeg := part.SegmentSeq - uint32(prewarmMaxBufferedSegments)
-		kept := make([]video.LivePart, 0, len(s.bufferedParts))
-		for _, p := range s.bufferedParts {
-			if p.SegmentSeq >= minSeg {
-				kept = append(kept, p)
-			}
-		}
-		s.bufferedParts = kept
-	}
-	s.mu.Unlock()
-}
-
-// WritePacket feeds one capture packet into the segmenter. Non-video packets are
-// ignored (the spike is video-only). The decode timestamp is derived exactly as
-// the recording muxer does: DTS = PTS - compositionOffset, with the composition
-// offset forwarded for correct B-frame presentation order.
-func (s *Session) WritePacket(pkt packets.Packet) error {
-	if !pkt.IsVideo {
-		return nil
-	}
-	pts := uint64(pkt.TimeLegacy.Milliseconds())
-	compositionOffset := pkt.CompositionTime
-	dts := pts
-	if compositionOffset > 0 && uint64(compositionOffset) <= pts {
-		dts = pts - uint64(compositionOffset)
-	} else if compositionOffset < 0 || uint64(compositionOffset) > pts {
-		// Guard against invalid offsets to avoid producing a CTS (DTS+CTO) jump.
-		compositionOffset = 0
-	}
-	return s.segmenter.WriteSample(pkt.IsKeyFrame, pkt.Data, dts, int32(compositionOffset))
-}
-
-// Close flushes any buffered sample and ships the final segment.
-func (s *Session) Close() error {
-	return s.segmenter.Close()
-}
-
-// publishInitIfNeeded ensures the init segment has been delivered, attempting an
-// upload if it has not. Returns true once init is known to be published.
-func (s *Session) publishInitIfNeeded() bool {
-	s.mu.Lock()
-	if s.initPublished {
-		s.mu.Unlock()
-		return true
-	}
-	initBytes := s.initBytes
-	s.mu.Unlock()
-
-	if len(initBytes) == 0 {
-		return false
-	}
-
-	ctx, cancel := s.newContext()
-	defer cancel()
-	if err := s.publisher.PublishInit(ctx, s.id, initBytes); err != nil {
-		log.WithError(err).WithFields(log.Fields{
-			"component":  "cloud/livehls",
-			"event":      "init_upload_failed",
-			"session_id": s.id,
-		}).Warn("Failed to upload live HLS init segment; retrying")
-		s.fireFailureOnce("init-upload-failed")
-		return false
-	}
-
-	s.mu.Lock()
-	s.initPublished = true
-	s.lastInitAt = time.Now()
-	s.mu.Unlock()
-	log.WithFields(log.Fields{
-		"component":  "cloud/livehls",
-		"event":      "init_uploaded",
-		"session_id": s.id,
-	}).Info("Live HLS init segment uploaded")
-	return true
-}
-
-// initRefreshInterval is how often the init segment is re-uploaded so its TTL in
-// the hub-api live window never lapses mid-session. The init segment is otherwise
-// written only once per session; because the live window expires objects after a
-// short TTL (LiveSegmentTTLSeconds, 45s on the hub) the init would age out after
-// ~1 minute and the playlist's #EXT-X-MAP would start 404ing, stalling playback.
-// Re-uploading well inside that TTL keeps the init alive for the life of the
-// session while still letting it expire naturally once the session ends.
-const initRefreshInterval = 15 * time.Second
-
-// refreshInitIfStale re-uploads the init segment if it has not been refreshed
-// within initRefreshInterval, keeping its created_at (and thus its TTL) current
-// for as long as the session is producing segments. It is a no-op until the init
-// has first been published. Failures are non-fatal: the next segment retries.
-func (s *Session) refreshInitIfStale() {
-	s.mu.Lock()
-	if !s.initPublished || time.Since(s.lastInitAt) < initRefreshInterval {
-		s.mu.Unlock()
-		return
-	}
-	initBytes := s.initBytes
-	s.mu.Unlock()
-
-	if len(initBytes) == 0 {
-		return
-	}
-
-	ctx, cancel := s.newContext()
-	defer cancel()
-	if err := s.publisher.PublishInit(ctx, s.id, initBytes); err != nil {
-		log.WithError(err).WithFields(log.Fields{
-			"component":  "cloud/livehls",
-			"event":      "init_refresh_failed",
-			"session_id": s.id,
-		}).Warn("Failed to refresh live HLS init segment; retrying")
-		return
-	}
-
-	s.mu.Lock()
-	s.lastInitAt = time.Now()
-	s.mu.Unlock()
-	log.WithFields(log.Fields{
-		"component":  "cloud/livehls",
-		"event":      "init_refreshed",
-		"session_id": s.id,
-	}).Debug("Live HLS init segment refreshed")
-}
-
-// fireReadyOnce invokes the OnReady callback the first time it is called.
-func (s *Session) fireReadyOnce() {
-	s.mu.Lock()
-	if s.readyFired || s.onReady == nil {
-		s.mu.Unlock()
-		return
-	}
-	s.readyFired = true
-	fn := s.onReady
-	s.mu.Unlock()
-	fn(s.id)
-}
-
-func (s *Session) fireFailureOnce(reason string) {
-	s.mu.Lock()
-	if s.failureFired || s.readyFired || s.onFailure == nil {
-		s.mu.Unlock()
-		return
-	}
-	s.failureFired = true
-	fn := s.onFailure
-	s.mu.Unlock()
-	fn(s.id, reason)
-}
-
-// newSessionID returns a short, unique, URL-safe session identifier of the form
-// <unix-seconds>-<random-hex>.
-func newSessionID() string {
-	b := make([]byte, 4)
-	if _, err := rand.Read(b); err != nil {
-		// rand.Read essentially never fails; fall back to a time-only id.
-		return fmt.Sprintf("%d", time.Now().UnixNano())
-	}
-	return fmt.Sprintf("%d-%s", time.Now().Unix(), hex.EncodeToString(b))
-}

machinery/src/cloud/livemoq/annexb.go

@@ -1,103 +0,0 @@
-package livemoq
-
-import (
-	"bytes"
-	"strings"
-
-	"github.com/bluenviron/mediacommon/pkg/codecs/h264"
-	"github.com/kerberos-io/agent/machinery/src/models"
-)
-
-var annexBStartCode = []byte{0x00, 0x00, 0x00, 0x01}
-
-// H264NormalizationStats reports malformed duplication removed from an access unit.
-type H264NormalizationStats struct {
-	DuplicateIDRNALUs int
-}
-
-// EnsureAnnexB restores the start code stripped by the Agent capture queue.
-func EnsureAnnexB(payload []byte) []byte {
-	if hasAnnexBStartCode(payload) {
-		return payload
-	}
-
-	framed := make([]byte, 0, len(annexBStartCode)+len(payload))
-	framed = append(framed, annexBStartCode...)
-	return append(framed, payload...)
-}
-
-// NormalizeH264AccessUnit removes delimiters and exact duplicate parameter-set
-// or IDR NALUs that can confuse older MoQ splitters and decoders.
-func NormalizeH264AccessUnit(payload []byte) ([]byte, error) {
-	normalized, _, err := NormalizeH264AccessUnitWithStats(payload)
-	return normalized, err
-}
-
-// NormalizeH264AccessUnitWithStats also reports exact duplicate IDR NALUs.
-func NormalizeH264AccessUnitWithStats(payload []byte) ([]byte, H264NormalizationStats, error) {
-	nalus, err := h264.AnnexBUnmarshal(EnsureAnnexB(payload))
-	if err != nil {
-		return nil, H264NormalizationStats{}, err
-	}
-
-	stats := H264NormalizationStats{}
-	normalized := make([][]byte, 0, len(nalus))
-	for _, nalu := range nalus {
-		if len(nalu) == 0 || nalu[0]&0x1f == 9 {
-			continue
-		}
-		naluType := nalu[0] & 0x1f
-		if naluType == 7 || naluType == 8 || naluType == 5 {
-			duplicate := false
-			for _, existing := range normalized {
-				if bytes.Equal(existing, nalu) {
-					duplicate = true
-					break
-				}
-			}
-			if duplicate {
-				if naluType == 5 {
-					stats.DuplicateIDRNALUs++
-				}
-				continue
-			}
-		}
-		normalized = append(normalized, nalu)
-	}
-
-	result, err := h264.AnnexBMarshal(normalized)
-	return result, stats, err
-}
-
-// BroadcastPath returns the relay path a quality tier is published on. Every
-// tier gets its own broadcast so a viewer switches between the camera's main and
-// sub stream by resubscribing to another path, without any control channel back
-// to the Agent. The high tier keeps the historical ".../live.hang" path so
-// existing viewers keep working; the low tier lives next to it on
-// ".../live-low.hang".
-func BroadcastPath(prefix string, deviceKey string, quality string) string {
-	prefix = strings.Trim(prefix, "/")
-	if prefix == "" {
-		prefix = "devices"
-	}
-	name := "live.hang"
-	if quality == models.StreamQualityLow {
-		name = "live-low.hang"
-	}
-	return prefix + "/" + strings.Trim(deviceKey, "/") + "/" + name
-}
-
-// TimestampUs converts the capture presentation timestamp from milliseconds.
-// CompositionTime must not be added: it is already represented in the PTS and
-// is only used by muxers to derive DTS for streams containing B-frames.
-func TimestampUs(presentationTimeMs int64) uint64 {
-	if presentationTimeMs < 0 {
-		return 0
-	}
-	return uint64(presentationTimeMs) * 1000
-}
-
-func hasAnnexBStartCode(payload []byte) bool {
-	return len(payload) >= 4 && payload[0] == 0 && payload[1] == 0 &&
-		((payload[2] == 0 && payload[3] == 1) || payload[2] == 1)
-}

machinery/src/cloud/livemoq/annexb_test.go

@@ -1,116 +0,0 @@
-package livemoq
-
-import (
-	"bytes"
-	"testing"
-
-	"github.com/kerberos-io/agent/machinery/src/models"
-)
-
-func TestEnsureAnnexB(t *testing.T) {
-	tests := []struct {
-		name    string
-		payload []byte
-		want    []byte
-	}{
-		{
-			name:    "missing start code",
-			payload: []byte{0x41, 0x01},
-			want:    []byte{0x00, 0x00, 0x00, 0x01, 0x41, 0x01},
-		},
-		{
-			name:    "four byte start code",
-			payload: []byte{0x00, 0x00, 0x00, 0x01, 0x65},
-			want:    []byte{0x00, 0x00, 0x00, 0x01, 0x65},
-		},
-		{
-			name:    "three byte start code",
-			payload: []byte{0x00, 0x00, 0x01, 0x41},
-			want:    []byte{0x00, 0x00, 0x01, 0x41},
-		},
-	}
-
-	for _, test := range tests {
-		t.Run(test.name, func(t *testing.T) {
-			if got := EnsureAnnexB(test.payload); !bytes.Equal(got, test.want) {
-				t.Fatalf("EnsureAnnexB() = %x, want %x", got, test.want)
-			}
-		})
-	}
-}
-
-func TestNormalizeH264AccessUnit(t *testing.T) {
-	startCode := []byte{0x00, 0x00, 0x00, 0x01}
-	sps := []byte{0x67, 0x42, 0x00, 0x1f}
-	pps := []byte{0x68, 0xce, 0x06, 0xe2}
-	aud := []byte{0x09, 0xf0}
-	idr := []byte{0x65, 0x88, 0x84}
-
-	payload := make([]byte, 0)
-	for _, nalu := range [][]byte{sps, pps, aud, sps, pps, idr} {
-		payload = append(payload, startCode...)
-		payload = append(payload, nalu...)
-	}
-
-	got, err := NormalizeH264AccessUnit(payload)
-	if err != nil {
-		t.Fatal(err)
-	}
-	want := make([]byte, 0)
-	for _, nalu := range [][]byte{sps, pps, idr} {
-		want = append(want, startCode...)
-		want = append(want, nalu...)
-	}
-	if !bytes.Equal(got, want) {
-		t.Fatalf("NormalizeH264AccessUnit() = %x, want %x", got, want)
-	}
-}
-
-func TestNormalizeH264AccessUnitRemovesOnlyExactDuplicateIDRSlices(t *testing.T) {
-	startCode := []byte{0x00, 0x00, 0x00, 0x01}
-	idrSlice1 := []byte{0x65, 0x88, 0x84}
-	idrSlice2 := []byte{0x65, 0x44, 0x22}
-
-	payload := make([]byte, 0)
-	for _, nalu := range [][]byte{idrSlice1, idrSlice1, idrSlice2} {
-		payload = append(payload, startCode...)
-		payload = append(payload, nalu...)
-	}
-
-	got, stats, err := NormalizeH264AccessUnitWithStats(payload)
-	if err != nil {
-		t.Fatal(err)
-	}
-	want := make([]byte, 0)
-	for _, nalu := range [][]byte{idrSlice1, idrSlice2} {
-		want = append(want, startCode...)
-		want = append(want, nalu...)
-	}
-	if !bytes.Equal(got, want) {
-		t.Fatalf("NormalizeH264AccessUnitWithStats() = %x, want %x", got, want)
-	}
-	if stats.DuplicateIDRNALUs != 1 {
-		t.Fatalf("DuplicateIDRNALUs = %d, want 1", stats.DuplicateIDRNALUs)
-	}
-}
-
-func TestBroadcastPath(t *testing.T) {
-	if got := BroadcastPath("/devices/", "/camera-1/", models.StreamQualityHigh); got != "devices/camera-1/live.hang" {
-		t.Fatalf("BroadcastPath() high = %q", got)
-	}
-	if got := BroadcastPath("", "camera-1", models.StreamQualityHigh); got != "devices/camera-1/live.hang" {
-		t.Fatalf("BroadcastPath() default = %q", got)
-	}
-	if got := BroadcastPath("", "camera-1", models.StreamQualityLow); got != "devices/camera-1/live-low.hang" {
-		t.Fatalf("BroadcastPath() low = %q", got)
-	}
-}
-
-func TestTimestampUs(t *testing.T) {
-	if got := TimestampUs(1234); got != 1_234_000 {
-		t.Fatalf("TimestampUs() = %d, want 1234000", got)
-	}
-	if got := TimestampUs(-1); got != 0 {
-		t.Fatalf("TimestampUs() negative = %d, want 0", got)
-	}
-}

machinery/src/cloud/livemoq/dedup.go

@@ -1,41 +0,0 @@
-package livemoq
-
-import (
-	"crypto/sha256"
-	"time"
-)
-
-type KeyframeDeduplicator struct {
-	hasPrevious  bool
-	timestampMs  int64
-	capturedAtMs int64
-	observedAt   time.Time
-	digest       [sha256.Size]byte
-}
-
-func (d *KeyframeDeduplicator) Reset() {
-	*d = KeyframeDeduplicator{}
-}
-
-// IsDuplicate reports exact repeated keyframe access units observed close
-// together. Distinct IDR slices within one access unit remain untouched.
-func (d *KeyframeDeduplicator) IsDuplicate(timestampMs int64, capturedAtMs int64, payload []byte, observedAt time.Time, window time.Duration) bool {
-	digest := sha256.Sum256(payload)
-	duplicate := d.hasPrevious && d.timestampMs == timestampMs && d.digest == digest
-	if duplicate {
-		if capturedAtMs > 0 && d.capturedAtMs > 0 {
-			gap := time.Duration(capturedAtMs-d.capturedAtMs) * time.Millisecond
-			duplicate = gap >= 0 && gap <= window
-		} else {
-			gap := observedAt.Sub(d.observedAt)
-			duplicate = gap >= 0 && gap <= window
-		}
-	}
-
-	d.hasPrevious = true
-	d.timestampMs = timestampMs
-	d.capturedAtMs = capturedAtMs
-	d.observedAt = observedAt
-	d.digest = digest
-	return duplicate
-}

machinery/src/cloud/livemoq/dedup_test.go

@@ -1,60 +0,0 @@
-package livemoq
-
-import (
-	"testing"
-	"time"
-)
-
-func TestKeyframeDeduplicator(t *testing.T) {
-	now := time.UnixMilli(10_000)
-	window := 500 * time.Millisecond
-	payload := []byte{0x00, 0x00, 0x00, 0x01, 0x65, 0x88}
-	deduplicator := KeyframeDeduplicator{}
-
-	if deduplicator.IsDuplicate(1_000, 10_000, payload, now, window) {
-		t.Fatal("first keyframe reported as duplicate")
-	}
-	if !deduplicator.IsDuplicate(1_000, 10_020, payload, now.Add(20*time.Millisecond), window) {
-		t.Fatal("exact repeated keyframe was not reported as duplicate")
-	}
-	if deduplicator.IsDuplicate(2_000, 11_000, payload, now.Add(time.Second), window) {
-		t.Fatal("same payload with a new timestamp reported as duplicate")
-	}
-	if deduplicator.IsDuplicate(2_000, 11_020, append(payload, 0x01), now.Add(1020*time.Millisecond), window) {
-		t.Fatal("different payload with the same timestamp reported as duplicate")
-	}
-}
-
-func TestKeyframeDeduplicatorAllowsTimestampReuseOutsideWindow(t *testing.T) {
-	now := time.UnixMilli(10_000)
-	payload := []byte{0x00, 0x00, 0x00, 0x01, 0x65, 0x88}
-	deduplicator := KeyframeDeduplicator{}
-
-	deduplicator.IsDuplicate(1_000, 10_000, payload, now, 500*time.Millisecond)
-	if deduplicator.IsDuplicate(1_000, 20_000, payload, now.Add(10*time.Second), 500*time.Millisecond) {
-		t.Fatal("later keyframe after timestamp reset reported as duplicate")
-	}
-}
-
-func TestKeyframeDeduplicatorFallsBackToObservationTime(t *testing.T) {
-	now := time.UnixMilli(10_000)
-	payload := []byte{0x65, 0x88}
-	deduplicator := KeyframeDeduplicator{}
-
-	deduplicator.IsDuplicate(1_000, 0, payload, now, 500*time.Millisecond)
-	if !deduplicator.IsDuplicate(1_000, 0, payload, now.Add(20*time.Millisecond), 500*time.Millisecond) {
-		t.Fatal("duplicate without capture time was not reported")
-	}
-}
-
-func TestKeyframeDeduplicatorReset(t *testing.T) {
-	now := time.UnixMilli(10_000)
-	payload := []byte{0x65, 0x88}
-	deduplicator := KeyframeDeduplicator{}
-
-	deduplicator.IsDuplicate(1_000, 10_000, payload, now, 500*time.Millisecond)
-	deduplicator.Reset()
-	if deduplicator.IsDuplicate(1_000, 10_020, payload, now.Add(20*time.Millisecond), 500*time.Millisecond) {
-		t.Fatal("first keyframe after reset reported as duplicate")
-	}
-}

machinery/src/cloud/livemoq/recovery.go

@@ -1,84 +0,0 @@
-package livemoq
-
-import (
-	"sync/atomic"
-	"time"
-)
-
-type FrameGateEvent uint8
-
-const (
-	FrameGateEventNone FrameGateEvent = iota
-	FrameGateEventStarted
-	FrameGateEventLagging
-	FrameGateEventRecovered
-)
-
-// FrameGate keeps publication on a decodable, recent GOP.
-type FrameGate struct {
-	started    bool
-	recovering bool
-}
-
-// WriteWatchdog tracks the single synchronous frame write performed by a MoQ
-// publisher so another goroutine can interrupt a wedged native call.
-type WriteWatchdog struct {
-	startedAt atomic.Int64
-}
-
-func (w *WriteWatchdog) Begin(now time.Time) {
-	w.startedAt.Store(now.UnixNano())
-}
-
-func (w *WriteWatchdog) End() {
-	w.startedAt.Store(0)
-}
-
-func (w *WriteWatchdog) Elapsed(now time.Time) (time.Duration, bool) {
-	startedAt := w.startedAt.Load()
-	if startedAt == 0 {
-		return 0, false
-	}
-	elapsed := now.Sub(time.Unix(0, startedAt))
-	if elapsed < 0 {
-		elapsed = 0
-	}
-	return elapsed, true
-}
-
-// Reset closes the gate so publication resumes on the next keyframe. It is used
-// when the publisher stopped writing for a reason unrelated to the stream health
-// (no subscribers), so the next viewer never receives a partial GOP.
-func (g *FrameGate) Reset() {
-	g.started = false
-	g.recovering = false
-}
-
-// Allow rejects stale frames and waits for a fresh keyframe before reopening.
-func (g *FrameGate) Allow(isKeyFrame bool, capturedAtMs int64, now time.Time, maxAge time.Duration) (bool, FrameGateEvent) {
-	if capturedAtMs > 0 && now.Sub(time.UnixMilli(capturedAtMs)) > maxAge {
-		event := FrameGateEventNone
-		if g.started {
-			if !g.recovering {
-				event = FrameGateEventLagging
-			}
-			g.started = false
-			g.recovering = true
-		}
-		return false, event
-	}
-
-	if !g.started {
-		if !isKeyFrame {
-			return false, FrameGateEventNone
-		}
-		g.started = true
-		if g.recovering {
-			g.recovering = false
-			return true, FrameGateEventRecovered
-		}
-		return true, FrameGateEventStarted
-	}
-
-	return true, FrameGateEventNone
-}

machinery/src/cloud/livemoq/recovery_test.go

@@ -1,68 +0,0 @@
-package livemoq
-
-import (
-	"testing"
-	"time"
-)
-
-func TestFrameGateRecoversAtFreshKeyframe(t *testing.T) {
-	now := time.UnixMilli(10_000)
-	maxAge := 1500 * time.Millisecond
-	gate := FrameGate{}
-
-	tests := []struct {
-		name         string
-		isKeyFrame   bool
-		capturedAtMs int64
-		wantAllowed  bool
-		wantEvent    FrameGateEvent
-	}{
-		{name: "waits for initial keyframe", capturedAtMs: 10_000},
-		{name: "starts at initial keyframe", isKeyFrame: true, capturedAtMs: 10_000, wantAllowed: true, wantEvent: FrameGateEventStarted},
-		{name: "publishes fresh delta", capturedAtMs: 10_020, wantAllowed: true},
-		{name: "detects stale packet", capturedAtMs: 8_000, wantEvent: FrameGateEventLagging},
-		{name: "rejects fresh delta while recovering", capturedAtMs: 10_040},
-		{name: "rejects stale keyframe without duplicate event", isKeyFrame: true, capturedAtMs: 8_000},
-		{name: "recovers at fresh keyframe", isKeyFrame: true, capturedAtMs: 10_060, wantAllowed: true, wantEvent: FrameGateEventRecovered},
-		{name: "publishes delta after recovery", capturedAtMs: 10_080, wantAllowed: true},
-	}
-
-	for _, test := range tests {
-		t.Run(test.name, func(t *testing.T) {
-			allowed, event := gate.Allow(test.isKeyFrame, test.capturedAtMs, now, maxAge)
-			if allowed != test.wantAllowed {
-				t.Fatalf("Allow() allowed = %t, want %t", allowed, test.wantAllowed)
-			}
-			if event != test.wantEvent {
-				t.Fatalf("Allow() event = %d, want %d", event, test.wantEvent)
-			}
-		})
-	}
-}
-
-func TestFrameGateAllowsMissingCaptureTime(t *testing.T) {
-	gate := FrameGate{}
-	allowed, event := gate.Allow(true, 0, time.Now(), time.Second)
-	if !allowed || event != FrameGateEventStarted {
-		t.Fatalf("Allow() = (%t, %d), want (true, %d)", allowed, event, FrameGateEventStarted)
-	}
-}
-
-func TestWriteWatchdogTracksActiveWrite(t *testing.T) {
-	now := time.Unix(10, 0)
-	watchdog := WriteWatchdog{}
-
-	if elapsed, active := watchdog.Elapsed(now); active || elapsed != 0 {
-		t.Fatalf("Elapsed() before Begin() = (%s, %t), want (0, false)", elapsed, active)
-	}
-
-	watchdog.Begin(now)
-	if elapsed, active := watchdog.Elapsed(now.Add(5 * time.Second)); !active || elapsed != 5*time.Second {
-		t.Fatalf("Elapsed() during write = (%s, %t), want (5s, true)", elapsed, active)
-	}
-
-	watchdog.End()
-	if elapsed, active := watchdog.Elapsed(now.Add(6 * time.Second)); active || elapsed != 0 {
-		t.Fatalf("Elapsed() after End() = (%s, %t), want (0, false)", elapsed, active)
-	}
-}

machinery/src/cloud/livemoq_disabled.go

@@ -1,21 +0,0 @@
-//go:build !moq
-
-package cloud
-
-import (
-	"context"
-
-	"github.com/kerberos-io/agent/machinery/src/models"
-	"github.com/kerberos-io/agent/machinery/src/packets"
-)
-
-// StartLiveStreamMoQ is disabled in the standard Agent build.
-func StartLiveStreamMoQ(
-	_ context.Context,
-	_ *models.Configuration,
-	_ *models.Communication,
-	_ bool,
-	_ *packets.Queue,
-	_ *packets.Queue,
-) {
-}

machinery/src/cloud/livemoq_enabled.go

@@ -1,491 +0,0 @@
-//go:build moq
-
-package cloud
-
-import (
-	"context"
-	"fmt"
-	"net/url"
-	"os"
-	"strings"
-	"sync"
-	"sync/atomic"
-	"time"
-
-	"github.com/kerberos-io/agent/machinery/src/cloud/livemoq"
-	"github.com/kerberos-io/agent/machinery/src/models"
-	"github.com/kerberos-io/agent/machinery/src/packets"
-	"github.com/moq-dev/moq-go/moq"
-	log "github.com/sirupsen/logrus"
-)
-
-const (
-	defaultMoQRelayURL      = "https://relay.uug.ai/anon"
-	minMoQRetryDelay        = time.Second
-	maxMoQRetryDelay        = 30 * time.Second
-	defaultMoQLivePacketAge = 1500 * time.Millisecond
-	minMoQLivePacketAge     = 250 * time.Millisecond
-	maxMoQLivePacketAge     = 30 * time.Second
-	defaultMoQWriteTimeout  = 5 * time.Second
-	minMoQWriteTimeout      = time.Second
-	maxMoQWriteTimeout      = time.Minute
-	moQWriteWatchInterval   = 250 * time.Millisecond
-	slowMoQWriteThreshold   = 100 * time.Millisecond
-	moQWriteWarningInterval = 10 * time.Second
-	duplicateKeyframeWindow = 500 * time.Millisecond
-)
-
-type liveMoQConfig struct {
-	relayURL      string
-	broadcast     string
-	quality       string
-	sourceLabel   string
-	queue         *packets.Queue
-	communication *models.Communication
-	maxPacketAge  time.Duration
-	writeTimeout  time.Duration
-}
-
-func (c liveMoQConfig) logEntry(event string) *log.Entry {
-	return log.WithFields(log.Fields{
-		"component": "moq",
-		"event":     event,
-		"quality":   c.quality,
-		"stream":    c.sourceLabel,
-	})
-}
-
-func moQRelayHost(relayURL string) string {
-	parsed, err := url.Parse(relayURL)
-	if err != nil {
-		return ""
-	}
-	return parsed.Host
-}
-
-func (c liveMoQConfig) packetAgeLimit() time.Duration {
-	if c.maxPacketAge > 0 {
-		return c.maxPacketAge
-	}
-	return defaultMoQLivePacketAge
-}
-
-func (c liveMoQConfig) writeTimeoutLimit() time.Duration {
-	if c.writeTimeout > 0 {
-		return c.writeTimeout
-	}
-	return defaultMoQWriteTimeout
-}
-
-func boundedMoQDuration(name string, fallback, minimum, maximum time.Duration) time.Duration {
-	raw := strings.TrimSpace(os.Getenv(name))
-	if raw == "" {
-		return fallback
-	}
-
-	value, err := time.ParseDuration(raw)
-	if err != nil {
-		log.WithError(err).WithFields(log.Fields{
-			"component":        "moq",
-			"configured_value": raw,
-			"effective_value":  fallback.String(),
-			"event":            "duration_invalid",
-			"variable":         name,
-		}).Warn("Invalid MoQ duration; using default")
-		return fallback
-	}
-	if value < minimum {
-		log.WithFields(log.Fields{
-			"component":        "moq",
-			"configured_value": value.String(),
-			"effective_value":  minimum.String(),
-			"event":            "duration_clamped",
-			"minimum":          minimum.String(),
-			"variable":         name,
-		}).Warn("MoQ duration is below the supported minimum")
-		return minimum
-	}
-	if value > maximum {
-		log.WithFields(log.Fields{
-			"component":        "moq",
-			"configured_value": value.String(),
-			"effective_value":  maximum.String(),
-			"event":            "duration_clamped",
-			"maximum":          maximum.String(),
-			"variable":         name,
-		}).Warn("MoQ duration exceeds the supported maximum")
-		return maximum
-	}
-	return value
-}
-
-// StartLiveStreamMoQ starts the publisher only in the dedicated MoQ build and
-// only when explicitly enabled by the deployment.
-//
-// Unlike WebRTC and HLS — where a viewer negotiates a session with the Agent and
-// can therefore ask for another quality on the fly — MoQ viewers subscribe to a
-// relay and never talk to the Agent. The quality selector is honoured by
-// publishing each tier as its OWN broadcast (see livemoq.BroadcastPath): the
-// high tier from the camera's highest-resolution stream and the low tier from
-// its sub stream, so switching quality in the frontend is a resubscribe to the
-// other path. Each tier only uploads while it actually has subscribers, so the
-// second broadcast is close to free when nobody watches it.
-func StartLiveStreamMoQ(
-	ctx context.Context,
-	configuration *models.Configuration,
-	communication *models.Communication,
-	subStreamEnabled bool,
-	mainQueue *packets.Queue,
-	subQueue *packets.Queue,
-) {
-	if os.Getenv("AGENT_LIVE_MOQ_ENABLED") != "true" {
-		return
-	}
-
-	config := configuration.Config
-	if config.Offline == "true" || config.Capture.Liveview == "false" {
-		log.WithFields(log.Fields{
-			"component": "moq",
-			"event":     "publisher_disabled",
-			"liveview":  config.Capture.Liveview,
-			"offline":   config.Offline,
-		}).Debug("MoQ publisher disabled by Agent configuration")
-		return
-	}
-	if config.Key == "" {
-		log.WithFields(log.Fields{
-			"component": "moq",
-			"event":     "publisher_configuration_invalid",
-			"variable":  "AGENT_KEY",
-		}).Warn("MoQ publisher requires an Agent key")
-		return
-	}
-
-	// Both tiers are published by default. AGENT_LIVE_MOQ_QUALITY pins the Agent
-	// to a single tier for deployments that must never publish the other one
-	// (viewers asking for the pinned-away tier then find no broadcast).
-	qualities := []string{models.StreamQualityHigh, models.StreamQualityLow}
-	switch strings.ToLower(strings.TrimSpace(os.Getenv("AGENT_LIVE_MOQ_QUALITY"))) {
-	case models.StreamQualityHigh:
-		qualities = []string{models.StreamQualityHigh}
-	case models.StreamQualityLow:
-		qualities = []string{models.StreamQualityLow}
-	}
-
-	relayURL := os.Getenv("AGENT_LIVE_MOQ_URL")
-	if relayURL == "" {
-		relayURL = defaultMoQRelayURL
-	}
-	broadcastPrefix := os.Getenv("AGENT_LIVE_MOQ_BROADCAST_PREFIX")
-	maxPacketAge := boundedMoQDuration("AGENT_LIVE_MOQ_MAX_PACKET_AGE", defaultMoQLivePacketAge, minMoQLivePacketAge, maxMoQLivePacketAge)
-	writeTimeout := boundedMoQDuration("AGENT_LIVE_MOQ_WRITE_TIMEOUT", defaultMoQWriteTimeout, minMoQWriteTimeout, maxMoQWriteTimeout)
-
-	var publishers sync.WaitGroup
-	for _, quality := range qualities {
-		queue := mainQueue
-		sourceLabel := "main"
-		if models.SelectSubStreamForQuality(config, quality, subStreamEnabled) && subQueue != nil {
-			queue = subQueue
-			sourceLabel = "sub"
-		}
-		if queue == nil {
-			log.WithFields(log.Fields{
-				"component": "moq",
-				"event":     "packet_queue_unavailable",
-				"quality":   quality,
-			}).Warn("MoQ packet queue is unavailable")
-			continue
-		}
-		publisherConfig := liveMoQConfig{
-			relayURL:      relayURL,
-			broadcast:     livemoq.BroadcastPath(broadcastPrefix, config.Key, quality),
-			quality:       quality,
-			sourceLabel:   sourceLabel,
-			queue:         queue,
-			communication: communication,
-			maxPacketAge:  maxPacketAge,
-			writeTimeout:  writeTimeout,
-		}
-		publishers.Add(1)
-		go func() {
-			defer publishers.Done()
-			runLiveStreamMoQ(ctx, publisherConfig)
-		}()
-	}
-	publishers.Wait()
-}
-
-func runLiveStreamMoQ(ctx context.Context, config liveMoQConfig) {
-	config.logEntry("publisher_started").Info("MoQ publisher started")
-	config.logEntry("publisher_configuration").WithFields(log.Fields{
-		"max_packet_age_ms": config.packetAgeLimit().Milliseconds(),
-		"relay_host":        moQRelayHost(config.relayURL),
-		"write_timeout_ms":  config.writeTimeoutLimit().Milliseconds(),
-	}).Debug("MoQ publisher configuration")
-
-	retryDelay := minMoQRetryDelay
-	for ctx.Err() == nil {
-		connectedAt := time.Now()
-		err := publishLiveStreamMoQ(ctx, config)
-		if ctx.Err() != nil {
-			return
-		}
-		if config.communication != nil {
-			config.communication.RecordMoQReconnect(config.quality)
-		}
-		config.logEntry("publisher_reconnecting").WithError(err).WithFields(log.Fields{
-			"connected_duration_ms": time.Since(connectedAt).Milliseconds(),
-			"retry_delay_ms":        retryDelay.Milliseconds(),
-		}).Warn("MoQ publisher stopped; reconnecting")
-		if time.Since(connectedAt) >= time.Minute {
-			retryDelay = minMoQRetryDelay
-		}
-
-		timer := time.NewTimer(retryDelay)
-		select {
-		case <-ctx.Done():
-			timer.Stop()
-			return
-		case <-timer.C:
-		}
-		if retryDelay < maxMoQRetryDelay {
-			retryDelay *= 2
-			if retryDelay > maxMoQRetryDelay {
-				retryDelay = maxMoQRetryDelay
-			}
-		}
-	}
-}
-
-func publishLiveStreamMoQ(ctx context.Context, config liveMoQConfig) error {
-	client, err := moq.Dial(ctx, config.relayURL)
-	if err != nil {
-		return fmt.Errorf("connect to relay: %w", err)
-	}
-	defer client.Close()
-	config.logEntry("relay_connected").WithField("relay_host", moQRelayHost(config.relayURL)).
-		Info("MoQ relay connected")
-
-	publisherCtx, cancelPublisher := context.WithCancel(ctx)
-	defer cancelPublisher()
-	sessionClosed := make(chan error, 1)
-	sessionWatchDone := make(chan struct{})
-	go func() {
-		defer close(sessionWatchDone)
-		sessionClosed <- client.Session().Closed(publisherCtx)
-		cancelPublisher()
-	}()
-
-	broadcast, err := client.CreateBroadcast(config.broadcast)
-	if err != nil {
-		return fmt.Errorf("create broadcast: %w", err)
-	}
-	defer broadcast.Finish()
-
-	stream, err := broadcast.PublishMedia("avc3", nil)
-	if err != nil {
-		return fmt.Errorf("create H.264 media stream: %w", err)
-	}
-	var finishStreamOnce sync.Once
-	finishStream := func() {
-		finishStreamOnce.Do(func() {
-			_ = stream.Finish()
-		})
-	}
-	defer finishStream()
-
-	// Only upload while this tier is actually being watched. `publishing` starts
-	// true so the track becomes discoverable on the relay even before the first
-	// subscriber ever arrives; from the moment a viewer has attached once, the
-	// subscriber watcher takes over and idles the tier again when everybody left.
-	publishing := &atomic.Bool{}
-	publishing.Store(true)
-	subscriberWatchDone := make(chan struct{})
-	go func() {
-		defer close(subscriberWatchDone)
-		watchLiveStreamMoQSubscribers(publisherCtx, stream, publishing, config)
-	}()
-	writeWatchdog := &livemoq.WriteWatchdog{}
-	writeWatchDone := make(chan struct{})
-	closePublisher := func() error {
-		finishStream()
-		return client.Close()
-	}
-	go func() {
-		defer close(writeWatchDone)
-		watchLiveStreamMoQWrites(publisherCtx, closePublisher, writeWatchdog, config)
-	}()
-	defer func() {
-		cancelPublisher()
-		<-writeWatchDone
-		<-subscriberWatchDone
-		<-sessionWatchDone
-	}()
-
-	cursor := config.queue.Latest()
-	gate := livemoq.FrameGate{}
-	deduplicator := livemoq.KeyframeDeduplicator{}
-	var lastSlowWriteWarning time.Time
-	var lastDuplicateKeyframeWarning time.Time
-	idle := false
-	for {
-		select {
-		case err := <-sessionClosed:
-			return fmt.Errorf("relay session closed: %w", err)
-		default:
-		}
-
-		packet, err := cursor.ReadPacketContext(publisherCtx)
-		if err != nil {
-			select {
-			case sessionErr := <-sessionClosed:
-				return fmt.Errorf("relay session closed: %w", sessionErr)
-			default:
-			}
-			if ctx.Err() != nil {
-				return ctx.Err()
-			}
-			return fmt.Errorf("read packet: %w", err)
-		}
-		if !publishing.Load() {
-			// Keep draining the cursor so we stay at the live edge, but publish
-			// nothing. The gate is closed so the next viewer resumes on a keyframe.
-			if !idle {
-				gate.Reset()
-				deduplicator.Reset()
-				idle = true
-			}
-			continue
-		}
-		idle = false
-		if !packet.IsVideo || len(packet.Data) == 0 || !strings.EqualFold(packet.Codec, "H264") {
-			continue
-		}
-		allowed, event := gate.Allow(packet.IsKeyFrame, packet.CurrentTime, time.Now(), config.packetAgeLimit())
-		switch event {
-		case livemoq.FrameGateEventStarted:
-			config.logEntry("broadcast_live").WithFields(log.Fields{
-				"codec":        packet.Codec,
-				"timestamp_ms": packet.Time,
-			}).Info("MoQ broadcast is live")
-		case livemoq.FrameGateEventLagging:
-			config.logEntry("stream_lagging").WithFields(log.Fields{
-				"max_packet_age_ms": config.packetAgeLimit().Milliseconds(),
-				"timestamp_ms":      packet.Time,
-			}).Warn("MoQ stream is lagging; dropping packets until a recent keyframe")
-		case livemoq.FrameGateEventRecovered:
-			config.logEntry("stream_recovered").WithField("timestamp_ms", packet.Time).
-				Info("MoQ stream recovered at a recent keyframe")
-		}
-		if !allowed {
-			continue
-		}
-		payload, normalizationStats, err := livemoq.NormalizeH264AccessUnitWithStats(packet.Data)
-		if err != nil {
-			return fmt.Errorf("normalize H.264 access unit: %w", err)
-		}
-		if normalizationStats.DuplicateIDRNALUs > 0 && time.Since(lastDuplicateKeyframeWarning) >= moQWriteWarningInterval {
-			config.logEntry("duplicate_idr_removed").WithFields(log.Fields{
-				"duplicate_idr_count": normalizationStats.DuplicateIDRNALUs,
-				"timestamp_ms":        packet.Time,
-			}).Warn("Removed duplicate IDR NAL units from MoQ keyframe")
-
-			lastDuplicateKeyframeWarning = time.Now()
-		}
-		if packet.IsKeyFrame && deduplicator.IsDuplicate(packet.Time, packet.CurrentTime, payload, time.Now(), duplicateKeyframeWindow) {
-			if time.Since(lastDuplicateKeyframeWarning) >= moQWriteWarningInterval {
-				config.logEntry("duplicate_keyframe_dropped").WithField("timestamp_ms", packet.Time).
-					Warn("Dropped duplicate MoQ keyframe")
-
-				lastDuplicateKeyframeWarning = time.Now()
-			}
-			continue
-		}
-		frame := moq.Frame{
-			Payload:     payload,
-			TimestampUs: livemoq.TimestampUs(packet.Time),
-		}
-		writeStartedAt := time.Now()
-		writeWatchdog.Begin(writeStartedAt)
-		err = stream.WriteFrame(frame)
-		writeWatchdog.End()
-		if err != nil {
-			return fmt.Errorf("write H.264 access unit: %w", err)
-		}
-		writeDuration := time.Since(writeStartedAt)
-		if config.communication != nil {
-			config.communication.RecordMoQWrite(config.quality, writeDuration, time.Now())
-		}
-		if writeDuration >= slowMoQWriteThreshold && time.Since(lastSlowWriteWarning) >= moQWriteWarningInterval {
-			packetAge := time.Duration(0)
-			if packet.CurrentTime > 0 {
-				packetAge = time.Since(time.UnixMilli(packet.CurrentTime))
-				if packetAge < 0 {
-					packetAge = 0
-				}
-			}
-			config.logEntry("slow_frame_write").WithFields(log.Fields{
-				"duration_ms":   writeDuration.Milliseconds(),
-				"keyframe":      packet.IsKeyFrame,
-				"packet_age_ms": packetAge.Milliseconds(),
-			}).Warn("MoQ frame write was slow")
-
-			lastSlowWriteWarning = time.Now()
-		}
-	}
-}
-
-func watchLiveStreamMoQWrites(ctx context.Context, closeClient func() error, watchdog *livemoq.WriteWatchdog, config liveMoQConfig) {
-	ticker := time.NewTicker(moQWriteWatchInterval)
-	defer ticker.Stop()
-
-	for {
-		select {
-		case <-ctx.Done():
-			closeClient()
-			return
-		case now := <-ticker.C:
-			writeDuration, active := watchdog.Elapsed(now)
-			if !active || writeDuration < config.writeTimeoutLimit() {
-				continue
-			}
-			config.logEntry("frame_write_timeout").WithFields(log.Fields{
-				"duration_ms": writeDuration.Milliseconds(),
-				"timeout_ms":  config.writeTimeoutLimit().Milliseconds(),
-			}).Warn("MoQ frame write timed out; reconnecting relay client")
-
-			if config.communication != nil {
-				config.communication.RecordMoQWriteTimeout()
-			}
-			closeClient()
-			return
-		}
-	}
-}
-
-// watchLiveStreamMoQSubscribers flips the publisher between uploading and idling
-// as viewers subscribe to and leave this tier's broadcast. Used and Unused both
-// block, so they are followed from their own goroutine.
-//
-// It deliberately never turns publishing off before the first subscriber has
-// been observed: the relay catalog is only complete once media has flowed, so
-// going idle up front could keep the tier undiscoverable. On any error it fails
-// open (keeps publishing) — a stalled watcher must never take the live view down.
-func watchLiveStreamMoQSubscribers(ctx context.Context, stream *moq.MediaProducer, publishing *atomic.Bool, config liveMoQConfig) {
-	for ctx.Err() == nil {
-		if err := stream.Used(ctx); err != nil {
-			publishing.Store(true)
-			return
-		}
-		if publishing.CompareAndSwap(false, true) {
-			config.logEntry("subscriber_joined").Info("MoQ subscriber joined; resuming broadcast")
-		}
-
-		if err := stream.Unused(ctx); err != nil {
-			publishing.Store(true)
-			return
-		}
-		publishing.Store(false)
-		config.logEntry("subscribers_idle").Info("MoQ broadcast idle; waiting for subscribers")
-	}
-}

machinery/src/cloud/livemoq_enabled_test.go

@@ -1,179 +0,0 @@
-//go:build moq
-
-package cloud
-
-import (
-	"context"
-	"sync/atomic"
-	"testing"
-	"time"
-
-	"github.com/kerberos-io/agent/machinery/src/cloud/livemoq"
-	"github.com/kerberos-io/agent/machinery/src/models"
-	"github.com/moq-dev/moq-go/moq"
-)
-
-func TestWatchLiveStreamMoQWritesClosesClientWhenContextEnds(t *testing.T) {
-	ctx, cancel := context.WithCancel(context.Background())
-	closed := make(chan struct{})
-	var closeCalls atomic.Int32
-
-	done := make(chan struct{})
-	go func() {
-		defer close(done)
-		watchLiveStreamMoQWrites(ctx, func() error {
-			if closeCalls.Add(1) == 1 {
-				close(closed)
-			}
-			return nil
-		}, &livemoq.WriteWatchdog{}, liveMoQConfig{quality: "low", sourceLabel: "sub"})
-	}()
-
-	cancel()
-	select {
-	case <-closed:
-	case <-time.After(time.Second):
-		t.Fatal("watchLiveStreamMoQWrites() did not close the client after cancellation")
-	}
-	<-done
-	if got := closeCalls.Load(); got != 1 {
-		t.Fatalf("close calls = %d, want 1", got)
-	}
-}
-
-func TestBoundedMoQDuration(t *testing.T) {
-	const name = "AGENT_LIVE_MOQ_TEST_DURATION"
-	tests := []struct {
-		name string
-		raw  string
-		want time.Duration
-	}{
-		{name: "unset", want: 5 * time.Second},
-		{name: "valid", raw: "12s", want: 12 * time.Second},
-		{name: "invalid", raw: "later", want: 5 * time.Second},
-		{name: "below minimum", raw: "100ms", want: time.Second},
-		{name: "above maximum", raw: "2m", want: time.Minute},
-	}
-
-	for _, test := range tests {
-		t.Run(test.name, func(t *testing.T) {
-			t.Setenv(name, test.raw)
-			if got := boundedMoQDuration(name, 5*time.Second, time.Second, time.Minute); got != test.want {
-				t.Fatalf("boundedMoQDuration() = %s, want %s", got, test.want)
-			}
-		})
-	}
-}
-
-func TestWatchLiveStreamMoQWritesRecordsTimeout(t *testing.T) {
-	ctx, cancel := context.WithCancel(context.Background())
-	defer cancel()
-	closed := make(chan struct{})
-	communication := &models.Communication{}
-	watchdog := &livemoq.WriteWatchdog{}
-	watchdog.Begin(time.Now().Add(-time.Second))
-
-	done := make(chan struct{})
-	go func() {
-		defer close(done)
-		watchLiveStreamMoQWrites(ctx, func() error {
-			close(closed)
-			return nil
-		}, watchdog, liveMoQConfig{
-			quality:       models.StreamQualityLow,
-			sourceLabel:   "sub",
-			communication: communication,
-			writeTimeout:  10 * time.Millisecond,
-		})
-	}()
-
-	select {
-	case <-closed:
-	case <-time.After(time.Second):
-		t.Fatal("watchLiveStreamMoQWrites() did not close the client after a write timeout")
-	}
-	<-done
-	if got := communication.RecoveryTelemetry().MoQWriteTimeouts; got != 1 {
-		t.Fatalf("MoQ write timeouts = %d, want 1", got)
-	}
-}
-
-func TestNativeMoQClientCloseStopsActiveWriter(t *testing.T) {
-	ctx, cancel := context.WithTimeout(context.Background(), 10*time.Second)
-	defer cancel()
-
-	server, err := moq.Listen(ctx, "127.0.0.1:0", moq.WithTLSGenerate("localhost"))
-	if err != nil {
-		t.Fatal(err)
-	}
-	serveDone := make(chan error, 1)
-	go func() {
-		serveDone <- server.Serve(ctx)
-	}()
-
-	client, err := moq.Dial(ctx, "https://"+server.LocalAddr(), moq.WithTLSVerify(false))
-	if err != nil {
-		server.Close()
-		t.Fatal(err)
-	}
-	broadcast, err := client.CreateBroadcast("test/native-close")
-	if err != nil {
-		client.Close()
-		server.Close()
-		t.Fatal(err)
-	}
-	stream, err := broadcast.PublishMedia("avc3", nil)
-	if err != nil {
-		client.Close()
-		server.Close()
-		t.Fatal(err)
-	}
-
-	firstWrite := make(chan struct{})
-	writerDone := make(chan error, 1)
-	go func() {
-		payload := []byte{
-			0x00, 0x00, 0x00, 0x01, 0x67, 0x42, 0xc0, 0x1e, 0xd9, 0x00, 0xa0, 0x47, 0xfe, 0xc8,
-			0x00, 0x00, 0x00, 0x01, 0x68, 0xce, 0x38, 0x80,
-			0x00, 0x00, 0x00, 0x01, 0x65, 0x88,
-		}
-		for timestamp := uint64(0); ; timestamp++ {
-			err := stream.WriteFrame(moq.Frame{Payload: payload, TimestampUs: timestamp})
-			if err != nil {
-				writerDone <- err
-				return
-			}
-			if timestamp == 0 {
-				close(firstWrite)
-			}
-		}
-	}()
-
-	select {
-	case <-firstWrite:
-	case <-ctx.Done():
-		t.Fatal("native MoQ writer did not start")
-	}
-	if err := stream.Finish(); err != nil {
-		t.Fatal(err)
-	}
-	if err := client.Close(); err != nil {
-		t.Fatal(err)
-	}
-	select {
-	case err := <-writerDone:
-		if err == nil {
-			t.Fatal("native MoQ writer stopped without an error after client close")
-		}
-	case <-ctx.Done():
-		t.Fatal("native MoQ client close did not stop the writer")
-	}
-
-	_ = broadcast.Finish()
-	_ = server.Close()
-	select {
-	case <-serveDone:
-	case <-ctx.Done():
-		t.Fatal("native MoQ server did not stop")
-	}
-}

machinery/src/cloud/livesnapshot/publisher.go

@@ -1,154 +0,0 @@
-// Package livesnapshot implements the agent-side producer for the live-view
-// "preview" (SD) mode over HTTP.
-//
-// Historically the preview pipeline shipped each resized keyframe (a base64
-// JPEG, often chunked) to viewers over the MQTT broker. MQTT is a control plane
-// for small messages, so pushing ~1 image/second of base64 image data per
-// watched camera congests the broker and delays genuine control traffic. This
-// package moves those frames off MQTT: the agent POSTs the latest resized JPEG
-// straight to hub-api over plain HTTPS (outbound only), and viewers fetch it
-// back with their session token. Only the tiny "a viewer is watching" keepalive
-// stays on MQTT.
-//
-// The wire contract (agent -> hub-api) deliberately mirrors the live HLS ingest
-// and the existing storage-upload convention (X-Kerberos-Storage-Device plus the
-// Hub public/private key auth headers). hub-api authenticates the agent and
-// stores the frame in an ephemeral, short-TTL per-device slot which it serves
-// straight back to authorized viewers; the frame never enters the vault or the
-// recordings collection.
-//
-// Like live HLS segments, a preview frame is worthless once stale: a frame that
-// fails to upload is superseded by the next one a second later, so the publisher
-// is fire-and-forget and drops on failure (logged) rather than retrying.
-package livesnapshot
-
-import (
-	"bytes"
-	"context"
-	"fmt"
-	"net/http"
-	"strings"
-	"time"
-
-	log "github.com/sirupsen/logrus"
-)
-
-const (
-	// snapshotIngestPath is the hub-api endpoint that accepts the latest preview
-	// frame and stores it in the device's ephemeral snapshot slot (mirrors the
-	// /storage/live live-HLS ingest convention).
-	snapshotIngestPath = "/storage/snapshot"
-
-	contentTypeJPEG = "image/jpeg"
-
-	// Header names for the snapshot ingest contract (shared with live HLS / storage).
-	headerHubPublicKey  = "X-Kerberos-Hub-PublicKey"
-	headerHubPrivateKey = "X-Kerberos-Hub-PrivateKey"
-	headerHubRegion     = "X-Kerberos-Hub-Region"
-	headerStorageDevice = "X-Kerberos-Storage-Device"
-
-	// defaultPublishTimeout bounds a single snapshot upload. Preview frames are
-	// produced roughly once a second from a single goroutine, so an upload that
-	// cannot land in a few seconds is abandoned rather than allowed to back up the
-	// preview loop behind a slow request.
-	defaultPublishTimeout = 4 * time.Second
-)
-
-// PublisherConfig carries the hub endpoint and credentials needed to ship
-// preview frames. It is populated from the agent's models.Config (the same
-// HubURI/HubKey/HubPrivateKey used by recordings and live HLS).
-type PublisherConfig struct {
-	HubURI        string // base hub-api URL, e.g. https://api.hub.example.com
-	HubKey        string // Hub public key (X-Kerberos-Hub-PublicKey)
-	HubPrivateKey string // Hub private key (X-Kerberos-Hub-PrivateKey)
-	Region        string // storage region (X-Kerberos-Hub-Region), may be empty
-	DeviceKey     string // device/camera key (X-Kerberos-Storage-Device)
-
-	// Timeout optionally overrides defaultPublishTimeout (used by tests).
-	Timeout time.Duration
-	// HTTPClient optionally injects a client (used by tests). When nil a
-	// redirect-credential-stripping client is created.
-	HTTPClient *http.Client
-}
-
-// Publisher ships the latest preview frame to hub-api over plain HTTP POST.
-//
-// It is safe for sequential use from a single live-stream goroutine. PublishSnapshot
-// is fire-and-forget: it returns an error for the caller to log, but the caller is
-// expected to continue (drop-on-fail) rather than retry.
-type Publisher struct {
-	cfg    PublisherConfig
-	client *http.Client
-}
-
-// NewPublisher builds a Publisher. The HTTP client strips the Hub credential
-// headers on a cross-host redirect (net/http does this for standard auth headers
-// but not custom-named ones), matching the recording/live-HLS upload clients.
-func NewPublisher(cfg PublisherConfig) *Publisher {
-	client := cfg.HTTPClient
-	if client == nil {
-		timeout := cfg.Timeout
-		if timeout <= 0 {
-			timeout = defaultPublishTimeout
-		}
-		client = &http.Client{
-			Timeout:       timeout,
-			CheckRedirect: stripHubCredentialsOnCrossHostRedirect,
-		}
-	}
-	return &Publisher{cfg: cfg, client: client}
-}
-
-// PublishSnapshot uploads a single resized preview frame (JPEG) as the device's
-// latest snapshot. It overwrites whatever frame was there before, so viewers
-// always fetch the most recent frame.
-func (p *Publisher) PublishSnapshot(ctx context.Context, jpeg []byte) error {
-	if p.cfg.HubURI == "" {
-		return fmt.Errorf("livesnapshot: HubURI not configured")
-	}
-	if len(jpeg) == 0 {
-		return fmt.Errorf("livesnapshot: empty snapshot body")
-	}
-
-	url := strings.TrimRight(p.cfg.HubURI, "/") + snapshotIngestPath
-	req, err := http.NewRequestWithContext(ctx, http.MethodPost, url, bytes.NewReader(jpeg))
-	if err != nil {
-		return fmt.Errorf("livesnapshot: build request: %w", err)
-	}
-
-	req.Header.Set("Content-Type", contentTypeJPEG)
-	req.Header.Set(headerStorageDevice, p.cfg.DeviceKey)
-	req.Header.Set(headerHubPublicKey, p.cfg.HubKey)
-	req.Header.Set(headerHubPrivateKey, p.cfg.HubPrivateKey)
-	req.Header.Set(headerHubRegion, p.cfg.Region)
-
-	resp, err := p.client.Do(req)
-	if err != nil {
-		return fmt.Errorf("livesnapshot: upload snapshot: %w", err)
-	}
-	defer resp.Body.Close()
-
-	if resp.StatusCode < 200 || resp.StatusCode >= 300 {
-		return fmt.Errorf("livesnapshot: upload snapshot rejected: %s", resp.Status)
-	}
-	log.WithFields(log.Fields{
-		"component": "livesnapshot",
-		"event":     "snapshot_published",
-	}).Debug("Live snapshot published")
-	return nil
-}
-
-// stripHubCredentialsOnCrossHostRedirect removes the Hub credential headers when
-// a redirect crosses to a different host. net/http strips standard sensitive
-// headers on a cross-host redirect but not custom-named ones, so without this the
-// Hub keys could leak to a redirect target.
-func stripHubCredentialsOnCrossHostRedirect(req *http.Request, via []*http.Request) error {
-	if len(via) == 0 {
-		return nil
-	}
-	if req.URL.Host != via[0].URL.Host {
-		req.Header.Del(headerHubPrivateKey)
-		req.Header.Del(headerHubPublicKey)
-	}
-	return nil
-}

machinery/src/cloud/recording_metadata.go

@@ -1,88 +0,0 @@
-package cloud
-
-import (
-	"encoding/json"
-	"math"
-	"net/http"
-	"os"
-	"path/filepath"
-	"strconv"
-	"strings"
-
-	"github.com/kerberos-io/agent/machinery/src/models"
-)
-
-const recordingFPSHeader = "X-Kerberos-Storage-Fps"
-const recordingDurationHeader = "X-Kerberos-Storage-Duration"
-const recordingTimestampHeader = "X-Kerberos-Storage-Timestamp"
-
-// queuedRecordingFPS reads the FPS snapshot written into the upload marker
-// when the recording was finalized. Historical empty markers intentionally
-// return no value so receivers can retain their existing MP4-derived fallback.
-func queuedRecordingFPS(fileName string) string {
-	value, ok := readRecordingUploadMetadata(fileName)
-	if !ok {
-		return ""
-	}
-
-	marker := strings.TrimSpace(string(value))
-	if strings.HasPrefix(marker, "{") {
-		metadata, ok := decodeRecordingUploadMetadata(value)
-		if !ok || metadata.FPS <= 0 || metadata.FPS > 240 || math.IsInf(metadata.FPS, 0) || math.IsNaN(metadata.FPS) {
-			return ""
-		}
-		return strconv.FormatFloat(metadata.FPS, 'f', -1, 64)
-	}
-
-	// Compatibility with markers created before upload metadata used JSON.
-	fps := marker
-	parsed, err := strconv.ParseFloat(fps, 64)
-	if err != nil || parsed <= 0 || parsed > 240 || math.IsInf(parsed, 0) || math.IsNaN(parsed) {
-		return ""
-	}
-	return fps
-}
-
-func queuedRecordingMetadata(fileName string) (models.RecordingUploadMetadata, bool) {
-	value, ok := readRecordingUploadMetadata(fileName)
-	if !ok || !strings.HasPrefix(strings.TrimSpace(string(value)), "{") {
-		return models.RecordingUploadMetadata{}, false
-	}
-	return decodeRecordingUploadMetadata(value)
-}
-
-func decodeRecordingUploadMetadata(value []byte) (models.RecordingUploadMetadata, bool) {
-	var metadata models.RecordingUploadMetadata
-	if err := json.Unmarshal(value, &metadata); err != nil {
-		return models.RecordingUploadMetadata{}, false
-	}
-	return metadata, true
-}
-
-func readRecordingUploadMetadata(fileName string) ([]byte, bool) {
-	markerNames := []string{
-		models.RecordingUploadMetadataFileName(fileName),
-		filepath.Base(fileName),
-	}
-	for _, markerName := range markerNames {
-		value, err := os.ReadFile(filepath.Join("data", "cloud", markerName))
-		if err == nil {
-			return value, true
-		}
-	}
-	return nil, false
-}
-
-func setQueuedRecordingMetadataHeaders(header http.Header, fileName string) {
-	if fps := queuedRecordingFPS(fileName); fps != "" {
-		header.Set(recordingFPSHeader, fps)
-	}
-	if metadata, ok := queuedRecordingMetadata(fileName); ok {
-		if metadata.Duration > 0 {
-			header.Set(recordingDurationHeader, strconv.FormatUint(metadata.Duration, 10))
-		}
-		if metadata.Timestamp > 0 {
-			header.Set(recordingTimestampHeader, strconv.FormatInt(metadata.Timestamp, 10))
-		}
-	}
-}

machinery/src/cloud/tus_client.go

@@ -1,615 +0,0 @@
-package cloud
-
-import (
-	"encoding/base64"
-	"encoding/json"
-	"errors"
-	"fmt"
-	"io"
-	"net/http"
-	"net/url"
-	"os"
-	"path/filepath"
-	"sort"
-	"strconv"
-	"strings"
-	"time"
-
-	"github.com/kerberos-io/agent/machinery/src/models"
-	log "github.com/sirupsen/logrus"
-)
-
-// tusResumableVersion is the tus protocol version implemented by this client.
-const tusResumableVersion = "1.0.0"
-
-// tusUploadPath is appended to the configured Kerberos Vault URI to reach the
-// resumable upload endpoint. It mirrors how the legacy uploader appends
-// "/storage".
-const tusUploadPath = "/storage/tus/"
-
-// tusResumeState is persisted in a sidecar file next to the agent data so an
-// interrupted upload can be resumed across retries and even agent restarts.
-type tusResumeState struct {
-	UploadURL string `json:"upload_url"`
-	VaultURI  string `json:"vault_uri"`
-	Size      int64  `json:"size"`
-}
-
-// resumableUploadsEnabled reports whether the resumable (tus) upload path should
-// be attempted. It is enabled by default and can be disabled (falling back to
-// the legacy single POST) by setting AGENT_DISABLE_RESUMABLE_UPLOAD=true.
-func resumableUploadsEnabled() bool {
-	return os.Getenv("AGENT_DISABLE_RESUMABLE_UPLOAD") != "true"
-}
-
-// tusDefaultChunkSize is the number of bytes uploaded per PATCH request when no
-// explicit size is configured. Splitting the upload into chunks keeps each HTTP
-// request small enough for intermediary proxies/load balancers and checkpoints
-// progress frequently, so an interruption resumes with minimal re-upload.
-const tusDefaultChunkSize int64 = 8 << 20 // 8 MiB (>= S3 multipart minimum part size)
-
-const tusProgressBucketPercent int64 = 10
-
-// tusChunkSize returns the number of bytes to send per PATCH request. It
-// defaults to tusDefaultChunkSize (8 MiB) and can be overridden with the
-// AGENT_TUS_CHUNK_SIZE_BYTES environment variable. A value of 0 (or negative)
-// disables chunking and sends the remaining bytes in a single PATCH.
-func tusChunkSize() int64 {
-	v := os.Getenv("AGENT_TUS_CHUNK_SIZE_BYTES")
-	if v == "" {
-		return tusDefaultChunkSize
-	}
-	n, err := strconv.ParseInt(v, 10, 64)
-	if err != nil {
-		return tusDefaultChunkSize
-	}
-	if n <= 0 {
-		return 0 // chunking disabled: send everything in one PATCH
-	}
-	return n
-}
-
-func tusProgressBucket(offset, size int64) int64 {
-	if size <= 0 {
-		return 100
-	}
-	percent := (offset * 100) / size
-	if percent > 100 {
-		percent = 100
-	}
-	return percent / tusProgressBucketPercent
-}
-
-func logTusUploadProgress(label string, offset, size int64, loggedBucket *int64) {
-	bucket := tusProgressBucket(offset, size)
-	if bucket <= *loggedBucket {
-		return
-	}
-	*loggedBucket = bucket
-	percent := bucket * tusProgressBucketPercent
-	if percent > 100 {
-		percent = 100
-	}
-	log.WithFields(log.Fields{
-		"bytes_sent":  offset,
-		"bytes_total": size,
-		"component":   "tus",
-		"event":       "upload_progress",
-		"progress":    percent,
-		"target":      label,
-	}).Info("Resumable upload progress")
-}
-
-// tusHeaderFunc sets the authentication and routing headers required on every
-// tus request for a particular upload target (Kerberos Vault directly, or
-// Kerberos Hub which proxies to a vault). fileName is only meaningful on the
-// creation request; it is empty on HEAD/PATCH/DELETE.
-type tusHeaderFunc func(h http.Header, fileName string)
-
-// runTusUpload performs a resumable (tus) upload of data/recordings/<fileName>
-// to baseURL, sending target-specific authentication/routing headers via
-// setHeaders on every request. It encapsulates the create/resume/chunk/finalize
-// state machine shared by the Kerberos Vault (direct) and Kerberos Hub (proxied)
-// upload paths.
-//
-// Return values:
-//   - uploaded:  the recording was fully received and persisted by the server.
-//   - responded: the server returned a definitive HTTP response (used by the
-//     caller to advance its retry/secondary-failover policy).
-//   - supported: the server exposes a tus endpoint. When false, the caller
-//     should fall back to the legacy single-POST upload (older deployments).
-//   - body:      a short message for logging.
-func runTusUpload(baseURL, metadata, fileName, label, slot string, setHeaders tusHeaderFunc) (uploaded bool, responded bool, supported bool, body string, err error) {
-	fullname := "data/recordings/" + fileName
-
-	file, ferr := os.Open(fullname)
-	if file != nil {
-		defer file.Close()
-	}
-	if ferr != nil {
-		msg := label + ": resumable upload failed, file doesn't exist anymore"
-		log.Info(msg)
-		// The file is gone, so the legacy path cannot help either. Report it as
-		// "supported" to avoid a pointless fallback attempt.
-		return false, false, true, "", errors.New(msg)
-	}
-
-	info, serr := file.Stat()
-	if serr != nil {
-		return false, false, true, "", serr
-	}
-	size := info.Size()
-
-	client := newVaultHTTPClient(0)
-	client.CheckRedirect = func(req *http.Request, via []*http.Request) error {
-		if len(via) == 0 {
-			return nil
-		}
-		if req.URL.Host != via[0].URL.Host {
-			for k := range req.Header {
-				if strings.HasPrefix(http.CanonicalHeaderKey(k), "X-Kerberos-") {
-					req.Header.Del(k)
-				}
-			}
-		}
-		return nil
-	}
-
-	sidecar := tusSidecarPath(fileName, slot)
-	uploadURL := loadTusResumeState(sidecar, baseURL)
-
-	const maxAttempts = 4
-	restartedAfterComplete := false
-
-	// lastStatus holds the HTTP status code of the most recent tus request. A
-	// value of 0 means the request failed at the transport level (no HTTP
-	// response at all, e.g. the vault was unreachable or the connection dropped
-	// because the internet went down). It lets the final "gave up" return report
-	// whether the vault actually answered, so the caller only advances its
-	// retry/back-off policy on a definitive response and transient network errors
-	// never consume the retry budget (matching the legacy single-POST behaviour).
-	lastStatus := 0
-
-	// highWaterOffset is the furthest server-acknowledged offset observed across
-	// all attempts (via HEAD or PATCH). It lets the retry budget be refreshed only
-	// on GENUINE net forward progress. Without it, a server that keeps resetting the
-	// offset — e.g. a persistent 409 ERR_MISMATCHED_OFFSET where HEAD reports 0 again
-	// while the first chunk still "succeeds" — would refresh the budget every attempt
-	// and loop forever, wedging the upload worker on one recording and saturating the
-	// uplink.
-	highWaterOffset := int64(0)
-
-	for attempt := 0; attempt < maxAttempts; attempt++ {
-		// (1) Ensure we have an active upload URL, creating one if needed.
-		if uploadURL == "" {
-			created, status, cerr := tusCreate(client, baseURL, size, metadata, setHeaders, fileName)
-			lastStatus = status
-			if cerr != nil {
-				if status == http.StatusNotFound || status == http.StatusMethodNotAllowed || status == http.StatusNotImplemented {
-					// The vault does not implement tus; let the caller fall back.
-					return false, false, false, "", cerr
-				}
-				log.Info(label + ": resumable create failed, " + cerr.Error())
-				tusBackoff(attempt)
-				continue
-			}
-			uploadURL = created
-			saveTusResumeState(sidecar, tusResumeState{UploadURL: uploadURL, VaultURI: baseURL, Size: size})
-		}
-
-		// (2) Query the current server-side offset.
-		offset, status, herr := tusHead(client, uploadURL, setHeaders)
-		lastStatus = status
-		if herr != nil {
-			if status == http.StatusNotFound || status == http.StatusGone {
-				// The upload expired/was removed server-side; start over.
-				removeTusResumeState(sidecar)
-				uploadURL = ""
-				continue
-			}
-			log.Info(label + ": resumable head failed, " + herr.Error())
-			tusBackoff(attempt)
-			continue
-		}
-
-		// The furthest offset any previous attempt reached. If this attempt pushes
-		// past it (via HEAD showing server-side progress or a successful PATCH) we made
-		// genuine net progress and may refresh the retry budget; if not, a repeated
-		// failure at the same spot must count against maxAttempts.
-		startHighWater := highWaterOffset
-		if offset > highWaterOffset {
-			highWaterOffset = offset
-		}
-
-		// (3) All bytes are present but the upload was not finalized (e.g. the
-		// completion hook failed). A completed tus upload cannot be re-finalized
-		// with another PATCH, so delete it and re-upload to force a clean finalize.
-		if offset >= size {
-			if restartedAfterComplete {
-				return false, true, true, "resumable finalize did not complete", errors.New(label + ": resumable finalize did not complete")
-			}
-			tusTerminate(client, uploadURL, setHeaders)
-			removeTusResumeState(sidecar)
-			uploadURL = ""
-			restartedAfterComplete = true
-			continue
-		}
-
-		// (4) Stream the remaining bytes to the vault via PATCH, reading directly
-		// from disk so the recording is never fully buffered in memory. When a chunk
-		// size is configured the data is sent across several PATCH requests,
-		// checkpointing the offset after each one so an interruption resumes from the
-		// last completed chunk instead of re-uploading everything.
-		chunkSize := tusChunkSize()
-		patchFailed := false
-		var lastBody string
-		loggedProgressBucket := tusProgressBucket(offset, size)
-		for offset < size {
-			// Re-seek every chunk so the on-disk position always matches the
-			// server-acknowledged offset, even if a PATCH was partially accepted.
-			if _, sErr := file.Seek(offset, io.SeekStart); sErr != nil {
-				return false, false, true, "", sErr
-			}
-			patchLen := size - offset
-			if chunkSize > 0 && chunkSize < patchLen {
-				patchLen = chunkSize
-			}
-			newOffset, status, respBody, perr := tusPatch(client, uploadURL, offset, patchLen, file, setHeaders)
-			lastStatus = status
-			if perr != nil {
-				if status >= 400 {
-					// Definitive rejection (e.g. provider push failed during finalize).
-					// Re-evaluate via HEAD on the next iteration to decide retry/restart.
-					log.Info(label + ": resumable patch rejected, " + perr.Error())
-				} else {
-					log.Info(label + ": resumable patch failed, " + perr.Error())
-				}
-				tusBackoff(attempt)
-				patchFailed = true
-				break
-			}
-			offset = newOffset
-			if offset > highWaterOffset {
-				highWaterOffset = offset
-			}
-			lastBody = respBody
-			logTusUploadProgress(label, offset, size, &loggedProgressBucket)
-			if offset < size {
-				// Partial progress: persist so a later retry resumes from here.
-				saveTusResumeState(sidecar, tusResumeState{UploadURL: uploadURL, VaultURI: baseURL, Size: size})
-			}
-		}
-		if patchFailed {
-			if highWaterOffset > startHighWater {
-				// Genuine net progress (we advanced past the furthest point any previous
-				// attempt reached) refreshes the retry budget: maxAttempts bounds the
-				// number of consecutive *non-progressing* failures, not the number of
-				// chunks needed for a large recording. A server that keeps rejecting the
-				// same offset (no net progress, e.g. a persistent ERR_MISMATCHED_OFFSET)
-				// therefore gives up after maxAttempts instead of retrying forever.
-				attempt = -1
-			}
-			continue
-		}
-
-		// All declared bytes have been sent and acknowledged: the upload is done.
-		removeTusResumeState(sidecar)
-		return true, true, true, lastBody, nil
-	}
-
-	// Every attempt failed. Only report responded=true when the vault actually
-	// answered on the last attempt (lastStatus > 0). If every attempt failed at
-	// the transport level (lastStatus == 0, e.g. the internet was disconnected),
-	// report responded=false so the caller keeps the recording queued and retries
-	// later instead of consuming its retry budget and entering the long back-off
-	// timeout.
-	return false, lastStatus > 0, true, "resumable upload did not complete after retries", errors.New(label + ": resumable upload did not complete after retries")
-}
-
-// uploadVaultResumable uploads a recording directly to a Kerberos Vault using
-// the tus resumable upload protocol. Credentials travel in the
-// X-Kerberos-Storage-* headers on every request and routing (directory/provider)
-// is additionally carried in the tus Upload-Metadata.
-func uploadVaultResumable(vault models.KStorage, publicKey, deviceKey, fileName, label, slot string) (bool, bool, bool, string, error) {
-	baseURL := strings.TrimRight(vault.URI, "/") + tusUploadPath
-	metadataValues := map[string]string{
-		"filename":  fileName,
-		"device":    deviceKey,
-		"directory": vault.Directory,
-		"provider":  vault.Provider,
-		"capture":   "IPCamera",
-		"cloudkey":  publicKey,
-		"fps":       queuedRecordingFPS(fileName),
-	}
-	addRecordingTusMetadata(metadataValues, fileName)
-	metadata := encodeTusMetadata(metadataValues)
-	setHeaders := func(h http.Header, fn string) {
-		setVaultTusHeaders(h, vault, publicKey, deviceKey, fn)
-	}
-	return runTusUpload(baseURL, metadata, fileName, label, slot, setHeaders)
-}
-
-// uploadHubResumable uploads a recording to Kerberos Hub's tus endpoint, which
-// authenticates the agent with its Hub public/private key and proxies the
-// resumable upload to the Kerberos Vault on the agent's behalf. The vault
-// directory and provider are resolved and injected by Kerberos Hub, so they are
-// intentionally omitted from the metadata here.
-func uploadHubResumable(config *models.Config, fileName, label, slot string) (bool, bool, bool, string, error) {
-	baseURL := strings.TrimRight(config.HubURI, "/") + tusUploadPath
-	metadataValues := map[string]string{
-		"filename": fileName,
-		"device":   config.Key,
-		"capture":  "IPCamera",
-		"fps":      queuedRecordingFPS(fileName),
-	}
-	addRecordingTusMetadata(metadataValues, fileName)
-	metadata := encodeTusMetadata(metadataValues)
-	setHeaders := func(h http.Header, fn string) {
-		setHubTusHeaders(h, config, fn)
-	}
-	return runTusUpload(baseURL, metadata, fileName, label, slot, setHeaders)
-}
-
-func addRecordingTusMetadata(values map[string]string, fileName string) {
-	metadata, ok := queuedRecordingMetadata(fileName)
-	if !ok {
-		return
-	}
-	if metadata.Duration > 0 {
-		values["duration"] = strconv.FormatUint(metadata.Duration, 10)
-	}
-	if metadata.Timestamp > 0 {
-		values["timestamp"] = strconv.FormatInt(metadata.Timestamp, 10)
-	}
-}
-
-// tusCreate performs the tus "creation" request (POST). On success it returns
-// the resolved upload URL the agent should use for subsequent HEAD/PATCH calls.
-func tusCreate(client *http.Client, baseURL string, size int64, metadata string, setHeaders tusHeaderFunc, fileName string) (string, int, error) {
-	req, err := http.NewRequest("POST", baseURL, nil)
-	if err != nil {
-		return "", 0, err
-	}
-	req.Header.Set("Tus-Resumable", tusResumableVersion)
-	req.Header.Set("Upload-Length", strconv.FormatInt(size, 10))
-	if metadata != "" {
-		req.Header.Set("Upload-Metadata", metadata)
-	}
-	setHeaders(req.Header, fileName)
-
-	resp, err := client.Do(req)
-	if resp != nil {
-		defer resp.Body.Close()
-	}
-	if err != nil {
-		return "", 0, err
-	}
-	io.Copy(io.Discard, resp.Body)
-
-	if resp.StatusCode != http.StatusCreated {
-		return "", resp.StatusCode, fmt.Errorf("unexpected status creating upload: %s", resp.Status)
-	}
-	location := resp.Header.Get("Location")
-	if location == "" {
-		return "", resp.StatusCode, errors.New("missing Location header in create response")
-	}
-	return resolveTusLocation(baseURL, location), resp.StatusCode, nil
-}
-
-// tusHead performs the tus "offset" request (HEAD) and returns the current
-// server-side upload offset.
-func tusHead(client *http.Client, uploadURL string, setHeaders tusHeaderFunc) (int64, int, error) {
-	req, err := http.NewRequest("HEAD", uploadURL, nil)
-	if err != nil {
-		return 0, 0, err
-	}
-	req.Header.Set("Tus-Resumable", tusResumableVersion)
-	setHeaders(req.Header, "")
-
-	resp, err := client.Do(req)
-	if resp != nil {
-		defer resp.Body.Close()
-	}
-	if err != nil {
-		return 0, 0, err
-	}
-	io.Copy(io.Discard, resp.Body)
-
-	if resp.StatusCode != http.StatusOK && resp.StatusCode != http.StatusNoContent {
-		return 0, resp.StatusCode, fmt.Errorf("unexpected status on HEAD: %s", resp.Status)
-	}
-	offsetStr := resp.Header.Get("Upload-Offset")
-	offset, perr := strconv.ParseInt(offsetStr, 10, 64)
-	if perr != nil {
-		return 0, resp.StatusCode, fmt.Errorf("invalid Upload-Offset header: %q", offsetStr)
-	}
-	return offset, resp.StatusCode, nil
-}
-
-// tusPatch streams up to length bytes of the file (starting at offset) to the
-// upload URL using a single PATCH request. The body is read straight from the
-// *os.File, so the recording is never fully buffered in memory.
-func tusPatch(client *http.Client, uploadURL string, offset, length int64, file io.Reader, setHeaders tusHeaderFunc) (int64, int, string, error) {
-	req, err := http.NewRequest("PATCH", uploadURL, io.LimitReader(file, length))
-	if err != nil {
-		return offset, 0, "", err
-	}
-	req.ContentLength = length
-	req.Header.Set("Tus-Resumable", tusResumableVersion)
-	req.Header.Set("Content-Type", "application/offset+octet-stream")
-	req.Header.Set("Upload-Offset", strconv.FormatInt(offset, 10))
-	setHeaders(req.Header, "")
-
-	resp, err := client.Do(req)
-	if resp != nil {
-		defer resp.Body.Close()
-	}
-	if err != nil {
-		return offset, 0, "", err
-	}
-	bodyBytes, _ := io.ReadAll(resp.Body)
-	respBody := string(bodyBytes)
-
-	if resp.StatusCode != http.StatusNoContent {
-		return offset, resp.StatusCode, respBody, fmt.Errorf("unexpected status on PATCH: %s, %s", resp.Status, respBody)
-	}
-	newOffsetStr := resp.Header.Get("Upload-Offset")
-	newOffset, perr := strconv.ParseInt(newOffsetStr, 10, 64)
-	if perr != nil {
-		// A 204 without a parseable offset means this PATCH was fully accepted.
-		return offset + length, resp.StatusCode, respBody, nil
-	}
-	return newOffset, resp.StatusCode, respBody, nil
-}
-
-// tusTerminate best-effort deletes an upload server-side (DELETE).
-func tusTerminate(client *http.Client, uploadURL string, setHeaders tusHeaderFunc) {
-	req, err := http.NewRequest("DELETE", uploadURL, nil)
-	if err != nil {
-		return
-	}
-	req.Header.Set("Tus-Resumable", tusResumableVersion)
-	setHeaders(req.Header, "")
-
-	resp, derr := client.Do(req)
-	if resp != nil {
-		io.Copy(io.Discard, resp.Body)
-		resp.Body.Close()
-	}
-	_ = derr
-}
-
-// setVaultTusHeaders sets the Kerberos Vault authentication and routing headers
-// on every tus request. Credentials are sent on each request (and never stored
-// server-side in the upload metadata). When fileName is empty it is omitted, as
-// it is only useful on the creation request (routing also travels in the tus
-// Upload-Metadata).
-func setVaultTusHeaders(h http.Header, vault models.KStorage, publicKey, deviceKey, fileName string) {
-	h.Set("X-Kerberos-Storage-CloudKey", publicKey)
-	h.Set("X-Kerberos-Storage-AccessKey", vault.AccessKey)
-	h.Set("X-Kerberos-Storage-SecretAccessKey", vault.SecretAccessKey)
-	h.Set("X-Kerberos-Storage-Provider", vault.Provider)
-	h.Set("X-Kerberos-Storage-Device", deviceKey)
-	h.Set("X-Kerberos-Storage-Directory", vault.Directory)
-	h.Set("X-Kerberos-Storage-Capture", "IPCamera")
-	if fileName != "" {
-		h.Set("X-Kerberos-Storage-FileName", fileName)
-	}
-}
-
-// setHubTusHeaders sets the Kerberos Hub authentication headers on every tus
-// request of a hub-proxied resumable upload. The agent authenticates with its
-// Hub public/private key (exactly as the legacy single-POST hub upload does);
-// Kerberos Hub validates the subscription and injects the vault credentials and
-// directory/provider on the agent's behalf.
-func setHubTusHeaders(h http.Header, config *models.Config, fileName string) {
-	h.Set("X-Kerberos-Hub-PublicKey", config.HubKey)
-	h.Set("X-Kerberos-Hub-PrivateKey", config.HubPrivateKey)
-	h.Set("X-Kerberos-Hub-Region", config.S3.Region)
-	h.Set("X-Kerberos-Storage-Device", config.Key)
-	h.Set("X-Kerberos-Storage-Capture", "IPCamera")
-	if fileName != "" {
-		h.Set("X-Kerberos-Storage-FileName", fileName)
-	}
-}
-
-// encodeTusMetadata serializes a map into the tus Upload-Metadata header format:
-// a comma separated list of "key base64(value)" pairs. Keys are sorted for a
-// deterministic header value. Empty values are skipped.
-func encodeTusMetadata(pairs map[string]string) string {
-	parts := make([]string, 0, len(pairs))
-	for k, v := range pairs {
-		if v == "" {
-			continue
-		}
-		parts = append(parts, k+" "+base64.StdEncoding.EncodeToString([]byte(v)))
-	}
-	sort.Strings(parts)
-	return strings.Join(parts, ",")
-}
-
-// resolveTusLocation turns the Location header returned by the create request
-// into an absolute URL. To keep talking to the agent's configured vault host
-// (and avoid issues when the vault sits behind a proxy that rewrites the host),
-// it keeps the configured base URL and only appends the server-assigned upload
-// id taken from the Location.
-func resolveTusLocation(baseURL, location string) string {
-	if ref, err := url.Parse(location); err == nil {
-		trimmed := strings.Trim(ref.Path, "/")
-		if trimmed != "" {
-			segments := strings.Split(trimmed, "/")
-			id := segments[len(segments)-1]
-			if id != "" {
-				return strings.TrimRight(baseURL, "/") + "/" + id
-			}
-		}
-	}
-	// Fallback: resolve the reference against the base URL as-is.
-	if base, err := url.Parse(baseURL); err == nil {
-		if ref, err := url.Parse(location); err == nil {
-			return base.ResolveReference(ref).String()
-		}
-	}
-	return location
-}
-
-// tusSidecarDir is the directory where resume state files are kept. It is
-// intentionally separate from data/cloud (which is scanned for recordings to
-// upload) so the sidecar files are never mistaken for recordings.
-func tusSidecarDir() string {
-	return "data/tus"
-}
-
-func tusSidecarPath(fileName, slot string) string {
-	safe := strings.ReplaceAll(fileName, "/", "_")
-	safe = strings.ReplaceAll(safe, string(os.PathSeparator), "_")
-	return filepath.Join(tusSidecarDir(), safe+"."+slot+".json")
-}
-
-// loadTusResumeState returns a previously stored upload URL for the given
-// sidecar, but only if it was created against the same vault base URL. Any
-// mismatch or read/parse error yields an empty string (start fresh).
-func loadTusResumeState(path, baseURL string) string {
-	b, err := os.ReadFile(path)
-	if err != nil {
-		return ""
-	}
-	var state tusResumeState
-	if err := json.Unmarshal(b, &state); err != nil {
-		return ""
-	}
-	if state.UploadURL == "" || state.VaultURI != baseURL {
-		return ""
-	}
-	return state.UploadURL
-}
-
-func saveTusResumeState(path string, state tusResumeState) {
-	if err := os.MkdirAll(filepath.Dir(path), 0o755); err != nil {
-		return
-	}
-	b, err := json.Marshal(state)
-	if err != nil {
-		return
-	}
-	_ = os.WriteFile(path, b, 0o644)
-}
-
-func removeTusResumeState(path string) {
-	_ = os.Remove(path)
-}
-
-// tusBackoffBaseDelay is the base delay used by tusBackoff for the exponential
-// back-off between resume attempts. It is a package variable (rather than a
-// constant) so tests can shrink it to keep them fast.
-var tusBackoffBaseDelay = 500 * time.Millisecond
-
-// tusBackoff sleeps for an exponentially increasing duration (capped) between
-// resume attempts to avoid hammering a temporarily unavailable vault.
-func tusBackoff(attempt int) {
-	delay := tusBackoffBaseDelay * time.Duration(1<<uint(attempt))
-	if delay > 3*time.Second {
-		delay = 3 * time.Second
-	}
-	time.Sleep(delay)
-}

machinery/src/cloud/tus_client_test.go

@@ -1,882 +0,0 @@
-package cloud
-
-import (
-	"bytes"
-	"encoding/base64"
-	"fmt"
-	"io"
-	"net"
-	"net/http"
-	"net/http/httptest"
-	"os"
-	"path/filepath"
-	"strconv"
-	"strings"
-	"sync"
-	"testing"
-	"time"
-
-	"github.com/kerberos-io/agent/machinery/src/models"
-)
-
-// fakeUpload tracks the state of a single resumable upload on the fake server.
-type fakeUpload struct {
-	size   int64
-	offset int64
-}
-
-// recordedRequest captures the method and headers of a request received by the
-// fake tus server, so tests can assert the client's per-method auth headers.
-type recordedRequest struct {
-	method string
-	header http.Header
-}
-
-// fakeTus is a tiny in-memory implementation of the tus 1.0.0 server protocol,
-// sufficient to exercise the agent's resumable client.
-type fakeTus struct {
-	mu             sync.Mutex
-	uploads        map[string]*fakeUpload
-	counter        int
-	creates        int
-	lastPatchBytes int64
-	patchSizes     []int64
-
-	// unsupported makes the creation endpoint return 404, simulating an older
-	// vault without a tus endpoint.
-	unsupported bool
-	// failFinalize causes the next N completing PATCH requests to return 502
-	// after storing the bytes, simulating a failed completion hook.
-	failFinalize int
-
-	// loseProgress simulates a vault that never durably retains the in-progress
-	// upload: every PATCH is acknowledged (the response advertises the advanced
-	// offset) but the stored offset is immediately reset to 0. HEAD therefore
-	// keeps reporting 0 and the next chunk — sent at the advanced offset — is
-	// rejected with 409, reproducing the cross-replica ERR_MISMATCHED_OFFSET
-	// loop that previously wedged the agent's upload worker forever.
-	loseProgress bool
-
-	// requests records the headers of every received request (in order) so
-	// tests can assert which auth/routing headers the client sent per method.
-	requests []recordedRequest
-}
-
-func newFakeTus() *fakeTus {
-	return &fakeTus{uploads: map[string]*fakeUpload{}}
-}
-
-func (s *fakeTus) seed(size, offset int64) string {
-	s.mu.Lock()
-	defer s.mu.Unlock()
-	s.counter++
-	id := fmt.Sprintf("seed-%d", s.counter)
-	s.uploads[id] = &fakeUpload{size: size, offset: offset}
-	return id
-}
-
-func (s *fakeTus) totalBytes() int64 {
-	s.mu.Lock()
-	defer s.mu.Unlock()
-	var total int64
-	for _, u := range s.uploads {
-		total += u.offset
-	}
-	return total
-}
-
-func (s *fakeTus) lastPatch() int64 {
-	s.mu.Lock()
-	defer s.mu.Unlock()
-	return s.lastPatchBytes
-}
-
-// patchCounts returns the number of PATCH requests received and the size of each.
-func (s *fakeTus) patchCounts() (int, []int64) {
-	s.mu.Lock()
-	defer s.mu.Unlock()
-	sizes := make([]int64, len(s.patchSizes))
-	copy(sizes, s.patchSizes)
-	return len(s.patchSizes), sizes
-}
-
-func (s *fakeTus) createCount() int {
-	s.mu.Lock()
-	defer s.mu.Unlock()
-	return s.creates
-}
-
-// requestsForMethod returns the recorded requests for the given HTTP method.
-func (s *fakeTus) requestsForMethod(method string) []recordedRequest {
-	s.mu.Lock()
-	defer s.mu.Unlock()
-	var out []recordedRequest
-	for _, req := range s.requests {
-		if req.method == method {
-			out = append(out, req)
-		}
-	}
-	return out
-}
-
-func (s *fakeTus) ServeHTTP(w http.ResponseWriter, r *http.Request) {
-	id := strings.TrimPrefix(r.URL.Path, tusUploadPath)
-	w.Header().Set("Tus-Resumable", tusResumableVersion)
-
-	s.mu.Lock()
-	s.requests = append(s.requests, recordedRequest{method: r.Method, header: r.Header.Clone()})
-	s.mu.Unlock()
-
-	switch r.Method {
-	case http.MethodPost:
-		if s.unsupported {
-			w.WriteHeader(http.StatusNotFound)
-			return
-		}
-		length, _ := strconv.ParseInt(r.Header.Get("Upload-Length"), 10, 64)
-		s.mu.Lock()
-		s.counter++
-		s.creates++
-		newID := fmt.Sprintf("up-%d", s.counter)
-		s.uploads[newID] = &fakeUpload{size: length}
-		s.mu.Unlock()
-		w.Header().Set("Location", tusUploadPath+newID)
-		w.WriteHeader(http.StatusCreated)
-
-	case http.MethodHead:
-		s.mu.Lock()
-		u, ok := s.uploads[id]
-		s.mu.Unlock()
-		if !ok {
-			w.WriteHeader(http.StatusNotFound)
-			return
-		}
-		w.Header().Set("Upload-Offset", strconv.FormatInt(u.offset, 10))
-		w.Header().Set("Upload-Length", strconv.FormatInt(u.size, 10))
-		w.WriteHeader(http.StatusOK)
-
-	case http.MethodPatch:
-		s.mu.Lock()
-		u, ok := s.uploads[id]
-		s.mu.Unlock()
-		if !ok {
-			w.WriteHeader(http.StatusNotFound)
-			return
-		}
-		if s.loseProgress {
-			reqOffset, _ := strconv.ParseInt(r.Header.Get("Upload-Offset"), 10, 64)
-			s.mu.Lock()
-			cur := u.offset
-			if reqOffset != cur {
-				// The offset the client resumes from no longer matches what this
-				// "replica" retained, so reject like a vault returning
-				// ERR_MISMATCHED_OFFSET.
-				s.mu.Unlock()
-				w.Header().Set("Upload-Offset", strconv.FormatInt(cur, 10))
-				w.WriteHeader(http.StatusConflict)
-				return
-			}
-			n, _ := io.Copy(io.Discard, r.Body)
-			s.lastPatchBytes = n
-			s.patchSizes = append(s.patchSizes, n)
-			// Advertise progress to the client, then immediately forget it so the
-			// next chunk (sent at the advanced offset) mismatches again.
-			reported := cur + n
-			u.offset = 0
-			s.mu.Unlock()
-			w.Header().Set("Upload-Offset", strconv.FormatInt(reported, 10))
-			w.WriteHeader(http.StatusNoContent)
-			return
-		}
-		n, _ := io.Copy(io.Discard, r.Body)
-		s.mu.Lock()
-		u.offset += n
-		s.lastPatchBytes = n
-		s.patchSizes = append(s.patchSizes, n)
-		complete := u.offset >= u.size
-		failNow := complete && s.failFinalize > 0
-		if failNow {
-			s.failFinalize--
-		}
-		offset := u.offset
-		s.mu.Unlock()
-
-		w.Header().Set("Upload-Offset", strconv.FormatInt(offset, 10))
-		if failNow {
-			// Bytes are stored but the (simulated) completion hook failed.
-			w.WriteHeader(http.StatusBadGateway)
-			return
-		}
-		w.WriteHeader(http.StatusNoContent)
-
-	case http.MethodDelete:
-		s.mu.Lock()
-		delete(s.uploads, id)
-		s.mu.Unlock()
-		w.WriteHeader(http.StatusNoContent)
-
-	default:
-		w.WriteHeader(http.StatusMethodNotAllowed)
-	}
-}
-
-// withRecording switches into a fresh temp working directory containing a
-// recording at data/recordings/<fileName>. The working directory is restored on
-// cleanup. Tests using this helper must not run in parallel.
-func withRecording(t *testing.T, fileName string, payload []byte) {
-	t.Helper()
-	dir := t.TempDir()
-	old, err := os.Getwd()
-	if err != nil {
-		t.Fatalf("getwd: %v", err)
-	}
-	if err := os.Chdir(dir); err != nil {
-		t.Fatalf("chdir: %v", err)
-	}
-	t.Cleanup(func() { _ = os.Chdir(old) })
-
-	if err := os.MkdirAll("data/recordings", 0o755); err != nil {
-		t.Fatalf("mkdir recordings: %v", err)
-	}
-	if err := os.WriteFile(filepath.Join("data/recordings", fileName), payload, 0o644); err != nil {
-		t.Fatalf("write recording: %v", err)
-	}
-}
-
-func withQueuedRecordingFPS(t *testing.T, fileName, fps string) {
-	t.Helper()
-	if err := os.MkdirAll("data/cloud", 0o755); err != nil {
-		t.Fatalf("mkdir cloud queue: %v", err)
-	}
-	markerName := models.RecordingUploadMetadataFileName(fileName)
-	if err := os.WriteFile(filepath.Join("data/cloud", markerName), []byte(fps), 0o644); err != nil {
-		t.Fatalf("write cloud queue marker: %v", err)
-	}
-}
-
-func testVault(uri string) models.KStorage {
-	return models.KStorage{
-		URI:             uri,
-		AccessKey:       "ak",
-		SecretAccessKey: "sk",
-		Provider:        "gcp",
-		Directory:       "dir",
-	}
-}
-
-func TestUploadKerberosVaultSkipsEmptyRecording(t *testing.T) {
-	fileName := "1787015373_3-654_office-camera17_0-0-0-0_-1_1960.mp4"
-	withRecording(t, fileName, nil)
-
-	requestCount := 0
-	server := httptest.NewServer(http.HandlerFunc(func(w http.ResponseWriter, r *http.Request) {
-		requestCount++
-		w.WriteHeader(http.StatusInternalServerError)
-	}))
-	defer server.Close()
-
-	vault := testVault(server.URL)
-	configuration := &models.Configuration{Config: models.Config{
-		Key:               "device-key",
-		KStorage:          &vault,
-		KStorageSecondary: &models.KStorage{},
-	}}
-
-	uploaded, configured, err := UploadKerberosVault(configuration, fileName)
-	if err != nil {
-		t.Fatalf("UploadKerberosVault() error = %v", err)
-	}
-	if uploaded || configured {
-		t.Fatalf("UploadKerberosVault() uploaded/configured = %v/%v, want false/false", uploaded, configured)
-	}
-	if requestCount != 0 {
-		t.Fatalf("Vault received %d requests, want 0", requestCount)
-	}
-}
-
-func TestUploadVaultResumable_HappyPath(t *testing.T) {
-	srv := newFakeTus()
-	ts := httptest.NewServer(srv)
-	defer ts.Close()
-
-	fileName := "1564859471_6-474162_oprit_577-283-727-375_1153_27.mp4"
-	payload := bytes.Repeat([]byte("x"), 4096)
-	withRecording(t, fileName, payload)
-	withQueuedRecordingFPS(t, fileName, `{"filename":"recording.mp4","device_key":"device-key","timestamp":1785934709414,"duration":20452,"fps":29.97}`)
-
-	uploaded, responded, supported, _, err := uploadVaultResumable(testVault(ts.URL), "pk", "dev", fileName, "test", "primary")
-	if err != nil {
-		t.Fatalf("unexpected error: %v", err)
-	}
-	if !uploaded || !responded || !supported {
-		t.Fatalf("uploaded/responded/supported = %v/%v/%v, want all true", uploaded, responded, supported)
-	}
-	if got := srv.totalBytes(); got != int64(len(payload)) {
-		t.Fatalf("server received %d bytes, want %d", got, len(payload))
-	}
-	if _, err := os.Stat(tusSidecarPath(fileName, "primary")); !os.IsNotExist(err) {
-		t.Fatalf("expected sidecar to be removed after success, stat err = %v", err)
-	}
-	posts := srv.requestsForMethod(http.MethodPost)
-	metadata := decodeTusMetadata(posts[0].header.Get("Upload-Metadata"))
-	if got := metadata["fps"]; got != "29.97" {
-		t.Fatalf("POST metadata fps = %q, want %q", got, "29.97")
-	}
-	if got := metadata["duration"]; got != "20452" {
-		t.Fatalf("POST metadata duration = %q, want %q", got, "20452")
-	}
-	if got := metadata["timestamp"]; got != "1785934709414" {
-		t.Fatalf("POST metadata timestamp = %q, want %q", got, "1785934709414")
-	}
-}
-
-func TestQueuedRecordingFPSValidation(t *testing.T) {
-	for _, test := range []struct {
-		name string
-		fps  string
-		want string
-	}{
-		{name: "json", fps: `{"fps":29}`, want: "29"},
-		{name: "json fractional", fps: `{"fps":17.35}`, want: "17.35"},
-		{name: "json with future field", fps: `{"fps":29,"codec":"h264"}`, want: "29"},
-		{name: "json without fps", fps: `{}`},
-		{name: "json invalid fps", fps: `{"fps":241}`},
-		{name: "legacy fractional", fps: "29.97", want: "29.97"},
-		{name: "legacy trimmed", fps: " 25 \n", want: "25"},
-		{name: "empty"},
-		{name: "invalid", fps: "invalid"},
-		{name: "zero", fps: "0"},
-		{name: "negative", fps: "-1"},
-		{name: "nan", fps: "NaN"},
-		{name: "infinite", fps: "+Inf"},
-		{name: "unreasonable", fps: "241"},
-	} {
-		t.Run(test.name, func(t *testing.T) {
-			fileName := "recording.mp4"
-			withRecording(t, fileName, []byte("recording"))
-			withQueuedRecordingFPS(t, fileName, test.fps)
-
-			if got := queuedRecordingFPS(fileName); got != test.want {
-				t.Fatalf("queuedRecordingFPS() = %q, want %q", got, test.want)
-			}
-
-			header := make(http.Header)
-			setQueuedRecordingMetadataHeaders(header, fileName)
-			if got := header.Get(recordingFPSHeader); got != test.want {
-				t.Fatalf("legacy FPS header = %q, want %q", got, test.want)
-			}
-		})
-	}
-}
-
-func TestQueuedRecordingFPSAllowsMissingHistoricalMarker(t *testing.T) {
-	fileName := "recording.mp4"
-	withRecording(t, fileName, []byte("recording"))
-
-	if got := queuedRecordingFPS(fileName); got != "" {
-		t.Fatalf("queuedRecordingFPS() = %q, want empty for missing marker", got)
-	}
-	header := make(http.Header)
-	setQueuedRecordingMetadataHeaders(header, fileName)
-	if got := header.Get(recordingFPSHeader); got != "" {
-		t.Fatalf("legacy FPS header = %q, want empty for missing marker", got)
-	}
-}
-
-func TestQueuedRecordingMetadataHeaders(t *testing.T) {
-	fileName := "recording.mp4"
-	withRecording(t, fileName, []byte("recording"))
-	withQueuedRecordingFPS(t, fileName, `{"filename":"recording.mp4","device_key":"device-key","timestamp":1785934709414,"duration":20452,"fps":25}`)
-
-	header := make(http.Header)
-	setQueuedRecordingMetadataHeaders(header, fileName)
-	if got := header.Get(recordingFPSHeader); got != "25" {
-		t.Fatalf("FPS header = %q", got)
-	}
-	if got := header.Get(recordingDurationHeader); got != "20452" {
-		t.Fatalf("duration header = %q", got)
-	}
-	if got := header.Get(recordingTimestampHeader); got != "1785934709414" {
-		t.Fatalf("timestamp header = %q", got)
-	}
-}
-
-func TestQueuedRecordingFPSAllowsLegacyMarkerFileName(t *testing.T) {
-	fileName := "recording.mp4"
-	withRecording(t, fileName, []byte("recording"))
-	if err := os.MkdirAll("data/cloud", 0o755); err != nil {
-		t.Fatalf("mkdir cloud queue: %v", err)
-	}
-	if err := os.WriteFile(filepath.Join("data/cloud", fileName), []byte("25"), 0o644); err != nil {
-		t.Fatalf("write legacy cloud queue marker: %v", err)
-	}
-
-	if got := queuedRecordingFPS(fileName); got != "25" {
-		t.Fatalf("queuedRecordingFPS() = %q, want legacy marker FPS", got)
-	}
-}
-
-func TestUploadVaultResumable_Chunked(t *testing.T) {
-	srv := newFakeTus()
-	ts := httptest.NewServer(srv)
-	defer ts.Close()
-
-	fileName := "1564859471_6-474162_oprit_577-283-727-375_1153_27.mp4"
-	// 10 KiB payload uploaded in 4 KiB chunks => 3 PATCH requests (4096+4096+2048).
-	payload := bytes.Repeat([]byte("c"), 10240)
-	withRecording(t, fileName, payload)
-	t.Setenv("AGENT_TUS_CHUNK_SIZE_BYTES", "4096")
-
-	uploaded, _, supported, _, err := uploadVaultResumable(testVault(ts.URL), "pk", "dev", fileName, "test", "primary")
-	if err != nil {
-		t.Fatalf("unexpected error: %v", err)
-	}
-	if !uploaded || !supported {
-		t.Fatalf("expected chunked upload success, got uploaded=%v supported=%v", uploaded, supported)
-	}
-	if got := srv.totalBytes(); got != int64(len(payload)) {
-		t.Fatalf("server received %d bytes, want %d", got, len(payload))
-	}
-	count, sizes := srv.patchCounts()
-	if count != 3 {
-		t.Fatalf("expected 3 chunked PATCH requests, got %d (sizes=%v)", count, sizes)
-	}
-	want := []int64{4096, 4096, 2048}
-	for i, w := range want {
-		if sizes[i] != w {
-			t.Fatalf("chunk %d size = %d, want %d (sizes=%v)", i, sizes[i], w, sizes)
-		}
-	}
-	if _, err := os.Stat(tusSidecarPath(fileName, "primary")); !os.IsNotExist(err) {
-		t.Fatalf("expected sidecar removed after success, stat err = %v", err)
-	}
-}
-
-func TestUploadVaultResumable_ChunkingDisabled(t *testing.T) {
-	srv := newFakeTus()
-	ts := httptest.NewServer(srv)
-	defer ts.Close()
-
-	fileName := "1564859471_6-474162_oprit_577-283-727-375_1153_27.mp4"
-	payload := bytes.Repeat([]byte("d"), 10240)
-	withRecording(t, fileName, payload)
-	// 0 disables chunking: the whole file should go out in a single PATCH.
-	t.Setenv("AGENT_TUS_CHUNK_SIZE_BYTES", "0")
-
-	uploaded, _, supported, _, err := uploadVaultResumable(testVault(ts.URL), "pk", "dev", fileName, "test", "primary")
-	if err != nil {
-		t.Fatalf("unexpected error: %v", err)
-	}
-	if !uploaded || !supported {
-		t.Fatalf("expected success, got uploaded=%v supported=%v", uploaded, supported)
-	}
-	count, sizes := srv.patchCounts()
-	if count != 1 {
-		t.Fatalf("expected a single PATCH when chunking is disabled, got %d (sizes=%v)", count, sizes)
-	}
-	if sizes[0] != int64(len(payload)) {
-		t.Fatalf("single PATCH size = %d, want %d", sizes[0], len(payload))
-	}
-}
-
-func TestTusChunkSize(t *testing.T) {
-	cases := []struct {
-		name string
-		env  string
-		set  bool
-		want int64
-	}{
-		{name: "default when unset", set: false, want: tusDefaultChunkSize},
-		{name: "default on invalid", env: "notanumber", set: true, want: tusDefaultChunkSize},
-		{name: "explicit value", env: "65536", set: true, want: 65536},
-		{name: "zero disables", env: "0", set: true, want: 0},
-		{name: "negative disables", env: "-5", set: true, want: 0},
-	}
-	for _, tc := range cases {
-		t.Run(tc.name, func(t *testing.T) {
-			if tc.set {
-				t.Setenv("AGENT_TUS_CHUNK_SIZE_BYTES", tc.env)
-			} else {
-				t.Setenv("AGENT_TUS_CHUNK_SIZE_BYTES", "")
-			}
-			if got := tusChunkSize(); got != tc.want {
-				t.Fatalf("tusChunkSize() = %d, want %d", got, tc.want)
-			}
-		})
-	}
-}
-
-func TestUploadVaultResumable_Unsupported(t *testing.T) {
-	srv := newFakeTus()
-	srv.unsupported = true
-	ts := httptest.NewServer(srv)
-	defer ts.Close()
-
-	fileName := "f.mp4"
-	withRecording(t, fileName, []byte("hello"))
-
-	uploaded, _, supported, _, _ := uploadVaultResumable(testVault(ts.URL), "pk", "dev", fileName, "test", "primary")
-	if uploaded {
-		t.Fatal("expected uploaded=false against a vault without a tus endpoint")
-	}
-	if supported {
-		t.Fatal("expected supported=false so the caller falls back to the legacy upload")
-	}
-}
-
-// TestUploadVaultResumable_NetworkErrorKeepsRetryBudget verifies that when the
-// vault is unreachable (mimicking the internet being disconnected) the resumable
-// upload reports responded=false. That is what stops the caller
-// (UploadKerberosVault) from consuming its retry budget and entering the long
-// back-off timeout on a transient network outage, so the recording keeps being
-// retried until connectivity returns.
-func TestUploadVaultResumable_NetworkErrorKeepsRetryBudget(t *testing.T) {
-	// Bind then immediately release a loopback port so every connection to it is
-	// refused, producing a transport-level error (no HTTP response).
-	ln, err := net.Listen("tcp", "127.0.0.1:0")
-	if err != nil {
-		t.Fatalf("listen: %v", err)
-	}
-	addr := ln.Addr().String()
-	if cerr := ln.Close(); cerr != nil {
-		t.Fatalf("close listener: %v", cerr)
-	}
-
-	// Keep the between-attempt back-off tiny so the test stays fast.
-	oldDelay := tusBackoffBaseDelay
-	tusBackoffBaseDelay = time.Millisecond
-	defer func() { tusBackoffBaseDelay = oldDelay }()
-
-	fileName := "1564859471_6-474162_oprit_577-283-727-375_1153_27.mp4"
-	withRecording(t, fileName, bytes.Repeat([]byte("n"), 2048))
-
-	uploaded, responded, supported, _, err := uploadVaultResumable(testVault("http://"+addr), "pk", "dev", fileName, "test", "primary")
-	if uploaded {
-		t.Fatal("expected uploaded=false when the vault is unreachable")
-	}
-	if !supported {
-		t.Fatal("a transport error is not a missing tus endpoint; expected supported=true")
-	}
-	if responded {
-		t.Fatal("expected responded=false for a pure network error so the retry budget is preserved")
-	}
-	if err == nil {
-		t.Fatal("expected an error when the vault is unreachable")
-	}
-}
-
-func TestUploadVaultResumable_MismatchedOffsetGivesUp(t *testing.T) {
-	// A vault that never durably retains the in-progress upload (offset resets to
-	// 0 between chunks) makes every resume "progress" by one chunk and then fail
-	// the next chunk with 409. Before the high-water gating fix this refreshed the
-	// retry budget every attempt and looped forever, wedging the upload worker and
-	// saturating the uplink (which starved heartbeats and reported the camera
-	// offline). The loop must now be bounded: give up after a fixed number of
-	// non-progressing attempts and report responded=true so the caller re-queues.
-	srv := newFakeTus()
-	srv.loseProgress = true
-	ts := httptest.NewServer(srv)
-	defer ts.Close()
-
-	// Keep the between-attempt back-off tiny so the test stays fast.
-	oldDelay := tusBackoffBaseDelay
-	tusBackoffBaseDelay = time.Millisecond
-	defer func() { tusBackoffBaseDelay = oldDelay }()
-
-	// Force multiple chunks so there is always a second chunk to be rejected.
-	t.Setenv("AGENT_TUS_CHUNK_SIZE_BYTES", "4096")
-
-	fileName := "1564859471_6-474162_oprit_577-283-727-375_1153_27.mp4"
-	withRecording(t, fileName, bytes.Repeat([]byte("m"), 12288))
-
-	done := make(chan struct{})
-	var uploaded, responded bool
-	var upErr error
-	go func() {
-		uploaded, responded, _, _, upErr = uploadVaultResumable(testVault(ts.URL), "pk", "dev", fileName, "test", "primary")
-		close(done)
-	}()
-
-	select {
-	case <-done:
-	case <-time.After(30 * time.Second):
-		t.Fatal("resumable upload did not terminate: the retry loop is unbounded on a persistent mismatched offset")
-	}
-
-	if uploaded {
-		t.Fatal("expected uploaded=false when the vault never retains the offset")
-	}
-	if !responded {
-		t.Fatal("expected responded=true (the vault answered) so the caller re-queues the recording")
-	}
-	if upErr == nil {
-		t.Fatal("expected an error when the upload cannot complete")
-	}
-
-	// The bounded retry budget must cap the number of PATCH requests. Two PATCHes
-	// per attempt across a handful of attempts stays comfortably below this.
-	if count, _ := srv.patchCounts(); count > 50 {
-		t.Fatalf("expected a bounded number of PATCH requests, got %d (retry loop not bounded)", count)
-	}
-}
-
-func TestUploadVaultResumable_FinalizeRetry(t *testing.T) {
-	srv := newFakeTus()
-	srv.failFinalize = 1
-	ts := httptest.NewServer(srv)
-	defer ts.Close()
-
-	fileName := "1564859471_6-474162_oprit_577-283-727-375_1153_27.mp4"
-	payload := bytes.Repeat([]byte("y"), 2048)
-	withRecording(t, fileName, payload)
-
-	uploaded, _, supported, _, err := uploadVaultResumable(testVault(ts.URL), "pk", "dev", fileName, "test", "primary")
-	if err != nil {
-		t.Fatalf("unexpected error: %v", err)
-	}
-	if !uploaded || !supported {
-		t.Fatalf("expected success after a failed finalize + restart, got uploaded=%v supported=%v", uploaded, supported)
-	}
-	if got := srv.createCount(); got < 2 {
-		t.Fatalf("expected at least 2 create requests (restart after failed finalize), got %d", got)
-	}
-}
-
-func TestUploadVaultResumable_ResumeFromSidecar(t *testing.T) {
-	srv := newFakeTus()
-	ts := httptest.NewServer(srv)
-	defer ts.Close()
-
-	fileName := "1564859471_6-474162_oprit_577-283-727-375_1153_27.mp4"
-	total := 8192
-	half := 4096
-	payload := bytes.Repeat([]byte("z"), total)
-	withRecording(t, fileName, payload)
-
-	// Simulate a previous run that uploaded half the file before being interrupted.
-	id := srv.seed(int64(total), int64(half))
-	baseURL := strings.TrimRight(ts.URL, "/") + tusUploadPath
-	saveTusResumeState(tusSidecarPath(fileName, "primary"), tusResumeState{
-		UploadURL: strings.TrimRight(baseURL, "/") + "/" + id,
-		VaultURI:  baseURL,
-		Size:      int64(total),
-	})
-
-	uploaded, _, supported, _, err := uploadVaultResumable(testVault(ts.URL), "pk", "dev", fileName, "test", "primary")
-	if err != nil {
-		t.Fatalf("unexpected error: %v", err)
-	}
-	if !uploaded || !supported {
-		t.Fatalf("expected resume success, got uploaded=%v supported=%v", uploaded, supported)
-	}
-	if got := srv.lastPatch(); got != int64(total-half) {
-		t.Fatalf("resume should only send the remaining %d bytes, sent %d", total-half, got)
-	}
-	if srv.createCount() != 0 {
-		t.Fatalf("resume should not create a new upload, got %d creates", srv.createCount())
-	}
-}
-
-func testHubConfig(hubURI string) *models.Config {
-	return &models.Config{
-		Key:           "device-key",
-		HubURI:        hubURI,
-		HubKey:        "hubpub",
-		HubPrivateKey: "hubpriv",
-		S3:            &models.S3{Region: "eu-west"},
-	}
-}
-
-// decodeTusMetadata parses a tus Upload-Metadata header value ("key b64,key b64")
-// back into a map of decoded key/value pairs.
-func decodeTusMetadata(meta string) map[string]string {
-	out := map[string]string{}
-	if meta == "" {
-		return out
-	}
-	for _, pair := range strings.Split(meta, ",") {
-		parts := strings.SplitN(strings.TrimSpace(pair), " ", 2)
-		if parts[0] == "" {
-			continue
-		}
-		val := ""
-		if len(parts) == 2 {
-			if b, err := base64.StdEncoding.DecodeString(parts[1]); err == nil {
-				val = string(b)
-			}
-		}
-		out[parts[0]] = val
-	}
-	return out
-}
-
-func TestUploadHubResumable_HappyPath(t *testing.T) {
-	srv := newFakeTus()
-	ts := httptest.NewServer(srv)
-	defer ts.Close()
-
-	fileName := "1564859471_6-474162_oprit_577-283-727-375_1153_27.mp4"
-	payload := bytes.Repeat([]byte("h"), 4096)
-	withRecording(t, fileName, payload)
-	withQueuedRecordingFPS(t, fileName, "29.97")
-
-	uploaded, _, supported, _, err := uploadHubResumable(testHubConfig(ts.URL), fileName, "test", "hub")
-	if err != nil {
-		t.Fatalf("unexpected error: %v", err)
-	}
-	if !uploaded || !supported {
-		t.Fatalf("uploaded/supported = %v/%v, want both true", uploaded, supported)
-	}
-	if got := srv.totalBytes(); got != int64(len(payload)) {
-		t.Fatalf("server received %d bytes, want %d", got, len(payload))
-	}
-
-	// The Hub auth headers must be present on every request type (POST/HEAD/PATCH),
-	// because Kerberos Hub validates them on each proxied request. Conversely the
-	// vault credentials/routing are injected by Kerberos Hub on the agent's behalf
-	// and must never be sent by the agent on the hub path.
-	for _, method := range []string{http.MethodPost, http.MethodHead, http.MethodPatch} {
-		reqs := srv.requestsForMethod(method)
-		if len(reqs) == 0 {
-			t.Fatalf("expected at least one %s request", method)
-		}
-		for _, req := range reqs {
-			if got := req.header.Get("X-Kerberos-Hub-PublicKey"); got != "hubpub" {
-				t.Errorf("%s: X-Kerberos-Hub-PublicKey = %q, want %q", method, got, "hubpub")
-			}
-			if got := req.header.Get("X-Kerberos-Hub-PrivateKey"); got != "hubpriv" {
-				t.Errorf("%s: X-Kerberos-Hub-PrivateKey = %q, want %q", method, got, "hubpriv")
-			}
-			if got := req.header.Get("X-Kerberos-Hub-Region"); got != "eu-west" {
-				t.Errorf("%s: X-Kerberos-Hub-Region = %q, want %q", method, got, "eu-west")
-			}
-			if got := req.header.Get("X-Kerberos-Storage-Device"); got != "device-key" {
-				t.Errorf("%s: X-Kerberos-Storage-Device = %q, want %q", method, got, "device-key")
-			}
-			for _, h := range []string{
-				"X-Kerberos-Storage-AccessKey",
-				"X-Kerberos-Storage-SecretAccessKey",
-				"X-Kerberos-Storage-CloudKey",
-				"X-Kerberos-Storage-Provider",
-				"X-Kerberos-Storage-Directory",
-			} {
-				if got := req.header.Get(h); got != "" {
-					t.Errorf("%s: %s should be empty on the hub path, got %q", method, h, got)
-				}
-			}
-		}
-	}
-
-	// The creation request carries the upload metadata; on the hub path it must
-	// omit directory/provider/cloudkey (Hub resolves those) but include
-	// filename/device/capture. The filename header is also set on create.
-	posts := srv.requestsForMethod(http.MethodPost)
-	if got := posts[0].header.Get("X-Kerberos-Storage-FileName"); got != fileName {
-		t.Errorf("POST X-Kerberos-Storage-FileName = %q, want %q", got, fileName)
-	}
-	meta := decodeTusMetadata(posts[0].header.Get("Upload-Metadata"))
-	for _, omitted := range []string{"directory", "provider", "cloudkey"} {
-		if _, ok := meta[omitted]; ok {
-			t.Errorf("hub metadata must omit %q, got %v", omitted, meta)
-		}
-	}
-	if meta["filename"] != fileName {
-		t.Errorf("hub metadata filename = %q, want %q", meta["filename"], fileName)
-	}
-	if meta["device"] != "device-key" {
-		t.Errorf("hub metadata device = %q, want %q", meta["device"], "device-key")
-	}
-	if meta["capture"] != "IPCamera" {
-		t.Errorf("hub metadata capture = %q, want %q", meta["capture"], "IPCamera")
-	}
-	if meta["fps"] != "29.97" {
-		t.Errorf("hub metadata fps = %q, want %q", meta["fps"], "29.97")
-	}
-}
-
-func TestUploadHubResumable_Unsupported(t *testing.T) {
-	srv := newFakeTus()
-	srv.unsupported = true
-	ts := httptest.NewServer(srv)
-	defer ts.Close()
-
-	fileName := "f.mp4"
-	withRecording(t, fileName, []byte("hello"))
-
-	uploaded, _, supported, _, _ := uploadHubResumable(testHubConfig(ts.URL), fileName, "test", "hub")
-	if uploaded {
-		t.Fatal("expected uploaded=false against a hub without a tus endpoint")
-	}
-	if supported {
-		t.Fatal("expected supported=false so the caller falls back to the legacy upload")
-	}
-}
-
-func TestEncodeTusMetadata(t *testing.T) {
-	got := encodeTusMetadata(map[string]string{
-		"b":     "2",
-		"a":     "1",
-		"empty": "",
-	})
-	// keys sorted, empty values skipped, values base64-encoded.
-	want := "a MQ==,b Mg=="
-	if got != want {
-		t.Fatalf("encodeTusMetadata = %q, want %q", got, want)
-	}
-}
-
-func TestResolveTusLocation(t *testing.T) {
-	cases := []struct {
-		name     string
-		base     string
-		location string
-		want     string
-	}{
-		{
-			name:     "absolute path location",
-			base:     "http://host/storage/tus/",
-			location: "/storage/tus/abc",
-			want:     "http://host/storage/tus/abc",
-		},
-		{
-			name:     "absolute url keeps configured host",
-			base:     "http://host/storage/tus/",
-			location: "http://internal:8080/storage/tus/xyz",
-			want:     "http://host/storage/tus/xyz",
-		},
-		{
-			name:     "relative id",
-			base:     "http://host/api/storage/tus/",
-			location: "abc",
-			want:     "http://host/api/storage/tus/abc",
-		},
-	}
-	for _, tc := range cases {
-		t.Run(tc.name, func(t *testing.T) {
-			if got := resolveTusLocation(tc.base, tc.location); got != tc.want {
-				t.Fatalf("resolveTusLocation(%q, %q) = %q, want %q", tc.base, tc.location, got, tc.want)
-			}
-		})
-	}
-}
-
-func TestTusResumeStateRoundTrip(t *testing.T) {
-	dir := t.TempDir()
-	old, _ := os.Getwd()
-	if err := os.Chdir(dir); err != nil {
-		t.Fatalf("chdir: %v", err)
-	}
-	defer os.Chdir(old)
-
-	path := tusSidecarPath("file.mp4", "primary")
-	state := tusResumeState{UploadURL: "http://host/storage/tus/abc", VaultURI: "http://host/storage/tus/", Size: 123}
-	saveTusResumeState(path, state)
-
-	if got := loadTusResumeState(path, state.VaultURI); got != state.UploadURL {
-		t.Fatalf("loadTusResumeState = %q, want %q", got, state.UploadURL)
-	}
-	// A mismatched vault URI must not be reused.
-	if got := loadTusResumeState(path, "http://other/storage/tus/"); got != "" {
-		t.Fatalf("loadTusResumeState with mismatched vault = %q, want empty", got)
-	}
-}

machinery/src/components/Kerberos.go

@@ -0,0 +1,387 @@
+package components
+
+import (
+	"context"
+	"runtime"
+	"strconv"
+	"sync"
+	"sync/atomic"
+	"time"
+
+	mqtt "github.com/eclipse/paho.mqtt.golang"
+	"github.com/kerberos-io/joy4/cgo/ffmpeg"
+
+	"github.com/kerberos-io/agent/machinery/src/capture"
+	"github.com/kerberos-io/agent/machinery/src/cloud"
+	"github.com/kerberos-io/agent/machinery/src/computervision"
+	configService "github.com/kerberos-io/agent/machinery/src/config"
+	"github.com/kerberos-io/agent/machinery/src/log"
+	"github.com/kerberos-io/agent/machinery/src/models"
+	"github.com/kerberos-io/agent/machinery/src/onvif"
+	routers "github.com/kerberos-io/agent/machinery/src/routers/mqtt"
+	"github.com/kerberos-io/joy4/av"
+	"github.com/kerberos-io/joy4/av/pubsub"
+	"github.com/tevino/abool"
+)
+
+func Bootstrap(configDirectory string, configuration *models.Configuration, communication *models.Communication) {
+	log.Log.Debug("Bootstrap: started")
+
+	// We will keep track of the Kerberos Agent up time
+	// This is send to Kerberos Hub in a heartbeat.
+	uptimeStart := time.Now()
+
+	// Initiate the packet counter, this is being used to detect
+	// if a camera is going blocky, or got disconnected.
+	var packageCounter atomic.Value
+	packageCounter.Store(int64(0))
+	communication.PackageCounter = &packageCounter
+
+	// This is used when the last packet was received (timestamp),
+	// this metric is used to determine if the camera is still online/connected.
+	var lastPacketTimer atomic.Value
+	packageCounter.Store(int64(0))
+	communication.LastPacketTimer = &lastPacketTimer
+
+	// This is used to understand if we have a working Kerberos Hub connection
+	// cloudTimestamp will be updated when successfully sending heartbeats.
+	var cloudTimestamp atomic.Value
+	cloudTimestamp.Store(int64(0))
+	communication.CloudTimestamp = &cloudTimestamp
+
+	communication.HandleStream = make(chan string, 1)
+	communication.HandleSubStream = make(chan string, 1)
+	communication.HandleUpload = make(chan string, 1)
+	communication.HandleHeartBeat = make(chan string, 1)
+	communication.HandleLiveSD = make(chan int64, 1)
+	communication.HandleLiveHDKeepalive = make(chan string, 1)
+	communication.HandleLiveHDPeers = make(chan string, 1)
+	communication.HandleONVIF = make(chan models.OnvifAction, 1)
+	communication.IsConfiguring = abool.New()
+
+	// Before starting the agent, we have a control goroutine, that might
+	// do several checks to see if the agent is still operational.
+	go ControlAgent(communication)
+
+	// Create some global variables
+	decoder := &ffmpeg.VideoDecoder{}
+	subDecoder := &ffmpeg.VideoDecoder{}
+	cameraSettings := &models.Camera{}
+
+	// Handle heartbeats
+	go cloud.HandleHeartBeat(configuration, communication, uptimeStart)
+
+	// We'll create a MQTT handler, which will be used to communicate with Kerberos Hub.
+	// Configure a MQTT client which helps for a bi-directional communication
+	mqttClient := routers.ConfigureMQTT(configDirectory, configuration, communication)
+
+	// Run the agent and fire up all the other
+	// goroutines which do image capture, motion detection, onvif, etc.
+	for {
+
+		// This will blocking until receiving a signal to be restarted, reconfigured, stopped, etc.
+		status := RunAgent(configDirectory, configuration, communication, mqttClient, uptimeStart, cameraSettings, decoder, subDecoder)
+
+		if status == "stop" {
+			break
+		}
+
+		if status == "not started" {
+			// We will re open the configuration, might have changed :O!
+			configService.OpenConfig(configDirectory, configuration)
+			// We will override the configuration with the environment variables
+			configService.OverrideWithEnvironmentVariables(configuration)
+		}
+
+		// Reset the MQTT client, might have provided new information, so we need to reconnect.
+		if routers.HasMQTTClientModified(configuration) {
+			routers.DisconnectMQTT(mqttClient, &configuration.Config)
+			mqttClient = routers.ConfigureMQTT(configDirectory, configuration, communication)
+		}
+
+		// We will create a new cancelable context, which will be used to cancel and restart.
+		// This is used to restart the agent when the configuration is updated.
+		ctx, cancel := context.WithCancel(context.Background())
+		communication.Context = &ctx
+		communication.CancelContext = &cancel
+	}
+	log.Log.Debug("Bootstrap: finished")
+}
+
+func RunAgent(configDirectory string, configuration *models.Configuration, communication *models.Communication, mqttClient mqtt.Client, uptimeStart time.Time, cameraSettings *models.Camera, decoder *ffmpeg.VideoDecoder, subDecoder *ffmpeg.VideoDecoder) string {
+
+	log.Log.Debug("RunAgent: bootstrapping agent")
+	config := configuration.Config
+
+	status := "not started"
+
+	// Currently only support H264 encoded cameras, this will change.
+	// Establishing the camera connection
+	rtspUrl := config.Capture.IPCamera.RTSP
+	infile, streams, err := capture.OpenRTSP(context.Background(), rtspUrl)
+
+	// We will initialise the camera settings object
+	// so we can check if the camera settings have changed, and we need
+	// to reload the decoders.
+
+	videoStream, _ := capture.GetVideoStream(streams)
+	if videoStream == nil {
+		log.Log.Error("RunAgent: no video stream found, might be the wrong codec (we only support H264 for the moment)")
+		time.Sleep(time.Second * 3)
+		return status
+	}
+
+	num, denum := videoStream.(av.VideoCodecData).Framerate()
+	width := videoStream.(av.VideoCodecData).Width()
+	height := videoStream.(av.VideoCodecData).Height()
+
+	// Set config values as well
+	configuration.Config.Capture.IPCamera.Width = width
+	configuration.Config.Capture.IPCamera.Height = height
+
+	var queue *pubsub.Queue
+	var subQueue *pubsub.Queue
+
+	var decoderMutex sync.Mutex
+	var subDecoderMutex sync.Mutex
+
+	if err == nil {
+
+		log.Log.Info("RunAgent: opened RTSP stream: " + rtspUrl)
+
+		// We might have a secondary rtsp url, so we might need to use that.
+		var subInfile av.DemuxCloser
+		var subStreams []av.CodecData
+		subStreamEnabled := false
+		subRtspUrl := config.Capture.IPCamera.SubRTSP
+		if subRtspUrl != "" && subRtspUrl != rtspUrl {
+			subInfile, subStreams, err = capture.OpenRTSP(context.Background(), subRtspUrl)
+			if err == nil {
+				log.Log.Info("RunAgent: opened RTSP sub stream " + subRtspUrl)
+				subStreamEnabled = true
+			}
+
+			videoStream, _ := capture.GetVideoStream(subStreams)
+			if videoStream == nil {
+				log.Log.Error("RunAgent: no video substream found, might be the wrong codec (we only support H264 for the moment)")
+				time.Sleep(time.Second * 3)
+				return status
+			}
+
+			width := videoStream.(av.VideoCodecData).Width()
+			height := videoStream.(av.VideoCodecData).Height()
+
+			// Set config values as well
+			configuration.Config.Capture.IPCamera.Width = width
+			configuration.Config.Capture.IPCamera.Height = height
+		}
+
+		if cameraSettings.RTSP != rtspUrl || cameraSettings.SubRTSP != subRtspUrl || cameraSettings.Width != width || cameraSettings.Height != height || cameraSettings.Num != num || cameraSettings.Denum != denum || cameraSettings.Codec != videoStream.(av.VideoCodecData).Type() {
+
+			if cameraSettings.RTSP != "" && cameraSettings.SubRTSP != "" && cameraSettings.Initialized {
+				decoder.Close()
+				if subStreamEnabled {
+					subDecoder.Close()
+				}
+			}
+
+			// At some routines we will need to decode the image.
+			// Make sure its properly locked as we only have a single decoder.
+			log.Log.Info("RunAgent: camera settings changed, reloading decoder")
+			capture.GetVideoDecoder(decoder, streams)
+			if subStreamEnabled {
+				capture.GetVideoDecoder(subDecoder, subStreams)
+			}
+
+			cameraSettings.RTSP = rtspUrl
+			cameraSettings.SubRTSP = subRtspUrl
+			cameraSettings.Width = width
+			cameraSettings.Height = height
+			cameraSettings.Framerate = float64(num) / float64(denum)
+			cameraSettings.Num = num
+			cameraSettings.Denum = denum
+			cameraSettings.Codec = videoStream.(av.VideoCodecData).Type()
+			cameraSettings.Initialized = true
+
+		} else {
+			log.Log.Info("RunAgent: camera settings did not change, keeping decoder")
+		}
+
+		communication.Decoder = decoder
+		communication.SubDecoder = subDecoder
+		communication.DecoderMutex = &decoderMutex
+		communication.SubDecoderMutex = &subDecoderMutex
+
+		// Create a packet queue, which is filled by the HandleStream routing
+		// and consumed by all other routines: motion, livestream, etc.
+		if config.Capture.PreRecording <= 0 {
+			config.Capture.PreRecording = 1
+			log.Log.Warning("RunAgent: Prerecording value not found in config or invalid value! Found: " + strconv.FormatInt(config.Capture.PreRecording, 10))
+		}
+
+		// We are creating a queue to store the RTSP frames in, these frames will be
+		// processed by the different consumers: motion detection, recording, etc.
+		queue = pubsub.NewQueue()
+		communication.Queue = queue
+		queue.SetMaxGopCount(int(config.Capture.PreRecording) + 1) // GOP time frame is set to prerecording (we'll add 2 gops to leave some room).
+		log.Log.Info("RunAgent: SetMaxGopCount was set with: " + strconv.Itoa(int(config.Capture.PreRecording)+1))
+		queue.WriteHeader(streams)
+
+		// We might have a substream, if so we'll create a seperate queue.
+		if subStreamEnabled {
+			log.Log.Info("RunAgent: Creating sub stream queue with SetMaxGopCount set to " + strconv.Itoa(int(1)))
+			subQueue = pubsub.NewQueue()
+			communication.SubQueue = subQueue
+			subQueue.SetMaxGopCount(1)
+			subQueue.WriteHeader(subStreams)
+		}
+
+		// Handle the camera stream
+		go capture.HandleStream(infile, queue, communication)
+
+		// Handle the substream if enabled
+		if subStreamEnabled {
+			go capture.HandleSubStream(subInfile, subQueue, communication)
+		}
+
+		// Handle processing of motion
+		communication.HandleMotion = make(chan models.MotionDataPartial, 1)
+		if subStreamEnabled {
+			motionCursor := subQueue.Latest()
+			go computervision.ProcessMotion(motionCursor, configuration, communication, mqttClient, subDecoder, &subDecoderMutex)
+		} else {
+			motionCursor := queue.Latest()
+			go computervision.ProcessMotion(motionCursor, configuration, communication, mqttClient, decoder, &decoderMutex)
+		}
+
+		// Handle livestream SD (low resolution over MQTT)
+		if subStreamEnabled {
+			livestreamCursor := subQueue.Latest()
+			go cloud.HandleLiveStreamSD(livestreamCursor, configuration, communication, mqttClient, subDecoder, &subDecoderMutex)
+		} else {
+			livestreamCursor := queue.Latest()
+			go cloud.HandleLiveStreamSD(livestreamCursor, configuration, communication, mqttClient, decoder, &decoderMutex)
+		}
+
+		// Handle livestream HD (high resolution over WEBRTC)
+		communication.HandleLiveHDHandshake = make(chan models.SDPPayload, 1)
+		if subStreamEnabled {
+			livestreamHDCursor := subQueue.Latest()
+			go cloud.HandleLiveStreamHD(livestreamHDCursor, configuration, communication, mqttClient, subStreams, subDecoder, &decoderMutex)
+		} else {
+			livestreamHDCursor := queue.Latest()
+			go cloud.HandleLiveStreamHD(livestreamHDCursor, configuration, communication, mqttClient, streams, decoder, &decoderMutex)
+		}
+
+		// Handle recording, will write an mp4 to disk.
+		go capture.HandleRecordStream(queue, configDirectory, configuration, communication, streams)
+
+		// Handle Upload to cloud provider (Kerberos Hub, Kerberos Vault and others)
+		go cloud.HandleUpload(configDirectory, configuration, communication)
+
+		// Handle ONVIF actions
+		go onvif.HandleONVIFActions(configuration, communication)
+
+		// If we reach this point, we have a working RTSP connection.
+		communication.CameraConnected = true
+
+		// !!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!
+		// This will go into a blocking state, once this channel is triggered
+		// the agent will cleanup and restart.
+
+		status = <-communication.HandleBootstrap
+
+		// If we reach this point, we are stopping the stream.
+		communication.CameraConnected = false
+
+		// Cancel the main context, this will stop all the other goroutines.
+		(*communication.CancelContext)()
+
+		// We will re open the configuration, might have changed :O!
+		configService.OpenConfig(configDirectory, configuration)
+
+		// We will override the configuration with the environment variables
+		configService.OverrideWithEnvironmentVariables(configuration)
+
+		// Here we are cleaning up everything!
+		if configuration.Config.Offline != "true" {
+			communication.HandleUpload <- "stop"
+		}
+		communication.HandleStream <- "stop"
+		if subStreamEnabled {
+			communication.HandleSubStream <- "stop"
+		}
+
+		time.Sleep(time.Second * 3)
+
+		infile.Close()
+		infile = nil
+		queue.Close()
+		queue = nil
+		communication.Queue = nil
+		if subStreamEnabled {
+			subInfile.Close()
+			subInfile = nil
+			subQueue.Close()
+			subQueue = nil
+			communication.SubQueue = nil
+		}
+		close(communication.HandleMotion)
+		communication.HandleMotion = nil
+
+		// Waiting for some seconds to make sure everything is properly closed.
+		log.Log.Info("RunAgent: waiting 3 seconds to make sure everything is properly closed.")
+		time.Sleep(time.Second * 3)
+
+	} else {
+		log.Log.Error("Something went wrong while opening RTSP: " + err.Error())
+		time.Sleep(time.Second * 3)
+	}
+
+	log.Log.Debug("RunAgent: finished")
+
+	// Clean up, force garbage collection
+	runtime.GC()
+
+	return status
+}
+
+func ControlAgent(communication *models.Communication) {
+	log.Log.Debug("ControlAgent: started")
+	packageCounter := communication.PackageCounter
+	go func() {
+		// A channel to check the camera activity
+		var previousPacket int64 = 0
+		var occurence = 0
+		for {
+
+			// If camera is connected, we'll check if we are still receiving packets.
+			if communication.CameraConnected {
+				packetsR := packageCounter.Load().(int64)
+				if packetsR == previousPacket {
+					// If we are already reconfiguring,
+					// we dont need to check if the stream is blocking.
+					if !communication.IsConfiguring.IsSet() {
+						occurence = occurence + 1
+					}
+				} else {
+					occurence = 0
+				}
+
+				log.Log.Info("ControlAgent: Number of packets read " + strconv.FormatInt(packetsR, 10))
+
+				// After 15 seconds without activity this is thrown..
+				if occurence == 3 {
+					log.Log.Info("Main: Restarting machinery.")
+					communication.HandleBootstrap <- "restart"
+					time.Sleep(2 * time.Second)
+					occurence = 0
+				}
+				previousPacket = packageCounter.Load().(int64)
+			}
+
+			time.Sleep(5 * time.Second)
+		}
+	}()
+	log.Log.Debug("ControlAgent: finished")
+}

machinery/src/components/Onvif.go

@@ -0,0 +1,25 @@
+package components
+
+import (
+	"time"
+
+	"github.com/cedricve/go-onvif"
+	"github.com/kerberos-io/agent/machinery/src/log"
+)
+
+func Discover(timeout time.Duration) {
+	log.Log.Info("Discovering devices")
+	log.Log.Info("Waiting for " + (timeout * time.Second).String())
+	devices, err := onvif.StartDiscovery(timeout * time.Second)
+	if err != nil {
+		log.Log.Error(err.Error())
+	} else {
+		for _, device := range devices {
+			hostname, _ := device.GetHostname()
+			log.Log.Info(hostname.Name)
+		}
+		if len(devices) == 0 {
+			log.Log.Info("No devices descovered\n")
+		}
+	}
+}

machinery/src/components/Stream.go

@@ -0,0 +1,93 @@
+package components
+
+import (
+	"fmt"
+	"image"
+	"image/jpeg"
+	"log"
+	"time"
+
+	"github.com/deepch/vdk/av"
+	"github.com/deepch/vdk/codec/h264parser"
+	"github.com/deepch/vdk/format/rtsp"
+	"github.com/nsmith5/mjpeg"
+)
+
+type Stream struct {
+	Name   string
+	Url    string
+	Debug  bool
+	Codecs string
+}
+
+func CreateStream(name string, url string) *Stream {
+	return &Stream{
+		Name: name,
+		Url:  url,
+	}
+}
+
+func (s Stream) Open() *rtsp.Client {
+
+	// Enable debugging
+	if s.Debug {
+		rtsp.DebugRtsp = true
+	}
+
+	fmt.Println("Dialing in to " + s.Url)
+	session, err := rtsp.Dial(s.Url)
+	if err != nil {
+		log.Println("Something went wrong dialing into stream: ", err)
+		time.Sleep(5 * time.Second)
+	}
+	session.RtpKeepAliveTimeout = 10 * time.Second
+	return session
+}
+
+func (s Stream) Close(session *rtsp.Client) {
+	fmt.Println("Closing RTSP session.")
+	err := session.Close()
+	if err != nil {
+		log.Println("Something went wrong while closing your RTSP session: ", err)
+	}
+}
+
+func (s Stream) GetCodecs() []av.CodecData {
+	session := s.Open()
+	codec, err := session.Streams()
+	log.Println("Reading codecs from stream: ", codec)
+	if err != nil {
+		log.Println("Something went wrong while reading codecs from stream: ", err)
+		time.Sleep(5 * time.Second)
+	}
+	s.Close(session)
+	return codec
+}
+
+func (s Stream) ReadPackets(packetChannel chan av.Packet) {
+	session := s.Open()
+	for {
+		packet, err := session.ReadPacket()
+		if err != nil {
+			break
+		}
+		if len(packetChannel) < cap(packetChannel) {
+			packetChannel <- packet
+		}
+	}
+	s.Close(session)
+}
+
+func GetSPSFromCodec(codecs []av.CodecData) ([]byte, []byte) {
+	sps := codecs[0].(h264parser.CodecData).SPS()
+	pps := codecs[0].(h264parser.CodecData).PPS()
+	return sps, pps
+}
+
+func StartMotionJPEG(imageFunction func() (image.Image, error), quality int) mjpeg.Handler {
+	stream := mjpeg.Handler{
+		Next:    imageFunction,
+		Options: &jpeg.Options{Quality: quality},
+	}
+	return stream
+}

machinery/src/components/backchannel.go

@@ -1,226 +0,0 @@
-package components
-
-import (
-	"bufio"
-	"context"
-	"math/rand"
-	"os"
-	"time"
-
-	"github.com/kerberos-io/agent/machinery/src/capture"
-	"github.com/kerberos-io/agent/machinery/src/models"
-	"github.com/kerberos-io/agent/machinery/src/packets"
-	"github.com/kerberos-io/joy4/av"
-	"github.com/pion/rtp"
-	log "github.com/sirupsen/logrus"
-	"github.com/zaf/g711"
-)
-
-const (
-	backchannelSampleRate       = 8000
-	backchannelTalkspurtGap     = 500 * time.Millisecond
-	backchannelReconnectInitial = time.Second
-	backchannelReconnectMax     = 30 * time.Second
-)
-
-type backchannelClient interface {
-	ConnectBackChannel(ctx context.Context, otelContext context.Context) error
-	StartBackChannel(ctx context.Context, otelContext context.Context) error
-	WritePacket(pkt packets.Packet) error
-	Close(otelContext context.Context) error
-}
-
-type backchannelPacketizer struct {
-	sequenceNumber uint16
-	timestamp      uint32
-	ssrc           uint32
-	lastPacketAt   time.Time
-}
-
-func newBackchannelPacketizer() backchannelPacketizer {
-	return backchannelPacketizer{
-		sequenceNumber: uint16(rand.Uint32()),
-		timestamp:      rand.Uint32(),
-		ssrc:           rand.Uint32(),
-	}
-}
-
-func (p *backchannelPacketizer) packet(audio models.AudioDataPartial, now time.Time) packets.Packet {
-	bufferUlaw := make([]byte, len(audio.Data))
-	for index, sample := range audio.Data {
-		bufferUlaw[index] = g711.EncodeUlawFrame(sample)
-	}
-
-	pkt := packets.Packet{
-		Packet: &rtp.Packet{
-			Header: rtp.Header{
-				Version:        2,
-				Marker:         p.lastPacketAt.IsZero() || now.Sub(p.lastPacketAt) >= backchannelTalkspurtGap,
-				PayloadType:    0,
-				SequenceNumber: p.sequenceNumber,
-				Timestamp:      p.timestamp,
-				SSRC:           p.ssrc,
-			},
-			Payload: bufferUlaw,
-		},
-	}
-
-	p.timestamp += uint32(len(bufferUlaw))
-	p.sequenceNumber++
-	p.lastPacketAt = now
-
-	return pkt
-}
-
-func GetBackChannelAudioCodec(streams []av.CodecData, communication *models.Communication) av.AudioCodecData {
-	for _, stream := range streams {
-		if stream.Type().IsAudio() {
-			if stream.Type().String() == "PCM_MULAW" {
-				pcmuCodec := stream.(av.AudioCodecData)
-				if pcmuCodec.IsBackChannel() {
-					communication.HasBackChannel.Store(true)
-					return pcmuCodec
-				}
-			}
-		}
-	}
-	return nil
-}
-
-func WriteAudioToBackchannel(ctx context.Context, communication *models.Communication, rtspClient capture.RTSPClient) {
-	writeAudioToBackchannel(ctx, ctx, communication.HandleAudio, rtspClient)
-}
-
-func writeAudioToBackchannel(ctx context.Context, otelContext context.Context, audioChannel <-chan models.AudioDataPartial, rtspClient backchannelClient) {
-	log.Info("Audio.WriteAudioToBackchannel(): writing to backchannel audio codec")
-
-	if err := rtspClient.StartBackChannel(ctx, otelContext); err != nil {
-		log.Error("Audio.WriteAudioToBackchannel(): error starting backchannel: " + err.Error())
-		if !reconnectBackchannel(ctx, otelContext, rtspClient) {
-			log.Info("Audio.WriteAudioToBackchannel(): stopped while reconnecting")
-			return
-		}
-	}
-
-	packetizer := newBackchannelPacketizer()
-	for {
-		select {
-		case <-ctx.Done():
-			log.Info("Audio.WriteAudioToBackchannel(): stopped")
-			return
-		case audio, ok := <-audioChannel:
-			if !ok {
-				log.Info("Audio.WriteAudioToBackchannel(): finished")
-				return
-			}
-
-			audio = latestBackchannelAudio(audio, audioChannel)
-			if len(audio.Data) == 0 {
-				continue
-			}
-
-			pkt := packetizer.packet(audio, time.Now())
-			if err := rtspClient.WritePacket(pkt); err != nil {
-				log.Error("Audio.WriteAudioToBackchannel(): error writing packet to backchannel: " + err.Error())
-				if !reconnectBackchannel(ctx, otelContext, rtspClient) {
-					log.Info("Audio.WriteAudioToBackchannel(): stopped while reconnecting")
-					return
-				}
-				packetizer = newBackchannelPacketizer()
-				continue
-			}
-
-			if !waitForBackchannel(ctx, time.Duration(len(audio.Data))*time.Second/backchannelSampleRate) {
-				log.Info("Audio.WriteAudioToBackchannel(): stopped")
-				return
-			}
-		}
-	}
-}
-
-func latestBackchannelAudio(audio models.AudioDataPartial, audioChannel <-chan models.AudioDataPartial) models.AudioDataPartial {
-	for {
-		select {
-		case next, ok := <-audioChannel:
-			if !ok {
-				return audio
-			}
-			audio = next
-		default:
-			return audio
-		}
-	}
-}
-
-func reconnectBackchannel(ctx context.Context, otelContext context.Context, rtspClient backchannelClient) bool {
-	backoff := backchannelReconnectInitial
-	for {
-		if err := rtspClient.Close(otelContext); err != nil {
-			log.Error("Audio.WriteAudioToBackchannel(): error closing failed backchannel: " + err.Error())
-		}
-		if ctx.Err() != nil {
-			return false
-		}
-
-		err := rtspClient.ConnectBackChannel(ctx, otelContext)
-		if err == nil {
-			err = rtspClient.StartBackChannel(ctx, otelContext)
-		}
-		if err == nil {
-			log.Info("Audio.WriteAudioToBackchannel(): reconnected backchannel")
-			return true
-		}
-
-		log.Error("Audio.WriteAudioToBackchannel(): error reconnecting backchannel: " + err.Error())
-		if !waitForBackchannel(ctx, backoff) {
-			return false
-		}
-		backoff *= 2
-		if backoff > backchannelReconnectMax {
-			backoff = backchannelReconnectMax
-		}
-	}
-}
-
-func waitForBackchannel(ctx context.Context, duration time.Duration) bool {
-	timer := time.NewTimer(duration)
-	defer timer.Stop()
-
-	select {
-	case <-ctx.Done():
-		return false
-	case <-timer.C:
-		return true
-	}
-}
-
-func WriteFileToBackChannel(infile av.DemuxCloser) {
-	// Do the warmup!
-	file, err := os.Open("./audiofile.bye")
-	if err != nil {
-		log.WithError(err).WithFields(log.Fields{
-			"component": "backchannel",
-			"event":     "audio_file_open_failed",
-			"path":      "./audiofile.bye",
-		}).Error("Failed to open backchannel audio file")
-		return
-	}
-	defer file.Close()
-
-	// Read file into buffer
-	reader := bufio.NewReader(file)
-	buffer := make([]byte, 1024)
-
-	count := 0
-	for {
-		_, err := reader.Read(buffer)
-		if err != nil {
-			break
-		}
-		// Send to backchannel
-		infile.Write(buffer, 2, uint32(count))
-
-		count = count + 1024
-		time.Sleep(128 * time.Millisecond)
-	}
-}

machinery/src/components/backchannel_test.go

@@ -1,209 +0,0 @@
-package components
-
-import (
-	"context"
-	"errors"
-	"sync"
-	"testing"
-	"time"
-
-	"github.com/kerberos-io/agent/machinery/src/models"
-	"github.com/kerberos-io/agent/machinery/src/packets"
-)
-
-type fakeBackchannelClient struct {
-	mutex           sync.Mutex
-	startErrors     []error
-	connectError    error
-	writeErrors     []error
-	startCalls      int
-	connectCalls    int
-	closeCalls      int
-	writeCalls      int
-	connectAttempt  chan struct{}
-	successfulWrite chan packets.Packet
-}
-
-func (f *fakeBackchannelClient) ConnectBackChannel(context.Context, context.Context) error {
-	f.mutex.Lock()
-	f.connectCalls++
-	err := f.connectError
-	f.mutex.Unlock()
-
-	select {
-	case f.connectAttempt <- struct{}{}:
-	default:
-	}
-	return err
-}
-
-func (f *fakeBackchannelClient) StartBackChannel(context.Context, context.Context) error {
-	f.mutex.Lock()
-	defer f.mutex.Unlock()
-	f.startCalls++
-	if len(f.startErrors) == 0 {
-		return nil
-	}
-	err := f.startErrors[0]
-	f.startErrors = f.startErrors[1:]
-	return err
-}
-
-func (f *fakeBackchannelClient) WritePacket(pkt packets.Packet) error {
-	f.mutex.Lock()
-	f.writeCalls++
-	var err error
-	if len(f.writeErrors) != 0 {
-		err = f.writeErrors[0]
-		f.writeErrors = f.writeErrors[1:]
-	}
-	f.mutex.Unlock()
-
-	if err == nil {
-		select {
-		case f.successfulWrite <- pkt:
-		default:
-		}
-	}
-	return err
-}
-
-func (f *fakeBackchannelClient) Close(context.Context) error {
-	f.mutex.Lock()
-	f.closeCalls++
-	f.mutex.Unlock()
-	return nil
-}
-
-func (f *fakeBackchannelClient) callCounts() (start, connect, close, write int) {
-	f.mutex.Lock()
-	defer f.mutex.Unlock()
-	return f.startCalls, f.connectCalls, f.closeCalls, f.writeCalls
-}
-
-func TestBackchannelPacketizerUsesFullRTPClock(t *testing.T) {
-	packetizer := backchannelPacketizer{ssrc: 1}
-	audio := models.AudioDataPartial{Data: make([]int16, 1024)}
-	startedAt := time.Unix(1, 0)
-
-	var timestamp uint32
-	for index := 0; index <= 64; index++ {
-		pkt := packetizer.packet(audio, startedAt.Add(time.Duration(index)*128*time.Millisecond))
-		timestamp = pkt.Packet.Timestamp
-	}
-
-	if timestamp != 65536 {
-		t.Fatalf("timestamp after 64 frames = %d, want 65536", timestamp)
-	}
-}
-
-func TestBackchannelPacketizerUsesNaturalSequenceRollover(t *testing.T) {
-	packetizer := backchannelPacketizer{sequenceNumber: ^uint16(0), ssrc: 1}
-	audio := models.AudioDataPartial{Data: []int16{0}}
-	startedAt := time.Unix(1, 0)
-
-	last := packetizer.packet(audio, startedAt)
-	firstAfterRollover := packetizer.packet(audio, startedAt.Add(time.Millisecond))
-
-	if last.Packet.SequenceNumber != ^uint16(0) {
-		t.Fatalf("last sequence number = %d, want %d", last.Packet.SequenceNumber, ^uint16(0))
-	}
-	if firstAfterRollover.Packet.SequenceNumber != 0 {
-		t.Fatalf("first sequence number after rollover = %d, want 0", firstAfterRollover.Packet.SequenceNumber)
-	}
-}
-
-func TestBackchannelPacketizerMarksTalkspurtStart(t *testing.T) {
-	packetizer := backchannelPacketizer{ssrc: 1}
-	audio := models.AudioDataPartial{Data: []int16{0}}
-	startedAt := time.Unix(1, 0)
-
-	first := packetizer.packet(audio, startedAt)
-	continuous := packetizer.packet(audio, startedAt.Add(128*time.Millisecond))
-	afterGap := packetizer.packet(audio, startedAt.Add(backchannelTalkspurtGap+128*time.Millisecond))
-
-	if !first.Packet.Marker {
-		t.Fatal("first packet must mark the start of a talkspurt")
-	}
-	if continuous.Packet.Marker {
-		t.Fatal("continuous packet must not carry the marker bit")
-	}
-	if !afterGap.Packet.Marker {
-		t.Fatal("packet after an audio gap must mark a new talkspurt")
-	}
-}
-
-func TestWriteAudioToBackchannelReconnectsAfterWriteFailure(t *testing.T) {
-	writeFailure := errors.New("EOF")
-	client := &fakeBackchannelClient{
-		writeErrors:     []error{writeFailure, nil},
-		connectAttempt:  make(chan struct{}, 1),
-		successfulWrite: make(chan packets.Packet, 1),
-	}
-	audioChannel := make(chan models.AudioDataPartial, 2)
-	ctx, cancel := context.WithCancel(context.Background())
-	done := make(chan struct{})
-	go func() {
-		writeAudioToBackchannel(ctx, ctx, audioChannel, client)
-		close(done)
-	}()
-
-	audioChannel <- models.AudioDataPartial{Data: make([]int16, 1024)}
-	select {
-	case <-client.connectAttempt:
-	case <-time.After(time.Second):
-		t.Fatal("backchannel was not reconnected after the write failure")
-	}
-
-	audioChannel <- models.AudioDataPartial{Data: make([]int16, 1024)}
-	select {
-	case pkt := <-client.successfulWrite:
-		if !pkt.Packet.Marker {
-			t.Fatal("first packet after reconnect must mark a new talkspurt")
-		}
-	case <-time.After(time.Second):
-		t.Fatal("fresh audio was not written after reconnect")
-	}
-
-	cancel()
-	select {
-	case <-done:
-	case <-time.After(time.Second):
-		t.Fatal("backchannel writer did not stop after cancellation")
-	}
-
-	startCalls, connectCalls, closeCalls, writeCalls := client.callCounts()
-	if startCalls != 2 || connectCalls != 1 || closeCalls != 1 || writeCalls != 2 {
-		t.Fatalf("calls (start, connect, close, write) = (%d, %d, %d, %d), want (2, 1, 1, 2)", startCalls, connectCalls, closeCalls, writeCalls)
-	}
-}
-
-func TestWriteAudioToBackchannelCancellationStopsReconnect(t *testing.T) {
-	client := &fakeBackchannelClient{
-		connectError:    errors.New("camera unavailable"),
-		writeErrors:     []error{errors.New("EOF")},
-		connectAttempt:  make(chan struct{}, 1),
-		successfulWrite: make(chan packets.Packet, 1),
-	}
-	audioChannel := make(chan models.AudioDataPartial, 1)
-	ctx, cancel := context.WithCancel(context.Background())
-	done := make(chan struct{})
-	go func() {
-		writeAudioToBackchannel(ctx, ctx, audioChannel, client)
-		close(done)
-	}()
-
-	audioChannel <- models.AudioDataPartial{Data: make([]int16, 1024)}
-	select {
-	case <-client.connectAttempt:
-	case <-time.After(time.Second):
-		t.Fatal("expected a reconnect attempt")
-	}
-	cancel()
-
-	select {
-	case <-done:
-	case <-time.After(250 * time.Millisecond):
-		t.Fatal("cancellation did not interrupt reconnect backoff")
-	}
-}

machinery/src/components/watchdog_test.go

@@ -1,82 +0,0 @@
-package components
-
-import (
-	"context"
-	"testing"
-	"time"
-)
-
-func TestWaitForRunRetryStopsOnCancellation(t *testing.T) {
-	ctx, cancel := context.WithCancel(context.Background())
-	cancel()
-
-	started := time.Now()
-	if waitForRunRetry(ctx) {
-		t.Fatal("waitForRunRetry() completed the retry delay after cancellation")
-	}
-	if elapsed := time.Since(started); elapsed > 100*time.Millisecond {
-		t.Fatalf("waitForRunRetry() took %s after cancellation", elapsed)
-	}
-}
-
-func TestStreamRestartWatchdogCoalescesStallsAndBacksOff(t *testing.T) {
-	now := time.Unix(1_000, 0)
-	watchdog := newStreamRestartWatchdog()
-	if _, restart := watchdog.Observe(now, 1, 1, true, false); restart {
-		t.Fatal("initial observation requested a restart")
-	}
-
-	for check := 1; check < streamWatchdogStallChecks; check++ {
-		now = now.Add(streamWatchdogInterval)
-		if _, restart := watchdog.Observe(now, 1, 1, true, false); restart {
-			t.Fatalf("check %d requested an early restart", check)
-		}
-	}
-	now = now.Add(streamWatchdogInterval)
-	reason, restart := watchdog.Observe(now, 1, 1, true, false)
-	if !restart || reason != "main and sub streams" {
-		t.Fatalf("Observe() = (%q, %t), want coalesced restart", reason, restart)
-	}
-
-	watchdog.MarkRestart(now)
-	if got := watchdog.Backoff(); got != 30*time.Second {
-		t.Fatalf("Backoff() = %s, want 30s", got)
-	}
-	for now = now.Add(streamWatchdogInterval); now.Before(watchdog.nextRestart); now = now.Add(streamWatchdogInterval) {
-		if _, restart := watchdog.Observe(now, 1, 1, true, false); restart {
-			t.Fatal("restart requested during cooldown")
-		}
-	}
-}
-
-func TestStreamRestartWatchdogResetsAfterHealthyMinute(t *testing.T) {
-	now := time.Unix(2_000, 0)
-	watchdog := newStreamRestartWatchdog()
-	watchdog.backoff = streamWatchdogMaxBackoff
-	watchdog.nextRestart = now.Add(streamWatchdogMaxBackoff)
-	watchdog.Observe(now, 1, 1, true, false)
-
-	for elapsed := streamWatchdogInterval; elapsed <= streamWatchdogHealthyReset+streamWatchdogInterval; elapsed += streamWatchdogInterval {
-		now = now.Add(streamWatchdogInterval)
-		watchdog.Observe(now, int64(elapsed), int64(elapsed), true, false)
-	}
-
-	if got := watchdog.Backoff(); got != streamWatchdogBaseBackoff {
-		t.Fatalf("Backoff() = %s, want %s", got, streamWatchdogBaseBackoff)
-	}
-	if !watchdog.nextRestart.IsZero() {
-		t.Fatalf("nextRestart = %s, want zero", watchdog.nextRestart)
-	}
-}
-
-func TestStreamRestartWatchdogPausesWhileConfiguring(t *testing.T) {
-	now := time.Unix(3_000, 0)
-	watchdog := newStreamRestartWatchdog()
-	watchdog.Observe(now, 1, 0, false, false)
-	for check := 0; check < streamWatchdogStallChecks+1; check++ {
-		now = now.Add(streamWatchdogInterval)
-		if _, restart := watchdog.Observe(now, 1, 0, false, true); restart {
-			t.Fatal("restart requested while configuring")
-		}
-	}
-}

machinery/src/computervision/main.go

@@ -1,75 +1,67 @@
 package computervision
 
 import (
+	"bufio"
+	"bytes"
+	"encoding/base64"
 	"image"
+	"image/jpeg"
+	"sync"
 	"time"
 
 	mqtt "github.com/eclipse/paho.mqtt.golang"
 	geo "github.com/kellydunn/golang-geo"
 	"github.com/kerberos-io/agent/machinery/src/capture"
-	"github.com/kerberos-io/agent/machinery/src/conditions"
+	"github.com/kerberos-io/agent/machinery/src/log"
 	"github.com/kerberos-io/agent/machinery/src/models"
-	"github.com/kerberos-io/agent/machinery/src/packets"
-	log "github.com/sirupsen/logrus"
+	"github.com/kerberos-io/joy4/av"
+	"github.com/kerberos-io/joy4/av/pubsub"
+	"github.com/kerberos-io/joy4/cgo/ffmpeg"
 )
 
-func ProcessMotion(motionCursor *packets.QueueCursor, configuration *models.Configuration, communication *models.Communication, mqttClient mqtt.Client, rtspClient capture.RTSPClient) {
+func ProcessMotion(motionCursor *pubsub.QueueCursor, configuration *models.Configuration, communication *models.Communication, mqttClient mqtt.Client, decoder *ffmpeg.VideoDecoder, decoderMutex *sync.Mutex) { //, wg *sync.WaitGroup) {
 
-	log.Debug("computervision.main.ProcessMotion(): start motion detection")
+	log.Log.Debug("ProcessMotion: started")
 	config := configuration.Config
-	loc, _ := time.LoadLocation(config.Timezone)
 
 	var isPixelChangeThresholdReached = false
 	var changesToReturn = 0
-	var motionRectangle models.MotionRectangle
-	var motionRectangles []models.MotionRectangle
 
-	// Resolve the motion sensitivity (pixel-change threshold). Nil, zero, and
-	// negative values use the historical default so older configurations keep
-	// recording after an upgrade.
-	pixelThreshold := 150
-	if config.Capture.PixelChangeThreshold != nil && *config.Capture.PixelChangeThreshold > 0 {
-		pixelThreshold = *config.Capture.PixelChangeThreshold
+	pixelThreshold := config.Capture.PixelChangeThreshold
+	// Might not be set in the config file, so set it to 150
+	if pixelThreshold == 0 {
+		pixelThreshold = 150
 	}
-	// In motion mode we always run detection. In CONTINUOUS mode recording is
-	// 24/7 so motion detection is normally skipped, BUT if a motion region is
-	// configured we still run it so the live view can visualise the motion boxes
-	// + region. In that case we only emit the motion EVENT — no motion-triggered
-	// recording (continuous already records, and the recorder's motion branch
-	// isn't draining HandleMotion in continuous mode).
-	continuousMode := config.Capture.Continuous == "true"
-	hasMotionRegion := config.Region != nil && len(config.Region.Polygon) > 0
 
-	if continuousMode && !hasMotionRegion {
+	if config.Capture.Continuous == "true" {
 
-		log.Info("computervision.main.ProcessMotion(): continuous recording enabled and no motion region configured, so no motion detection required.")
+		log.Log.Info("ProcessMotion: Continuous recording, so no motion detection.")
 
 	} else {
 
-		if continuousMode {
-			log.Info("computervision.main.ProcessMotion(): continuous recording enabled with a motion region, running motion detection for live-view visualisation only (no motion-triggered recording).")
-		} else {
-			log.Info("computervision.main.ProcessMotion(): motion detected is enabled, so starting the motion detection.")
-		}
+		log.Log.Info("ProcessMotion: Motion detection enabled.")
 
 		hubKey := config.HubKey
 		deviceKey := config.Key
 
+		// Allocate a VideoFrame
+		frame := ffmpeg.AllocVideoFrame()
+
 		// Initialise first 2 elements
 		var imageArray [3]*image.Gray
 
 		j := 0
 
 		var cursorError error
-		var pkt packets.Packet
+		var pkt av.Packet
 
 		for cursorError == nil {
 			pkt, cursorError = motionCursor.ReadPacket()
 			// Check If valid package.
 			if len(pkt.Data) > 0 && pkt.IsKeyFrame {
-				grayImage, err := rtspClient.DecodePacketRaw(pkt)
+				grayImage, err := GetGrayImage(frame, pkt, decoder, decoderMutex)
 				if err == nil {
-					imageArray[j] = &grayImage
+					imageArray[j] = grayImage
 					j++
 				}
 			}
@@ -78,95 +70,48 @@ func ProcessMotion(motionCursor *packets.QueueCursor, configuration *models.Conf
 			}
 		}
 
-		// A user might have set the base width and height for the IPCamera.
-		// This means also the polygon coordinates are set to a specific width and height (which might be different than the actual packets
-		// received from the IPCamera). So we will resize the polygon coordinates to the base width and height.
-		baseWidthRatio := 1.0
-		baseHeightRatio := 1.0
-		baseWidth := config.Capture.IPCamera.BaseWidth
-		baseHeight := config.Capture.IPCamera.BaseHeight
-		if baseWidth > 0 && baseHeight > 0 {
-			// We'll get the first image to calculate the ratio
-			img := imageArray[0]
-			if img != nil {
-				bounds := img.Bounds()
-				rows := bounds.Dy()
-				cols := bounds.Dx()
-				baseWidthRatio = float64(cols) / float64(baseWidth)
-				baseHeightRatio = float64(rows) / float64(baseHeight)
-			}
-		}
-
-		// Calculate mask
-		var polyObjects []geo.Polygon
-		if config.Region != nil {
-			for _, polygon := range config.Region.Polygon {
-				coords := polygon.Coordinates
-				poly := geo.Polygon{}
-				for _, c := range coords {
-					x := c.X * baseWidthRatio
-					y := c.Y * baseHeightRatio
-					p := geo.NewPoint(x, y)
-					if !poly.Contains(p) {
-						poly.Add(p)
-					}
-				}
-				polyObjects = append(polyObjects, poly)
-			}
-		}
-
-		// Frame dimensions + the motion region polygon(s) in image space, shipped
-		// with each motion event so the live view can draw a motion-debug overlay
-		// (the boxes below + the detection region).
-		var imageCols, imageRows int
-		var regionPolygons [][]map[string]int
-		if config.Region != nil {
-			for _, polygon := range config.Region.Polygon {
-				var pts []map[string]int
-				for _, c := range polygon.Coordinates {
-					pts = append(pts, map[string]int{
-						"x": int(c.X * baseWidthRatio),
-						"y": int(c.Y * baseHeightRatio),
-					})
-				}
-				if len(pts) > 0 {
-					regionPolygons = append(regionPolygons, pts)
-				}
-			}
-		}
-
 		img := imageArray[0]
-		var coordinatesPerRegion [][]int
-		totalCoordinates := 0
 		if img != nil {
+
+			// Calculate mask
+			var polyObjects []geo.Polygon
+
+			if config.Region != nil {
+				for _, polygon := range config.Region.Polygon {
+					coords := polygon.Coordinates
+					poly := geo.Polygon{}
+					for _, c := range coords {
+						x := c.X
+						y := c.Y
+						p := geo.NewPoint(x, y)
+						if !poly.Contains(p) {
+							poly.Add(p)
+						}
+					}
+					polyObjects = append(polyObjects, poly)
+				}
+			}
+
 			bounds := img.Bounds()
 			rows := bounds.Dy()
 			cols := bounds.Dx()
-			imageCols = cols
-			imageRows = rows
 
-			// Build a SEPARATE coordinate list per region. Motion is evaluated
-			// independently per region: pixels are NOT shared between regions, so
-			// the threshold must be exceeded within a single region to trigger.
-			coordinatesPerRegion = make([][]int, len(polyObjects))
+			// Make fixed size array of uinty8
+			var coordinatesToCheck []int
 			for y := 0; y < rows; y++ {
 				for x := 0; x < cols; x++ {
-					point := geo.NewPoint(float64(x), float64(y))
-					for idx, poly := range polyObjects {
+					for _, poly := range polyObjects {
+						point := geo.NewPoint(float64(x), float64(y))
 						if poly.Contains(point) {
-							coordinatesPerRegion[idx] = append(coordinatesPerRegion[idx], y*cols+x)
-							totalCoordinates++
+							coordinatesToCheck = append(coordinatesToCheck, y*cols+x)
 						}
 					}
 				}
 			}
-		}
-
-		// If no region is set, we'll skip the motion detection
-		if totalCoordinates > 0 {
 
 			// Start the motion detection
 			i := 0
+			loc, _ := time.LoadLocation(config.Timezone)
 
 			for cursorError == nil {
 				pkt, cursorError = motionCursor.ReadPacket()
@@ -176,88 +121,67 @@ func ProcessMotion(motionCursor *packets.QueueCursor, configuration *models.Conf
 					continue
 				}
 
-				grayImage, err := rtspClient.DecodePacketRaw(pkt)
+				grayImage, err := GetGrayImage(frame, pkt, decoder, decoderMutex)
 				if err == nil {
-					imageArray[2] = &grayImage
+					imageArray[2] = grayImage
 				}
 
-				// We might have different conditions enabled such as time window or uri response.
-				// We'll validate those conditions and if not valid we'll not do anything.
-				detectMotion, err := conditions.Validate(loc, configuration)
-				if !detectMotion && err != nil {
-					log.Debug("computervision.main.ProcessMotion(): " + err.Error() + ".")
+				// Store snapshots (jpg) for hull.
+				if config.Capture.Snapshots != "false" {
+					StoreSnapshot(communication, frame, pkt, decoder, decoderMutex)
 				}
 
-				// Run detection when motion is enabled, OR when we're in continuous
-				// mode with a region: there config.Capture.Motion (the motion-RECORDING
-				// switch) is irrelevant, so the configured region alone is enough to
-				// emit motion events for the live-view overlay.
-				if config.Capture.Motion != "false" || continuousMode {
+				// Check if within time interval
+				detectMotion := true
+				timeEnabled := config.Time
+				if timeEnabled != "false" {
+					now := time.Now().In(loc)
+					weekday := now.Weekday()
+					hour := now.Hour()
+					minute := now.Minute()
+					second := now.Second()
+					if config.Timetable != nil && len(config.Timetable) > 0 {
+						timeInterval := config.Timetable[int(weekday)]
+						if timeInterval != nil {
+							start1 := timeInterval.Start1
+							end1 := timeInterval.End1
+							start2 := timeInterval.Start2
+							end2 := timeInterval.End2
+							currentTimeInSeconds := hour*60*60 + minute*60 + second
+							if (currentTimeInSeconds >= start1 && currentTimeInSeconds <= end1) ||
+								(currentTimeInSeconds >= start2 && currentTimeInSeconds <= end2) {
 
-					if detectMotion {
+							} else {
+								detectMotion = false
+								log.Log.Info("ProcessMotion: Time interval not valid, disabling motion detection.")
+							}
+						}
+					}
+				}
 
-						// Remember additional information about the result of findmotion
-						isPixelChangeThresholdReached, changesToReturn, motionRectangle, motionRectangles = FindMotion(imageArray, coordinatesPerRegion, pixelThreshold)
-						if isPixelChangeThresholdReached {
+				if config.Capture.Motion != "false" {
 
-							// If offline mode is disabled, send a message to the hub
-							if config.Offline != "true" {
-								if mqttClient != nil {
-									if hubKey != "" {
-										message := models.Message{
-											Payload: models.Payload{
-												Action:   "motion",
-												DeviceId: configuration.Config.Key,
-												Value: map[string]interface{}{
-													"timestamp": time.Now().Unix(),
-													// Live-view motion-debug overlay data. The boxes/region
-													// are in the MOTION frame's pixel space (width/height =
-													// the stream motion ran on, i.e. the sub stream when
-													// set). mainWidth/mainHeight are the MAIN stream's
-													// dimensions so the live view can extrapolate the
-													// boxes/region onto the high-res main view it shows —
-													// we know both, so no guessing from the <video> element.
-													"width":      imageCols,
-													"height":     imageRows,
-													"mainWidth":  configuration.Config.Capture.IPCamera.Width,
-													"mainHeight": configuration.Config.Capture.IPCamera.Height,
-													"regions":    motionRectangles,
-													"polygon":    regionPolygons, // Motion sensitivity = the pixel-change threshold that must
-													// be exceeded before motion triggers. The live view renders
-													// a reference square of sqrt(threshold) px (in this MOTION
-													// frame's pixel space) so the user can visually gauge how
-													// large a moving object must be before it is detected.
-													"pixelChangeThreshold": pixelThreshold,
-												},
-											},
-										}
-										payload, err := models.PackageMQTTMessage(configuration, message)
-										if err == nil {
-											mqttClient.Publish("kerberos/hub/"+hubKey, 2, false, payload)
-										} else {
-											log.Info("computervision.main.ProcessMotion(): failed to package MQTT message: " + err.Error())
-										}
-									} else {
-										mqttClient.Publish("kerberos/agent/"+deviceKey, 2, false, "motion")
-									}
+					// Remember additional information about the result of findmotion
+					isPixelChangeThresholdReached, changesToReturn = FindMotion(imageArray, coordinatesToCheck, pixelThreshold)
+					if detectMotion && isPixelChangeThresholdReached {
+
+						// If offline mode is disabled, send a message to the hub
+						if config.Offline != "true" {
+							if mqttClient != nil {
+								if hubKey != "" {
+									mqttClient.Publish("kerberos/"+hubKey+"/device/"+deviceKey+"/motion", 2, false, "motion")
+								} else {
+									mqttClient.Publish("kerberos/device/"+deviceKey+"/motion", 2, false, "motion")
 								}
 							}
+						}
 
-							// Trigger motion-based recording — but NOT in continuous mode:
-							// there the recorder runs the continuous branch and does not
-							// drain HandleMotion, so a (blocking) send would hang the motion
-							// loop. In continuous mode we only publish the motion event above
-							// for the live-view overlay.
-							if config.Capture.Recording != "false" && !continuousMode {
-								dataToPass := models.MotionDataPartial{
-									Timestamp:       time.Now().Unix(),
-									NumberOfChanges: changesToReturn,
-									Rectangle:       motionRectangle,
-								}
-								if !communication.TrySendMotion(dataToPass) {
-									log.Warn("computervision.main.ProcessMotion(): motion channel unavailable or full, dropping recording trigger")
-								}
+						if config.Capture.Recording != "false" {
+							dataToPass := models.MotionDataPartial{
+								Timestamp:       time.Now().Unix(),
+								NumberOfChanges: changesToReturn,
 							}
+							communication.HandleMotion <- dataToPass //Save data to the channel
 						}
 					}
 
@@ -271,246 +195,67 @@ func ProcessMotion(motionCursor *packets.QueueCursor, configuration *models.Conf
 				img = nil
 			}
 		}
+
+		frame.Free()
 	}
 
-	log.Debug("computervision.main.ProcessMotion(): stop the motion detection.")
+	log.Log.Debug("ProcessMotion: finished")
 }
 
-func FindMotion(imageArray [3]*image.Gray, coordinatesPerRegion [][]int, pixelChangeThreshold int) (thresholdReached bool, changesDetected int, motionRectangle models.MotionRectangle, motionRectangles []models.MotionRectangle) {
+func FindMotion(imageArray [3]*image.Gray, coordinatesToCheck []int, pixelChangeThreshold int) (thresholdReached bool, changesDetected int) {
 	image1 := imageArray[0]
 	image2 := imageArray[1]
 	image3 := imageArray[2]
 	threshold := 60
-
-	// Evaluate each region INDEPENDENTLY — pixels are not shared between regions,
-	// so the threshold must be exceeded within a single region to trigger. The
-	// overall rectangle (recording metadata) and the per-cluster rectangles
-	// (live-view overlay) are aggregated across all regions.
-	var combinedRectangles []models.MotionRectangle
-	var overall models.MotionRectangle
-	haveOverall := false
-	totalChanges := 0
-	for _, coordinatesToCheck := range coordinatesPerRegion {
-		if len(coordinatesToCheck) == 0 {
-			continue
-		}
-		changes, rect, rects := AbsDiffBitwiseAndThreshold(image1, image2, image3, threshold, coordinatesToCheck)
-		totalChanges += changes
-		if changes > pixelChangeThreshold {
-			thresholdReached = true
-		}
-		combinedRectangles = append(combinedRectangles, rects...)
-		if changes > 0 {
-			if !haveOverall {
-				overall = rect
-				haveOverall = true
-			} else {
-				overall = unionMotionRectangle(overall, rect)
-			}
-		}
-	}
-
-	return thresholdReached, totalChanges, overall, combinedRectangles
+	changes := AbsDiffBitwiseAndThreshold(image1, image2, image3, threshold, coordinatesToCheck)
+	return changes > pixelChangeThreshold, changes
 }
 
-// unionMotionRectangle returns the smallest rectangle that contains both a and b.
-func unionMotionRectangle(a, b models.MotionRectangle) models.MotionRectangle {
-	minX := a.X
-	if b.X < minX {
-		minX = b.X
-	}
-	minY := a.Y
-	if b.Y < minY {
-		minY = b.Y
-	}
-	maxX := a.X + a.Width
-	if b.X+b.Width > maxX {
-		maxX = b.X + b.Width
-	}
-	maxY := a.Y + a.Height
-	if b.Y+b.Height > maxY {
-		maxY = b.Y + b.Height
-	}
-	return models.MotionRectangle{
-		X:      minX,
-		Y:      minY,
-		Width:  maxX - minX,
-		Height: maxY - minY,
-	}
+func GetGrayImage(frame *ffmpeg.VideoFrame, pkt av.Packet, dec *ffmpeg.VideoDecoder, decoderMutex *sync.Mutex) (*image.Gray, error) {
+	_, err := capture.DecodeImage(frame, pkt, dec, decoderMutex)
+
+	// Do a deep copy of the image
+	imgDeepCopy := image.NewGray(frame.ImageGray.Bounds())
+	imgDeepCopy.Stride = frame.ImageGray.Stride
+	copy(imgDeepCopy.Pix, frame.ImageGray.Pix)
+
+	return imgDeepCopy, err
 }
 
-func AbsDiffBitwiseAndThreshold(img1 *image.Gray, img2 *image.Gray, img3 *image.Gray, threshold int, coordinatesToCheck []int) (int, models.MotionRectangle, []models.MotionRectangle) {
+func GetRawImage(frame *ffmpeg.VideoFrame, pkt av.Packet, dec *ffmpeg.VideoDecoder, decoderMutex *sync.Mutex) (*ffmpeg.VideoFrame, error) {
+	_, err := capture.DecodeImage(frame, pkt, dec, decoderMutex)
+	return frame, err
+}
+
+func ImageToBytes(img image.Image) ([]byte, error) {
+	buffer := new(bytes.Buffer)
+	w := bufio.NewWriter(buffer)
+	err := jpeg.Encode(w, img, &jpeg.Options{Quality: 15})
+	return buffer.Bytes(), err
+}
+
+func AbsDiffBitwiseAndThreshold(img1 *image.Gray, img2 *image.Gray, img3 *image.Gray, threshold int, coordinatesToCheck []int) int {
 	changes := 0
-	cols := img1.Bounds().Dx()
-	rows := img1.Bounds().Dy()
-	var pixelList [][]int
 	for i := 0; i < len(coordinatesToCheck); i++ {
 		pixel := coordinatesToCheck[i]
 		diff := int(img3.Pix[pixel]) - int(img1.Pix[pixel])
 		diff2 := int(img3.Pix[pixel]) - int(img2.Pix[pixel])
 		if (diff > threshold || diff < -threshold) && (diff2 > threshold || diff2 < -threshold) {
 			changes++
-			// Store the pixel coordinates where the change is detected
-			pixelList = append(pixelList, []int{pixel % cols, pixel / cols})
 		}
 	}
-
-	// Calculate rectangle of pixelList (startX, startY, endX, endY)
-	var motionRectangle models.MotionRectangle
-	if len(pixelList) > 0 {
-		startX := pixelList[0][0]
-		startY := pixelList[0][1]
-		endX := startX
-		endY := startY
-		for _, pixel := range pixelList {
-			if pixel[0] < startX {
-				startX = pixel[0]
-			}
-			if pixel[1] < startY {
-				startY = pixel[1]
-			}
-			if pixel[0] > endX {
-				endX = pixel[0]
-			}
-			if pixel[1] > endY {
-				endY = pixel[1]
-			}
-		}
-		log.WithFields(log.Fields{
-			"component": "computer_vision",
-			"end_x":     endX,
-			"end_y":     endY,
-			"event":     "motion_bounds_detected",
-			"start_x":   startX,
-			"start_y":   startY,
-		}).Debug("Motion bounds detected")
-		motionRectangle = models.MotionRectangle{
-			X:      startX,
-			Y:      startY,
-			Width:  endX - startX,
-			Height: endY - startY,
-		}
-		log.WithFields(log.Fields{
-			"component": "computer_vision",
-			"event":     "motion_rectangle_created",
-			"height":    motionRectangle.Height,
-			"width":     motionRectangle.Width,
-			"x":         motionRectangle.X,
-			"y":         motionRectangle.Y,
-		}).Debug("Motion rectangle created")
-	}
-
-	// Cluster the changed pixels into separate bounding boxes so the live view can
-	// visualise WHERE motion happened (a single overall rectangle is useless when
-	// two objects move in opposite corners). Cheap grid-based connected components.
-	motionRectangles := clusterMotionRectangles(pixelList, cols, rows)
-
-	return changes, motionRectangle, motionRectangles
+	return changes
 }
 
-// clusterMotionRectangles groups the changed-pixel coordinates into a handful of
-// bounding boxes using connected-components on a coarse grid (8-connectivity).
-// It is intentionally lightweight — it runs only when the motion threshold is
-// reached and the boxes are meant for a debug overlay, not precise detection.
-func clusterMotionRectangles(pixelList [][]int, cols, rows int) []models.MotionRectangle {
-	if len(pixelList) == 0 || cols <= 0 || rows <= 0 {
-		return nil
-	}
-
-	// ~40 cells across the longest side keeps the grid small (cheap to cluster)
-	// while still separating distinct motion blobs.
-	const gridDim = 40
-	cellW := cols / gridDim
-	if cellW < 1 {
-		cellW = 1
-	}
-	cellH := rows / gridDim
-	if cellH < 1 {
-		cellH = 1
-	}
-	gCols := (cols + cellW - 1) / cellW
-	gRows := (rows + cellH - 1) / cellH
-
-	grid := make([]bool, gCols*gRows)
-	for _, p := range pixelList {
-		cx := p[0] / cellW
-		cy := p[1] / cellH
-		if cx >= 0 && cx < gCols && cy >= 0 && cy < gRows {
-			grid[cy*gCols+cx] = true
+func StoreSnapshot(communication *models.Communication, frame *ffmpeg.VideoFrame, pkt av.Packet, decoder *ffmpeg.VideoDecoder, decoderMutex *sync.Mutex) {
+	rgbImage, err := GetRawImage(frame, pkt, decoder, decoderMutex)
+	if err == nil {
+		buffer := new(bytes.Buffer)
+		w := bufio.NewWriter(buffer)
+		err := jpeg.Encode(w, &rgbImage.Image, &jpeg.Options{Quality: 15})
+		if err == nil {
+			snapshot := base64.StdEncoding.EncodeToString(buffer.Bytes())
+			communication.Image = snapshot
 		}
 	}
-
-	visited := make([]bool, gCols*gRows)
-	var rectangles []models.MotionRectangle
-	const maxBoxes = 12
-	stack := make([][2]int, 0, 64)
-
-	for cy := 0; cy < gRows; cy++ {
-		for cx := 0; cx < gCols; cx++ {
-			idx := cy*gCols + cx
-			if !grid[idx] || visited[idx] {
-				continue
-			}
-
-			// Flood-fill this component (8-connectivity) and track its extent.
-			minX, minY, maxX, maxY := cx, cy, cx, cy
-			cellCount := 0
-			stack = stack[:0]
-			stack = append(stack, [2]int{cx, cy})
-			visited[idx] = true
-			for len(stack) > 0 {
-				cur := stack[len(stack)-1]
-				stack = stack[:len(stack)-1]
-				ccx, ccy := cur[0], cur[1]
-				cellCount++
-				if ccx < minX {
-					minX = ccx
-				}
-				if ccy < minY {
-					minY = ccy
-				}
-				if ccx > maxX {
-					maxX = ccx
-				}
-				if ccy > maxY {
-					maxY = ccy
-				}
-				for dy := -1; dy <= 1; dy++ {
-					for dx := -1; dx <= 1; dx++ {
-						nx, ny := ccx+dx, ccy+dy
-						if nx < 0 || ny < 0 || nx >= gCols || ny >= gRows {
-							continue
-						}
-						nIdx := ny*gCols + nx
-						if grid[nIdx] && !visited[nIdx] {
-							visited[nIdx] = true
-							stack = append(stack, [2]int{nx, ny})
-						}
-					}
-				}
-			}
-
-			// Skip single-cell specks (sensor noise) unless it's the only motion.
-			if cellCount < 2 && len(pixelList) > 4 {
-				continue
-			}
-
-			x := minX * cellW
-			y := minY * cellH
-			w := (maxX - minX + 1) * cellW
-			h := (maxY - minY + 1) * cellH
-			if x+w > cols {
-				w = cols - x
-			}
-			if y+h > rows {
-				h = rows - y
-			}
-			rectangles = append(rectangles, models.MotionRectangle{X: x, Y: y, Width: w, Height: h})
-			if len(rectangles) >= maxBoxes {
-				return rectangles
-			}
-		}
-	}
-
-	return rectangles
 }

machinery/src/conditions/main.go

@@ -1,28 +0,0 @@
-package conditions
-
-import (
-	"errors"
-	"time"
-
-	"github.com/kerberos-io/agent/machinery/src/models"
-)
-
-func Validate(loc *time.Location, configuration *models.Configuration) (valid bool, err error) {
-	valid = true
-	err = nil
-
-	withinTimeInterval := IsWithinTimeInterval(loc, configuration)
-	if !withinTimeInterval {
-		valid = false
-		err = errors.New("time interval not valid")
-		return
-	}
-	validUriResponse := IsValidUriResponse(configuration)
-	if !validUriResponse {
-		valid = false
-		err = errors.New("uri response not valid")
-		return
-	}
-
-	return
-}

machinery/src/conditions/timewindow.go

@@ -1,39 +0,0 @@
-package conditions
-
-import (
-	"time"
-
-	"github.com/kerberos-io/agent/machinery/src/models"
-	log "github.com/sirupsen/logrus"
-)
-
-func IsWithinTimeInterval(loc *time.Location, configuration *models.Configuration) (enabled bool) {
-	config := configuration.Config
-	timeEnabled := config.Time
-	enabled = true
-	if timeEnabled != "false" {
-		now := time.Now().In(loc)
-		weekday := now.Weekday()
-		hour := now.Hour()
-		minute := now.Minute()
-		second := now.Second()
-		if config.Timetable != nil && len(config.Timetable) > 0 {
-			timeInterval := config.Timetable[int(weekday)]
-			if timeInterval != nil {
-				start1 := timeInterval.Start1
-				end1 := timeInterval.End1
-				start2 := timeInterval.Start2
-				end2 := timeInterval.End2
-				currentTimeInSeconds := hour*60*60 + minute*60 + second
-				if (currentTimeInSeconds >= start1 && currentTimeInSeconds <= end1) ||
-					(currentTimeInSeconds >= start2 && currentTimeInSeconds <= end2) {
-					log.Debug("conditions.timewindow.IsWithinTimeInterval(): time interval valid, enabling recording.")
-				} else {
-					log.Info("conditions.timewindow.IsWithinTimeInterval(): time interval not valid, disabling recording.")
-					enabled = false
-				}
-			}
-		}
-	}
-	return
-}

machinery/src/conditions/uri.go

@@ -1,97 +0,0 @@
-package conditions
-
-import (
-	"bytes"
-	"crypto/tls"
-	"encoding/json"
-	"io"
-	"net/http"
-	"os"
-	"time"
-
-	"github.com/kerberos-io/agent/machinery/src/models"
-	log "github.com/sirupsen/logrus"
-)
-
-const conditionHTTPTimeout = 10 * time.Second
-
-var (
-	conditionHTTPClient         = &http.Client{Timeout: conditionHTTPTimeout}
-	conditionInsecureHTTPClient = &http.Client{
-		Transport: &http.Transport{
-			TLSClientConfig: &tls.Config{InsecureSkipVerify: true}, // #nosec G402 -- explicit operator opt-in
-		},
-		Timeout: conditionHTTPTimeout,
-	}
-)
-
-func IsValidUriResponse(configuration *models.Configuration) (enabled bool) {
-	config := configuration.Config
-	conditionURI := config.ConditionURI
-	enabled = true
-	if conditionURI != "" {
-		client := conditionHTTPClient
-		if os.Getenv("AGENT_TLS_INSECURE") == "true" {
-			client = conditionInsecureHTTPClient
-		}
-
-		payload := struct {
-			CameraID   string `json:"camera_id"`
-			CameraName string `json:"camera_name"`
-			SiteID     string `json:"site_id"`
-			HubKey     string `json:"hub_key"`
-			Timestamp  string `json:"timestamp"`
-		}{
-			CameraID:   config.Key,
-			CameraName: config.FriendlyName,
-			SiteID:     config.HubSite,
-			HubKey:     config.HubKey,
-			Timestamp:  time.Now().Format("2006-01-02 15:04:05"),
-		}
-		jsonBody, err := json.Marshal(payload)
-		if err != nil {
-			log.WithError(err).WithFields(log.Fields{
-				"component": "conditions/uri",
-				"event":     "request_encoding_failed",
-			}).Error("Failed to encode condition request")
-			return false
-		}
-
-		req, err := http.NewRequest(http.MethodPost, conditionURI, bytes.NewReader(jsonBody))
-		if err != nil {
-			log.WithError(err).WithFields(log.Fields{
-				"component": "conditions/uri",
-				"event":     "request_creation_failed",
-			}).Error("Failed to create condition request")
-			return false
-		}
-		req.Header.Set("Content-Type", "application/json")
-		resp, err := client.Do(req)
-		if resp != nil {
-			_, _ = io.Copy(io.Discard, resp.Body)
-			resp.Body.Close()
-		}
-		if err == nil && resp != nil && resp.StatusCode == http.StatusOK {
-			log.WithFields(log.Fields{
-				"component":   "conditions/uri",
-				"event":       "recording_enabled",
-				"status_code": resp.StatusCode,
-			}).Info("Condition request enabled recording")
-		} else {
-			if err != nil {
-				log.WithError(err).WithFields(log.Fields{
-					"component": "conditions/uri",
-					"event":     "request_failed",
-				}).Error("Condition request failed")
-			} else {
-				log.WithFields(log.Fields{
-					"component":   "conditions/uri",
-					"event":       "recording_disabled",
-					"status_code": resp.StatusCode,
-				}).Info("Condition request disabled recording")
-			}
-			enabled = false
-		}
-	}
-	return
-}

machinery/src/conditions/uri_test.go

@@ -1,63 +0,0 @@
-package conditions
-
-import (
-	"encoding/json"
-	"net/http"
-	"net/http/httptest"
-	"sync/atomic"
-	"testing"
-
-	"github.com/kerberos-io/agent/machinery/src/models"
-)
-
-func TestIsValidUriResponseReusesClientAndEncodesPayload(t *testing.T) {
-	var requests atomic.Int32
-	server := httptest.NewServer(http.HandlerFunc(func(w http.ResponseWriter, request *http.Request) {
-		requests.Add(1)
-		if request.Method != http.MethodPost {
-			t.Errorf("method = %s, want POST", request.Method)
-		}
-		if got := request.Header.Get("Content-Type"); got != "application/json" {
-			t.Errorf("Content-Type = %q, want application/json", got)
-		}
-		var payload struct {
-			CameraID   string `json:"camera_id"`
-			CameraName string `json:"camera_name"`
-		}
-		if err := json.NewDecoder(request.Body).Decode(&payload); err != nil {
-			t.Errorf("decode request: %v", err)
-		}
-		if payload.CameraID != "camera-1" || payload.CameraName != `Front "Door"` {
-			t.Errorf("payload = %+v", payload)
-		}
-		w.WriteHeader(http.StatusOK)
-	}))
-	defer server.Close()
-
-	configuration := &models.Configuration{}
-	configuration.Config.ConditionURI = server.URL
-	configuration.Config.Key = "camera-1"
-	configuration.Config.FriendlyName = `Front "Door"`
-
-	for i := 0; i < 2; i++ {
-		if !IsValidUriResponse(configuration) {
-			t.Fatal("IsValidUriResponse() = false, want true")
-		}
-	}
-	if got := requests.Load(); got != 2 {
-		t.Fatalf("requests = %d, want 2", got)
-	}
-}
-
-func TestIsValidUriResponseRejectsNonOK(t *testing.T) {
-	server := httptest.NewServer(http.HandlerFunc(func(w http.ResponseWriter, request *http.Request) {
-		http.Error(w, "unavailable", http.StatusServiceUnavailable)
-	}))
-	defer server.Close()
-
-	configuration := &models.Configuration{}
-	configuration.Config.ConditionURI = server.URL
-	if IsValidUriResponse(configuration) {
-		t.Fatal("IsValidUriResponse() = true, want false")
-	}
-}

machinery/src/config/main.go

@@ -4,43 +4,39 @@ import (
 	"context"
 	"encoding/json"
 	"errors"
+	"image"
 	"io/ioutil"
 	"os"
 	"reflect"
+	"sort"
 	"strconv"
 	"strings"
 	"time"
 
 	"github.com/InVisionApp/conjungo"
 	"github.com/kerberos-io/agent/machinery/src/database"
+	"github.com/kerberos-io/agent/machinery/src/log"
 	"github.com/kerberos-io/agent/machinery/src/models"
-	log "github.com/sirupsen/logrus"
 	"go.mongodb.org/mongo-driver/bson"
-	"go.mongodb.org/mongo-driver/mongo"
 )
 
-const factoryConfigRetryDelay = 5 * time.Second
-
-func newFactoryConfigReadContext() (context.Context, context.CancelFunc) {
-	return context.WithTimeout(context.Background(), database.TIMEOUT)
-}
-
-func isRetryableFactoryConfigReadError(err error) bool {
-	return errors.Is(err, context.DeadlineExceeded) || mongo.IsTimeout(err) || mongo.IsNetworkError(err)
-}
-
-func readFactoryConfig(collection *mongo.Collection, filter bson.M, destination *models.Config) error {
-	for {
-		ctx, cancel := newFactoryConfigReadContext()
-		err := collection.FindOne(ctx, filter).Decode(destination)
-		cancel()
-		if !isRetryableFactoryConfigReadError(err) {
-			return err
+func GetImageFromFilePath(configDirectory string) (image.Image, error) {
+	snapshotDirectory := configDirectory + "/data/snapshots"
+	files, err := ioutil.ReadDir(snapshotDirectory)
+	if err == nil && len(files) > 1 {
+		sort.Slice(files, func(i, j int) bool {
+			return files[i].ModTime().Before(files[j].ModTime())
+		})
+		filePath := configDirectory + "/data/snapshots/" + files[1].Name()
+		f, err := os.Open(filePath)
+		if err != nil {
+			return nil, err
 		}
-
-		log.Warn("Factory configuration read timed out or lost its database connection; retrying.")
-		time.Sleep(factoryConfigRetryDelay)
+		defer f.Close()
+		image, _, err := image.Decode(f)
+		return image, err
 	}
+	return nil, errors.New("Could not find a snapshot in " + snapshotDirectory)
 }
 
 // ReadUserConfig Reads the user configuration of the Kerberos Open Source instance.
@@ -50,14 +46,14 @@ func ReadUserConfig(configDirectory string) (userConfig models.User) {
 	for {
 		jsonFile, err := os.Open(configDirectory + "/data/config/user.json")
 		if err != nil {
-			log.Error("Config file is not found " + configDirectory + "/data/config/user.json, trying again in 5s: " + err.Error())
+			log.Log.Error("Config file is not found " + configDirectory + "/data/config/user.json, trying again in 5s: " + err.Error())
 			time.Sleep(5 * time.Second)
 		} else {
-			log.Info("Successfully Opened user.json")
+			log.Log.Info("Successfully Opened user.json")
 			byteValue, _ := ioutil.ReadAll(jsonFile)
 			err = json.Unmarshal(byteValue, &userConfig)
 			if err != nil {
-				log.Error("JSON file not valid: " + err.Error())
+				log.Log.Error("JSON file not valid: " + err.Error())
 			} else {
 				jsonFile.Close()
 				break
@@ -84,19 +80,25 @@ func OpenConfig(configDirectory string, configuration *models.Configuration) {
 		// Write to mongodb
 		client := database.New()
 
-		db := client.Client.Database(database.DatabaseName)
+		db := client.Database(database.DatabaseName)
 		collection := db.Collection("configuration")
 
 		var globalConfig models.Config
-		err := readFactoryConfig(collection, bson.M{
+		res := collection.FindOne(context.Background(), bson.M{
 			"type": "global",
-		}, &globalConfig)
+		})
+
+		if res.Err() != nil {
+			log.Log.Error("Could not find global configuration, using default configuration.")
+			panic("Could not find global configuration, using default configuration.")
+		}
+		err := res.Decode(&globalConfig)
 		if err != nil {
-			log.Error("Could not find global configuration, using default configuration.")
+			log.Log.Error("Could not find global configuration, using default configuration.")
 			panic("Could not find global configuration, using default configuration.")
 		}
 		if globalConfig.Type != "global" {
-			log.Error("Could not find global configuration, might missed the mongodb connection.")
+			log.Log.Error("Could not find global configuration, might missed the mongodb connection.")
 			panic("Could not find global configuration, might missed the mongodb connection.")
 		}
 
@@ -104,16 +106,21 @@ func OpenConfig(configDirectory string, configuration *models.Configuration) {
 
 		var customConfig models.Config
 		deploymentName := os.Getenv("DEPLOYMENT_NAME")
-		err = readFactoryConfig(collection, bson.M{
+		res = collection.FindOne(context.Background(), bson.M{
 			"type": "config",
 			"name": deploymentName,
-		}, &customConfig)
+		})
+		if res.Err() != nil {
+			log.Log.Error("Could not find configuration for " + deploymentName + ", using global configuration.")
+		}
+		err = res.Decode(&customConfig)
 		if err != nil {
-			log.Error("Could not find configuration for " + deploymentName + ", using global configuration.")
-			customConfig = models.Config{}
-		} else if customConfig.Type != "config" {
-			log.Error("Custom configuration has an invalid type, using global configuration.")
-			customConfig = models.Config{}
+			log.Log.Error("Could not find configuration for " + deploymentName + ", using global configuration.")
+		}
+
+		if customConfig.Type != "config" {
+			log.Log.Error("Could not find custom configuration, might missed the mongodb connection.")
+			panic("Could not find custom configuration, might missed the mongodb connection.")
 		}
 		configuration.CustomConfig = customConfig
 
@@ -134,13 +141,8 @@ func OpenConfig(configDirectory string, configuration *models.Configuration) {
 			},
 		)
 
-		// Reset main configuration Config.
-		configuration.Config = models.Config{}
-
-		// Merge the global settings in the main config
+		// Merge Config toplevel
 		conjungo.Merge(&configuration.Config, configuration.GlobalConfig, opts)
-
-		// Now we might override some settings with the custom config
 		conjungo.Merge(&configuration.Config, configuration.CustomConfig, opts)
 
 		// Merge Kerberos Vault settings
@@ -149,27 +151,12 @@ func OpenConfig(configDirectory string, configuration *models.Configuration) {
 		conjungo.Merge(&kerberosvault, configuration.CustomConfig.KStorage, opts)
 		configuration.Config.KStorage = &kerberosvault
 
-		// Merge Secondary Kerberos Vault settings
-		var kerberosvaultSecondary models.KStorage
-		conjungo.Merge(&kerberosvaultSecondary, configuration.GlobalConfig.KStorageSecondary, opts)
-		conjungo.Merge(&kerberosvaultSecondary, configuration.CustomConfig.KStorageSecondary, opts)
-		configuration.Config.KStorageSecondary = &kerberosvaultSecondary
-
 		// Merge Kerberos S3 settings
 		var s3 models.S3
 		conjungo.Merge(&s3, configuration.GlobalConfig.S3, opts)
 		conjungo.Merge(&s3, configuration.CustomConfig.S3, opts)
 		configuration.Config.S3 = &s3
 
-		// Merge Encryption settings
-		var encryption models.Encryption
-		conjungo.Merge(&encryption, configuration.GlobalConfig.Encryption, opts)
-		conjungo.Merge(&encryption, configuration.CustomConfig.Encryption, opts)
-		configuration.Config.Encryption = &encryption
-
-		// Merge timetable manually because it's an array
-		configuration.Config.Timetable = configuration.CustomConfig.Timetable
-
 		// Cleanup
 		opts = nil
 
@@ -180,29 +167,21 @@ func OpenConfig(configDirectory string, configuration *models.Configuration) {
 
 		// Open device config
 		for {
-			configPath := configDirectory + "/data/config/config.json"
-			jsonFile, err := os.Open(configPath)
+			jsonFile, err := os.Open(configDirectory + "/data/config/config.json")
 			if err != nil {
-				log.WithError(err).WithFields(log.Fields{
-					"component":      "config",
-					"event":          "configuration_open_failed",
-					"retry_delay_ms": 5000,
-				}).Warn("Configuration file unavailable; retrying")
+				log.Log.Error("Config file is not found " + configDirectory + "/data/config/config.json" + ", trying again in 5s.")
 				time.Sleep(5 * time.Second)
 			} else {
-				log.WithFields(log.Fields{
-					"component": "config",
-					"event":     "configuration_opened",
-				}).Info("Configuration file opened")
+				log.Log.Info("Successfully Opened config.json from " + configuration.Name)
 				byteValue, _ := ioutil.ReadAll(jsonFile)
 				err = json.Unmarshal(byteValue, &configuration.Config)
 				jsonFile.Close()
 				if err != nil {
-					log.Error("JSON file not valid: " + err.Error())
+					log.Log.Error("JSON file not valid: " + err.Error())
 				} else {
 					err = json.Unmarshal(byteValue, &configuration.CustomConfig)
 					if err != nil {
-						log.Error("JSON file not valid: " + err.Error())
+						log.Log.Error("JSON file not valid: " + err.Error())
 					} else {
 						break
 					}
@@ -211,120 +190,19 @@ func OpenConfig(configDirectory string, configuration *models.Configuration) {
 			}
 			jsonFile.Close()
 		}
+
 	}
+
 	return
 }
 
-// OverrideWithEnvironmentVariables builds the effective configuration from the
-// environment variables.
-//
-// In ConfigMap/standalone mode (DEPLOYMENT empty or "agent") the global
-// configuration is delivered as GLOBAL_AGENT_* environment variables and the
-// per-agent configuration as AGENT_* environment variables. We parse them into
-// the separate global and custom configurations and build the effective
-// configuration as "global overridden by custom", mirroring the MongoDB-backed
-// factory behaviour. This keeps the global and per-agent (custom) configuration
-// separated so the factory edit page can distinguish inherited global settings
-// from per-agent overrides.
+// This function will override the configuration with environment variables.
 func OverrideWithEnvironmentVariables(configuration *models.Configuration) {
-	if os.Getenv("DEPLOYMENT") == "" || os.Getenv("DEPLOYMENT") == "agent" {
-		initConfigPointers(&configuration.Config)
-
-		// Parse the global configuration from the GLOBAL_AGENT_* variables.
-		globalWrap := &models.Configuration{Config: configuration.GlobalConfig}
-		initConfigPointers(&globalWrap.Config)
-		applyAgentEnvVars(globalWrap, "GLOBAL_", false)
-		configuration.GlobalConfig = globalWrap.Config
-
-		// Parse the per-agent (custom) configuration from the AGENT_* variables.
-		// In ConfigMap mode the per-agent overrides are delivered exclusively
-		// through AGENT_* environment variables, so we must start from an empty
-		// configuration rather than the bundled config.json that OpenConfig loaded
-		// into CustomConfig. Otherwise defaults from that file (e.g. cloud="s3")
-		// would leak into the custom config and be mistaken for explicit per-agent
-		// overrides, hiding inherited global settings (the factory edit page would
-		// show the local default instead of the inherited global persistence).
-		customBase := configuration.CustomConfig
-		if isConfigMapMode() {
-			customBase = models.Config{}
-		}
-		customWrap := &models.Configuration{Config: customBase}
-		initConfigPointers(&customWrap.Config)
-		applyAgentEnvVars(customWrap, "", false)
-		configuration.CustomConfig = customWrap.Config
-
-		// Build the effective configuration: global base, then per-agent
-		// overrides on top. Defaults (e.g. signing) are applied on the last
-		// pass only.
-		applyAgentEnvVars(configuration, "GLOBAL_", false)
-		applyAgentEnvVars(configuration, "", true)
-	} else {
-		// Factory/MongoDB mode: the global and custom configurations are already
-		// loaded and merged from MongoDB; we only override the effective
-		// configuration with any AGENT_* environment variables.
-		applyAgentEnvVars(configuration, "", true)
-	}
-}
-
-// isConfigMapMode reports whether the agent is running in ConfigMap mode, i.e.
-// whether a global configuration layer is delivered separately through
-// GLOBAL_AGENT_* environment variables. In that mode the per-agent (custom)
-// configuration must be built solely from the AGENT_* overrides and must not be
-// seeded with the bundled config.json defaults, so that inherited global
-// settings remain distinguishable from explicit per-agent overrides.
-func isConfigMapMode() bool {
-	for _, env := range os.Environ() {
-		if strings.HasPrefix(env, "GLOBAL_AGENT_") {
-			return true
-		}
-	}
-	return false
-}
-
-// initConfigPointers ensures all pointer sub-structs are non-nil so that the
-// environment-variable parsing can assign into them without dereferencing a nil
-// pointer.
-func initConfigPointers(config *models.Config) {
-	if config.KStorage == nil {
-		config.KStorage = &models.KStorage{}
-	}
-	if config.KStorageSecondary == nil {
-		config.KStorageSecondary = &models.KStorage{}
-	}
-	if config.S3 == nil {
-		config.S3 = &models.S3{}
-	}
-	if config.Encryption == nil {
-		config.Encryption = &models.Encryption{}
-	}
-	if config.Signing == nil {
-		config.Signing = &models.Signing{}
-	}
-	if config.Dropbox == nil {
-		config.Dropbox = &models.Dropbox{}
-	}
-	if config.Region == nil {
-		config.Region = &models.Region{}
-	}
-}
-
-// applyAgentEnvVars applies the AGENT_* environment variables (optionally
-// carrying the given prefix, e.g. "GLOBAL_") onto configuration.Config. When
-// applyDefaults is true, defaults (such as the signing key) are applied after
-// parsing; this should only be done for the effective configuration.
-func applyAgentEnvVars(configuration *models.Configuration, prefix string, applyDefaults bool) {
 	environmentVariables := os.Environ()
-
-	// Initialize the configuration for some new fields.
-	if configuration.Config.KStorageSecondary == nil {
-		configuration.Config.KStorageSecondary = &models.KStorage{}
-	}
-
 	for _, env := range environmentVariables {
-		fullKey := strings.SplitN(env, "=", 2)[0]
-		if strings.HasPrefix(fullKey, prefix+"AGENT_") && !(prefix == "" && strings.HasPrefix(fullKey, "GLOBAL_AGENT_")) {
-			key := strings.TrimPrefix(fullKey, prefix)
-			value := os.Getenv(fullKey)
+		if strings.Contains(env, "AGENT_") {
+			key := strings.Split(env, "=")[0]
+			value := os.Getenv(key)
 			switch key {
 
 			/* General configuration */
@@ -349,12 +227,6 @@ func applyAgentEnvVars(configuration *models.Configuration, prefix string, apply
 					configuration.Config.MaxDirectorySize = size
 				}
 				break
-			case "AGENT_AUTO_CLEAN_MIN_FREE_SPACE":
-				size, err := strconv.ParseInt(value, 10, 64)
-				if err == nil {
-					configuration.Config.MinFreeSpace = size
-				}
-				break
 
 			/* Camera configuration */
 			case "AGENT_CAPTURE_IPCAMERA_RTSP":
@@ -364,15 +236,7 @@ func applyAgentEnvVars(configuration *models.Configuration, prefix string, apply
 				configuration.Config.Capture.IPCamera.SubRTSP = value
 				break
 
-			/* Base width and height for the liveview and motion regions */
-			case "AGENT_CAPTURE_IPCAMERA_BASE_WIDTH":
-				configuration.Config.Capture.IPCamera.BaseWidth, _ = strconv.Atoi(value)
-				break
-			case "AGENT_CAPTURE_IPCAMERA_BASE_HEIGHT":
-				configuration.Config.Capture.IPCamera.BaseHeight, _ = strconv.Atoi(value)
-				break
-
-			/* ONVIF connnection settings */
+				/* ONVIF connnection settings */
 			case "AGENT_CAPTURE_IPCAMERA_ONVIF":
 				configuration.Config.Capture.IPCamera.ONVIF = value
 				break
@@ -399,9 +263,6 @@ func applyAgentEnvVars(configuration *models.Configuration, prefix string, apply
 			case "AGENT_CAPTURE_MOTION":
 				configuration.Config.Capture.Motion = value
 				break
-			case "AGENT_CAPTURE_ONVIF_MOTION":
-				configuration.Config.Capture.ONVIFMotion = value
-				break
 			case "AGENT_CAPTURE_SNAPSHOTS":
 				configuration.Config.Capture.Snapshots = value
 				break
@@ -426,7 +287,7 @@ func applyAgentEnvVars(configuration *models.Configuration, prefix string, apply
 			case "AGENT_CAPTURE_PIXEL_CHANGE":
 				count, err := strconv.Atoi(value)
 				if err == nil {
-					configuration.Config.Capture.PixelChangeThreshold = &count
+					configuration.Config.Capture.PixelChangeThreshold = count
 				}
 				break
 			case "AGENT_CAPTURE_FRAGMENTED":
@@ -528,26 +389,10 @@ func applyAgentEnvVars(configuration *models.Configuration, prefix string, apply
 				configuration.Config.MQTTPassword = value
 				break
 
-			/* MQTT chunking of low-resolution images into multiple messages */
-			case "AGENT_CAPTURE_LIVEVIEW_CHUNKING":
-				configuration.Config.Capture.LiveviewChunking = value
-				break
-
-			/* Real-time streaming of keyframes to a MQTT topic */
-			case "AGENT_REALTIME_PROCESSING":
-				configuration.Config.RealtimeProcessing = value
-				break
-			case "AGENT_REALTIME_PROCESSING_TOPIC":
-				configuration.Config.RealtimeProcessingTopic = value
-				break
-
 			/* WebRTC settings for live-streaming (remote) */
 			case "AGENT_STUN_URI":
 				configuration.Config.STUNURI = value
 				break
-			case "AGENT_FORCE_TURN":
-				configuration.Config.ForceTurn = value
-				break
 			case "AGENT_TURN_URI":
 				configuration.Config.TURNURI = value
 				break
@@ -568,9 +413,6 @@ func applyAgentEnvVars(configuration *models.Configuration, prefix string, apply
 				break
 
 			/* When connected and storing in Kerberos Hub (SAAS) */
-			case "AGENT_HUB_ENCRYPTION":
-				configuration.Config.HubEncryption = value
-				break
 			case "AGENT_HUB_URI":
 				configuration.Config.HubURI = value
 				break
@@ -587,7 +429,7 @@ func applyAgentEnvVars(configuration *models.Configuration, prefix string, apply
 				configuration.Config.S3.Region = value
 				break
 
-			/* When storing in a Vault */
+			/* When storing in a Kerberos Vault */
 			case "AGENT_KERBEROSVAULT_URI":
 				configuration.Config.KStorage.URI = value
 				break
@@ -604,37 +446,6 @@ func applyAgentEnvVars(configuration *models.Configuration, prefix string, apply
 				configuration.Config.KStorage.Directory = value
 				break
 
-			/* Retry policy and timeout */
-			case "AGENT_KERBEROSVAULT_MAX_RETRIES":
-				maxRetries, err := strconv.Atoi(value)
-				if err == nil {
-					configuration.Config.KStorage.MaxRetries = maxRetries
-				}
-				break
-			case "AGENT_KERBEROSVAULT_TIMEOUT":
-				timeout, err := strconv.Atoi(value)
-				if err == nil {
-					configuration.Config.KStorage.Timeout = timeout
-				}
-				break
-
-			/* When storing in a secondary Vault */
-			case "AGENT_KERBEROSVAULT_SECONDARY_URI":
-				configuration.Config.KStorageSecondary.URI = value
-				break
-			case "AGENT_KERBEROSVAULT_SECONDARY_ACCESS_KEY":
-				configuration.Config.KStorageSecondary.AccessKey = value
-				break
-			case "AGENT_KERBEROSVAULT_SECONDARY_SECRET_KEY":
-				configuration.Config.KStorageSecondary.SecretAccessKey = value
-				break
-			case "AGENT_KERBEROSVAULT_SECONDARY_PROVIDER":
-				configuration.Config.KStorageSecondary.Provider = value
-				break
-			case "AGENT_KERBEROSVAULT_SECONDARY_DIRECTORY":
-				configuration.Config.KStorageSecondary.Directory = value
-				break
-
 			/* When storing in dropbox */
 			case "AGENT_DROPBOX_ACCESS_TOKEN":
 				configuration.Config.Dropbox.AccessToken = value
@@ -642,61 +453,9 @@ func applyAgentEnvVars(configuration *models.Configuration, prefix string, apply
 			case "AGENT_DROPBOX_DIRECTORY":
 				configuration.Config.Dropbox.Directory = value
 				break
-
-			/* When encryption is enabled */
-			case "AGENT_ENCRYPTION":
-				configuration.Config.Encryption.Enabled = value
-				break
-			case "AGENT_ENCRYPTION_RECORDINGS":
-				configuration.Config.Encryption.Recordings = value
-				break
-			case "AGENT_ENCRYPTION_FINGERPRINT":
-				configuration.Config.Encryption.Fingerprint = value
-				break
-			case "AGENT_ENCRYPTION_PRIVATE_KEY":
-				encryptionPrivateKey := strings.ReplaceAll(value, "\\n", "\n")
-				configuration.Config.Encryption.PrivateKey = encryptionPrivateKey
-				break
-			case "AGENT_ENCRYPTION_SYMMETRIC_KEY":
-				configuration.Config.Encryption.SymmetricKey = value
-				break
-
-			/* When signing is enabled */
-			case "AGENT_SIGNING":
-				configuration.Config.Signing.Enabled = value
-				break
-			case "AGENT_SIGNING_PRIVATE_KEY":
-				signingPrivateKey := strings.ReplaceAll(value, "\\n", "\n")
-				configuration.Config.Signing.PrivateKey = signingPrivateKey
-				break
 			}
 		}
 	}
-
-	// Motion sensitivity historically used 0 to mean "use the default". Preserve
-	// that behaviour for configurations created before this field became a
-	// pointer, and also recover invalid negative values. Only apply this to the
-	// effective configuration so missing values can still be inherited between
-	// the separate global and custom layers.
-	if applyDefaults && (configuration.Config.Capture.PixelChangeThreshold == nil || *configuration.Config.Capture.PixelChangeThreshold <= 0) {
-		defaultPixelChangeThreshold := 150
-		configuration.Config.Capture.PixelChangeThreshold = &defaultPixelChangeThreshold
-	}
-
-	// Signing is a new feature, so if empty we set default values. Only applied
-	// for the effective configuration (applyDefaults), not for the separate
-	// global/custom views.
-	if applyDefaults && (configuration.Config.Signing == nil || configuration.Config.Signing.PrivateKey == "") {
-		configuration.Config.Signing = &models.Signing{
-			Enabled:    "true",
-			PrivateKey: "-----BEGIN PRIVATE KEY-----\nMIIJQgIBADANBgkqhkiG9w0BAQEFAASCCSwwggkoAgEAAoICAQDoSxjyw08lRxF4Yoqmcaewjq3XjB55dMy4tlN5MGLdr8aAPuNR9Mwh3jlh1bDpwQXNgZkHDV/q9bpdPGGi7SQo2xw+rDuo5Y1f3wdzz+iuCTPbzoGFalE+1PZlU5TEtUtlbt7MRc4pxTaLP3u0P3EtW3KnzcUarcJWZJYxzv7gqVNCA/47BN+1ptqjwz3LAlah5yaftEvVjkaANOsafUswbS4VT44XfSlbKgebORCKDuNgQiyhuV5gU+J0TOaqRWwwMAWV0UoScyJLfhHRBCrUwrCUTwqH9jfkB7pgRFsYoZJd4MKMeHJjFSum+QXCBqInSnwu8c2kJChiLMWqJ+mhpTdfUAmSkeUSStfbbcavIPbDABvMgzOcmYMIVXXe57twU0xdu3AqWLtc9kw1BkUgZblM9pSSpYrIDheEyMs2/hiLgXsIaM0nVQtqwrA7rbeEGuPblzA6hvHgwN9K6HaBqdlGSlpYZ0v3SWIMwmxRB+kIojlyuggm8Qa4mqL97GFDGl6gOBGlNUFTBUVEa3EaJ7NJpGobRGsh/9dXzcW4aYmT9WxlzTlIKksI1ro6KdRfuVWfEs4AnG8bVEJmofK8EUrueB9IdXlcJZB49xolnOZPFohtMe/0U7evQOQP3sZnX+KotCsE7OXJvL09oF58JKoqmK9lPp0+pFBU4g6NjQIDAQABAoICAA+RSWph1t+q5R3nxUxFTYMrhv5IjQe2mDxJpF3B409zolC9OHxgGUisobTY3pBqs0DtKbxUeH2A0ehUH/axEosWHcz3cmIbgxHE9kdlJ9B3Lmss6j/uw+PWutu1sgm5phaIFIvuNNRWhPB6yXUwU4sLRat1+Z9vTmIQiKdtLIrtJz/n2VDvrJxn1N+yAsE20fnrksFKyZuxVsJaZPiX/t5Yv1/z0LjFjVoL7GUA5/Si7csN4ftqEhUrkNr2BvcZlTyffrF4lZCXrtl76RNUaxhqIu3H0gFbV2UfBpuckkfAhNRpXJ4iFSxm4nQbk4ojV8+l21RFOBeDN2Z7Ocu6auP5MnzpopR66vmDCmPoid498VGgDzFQEVkOar8WAa4v9h85QgLKrth6FunmaWJUT6OggQD3yY58GSwp5+ARMETMBP2x6Eld+PGgqoJvPT1+l/e9gOw7/SJ+Wz6hRXZAm/eiXMppHtB7sfea5rscNanPjJkK9NvPM0MX9cq/iA6QjXuETkMbubjo+Cxk3ydZiIQmWQDAx/OgxTyHbeRCVhLPcAphX0clykCuHZpI9Mvvj643/LoE0mjTByWJXf/WuGJA8ElHkjSdokVJ7jumz8OZZHfq0+V7+la2opsObeQANHW5MLWrnHlRVzTGV0IRZDXh7h1ptUJ4ubdvw/GJ2NeTAoIBAQD0lXXdjYKWC4uZ4YlgydP8b1CGda9cBV5RcPt7q9Ya1R2E4ieYyohmzltopvdaOXdsTZzhtdzOzKF+2qNcbBKhBTleYZ8GN5RKbo7HwXWpzfCTjseKHOD/QPwvBKXzLVWNtXn1NrLR79Rv0wbkYF6DtoqpEPf5kMs4bx79yW+mz8FUgdEeMjKphx6Jd5RYlTUxS64K6bnK7gjHNCF2cwdxsh4B6EB649GKeNz4JXi+oQBmOcX5ncXnkJrbju+IjtCkQ40HINVNdX7XeEaaw6KGaImVjw61toPUuDaioYUojufayoyXaUJnDbHQ2tNekEpq5iwnenZCbUKWmSeRe7dLAoIBAQDzIscYujsrmPxiTj2prhG0v36NRNP99mShnnJGowiIs+UBS0EMdOmBFa2sC9uFs/VnreQNYPDJdfr7O5VK9kfbH/PSiiKJ+wVebfdAlWkJYH27JN2Kl2l/OsvRVelNvF3BWIYF46qzGxIM0axaz3T2ZAJ9SrUgeAYhak6uyM4fbexEWXxDgPGu6C0jB6IAzmHJnnh+j5+4ZXqjVyUxBYtUsWXF/TXomVcT9jxj7aUmS2/Us0XTVOVNpALqqYcekrzsX/wX0OEi5HkivYXHcNaDHx3NuUf6KdYof5DwPUM76qe+5/kWlSIHP3M6rIFK3pYFUnkHn2E8jNWcO97Aio+HAoIBAA+bcff/TbPxbKkXIUMR3fsfx02tONFwbkJYKVQM9Q6lRsrx+4Dee7HDvUWCUgpp3FsG4NnuVvbDTBLiNMZzBwVLZgvFwvYMmePeBjJs/+sj/xQLamQ/z4O6S91cOJK589mlGPEy2lpXKYExQCFWnPFetp5vPMOqH62sOZgMQJmubDHOTt/UaDM1Mhenj8nPS6OnpqV/oKF4awr7Ip+CW5k/unZ4sZSl8PsbF06mZXwUngfn6+Av1y8dpSQZjONz6ZBx1w/7YmEc/EkXnbnGfhqBlTX7+P5TdTofvyzFjc+2vsjRYANRbjFRSGWBcTd5kaYcpfim8eDvQ+6EO2gnMt0CggEAH2ln1Y8B5AEQ4lZ/avOdP//ZhsDUrqPtnl/NHckkahzrwj4JumVEYbP+SxMBGoYEd4+kvgG/OhfvBBRPlm65G9tF8fZ8vdzbdba5UfO7rUV1GP+LS8OCErjy6imySaPDbR5Vul8Oh7NAor1YCidxUf/bvnovanF3QUvtvHEfCDp4YuA4yLPZBaLjaforePUw9w5tPNSravRZYs74dBvmQ1vj7S9ojpN5B5AxfyuNwaPPX+iFZec69MvywISEe3Ozysof1Kfc3lgsOkvIA9tVK32SqSh93xkWnQbWH+OaUxxe7bAko0FDMzKEXZk53wVg1nEwR8bUljEPy+6EOdXs8wKCAQEAsEOWYMY5m7HkeG2XTTvX7ECmmdGl/c4ZDVwzB4IPxqUG7XfLmtsON8YoKOEUpJoc4ANafLXzmU+esUGbH4Ph22IWgP9jzws7jxaN/Zoku64qrSjgEZFTRIpKyhFk/ImWbS9laBW4l+m0tqTTRqoE0QEJf/2uv/04q65zrA70X9z2+KTrAtqOiRQPWl/IxRe9U4OEeGL+oD+YlXKCDsnJ3rwUIOZgJx0HWZg7K35DKwqs1nVi56FBdljiTRKAjVLRedjgDCSfGS1yUZ3krHzpaPt1qgnT3rdtYcIdbYDr66V2/gEEaz6XMGHuTk/ewjzUJxq9UTVeXOCbkRPXgVJg1w==\n-----END PRIVATE KEY-----",
-		}
-	}
-
-	// When the agent is configured through environment variables the global and
-	// custom configurations were already parsed separately (see
-	// OverrideWithEnvironmentVariables), so there is no need to mirror the
-	// effective configuration into CustomConfig anymore.
 }
 
 func SaveConfig(configDirectory string, config models.Config, configuration *models.Configuration, communication *models.Communication) error {
@@ -709,12 +468,10 @@ func SaveConfig(configDirectory string, config models.Config, configuration *mod
 			return err
 		}
 
-		if communication.CameraConnected.Load() {
+		if communication.CameraConnected {
 			select {
 			case communication.HandleBootstrap <- "restart":
-				log.Info("config.main.SaveConfig(): update config, restart agent.")
-			case <-time.After(1 * time.Second):
-				log.Info("config.main.SaveConfig(): update config, restart agent.")
+			default:
 			}
 		}
 
@@ -727,25 +484,12 @@ func SaveConfig(configDirectory string, config models.Config, configuration *mod
 }
 
 func StoreConfig(configDirectory string, config models.Config) error {
-
-	// Encryption key can be set wrong.
-	if config.Encryption != nil {
-		encryptionPrivateKey := config.Encryption.PrivateKey
-		// Replace \\n by \n
-		encryptionPrivateKey = strings.ReplaceAll(encryptionPrivateKey, "\\n", "\n")
-		config.Encryption.PrivateKey = encryptionPrivateKey
-	}
-
-	// Reset the basewidth and baseheight
-	config.Capture.IPCamera.BaseWidth = 0
-	config.Capture.IPCamera.BaseHeight = 0
-
 	// Save into database
 	if os.Getenv("DEPLOYMENT") == "factory" || os.Getenv("MACHINERY_ENVIRONMENT") == "kubernetes" {
 		// Write to mongodb
 		client := database.New()
 
-		db := client.Client.Database(database.DatabaseName)
+		db := client.Database(database.DatabaseName)
 		collection := db.Collection("configuration")
 
 		ctx, cancel := context.WithTimeout(context.Background(), 10*time.Second)

machinery/src/config/main_test.go

@@ -1,78 +0,0 @@
-package config
-
-import (
-	"context"
-	"errors"
-	"testing"
-	"time"
-
-	"github.com/kerberos-io/agent/machinery/src/database"
-	"github.com/kerberos-io/agent/machinery/src/models"
-	"go.mongodb.org/mongo-driver/mongo"
-)
-
-func TestApplyAgentEnvVarsPixelChangeThresholdDefault(t *testing.T) {
-	tests := []struct {
-		name      string
-		threshold *int
-		want      int
-	}{
-		{name: "missing", want: 150},
-		{name: "legacy zero", threshold: intPointer(0), want: 150},
-		{name: "negative", threshold: intPointer(-1), want: 150},
-		{name: "positive", threshold: intPointer(275), want: 275},
-	}
-
-	for _, test := range tests {
-		t.Run(test.name, func(t *testing.T) {
-			configuration := &models.Configuration{}
-			configuration.Config.Capture.PixelChangeThreshold = test.threshold
-
-			applyAgentEnvVars(configuration, "TEST_", true)
-
-			if configuration.Config.Capture.PixelChangeThreshold == nil {
-				t.Fatal("PixelChangeThreshold is nil after applying defaults")
-			}
-			if got := *configuration.Config.Capture.PixelChangeThreshold; got != test.want {
-				t.Fatalf("PixelChangeThreshold = %d, want %d", got, test.want)
-			}
-		})
-	}
-}
-
-func intPointer(value int) *int {
-	return &value
-}
-
-func TestNewFactoryConfigReadContextUsesDatabaseTimeout(t *testing.T) {
-	ctx, cancel := newFactoryConfigReadContext()
-	defer cancel()
-
-	deadline, ok := ctx.Deadline()
-	if !ok {
-		t.Fatal("expected read context deadline")
-	}
-
-	remaining := time.Until(deadline)
-	if remaining <= 0 {
-		t.Fatalf("deadline already expired: %v", remaining)
-	}
-	if remaining > database.TIMEOUT {
-		t.Fatalf("remaining deadline = %v, want <= %v", remaining, database.TIMEOUT)
-	}
-	if remaining < database.TIMEOUT-time.Second {
-		t.Fatalf("remaining deadline = %v, want close to %v", remaining, database.TIMEOUT)
-	}
-}
-
-func TestFactoryConfigRetryableErrors(t *testing.T) {
-	if !isRetryableFactoryConfigReadError(context.DeadlineExceeded) {
-		t.Fatal("context deadline should be retryable")
-	}
-	if isRetryableFactoryConfigReadError(mongo.ErrNoDocuments) {
-		t.Fatal("missing configuration should not retry")
-	}
-	if isRetryableFactoryConfigReadError(errors.New("invalid BSON")) {
-		t.Fatal("decode errors should not retry")
-	}
-}

machinery/src/database/main.go

@@ -7,7 +7,6 @@ import (
 	"sync"
 	"time"
 
-	log "github.com/sirupsen/logrus"
 	"go.mongodb.org/mongo-driver/mongo"
 	"go.mongodb.org/mongo-driver/mongo/options"
 )
@@ -16,19 +15,12 @@ type DB struct {
 	Client *mongo.Client
 }
 
-var TIMEOUT = 10 * time.Second
 var _init_ctx sync.Once
 var _instance *DB
+var DatabaseName = "KerberosFactory"
 
-var DatabaseName = os.Getenv("MONGODB_DATABASE_FACTORY")
+func New() *mongo.Client {
 
-func New() *DB {
-
-	if DatabaseName == "" {
-		DatabaseName = "KerberosFactory"
-	}
-
-	mongodbURI := os.Getenv("MONGODB_URI")
 	host := os.Getenv("MONGODB_HOST")
 	databaseCredentials := os.Getenv("MONGODB_DATABASE_CREDENTIALS")
 	replicaset := os.Getenv("MONGODB_REPLICASET")
@@ -36,65 +28,28 @@ func New() *DB {
 	password := os.Getenv("MONGODB_PASSWORD")
 	authentication := "SCRAM-SHA-256"
 
-	ctx, cancel := context.WithTimeout(context.Background(), TIMEOUT)
-	defer cancel()
-
 	_init_ctx.Do(func() {
+		ctx, cancel := context.WithTimeout(context.Background(), 10*time.Second)
+		defer cancel()
+
 		_instance = new(DB)
-
-		// We can also apply the complete URI
-		// e.g. "mongodb+srv://<username>:<password>@kerberos-hub.shhng.mongodb.net/?retryWrites=true&w=majority&appName=kerberos-hub"
-		if mongodbURI != "" {
-			log.WithFields(log.Fields{
-				"component":      "database",
-				"database":       DatabaseName,
-				"event":          "client_configuring",
-				"uri_configured": true,
-			}).Debug("Configuring MongoDB client")
-			serverAPI := options.ServerAPI(options.ServerAPIVersion1)
-			opts := options.Client().ApplyURI(mongodbURI).SetServerAPIOptions(serverAPI)
-
-			// Create a new client and connect to the server
-			client, err := mongo.Connect(ctx, opts)
-			if err != nil {
-				log.WithError(err).WithFields(log.Fields{
-					"component": "database",
-					"database":  DatabaseName,
-					"event":     "client_configuration_failed",
-				}).Fatal("Failed to configure MongoDB client")
-			}
-			_instance.Client = client
-
-		} else {
-			log.WithFields(log.Fields{
-				"component":             "database",
-				"database":              DatabaseName,
-				"event":                 "client_configuring",
-				"replicaset_configured": replicaset != "",
-				"uri_configured":        false,
-			}).Debug("Configuring MongoDB client")
-
-			// New MongoDB driver
-			mongodbURI := fmt.Sprintf("mongodb://%s:%s@%s", username, password, host)
-			if replicaset != "" {
-				mongodbURI = fmt.Sprintf("%s/?replicaSet=%s", mongodbURI, replicaset)
-			}
-			client, err := mongo.Connect(ctx, options.Client().ApplyURI(mongodbURI).SetAuth(options.Credential{
-				AuthMechanism: authentication,
-				AuthSource:    databaseCredentials,
-				Username:      username,
-				Password:      password,
-			}))
-			if err != nil {
-				log.WithError(err).WithFields(log.Fields{
-					"component": "database",
-					"database":  DatabaseName,
-					"event":     "client_configuration_failed",
-				}).Fatal("Failed to configure MongoDB client")
-			}
-			_instance.Client = client
+		mongodbURI := fmt.Sprintf("mongodb://%s:%s@%s", username, password, host)
+		if replicaset != "" {
+			mongodbURI = fmt.Sprintf("%s/?replicaSet=%s", mongodbURI, replicaset)
 		}
+
+		client, err := mongo.Connect(ctx, options.Client().ApplyURI(mongodbURI).SetAuth(options.Credential{
+			AuthMechanism: authentication,
+			AuthSource:    databaseCredentials,
+			Username:      username,
+			Password:      password,
+		}))
+		if err != nil {
+			fmt.Printf("Error setting up mongodb connection: %+v\n", err)
+			os.Exit(1)
+		}
+		_instance.Client = client
 	})
 
-	return _instance
+	return _instance.Client
 }

machinery/src/encryption/main.go

@@ -1,126 +0,0 @@
-package encryption
-
-import (
-	"bytes"
-	"crypto"
-	"crypto/aes"
-	"crypto/cipher"
-	"crypto/md5"
-	"crypto/rand"
-	"crypto/rsa"
-	"crypto/sha256"
-	"encoding/base64"
-	"errors"
-	"hash"
-)
-
-func DecryptWithPrivateKey(ciphertext string, privateKey *rsa.PrivateKey) ([]byte, error) {
-	cipheredValue, _ := base64.StdEncoding.DecodeString(ciphertext)
-	out, err := rsa.DecryptPKCS1v15(nil, privateKey, cipheredValue)
-	return out, err
-}
-
-func SignWithPrivateKey(data []byte, privateKey *rsa.PrivateKey) ([]byte, error) {
-	hashed := sha256.Sum256(data)
-	signature, err := rsa.SignPKCS1v15(nil, privateKey, crypto.SHA256, hashed[:])
-	return signature, err
-}
-
-func AesEncrypt(content []byte, password string) ([]byte, error) {
-	salt := make([]byte, 8)
-	_, err := rand.Read(salt)
-	if err != nil {
-		return nil, err
-	}
-	key, iv, err := DefaultEvpKDF([]byte(password), salt)
-
-	block, err := aes.NewCipher(key)
-	if err != nil {
-		return nil, err
-	}
-
-	mode := cipher.NewCBCEncrypter(block, iv)
-	cipherBytes := PKCS5Padding(content, aes.BlockSize)
-	mode.CryptBlocks(cipherBytes, cipherBytes)
-
-	cipherText := make([]byte, 16+len(cipherBytes))
-	copy(cipherText[:8], []byte("Salted__"))
-	copy(cipherText[8:16], salt)
-	copy(cipherText[16:], cipherBytes)
-	return cipherText, nil
-}
-
-func AesDecrypt(cipherText []byte, password string) ([]byte, error) {
-	if string(cipherText[:8]) != "Salted__" {
-		return nil, errors.New("invalid crypto js aes encryption")
-	}
-
-	salt := cipherText[8:16]
-	cipherBytes := cipherText[16:]
-	key, iv, err := DefaultEvpKDF([]byte(password), salt)
-	if err != nil {
-		return nil, err
-	}
-
-	block, err := aes.NewCipher(key)
-	if err != nil {
-		return nil, err
-	}
-
-	mode := cipher.NewCBCDecrypter(block, iv)
-	mode.CryptBlocks(cipherBytes, cipherBytes)
-
-	result := PKCS5UnPadding(cipherBytes)
-	return result, nil
-}
-
-func EvpKDF(password []byte, salt []byte, keySize int, iterations int, hashAlgorithm string) ([]byte, error) {
-	var block []byte
-	var hasher hash.Hash
-	derivedKeyBytes := make([]byte, 0)
-	switch hashAlgorithm {
-	case "md5":
-		hasher = md5.New()
-	default:
-		return []byte{}, errors.New("not implement hasher algorithm")
-	}
-	for len(derivedKeyBytes) < keySize*4 {
-		if len(block) > 0 {
-			hasher.Write(block)
-		}
-		hasher.Write(password)
-		hasher.Write(salt)
-		block = hasher.Sum([]byte{})
-		hasher.Reset()
-
-		for i := 1; i < iterations; i++ {
-			hasher.Write(block)
-			block = hasher.Sum([]byte{})
-			hasher.Reset()
-		}
-		derivedKeyBytes = append(derivedKeyBytes, block...)
-	}
-	return derivedKeyBytes[:keySize*4], nil
-}
-
-func DefaultEvpKDF(password []byte, salt []byte) (key []byte, iv []byte, err error) {
-	keySize := 256 / 32
-	ivSize := 128 / 32
-	derivedKeyBytes, err := EvpKDF(password, salt, keySize+ivSize, 1, "md5")
-	if err != nil {
-		return []byte{}, []byte{}, err
-	}
-	return derivedKeyBytes[:keySize*4], derivedKeyBytes[keySize*4:], nil
-}
-
-func PKCS5UnPadding(src []byte) []byte {
-	length := len(src)
-	unpadding := int(src[length-1])
-	return src[:(length - unpadding)]
-}
-
-func PKCS5Padding(src []byte, blockSize int) []byte {
-	padding := blockSize - len(src)%blockSize
-	padtext := bytes.Repeat([]byte{byte(padding)}, padding)
-	return append(src, padtext...)
-}

machinery/src/lifecycle/supervisor.go

@@ -1,336 +0,0 @@
-package lifecycle
-
-import (
-	"context"
-	"errors"
-	"fmt"
-	"runtime/debug"
-	"sort"
-	"sync"
-	"time"
-)
-
-var (
-	ErrSupervisorSealed  = errors.New("supervisor is sealed")
-	ErrSupervisorStopped = errors.New("supervisor is shutting down")
-	ErrTaskExists        = errors.New("task already exists")
-)
-
-type TaskFunc func(context.Context) error
-
-type TaskPolicy struct {
-	Required    bool
-	LongRunning bool
-}
-
-type TaskStatus string
-
-const (
-	TaskRunning   TaskStatus = "running"
-	TaskSucceeded TaskStatus = "succeeded"
-	TaskFailed    TaskStatus = "failed"
-	TaskPanicked  TaskStatus = "panicked"
-)
-
-type TaskSnapshot struct {
-	Name      string
-	Policy    TaskPolicy
-	Status    TaskStatus
-	StartedAt time.Time
-	EndedAt   time.Time
-	Error     string
-	Panic     string
-	Stack     []byte
-}
-
-type Failure struct {
-	Task  string
-	Cause error
-	Panic string
-	Stack []byte
-}
-
-func (f Failure) Error() string {
-	if f.Cause == nil {
-		return fmt.Sprintf("task %q failed", f.Task)
-	}
-	return f.Cause.Error()
-}
-
-type ShutdownReport struct {
-	Complete bool
-	Cause    error
-	Tasks    []TaskSnapshot
-	Running  []TaskSnapshot
-}
-
-type supervisorPhase uint8
-
-const (
-	phaseStarting supervisorPhase = iota
-	phaseRunning
-	phaseDraining
-)
-
-type taskState struct {
-	TaskSnapshot
-}
-
-type Supervisor struct {
-	ctx    context.Context
-	cancel context.CancelCauseFunc
-
-	mu        sync.Mutex
-	phase     supervisorPhase
-	sealed    bool
-	active    int
-	tasks     map[string]*taskState
-	allDone   chan struct{}
-	doneOnce  sync.Once
-	start     chan struct{}
-	startOnce sync.Once
-
-	failures    chan Failure
-	failureOnce sync.Once
-
-	stopParentCancel func() bool
-}
-
-func NewSupervisor(parent context.Context) *Supervisor {
-	if parent == nil {
-		parent = context.Background()
-	}
-
-	ctx, cancel := context.WithCancelCause(parent)
-	supervisor := &Supervisor{
-		ctx:      ctx,
-		cancel:   cancel,
-		phase:    phaseStarting,
-		tasks:    make(map[string]*taskState),
-		allDone:  make(chan struct{}),
-		start:    make(chan struct{}),
-		failures: make(chan Failure, 1),
-	}
-
-	stopParentCancel := context.AfterFunc(parent, func() {
-		supervisor.BeginShutdown(context.Cause(parent))
-	})
-	supervisor.mu.Lock()
-	if supervisor.sealed && supervisor.active == 0 {
-		supervisor.mu.Unlock()
-		stopParentCancel()
-	} else {
-		supervisor.stopParentCancel = stopParentCancel
-		supervisor.mu.Unlock()
-	}
-
-	return supervisor
-}
-
-func (s *Supervisor) Context() context.Context {
-	return s.ctx
-}
-
-func (s *Supervisor) Failures() <-chan Failure {
-	return s.failures
-}
-
-func (s *Supervisor) Go(name string, policy TaskPolicy, task TaskFunc) error {
-	if name == "" {
-		return errors.New("task name is required")
-	}
-	if task == nil {
-		return errors.New("task function is required")
-	}
-
-	s.mu.Lock()
-	if s.sealed {
-		s.mu.Unlock()
-		return fmt.Errorf("%w: %s", ErrSupervisorSealed, name)
-	}
-	if s.ctx.Err() != nil {
-		s.mu.Unlock()
-		return fmt.Errorf("%w: %s", ErrSupervisorStopped, name)
-	}
-	if _, exists := s.tasks[name]; exists {
-		s.mu.Unlock()
-		return fmt.Errorf("%w: %s", ErrTaskExists, name)
-	}
-
-	state := &taskState{TaskSnapshot: TaskSnapshot{
-		Name:      name,
-		Policy:    policy,
-		Status:    TaskRunning,
-		StartedAt: time.Now(),
-	}}
-	s.tasks[name] = state
-	s.active++
-	s.mu.Unlock()
-
-	go s.run(state, task)
-	return nil
-}
-
-func (s *Supervisor) run(state *taskState, task TaskFunc) {
-	var taskErr error
-	panicked := true
-	var panicValue string
-	var panicStack []byte
-
-	defer func() {
-		recovered := recover()
-		if panicked {
-			panicValue = fmt.Sprint(recovered)
-			panicStack = debug.Stack()
-			taskErr = fmt.Errorf("task %q panicked: %s", state.Name, panicValue)
-		}
-		s.finish(state, taskErr, panicked, panicValue, panicStack)
-	}()
-
-	select {
-	case <-s.start:
-	case <-s.ctx.Done():
-		panicked = false
-		return
-	}
-
-	taskErr = task(s.ctx)
-	panicked = false
-}
-
-func (s *Supervisor) finish(
-	state *taskState,
-	taskErr error,
-	panicked bool,
-	panicValue string,
-	panicStack []byte,
-) {
-	var failure *Failure
-
-	s.mu.Lock()
-	state.EndedAt = time.Now()
-	state.Error = ""
-	state.Panic = panicValue
-	state.Stack = append([]byte(nil), panicStack...)
-	switch {
-	case panicked:
-		state.Status = TaskPanicked
-		state.Error = taskErr.Error()
-	case taskErr != nil:
-		state.Status = TaskFailed
-		state.Error = taskErr.Error()
-	default:
-		state.Status = TaskSucceeded
-	}
-
-	shuttingDown := s.phase == phaseDraining || s.ctx.Err() != nil
-	unexpected := panicked || (!shuttingDown &&
-		(state.Policy.Required && (taskErr != nil || state.Policy.LongRunning)))
-	if unexpected {
-		cause := taskErr
-		if cause == nil {
-			cause = fmt.Errorf("required long-running task %q exited", state.Name)
-		}
-		failure = &Failure{
-			Task:  state.Name,
-			Cause: cause,
-			Panic: panicValue,
-			Stack: append([]byte(nil), panicStack...),
-		}
-		s.phase = phaseDraining
-		s.sealed = true
-		s.cancel(failure.Cause)
-		s.failureOnce.Do(func() {
-			s.failures <- *failure
-		})
-	}
-
-	s.active--
-	s.closeDoneIfReadyLocked()
-	s.mu.Unlock()
-}
-
-func (s *Supervisor) Seal() {
-	s.mu.Lock()
-	s.sealed = true
-	if s.phase == phaseStarting {
-		s.phase = phaseRunning
-	}
-	s.startOnce.Do(func() {
-		close(s.start)
-	})
-	s.closeDoneIfReadyLocked()
-	s.mu.Unlock()
-}
-
-func (s *Supervisor) BeginShutdown(cause error) {
-	if cause == nil {
-		cause = context.Canceled
-	}
-
-	s.mu.Lock()
-	s.phase = phaseDraining
-	s.sealed = true
-	s.cancel(cause)
-	s.closeDoneIfReadyLocked()
-	s.mu.Unlock()
-}
-
-func (s *Supervisor) Wait(ctx context.Context) ShutdownReport {
-	if ctx == nil {
-		ctx = context.Background()
-	}
-
-	select {
-	case <-s.allDone:
-	case <-ctx.Done():
-	}
-
-	return s.report()
-}
-
-func (s *Supervisor) Snapshot() []TaskSnapshot {
-	return s.report().Tasks
-}
-
-func (s *Supervisor) closeDoneIfReadyLocked() {
-	if !s.sealed || s.active != 0 {
-		return
-	}
-	if s.stopParentCancel != nil {
-		s.stopParentCancel()
-		s.stopParentCancel = nil
-	}
-	s.doneOnce.Do(func() {
-		close(s.allDone)
-	})
-}
-
-func (s *Supervisor) report() ShutdownReport {
-	s.mu.Lock()
-	defer s.mu.Unlock()
-
-	tasks := make([]TaskSnapshot, 0, len(s.tasks))
-	running := make([]TaskSnapshot, 0)
-	for _, state := range s.tasks {
-		snapshot := state.TaskSnapshot
-		snapshot.Stack = append([]byte(nil), state.Stack...)
-		tasks = append(tasks, snapshot)
-		if snapshot.Status == TaskRunning {
-			running = append(running, snapshot)
-		}
-	}
-	sort.Slice(tasks, func(i, j int) bool {
-		return tasks[i].Name < tasks[j].Name
-	})
-	sort.Slice(running, func(i, j int) bool {
-		return running[i].Name < running[j].Name
-	})
-
-	return ShutdownReport{
-		Complete: s.sealed && s.active == 0,
-		Cause:    context.Cause(s.ctx),
-		Tasks:    tasks,
-		Running:  running,
-	}
-}

machinery/src/lifecycle/supervisor_test.go

@@ -1,300 +0,0 @@
-package lifecycle
-
-import (
-	"context"
-	"errors"
-	"strings"
-	"sync"
-	"testing"
-	"time"
-)
-
-func TestSupervisorWaitsForSeal(t *testing.T) {
-	supervisor := NewSupervisor(context.Background())
-	started := make(chan struct{})
-	if err := supervisor.Go("quick", TaskPolicy{}, func(context.Context) error {
-		close(started)
-		return nil
-	}); err != nil {
-		t.Fatal(err)
-	}
-
-	waitContext, cancel := context.WithTimeout(context.Background(), 20*time.Millisecond)
-	defer cancel()
-	if report := supervisor.Wait(waitContext); report.Complete {
-		t.Fatal("Wait() completed before Seal()")
-	}
-	select {
-	case <-started:
-		t.Fatal("task started before Seal()")
-	default:
-	}
-
-	supervisor.Seal()
-	<-started
-	if report := supervisor.Wait(context.Background()); !report.Complete {
-		t.Fatal("Wait() did not complete after Seal()")
-	}
-}
-
-func TestSupervisorSealsEmptyGroup(t *testing.T) {
-	supervisor := NewSupervisor(context.Background())
-	supervisor.Seal()
-
-	report := supervisor.Wait(context.Background())
-	if !report.Complete || len(report.Tasks) != 0 {
-		t.Fatalf("Wait() report = %+v, want complete empty report", report)
-	}
-}
-
-func TestSupervisorReportsRunningTasksOnTimeout(t *testing.T) {
-	supervisor := NewSupervisor(context.Background())
-	release := make(chan struct{})
-	if err := supervisor.Go("blocked", TaskPolicy{}, func(context.Context) error {
-		<-release
-		return nil
-	}); err != nil {
-		t.Fatal(err)
-	}
-	supervisor.Seal()
-
-	waitContext, cancel := context.WithTimeout(context.Background(), 20*time.Millisecond)
-	defer cancel()
-	report := supervisor.Wait(waitContext)
-	if report.Complete {
-		t.Fatal("Wait() unexpectedly completed")
-	}
-	if len(report.Running) != 1 || report.Running[0].Name != "blocked" {
-		t.Fatalf("Wait() running tasks = %+v, want blocked", report.Running)
-	}
-
-	close(release)
-	if report = supervisor.Wait(context.Background()); !report.Complete {
-		t.Fatal("Wait() did not complete after releasing task")
-	}
-}
-
-func TestSupervisorFailsWhenRequiredLongRunningTaskExits(t *testing.T) {
-	supervisor := NewSupervisor(context.Background())
-	release := make(chan struct{})
-	if err := supervisor.Go("recorder", TaskPolicy{Required: true, LongRunning: true}, func(context.Context) error {
-		<-release
-		return nil
-	}); err != nil {
-		t.Fatal(err)
-	}
-	supervisor.Seal()
-	close(release)
-
-	select {
-	case failure := <-supervisor.Failures():
-		if failure.Task != "recorder" || !strings.Contains(failure.Error(), "exited") {
-			t.Fatalf("failure = %+v", failure)
-		}
-	case <-time.After(time.Second):
-		t.Fatal("required task exit did not emit a failure")
-	}
-}
-
-func TestSupervisorAllowsRequiredOneShotTaskToSucceed(t *testing.T) {
-	supervisor := NewSupervisor(context.Background())
-	if err := supervisor.Go("setup", TaskPolicy{Required: true}, func(context.Context) error {
-		return nil
-	}); err != nil {
-		t.Fatal(err)
-	}
-	supervisor.Seal()
-	if report := supervisor.Wait(context.Background()); !report.Complete {
-		t.Fatal("Wait() did not complete")
-	}
-
-	select {
-	case failure := <-supervisor.Failures():
-		t.Fatalf("successful one-shot task emitted failure: %+v", failure)
-	default:
-	}
-}
-
-func TestSupervisorFailsWhenRequiredOneShotTaskReturnsError(t *testing.T) {
-	supervisor := NewSupervisor(context.Background())
-	wantErr := errors.New("setup failed")
-	if err := supervisor.Go("setup", TaskPolicy{Required: true}, func(context.Context) error {
-		return wantErr
-	}); err != nil {
-		t.Fatal(err)
-	}
-	supervisor.Seal()
-
-	select {
-	case failure := <-supervisor.Failures():
-		if !errors.Is(failure.Cause, wantErr) {
-			t.Fatalf("failure cause = %v, want %v", failure.Cause, wantErr)
-		}
-	case <-time.After(time.Second):
-		t.Fatal("required task error did not emit a failure")
-	}
-}
-
-func TestSupervisorRecoversPanicAndCapturesStack(t *testing.T) {
-	supervisor := NewSupervisor(context.Background())
-	if err := supervisor.Go("panic", TaskPolicy{}, func(context.Context) error {
-		panic("boom")
-	}); err != nil {
-		t.Fatal(err)
-	}
-	supervisor.Seal()
-
-	select {
-	case failure := <-supervisor.Failures():
-		if failure.Task != "panic" || failure.Panic != "boom" || len(failure.Stack) == 0 {
-			t.Fatalf("failure = %+v, want captured panic and stack", failure)
-		}
-	case <-time.After(time.Second):
-		t.Fatal("panic did not emit a failure")
-	}
-
-	report := supervisor.Wait(context.Background())
-	if !report.Complete || len(report.Tasks) != 1 || len(report.Tasks[0].Stack) == 0 {
-		t.Fatalf("report = %+v, want completed task with captured stack", report)
-	}
-}
-
-func TestSupervisorCapturesEmptyPanicDuringShutdown(t *testing.T) {
-	supervisor := NewSupervisor(context.Background())
-	started := make(chan struct{})
-	if err := supervisor.Go("panic", TaskPolicy{}, func(ctx context.Context) error {
-		close(started)
-		<-ctx.Done()
-		panic("")
-	}); err != nil {
-		t.Fatal(err)
-	}
-	supervisor.Seal()
-	<-started
-	supervisor.BeginShutdown(errors.New("requested shutdown"))
-
-	select {
-	case failure := <-supervisor.Failures():
-		if failure.Task != "panic" || len(failure.Stack) == 0 {
-			t.Fatalf("failure = %+v, want captured panic and stack", failure)
-		}
-	case <-time.After(time.Second):
-		t.Fatal("panic during shutdown did not emit a failure")
-	}
-	if report := supervisor.Wait(context.Background()); !report.Complete || report.Tasks[0].Status != TaskPanicked {
-		t.Fatalf("report = %+v, want completed panicked task", report)
-	}
-}
-
-func TestSupervisorPublishesFailureBeforeCompletion(t *testing.T) {
-	supervisor := NewSupervisor(context.Background())
-	wantErr := errors.New("setup failed")
-	if err := supervisor.Go("setup", TaskPolicy{Required: true}, func(context.Context) error {
-		return wantErr
-	}); err != nil {
-		t.Fatal(err)
-	}
-	supervisor.Seal()
-
-	report := supervisor.Wait(context.Background())
-	if !report.Complete || !errors.Is(report.Cause, wantErr) {
-		t.Fatalf("report = %+v, want complete report caused by task failure", report)
-	}
-	select {
-	case failure := <-supervisor.Failures():
-		if !errors.Is(failure.Cause, wantErr) {
-			t.Fatalf("failure cause = %v, want %v", failure.Cause, wantErr)
-		}
-	default:
-		t.Fatal("failure was not published before completion")
-	}
-}
-
-func TestSupervisorCompletedWaitWinsOverCanceledContext(t *testing.T) {
-	supervisor := NewSupervisor(context.Background())
-	supervisor.Seal()
-
-	waitContext, cancel := context.WithCancel(context.Background())
-	cancel()
-	if report := supervisor.Wait(waitContext); !report.Complete {
-		t.Fatalf("report = %+v, want authoritative completion state", report)
-	}
-}
-
-func TestSupervisorRejectsTaskAfterParentCancellation(t *testing.T) {
-	parent, cancel := context.WithCancel(context.Background())
-	supervisor := NewSupervisor(parent)
-	cancel()
-
-	err := supervisor.Go("late", TaskPolicy{}, func(context.Context) error { return nil })
-	if !errors.Is(err, ErrSupervisorStopped) && !errors.Is(err, ErrSupervisorSealed) {
-		t.Fatalf("Go() error = %v, want stopped or sealed supervisor", err)
-	}
-	supervisor.BeginShutdown(context.Canceled)
-	if report := supervisor.Wait(context.Background()); !report.Complete {
-		t.Fatalf("report = %+v, want complete canceled supervisor", report)
-	}
-}
-
-func TestSupervisorShutdownBeforeSealDoesNotStartTasks(t *testing.T) {
-	supervisor := NewSupervisor(context.Background())
-	started := make(chan struct{})
-	if err := supervisor.Go("worker", TaskPolicy{}, func(context.Context) error {
-		close(started)
-		return nil
-	}); err != nil {
-		t.Fatal(err)
-	}
-
-	supervisor.BeginShutdown(errors.New("startup aborted"))
-	if report := supervisor.Wait(context.Background()); !report.Complete {
-		t.Fatalf("report = %+v, want completed aborted startup", report)
-	}
-	select {
-	case <-started:
-		t.Fatal("task started after startup was aborted")
-	default:
-	}
-}
-
-func TestSupervisorRejectsDuplicateAndLateTasks(t *testing.T) {
-	supervisor := NewSupervisor(context.Background())
-	release := make(chan struct{})
-	if err := supervisor.Go("worker", TaskPolicy{}, func(context.Context) error {
-		<-release
-		return nil
-	}); err != nil {
-		t.Fatal(err)
-	}
-	if err := supervisor.Go("worker", TaskPolicy{}, func(context.Context) error { return nil }); !errors.Is(err, ErrTaskExists) {
-		t.Fatalf("duplicate Go() error = %v, want ErrTaskExists", err)
-	}
-
-	supervisor.Seal()
-	if err := supervisor.Go("late", TaskPolicy{}, func(context.Context) error { return nil }); !errors.Is(err, ErrSupervisorSealed) {
-		t.Fatalf("late Go() error = %v, want ErrSupervisorSealed", err)
-	}
-	close(release)
-}
-
-func TestSupervisorConcurrentStartAndSeal(t *testing.T) {
-	supervisor := NewSupervisor(context.Background())
-	var starters sync.WaitGroup
-	for index := 0; index < 100; index++ {
-		starters.Add(1)
-		go func(index int) {
-			defer starters.Done()
-			_ = supervisor.Go(
-				"worker-"+time.Unix(0, int64(index)).Format("150405.000000000"),
-				TaskPolicy{},
-				func(context.Context) error { return nil },
-			)
-		}(index)
-	}
-
-	supervisor.Seal()
-	starters.Wait()
-	if report := supervisor.Wait(context.Background()); !report.Complete {
-		t.Fatal("Wait() did not complete after concurrent Start and Seal")
-	}
-}

machinery/src/log/main.go

@@ -0,0 +1,136 @@
+package log
+
+import (
+	"os"
+	"time"
+
+	"github.com/op/go-logging"
+	"github.com/sirupsen/logrus"
+	"gopkg.in/natefinch/lumberjack.v2"
+)
+
+// The logging library being used everywhere.
+var Log = Logging{
+	Logger: "logrus",
+	Level:  "debug",
+}
+
+// -----------------
+// This a gologging
+// -> github.com/op/go-logging
+
+var gologging = logging.MustGetLogger("gologger")
+
+func ConfigureGoLogging(configDirectory string, timezone *time.Location) {
+	// Logging
+	var format = logging.MustStringFormatter(
+		`%{color}%{time:15:04:05.000} %{shortfunc} ▶ %{level:.4s} %{id:03x}%{color:reset} %{message}`,
+	)
+	var format2 = logging.MustStringFormatter(
+		`%{time:15:04:05.000} %{shortfunc} ▶ %{level:.4s}  %{id:03x}%{color:reset} %{message}`,
+	)
+	stdBackend := logging.NewLogBackend(os.Stderr, "", 0)
+	stdBackendLeveled := logging.NewBackendFormatter(stdBackend, format)
+	fileBackend := logging.NewLogBackend(&lumberjack.Logger{
+		Filename: configDirectory + "/data/log/machinery.txt",
+		MaxSize:  2,    // megabytes
+		Compress: true, // disabled by default
+	}, "", 0)
+	fileBackendLeveled := logging.NewBackendFormatter(fileBackend, format2)
+	logging.SetBackend(stdBackendLeveled, fileBackendLeveled)
+	logging.SetLevel(logging.DEBUG, "")
+}
+
+// -----------------
+// This a logrus
+// -> github.com/sirupsen/logrus
+
+func ConfigureLogrus(timezone *time.Location) {
+	// Log as JSON instead of the default ASCII formatter.
+	logrus.SetFormatter(LocalTimeZoneFormatter{
+		Timezone:  timezone,
+		Formatter: &logrus.JSONFormatter{},
+	}) // Use local timezone for providing datetime in logs!
+
+	// Output to stdout instead of the default stderr
+	// Can be any io.Writer, see below for File example
+	logrus.SetOutput(os.Stdout)
+
+	// Only log the warning severity or above.
+	logrus.SetLevel(logrus.InfoLevel)
+}
+
+type LocalTimeZoneFormatter struct {
+	Timezone  *time.Location
+	Formatter logrus.Formatter
+}
+
+func (u LocalTimeZoneFormatter) Format(e *logrus.Entry) ([]byte, error) {
+	e.Time = e.Time.In(u.Timezone)
+	return u.Formatter.Format(e)
+}
+
+type Logging struct {
+	Logger string
+	Level  string
+}
+
+func (self *Logging) Init(configDirectory string, timezone *time.Location) {
+	switch self.Logger {
+	case "go-logging":
+		ConfigureGoLogging(configDirectory, timezone)
+	case "logrus":
+		ConfigureLogrus(timezone)
+	default:
+	}
+}
+
+func (self *Logging) Info(sentence string) {
+	switch self.Logger {
+	case "go-logging":
+		gologging.Info(sentence)
+	case "logrus":
+		logrus.Info(sentence)
+	default:
+	}
+}
+
+func (self *Logging) Warning(sentence string) {
+	switch self.Logger {
+	case "go-logging":
+		gologging.Warning(sentence)
+	case "logrus":
+		logrus.Warn(sentence)
+	default:
+	}
+}
+
+func (self *Logging) Debug(sentence string) {
+	switch self.Logger {
+	case "go-logging":
+		gologging.Debug(sentence)
+	case "logrus":
+		logrus.Debug(sentence)
+	default:
+	}
+}
+
+func (self *Logging) Error(sentence string) {
+	switch self.Logger {
+	case "go-logging":
+		gologging.Error(sentence)
+	case "logrus":
+		logrus.Error(sentence)
+	default:
+	}
+}
+
+func (self *Logging) Fatal(sentence string) {
+	switch self.Logger {
+	case "go-logging":
+		gologging.Fatal(sentence)
+	case "logrus":
+		logrus.Fatal(sentence)
+	default:
+	}
+}