Commit Graph

592 Commits

Author SHA1 Message Date
Jerus Bot
19fa3ba966 chore: update prlog for pr 2025-10-23 12:09:04 +01:00
Jeremiah Russell
7bbc41e1c3 🔧 chore(vscode): update cspell dictionary
- add "creds", "tokencache", and "trdir" to cspell dictionary
2025-10-23 12:09:04 +01:00
Jeremiah Russell
6d24a0175c feat(cli): add token and auth uri config options
- allow users to configure token_uri and auth_uri in config file
- add default values for token_uri and auth_uri
2025-10-23 12:09:04 +01:00
Jeremiah Russell
15599e2258 🧹 Refactor: add run_init_basic helper to eliminate command duplication 2025-10-23 11:16:25 +01:00
Jerus Bot
47a9233856 chore: update prlog for pr 2025-10-23 11:16:25 +01:00
Jeremiah Russell
4550ffca92 🧹 Refactor: eliminate test duplication with helper functions 2025-10-23 11:16:25 +01:00
Jeremiah Russell
5228a24b32 📝 Update documentation for --skip-rules flag 2025-10-23 11:16:25 +01:00
Jeremiah Russell
cc8259bd6a Add integration tests for --skip-rules 2025-10-23 11:16:25 +01:00
Jeremiah Russell
e33c0320a0 Add unit tests for --skip-rules functionality 2025-10-23 11:16:25 +01:00
Jeremiah Russell
c39e64f0ac Implement core logic for --skip-rules in init 2025-10-23 11:16:25 +01:00
Jeremiah Russell
0b24767065 Add --skip-rules flag to init command 2025-10-23 11:16:25 +01:00
Jerus Bot
79e0de72e6 chore: update prlog for pr 2025-10-23 07:37:30 +01:00
Jeremiah Russell
05b4a968f7 🐛 fix(config): improve config logging format
- use pretty format for config logging to enhance readability
2025-10-23 07:37:30 +01:00
Jerus Bot
c3d2f818b8 chore: update prlog for pr 2025-10-23 06:52:46 +01:00
Jeremiah Russell
89fce9792e feat(config): load application secret with logging
- add logging to indicate the source of the application secret
- log the configuration root to aid in debugging credential file loading
2025-10-23 06:52:46 +01:00
Jerus Bot
2ec8e00119 chore: Release cull-gmail v0.0.13 2025-10-22 16:37:03 +00:00
Jerus Bot
33710e48c1 chore: update prlog for pr 2025-10-22 17:35:43 +01:00
Jeremiah Russell
c1f7cf859a 🐛 fix(cli): load config file only if it exists
- only load config file if it exists
- prevents error when config file is not present
2025-10-22 17:35:43 +01:00
Jeremiah Russell
2af6df145f 🐛 fix(cli): fix config file loading
- remove unnecessary config_file.required(false)
2025-10-22 17:35:43 +01:00
Jeremiah Russell
825f2de316 🐛 fix(client_config): print config for debugging
- add log to print config for debugging
2025-10-22 17:35:43 +01:00
Jeremiah Russell
4aef4608fc feat(cli): enhance configuration loading with logging
- add logging to display the config file being loaded
2025-10-22 17:35:43 +01:00
Jeremiah Russell
3112e23040 🐛 fix(cli): correct spelling errors in documentation
- correct spelling of "behaviour" to "behavior"
- correct spelling of "dry-run mode"
2025-10-22 17:35:43 +01:00
Jeremiah Russell
60d37dfc41 🐛 fix(cli): load config file as optional
- the config file should not be required
- set required to false
2025-10-22 17:35:43 +01:00
Jerus Bot
9b16105776 chore: Release cull-gmail v0.0.12 2025-10-22 13:40:14 +00:00
Jerus Bot
65c3ac41b9 chore: update prlog for pr 2025-10-22 12:10:24 +01:00
Jeremiah Russell
2b2c0ca414 📦 build(ci): upgrade circleci-toolkit orb to v2.13.5
- upgrade circleci-toolkit orb to the latest version
- remove deprecated commands and jobs
2025-10-22 12:10:24 +01:00
Jerus Bot
23361bf936 chore: update prlog for pr 2025-10-22 11:24:20 +01:00
Jeremiah Russell
fa72a93e1d 🐛 fix(ci): correct default test runner value
- fix default test runner value in circleci config
2025-10-22 11:24:20 +01:00
Jeremiah Russell
4283adf7b2 ♻️ Refactor duplicated test setup in integration tests
Extract repeated test command setup into helper functions:
- run_init_with_dirs() for tests with separate config/rules directories
- run_init_with_credential() for tests with credential files

This eliminates code duplication and makes tests more maintainable.
Also fixed duplicate #[test] attribute warning.
2025-10-22 06:38:00 +01:00
Jeremiah Russell
d92d4ad9c0 ♻️ Refactor duplicated InitCli creation in tests
Extract repeated InitCli instance creation into helper functions:
- create_test_init_cli() for default test instances
- create_test_init_cli_with_force() for force-enabled instances

This reduces code duplication and makes test setup more maintainable.
2025-10-22 06:38:00 +01:00
Jerus Bot
acb5e11b4b chore: update prlog for pr 2025-10-22 06:38:00 +01:00
Jeremiah Russell
2b29382d5e 🎨 Apply cargo fmt formatting 2025-10-22 06:38:00 +01:00
Jeremiah Russell
10a1a1e058 🐛 Fix duplicate CreateDir operation in init planning
Prevent duplicate CreateDir operations when rules directory
is the same as config directory by checking if the directory
creation has already been planned before adding another one.
2025-10-22 06:38:00 +01:00
Jeremiah Russell
d4cc2621db Add configurable rules directory support
- Add rules configuration option to ClientConfig
- Support custom rules file paths via config and CLI
- Add --rules-dir option to init command
- Update Rules struct to accept custom file paths
- Add helper functions for rules path resolution
- Fix doc comment formatting issues
- Add integration tests for custom rules paths
2025-10-22 06:38:00 +01:00
Jeremiah Russell
e914e492e8 test: add integration tests for --rules-dir feature
- Add test_init_with_separate_rules_directory to verify rules created in custom location
- Add test_init_rules_dir_dry_run to verify dry-run behavior with --rules-dir
- Verify config file contains correct rules path when using separate directory
- All 12 init integration tests passing (11 run, 1 ignored)
2025-10-22 06:38:00 +01:00
Jeremiah Russell
bcb93fd68f feat: integrate configurable rules path throughout CLI
- Make parse_config_root() public for reuse in main.rs
- Add get_rules_path() helper to extract and resolve rules path from config
- Update main CLI to use configured rules path for default rule execution
- Add run_with_rules_path() method to RulesCli for custom path support
- Update all unit tests to include rules_dir field
- Rules path now supports h:, c:, r: prefixes throughout the application
2025-10-22 06:38:00 +01:00
Jeremiah Russell
20b36a00ed feat: add get_rules_from() to load rules from custom path
- Add get_rules_from(path) function that accepts optional custom path
- Keep get_rules() as backward-compatible wrapper
- Automatically create and save default rules to custom path if not found
2025-10-22 06:38:00 +01:00
Jeremiah Russell
2083c5c5fe feat: add configurable rules directory support to Rules and InitCli
- Add Rules::load_from() and Rules::save_to() methods for custom paths
- Add --rules-dir option to init command
- Support h:, c:, r: path prefixes for rules directory
- Generate config file with correct rules path when using separate directory
- Create rules directory automatically if it doesn't exist
- Maintain backward compatibility with default ~/.cull-gmail/rules.toml
2025-10-22 06:38:00 +01:00
Jeremiah Russell
df9d2b6c8a 🔧 fix: address clippy warnings after refactoring
- Change &PathBuf to &Path parameter in plan_credential_file_operation
- Use inline format string in log message
- Both formatting and linting now clean
2025-10-21 14:48:31 +01:00
Jeremiah Russell
aaa4ebcbde ♻️ refactor: reduce cognitive complexity of plan_operations and execute_operation
## Refactoring Changes

### plan_operations function:
- Split monolithic function into focused single-purpose methods
- Extract plan_config_directory, plan_credential_file_operation, etc.
- Add check_file_conflicts helper to eliminate repetitive error checking
- Fix should_backup logic (was always returning true)

### execute_operation function:
- Replace large match statement with focused execution methods
- Extract execute_create_directory, execute_copy_file, etc.
- Add handle_existing_file helper for backup/interactive logic
- Add prompt_for_overwrite and apply_permissions_if_needed helpers

## Benefits:
- Each function now has single responsibility
- Eliminated code duplication in conflict checking and interactive prompts
- Reduced cyclomatic complexity from ~15 to 2-3 per function
- Improved testability and maintainability
- All tests continue to pass
2025-10-21 14:48:31 +01:00
Jeremiah Russell
fc9a1418b9 ♻️ refactor: extract mock credential file creation into helper function
- Add create_mock_credential_file() helper to eliminate duplication
- Replace identical credential JSON creation in two integration tests
- Improves test maintainability and reduces code duplication
- All tests continue to pass with same behavior
2025-10-21 14:48:31 +01:00
Jerus Bot
4fd125189a chore: update prlog for pr 2025-10-21 14:48:31 +01:00
Jeremiah Russell
5bcfc8fd29 🐛 fix: allow init command to run without existing config file
- Move init command handling before config loading in CLI dispatcher
- Prevents init from failing when no configuration exists yet
- Fixes CircleCI test failures where init was trying to load ~/.cull-gmail/cull-gmail.toml
- All integration tests now pass in CI environment
2025-10-21 14:48:31 +01:00
Jeremiah Russell
b33458cf3e 🎨 style: apply rustfmt formatting to test assertions 2025-10-21 14:48:31 +01:00
Jeremiah Russell
3dcd229ee9 🐛 fix: replace hardcoded paths in tests with temp directories for CI compatibility 2025-10-21 14:48:31 +01:00
Jeremiah Russell
8f79081b4f 🔧 fix: address clippy warnings and improve code formatting 2025-10-21 14:48:31 +01:00
Jeremiah Russell
5f40af6c88 📝 docs(init): add docs and update README and WARP 2025-10-21 14:48:31 +01:00
Jeremiah Russell
2cfd16c8ac 🧪 test(init): unit tests for planning and file IO 2025-10-21 14:48:31 +01:00
Jeremiah Russell
0a047dd547 🏗️ feat(init): implement plan and apply operations
- Add comprehensive Operation enum for file/directory operations
- Implement path resolution with h:, c:, r: prefix support
- Create default config and rules file templates
- Add interactive prompts for credential file setup
- Support dry-run mode with detailed operation preview
- Include progress bar for operation execution
- Implement secure file permissions (0600 for credentials, 0700 for tokens)
- Add timestamped backup functionality for existing files
- Support force overwrite and interactive conflict resolution
2025-10-21 14:48:31 +01:00
Jeremiah Russell
fd70ef9511 feat(cli): scaffold InitCli subcommand and clap wiring 2025-10-21 14:48:31 +01:00