From ff5396e2ec8a8dbb9f58c58bec679eeced68dae4 Mon Sep 17 00:00:00 2001 From: Jaco Greeff Date: Tue, 20 Feb 2018 14:37:28 +0100 Subject: [PATCH] Use u8a.toString as u8aToString (#93) * Use u8a.toString as u8aToString * Fix lint --- packages/util/src/u8a/toString.js | 10 ++-------- packages/util/src/u8a/toString.spec.js | 4 ++-- 2 files changed, 4 insertions(+), 10 deletions(-) diff --git a/packages/util/src/u8a/toString.js b/packages/util/src/u8a/toString.js index 92aff563b..fb4e5503c 100644 --- a/packages/util/src/u8a/toString.js +++ b/packages/util/src/u8a/toString.js @@ -12,18 +12,12 @@ @example import { u8aToString } from '@polkadot/util'; - u8aToString(new Uint8Array([0x68, 0x65, 0x6c, 0x6c, 0x6f])); // hello + u8aToString(new Uint8Array([21,23,45,67])); // 21,23,45,67 */ module.exports = function u8aToString (value?: Uint8Array): string { if (!value || !value.length) { return ''; } - return value - .reduce((result, ch) => { - result.push(String.fromCharCode(ch)); - - return result; - }, []) - .join(''); + return value.toString(); }; diff --git a/packages/util/src/u8a/toString.spec.js b/packages/util/src/u8a/toString.spec.js index 5521bbb0f..aec197e85 100644 --- a/packages/util/src/u8a/toString.spec.js +++ b/packages/util/src/u8a/toString.spec.js @@ -20,8 +20,8 @@ describe('u8aToString', () => { it('decodes the buffer correctly', () => { expect( u8aToString( - new Uint8Array([0x68, 0x65, 0x6c, 0x6c, 0x6f]) + new Uint8Array([21, 23, 45, 67]) ) - ).toEqual('hello'); + ).toEqual('21,23,45,67'); }); });