From b375b6c2d533aba1bc8f4c2353db053c10bbca0a Mon Sep 17 00:00:00 2001 From: Jaco Greeff Date: Tue, 10 Nov 2020 16:07:53 +0100 Subject: [PATCH] Mark detectPackage as sideEffects (#764) --- packages/networks/package.json | 4 ---- packages/util-crypto/package.json | 4 ---- packages/util/package.json | 8 +++----- packages/x-fetch/package.json | 4 ---- packages/x-randomvalues/package.json | 4 ---- packages/x-textdecoder/package.json | 4 ---- packages/x-textencoder/package.json | 4 ---- packages/x-ws/package.json | 4 ---- 8 files changed, 3 insertions(+), 33 deletions(-) diff --git a/packages/networks/package.json b/packages/networks/package.json index 4c13eba36..d67e559a6 100644 --- a/packages/networks/package.json +++ b/packages/networks/package.json @@ -5,10 +5,6 @@ "main": "index.js", "module": "index.mjs", "sideEffects": false, - "publishConfig": { - "access": "public", - "registry": "https://registry.npmjs.org" - }, "repository": { "type": "git", "url": "git+https://github.com/polkadot-js/common.git" diff --git a/packages/util-crypto/package.json b/packages/util-crypto/package.json index d9f940d91..f5dcca961 100644 --- a/packages/util-crypto/package.json +++ b/packages/util-crypto/package.json @@ -14,10 +14,6 @@ ], "contributors": [], "license": "Apache-2.0", - "publishConfig": { - "access": "public", - "registry": "https://registry.npmjs.org" - }, "repository": { "type": "git", "url": "git+https://github.com/polkadot-js/common.git" diff --git a/packages/util/package.json b/packages/util/package.json index 04b619f09..4b7073a75 100644 --- a/packages/util/package.json +++ b/packages/util/package.json @@ -4,7 +4,9 @@ "description": "A collection of useful utilities for @polkadot", "main": "index.js", "module": "index.mjs", - "sideEffects": false, + "sideEffects": [ + "detectPackage.mjs" + ], "keywords": [ "Polkadot" ], @@ -14,10 +16,6 @@ ], "contributors": [], "license": "Apache-2.0", - "publishConfig": { - "access": "public", - "registry": "https://registry.npmjs.org" - }, "repository": { "type": "git", "url": "git+https://github.com/polkadot-js/common.git" diff --git a/packages/x-fetch/package.json b/packages/x-fetch/package.json index dc8f070a7..35a62052b 100644 --- a/packages/x-fetch/package.json +++ b/packages/x-fetch/package.json @@ -11,10 +11,6 @@ ], "contributors": [], "license": "Apache-2.0", - "publishConfig": { - "access": "public", - "registry": "https://registry.npmjs.org" - }, "repository": { "type": "git", "url": "git+https://github.com/polkadot-js/common.git" diff --git a/packages/x-randomvalues/package.json b/packages/x-randomvalues/package.json index 2e8c6bfae..af5522e1f 100644 --- a/packages/x-randomvalues/package.json +++ b/packages/x-randomvalues/package.json @@ -11,10 +11,6 @@ ], "contributors": [], "license": "Apache-2.0", - "publishConfig": { - "access": "public", - "registry": "https://registry.npmjs.org" - }, "repository": { "type": "git", "url": "git+https://github.com/polkadot-js/common.git" diff --git a/packages/x-textdecoder/package.json b/packages/x-textdecoder/package.json index 69c10c1f5..8324fc55c 100644 --- a/packages/x-textdecoder/package.json +++ b/packages/x-textdecoder/package.json @@ -11,10 +11,6 @@ ], "contributors": [], "license": "Apache-2.0", - "publishConfig": { - "access": "public", - "registry": "https://registry.npmjs.org" - }, "repository": { "type": "git", "url": "git+https://github.com/polkadot-js/common.git" diff --git a/packages/x-textencoder/package.json b/packages/x-textencoder/package.json index 549216f15..a1dbadfa7 100644 --- a/packages/x-textencoder/package.json +++ b/packages/x-textencoder/package.json @@ -11,10 +11,6 @@ ], "contributors": [], "license": "Apache-2.0", - "publishConfig": { - "access": "public", - "registry": "https://registry.npmjs.org" - }, "repository": { "type": "git", "url": "git+https://github.com/polkadot-js/common.git" diff --git a/packages/x-ws/package.json b/packages/x-ws/package.json index 92d5c5623..412bca753 100644 --- a/packages/x-ws/package.json +++ b/packages/x-ws/package.json @@ -11,10 +11,6 @@ ], "contributors": [], "license": "Apache-2.0", - "publishConfig": { - "access": "public", - "registry": "https://registry.npmjs.org" - }, "repository": { "type": "git", "url": "git+https://github.com/polkadot-js/common.git"