diff --git a/packages/util/src/compact/fromU8a.spec.ts b/packages/util/src/compact/fromU8a.spec.ts index 55975dde2..cbe8c3820 100644 --- a/packages/util/src/compact/fromU8a.spec.ts +++ b/packages/util/src/compact/fromU8a.spec.ts @@ -47,4 +47,12 @@ describe('compactFromU8a', (): void => { ) ).toEqual([7, new BN('5af3107a4000', 16)]); }); + + it('decodes an actual value', (): void => { + expect( + compactFromU8a( + hexToU8a('0x0284d717') + )[1].toString() + ).toEqual('100000000'); + }); }); diff --git a/packages/util/src/compact/toU8a.spec.ts b/packages/util/src/compact/toU8a.spec.ts index a8f885a51..abbfc333d 100644 --- a/packages/util/src/compact/toU8a.spec.ts +++ b/packages/util/src/compact/toU8a.spec.ts @@ -72,6 +72,13 @@ describe('encode', (): void => { ); }); + it('does not modify the original', (): void => { + const original = new BN(123456); + + expect(compactToU8a(original)).toEqual(new Uint8Array([2, 137, 7, 0])); + expect(original.toString()).toEqual('123456'); + }); + describe('from Rust', (): void => { // Copied from https://github.com/paritytech/parity-codec/blob/master/src/codec.rs const testCases = [ diff --git a/packages/util/src/compact/toU8a.ts b/packages/util/src/compact/toU8a.ts index 86ca57102..8b336577f 100644 --- a/packages/util/src/compact/toU8a.ts +++ b/packages/util/src/compact/toU8a.ts @@ -29,9 +29,9 @@ export function compactToU8a (_value: BN | BigInt | number): Uint8Array { if (value.lte(MAX_U8)) { return new Uint8Array([value.toNumber() << 2]); } else if (value.lte(MAX_U16)) { - return bnToU8a(value.ishln(2).iadd(BN_ONE), 16, true); + return bnToU8a(value.shln(2).iadd(BN_ONE), 16, true); } else if (value.lte(MAX_U32)) { - return bnToU8a(value.ishln(2).iadd(BN_TWO), 32, true); + return bnToU8a(value.shln(2).iadd(BN_TWO), 32, true); } const u8a = bnToU8a(value);