Adjust base library usage of for vs reduce/map (#1151)

* Adjust base library usage of `for` vs `reduce/map`

* Additional

* Adjust

packages/util-crypto/src/key/extractPath.ts

@@ -23,9 +23,9 @@ export function keyExtractPath (derivePath: string): ExtractResult {
   if (parts) {
     constructed = parts.join('');
 
-    parts.forEach((value: string): void => {
-      path.push(DeriveJunction.from(value.substr(1)));
-    });
+    for (const p of parts) {
+      path.push(DeriveJunction.from(p.substr(1)));
+    }
   }
 
   assert(constructed === derivePath, () => `Re-constructed path "${constructed}" does not match input`);

packages/util-crypto/src/key/fromPath.ts

@@ -18,8 +18,11 @@ const generators = {
 
 export function keyFromPath (pair: Keypair, path: DeriveJunction[], type: KeypairType): Keypair {
   const keyHdkd = generators[type];
+  let result = pair;
 
-  return path.reduce((pair, junction): Keypair => {
-    return keyHdkd(pair, junction);
-  }, pair);
+  for (const junction of path) {
+    result = keyHdkd(result, junction);
+  }
+
+  return result;
 }