Adjust base library usage of for vs reduce/map (#1151)
* Adjust base library usage of `for` vs `reduce/map` * Additional * Adjust
This commit is contained in:
@@ -9,4 +9,10 @@ describe('bnMax', (): void => {
|
||||
bnMax(new BN(1), new BN(2), new BN(3))
|
||||
).toEqual(new BN(3));
|
||||
});
|
||||
|
||||
it('finds BN maximum', (): void => {
|
||||
expect(
|
||||
bnMax(new BN(2), new BN(3), new BN(1))
|
||||
).toEqual(new BN(3));
|
||||
});
|
||||
});
|
||||
|
||||
@@ -6,7 +6,7 @@ import { BN, bnMin } from '.';
|
||||
describe('bnMin', (): void => {
|
||||
it('finds BN minimum', (): void => {
|
||||
expect(
|
||||
bnMin(new BN(1), new BN(2), new BN(3))
|
||||
bnMin(new BN(2), new BN(1), new BN(3))
|
||||
).toEqual(new BN(1));
|
||||
});
|
||||
});
|
||||
|
||||
@@ -7,5 +7,11 @@ import { BN } from './bn';
|
||||
export function checkMaxMin (type: 'max' | 'min', items: BN[]): BN {
|
||||
assert(items.length >= 1, 'Must provide one or more BN arguments');
|
||||
|
||||
return items.reduce<BN>((a, v) => BN[type](a, v), items[0]);
|
||||
let result = items[0];
|
||||
|
||||
for (const v of items) {
|
||||
result = BN[type](result, v);
|
||||
}
|
||||
|
||||
return result;
|
||||
}
|
||||
|
||||
Reference in New Issue
Block a user