Revert all recent $ renames (#5429)

* Revert "[CI Skip] bump/beta 9.11.4-6-x"

This reverts commit 7ee4f7aaf8.

* Revert "Rename Code .registry to .$registry (#5428)"

This reverts commit dd6826fadd.

* Revert "[CI Skip] bump/beta 9.11.4-5-x"

This reverts commit abc68bf2e2.

* Revert "Convert encodedLength to $encodedLength (#5426)"

This reverts commit ccab89304b.

* Revert "[CI Skip] bump/beta 9.11.4-4-x"

This reverts commit 044465eee4.

* Revert "Rename inspect() to inspectU8a() (#5425)"

This reverts commit 42af205546.

* Revert "[CI Skip] bump/beta 9.11.4-3-x"

This reverts commit 545ad50097.

* Revert "Move .isEmpty to $isEmpty (#5424)"

This reverts commit 6f19084a4d.

* Revert "[CI Skip] bump/beta 9.11.4-2-x"

This reverts commit 4688291ecf.

* Revert "Warn on deprecated getter usage (#5423)"

This reverts commit da1cf9d64e.

* Revert "[CI Skip] bump/beta 9.11.4-1-x"

This reverts commit 96a3ef51f0.

* Revert "Revert "[CI Skip] bump/beta 9.11.4-1-x""

This reverts commit 2eca0730a630d587878f12c141e21ea631dcdd19.

* Revert "Revert "[CI Skip] bump/beta 9.11.4-2-x""

This reverts commit 66284b40692071aa03a1064997c9402fc0b0987c.

* Revert "Revert "[CI Skip] bump/beta 9.11.4-3-x""

This reverts commit 9b820eaefccdb7b51d893000e5480d11e5195e22.

* Revert "Revert "[CI Skip] bump/beta 9.11.4-4-x""

This reverts commit cb5149adf98a5eefd8da61b8793707f85deb7c09.

* Revert "Revert "[CI Skip] bump/beta 9.11.4-5-x""

This reverts commit 489a64439860fefba163695ec36b319dcb1eeddc.

* Revert "Revert "[CI Skip] bump/beta 9.11.4-6-x""

This reverts commit 34a0fd4e2784a1b40ea8e06534d1f39328250e7a.

* Adjust linebreaks

* Adjust isStorageFallback naming

* Fix build

packages/typegen/src/generate/consts.ts

@@ -33,7 +33,7 @@ function generateForMeta (meta: Metadata, dest: string, extraTypes: ExtraTypes,
     const allDefs = Object.entries(allTypes).reduce((defs, [path, obj]) => {
       return Object.entries(obj).reduce((defs, [key, value]) => ({ ...defs, [`${path}/${key}`]: value }), defs);
     }, {});
-    const { $registry: registry, lookup, pallets } = meta.asLatest;
+    const { lookup, pallets, registry } = meta.asLatest;
 
     const modules = pallets
       .filter(({ constants }) => constants.length > 0)

packages/typegen/src/generate/events.ts

@@ -77,7 +77,7 @@ function generateForMeta (meta: Metadata, dest: string, extraTypes: ExtraTypes,
     const allDefs = Object.entries(allTypes).reduce((defs, [path, obj]) => {
       return Object.entries(obj).reduce((defs, [key, value]) => ({ ...defs, [`${path}/${key}`]: value }), defs);
     }, {});
-    const { $registry: registry, lookup, pallets } = meta.asLatest;
+    const { lookup, pallets, registry } = meta.asLatest;
     const modules = pallets
       .filter(({ events }) => events.isSome)
       .map(({ events, name }) => ({

packages/typegen/src/generate/lookup.ts

@@ -240,7 +240,7 @@ function generateRegistry (registry: Registry, filtered: [PortableType, TypeDef]
 
 function generateLookup (destDir: string, entries: [string, HexString][]): void {
   entries.reduce<string[]>((exclude, [subPath, staticMeta]): string[] => {
-    const { $registry: registry, lookup } = initMeta(staticMeta).metadata.asLatest;
+    const { lookup, registry } = initMeta(staticMeta).metadata.asLatest;
     const filtered = getFilteredTypes(lookup, exclude);
 
     generateLookupDefs(registry, filtered, destDir, subPath);

packages/typegen/src/generate/runtime.ts

@@ -83,7 +83,7 @@ export function generateCallTypes (meta: Metadata, dest: string, extraTypes: Ext
 
     // find the system.Version in metadata
     let apis: Apis | null = null;
-    const { $registry: registry, pallets } = meta.asLatest;
+    const { pallets, registry } = meta.asLatest;
     const sysp = pallets.find(({ name }) => name.eq('System'));
 
     if (sysp) {

packages/typegen/src/metadataMd.ts

@@ -232,7 +232,7 @@ function addConstants ({ lookup, pallets }: MetadataLatest): string {
     description: DESC_CONSTANTS,
     sections: pallets
       .sort(sortByName)
-      .filter(({ constants }) => !constants.$isEmpty)
+      .filter(({ constants }) => !constants.isEmpty)
       .map(({ constants, name }) => {
         const sectionName = stringLowerFirst(name);
 
@@ -256,7 +256,7 @@ function addConstants ({ lookup, pallets }: MetadataLatest): string {
 }
 
 /** @internal */
-function addStorage ({ $registry: registry, lookup, pallets }: MetadataLatest): string {
+function addStorage ({ lookup, pallets, registry }: MetadataLatest): string {
   const { substrate } = getSubstrateStorage(registry);
   const moduleSections = pallets
     .sort(sortByName)

packages/typegen/src/util/derived.ts

@@ -67,10 +67,10 @@ export function getSimilarTypes (registry: Registry, definitions: Record<string,
       }
     }
   } else if (isChildClass(Enum, Clazz)) {
-    const { $isBasic, defKeys } = new (Clazz as Constructor)(registry) as Enum;
+    const { defKeys, isBasic } = new (Clazz as Constructor)(registry) as Enum;
     const keys = defKeys.filter((v) => !v.startsWith('__Unused'));
 
-    if ($isBasic) {
+    if (isBasic) {
       possibleTypes.push(arrayToStrType(keys), 'number');
     } else {
       // TODO We don't really want any here, these should be expanded