From dd1fab536698c6dc616fa21be335c1ecd87092c2 Mon Sep 17 00:00:00 2001 From: Jaco Greeff Date: Thu, 16 Apr 2020 09:09:17 +0200 Subject: [PATCH] Adjust set bitfileds to LE (#2178) --- packages/types/src/codec/Set.ts | 4 ++-- packages/types/src/interfaces/identity/IdentityFields.spec.ts | 4 ++-- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/packages/types/src/codec/Set.ts b/packages/types/src/codec/Set.ts index c1caac0de4..35b6fed5b0 100644 --- a/packages/types/src/codec/Set.ts +++ b/packages/types/src/codec/Set.ts @@ -60,7 +60,7 @@ function decodeSet (setValues: SetValues, value: string[] | Set | Uint8A } else if (isU8a(value)) { return value.length === 0 ? [] - : decodeSetNumber(setValues, u8aToBn(value.subarray(0, byteLength), { isLe: false })); + : decodeSetNumber(setValues, u8aToBn(value.subarray(0, byteLength), { isLe: true })); } else if (value instanceof Set || Array.isArray(value)) { const input = Array.isArray(value) ? value @@ -230,7 +230,7 @@ export default class CodecSet extends Set implements Codec { public toU8a (isBare?: boolean): Uint8Array { return bnToU8a(this.valueEncoded, { bitLength: this.#byteLength * 8, - isLe: false + isLe: true }); } } diff --git a/packages/types/src/interfaces/identity/IdentityFields.spec.ts b/packages/types/src/interfaces/identity/IdentityFields.spec.ts index 4a21d34810..5a6098a1b1 100644 --- a/packages/types/src/interfaces/identity/IdentityFields.spec.ts +++ b/packages/types/src/interfaces/identity/IdentityFields.spec.ts @@ -22,12 +22,12 @@ describe('IdentityFields', (): void => { it('encodes to a valid u8a value', (): void => { expect( registry.createType('IdentityFields', ['Display', 'Legal']).toU8a() - ).toEqual(new Uint8Array([0, 0, 0, 0, 0, 0, 0, 3])); + ).toEqual(new Uint8Array([3, 0, 0, 0, 0, 0, 0, 0])); }); it('decodes from a u8a', (): void => { expect( - registry.createType('IdentityFields', new Uint8Array([0, 0, 0, 0, 0, 0, 0, 1 + 2 + 64])).toHuman() + registry.createType('IdentityFields', new Uint8Array([1 + 2 + 64, 0, 0, 0, 0, 0, 0, 0])).toHuman() ).toEqual(['Display', 'Legal', 'Image']); }); });