no warm for unknown signed extensions (#5601)

This commit is contained in:
Xiliang Chen
2023-04-20 08:14:55 +03:00
committed by GitHub
parent 3d2307f12a
commit b849d50995
3 changed files with 11 additions and 8 deletions
+1 -1
View File
@@ -97,7 +97,7 @@ export abstract class Init<ApiType extends ApiTypes> extends Decorate<ApiType> {
registry.knownTypes.typesAlias = getSpecAlias(registry, chain, version.specName);
}
registry.setMetadata(metadata, undefined, objectSpread<ExtDef>({}, getSpecExtensions(registry, chain, version.specName), this._options.signedExtensions));
registry.setMetadata(metadata, undefined, objectSpread<ExtDef>({}, getSpecExtensions(registry, chain, version.specName), this._options.signedExtensions), this._options.noInitWarn);
}
/**
+1 -1
View File
@@ -77,5 +77,5 @@ export interface Registry {
register (type: CodecClass | RegistryTypes): void;
register (name: string, type: CodecClass): void;
register (arg1: string | CodecClass | RegistryTypes, arg2?: CodecClass): void;
setMetadata (metadata: unknown, signedExtensions?: string[], userExtensions?: unknown): void;
setMetadata (metadata: unknown, signedExtensions?: string[], userExtensions?: unknown, noInitWarn?: boolean): void;
}
+9 -6
View File
@@ -566,7 +566,7 @@ export class TypeRegistry implements Registry {
};
// sets the metadata
public setMetadata (metadata: Metadata, signedExtensions?: string[], userExtensions?: ExtDef): void {
public setMetadata (metadata: Metadata, signedExtensions?: string[], userExtensions?: ExtDef, noInitWarn?: boolean): void {
this.#metadata = metadata.asLatest;
this.#metadataVersion = metadata.version;
this.#firstCallIndex = null;
@@ -602,7 +602,8 @@ export class TypeRegistry implements Registry {
? this.#metadata.extrinsic.signedExtensions.map(({ identifier }) => identifier.toString())
: fallbackExtensions
),
userExtensions
userExtensions,
noInitWarn
);
// setup the chain properties with format overrides
@@ -612,14 +613,16 @@ export class TypeRegistry implements Registry {
}
// sets the available signed extensions
setSignedExtensions (signedExtensions: string[] = fallbackExtensions, userExtensions?: ExtDef): void {
setSignedExtensions (signedExtensions: string[] = fallbackExtensions, userExtensions?: ExtDef, noInitWarn?: boolean): void {
this.#signedExtensions = signedExtensions;
this.#userExtensions = userExtensions;
const unknown = findUnknownExtensions(this.#signedExtensions, this.#userExtensions);
if (!noInitWarn) {
const unknown = findUnknownExtensions(this.#signedExtensions, this.#userExtensions);
if (unknown.length) {
l.warn(`Unknown signed extensions ${unknown.join(', ')} found, treating them as no-effect`);
if (unknown.length) {
l.warn(`Unknown signed extensions ${unknown.join(', ')} found, treating them as no-effect`);
}
}
}
}