Remove outdated blockNumber refs. in API docs (#1382)

* Remove outdated blockNumber refs

* ExtendedHeader

* Update subscribeNewHeads.ts

packages/api-derive/src/chain/subscribeNewHeads.ts

@@ -21,8 +21,8 @@ export type HeaderAndValidators = [Header, AccountId[]];
  * <BR>
  *
  * ```javascript
- * api.derive.chain.subscribeNewHeads(({ author, blockNumber }) => {
- *   console.log(`block #${blockNumber} was authored by ${author}`);
+ * api.derive.chain.subscribeNewHeads((header) => {
+ *   console.log(`block #${header.number} was authored by ${header.author}`);
  * });
  * ```
  */

packages/api/README.md

@@ -46,7 +46,7 @@ const api = await ApiPromise.create();
 
 // make a call to retrieve the current network head
 api.rpc.chain.subscribeNewHeads((header) => {
-  console.log(`Chain is at #${header.blockNumber}`);
+  console.log(`Chain is at #${header.number}`);
 });
 ```
 
@@ -60,7 +60,7 @@ const api = await ApiRx.create().toPromise();
 
 // make a call to retrieve the current network head
 api.rpc.chain.subscribeNewHeads().subscribe((header) => {
-  console.log(`Chain is at #${header.blockNumber}`);
+  console.log(`Chain is at #${header.number}`);
 });
 ```
 

packages/rpc-core/README.md

@@ -43,7 +43,7 @@ rpc.chain
   )
   .subscribe(
     (header) => {
-      console.log(`best #${header.blockNumber.toString()}`);
+      console.log(`best #${header.number.toString()}`);
       console.log(`parentHash: ${header.parentHash.toString()}`);
       console.log(`stateRoot: ${header.stateRoot.toString()}`);
       console.log(`extrinsicsRoot: ${header.extrinsicsRoot.toString()}`);
@@ -63,7 +63,7 @@ rpc
   .subscribeNewHeads()
   .subscribe(
     (header) => {
-      console.log(`best #${header.blockNumber}`);
+      console.log(`best #${header.number}`);
     },
     (error) => {
       console.error('error subscribing:', error);