From a8bfa90b87efe874c234a7013b5fdefd81030cf2 Mon Sep 17 00:00:00 2001 From: Jaco Greeff Date: Thu, 24 Oct 2019 16:20:40 +0200 Subject: [PATCH] Update signing comment (#1509) * Update signing comment * Extrinsic V4 CHANGELOG --- CHANGELOG.md | 1 + packages/types/src/primitive/Extrinsic/v4/ExtrinsicPayload.ts | 2 +- 2 files changed, 2 insertions(+), 1 deletion(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index 2e846c8287..a2589a4781 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -1,5 +1,6 @@ # 0.95.0-beta.x +- Support Extrinsic V4 with additional signature indicator (Latest Kusama) - Adjust subscription update checks to avoid duplicated data updates - Support Metadata V8 (exposes per-module `decl_error` definitions) - Support next generation contracts ABI (with additional type definitions) diff --git a/packages/types/src/primitive/Extrinsic/v4/ExtrinsicPayload.ts b/packages/types/src/primitive/Extrinsic/v4/ExtrinsicPayload.ts index 2d968d29e6..3408f8df43 100644 --- a/packages/types/src/primitive/Extrinsic/v4/ExtrinsicPayload.ts +++ b/packages/types/src/primitive/Extrinsic/v4/ExtrinsicPayload.ts @@ -79,7 +79,7 @@ export default class ExtrinsicPayloadV4 extends Struct { // NOTE The `toU8a(true)` argument is absolutely critical - we don't want the method (Bytes) // to have the length prefix included. This means that the data-as-signed is un-decodable, // but is also doesn't need the extra information, only the pure data (and is not decoded) - // ... The same applies to V1 & V1, if we have a V4, carry move this comment to latest + // ... The same applies to V1..V3, if we have a V5, carry move this comment to latest return sign(signerPair, this.toU8a(true), { withType: true }); } }