From a208cc9bb549854189414b013b14fffc62e29e65 Mon Sep 17 00:00:00 2001 From: Jaco Date: Mon, 30 May 2022 07:36:28 +0200 Subject: [PATCH] LRU Sizing (#4872) --- CHANGELOG.md | 7 +++++++ packages/rpc-provider/src/lru.ts | 4 ++-- packages/rpc-provider/src/ws/index.ts | 2 +- 3 files changed, 10 insertions(+), 3 deletions(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index c73393eebf..5704f6fdb0 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -1,5 +1,12 @@ # CHANGELOG +## master + +Changes: + +- Lower default historic LRU cache size (128 entries, 192MB est) + + ## 8.6.1 May 29, 2022 Changes: diff --git a/packages/rpc-provider/src/lru.ts b/packages/rpc-provider/src/lru.ts index 57791c206e..15fcdeb555 100644 --- a/packages/rpc-provider/src/lru.ts +++ b/packages/rpc-provider/src/lru.ts @@ -1,10 +1,10 @@ // Copyright 2017-2022 @polkadot/rpc-provider authors & contributors // SPDX-License-Identifier: Apache-2.0 -// Assuming all 1.5MB responses, we apply a default allowing for 576MB +// Assuming all 1.5MB responses, we apply a default allowing for 192MB // cache space (depending on the historic queries this would vary, metadata // for Kusama/Polkadot/Substrate falls between 600-750K, 2x for estimate) -const DEFAULT_CAPACITY = 384; +const DEFAULT_CAPACITY = 128; class LRUNode { public readonly key: string; diff --git a/packages/rpc-provider/src/ws/index.ts b/packages/rpc-provider/src/ws/index.ts index 5a5affe617..abef9bf001 100644 --- a/packages/rpc-provider/src/ws/index.ts +++ b/packages/rpc-provider/src/ws/index.ts @@ -300,7 +300,7 @@ export class WsProvider implements ProviderInterface { const [id, body] = this.#coder.encodeJson(method, params); let resultPromise: Promise | null = isCacheable - ? this.#callCache.get(body) as Promise + ? this.#callCache.get(body) : null; if (!resultPromise) {