quantus/api
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Swap isPedantic to warn (with fallback) (#1221)

Browse Source 
* Swap isPedantic to warn (with fallback)

* Remove extra instanceof

* One less check (toU8a implies codec)

* Comment typo

* Handle fallback grecefully
This commit is contained in:
Jaco Greeff
2019-07-28 10:45:26 +02:00
committed by GitHub
parent 38e8ad659a
commit a06db4cfb9
1 changed files with 14 additions and 7 deletions
Download Patch File Download Diff File Expand all files Collapse all files
packages/types/src/codec/createType.ts
+14 -7
View File
@@ -306,26 +306,33 @@ export function getTypeClass<T extends Codec = Codec> (value: TypeDef, Fallback?
throw new Error(`Unable to determine type from ${JSON.stringify(value)}`);
}
// Initializes a type with a value. This also checks for fallbacks and in the cases
// where isPedantic is specified (storage decoding), also check the format/structure
function initType<T extends Codec = Codec, K extends string = string> (Type: Constructor<FromReg<T, K>>, params: any[] = [], isPedantic?: boolean): FromReg<T, K> {
try {
const created = new Type(...params);
const [value] = params;
// in pedantic mode, actually check that the encoding matches that supplied - this
// is much slower, but ensures that we have a 100% grasp on the actual provided value
if (isPedantic && value && value.toHex && value.toU8a && !value.isEmpty) {
// With isPedantic, actually check that the encoding matches that supplied. This
// is much slower, but verifies that we have the correct types defined
if (isPedantic && value && value.toU8a && !value.isEmpty) {
const inHex = value.toHex(true);
const crHex = created.toHex(true);
const hasMatch = inHex === crHex || (
(value instanceof ClassOf('StorageData')) && // input is from storage
(created instanceof Uint8Array) // we are a variable-length structure
created instanceof Uint8Array
// strip the input length
? (value.toU8a(true).toString() === created.toU8a().toString())
// compare raw
// compare raw. without additions
: (value.toU8a(true).toString() === created.toU8a(true).toString())
);
assert(hasMatch, `Input doesn't match output, received ${inHex}, created ${crHex}`);
if (!hasMatch) {
if (Type.Fallback) {
return initType(Type.Fallback as Constructor<FromReg<T, K>>, params, isPedantic);
}
console.warn(`${created.toRawType()}:: Input doesn't match output, received ${inHex}, created ${crHex}`);
}
}
return created;