eslint rules (#1099)

* Off to the races - 3760 problems (1794 errors, 1966 warnings)

* Convert Array<T> -> T[] (not all correct, eg. extends)

* () => { -> (): void  => {

* get is/as -> public get is/as

* public for getters, constructors & base Codec

* Some cleanups from previous overzealous search & replace

* Under 2k, 1874 problems (649 errors, 1225 warnings)

* ^^^ check that commit for details ;)

* Minor.

* rm config header

* Minor cleanups

* Default to tslint, eslint as option

* Trigger

* Update jsonrpc

* 1494 problems (433 errors, 1061 warnings)

* 1103 problems (135 errors, 968 warnings)

* 899 problems (9 errors, 890 warnings)

* 483 problems (9 errors, 474 warnings) (ignore any... for now)

* 366 problems (9 errors, 357 warnings)

* 336 problems (9 errors, 327 warnings)

* 148 problems (9 errors, 139 warnings)

* 31 problems (8 errors, 23 warnings)

* 0, 0

packages/rpc-core/src/methodSend.spec.ts

@@ -4,12 +4,12 @@
 
 import Rpc from '.';
 
-describe('methodSend', () => {
+describe('methodSend', (): void => {
   let rpc: Rpc;
   let methods: any;
   let provider: any;
 
-  beforeEach(() => {
+  beforeEach((): void => {
     methods = {
       blah: {
         method: 'blah',
@@ -28,7 +28,7 @@ describe('methodSend', () => {
     };
 
     provider = {
-      send: jest.fn((method, params) => {
+      send: jest.fn((method, params): Promise<any> => {
         return Promise.resolve(params[0]);
       })
     };
@@ -36,37 +36,37 @@ describe('methodSend', () => {
     rpc = new Rpc(provider);
   });
 
-  it('wraps errors with the call signature', (done) => {
+  it('wraps errors with the call signature', (done): void => {
     // @ts-ignore private method
     const method = rpc.createMethodSend(methods.blah);
 
     method().subscribe(
-      () => { /* noop */ },
-      (error) => {
+      (): void => { /* noop */ },
+      (error): void => {
         expect(error.message).toMatch(/blah \(foo: Bytes\): Bytes/);
         done();
       }
     );
   });
 
-  it('checks for mismatched parameters', (done) => {
+  it('checks for mismatched parameters', (done): void => {
     // @ts-ignore private method
     const method = rpc.createMethodSend(methods.bleh);
 
     method(1).subscribe(
-      () => { /* noop */ },
-      (error) => {
+      (): void => { /* noop */ },
+      (error): void => {
         expect(error.message).toMatch(/parameters, 1 found instead/);
         done();
       });
   });
 
-  it('calls the provider with the correct parameters', (done) => {
+  it('calls the provider with the correct parameters', (done): void => {
     // @ts-ignore private method
     const method = rpc.createMethodSend(methods.blah);
 
     // Args are length-prefixed, because it's a Bytes
-    method(new Uint8Array([2 << 2, 0x12, 0x34])).subscribe(() => {
+    method(new Uint8Array([2 << 2, 0x12, 0x34])).subscribe((): void => {
       expect(provider.send).toHaveBeenCalledWith('test_blah', ['0x1234']);
       done();
     });