eslint rules (#1099)

* Off to the races - 3760 problems (1794 errors, 1966 warnings)

* Convert Array<T> -> T[] (not all correct, eg. extends)

* () => { -> (): void  => {

* get is/as -> public get is/as

* public for getters, constructors & base Codec

* Some cleanups from previous overzealous search & replace

* Under 2k, 1874 problems (649 errors, 1225 warnings)

* ^^^ check that commit for details ;)

* Minor.

* rm config header

* Minor cleanups

* Default to tslint, eslint as option

* Trigger

* Update jsonrpc

* 1494 problems (433 errors, 1061 warnings)

* 1103 problems (135 errors, 968 warnings)

* 899 problems (9 errors, 890 warnings)

* 483 problems (9 errors, 474 warnings) (ignore any... for now)

* 366 problems (9 errors, 357 warnings)

* 336 problems (9 errors, 327 warnings)

* 148 problems (9 errors, 139 warnings)

* 31 problems (8 errors, 23 warnings)

* 0, 0

packages/api-metadata/src/consts/fromMetadata/fromMetadata.spec.ts

@@ -11,8 +11,8 @@ import fromMetadata from '../fromMetadata';
 const metadata = new Metadata(json);
 const consts = fromMetadata(metadata);
 
-describe('fromMetadata', () => {
-  it('should return constants with the correct type and value', () => {
+describe('fromMetadata', (): void => {
+  it('should return constants with the correct type and value', (): void => {
     expect(consts.democracy.cooloffPeriod).toBeInstanceOf(BlockNumber);
     expect(consts.democracy.cooloffPeriod.eq(432000)).toBeTruthy();
   });