eslint rules (#1099)

* Off to the races - 3760 problems (1794 errors, 1966 warnings)

* Convert Array<T> -> T[] (not all correct, eg. extends)

* () => { -> (): void  => {

* get is/as -> public get is/as

* public for getters, constructors & base Codec

* Some cleanups from previous overzealous search & replace

* Under 2k, 1874 problems (649 errors, 1225 warnings)

* ^^^ check that commit for details ;)

* Minor.

* rm config header

* Minor cleanups

* Default to tslint, eslint as option

* Trigger

* Update jsonrpc

* 1494 problems (433 errors, 1061 warnings)

* 1103 problems (135 errors, 968 warnings)

* 899 problems (9 errors, 890 warnings)

* 483 problems (9 errors, 474 warnings) (ignore any... for now)

* 366 problems (9 errors, 357 warnings)

* 336 problems (9 errors, 327 warnings)

* 148 problems (9 errors, 139 warnings)

* 31 problems (8 errors, 23 warnings)

* 0, 0

packages/api-derive/src/balances/all.ts

@@ -5,7 +5,7 @@
 import BN from 'bn.js';
 import { combineLatest, of, Observable } from 'rxjs';
 import { map, switchMap } from 'rxjs/operators';
-import { ApiInterface$Rx } from '@polkadot/api/types';
+import { ApiInterfaceRx } from '@polkadot/api/types';
 import { AccountId, AccountIndex, Address, Balance, BalanceLock, BlockNumber, Index, Option, VestingSchedule } from '@polkadot/types';
 import { bnMax } from '@polkadot/util';
 
@@ -14,7 +14,7 @@ import { bestNumber } from '../chain/bestNumber';
 import { DerivedBalances } from '../types';
 import { drr } from '../util/drr';
 
-type Result = [AccountId | undefined, BlockNumber | undefined, [Balance?, Balance?, Array<BalanceLock>?, Option<VestingSchedule>?, Index?]];
+type Result = [AccountId | undefined, BlockNumber | undefined, [Balance?, Balance?, BalanceLock[]?, Option<VestingSchedule>?, Index?]];
 
 const EMPTY_ACCOUNT = new AccountId();
 const ZERO = new Balance(0);
@@ -24,10 +24,10 @@ function calcBalances ([accountId = EMPTY_ACCOUNT, bestNumber = ZERO, [freeBalan
 
   if (Array.isArray(locks)) {
     // only get the locks that are valid until passed the current block
-    const totals = locks.filter((value) => bestNumber && value.until.gt(bestNumber));
+    const totals = locks.filter((value): boolean => bestNumber && value.until.gt(bestNumber));
     // get the maximum of the locks according to https://github.com/paritytech/substrate/blob/master/srml/balances/src/lib.rs#L699
     lockedBalance = totals[0]
-      ? bnMax(...totals.map(({ amount }) => amount)) as Balance
+      ? bnMax(...totals.map(({ amount }): Balance => amount)) as Balance
       : ZERO;
   }
 
@@ -54,7 +54,7 @@ function calcBalances ([accountId = EMPTY_ACCOUNT, bestNumber = ZERO, [freeBalan
     reservedBalance,
     vestedBalance,
     votingBalance: freeBalance.add(reservedBalance)
-  } as DerivedBalances;
+  } as unknown as DerivedBalances;
 }
 
 /**
@@ -73,10 +73,10 @@ function calcBalances ([accountId = EMPTY_ACCOUNT, bestNumber = ZERO, [freeBalan
  * });
  * ```
  */
-export function all (api: ApiInterface$Rx) {
+export function all (api: ApiInterfaceRx): (address: AccountIndex | AccountId | Address | string) => Observable<DerivedBalances> {
   return (address: AccountIndex | AccountId | Address | string): Observable<DerivedBalances> => {
     return idAndIndex(api)(address).pipe(
-      switchMap(([accountId]) =>
+      switchMap(([accountId]): Observable<Result> =>
         (accountId
           ? combineLatest([
             of(accountId),

packages/api-derive/src/balances/fees.ts

@@ -2,7 +2,7 @@
 // This software may be modified and distributed under the terms
 // of the Apache-2.0 license. See the LICENSE file for details.
 
-import { ApiInterface$Rx } from '@polkadot/api/types';
+import { ApiInterfaceRx } from '@polkadot/api/types';
 import { DerivedFees } from '../types';
 
 import BN from 'bn.js';
@@ -24,7 +24,7 @@ import { drr } from '../util/drr';
  * });
  * ```
  */
-export function fees (api: ApiInterface$Rx) {
+export function fees (api: ApiInterfaceRx): () => Observable<DerivedFees> {
   return (): Observable<DerivedFees> => {
     return (
       api.consts.balances
@@ -45,13 +45,14 @@ export function fees (api: ApiInterface$Rx) {
           api.query.balances.transactionByteFee,
           api.query.balances.transferFee
         ]) as any as Observable<[BN, BN, BN, BN, BN]>
-      ).pipe(map(([creationFee, existentialDeposit, transactionBaseFee, transactionByteFee, transferFee]) => ({
+    ).pipe(
+      map(([creationFee, existentialDeposit, transactionBaseFee, transactionByteFee, transferFee]): DerivedFees => ({
         creationFee,
         existentialDeposit,
         transactionBaseFee,
         transactionByteFee,
         transferFee
-      } as DerivedFees)),
+      } as unknown as DerivedFees)),
       drr()
     );
   };

packages/api-derive/src/balances/votingBalances.ts

@@ -3,18 +3,18 @@
 // of the Apache-2.0 license. See the LICENSE file for details.
 
 import { combineLatest, Observable, of } from 'rxjs';
-import { ApiInterface$Rx } from '@polkadot/api/types';
+import { ApiInterfaceRx } from '@polkadot/api/types';
 import { AccountId, AccountIndex, Address } from '@polkadot/types';
 
 import { DerivedBalances } from '../types';
 import { drr } from '../util/drr';
 import { all } from './all';
 
-export function votingBalances (api: ApiInterface$Rx) {
-  return (addresses?: Array<AccountId | AccountIndex | Address | string>): Observable<Array<DerivedBalances>> => {
+export function votingBalances (api: ApiInterfaceRx): (addresses?: (AccountId | AccountIndex | Address | string)[]) => Observable<DerivedBalances[]> {
+  return (addresses?: (AccountId | AccountIndex | Address | string)[]): Observable<DerivedBalances[]> => {
     return (
       !addresses || !addresses.length
-        ? of([] as Array<DerivedBalances>)
+        ? of([] as DerivedBalances[])
         : combineLatest(addresses.map(all(api)))
     ).pipe(
       drr()

packages/api-derive/src/balances/votingBalancesNominatorsFor.ts

@@ -4,7 +4,7 @@
 
 import { Observable, of } from 'rxjs';
 import { switchMap } from 'rxjs/operators';
-import { ApiInterface$Rx } from '@polkadot/api/types';
+import { ApiInterfaceRx } from '@polkadot/api/types';
 import { AccountId, AccountIndex, Address, Vector } from '@polkadot/types';
 
 import { idAndIndex } from '../accounts/idAndIndex';
@@ -12,13 +12,13 @@ import { DerivedBalances } from '../types';
 import { drr } from '../util/drr';
 import { votingBalances } from './votingBalances';
 
-export function votingBalancesNominatorsFor (api: ApiInterface$Rx) {
-  return (address: AccountId | AccountIndex | Address | string): Observable<Array<DerivedBalances>> => {
+export function votingBalancesNominatorsFor (api: ApiInterfaceRx): (address: AccountId | AccountIndex | Address | string) => Observable<DerivedBalances[]> {
+  return (address: AccountId | AccountIndex | Address | string): Observable<DerivedBalances[]> => {
     return idAndIndex(api)(address).pipe(
-      switchMap(([accountId]) =>
+      switchMap(([accountId]): Observable<AccountId[]> =>
         accountId
           ? (api.query.staking.nominatorsFor<Vector<AccountId>>(accountId))
-          : of([] as Array<AccountId>)
+          : of([] as AccountId[])
       ),
       switchMap(votingBalances(api)),
       drr()