Move .isEmpty to $isEmpty (#5424)

* Move .isEmpty to $isEmpty

* Adjust usages

packages/api-contract/src/Abi/index.ts

@@ -75,19 +75,19 @@ function parseJson (json: Record<string, unknown>, chainProperties?: ChainProper
 }
 
 export class Abi {
-  public readonly events: AbiEvent[];
+  readonly events: AbiEvent[];
 
-  public readonly constructors: AbiConstructor[];
+  readonly constructors: AbiConstructor[];
 
-  public readonly info: ContractProjectInfo;
+  readonly info: ContractProjectInfo;
 
-  public readonly json: Record<string, unknown>;
+  readonly json: Record<string, unknown>;
 
-  public readonly messages: AbiMessage[];
+  readonly messages: AbiMessage[];
 
-  public readonly metadata: ContractMetadataLatest;
+  readonly metadata: ContractMetadataLatest;
 
-  public readonly registry: Registry;
+  readonly registry: Registry;
 
   constructor (abiJson: Record<string, unknown> | string, chainProperties?: ChainProperties) {
     [this.json, this.registry, this.metadata, this.info] = parseJson(

packages/api-contract/src/base/Base.ts

@@ -11,9 +11,9 @@ import { isFunction } from '@polkadot/util';
 import { Abi } from '../Abi';
 
 export abstract class Base<ApiType extends ApiTypes> {
-  public readonly abi: Abi;
+  readonly abi: Abi;
 
-  public readonly api: ApiBase<ApiType>;
+  readonly api: ApiBase<ApiType>;
 
   protected readonly _decorateMethod: DecorateMethod<ApiType>;
 

packages/api-contract/src/base/Blueprint.ts

@@ -23,7 +23,7 @@ export interface BlueprintConstructor<ApiType extends ApiTypes> {
 }
 
 export class BlueprintSubmittableResult<ApiType extends ApiTypes> extends SubmittableResult {
-  public readonly contract?: Contract<ApiType>;
+  readonly contract?: Contract<ApiType>;
 
   constructor (result: ISubmittableResult, contract?: Contract<ApiType>) {
     super(result);
@@ -36,7 +36,7 @@ export class Blueprint<ApiType extends ApiTypes> extends Base<ApiType> {
   /**
    * @description The on-chain code hash for this blueprint
    */
-  public readonly codeHash: Hash;
+  readonly codeHash: Hash;
 
   readonly #tx: MapConstructorExec<ApiType> = {};
 

packages/api-contract/src/base/Code.ts

@@ -25,8 +25,8 @@ export interface CodeConstructor<ApiType extends ApiTypes> {
 }
 
 export class CodeSubmittableResult<ApiType extends ApiTypes> extends SubmittableResult {
-  public readonly blueprint?: Blueprint<ApiType>;
-  public readonly contract?: Contract<ApiType>;
+  readonly blueprint?: Blueprint<ApiType>;
+  readonly contract?: Contract<ApiType>;
 
   constructor (result: ISubmittableResult, blueprint?: Blueprint<ApiType>, contract?: Contract<ApiType>) {
     super(result);
@@ -37,7 +37,7 @@ export class CodeSubmittableResult<ApiType extends ApiTypes> extends Submittable
 }
 
 export class Code<ApiType extends ApiTypes> extends Base<ApiType> {
-  public readonly code: Uint8Array;
+  readonly code: Uint8Array;
 
   readonly #tx: MapConstructorExec<ApiType> = {};
 

packages/api-contract/src/base/Contract.ts

@@ -42,7 +42,7 @@ function createTx <ApiType extends ApiTypes> (meta: AbiMessage, fn: (options: Co
 }
 
 export class ContractSubmittableResult extends SubmittableResult {
-  public readonly contractEvents?: DecodedEvent[];
+  readonly contractEvents?: DecodedEvent[];
 
   constructor (result: ISubmittableResult, contractEvents?: DecodedEvent[]) {
     super(result);
@@ -55,7 +55,7 @@ export class Contract<ApiType extends ApiTypes> extends Base<ApiType> {
   /**
    * @description The on-chain address for this contract
    */
-  public readonly address: AccountId;
+  readonly address: AccountId;
 
   readonly #query: MapMessageQuery<ApiType> = {};
   readonly #tx: MapMessageTx<ApiType> = {};