Adjust class privates via #, where applicable (#1921)

* Adjust class priates via #, where applicable

* Remove stray log

* Cleanup rpc-provider

* Small adjustments

* No private access in tests

* Submittable privates

* Use derive for nonce derivation

* Tweak observers

* Alphabetical privates
This commit is contained in:
Jaco Greeff
2020-02-22 11:29:50 +01:00
committed by GitHub
parent ccf32a6289
commit 3bf4c3fac5
32 changed files with 406 additions and 514 deletions
+3 -3
View File
@@ -65,7 +65,7 @@ function createErrorMessage ({ method, params, type }: RpcMethod, error: Error):
* ```
*/
export default class Rpc implements RpcInterface {
private _storageCache = new Map<string, string | null>();
readonly #storageCache = new Map<string, string | null>();
public readonly mapping: Map<string, RpcMethod> = new Map();
@@ -396,7 +396,7 @@ export default class Rpc implements RpcInterface {
// - if a single result value, don't fill - it is not an update hole
// - fallback to an empty option in all cases
const value = isUndefined(found)
? (witCache && this._storageCache.get(hexKey)) || null
? (witCache && this.#storageCache.get(hexKey)) || null
: found[1];
const isEmpty = isNull(value);
const input = isEmpty || this.treatAsHex(key)
@@ -406,7 +406,7 @@ export default class Rpc implements RpcInterface {
// store the retrieved result - the only issue with this cache is that there is no
// clearing of it, so very long running processes (not just a couple of hours, longer)
// will increase memory beyond what is allowed.
this._storageCache.set(hexKey, value);
this.#storageCache.set(hexKey, value);
if (meta.modifier.isOptional) {
return new Option(