jif-oai fcc2a92743 fix: emit thread stop lifecycle on implicit shutdown (#22482) ...

## Why

The thread lifecycle contributor hooks from #22476 should observe every
session teardown. The explicit `Op::Shutdown` path already emitted
`on_thread_stop`, but when `submission_loop` exited because its
submission channel closed, it only tore down runtime services. That
meant extensions could miss the thread-stop lifecycle signal on implicit
runtime shutdown.

## What Changed

- Split shared runtime teardown into `shutdown_runtime_services(...)`.
- Split thread-stop lifecycle emission into
`emit_thread_stop_lifecycle(...)`.
- Reused those helpers from both explicit shutdown and the channel-close
shutdown path.
- Tracked whether `Op::Shutdown` was received so the explicit path does
not double-emit lifecycle events after it exits the loop.
- Added a regression test that closes the submission channel and asserts
`ThreadLifecycleContributor::on_thread_stop` runs once with the expected
thread/session stores.

## Testing

- `cargo test -p codex-core
submission_loop_channel_close_emits_thread_stop_lifecycle`

2026-05-13 14:19:57 +02:00

..

agent

core: box multi-agent handler futures (#22266)

2026-05-12 17:22:25 -07:00

apps

Split DeveloperInstructions into individual fragments. (#18813)

2026-04-21 10:22:36 -07:00

bin

Refactor config types into a separate crate (#16962)

2026-04-07 00:32:41 +00:00

config

add --dangerously-bypass-hook-trust CLI flag (#21768)

2026-05-13 07:13:57 +00:00

context

[codex] Filter legacy warning messages during compaction (#22243)

2026-05-11 19:51:51 -07:00

context_manager

chore(config) include_collaboration_mode_instructions (#22383)

2026-05-12 15:50:10 -07:00

guardian

feat: route guardian review model selection through providers (#22258)

2026-05-13 01:55:46 +00:00

plugins

[codex] Remove string-keyed MCP tool maps (#21454)

2026-05-07 10:16:10 -07:00

sandboxing

permissions: derive legacy exec policies at boundaries (#19737)

2026-04-26 22:11:49 -07:00

session

fix: emit thread stop lifecycle on implicit shutdown (#22482)

2026-05-13 14:19:57 +02:00

state

feat: add turn lifecycle contributors (#22480)

2026-05-13 13:47:27 +02:00

tasks

feat: add turn lifecycle contributors (#22480)

2026-05-13 13:47:27 +02:00

tools

Refactor extension tools onto shared ToolExecutor (#22369)

2026-05-13 12:12:06 +02:00

unified_exec

[codex] Tighten unified exec sandbox setup (#22207)

2026-05-12 08:41:00 -07:00

utils

Extract rollout into its own crate (#15548)

2026-03-24 18:10:53 -07:00

agents_md_tests.rs

Remove js_repl feature (#19410)

2026-04-24 17:49:29 -07:00

agents_md.rs

[codex] Move config loading into codex-config (#19487)

2026-04-26 15:10:53 -07:00

apply_patch_tests.rs

[codex] Migrate apply_patch to executor filesystem (#17027)

2026-04-07 21:20:22 +00:00

apply_patch.rs

Support multi-environment apply_patch selection (#21617)

2026-05-11 16:33:44 -07:00

arc_monitor_tests.rs

Surface multi-environment choices in environment context (#20646)

2026-05-01 22:11:06 +00:00

arc_monitor.rs

feat: add remote compaction v2 Responses client path (#20773)

2026-05-04 14:15:01 +02:00

attestation.rs

[codex] request desktop attestation from app (#20619)

2026-05-08 12:36:02 -07:00

client_common_tests.rs

Allow guardian bare allow output (#18797)

2026-04-21 15:37:12 -07:00

client_common.rs

[codex] Trace cancelled inference streams (#19839)

2026-04-27 21:58:29 +00:00

client_tests.rs

[codex] request desktop attestation from app (#20619)

2026-05-08 12:36:02 -07:00

client.rs

Remove CODEX_RS_SSE_FIXTURE test hook (#22413)

2026-05-13 03:08:01 +00:00

codex_delegate_tests.rs

[codex-analytics] plumb protocol-native review timing (#21434)

2026-05-07 20:31:41 -07:00

codex_delegate.rs

extension: wire extension registries into sessions (#21737)

2026-05-11 11:38:18 +02:00

codex_thread.rs

feat: add thread lifecycle contributor hooks (#22476)

2026-05-13 13:11:30 +02:00

command_canonicalization_tests.rs

fix: move inline codex-rs/core unit tests into sibling files (#14444)

2026-03-12 08:16:36 -07:00

command_canonicalization.rs

core: remove cross-crate re-exports from lib.rs (#16512)

2026-04-01 23:06:24 -07:00

compact_remote_v2.rs

Send response.processed after remote compaction v2 (#21642)

2026-05-07 19:57:36 -07:00

compact_remote.rs

[codex] Filter legacy warning messages during compaction (#22243)

2026-05-11 19:51:51 -07:00

compact_tests.rs

[codex] Filter legacy warning messages during compaction (#22243)

2026-05-11 19:51:51 -07:00

compact.rs

Revert "[codex] Harden overflow auto-compaction recovery" (#22170)

2026-05-11 19:33:15 +03:00

config_lock.rs

feat: export and replay effective config locks (#20405)

2026-05-01 17:46:02 +02:00

connectors_tests.rs

Simplify MCP tool handler plumbing (#21595)

2026-05-12 00:11:31 +00:00

connectors.rs

[elicitation] Advertise new url elicitation capability when auth_elicitation is enabled. (#22188)

2026-05-11 12:23:55 -07:00

consequential_tool_message_templates.json

[elicitation] User-friendly tool call messages. (#14403)

2026-03-12 00:35:21 -07:00

environment_selection.rs

Make environment provider snapshots path-free (#21794)

2026-05-08 15:30:00 -07:00

event_mapping_tests.rs

Improve goal continuation based on feedback (#22045)

2026-05-11 09:51:21 -07:00

event_mapping.rs

Organize context fragments (#18794)

2026-04-20 22:39:17 -07:00

exec_env_tests.rs

[codex] Move config loading into codex-config (#19487)

2026-04-26 15:10:53 -07:00

exec_env.rs

[codex] Move config loading into codex-config (#19487)

2026-04-26 15:10:53 -07:00

exec_policy_tests.rs

fix(permissions): preserve managed deny-read during escalation (#15977)

2026-05-11 11:49:44 -07:00

exec_policy_windows_tests.rs

execpolicy: unwrap PowerShell -Command wrappers on Windows (#20336)

2026-05-01 00:56:20 +00:00

exec_policy.rs

fix(exec-policy) use is_known_safe_command less (#20305)

2026-05-11 11:37:53 -07:00

exec_tests.rs

feat(sandbox): add Windows deny-read parity (#18202)

2026-05-11 23:04:28 -07:00

exec.rs

feat(sandbox): add Windows deny-read parity (#18202)

2026-05-11 23:04:28 -07:00

function_tool.rs

feat: extract shared tool executor interface (#22359)

2026-05-13 11:31:27 +02:00

git_info_tests.rs

Refactor config loading to use filesystem abstraction (#18209)

2026-04-17 00:51:21 +00:00

goals.rs

Fix goal update and add /goal edit command in TUI (#21954)

2026-05-11 10:49:19 -07:00

hook_runtime.rs

hooks: use new session IDs instead of thread IDs for hooks, apply parent's session ID to subagents' hooks (#22268)

2026-05-12 19:05:10 -07:00

installation_id.rs

feat: split memories part 2 (#19860)

2026-04-28 13:03:28 +02:00

landlock.rs

linux-sandbox: switch helper plumbing to PermissionProfile (#20106)

2026-04-28 19:43:44 -07:00

lib.rs

Remove unavailable MCP placeholder tool backfill (#22439)

2026-05-12 23:30:13 -07:00

mcp_openai_file.rs

refactor: route Codex auth through AuthProvider (#18811)

2026-04-23 17:14:02 -07:00

mcp_skill_dependencies.rs

feat: make built-in MCPs first-class runtime servers (#21356)

2026-05-07 10:36:32 +02:00

mcp_tool_approval_templates.rs

chore: clean up argument-comment lint and roll out all-target CI on macOS (#16054)

2026-03-27 19:00:44 -07:00

mcp_tool_call_tests.rs

hooks: use new session IDs instead of thread IDs for hooks, apply parent's session ID to subagents' hooks (#22268)

2026-05-12 19:05:10 -07:00

mcp_tool_call.rs

[codex] Remove string-keyed MCP tool maps (#21454)

2026-05-07 10:16:10 -07:00

mcp_tool_exposure_test.rs

Simplify MCP tool handler plumbing (#21595)

2026-05-12 00:11:31 +00:00

mcp_tool_exposure.rs

[codex] Remove string-keyed MCP tool maps (#21454)

2026-05-07 10:16:10 -07:00

mcp.rs

feat: make built-in MCPs first-class runtime servers (#21356)

2026-05-07 10:36:32 +02:00

memory_usage.rs

Remove ToolName display helper (#21465)

2026-05-08 12:17:48 -07:00

mention_syntax.rs

Extract codex-utils-plugins crate (#15746)

2026-03-25 11:05:35 -07:00

network_policy_decision_tests.rs

extract models manager and related ownership from core (#16508)

2026-04-02 23:00:02 -07:00

network_policy_decision.rs

refactor(proxy): clarify sandbox block messages (#17168)

2026-04-09 10:53:06 -07:00

network_proxy_loader_tests.rs

chore: clean up argument-comment lint and roll out all-target CI on macOS (#16054)

2026-03-27 19:00:44 -07:00

network_proxy_loader.rs

inline hostname resolution for remote sandbox config (#19739)

2026-04-27 03:18:57 +00:00

original_image_detail.rs

Remove js_repl feature (#19410)

2026-04-24 17:49:29 -07:00

otel_init.rs

Add process-scoped SQLite telemetry (#22154)

2026-05-11 11:32:40 -07:00

personality_migration_tests.rs

Revert state DB injection and agent graph store (#21481)

2026-05-06 22:48:29 -07:00

personality_migration.rs

Revert state DB injection and agent graph store (#21481)

2026-05-06 22:48:29 -07:00

prompt_debug.rs

extension: wire extension registries into sessions (#21737)

2026-05-11 11:38:18 +02:00

realtime_context_tests.rs

[codex-analytics] rework thread_source for thread analytics (#20949)

2026-05-06 02:12:31 +00:00

realtime_context.rs

[codex] Route live thread writes through ThreadStore (#18882)

2026-04-23 10:17:09 -07:00

realtime_conversation_tests.rs

Update realtime handoff transcript handling (#18597)

2026-04-20 14:04:09 -07:00

realtime_conversation.rs

Make realtime sideband startup async (#20715)

2026-05-04 22:28:14 +00:00

realtime_prompt.rs

[codex] Update realtime V2 VAD silence delay and 1.5 prompt (#18092)

2026-04-16 14:30:57 -07:00

review_format.rs

core: remove cross-crate re-exports from lib.rs (#16512)

2026-04-01 23:06:24 -07:00

review_prompts.rs

Spread AbsolutePathBuf (#17792)

2026-04-14 14:26:10 -07:00

rollout.rs

codex: use ThreadStore history for core review forks (#20577)

2026-05-05 15:25:19 -07:00

safety_tests.rs

permissions: remove cwd special path (#19841)

2026-04-27 13:41:27 -07:00

safety.rs

Make turn diff tracking operation backed (#21180)

2026-05-07 11:33:47 +02:00

sandbox_tags_tests.rs

permissions: make runtime config profile-backed (#19606)

2026-04-26 13:29:54 -07:00

sandbox_tags.rs

permissions: make runtime config profile-backed (#19606)

2026-04-26 13:29:54 -07:00

session_prefix.rs

Organize context fragments (#18794)

2026-04-20 22:39:17 -07:00

session_rollout_init_error.rs

remove temporary ownership re-exports (#16626)

2026-04-03 00:33:34 -07:00

session_startup_prewarm.rs

Add production startup and TTFT telemetry (#22198)

2026-05-11 23:58:36 +00:00

shell_detect.rs

chore: rename codex-command to codex-shell-command (#11378)

2026-02-10 17:03:46 -08:00

shell_snapshot_tests.rs

state: pass state db handles through consumers (#20561)

2026-05-04 11:46:03 -07:00

shell_snapshot.rs

state: pass state db handles through consumers (#20561)

2026-05-04 11:46:03 -07:00

shell_tests.rs

chore: clean up argument-comment lint and roll out all-target CI on macOS (#16054)

2026-03-27 19:00:44 -07:00

shell.rs

fix: add shell fallback paths for pwsh/powershell that work on GitHub Actions Windows runners (#16617)

2026-04-02 13:47:10 -07:00

skills.rs

Add plugin ID to skill analytics (#20923)

2026-05-04 20:36:29 -07:00

spawn.rs

Spread AbsolutePathBuf (#17792)

2026-04-14 14:26:10 -07:00

state_db_bridge.rs

state: pass state db handles through consumers (#20561)

2026-05-04 11:46:03 -07:00

stream_events_utils_tests.rs

Delete unused ResponseItem::Message.end_turn (#19605)

2026-04-26 17:18:09 -07:00

stream_events_utils.rs

Simplify MCP tool handler plumbing (#21595)

2026-05-12 00:11:31 +00:00

test_support.rs

Revert state DB injection and agent graph store (#21481)

2026-05-06 22:48:29 -07:00

thread_manager_tests.rs

extension: wire extension registries into sessions (#21737)

2026-05-11 11:38:18 +02:00

thread_manager.rs

feat: add thread lifecycle contributor hooks (#22476)

2026-05-13 13:11:30 +02:00

thread_rollout_truncation_tests.rs

Delete unused ResponseItem::Message.end_turn (#19605)

2026-04-26 17:18:09 -07:00

thread_rollout_truncation.rs

[codex-analytics] feature plumbing and emittance (#16640)

2026-04-13 23:11:49 -07:00

turn_diff_tracker_tests.rs

fix: preserve exact turn diffs after partial apply_patch failures (#21518)

2026-05-07 18:05:45 +02:00

turn_diff_tracker.rs

fix: preserve exact turn diffs after partial apply_patch failures (#21518)

2026-05-07 18:05:45 +02:00

turn_metadata_tests.rs

feat: include thread ID in MCP turn metadata (#21329)

2026-05-06 11:36:15 +02:00

turn_metadata.rs

feat: include thread ID in MCP turn metadata (#21329)

2026-05-06 11:36:15 +02:00

turn_timing_tests.rs

Add turn start timestamp to turn metadata (#19473)

2026-04-28 16:36:59 +00:00

turn_timing.rs

Add production startup and TTFT telemetry (#22198)

2026-05-11 23:58:36 +00:00

user_shell_command_tests.rs

Organize context fragments (#18794)

2026-04-20 22:39:17 -07:00

user_shell_command.rs

Organize context fragments (#18794)

2026-04-20 22:39:17 -07:00

util_tests.rs

Update models.json (#18586)

2026-04-20 10:27:01 -07:00

util.rs

remove temporary ownership re-exports (#16626)

2026-04-03 00:33:34 -07:00

web_search.rs

add missing fields to WebSearchAction and update app-server types (#10276)

2026-01-30 16:37:56 -08:00

windows_sandbox_read_grants_tests.rs

core: remove cross-crate re-exports from lib.rs (#16512)

2026-04-01 23:06:24 -07:00

windows_sandbox_read_grants.rs

core: remove cross-crate re-exports from lib.rs (#16512)

2026-04-01 23:06:24 -07:00

windows_sandbox_tests.rs

Configure multi_agent_v2 spawn agent hints (#17071)

2026-04-08 08:42:18 -07:00

windows_sandbox.rs

Configure multi_agent_v2 spawn agent hints (#17071)

2026-04-08 08:42:18 -07:00