mirror of
https://github.com/openai/codex.git
synced 2026-09-05 15:18:41 +00:00
## What changed - Add a best-effort `network/policyDecision` notification for final domain and non-domain policy decisions made by executor-local proxies. - Validate notifications against the active process on the controller and emit audit events with controller-trusted session and execution metadata. - Reserve outbound RPC capacity so audit notifications cannot block control messages, and expose valid `chatgpt-account-id` header values for audit attribution. ## Testing - Cover notification serialization, proxy decision capture, executor-to-controller delivery, trusted metadata handling, and reserved RPC capacity. GitOrigin-RevId: a39f96a6b3d9401c03d54eaef5b9a6d3fe0da78b
119 lines
3.8 KiB
Rust
119 lines
3.8 KiB
Rust
use pretty_assertions::assert_eq;
|
|
|
|
use super::ExecServerNetworkPolicyDecision;
|
|
use super::ExecServerNetworkPolicyRequest;
|
|
use super::ExecServerNetworkProtocol;
|
|
use super::NetworkPolicyDecisionNotification;
|
|
use super::NetworkPolicyRequestParams;
|
|
use super::NetworkPolicyRequestResponse;
|
|
use crate::ProcessId;
|
|
|
|
#[test]
|
|
fn network_policy_request_uses_stable_json_shapes() {
|
|
let request = NetworkPolicyRequestParams {
|
|
process_id: ProcessId::from("process-1"),
|
|
request: ExecServerNetworkPolicyRequest {
|
|
protocol: ExecServerNetworkProtocol::HttpsConnect,
|
|
host: "example.com".to_string(),
|
|
port: 443,
|
|
},
|
|
};
|
|
let request_json = serde_json::json!({
|
|
"processId": "process-1",
|
|
"request": {
|
|
"protocol": "https_connect",
|
|
"host": "example.com",
|
|
"port": 443,
|
|
},
|
|
});
|
|
assert_eq!(
|
|
serde_json::to_value(&request).expect("serialize policy request"),
|
|
request_json
|
|
);
|
|
let decoded_request: NetworkPolicyRequestParams =
|
|
serde_json::from_value(request_json.clone()).expect("deserialize policy request");
|
|
assert_eq!(
|
|
serde_json::to_value(decoded_request).expect("reserialize policy request"),
|
|
request_json
|
|
);
|
|
|
|
let decision = NetworkPolicyRequestResponse {
|
|
decision: ExecServerNetworkPolicyDecision::Allow,
|
|
};
|
|
let decision_json = serde_json::json!({
|
|
"decision": {"type": "allow"},
|
|
});
|
|
assert_eq!(
|
|
serde_json::to_value(&decision).expect("serialize policy decision"),
|
|
decision_json
|
|
);
|
|
assert_eq!(
|
|
serde_json::from_value::<NetworkPolicyRequestResponse>(decision_json)
|
|
.expect("deserialize policy decision"),
|
|
decision
|
|
);
|
|
|
|
for (decision, decision_json) in [
|
|
(
|
|
ExecServerNetworkPolicyDecision::Deny {
|
|
reason: "not_allowed".to_string(),
|
|
},
|
|
serde_json::json!({"type": "deny", "reason": "not_allowed"}),
|
|
),
|
|
(
|
|
ExecServerNetworkPolicyDecision::Ask {
|
|
reason: "not_allowed".to_string(),
|
|
},
|
|
serde_json::json!({"type": "ask", "reason": "not_allowed"}),
|
|
),
|
|
] {
|
|
let response = NetworkPolicyRequestResponse { decision };
|
|
assert_eq!(
|
|
serde_json::to_value(&response).expect("serialize policy decision"),
|
|
serde_json::json!({"decision": decision_json})
|
|
);
|
|
}
|
|
}
|
|
|
|
#[test]
|
|
fn network_policy_decision_notification_uses_stable_json_shape() {
|
|
let notification = NetworkPolicyDecisionNotification {
|
|
process_id: ProcessId::from("process-1"),
|
|
timestamp: "2026-08-11T12:34:56.789Z".to_string(),
|
|
scope: "domain".to_string(),
|
|
decision: "deny".to_string(),
|
|
source: "baseline_policy".to_string(),
|
|
reason: "not_allowed".to_string(),
|
|
protocol: ExecServerNetworkProtocol::HttpsConnect,
|
|
host: "example.com".to_string(),
|
|
port: 443,
|
|
method: Some("CONNECT".to_string()),
|
|
client: Some("127.0.0.1".to_string()),
|
|
policy_override: false,
|
|
};
|
|
let expected = serde_json::json!({
|
|
"processId": "process-1",
|
|
"timestamp": "2026-08-11T12:34:56.789Z",
|
|
"scope": "domain",
|
|
"decision": "deny",
|
|
"source": "baseline_policy",
|
|
"reason": "not_allowed",
|
|
"protocol": "https_connect",
|
|
"host": "example.com",
|
|
"port": 443,
|
|
"method": "CONNECT",
|
|
"client": "127.0.0.1",
|
|
"policyOverride": false,
|
|
});
|
|
|
|
assert_eq!(
|
|
serde_json::to_value(¬ification).expect("serialize policy decision notification"),
|
|
expected
|
|
);
|
|
assert_eq!(
|
|
serde_json::from_value::<NetworkPolicyDecisionNotification>(expected)
|
|
.expect("deserialize policy decision notification"),
|
|
notification
|
|
);
|
|
}
|