mirror of
https://github.com/openai/codex.git
synced 2026-10-20 17:38:45 +00:00
Benjamin Carlsson
ce7fbb373b
## Why Windows release packages need the voice helper and native audio libraries. Realtime TLS connections on fresh Windows installations also need platform certificate validation so Windows can retrieve missing trusted roots on demand. ## What changed - Build and sign the voice helper and audio DLLs for Windows x64 and ARM64, bundle a pinned Microsoft CRT DLL, and verify signatures and runtime receipts before packaging. - Add verified, pinned Cygwin and native build tools plus MSVC linker, compiler, and path handling fixes for the Windows Bazel builds. - Include voice resources in primary release archives and WinGet packages. Preserve WinGet executable names, update manifest hashes, and recognize the package root through matching entrypoint metadata. Keep Python runtime wheels voice-free to preserve their existing Windows support floor. - Use Windows platform TLS validation for realtime WebSockets when no custom CA bundle is configured, preserving custom CA behavior. ## Testing Add coverage for build-input integrity and unsafe paths, signed Windows runtime assembly, WinGet file and hash preservation, package discovery, and TLS trust selection, untrusted certificate rejection, and hostname validation. GitOrigin-RevId: 423da35872fa5549d69fd4ca97d922bb49599386
59 lines
2.0 KiB
Rust
59 lines
2.0 KiB
Rust
//! Certificate rejection coverage for Windows platform TLS.
|
|
|
|
use super::build_windows_platform_tls_config;
|
|
use std::sync::Arc;
|
|
|
|
#[test]
|
|
fn platform_tls_rejects_a_self_signed_server() {
|
|
let client_config =
|
|
build_windows_platform_tls_config().expect("configure platform verification");
|
|
let certified_key = rcgen::generate_simple_self_signed(vec!["localhost".to_string()])
|
|
.expect("generate untrusted certificate");
|
|
let server_config = rustls::ServerConfig::builder()
|
|
.with_no_client_auth()
|
|
.with_single_cert(
|
|
vec![certified_key.cert.der().clone()],
|
|
certified_key.signing_key.into(),
|
|
)
|
|
.expect("configure test server");
|
|
let mut client = rustls::ClientConnection::new(
|
|
client_config,
|
|
"localhost".try_into().expect("valid server name"),
|
|
)
|
|
.expect("create client");
|
|
let mut server = rustls::ServerConnection::new(Arc::new(server_config)).expect("create server");
|
|
|
|
// Drive the real handshake without opening ports or changing system trust.
|
|
for _ in 0..10 {
|
|
let mut outbound = Vec::new();
|
|
client
|
|
.write_tls(&mut outbound)
|
|
.expect("write client records");
|
|
server
|
|
.read_tls(&mut outbound.as_slice())
|
|
.expect("read client records");
|
|
server
|
|
.process_new_packets()
|
|
.expect("process client records");
|
|
outbound.clear();
|
|
server
|
|
.write_tls(&mut outbound)
|
|
.expect("write server records");
|
|
client
|
|
.read_tls(&mut outbound.as_slice())
|
|
.expect("read server records");
|
|
if let Err(error) = client.process_new_packets() {
|
|
assert!(
|
|
matches!(error, rustls::Error::InvalidCertificate(_)),
|
|
"{error:?}"
|
|
);
|
|
return;
|
|
}
|
|
assert!(
|
|
client.is_handshaking(),
|
|
"untrusted server must not complete TLS"
|
|
);
|
|
}
|
|
panic!("expected certificate rejection during handshake");
|
|
}
|