johnl-oai
dd12f892f1
Avoid sharing violations when repairing Windows runtime ACLs ( #51822 )
...
## Why
Opening active EXE/DLL files with `MAXIMUM_ALLOWED` can request access that causes sharing violations during sandbox runtime ACL repair.
## What changed
Restrict `MAXIMUM_ALLOWED` opens to directories that need to suppress child ACL propagation. For files, request `READ_CONTROL | WRITE_DAC` only when an ACL update is needed.
Preserve the non-inheriting grant behavior from https://github.com/openai/codex/pull/49690 , including existing permissions, deny ACEs, and null DACLs.
## Testing
Extend the Windows runtime repair regression test to hold `node.exe` open with `FILE_SHARE_READ` throughout repair and revalidation, while checking read/execute access and preserved denials.
GitOrigin-RevId: 2e087b51adc0221d0eda061fa0a34d2e98409662
2026-10-07 20:46:56 +00:00
..
2026-10-02 04:02:14 +00:00
2026-10-07 12:47:04 +00:00
2026-09-30 17:33:59 +00:00
2026-10-06 21:29:35 +00:00
2026-09-30 00:51:39 +00:00
2026-10-07 19:28:14 +00:00
2026-10-06 16:56:39 +00:00
2026-10-04 06:28:20 +00:00
2026-10-07 07:57:14 +00:00
2026-10-07 06:07:47 +00:00
2026-10-06 17:26:19 +00:00
2026-10-05 23:52:06 +00:00
2026-10-05 23:52:06 +00:00
2026-10-06 23:44:17 +00:00
2026-10-02 22:20:55 +00:00
2026-09-30 18:49:29 +00:00
2026-10-07 06:07:47 +00:00
2026-10-01 22:32:29 +00:00
2026-09-29 13:58:09 +00:00
2026-09-29 03:32:19 +00:00
2026-10-05 22:18:55 +00:00
2026-10-05 22:18:55 +00:00
2026-10-06 00:36:25 +00:00
2026-10-07 16:46:43 +00:00
2026-10-06 19:13:04 +00:00
2026-09-25 00:20:02 +00:00
2026-10-07 19:28:14 +00:00
2026-10-07 01:52:09 +00:00
2026-10-02 22:12:07 +00:00
2026-10-07 19:42:35 +00:00
2026-10-06 23:28:55 +00:00
2026-10-06 22:36:22 +00:00
2026-10-07 06:07:47 +00:00
2026-10-07 17:59:22 +00:00
2026-10-07 17:59:22 +00:00
2026-10-07 19:03:52 +00:00
2026-10-06 16:56:39 +00:00
2026-10-07 19:42:35 +00:00
2026-10-07 11:18:05 +00:00
2026-10-01 09:52:54 +00:00
2026-10-07 17:59:22 +00:00
2026-10-01 15:57:03 +00:00
2026-10-07 10:33:33 +00:00
2026-10-06 15:50:27 +00:00
2026-10-01 11:01:37 +00:00
2026-10-01 22:32:29 +00:00
2026-09-29 22:24:09 +00:00
2026-10-07 00:51:24 +00:00
2026-10-02 23:26:27 +00:00
2026-09-28 14:46:32 +00:00
2026-09-28 06:30:53 +00:00
2026-10-07 18:32:50 +00:00
2026-10-02 23:26:27 +00:00
2026-10-06 01:46:33 +00:00
2026-10-07 20:21:35 +00:00
2026-10-07 11:10:20 +00:00
2026-10-07 17:28:32 +00:00
2026-10-06 21:29:35 +00:00
2026-10-06 19:30:57 +00:00
2026-10-07 17:59:22 +00:00
2026-10-01 15:57:03 +00:00
2026-09-29 01:14:41 +00:00
2026-10-07 19:28:14 +00:00
2026-10-07 07:57:14 +00:00
2026-10-07 07:57:14 +00:00
2026-10-07 20:21:35 +00:00
2026-09-24 18:08:31 +00:00
2026-09-28 15:58:17 +00:00
2026-10-07 17:17:05 +00:00
2026-10-07 17:28:32 +00:00
2026-10-02 00:46:14 +00:00
2026-10-06 19:30:57 +00:00
2026-10-07 06:34:22 +00:00
2026-10-07 14:32:44 +00:00
2026-10-07 19:42:35 +00:00
2026-10-01 18:05:05 +00:00
2026-10-03 07:14:12 +00:00
2026-10-01 15:57:03 +00:00
2026-10-07 20:46:56 +00:00
2026-10-03 03:20:37 +00:00
2026-10-01 15:57:03 +00:00
2026-10-07 20:21:35 +00:00
2026-10-07 20:21:35 +00:00
2026-10-02 04:02:14 +00:00