mirror of
https://github.com/openai/codex.git
synced 2026-11-11 21:10:39 +00:00
jif
a390571745
## Why Profiles without a v1 memory workspace have no legacy context to preserve or consolidate before using v2. ## What changed - Select v2 when memories are enabled and the `memories` directory is absent. Preserve explicit `memories.version` settings, the `memories.dual_write = false` opt-out, and the v1 default for existing workspaces or filesystem check errors. - Report `v2_ready` immediately for profiles without a v1 workspace. Keep the consolidation count and valid-summary requirements for profiles with a v1 workspace. - Make resetting an absent memory workspace a no-op so it does not create an unused v1 directory. ## Testing Extend coverage for default and explicit version selection, opt-outs, version-specific memory reads, fresh-profile readiness and reset behavior, and running only the v2 pipeline for fresh profiles. GitOrigin-RevId: a8fb0844962ae9266ffbe88af97e8dc4a99ac15f
60 lines
2.2 KiB
Rust
60 lines
2.2 KiB
Rust
//! Reports v2 readiness without exposing memory contents or persistence details to clients.
|
|
|
|
use super::*;
|
|
use codex_app_server_protocol::MemoryStatusParams;
|
|
use codex_app_server_protocol::MemoryStatusResponse;
|
|
use codex_protocol::MemoryVersion;
|
|
|
|
impl ThreadRequestProcessor {
|
|
pub(crate) async fn memory_status(
|
|
&self,
|
|
params: MemoryStatusParams,
|
|
) -> Result<Option<ClientResponsePayload>, JSONRPCErrorError> {
|
|
let minimum = params.min_consolidated_threads.unwrap_or(20);
|
|
if !(1..=4096).contains(&minimum) {
|
|
return Err(invalid_params(
|
|
"minConsolidatedThreads must be between 1 and 4096",
|
|
));
|
|
}
|
|
let db = self
|
|
.state_db
|
|
.as_ref()
|
|
.ok_or_else(|| internal_error("sqlite state db unavailable for memory status"))?;
|
|
let store = db
|
|
.memories_for_version(MemoryVersion::V2)
|
|
.await
|
|
.map_err(|error| internal_error(format!("failed to open v2 memory state: {error}")))?;
|
|
let count = store
|
|
.max_consolidated_thread_count()
|
|
.await
|
|
.map_err(|error| internal_error(format!("failed to read memory progress: {error}")))?;
|
|
let root = self
|
|
.config
|
|
.codex_home
|
|
.join(MemoryVersion::V2.directory_name());
|
|
let summary = tokio::fs::read_to_string(root.join("memory_summary.md"))
|
|
.await
|
|
.ok();
|
|
let has_v1_workspace = tokio::fs::try_exists(
|
|
self.config
|
|
.codex_home
|
|
.join(MemoryVersion::V1.directory_name()),
|
|
)
|
|
.await
|
|
.map_err(|error| internal_error(format!("failed to check v1 memory workspace: {error}")))?;
|
|
// Fresh profiles can start on V2 without consolidating any V1 history first.
|
|
let ready = !has_v1_workspace
|
|
|| count >= minimum
|
|
&& summary
|
|
.as_deref()
|
|
.is_some_and(codex_memories_write::workspace::is_valid_v2_summary);
|
|
Ok(Some(
|
|
MemoryStatusResponse {
|
|
v2_consolidated_threads: count,
|
|
v2_ready: ready,
|
|
}
|
|
.into(),
|
|
))
|
|
}
|
|
}
|