codex

mirror of https://github.com/openai/codex.git synced 2026-11-02 19:43:24 +00:00

Files

T

Dylan Hurd d68b85a097 Require fresh approval beneath denied permission paths (#39266 )

## Why

A stored permission grant may allow access to a parent while explicitly denying
a child path. A later request for that child must not be treated as already
approved by the broader parent grant.

## What changed

- Compare materialized permission profiles without intersecting away denied or
  reopened paths before deciding that a request is preapproved.
- Execute preapproved commands with the stored grant itself so its denied paths
  remain enforced.
- Fail closed when permission profiles cannot be materialized.

## Testing

Added unit and integration coverage for turn and session grants across
`exec_command`, `shell_command`, and `apply_patch`, including approval-disabled
and `Never` approval modes.

GitOrigin-RevId: 5455880328a89c7958f859c7ce87805dff9704fb

2026-08-18 19:17:09 +00:00

snapshots

Include agent names in turn metadata (#38483 )

2026-08-14 02:32:05 +00:00

abort_tasks.rs

Unify turn input submission and routing (#38275 )

2026-08-13 00:00:16 +00:00

additional_context.rs

Unify turn input submission and routing (#38275 )

2026-08-13 00:00:16 +00:00

agent_execution.rs

Preserve environments when reloading V2 agents (#37847 )

2026-08-10 16:57:09 +00:00

agent_websocket.rs

Unify turn input submission and routing (#38275 )

2026-08-13 00:00:16 +00:00

agents_md.rs

Preserve filesystem permission path conventions (#39084 )

2026-08-17 21:49:30 +00:00

apply_patch_cli.rs

Preserve filesystem permission path conventions (#39084 )

2026-08-17 21:49:30 +00:00

approvals.rs

Require approval for commands with dynamic shell words (#39159 )

2026-08-18 07:26:21 +00:00

audio_truncation.rs

Unify turn input submission and routing (#38275 )

2026-08-13 00:00:16 +00:00

auto_review.rs

Add Guardian v2 approval review metrics (#39224 )

2026-08-18 16:27:54 +00:00

catalog_permission_messages.rs

Source Guardian v2 defaults from the model catalog (#38990 )

2026-08-17 11:44:56 +00:00

cli_stream.rs

Update models.json (#31684 )

2026-07-09 03:40:08 +00:00

client_websockets.rs

Unify turn input submission and routing (#38275 )

2026-08-13 00:00:16 +00:00

client.rs

Enable parallel tool calls for all model prompts (#38499 )

2026-08-14 05:49:33 +00:00

cloud_config.rs

Disable Guardian V2 for managed automatic reviewers (#39005 )

2026-08-17 13:16:05 +00:00

code_mode_elicitation.rs

Unify turn input submission and routing (#38275 )

2026-08-13 00:00:16 +00:00

code_mode.rs

Include node_repl screenshots in Guardian v2 reviews (#39227 )

2026-08-18 16:38:52 +00:00

codex_delegate.rs

Unify turn input submission and routing (#38275 )

2026-08-13 00:00:16 +00:00

collaboration_instructions.rs

Refresh collaboration instructions when their content changes (#39163 )

2026-08-18 07:32:03 +00:00

compact_remote_parity.rs

Unify turn input submission and routing (#38275 )

2026-08-13 00:00:16 +00:00

compact_remote.rs

Drop descendant progress updates after remote compaction (#39176 )

2026-08-18 09:38:27 +00:00

compact_resume_fork.rs

Unify turn input submission and routing (#38275 )

2026-08-13 00:00:16 +00:00

compact.rs

Unify turn input submission and routing (#38275 )

2026-08-13 00:00:16 +00:00

current_time_reminder.rs

Tag current time reminders in model context (#38443 )

2026-08-13 21:53:52 +00:00

cyber_exec_policy.rs

Unify turn input submission and routing (#38275 )

2026-08-13 00:00:16 +00:00

deprecation_notice.rs

Add indexed web search mode (#28489 )

2026-06-19 05:35:57 -07:00

exec_policy.rs

Fail closed on deeply nested command wrappers (#39122 )

2026-08-18 02:23:57 +00:00

exec.rs

Add network environment ID plumbing (#28766 )

2026-06-18 14:09:38 +02:00

extension_sandbox.rs

Preserve filesystem permission path conventions (#39084 )

2026-08-17 21:49:30 +00:00

external_auth.rs

Prevent custom providers from inheriting ambient auth (#39214 )

2026-08-18 15:06:09 +00:00

fork_thread.rs

Add experimental app-server project APIs (#38940 )

2026-08-17 04:01:37 +00:00

git_enrichment.rs

Unify turn input submission and routing (#38275 )

2026-08-13 00:00:16 +00:00

guardian_review.rs

Preserve filesystem permission path conventions (#39084 )

2026-08-17 21:49:30 +00:00

hooks_mcp.rs

Route MCP tool calls through shared approval handling (#38108 )

2026-08-12 03:00:47 +00:00

hooks.rs

Reject sessions with unloadable required managed hooks (#38394 )

2026-08-13 15:23:09 +00:00

image_rollout.rs

Unify turn input submission and routing (#38275 )

2026-08-13 00:00:16 +00:00

injected_models_cache.rs

Unify turn input submission and routing (#38275 )

2026-08-13 00:00:16 +00:00

items.rs

Unify turn input submission and routing (#38275 )

2026-08-13 00:00:16 +00:00

json_result.rs

Unify turn input submission and routing (#38275 )

2026-08-13 00:00:16 +00:00

live_cli.rs

[codex] Use expect in integration tests (#28441 )

2026-06-15 21:53:47 -07:00

mcp_auth_elicitation.rs

Unify turn input submission and routing (#38275 )

2026-08-13 00:00:16 +00:00

mcp_auth_refresh.rs

Read plugin authentication state from AuthManager (#39087 )

2026-08-17 22:26:27 +00:00

mcp_refresh_cleanup.rs

Negotiate MCP extensions per app-server session (#36910 )

2026-08-04 15:23:43 +00:00

mcp_startup_refresh_http_proxy.rs

Support per-server MCP OAuth callback ports (#38448 )

2026-08-13 22:42:12 +00:00

mcp_tool_cache.rs

Preserve MCP namespace descriptions in the tool catalog cache (#38623 )

2026-08-14 18:35:13 +00:00

mcp_tool_exposure.rs

Scope MCP resource reads by connector (#39244 )

2026-08-18 18:01:39 +00:00

mcp_turn_metadata.rs

Enforce strict auto-review for MCP tool calls (#38492 )

2026-08-14 04:46:04 +00:00

mod.rs

Add structured telemetry for response retries (#38452 )

2026-08-13 23:13:37 +00:00

model_overrides.rs

[5 of 7] Replace OverrideTurnContext with ThreadSettings (#22508 )

2026-05-18 21:03:51 -07:00

model_runtime_selectors.rs

Unify turn input submission and routing (#38275 )

2026-08-13 00:00:16 +00:00

model_switching.rs

Keep active-turn model settings stable across updates (#38785 )

2026-08-15 16:58:08 +00:00

model_visible_layout.rs

Add a configurable skill catalog token budget (#38978 )

2026-08-17 10:01:59 +00:00

models_cache_ttl.rs

Source Guardian v2 defaults from the model catalog (#38990 )

2026-08-17 11:44:56 +00:00

models_etag_responses.rs

Unify turn input submission and routing (#38275 )

2026-08-13 00:00:16 +00:00

multi_agent_mode.rs

Source multi-agent instructions from the model catalog (#38619 )

2026-08-14 18:26:20 +00:00

multi_agent_resume.rs

Unify turn input submission and routing (#38275 )

2026-08-13 00:00:16 +00:00

multi_exec_server_sandbox.rs

Carry environment config in turn selections (#38521 )

2026-08-14 07:52:38 +00:00

network_approval.rs

Carry environment config in turn selections (#38521 )

2026-08-14 07:52:38 +00:00

openai_file_mcp.rs

Preserve filesystem permission path conventions (#39084 )

2026-08-17 21:49:30 +00:00

otel.rs

Route network access through the shared approval pipeline (#38299 )

2026-08-13 02:40:49 +00:00

override_updates.rs

Pair thread environment settings (#26687 )

2026-06-08 13:55:15 -07:00

pending_input.rs

Unify turn input submission and routing (#38275 )

2026-08-13 00:00:16 +00:00

permissions_messages.rs

Source Guardian v2 defaults from the model catalog (#38990 )

2026-08-17 11:44:56 +00:00

personality.rs

Source Guardian v2 defaults from the model catalog (#38990 )

2026-08-17 11:44:56 +00:00

plugins.rs

Read plugin authentication state from AuthManager (#39087 )

2026-08-17 22:26:27 +00:00

prompt_cache_key.rs

Use session IDs for prompt cache keys (#33035 )

2026-07-14 10:37:23 +00:00

prompt_caching.rs

Enable unified exec by default on Windows (#38625 )

2026-08-14 19:07:15 +00:00

prompt_debug_tests.rs

Enable git attribution across Codex entry points (#34819 )

2026-07-22 20:23:35 +00:00

quota_exceeded.rs

Unify turn input submission and routing (#38275 )

2026-08-13 00:00:16 +00:00

realtime_conversation.rs

Reconnect WebRTC Realtime sideband transports (#39257 )

2026-08-18 18:41:40 +00:00

realtime_initial_items.rs

Add a realtime delegation acknowledgement control (#36413 )

2026-08-01 01:17:26 +00:00

remote_env.rs

Preserve filesystem permission path conventions (#39084 )

2026-08-17 21:49:30 +00:00

remote_models.rs

Source Guardian v2 defaults from the model catalog (#38990 )

2026-08-17 11:44:56 +00:00

request_compression.rs

Unify turn input submission and routing (#38275 )

2026-08-13 00:00:16 +00:00

request_permissions_tool.rs

Unify turn input submission and routing (#38275 )

2026-08-13 00:00:16 +00:00

request_permissions.rs

Require fresh approval beneath denied permission paths (#39266 )

2026-08-18 19:17:09 +00:00

request_plugin_install.rs

Hydrate recommended plugin metadata on selection (#39143 )

2026-08-18 05:42:39 +00:00

request_user_input.rs

Unify turn input submission and routing (#38275 )

2026-08-13 00:00:16 +00:00

responses_api_proxy_headers.rs

Unify turn input submission and routing (#38275 )

2026-08-13 00:00:16 +00:00

responses_lite.rs

Enable parallel tool calls for all model prompts (#38499 )

2026-08-14 05:49:33 +00:00

responses_system_proxy.rs

Migrate login HTTP construction to HttpClient (#34643 )

2026-07-22 00:50:28 +00:00

resume_warning.rs

Persist active permission profiles in turn context (#39145 )

2026-08-18 05:46:08 +00:00

resume.rs

Unify turn input submission and routing (#38275 )

2026-08-13 00:00:16 +00:00

retry_after.rs

Add structured telemetry for response retries (#38452 )

2026-08-13 23:13:37 +00:00

review.rs

Unify turn input submission and routing (#38275 )

2026-08-13 00:00:16 +00:00

rmcp_client.rs

Enable parallel tool calls for all model prompts (#38499 )

2026-08-14 05:49:33 +00:00

rollout_budget.rs

Unify turn input submission and routing (#38275 )

2026-08-13 00:00:16 +00:00

rollout_list_find.rs

Honor the configured SQLite home across state consumers (#34994 )

2026-07-23 19:19:35 +00:00

safety_buffering.rs

Unify turn input submission and routing (#38275 )

2026-08-13 00:00:16 +00:00

safety_check_downgrade.rs

Unify turn input submission and routing (#38275 )

2026-08-13 00:00:16 +00:00

search_tool.rs

Unify turn input submission and routing (#38275 )

2026-08-13 00:00:16 +00:00

shell_command.rs

Prevent Noise auth tokens from reaching child processes (#38941 )

2026-08-17 04:17:45 +00:00

shell_serialization.rs

test: branch on target OS instead of runner flavor (#29712 )

2026-06-23 14:27:13 -07:00

shell_snapshot.rs

Unify turn input submission and routing (#38275 )

2026-08-13 00:00:16 +00:00

skill_approval.rs

Unify turn input submission and routing (#38275 )

2026-08-13 00:00:16 +00:00

skills_extension.rs

Add a configurable skill catalog token budget (#38978 )

2026-08-17 10:01:59 +00:00

skills.rs

Add a configurable skill catalog token budget (#38978 )

2026-08-17 10:01:59 +00:00

spawn_agent_description.rs

Source multi-agent instructions from the model catalog (#38619 )

2026-08-14 18:26:20 +00:00

sqlite_state.rs

Support metadata staging for reserved thread IDs (#38819 )

2026-08-16 00:57:28 +00:00

stream_error_allows_next_turn.rs

Unify turn input submission and routing (#38275 )

2026-08-13 00:00:16 +00:00

stream_no_completed.rs

Unify turn input submission and routing (#38275 )

2026-08-13 00:00:16 +00:00

subagent_notifications.rs

Source multi-agent instructions from the model catalog (#38619 )

2026-08-14 18:26:20 +00:00

token_budget.rs

Add a configurable skill catalog token budget (#38978 )

2026-08-17 10:01:59 +00:00

tool_harness.rs

Unify turn input submission and routing (#38275 )

2026-08-13 00:00:16 +00:00

tool_lifecycle.rs

Run tool start callbacks after pre-tool hooks (#38568 )

2026-08-14 12:21:08 +00:00

tool_parallelism.rs

Unify turn input submission and routing (#38275 )

2026-08-13 00:00:16 +00:00

tools.rs

Unify turn input submission and routing (#38275 )

2026-08-13 00:00:16 +00:00

truncation.rs

Unify turn input submission and routing (#38275 )

2026-08-13 00:00:16 +00:00

turn_input_submission.rs

Centralize thread environment selection state (#38423 )

2026-08-13 19:25:05 +00:00

turn_state.rs

Include sandbox mode in response metadata (#37507 )

2026-08-07 22:41:20 +00:00

unified_exec_process_events.rs

Preserve foreign paths in managed network approvals (#39040 )

2026-08-17 18:15:56 +00:00

unified_exec_zsh_fork_approvals.rs

Unify turn input submission and routing (#38275 )

2026-08-13 00:00:16 +00:00

unified_exec.rs

Add network policy metadata to environment configuration (#39055 )

2026-08-17 19:22:45 +00:00

unstable_features_warning.rs

Extract persisted history types into a dedicated crate (#37871 )

2026-08-10 19:26:52 +00:00

user_notification.rs

Unify turn input submission and routing (#38275 )

2026-08-13 00:00:16 +00:00

user_shell_cmd.rs

Unify turn input submission and routing (#38275 )

2026-08-13 00:00:16 +00:00

view_image.rs

Preserve filesystem permission path conventions (#39084 )

2026-08-17 21:49:30 +00:00

web_search.rs

Add an Amazon Bedrock Runtime provider (#38470 )

2026-08-14 01:23:59 +00:00

websocket_fallback.rs

Unify turn input submission and routing (#38275 )

2026-08-13 00:00:16 +00:00

window_headers.rs

Unify turn input submission and routing (#38275 )

2026-08-13 00:00:16 +00:00

windows_sandbox.rs

Preserve filesystem permission path conventions (#39084 )

2026-08-17 21:49:30 +00:00

workspace_roots.rs

Use turn environment permissions for tool execution (#37038 )

2026-08-05 06:38:57 +00:00