mirror of
https://github.com/openai/codex.git
synced 2026-11-20 22:40:37 +00:00
## Why Code Mode wrappers should preserve cached scores for nested actions so adaptive review can reuse them across cells. ## What changed Remove `code_mode` from `GuardianModelPolicy` and its approval scopes. Skip scoring and cache invalidation for direct Code Mode `exec` wrappers under model policies, leaving nested tools governed by their own categories. Preserve legacy wrapper scoring behavior. ## Testing Expand app-server coverage for score reuse across cells, synchronous nested reviews, required model policies, and legacy configurations. Retain checks that ordinary tools named `exec` or MCP tools named `wait` invalidate cached scores. GitOrigin-RevId: 7a0692e5330f3d4b4bda988ecbe7061bc8b2318c
49 lines
1.7 KiB
Rust
49 lines
1.7 KiB
Rust
use super::super::tests::test_model;
|
|
use super::*;
|
|
use pretty_assertions::assert_eq;
|
|
|
|
#[test]
|
|
fn guardian_policy_is_optional_and_tolerates_future_config() -> anyhow::Result<()> {
|
|
let model = test_model(/*spec*/ None);
|
|
let mut wire = serde_json::to_value(&model)?;
|
|
assert!(
|
|
!wire
|
|
.as_object()
|
|
.expect("model object")
|
|
.contains_key("guardian")
|
|
);
|
|
assert_eq!(serde_json::from_value::<ModelInfo>(wire.clone())?, model);
|
|
|
|
wire["guardian"] = serde_json::json!({
|
|
"computer_use": "adaptive", "shell": "future_mode", "future_scope": {"version": 2},
|
|
"mcp": null, "permissions": "adaptive",
|
|
});
|
|
let model: ModelInfo = serde_json::from_value(wire)?;
|
|
assert_eq!(
|
|
model.guardian,
|
|
Some(GuardianModelPolicy {
|
|
computer_use: Some(GuardianReviewMode::Adaptive),
|
|
shell: Some(GuardianReviewMode::Unknown),
|
|
permissions: Some(GuardianReviewMode::Adaptive),
|
|
..Default::default()
|
|
})
|
|
);
|
|
assert!(model.computer_use_review_required());
|
|
assert_eq!(
|
|
model.guardian_review_mode(GuardianScope::Mcp),
|
|
Some(GuardianReviewMode::Disabled)
|
|
);
|
|
Ok(())
|
|
}
|
|
|
|
#[test]
|
|
fn guardian_policy_overrides_the_legacy_cua_bit_only_when_present() {
|
|
let mut model = test_model(/*spec*/ None);
|
|
model.node_repl_auto_review_required = true;
|
|
assert!(model.computer_use_review_required());
|
|
model.guardian = Some(GuardianModelPolicy::default());
|
|
assert!(!model.computer_use_review_required());
|
|
model.guardian.as_mut().expect("policy").computer_use = Some(GuardianReviewMode::Synchronous);
|
|
assert!(model.computer_use_review_required());
|
|
}
|