Michael Bolin d1068e057a Extract tool-suggest wire helpers into codex-tools (#16499) ...

## Why

This is another straight-refactor step in the `codex-tools` migration.

`core/src/tools/handlers/tool_suggest.rs` still owned request/response
payload structs, elicitation metadata shaping, and connector-completion
predicates that do not depend on `codex-core` session/runtime internals.
Per the `AGENTS.md` guidance to keep shrinking `codex-core`, this moves
that pure wire-format logic into `codex-rs/tools` so the core handler
keeps only session orchestration, plugin/config refresh, and MCP cache
updates.

## What changed

- Added `codex-rs/tools/src/tool_suggest.rs` and exported its API from
`codex-rs/tools/src/lib.rs`.
- Moved `ToolSuggestArgs`, `ToolSuggestResult`, `ToolSuggestMeta`,
`build_tool_suggestion_elicitation_request()`,
`all_suggested_connectors_picked_up()`, and
`verified_connector_suggestion_completed()` into `codex-tools`.
- Rewired `core/src/tools/handlers/tool_suggest.rs` to consume those
exports directly.
- Ported the existing pure helper tests from
`core/src/tools/handlers/tool_suggest_tests.rs` to
`tools/src/tool_suggest_tests.rs` without adding new behavior coverage.

## Validation

```shell
cargo test -p codex-tools
cargo test -p codex-core tools::handlers::tool_suggest::tests
just argument-comment-lint
```

2026-04-01 20:49:15 -07:00

..

agent

feat: fork pattern v2 (#15771)

2026-03-31 13:06:08 +02:00

apps

[apps][tool_suggest] Remove tool_suggest's dependency on tool search. (#14856)

2026-03-25 12:26:02 -07:00

bin

…

codex

chore: clean up argument-comment lint and roll out all-target CI on macOS (#16054)

2026-03-27 19:00:44 -07:00

config

Extract MCP into codex-mcp crate (#15919)

2026-04-01 19:03:26 -07:00

config_loader

chore: clean up argument-comment lint and roll out all-target CI on macOS (#16054)

2026-03-27 19:00:44 -07:00

context_manager

chore: clean up argument-comment lint and roll out all-target CI on macOS (#16054)

2026-03-27 19:00:44 -07:00

guardian

fix: guard guardian_command_source_tool_name with cfg(unix) (#16498)

2026-04-01 20:16:44 -07:00

instructions

Extract codex-core-skills crate (#15749)

2026-03-25 12:57:42 -07:00

memories

chore: clean up argument-comment lint and roll out all-target CI on macOS (#16054)

2026-03-27 19:00:44 -07:00

models_manager

login: treat provider auth refresh_interval_ms=0 as no auto-refresh (#16480)

2026-04-01 15:30:10 -07:00

plugins

codex-tools: extract discoverable tool models (#16254)

2026-03-30 10:48:49 -07:00

sandboxing

fix(core) rm execute_exec_request sandbox_policy (#16422)

2026-04-01 11:03:48 -04:00

snapshots

[codex] Defer fork context injection until first turn (#15699)

2026-03-24 18:34:44 -07:00

state

feat: spawn v2 as inter agent communication (#15985)

2026-03-27 15:45:19 +01:00

tasks

fix(core) rm execute_exec_request sandbox_policy (#16422)

2026-04-01 11:03:48 -04:00

tools

Extract tool-suggest wire helpers into codex-tools (#16499)

2026-04-01 20:49:15 -07:00

unified_exec

chore: clean up argument-comment lint and roll out all-target CI on macOS (#16054)

2026-03-27 19:00:44 -07:00

utils

Extract rollout into its own crate (#15548)

2026-03-24 18:10:53 -07:00

api_bridge_tests.rs

Add auth 401 observability to client bug reports (#14611)

2026-03-14 15:38:51 -07:00

api_bridge.rs

[codex] import token_data from codex-login directly (#15903)

2026-03-26 13:34:02 -07:00

apply_patch_tests.rs

fix: move inline codex-rs/core unit tests into sibling files (#14444)

2026-03-12 08:16:36 -07:00

apply_patch.rs

fix: move inline codex-rs/core unit tests into sibling files (#14444)

2026-03-12 08:16:36 -07:00

arc_monitor_tests.rs

[apps] Use ARC for yolo mode. (#15273)

2026-03-20 21:13:20 +00:00

arc_monitor.rs

[apps] Use ARC for yolo mode. (#15273)

2026-03-20 21:13:20 +00:00

auth_env_telemetry.rs

core: support dynamic auth tokens for model providers (#16288)

2026-03-31 01:37:27 -07:00

client_common_tests.rs

chore: clean up argument-comment lint and roll out all-target CI on macOS (#16054)

2026-03-27 19:00:44 -07:00

client_common.rs

Remove client_common tool re-exports (#16482)

2026-04-01 19:15:15 -07:00

client_tests.rs

chore: clean up argument-comment lint and roll out all-target CI on macOS (#16054)

2026-03-27 19:00:44 -07:00

client.rs

core: support dynamic auth tokens for model providers (#16288)

2026-03-31 01:37:27 -07:00

codex_delegate_tests.rs

fix(guardian): make GuardianAssessmentEvent.action strongly typed (#16448)

2026-04-01 15:42:18 -07:00

codex_delegate.rs

fix(guardian): make GuardianAssessmentEvent.action strongly typed (#16448)

2026-04-01 15:42:18 -07:00

codex_tests_guardian.rs

chore: clean up argument-comment lint and roll out all-target CI on macOS (#16054)

2026-03-27 19:00:44 -07:00

codex_tests.rs

Extract MCP into codex-mcp crate (#15919)

2026-04-01 19:03:26 -07:00

codex_thread.rs

fix: ma2 (#16238)

2026-03-31 11:22:38 +02:00

codex.rs

Extract MCP into codex-mcp crate (#15919)

2026-04-01 19:03:26 -07:00

command_canonicalization_tests.rs

fix: move inline codex-rs/core unit tests into sibling files (#14444)

2026-03-12 08:16:36 -07:00

command_canonicalization.rs

fix: move inline codex-rs/core unit tests into sibling files (#14444)

2026-03-12 08:16:36 -07:00

commit_attribution_tests.rs

chore: clean up argument-comment lint and roll out all-target CI on macOS (#16054)

2026-03-27 19:00:44 -07:00

commit_attribution.rs

fix: move inline codex-rs/core unit tests into sibling files (#14444)

2026-03-12 08:16:36 -07:00

compact_remote.rs

[hooks] use a user message > developer message for prompt continuation (#14867)

2026-03-19 10:53:08 -07:00

compact_tests.rs

chore: clean up argument-comment lint and roll out all-target CI on macOS (#16054)

2026-03-27 19:00:44 -07:00

compact.rs

Move string truncation helpers into codex-utils-string (#15572)

2026-03-24 15:45:40 -07:00

connectors_tests.rs

chore: clean up argument-comment lint and roll out all-target CI on macOS (#16054)

2026-03-27 19:00:44 -07:00

connectors.rs

Extract MCP into codex-mcp crate (#15919)

2026-04-01 19:03:26 -07:00

consequential_tool_message_templates.json

[elicitation] User-friendly tool call messages. (#14403)

2026-03-12 00:35:21 -07:00

contextual_user_message_tests.rs

chore: clean up argument-comment lint and roll out all-target CI on macOS (#16054)

2026-03-27 19:00:44 -07:00

contextual_user_message.rs

Extract codex-instructions crate (#15744)

2026-03-25 10:43:49 -07:00

default_client_forwarding.rs

Move auth code into login crate (#15150)

2026-03-19 18:58:17 -07:00

environment_context_tests.rs

chore: clean up argument-comment lint and roll out all-target CI on macOS (#16054)

2026-03-27 19:00:44 -07:00

environment_context.rs

chore: refactor network permissions to use explicit domain and unix socket rule maps (#15120)

2026-03-27 06:17:59 +00:00

error_tests.rs

Add usage-based business plan types (#15934)

2026-03-27 14:25:13 -07:00

error.rs

Add usage-based business plan types (#15934)

2026-03-27 14:25:13 -07:00

event_mapping_tests.rs

chore: clean up argument-comment lint and roll out all-target CI on macOS (#16054)

2026-03-27 19:00:44 -07:00

event_mapping.rs

Trim pre-turn context updates during rollback (#15577)

2026-03-24 12:43:53 -07:00

exec_env_tests.rs

chore: clean up argument-comment lint and roll out all-target CI on macOS (#16054)

2026-03-27 19:00:44 -07:00

exec_env.rs

fix: move inline codex-rs/core unit tests into sibling files (#14444)

2026-03-12 08:16:36 -07:00

exec_policy_tests.rs

chore: clean up argument-comment lint and roll out all-target CI on macOS (#16054)

2026-03-27 19:00:44 -07:00

exec_policy.rs

fix(core) disable command_might_be_dangerous when unsandboxed (#15036)

2026-03-21 01:28:25 +00:00

exec_tests.rs

chore: clean up argument-comment lint and roll out all-target CI on macOS (#16054)

2026-03-27 19:00:44 -07:00

exec.rs

fix(core) rm execute_exec_request sandbox_policy (#16422)

2026-04-01 11:03:48 -04:00

external_agent_config_tests.rs

chore: clean up argument-comment lint and roll out all-target CI on macOS (#16054)

2026-03-27 19:00:44 -07:00

external_agent_config.rs

Apply argument comment lint across codex-rs (#14652)

2026-03-16 16:48:15 -07:00

file_watcher_tests.rs

chore: clean up argument-comment lint and roll out all-target CI on macOS (#16054)

2026-03-27 19:00:44 -07:00

file_watcher.rs

core: Make FileWatcher reusable (#15093)

2026-03-24 11:04:47 -07:00

flags.rs

…

function_tool.rs

…

git_info_tests.rs

chore: clean up argument-comment lint and roll out all-target CI on macOS (#16054)

2026-03-27 19:00:44 -07:00

hook_runtime.rs

[hooks] add non-streaming (non-stdin style) shell-only PostToolUse support (#15531)

2026-03-25 19:18:03 -07:00

landlock.rs

fix: fix old system bubblewrap compatibility without falling back to vendored bwrap (#15693)

2026-03-25 23:51:39 -07:00

lib.rs

Extract MCP into codex-mcp crate (#15919)

2026-04-01 19:03:26 -07:00

mcp_skill_dependencies.rs

Extract MCP into codex-mcp crate (#15919)

2026-04-01 19:03:26 -07:00

mcp_tool_approval_templates.rs

chore: clean up argument-comment lint and roll out all-target CI on macOS (#16054)

2026-03-27 19:00:44 -07:00

mcp_tool_call_tests.rs

chore: clean up argument-comment lint and roll out all-target CI on macOS (#16054)

2026-03-27 19:00:44 -07:00

mcp_tool_call.rs

[mcp] Bypass read-only tool checks. (#16044)

2026-03-27 15:22:04 -07:00

mcp.rs

Extract MCP into codex-mcp crate (#15919)

2026-04-01 19:03:26 -07:00

memory_trace_tests.rs

fix: move inline codex-rs/core unit tests into sibling files (#14444)

2026-03-12 08:16:36 -07:00

memory_trace.rs

fix: move inline codex-rs/core unit tests into sibling files (#14444)

2026-03-12 08:16:36 -07:00

mention_syntax.rs

Extract codex-utils-plugins crate (#15746)

2026-03-25 11:05:35 -07:00

message_history_tests.rs

chore: clean up argument-comment lint and roll out all-target CI on macOS (#16054)

2026-03-27 19:00:44 -07:00

message_history.rs

feat(tui): restore composer history in app-server tui (#14945)

2026-03-18 11:54:11 -06:00

model_provider_info_tests.rs

login: treat provider auth refresh_interval_ms=0 as no auto-refresh (#16480)

2026-04-01 15:30:10 -07:00

model_provider_info.rs

core: support dynamic auth tokens for model providers (#16288)

2026-03-31 01:37:27 -07:00

network_policy_decision_tests.rs

fix: move inline codex-rs/core unit tests into sibling files (#14444)

2026-03-12 08:16:36 -07:00

network_policy_decision.rs

fix: move inline codex-rs/core unit tests into sibling files (#14444)

2026-03-12 08:16:36 -07:00

network_proxy_loader_tests.rs

chore: clean up argument-comment lint and roll out all-target CI on macOS (#16054)

2026-03-27 19:00:44 -07:00

network_proxy_loader.rs

chore: refactor network permissions to use explicit domain and unix socket rule maps (#15120)

2026-03-27 06:17:59 +00:00

original_image_detail.rs

Extract tool config into codex-tools (#16379)

2026-04-01 13:21:50 -07:00

otel_init.rs

Split features into codex-features crate (#15253)

2026-03-19 20:12:07 -07:00

personality_migration_tests.rs

feat: change multi-agent to use path-like system instead of uuids (#15313)

2026-03-20 18:23:48 +00:00

personality_migration.rs

Apply argument comment lint across codex-rs (#14652)

2026-03-16 16:48:15 -07:00

project_doc_tests.rs

chore: clean up argument-comment lint and roll out all-target CI on macOS (#16054)

2026-03-27 19:00:44 -07:00

project_doc.rs

Use AbsolutePathBuf for cwd state (#15710)

2026-03-25 16:02:22 +00:00

provider_auth.rs

core: support dynamic auth tokens for model providers (#16288)

2026-03-31 01:37:27 -07:00

realtime_context_tests.rs

chore: clean up argument-comment lint and roll out all-target CI on macOS (#16054)

2026-03-27 19:00:44 -07:00

realtime_context.rs

Move string truncation helpers into codex-utils-string (#15572)

2026-03-24 15:45:40 -07:00

realtime_conversation_tests.rs

[stack 2/4] Align main realtime v2 wire and runtime flow (#14830)

2026-03-16 21:38:07 -07:00

realtime_conversation.rs

core: support dynamic auth tokens for model providers (#16288)

2026-03-31 01:37:27 -07:00

response_debug_context.rs

Add auth 401 observability to client bug reports (#14611)

2026-03-14 15:38:51 -07:00

review_format.rs

Apply argument comment lint across codex-rs (#14652)

2026-03-16 16:48:15 -07:00

review_prompts.rs

Use codex-utils-template for review prompts (#16001)

2026-03-27 14:50:01 +01:00

rollout.rs

Extract rollout into its own crate (#15548)

2026-03-24 18:10:53 -07:00

safety_tests.rs

Protect first-time project .codex creation across Linux and macOS sandboxes (#15067)

2026-03-26 16:06:53 -04:00

safety.rs

Extract sandbox manager and transforms into codex-sandboxing (#15603)

2026-03-24 08:20:57 -07:00

sandbox_tags_tests.rs

chore: clean up argument-comment lint and roll out all-target CI on macOS (#16054)

2026-03-27 19:00:44 -07:00

sandbox_tags.rs

Extract sandbox manager and transforms into codex-sandboxing (#15603)

2026-03-24 08:20:57 -07:00

seatbelt.rs

permissions: remove macOS seatbelt extension profiles (#15918)

2026-03-26 17:12:45 -07:00

session_prefix.rs

feat: change multi-agent to use path-like system instead of uuids (#15313)

2026-03-20 18:23:48 +00:00

session_rollout_init_error.rs

Extract rollout into its own crate (#15548)

2026-03-24 18:10:53 -07:00

session_startup_prewarm.rs

fix(core): prevent hanging turn/start due to websocket warming issues (#14838)

2026-03-17 10:07:46 -07:00

shell_detect.rs

chore: rename codex-command to codex-shell-command (#11378)

2026-02-10 17:03:46 -08:00

shell_snapshot_tests.rs

fix: close Bazel argument-comment-lint CI gaps (#16253)

2026-03-30 11:59:50 -07:00

shell_snapshot.rs

feat: add suffix to shell snapshot name (#14938)

2026-03-17 17:59:27 +00:00

shell_tests.rs

chore: clean up argument-comment lint and roll out all-target CI on macOS (#16054)

2026-03-27 19:00:44 -07:00

shell.rs

Apply argument comment lint across codex-rs (#14652)

2026-03-16 16:48:15 -07:00

skills_watcher.rs

chore: clean up argument-comment lint and roll out all-target CI on macOS (#16054)

2026-03-27 19:00:44 -07:00

skills.rs

Extract codex-core-skills crate (#15749)

2026-03-25 12:57:42 -07:00

spawn.rs

sandboxing: plumb split sandbox policies through runtime (#13439)

2026-03-07 02:30:21 +00:00

state_db_bridge.rs

Extract rollout into its own crate (#15548)

2026-03-24 18:10:53 -07:00

stream_events_utils_tests.rs

chore: clean up argument-comment lint and roll out all-target CI on macOS (#16054)

2026-03-27 19:00:44 -07:00

stream_events_utils.rs

Feat/restore image generation history (#15223)

2026-03-19 22:57:16 -07:00

test_support.rs

Add cached environment manager for exec server URL (#15785)

2026-03-25 16:14:36 -07:00

text_encoding_tests.rs

fix: move inline codex-rs/core unit tests into sibling files (#14444)

2026-03-12 08:16:36 -07:00

text_encoding.rs

fix: move inline codex-rs/core unit tests into sibling files (#14444)

2026-03-12 08:16:36 -07:00

thread_manager_tests.rs

chore: clean up argument-comment lint and roll out all-target CI on macOS (#16054)

2026-03-27 19:00:44 -07:00

thread_manager.rs

Add cached environment manager for exec server URL (#15785)

2026-03-25 16:14:36 -07:00

thread_rollout_truncation_tests.rs

fix: update fork boundaries computation (#16322)

2026-03-31 14:10:43 +02:00

thread_rollout_truncation.rs

fix: update fork boundaries computation (#16322)

2026-03-31 14:10:43 +02:00

turn_diff_tracker_tests.rs

fix: move inline codex-rs/core unit tests into sibling files (#14444)

2026-03-12 08:16:36 -07:00

turn_diff_tracker.rs

fix: move inline codex-rs/core unit tests into sibling files (#14444)

2026-03-12 08:16:36 -07:00

turn_metadata_tests.rs

Plumb MCP turn metadata through _meta (#15190)

2026-03-19 22:05:13 +00:00

turn_metadata.rs

Move git utilities into a dedicated crate (#15564)

2026-03-24 13:26:23 -07:00

turn_timing_tests.rs

feat: add memory citation to agent message (#14821)

2026-03-18 10:03:38 +00:00

turn_timing.rs

fix: move inline codex-rs/core unit tests into sibling files (#14444)

2026-03-12 08:16:36 -07:00

user_shell_command_tests.rs

fix: move inline codex-rs/core unit tests into sibling files (#14444)

2026-03-12 08:16:36 -07:00

user_shell_command.rs

fix: move inline codex-rs/core unit tests into sibling files (#14444)

2026-03-12 08:16:36 -07:00

util_tests.rs

chore: clean up argument-comment lint and roll out all-target CI on macOS (#16054)

2026-03-27 19:00:44 -07:00

util.rs

Move auth code into login crate (#15150)

2026-03-19 18:58:17 -07:00

web_search.rs

add missing fields to WebSearchAction and update app-server types (#10276)

2026-01-30 16:37:56 -08:00

windows_sandbox_read_grants_tests.rs

fix: move inline codex-rs/core unit tests into sibling files (#14444)

2026-03-12 08:16:36 -07:00

windows_sandbox_read_grants.rs

fix: move inline codex-rs/core unit tests into sibling files (#14444)

2026-03-12 08:16:36 -07:00

windows_sandbox_tests.rs

chore: clean up argument-comment lint and roll out all-target CI on macOS (#16054)

2026-03-27 19:00:44 -07:00

windows_sandbox.rs

feat(windows-sandbox): add network proxy support (#12220)

2026-03-26 17:27:38 -07:00