Files
codex/codex-rs/tui/src/app/link_hover.rs
T
Felipe Coury bedafe7156 Open subagent transcripts from activity links in the TUI (#62159)
## Why

When a transcript mentions a subagent, readers have to find it in the
sidebar chooser to inspect its work.

## What changed

Underline subagent labels in transcript activity when the sidebar is
available. Clicking a label opens that agent's transcript beside the
parent conversation, including when the link is in an unfocused pane.

Use backend ancestry to confirm that the linked agent belongs to the
current conversation. If a click arrives while agent discovery is in
progress after resume, resolve it when discovery finishes.

## Testing

Cover clicks from the parent transcript and a nested-agent link in an
unfocused pane, along with clicks during discovery and inherited
activity from a fork. Snapshot the underline across a wrapped label.

GitOrigin-RevId: 75b343c56eac4a009d644f0cfc135b6d9bfbe3a0
2026-11-18 02:04:55 +00:00

190 lines
7.2 KiB
Rust

//! Match hover feedback to transcript links and the pane divider. Keep passive link drags with their original view.
//! Recheck after painting so scrolling and live output cannot leave a hand over stale content.
use codex_protocol::ThreadId;
use crossterm::event::KeyModifiers;
use crossterm::event::MouseButton::Left;
use crossterm::event::MouseEvent;
use crossterm::event::MouseEventKind::Drag;
use crossterm::event::MouseEventKind::Moved;
use crossterm::event::MouseEventKind::ScrollDown;
use crossterm::event::MouseEventKind::ScrollUp;
use crossterm::event::MouseEventKind::Up;
use super::App;
use super::side_companion::SideCompanion;
use crate::app_event::AppEvent;
use crate::terminal_hyperlinks::ReaderLink;
use crate::transcript_view::ViewAction;
use crate::tui::PointerShape;
use crate::tui::Tui;
use crate::tui::TuiEvent;
impl App {
pub(super) fn transcript_link_at(&self, mouse: MouseEvent) -> Option<ReaderLink> {
if !mouse.modifiers.is_empty()
&& !mouse
.modifiers
.intersects(KeyModifiers::CONTROL | KeyModifiers::SUPER)
{
return None;
}
if let Some(area) = self.conversation_frame.panel_area()
&& area.contains((mouse.column, mouse.row).into())
&& let Some(pane) = self.sidebar()
{
return pane.visible_link_at(mouse.column, mouse.row);
}
let view = if let Some(panes) = self.conversation_frame.side_pane()
&& panes.passive.contains((mouse.column, mouse.row).into())
{
let passive = &self.side_companions.get(&panes.passive_thread)?.view;
if passive.is_select_mode() {
return None;
}
passive
} else {
&self.transcript_view
};
view.reader_link_at(mouse.column, mouse.row)
}
pub(super) fn handle_passive_transcript_event(
&mut self,
tui: &mut Tui,
id: ThreadId,
event: &TuiEvent,
) -> bool {
let Some(companion) = self.side_companions.get_mut(&id) else {
return false;
};
let view = &mut companion.view;
view.agent_links = self.transcript_view.agent_links;
view.mouse_scroll_speed = self.transcript_view.mouse_scroll_speed;
view.copy_on_select = self.transcript_view.copy_on_select;
view.copy_on_select_clear_selection = self.transcript_view.copy_on_select_clear_selection;
view.primary_selection = self.transcript_view.primary_selection;
let action = match event {
TuiEvent::Mouse(mouse) => view.handle_mouse(*mouse, &companion.cells),
TuiEvent::Key(key) if crate::text_selection::is_copy_key(*key) => view
.handle_selection_key(*key, &companion.cells)
.filter(|action| matches!(action, ViewAction::Copy(_))),
_ => None,
};
let Some(action) = action else {
return false;
};
if let Some((count, result)) = view.copy_action(
tui,
&companion.cells,
&action,
crate::clipboard_copy::CopyFormat::Markdown,
) {
self.transcript_view.show_copy_feedback(&result, count);
} else if let ViewAction::OpenLink(url) = action {
self.open_url_in_browser(url);
} else if let ViewAction::OpenAgent(agent) = action
&& let Some(backend) = view.agent_links
{
self.app_event_tx.send(AppEvent::OpenSidebarAgent {
backend,
source: id,
agent,
});
}
tui.frame_requester().schedule_frame();
true
}
pub(super) fn continue_passive_link_drag(
&mut self,
tui: &mut Tui,
event: &TuiEvent,
) -> color_eyre::eyre::Result<bool> {
let Some((id, area)) = self.passive_link_drag else {
return Ok(false);
};
if self.conversation_focus_available(tui) {
match event {
TuiEvent::Draw => {
if let Some(companion) = self.side_companions.get_mut(&id)
&& companion.view.tick_selection(&companion.cells)
{
tui.frame_requester()
.schedule_frame_in(crate::tui::TARGET_FRAME_INTERVAL);
}
return Ok(false);
}
TuiEvent::Mouse(mouse) if mouse.kind == Moved => return Ok(false),
TuiEvent::Mouse(mouse)
if matches!(mouse.kind, Drag(Left) | Up(Left) | ScrollUp | ScrollDown) =>
{
if !matches!(mouse.kind, ScrollUp | ScrollDown)
|| !self
.side_companions
.get(&id)
.is_some_and(SideCompanion::can_scroll_without_refresh)
{
self.refresh_owned_transcript(tui)?;
}
if self
.conversation_frame
.side_pane()
.is_some_and(|panes| panes.passive_thread == id && panes.passive == area)
{
self.handle_passive_transcript_event(tui, id, event);
if mouse.kind == Up(Left) {
self.passive_link_drag = None;
}
return Ok(true);
}
}
_ => {}
}
}
self.passive_link_drag = None;
if let Some(companion) = self.side_companions.get_mut(&id) {
companion.view.end_drag();
} else if self.current_displayed_thread_id() == Some(id) {
self.transcript_view.end_drag();
}
Ok(false)
}
pub(super) fn refresh_link_hover(&self, tui: &mut Tui) -> std::io::Result<()> {
let shape = if tui
.link_hover
.mouse
.is_some_and(|mouse| tui.shortcut_hud_contains(mouse))
|| !tui.is_owned_screen()
|| self.overlay.is_some()
{
PointerShape::Default
} else if self.conversation_focus_available(tui)
&& (self.divider_drag.is_some()
|| tui.link_hover.mouse.is_some_and(|mouse| {
self.conversation_frame
.divider_area()
.is_some_and(|area| area.contains((mouse.column, mouse.row).into()))
&& self.divider_is_settled(tui, tui.terminal.last_known_screen_size.into())
}))
{
PointerShape::Resize
} else if self.chat_widget.no_modal_or_popup_active()
&& tui
.link_hover
.mouse
.is_some_and(|mouse| self.transcript_link_at(mouse).is_some())
{
PointerShape::Link
} else {
PointerShape::Default
};
if (shape == PointerShape::Resize) != (tui.link_hover.shape == PointerShape::Resize) {
tui.frame_requester().schedule_frame();
}
tui.link_hover.shape = shape;
tui.set_pointer_shape(shape)
}
}