Files
codex/codex-rs/tui/src/app/status_line_settings.rs
T
Joe Savona f06700bc5d Add aggregate metrics for status line provider usage (#62041)
## What changed

- Count status line picker openings and successful provider changes with fixed labels for enabling a custom provider, switching custom providers, and returning to the default. Skip unchanged selections and failed saves.
- Apply current analytics consent to the built-in exporter. Suppress built-in reporting for custom environments, unrecognized originators, or custom OpenTelemetry resource attributes and headers, while allowing explicitly configured OTLP collectors.
- Stop recording through the captured collector if the configured metrics exporter changes.

## Testing

Add assertions for picker and provider-change counters, unchanged selections, failed saves, custom resource and header suppression, and exporter changes.

GitOrigin-RevId: 600bc06d6587e83a6ca09241f0285b47d30a331e
2026-11-17 13:10:04 +00:00

68 lines
2.5 KiB
Rust

//! Save the status line provider to the active local user configuration.
use super::App;
use crate::legacy_core::config::edit::ConfigEdit;
use crate::legacy_core::config::edit::ConfigEditsBuilder;
use crate::statusline_provider::StatuslineProvider;
use anyhow::Context;
use codex_config::types::BuiltinStatusLine;
use codex_config::types::StatusLineSelection;
use codex_config::types::StatusLineSelection::Builtin;
use codex_config::types::StatusLineSelection::Mcp;
impl App {
pub(super) async fn save_status_line_provider(
&mut self,
provider: StatusLineSelection,
provider_from_picker: Option<StatuslineProvider>,
) -> anyhow::Result<()> {
let value = match &provider {
Builtin(BuiltinStatusLine::Default) => toml_edit::value("default"),
Mcp(id) => {
let table = toml_edit::InlineTable::from_iter([
("server", id.server.as_str()),
("tool", id.tool.as_str()),
]);
toml_edit::value(table)
}
};
ConfigEditsBuilder::for_config_path(self.local_settings.user_config_path.as_path())
.with_edits([ConfigEdit::SetPath {
segments: vec!["tui".into(), "status_line_provider".into()],
value,
}])
.apply()
.await
.context("Failed to save status line provider")?;
let previous = self
.local_settings
.tui
.status_line_provider
.as_deref()
.unwrap_or(&Builtin(BuiltinStatusLine::Default));
let change = match (previous, &provider) {
(Builtin(_), Mcp(_)) => Some("enabled_custom"),
(Mcp(_), Builtin(_)) => Some("returned_to_default"),
(Mcp(old), Mcp(new)) if old != new => Some("switched_custom"),
(Builtin(_), Builtin(_)) | (Mcp(_), Mcp(_)) => None,
};
if let Some(change) = change {
self.statusline_metrics.record(
&self.config,
"codex.statusline.provider_changed",
&[("change", change)],
);
}
self.local_settings.tui.status_line_provider = Some(Box::new(provider.clone()));
self.chat_widget.local_settings.tui.status_line_provider = Some(Box::new(provider));
self.chat_widget
.reselect_statusline_provider(provider_from_picker);
Ok(())
}
}
#[cfg(test)]
#[path = "status_line_settings_tests.rs"]
mod tests;