mirror of
https://github.com/openai/codex.git
synced 2026-10-25 18:28:38 +00:00
pmccrary-oai
daa48072f4
## Why Token-budget sessions need a way to recover prior conversation context and preserve working state across context-window transitions. ## What changed - Add direct-model `history` tools for listing windows and items, reading items, and searching conversation contents. - Add direct-model `notes` tools for listing, reading, searching, appending, and writing persistent notes. - Route tool calls through the configured Codex backend with trusted session and agent context, bounded request arguments, and truncation-aware output handling. - Expose the extension when `features.token_budget.use_history_notes_history` is enabled with an OpenAI provider and Codex backend authentication. ## Testing - Cover tool registration, configuration changes, provider and authentication requirements, backend request context, encrypted output preservation, and request and response limits. GitOrigin-RevId: 43b259f01014ba3f30803dd7cd5634942407a9bb
84 lines
2.6 KiB
Rust
84 lines
2.6 KiB
Rust
use codex_protocol::models::FunctionCallOutputContentItem;
|
|
use codex_protocol::models::ResponseInputItem;
|
|
use codex_tools::FunctionCallError;
|
|
use codex_tools::ToolOutput;
|
|
use codex_tools::ToolPayload;
|
|
use codex_utils_output_truncation::TruncationPolicy;
|
|
use pretty_assertions::assert_eq;
|
|
use serde_json::json;
|
|
|
|
use super::HistoryNotesAction;
|
|
use super::HistoryNotesToolOutput;
|
|
|
|
#[test]
|
|
fn preserves_encrypted_history_output() {
|
|
let result = HistoryNotesToolOutput::new(
|
|
json!({"encrypted_output": "enc_payload"}),
|
|
TruncationPolicy::Bytes(1024),
|
|
)
|
|
.expect("bounded encrypted output should be accepted")
|
|
.to_response_item(
|
|
"call-1",
|
|
&ToolPayload::Function {
|
|
arguments: "{}".to_string(),
|
|
},
|
|
);
|
|
|
|
let ResponseInputItem::FunctionCallOutput { output, .. } = result else {
|
|
panic!("expected function-call output");
|
|
};
|
|
assert_eq!(
|
|
output.content_items(),
|
|
Some(
|
|
[FunctionCallOutputContentItem::EncryptedContent {
|
|
encrypted_content: "enc_payload".to_string(),
|
|
}]
|
|
.as_slice()
|
|
)
|
|
);
|
|
}
|
|
|
|
#[test]
|
|
fn rejects_encrypted_history_output_over_the_tool_limit() {
|
|
assert_eq!(
|
|
HistoryNotesToolOutput::new(
|
|
json!({"encrypted_output": "x".repeat(1025)}),
|
|
TruncationPolicy::Bytes(1024),
|
|
)
|
|
.err(),
|
|
Some(FunctionCallError::RespondToModel(
|
|
"History returned an encrypted result larger than the 1024-byte tool-output limit; retry with narrower bounds".to_string()
|
|
))
|
|
);
|
|
assert_eq!(
|
|
HistoryNotesToolOutput::new(
|
|
json!({"encrypted_output": "x".repeat(40_001)}),
|
|
TruncationPolicy::Tokens(20_000),
|
|
)
|
|
.err(),
|
|
Some(FunctionCallError::RespondToModel(
|
|
"History returned an encrypted result larger than the 40000-byte tool-output limit; retry with narrower bounds".to_string()
|
|
))
|
|
);
|
|
}
|
|
|
|
#[test]
|
|
fn rejects_history_request_limits_before_sending_them() {
|
|
assert_eq!(
|
|
HistoryNotesAction::HistoryListItems
|
|
.validate_arguments(&json!({"limit": 21, "max_chars_per_item": 2_000}))
|
|
.err(),
|
|
Some(FunctionCallError::RespondToModel(
|
|
"History argument `limit` exceeds the maximum of 20".to_string()
|
|
))
|
|
);
|
|
assert_eq!(
|
|
HistoryNotesAction::NotesSearchContents
|
|
.validate_arguments(&json!({"query": "x".repeat(1001)}))
|
|
.err(),
|
|
Some(FunctionCallError::RespondToModel(
|
|
"History argument `query` exceeds the maximum of 1000 characters".to_string()
|
|
))
|
|
);
|
|
}
|