mirror of
https://github.com/openai/codex.git
synced 2026-09-06 15:29:32 +00:00
2b5bdcf675
## Why Agent Plugins use a schema-declared root `plugin.json` and can have dotted names or versions that do not fit Codex's directory-safe version format. The packaging and installation paths still assumed the legacy manifest layout and identifier rules. ## What changed - Recognize valid root Agent Plugin manifests when discovering, packing, and installing plugins, while leaving unrelated root manifests on the legacy path. - Accept safe dotted plugin names, default missing Agent Plugin versions to `1.0.0`, and derive stable directory-safe versions when necessary without rewriting the portable manifest. - Skip legacy command migration for Agent Plugins and reject symlinks or other unsupported file types while copying plugin sources. ## Testing Add coverage for portable bundle round trips, manifest discovery, dotted names, version handling, command preservation, and symlink rejection. GitOrigin-RevId: 61476c4c4100495842253d8b429c0b896490962d
35 lines
1.1 KiB
Rust
35 lines
1.1 KiB
Rust
use super::PluginId;
|
|
|
|
#[test]
|
|
fn accepts_dotted_plugin_names() {
|
|
let plugin_id =
|
|
PluginId::new("acme.tools".to_string(), "marketplace".to_string()).expect("plugin id");
|
|
|
|
assert_eq!(plugin_id.as_key(), "acme.tools@marketplace");
|
|
}
|
|
|
|
#[test]
|
|
fn marketplace_names_preserve_legacy_character_set() {
|
|
PluginId::new("acme".to_string(), "marketplace_name-1".to_string()).expect("marketplace name");
|
|
|
|
let err = PluginId::new("acme".to_string(), "market.place".to_string())
|
|
.expect_err("dotted marketplace name");
|
|
assert_eq!(
|
|
err.to_string(),
|
|
"invalid marketplace name: only ASCII letters, digits, `_`, and `-` are allowed"
|
|
);
|
|
}
|
|
|
|
#[test]
|
|
fn rejects_dot_path_segments() {
|
|
assert!(PluginId::new(".".to_string(), "marketplace".to_string()).is_err());
|
|
assert!(PluginId::new("plugin".to_string(), "..".to_string()).is_err());
|
|
}
|
|
|
|
#[test]
|
|
fn rejects_dots_that_can_alias_path_segments() {
|
|
for plugin_name in [".plugin", "plugin.", "plugin..name"] {
|
|
assert!(PluginId::new(plugin_name.to_string(), "marketplace".to_string()).is_err());
|
|
}
|
|
}
|