mirror of
https://github.com/openai/codex.git
synced 2026-11-05 20:10:33 +00:00
radai-oai
875a1a78f0
## Why Creating child history before persisting its parent-child relationship can leave history that parent subtree deletion cannot discover, especially when fork startup copies history. A relationship write failure must reject the spawn before child storage is created. ## What changed - Reserve the child thread ID and persist its spawn edge before starting the child. Propagate persistence failures to the caller. - Keep pending relationship writes owned through caller cancellation, and wait for them to finish before closing the edge during cleanup, including when a write commits but reports an error. - Skip edge cleanup when publication was skipped, and reject IDs belonging to running threads before publication. ## Testing Add regression coverage for cancellation before commit or acknowledgement, errors after commit, skipped publication, and duplicate child IDs. Integration tests cover fresh children and full-history forks, verifying that failed publication leaves no child history, execution, or creation notification and preserves unrelated history during parent deletion. GitOrigin-RevId: 6e2e3f32d9558091312651ab47aa845d7d13b4ca
63 lines
2.7 KiB
Rust
63 lines
2.7 KiB
Rust
use std::future::Future;
|
|
use std::pin::Pin;
|
|
|
|
use codex_protocol::ThreadId;
|
|
|
|
use crate::AgentGraphStoreResult;
|
|
use crate::ThreadSpawnEdgeStatus;
|
|
|
|
/// Future returned by [`AgentGraphStore`] operations.
|
|
pub type AgentGraphStoreFuture<'a, T> =
|
|
Pin<Box<dyn Future<Output = AgentGraphStoreResult<T>> + Send + 'a>>;
|
|
|
|
/// Storage-neutral boundary for persisted thread-spawn parent/child topology.
|
|
///
|
|
/// Implementations are expected to return stable ordering for list methods so callers can merge
|
|
/// persisted graph state with live in-memory state without introducing nondeterministic output.
|
|
pub trait AgentGraphStore: Send + Sync {
|
|
/// Insert or replace the directional parent/child edge for a spawned thread.
|
|
///
|
|
/// `child_thread_id` has at most one persisted parent. Re-inserting the same child should
|
|
/// update both the parent and status to match the supplied values.
|
|
/// The edge may be published before the child's metadata or history exists. A successful
|
|
/// write must make the child discoverable through the list methods.
|
|
fn upsert_thread_spawn_edge(
|
|
&self,
|
|
parent_thread_id: ThreadId,
|
|
child_thread_id: ThreadId,
|
|
status: ThreadSpawnEdgeStatus,
|
|
) -> AgentGraphStoreFuture<'_, ()>;
|
|
|
|
/// Update the persisted lifecycle status of a spawned thread's incoming edge.
|
|
///
|
|
/// Implementations should treat missing children as a successful no-op.
|
|
fn set_thread_spawn_edge_status(
|
|
&self,
|
|
child_thread_id: ThreadId,
|
|
status: ThreadSpawnEdgeStatus,
|
|
) -> AgentGraphStoreFuture<'_, ()>;
|
|
|
|
/// List direct spawned children of a parent thread.
|
|
///
|
|
/// When `status_filter` is `Some`, only child edges with that exact status are returned. When
|
|
/// it is `None`, all direct child edges are returned regardless of status, including statuses
|
|
/// that may be added by a future store implementation.
|
|
fn list_thread_spawn_children(
|
|
&self,
|
|
parent_thread_id: ThreadId,
|
|
status_filter: Option<ThreadSpawnEdgeStatus>,
|
|
) -> AgentGraphStoreFuture<'_, Vec<ThreadId>>;
|
|
|
|
/// List spawned descendants breadth-first by depth, then by thread id.
|
|
///
|
|
/// `status_filter` is applied to every traversed edge, not just to the returned descendants.
|
|
/// For example, `Some(Open)` walks only open edges, so descendants under a closed edge are not
|
|
/// included even if their own incoming edge is open. `None` walks and returns every persisted
|
|
/// edge regardless of status.
|
|
fn list_thread_spawn_descendants(
|
|
&self,
|
|
root_thread_id: ThreadId,
|
|
status_filter: Option<ThreadSpawnEdgeStatus>,
|
|
) -> AgentGraphStoreFuture<'_, Vec<ThreadId>>;
|
|
}
|