mirror of
https://github.com/openai/codex.git
synced 2026-10-28 18:58:46 +00:00
ztanner-oai
6562117a81
## Why Slow consumers can lose process output or block control replies when the in-process event queue fills. Descendants can also keep output streams open after the child exits, leaving clients unable to tell whether captured output is complete. ## What changed - Require delivery of `process/outputDelta` and `process/exited` notifications, while allowing process request replies to proceed when event delivery is blocked. - Exclude time spent delivering output to slow clients from the post-exit drain budget, and drain queued bytes after the deadline closes a stream. - Keep draining after an output byte cap is reached so the child can finish writing; abort each stream's reader when its drain deadline expires. - Add optional `outputDrainTimedOut` to `process/exited` and generated bindings. Report incomplete output separately from the child's exit code, treating a fully captured requested byte cap as complete. - Deliver the exit notification before moving Windows console cleanup to a blocking task. ## Testing Add regression coverage for full event queues, stalled consumers issuing process control requests, slow output delivery, inherited pipes, output caps, Windows console descendants, and compatibility with exit notifications that omit `outputDrainTimedOut`. GitOrigin-RevId: 04cfeea5daa7c2b833cdec3f1fff7efeb4d1a86e
48 lines
1.7 KiB
JSON
Generated
48 lines
1.7 KiB
JSON
Generated
{
|
|
"$schema": "http://json-schema.org/draft-07/schema#",
|
|
"description": "Final process exit notification for `process/spawn`.",
|
|
"properties": {
|
|
"exitCode": {
|
|
"description": "Process exit code.",
|
|
"format": "int32",
|
|
"type": "integer"
|
|
},
|
|
"outputDrainTimedOut": {
|
|
"description": "Whether output collection hit its post-exit deadline before seeing EOF or reaching the requested byte cap on either stream. Older servers omit this field.",
|
|
"type": [
|
|
"boolean",
|
|
"null"
|
|
]
|
|
},
|
|
"processHandle": {
|
|
"description": "Client-supplied, connection-scoped `processHandle` from `process/spawn`.",
|
|
"type": "string"
|
|
},
|
|
"stderr": {
|
|
"description": "Buffered stderr capture.\n\nEmpty when stderr was streamed via `process/outputDelta`.",
|
|
"type": "string"
|
|
},
|
|
"stderrCapReached": {
|
|
"description": "Whether stderr reached `outputBytesCap`.\n\nIn streaming mode, stderr is empty and cap state is also reported on the final stderr `process/outputDelta` notification.",
|
|
"type": "boolean"
|
|
},
|
|
"stdout": {
|
|
"description": "Buffered stdout capture.\n\nEmpty when stdout was streamed via `process/outputDelta`.",
|
|
"type": "string"
|
|
},
|
|
"stdoutCapReached": {
|
|
"description": "Whether stdout reached `outputBytesCap`.\n\nIn streaming mode, stdout is empty and cap state is also reported on the final stdout `process/outputDelta` notification.",
|
|
"type": "boolean"
|
|
}
|
|
},
|
|
"required": [
|
|
"exitCode",
|
|
"processHandle",
|
|
"stderr",
|
|
"stderrCapReached",
|
|
"stdout",
|
|
"stdoutCapReached"
|
|
],
|
|
"title": "ProcessExitedNotification",
|
|
"type": "object"
|
|
} |