mirror of
https://github.com/openai/codex.git
synced 2026-10-30 19:18:49 +00:00
jif
2e5ee418ad
## Why Reports from a large thread tree can exceed the rollout attachment limit, making the threads involved in a failed Guardian review harder to diagnose. ## What changed - Prioritize descendants with retained failed reviews when selecting bounded report rollouts, while always preserving the reported thread. - Include each selected thread's available Guardian trunk rollout alongside its conversation rollout. - Add a thread index attachment with selected filenames, bounded omission details, retained failure threads, and the process-wide discarded-record count. - Link failed-review records to their reviewed turn and target item when available. ## Testing - Cover failed-review prioritization, bounded omission metadata, discarded-record accounting, and turn/item linkage in Guardian report records. GitOrigin-RevId: ae7916c27a3c279e899cd5a6ead8a4b7e0cc26a1
54 lines
2.0 KiB
Rust
54 lines
2.0 KiB
Rust
use super::*;
|
|
use pretty_assertions::assert_eq;
|
|
|
|
#[test]
|
|
fn records_keep_recent_failures_and_select_the_requested_tree() {
|
|
let mut records = ReviewRecords::default();
|
|
let root = ThreadId::new();
|
|
let child = ThreadId::new();
|
|
let unrelated = ThreadId::new();
|
|
records.push(child, br#"{"child":"denied"}"#.to_vec());
|
|
records.push(unrelated, br#"{"unrelated":"denied"}"#.to_vec());
|
|
for index in 0..12 {
|
|
records.push(root, format!(r#"{{"root":{index}}}"#).into_bytes());
|
|
}
|
|
let snapshot = records.snapshot(&[root, child]);
|
|
let attachment = snapshot.attachment.expect("task-tree records");
|
|
let expected = std::iter::once("{\"child\":\"denied\"}\n".to_string())
|
|
.chain((4..12).map(|index| format!("{{\"root\":{index}}}\n")))
|
|
.collect::<String>();
|
|
assert_eq!(attachment.buffer, expected.into_bytes());
|
|
assert_eq!(snapshot.thread_ids, vec![root, child]);
|
|
assert_eq!(snapshot.process_discarded_records, 4);
|
|
let unrelated_snapshot = records.snapshot(&[unrelated]);
|
|
assert_eq!(unrelated_snapshot.thread_ids, vec![unrelated]);
|
|
// The diagnostic counter must not be mistaken for tree-specific omissions.
|
|
assert_eq!(unrelated_snapshot.process_discarded_records, 4);
|
|
}
|
|
|
|
#[test]
|
|
fn record_count_and_bytes_are_bounded_across_threads() {
|
|
let mut records = ReviewRecords::default();
|
|
for _ in 0..MAX_RECORDS + 1 {
|
|
records.push(ThreadId::new(), b"{}".to_vec());
|
|
}
|
|
assert_eq!(records.records.len(), MAX_RECORDS);
|
|
let payload = vec![b' '; MAX_BYTES / 3];
|
|
let thread_id = ThreadId::new();
|
|
for _ in 0..4 {
|
|
records.push(thread_id, payload.clone());
|
|
}
|
|
assert!(records.bytes <= MAX_BYTES);
|
|
assert_eq!(records.records.len(), 2);
|
|
assert_eq!(
|
|
records
|
|
.snapshot(&[thread_id])
|
|
.attachment
|
|
.expect("bounded records")
|
|
.buffer
|
|
.len(),
|
|
2 * (payload.len() + 1)
|
|
);
|
|
assert_eq!(records.discarded_records, MAX_RECORDS + 3);
|
|
}
|