mirror of
https://github.com/openai/codex.git
synced 2026-09-08 15:50:34 +00:00
0877afbe85
## Why Compacting a resumed conversation can fail when its previous model is no longer available. Some model-specific failures, such as a model-not-found response, are not represented as invalid requests and therefore did not trigger the existing fallback to the currently selected model. ## What changed - Share a retry predicate between both remote compaction implementations. - Fall back to the current model for invalid requests, unexpected statuses, context-window and usage-limit errors, server failures, and exhausted retries. ## Testing Add an integration test that resumes a conversation whose previous model returns model-not-found and verifies that compaction and the next turn use the renamed model. GitOrigin-RevId: c3857beae2ce79b50589deb13c2e59710ce14725
64 lines
2.0 KiB
Rust
64 lines
2.0 KiB
Rust
use codex_analytics::CompactionImplementation;
|
|
use codex_analytics::CompactionReason;
|
|
use codex_otel::SessionTelemetry;
|
|
use codex_protocol::error::CodexErr;
|
|
use tracing::warn;
|
|
|
|
/// Retries failures that may be model-specific and succeed with a different model.
|
|
pub(crate) fn should_retry_with_current_model(error: &CodexErr) -> bool {
|
|
matches!(
|
|
error,
|
|
CodexErr::InvalidRequest(_)
|
|
| CodexErr::UnexpectedStatus(_)
|
|
| CodexErr::ContextWindowExceeded
|
|
| CodexErr::UsageLimitReached(_)
|
|
| CodexErr::ServerOverloaded
|
|
| CodexErr::InternalServerError
|
|
| CodexErr::RetryLimit(_)
|
|
)
|
|
}
|
|
|
|
pub(crate) fn record_model_fallback(
|
|
session_telemetry: &SessionTelemetry,
|
|
previous_model: &str,
|
|
current_model: &str,
|
|
reason: CompactionReason,
|
|
implementation: CompactionImplementation,
|
|
fallback_error: Option<&CodexErr>,
|
|
) {
|
|
let reason_tag = match reason {
|
|
CompactionReason::UserRequested => "user_requested",
|
|
CompactionReason::ContextLimit => "context_limit",
|
|
CompactionReason::ModelDownshift => "model_downshift",
|
|
CompactionReason::CompHashChanged => "comp_hash_changed",
|
|
};
|
|
let implementation_tag = match implementation {
|
|
CompactionImplementation::Responses => "responses",
|
|
CompactionImplementation::ResponsesCompactionV2 => "responses_compaction_v2",
|
|
CompactionImplementation::ResponsesCompact => "responses_compact",
|
|
};
|
|
let outcome = if fallback_error.is_none() {
|
|
"succeeded"
|
|
} else {
|
|
"failed"
|
|
};
|
|
session_telemetry.counter(
|
|
"codex.compaction.model_fallback",
|
|
/*inc*/ 1,
|
|
&[
|
|
("reason", reason_tag),
|
|
("implementation", implementation_tag),
|
|
("outcome", outcome),
|
|
],
|
|
);
|
|
warn!(
|
|
previous_model,
|
|
current_model,
|
|
?reason,
|
|
?implementation,
|
|
outcome,
|
|
?fallback_error,
|
|
"previous-model compaction failed; retried with current model"
|
|
);
|
|
}
|